Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Michal Privoznik
On 26.09.2012 22:46, Anthony Liguori wrote: > Michal Privoznik writes: > >> On 25.09.2012 19:08, Doug Goldstein wrote: >>> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >>> wrote: On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: > On 09/25/2012 06:54 AM, Daniel P. Berr

Re: [Qemu-devel] [PATCH v9 4/4] block: Support GlusterFS as a QEMU block backend.

2012-09-26 Thread Bharata B Rao
On Wed, Sep 26, 2012 at 06:38:02PM +0200, Paolo Bonzini wrote: > Il 26/09/2012 18:11, Bharata B Rao ha scritto: > >>> +static int parse_volume_options(GlusterConf *gconf, char *path) > >>> > > +{ > >>> > > +char *token, *saveptr; > >>> > > + > >>> > > +/* volname */ > >>> > > +token = s

Re: [Qemu-devel] [PATCH 2/2] tcg/arm: Implement movcond_i32

2012-09-26 Thread Paolo Bonzini
Il 26/09/2012 20:48, Peter Maydell ha scritto: > Implement movcond_i32 for ARM, as the sequence > mov dst, v2 (implicitly done by the tcg common code) > cmp c1, c2 > movCC dst, v1 Should you make tcg/optimize.c prefer "movcond a, a, b" to "movcond a, b, a", similar to commit c2b0e2f (tcg/o

Re: [Qemu-devel] [PATCH 0/2] add pci-serial device.

2012-09-26 Thread Gerd Hoffmann
Hi, > Understood, but I'd really prefer a file in docs/. We should be > rigorous about having formal specs for all of our paravirtual devices. > The code shouldn't be the spec. Well, pci-serial and pci-bridge are *not* paravirtual devices. They follow a specification describing the programmin

[Qemu-devel] [RFC v2 3/7] qemu-option: qemu_opts_validate(): fix duplicated code

2012-09-26 Thread Dong Xu Wang
Use opts_accepts_any() and find_desc_by_name(). Signed-off-by: Luiz Capitulino Signed-off-by: Dong Xu Wang --- qemu-option.c | 14 +++--- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index d8b0988..b7baacc 100644 --- a/qemu-option.c +++

[Qemu-devel] [RFC v2 2/7] qemu-option: opt_set(): split it up into more functions

2012-09-26 Thread Dong Xu Wang
The new functions are opts_accepts_any() and find_desc_by_name(), which are also going to be used by qemu_opts_validate() (see next commit). This also makes opt_set() slightly more readable. Signed-off-by: Luiz Capitulino Signed-off-by: Dong Xu Wang --- qemu-option.c | 40 +++

[Qemu-devel] [RFC v2 1/7] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-09-26 Thread Dong Xu Wang
Call qemu_opt_set() instead of duplicating opt_set(). It will set opt->str in qemu_opt_set_bool, without opt->str, there will be some potential bugs. These are uses of opt->str, and what happens when it isn't set: * qemu_opt_get(): returns NULL, which means "not set". Bug can bite when value

[Qemu-devel] [PATCH] cpu: Add missing 'static' attribute to qemu_global_mutex

2012-09-26 Thread Stefan Weil
Contrary to its name, 'qemu_global_mutex' is only used locally in cpus.c. Signed-off-by: Stefan Weil --- cpus.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index 33da623..348b414 100644 --- a/cpus.c +++ b/cpus.c @@ -613,7 +613,7 @@ static void qemu_tcg_

[Qemu-devel] [RFC v2 6/7] create new function: qemu_opt_set_number

2012-09-26 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang --- qemu-option.c |8 qemu-option.h |1 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 818408b..2b52576 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -678,6 +678,14 @@ int qemu_opt_set_bool(Qemu

[Qemu-devel] [RFC v2 4/7] introduce qemu_opts_create_nofail function

2012-09-26 Thread Dong Xu Wang
While id is NULL, qemu_opts_create can not fail, so ignore errors is fine. Signed-off-by: Dong Xu Wang --- qemu-option.c |5 + qemu-option.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index b7baacc..818408b 100644 --- a/qemu-opt

[Qemu-devel] [RFC v2 7/7] remove QEMUOptionParameter

2012-09-26 Thread Dong Xu Wang
remove QEMUOptionParameter, and use QemuOpts and QemuOptsList. Signed-off-by: Dong Xu Wang --- block.c | 88 ++-- block.h |5 +- block/Makefile.objs |9 +- block/qcow2.c | 175 --- block/raw-posix.c | 68 - block/ra

[Qemu-devel] [RFC v2 5/7] use qemu_opts_create_nofail

2012-09-26 Thread Dong Xu Wang
use qemu_opts_create_nofail while id is NULL. Signed-off-by: Dong Xu Wang --- blockdev.c |2 +- hw/watchdog.c |2 +- qemu-config.c |4 ++-- qemu-img.c |2 +- qemu-sockets.c |8 vl.c |6 +++--- 6 files changed, 12 insertions(+), 12 deletions(-)

[Qemu-devel] [RFC v2 0/7] replace QEMUOptionParameter with QemuOpts parser

2012-09-26 Thread Dong Xu Wang
This is still a RFC, I cut some block image formats to simplify the exploring. patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html patch 4-5: because qemu_opts_create can not fail while id is null

Re: [Qemu-devel] [RFC PATCH v3 09/19] pc: Add dimm paravirt SRAT info

2012-09-26 Thread Wen Congyang
At 09/21/2012 07:17 PM, Vasilis Liaskovitis Wrote: > The numa_fw_cfg paravirt interface is extended to include SRAT information for > all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, > denoting start address, size and node proximity. The new info is appended > after > e

Re: [Qemu-devel] [big lock] Discussion about the convention of device's DMA each other after breaking down biglock

2012-09-26 Thread liu ping fan
On Mon, Sep 24, 2012 at 5:42 PM, Avi Kivity wrote: > On 09/24/2012 10:32 AM, liu ping fan wrote: >> On Mon, Sep 24, 2012 at 3:44 PM, Avi Kivity wrote: >>> On 09/24/2012 08:33 AM, liu ping fan wrote: On Wed, Sep 19, 2012 at 5:50 PM, Avi Kivity wrote: > On 09/19/2012 12:34 PM, Jan Kiszka

[Qemu-devel] [PATCH 04/12] tcg-sparc: Fix qemu_st for 32-bit

2012-09-26 Thread Richard Henderson
The datalo variable is still live in the miss path. Use another when reconstructing the full data value. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 9

[Qemu-devel] [PATCH 08/12] tcg-sparc: Optimize setcond2 equality compare with 0.

2012-09-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index b1f3eaf..1618996 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-target.c @@ -693,9 +693,1

[Qemu-devel] [PATCH v3] qemu/xen: Add 64 bits big bar support on qemu

2012-09-26 Thread Xudong Hao
v3 changes from v2: - Refine code following by the qemu code style - As suggestion by Stefano, cheanup code, add some code comment v2 changes from v1: - Rebase to qemu upstream from qemu-xen Currently it is assumed PCI device BAR access < 4G memory. If there is such a device whose BAR size is lar

[Qemu-devel] [PATCH 10/12] tcg-sparc: Dump illegal opode contents

2012-09-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- sparc-dis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sparc-dis.c b/sparc-dis.c index cdd337a..1d017fa 100644 --- a/sparc-dis.c +++ b/sparc-dis.c @@ -3270,6 +3270,6 @@ print_insn_sparc (bfd_vma memaddr, disassemble_info *info) }

[Qemu-devel] [PATCH 03/12] tcg-sparc: Fix setcond2

2012-09-26 Thread Richard Henderson
Like brcond2, use tcg_high_cond. Use movcc instead of branches. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index c10e3b1.

[Qemu-devel] [PATCH 09/12] tcg-sparc: Drop use of Bicc in favor of BPcc

2012-09-26 Thread Richard Henderson
Now that we're always sparcv9, we can not bother using Bicc for 32-bit branches and BPcc for 64-bit branches and instead always use BPcc. New interfaces allow less direct use of tcg_out32 and raw numbers inside the qemu_ld/st routines. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c

[Qemu-devel] [PATCH 07/12] tcg-sparc: Use Z constraint for %g0

2012-09-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 109 ++--- tcg/sparc/tcg-target.h | 5 ++- 2 files changed, 60 insertions(+), 54 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 3154992..b1f3eaf 100644 ---

[Qemu-devel] [PATCH 05/12] tcg-sparc: Fix setcond

2012-09-26 Thread Richard Henderson
The set of comparisons that can immediately use the carry are LTU/GEU, not LTU/LEU. Don't swap operands when we need a temp register; the register may already be in use from setcond2. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 33 +++-- 1 file chan

Re: [Qemu-devel] [PATCH v2 35/45] add hierarchical bitmap data type and test cases

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > HBitmaps provides an array of bits. The bits are stored as usual in an > array of unsigned longs, but HBitmap is also optimized to provide fast > iteration over set bits; going from one bit to the next is O(logB n) > worst case, with B = sizeof(long)

[Qemu-devel] [PATCH V4 5/5] libqblock test example

2012-09-26 Thread Wenchao Xia
In this example, at first it will create some qcow2 images, then get information including backing file relationship. Then it will do sync IO on the image. Signed-off-by: Wenchao Xia --- tests/libqblock/libqblock-qcow2.c | 366 - 1 files changed, 365 insert

[Qemu-devel] [PATCH V4 2/5] libqblock type defines

2012-09-26 Thread Wenchao Xia
This patch contains type and macro defines used in APIs, one file for public usage by user, one for libqblock internal usage. Signed-off-by: Wenchao Xia --- libqblock/libqblock-internal.h | 57 + libqblock/libqblock-types.h| 268 2 files

[Qemu-devel] [PATCH V4 4/5] libqblock test build system

2012-09-26 Thread Wenchao Xia
This patch will create a new directory in ./tests, make check-libqblock will build an executable binary, make clean or make check-clean will delete generated binaries. Signed-off-by: Wenchao Xia --- .gitignore|2 + Makefile |1 + tests/M

[Qemu-devel] [PATCH 12/12] tcg-sparc: Emit MOVR insns for setcond_i64 and movcond_64

2012-09-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 90a041e..72f07f9 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/sparc/tcg-targe

[Qemu-devel] [PATCH 02/12] tcg-sparc: Implement movcond.

2012-09-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 43 --- tcg/sparc/tcg-target.h | 4 ++-- 2 files changed, 38 insertions(+), 9 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 726fb9b..c10e3b1 100644 --- a/tcg/s

[Qemu-devel] [PATCH 06/12] tcg-sparc: Fix add2/sub2

2012-09-26 Thread Richard Henderson
We must care not to clobber the high parts before we consume them. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index c3e15b9..315499

[Qemu-devel] [PATCH 01/12] tcg-sparc: Fix brcond2

2012-09-26 Thread Richard Henderson
Much the same problem as recently fixed for hppa. Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index bb43e83..726fb9b 100644 --- a/tcg/sparc

[Qemu-devel] [PATCH 11/12] tcg-sparc: Emit BPr insns for brcond_i64

2012-09-26 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.c | 49 +++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index f3eb246..90a041e 100644 --- a/tcg/sparc/tcg-target.c +++ b/tcg/s

[Qemu-devel] [PATCH V4 3/5] libqblock API

2012-09-26 Thread Wenchao Xia
This patch contains the major APIs in the library. For ABI some reserved members were used. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockState. It stands for an block image object. 3 QBlockStaticInfo. It contains st

[Qemu-devel] [PATCH V4 1/5] libqblock build system

2012-09-26 Thread Wenchao Xia
Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and third are non PIC and PIC ones in ./libqblock. GCC

[Qemu-devel] [PATCH V4 0/5] libqblock qemu block layer library

2012-09-26 Thread Wenchao Xia
This patch introduce libqblock API, make libqblock.la and make check-libqblock could build this library. Functionalities: 1 create a new image. 2 sync access of an image. 3 basic image information retrieving such as backing file. 4 detect if a sector is allocated in an image. Supported Format

Re: [Qemu-devel] [PATCH V3 1/5] libqblock build system

2012-09-26 Thread Wenchao Xia
于 2012-9-19 17:57, Paolo Bonzini 写道: Il 19/09/2012 08:35, Wenchao Xia ha scritto: +QEMU_OBJS=$(tools-obj-y) $(block-obj-y) +QEMU_OBJS_FILTERED=$(filter %.o,$(QEMU_OBJS)) What does this filter out? $(block-obj-y) contains /block, which would cause trouble in building, so filtered it out.

[Qemu-devel] Proposal for virtio standardization.

2012-09-26 Thread Rusty Russell
Hi all, I've had several requests for a more formal approach to the virtio draft spec, and (after some soul-searching) I'd like to try that. The proposal is to use OASIS as the standards body, as it's fairly light-weight as these things go. For me this means paperwork and setting

[Qemu-devel] [PATCH 00/12] tcg-sparc fixes and improvements

2012-09-26 Thread Richard Henderson
All of this based on testing alpha-softmmu on sparcv8plus and sparcv9. There were 5 problems with sparcv8plus implementing 64-bit opcodes. This patch set is based on the "TCGCond improvments" patch set I've previously posted, primarily for its is_unsigned_cond and tcg_high_cond functions. (http:/

[Qemu-devel] [PATCH] cadence_ttc: Fix 'clear on read' behavior

2012-09-26 Thread Peter Crosthwaite
From: Soren Brinkmann A missing call to qemu_set_irq() when reading the IRQ register required SW to write to the IRQ register to acknowledge an interrupt. With this patch the behavior is fixed: - Reading the interrupt register clears it and updates the timers interrupt status - Writes to the

Re: [Qemu-devel] [PATCH v2] qemu/xen: Add 64 bits big bar support on qemu

2012-09-26 Thread Hao, Xudong
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: Wednesday, September 26, 2012 6:57 PM > To: Hao, Xudong > Cc: Stefano Stabellini; xen-de...@lists.xen.org; qemu-devel@nongnu.org; > Zhang, Xiantao > Subject: RE: [PATCH v2] qemu/xen: Add 64 bit

Re: [Qemu-devel] ARM bootloader boot blobbing.

2012-09-26 Thread Peter Crosthwaite
On Thu, Sep 27, 2012 at 7:52 AM, Edgar E. Iglesias wrote: > On Wed, Sep 26, 2012 at 04:27:57PM +1000, Peter Crosthwaite wrote: >> Hi All, >> >> Can anyone think of a reason why the arm primary bootloader cant be >> done by just direct interaction with the CPU? Currently we have this >> ... >> >> /

Re: [Qemu-devel] [PATCH v2 34/45] host-utils: add ffsl

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > We can provide fast versions based on the other functions defined > by host-utils.h. Some care is required on glibc, which provides > ffsl already. > Why glibc chose for ffsl even though it uses for ffs (per POSIX) is beyond me. At any rate, this

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/6] target-ppc: Extend FPU state for newer POWER CPUs

2012-09-26 Thread David Gibson
On Wed, Sep 26, 2012 at 08:36:45AM +0200, Aurelien Jarno wrote: > On Wed, Sep 26, 2012 at 01:12:18PM +1000, David Gibson wrote: > > This patch adds some extra FPU state to CPUPPCState. Specifically, fpscr > > is extended to 64 bits, since some recent CPUs now have more status bits > > than fit ins

Re: [Qemu-devel] [Qemu-ppc] [0/6] Pending pseries updates

2012-09-26 Thread David Gibson
On Wed, Sep 26, 2012 at 02:59:25PM +0200, Alexander Graf wrote: > > On 26.09.2012, at 05:12, David Gibson wrote: > > > Hi Alex, > > > > Here's another batch of updates for pseries, some of which affect > > wider target-ppc code. I have sent a few of these before, but I don't > > believe any hav

Re: [Qemu-devel] [PATCH v2 29/45] qemu-iotests: add mirroring test case

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > tests/qemu-iotests/040 | 353 > + > tests/qemu-iotests/040.out | 5 + > tests/qemu-iotests/group | 3 +- > 3 file modificati, 360 inserzioni(+). 1 rimozione(-

Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 125 > ++- > hmp-commands.hx | 21 ++ > hmp.c| 28 ++

Re: [Qemu-devel] [PATCH v2 25/45] block: introduce BLOCK_JOB_READY event

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > Even for jobs that need to be manually completed, management may want > to take care itself of the completion, not requiring the user to issue > a command to terminate the job. In this case we want to avoid that > they poll us continuously, waiting fo

Re: [Qemu-devel] [PATCH] CODING_STYLE: Define how to handle acronyms in CamelCase

2012-09-26 Thread Anthony Liguori
Alex Williamson writes: > When creating structure names in CamelCase, it's easy to have > back-to-back capitals when using acronyms (ex. PCIINTxRoutingNotifier, > QEMUSGList, VFIOINTx). In the worst case these can look like macros, > but even adjoining a single, all-caps acronym makes it more di

Re: [Qemu-devel] ARM bootloader boot blobbing.

2012-09-26 Thread Edgar E. Iglesias
On Wed, Sep 26, 2012 at 04:27:57PM +1000, Peter Crosthwaite wrote: > Hi All, > > Can anyone think of a reason why the arm primary bootloader cant be > done by just direct interaction with the CPU? Currently we have this > ... > > /* The worlds second smallest bootloader. Set r0-r2, then jump to

[Qemu-devel] [PATCH 00/22 v3] target-i386: convert CPU features into properties

2012-09-26 Thread Igor Mammedov
git tree for testing: https://github.com/imammedo/qemu/tree/x86-cpu-properties.v3 Depends on: [Qemu-devel] [PATCH 0/5] i386: cpu: remove duplicate feature names http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html Rebased on top of todays qemu tree. Igor Mammedov (22): targ

[Qemu-devel] [PATCH 21/22] target-i386: move default init of cpuid_kvm_features bitmap into CPU initializer from cpudef

2012-09-26 Thread Igor Mammedov
Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. Signed-off-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- [ehabkost: rebase on top of latest qemu.git master, where the bitmap initialization is now differ

[Qemu-devel] [PATCH 11/22] target-i386: convert 'hv_vapic' feature into property

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 079a8e7..42f06bf 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1247,6 +1247,26 @@ static void

[Qemu-devel] [PATCH 19/22] target-i386: use properties to set/unset user specified features on CPU

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- v2: * fix error of initializing from incorrect cpu model definition use x86_cpu_def instead of def. spotted-by: Eduardo Habkost * add missing env in cpu_x86_find_by_name() * added cpu_x86_set_props() to make following code

[Qemu-devel] [PATCH 20/22] target-i386: move init of "hypervisor" feature into CPU initializer from cpudef

2012-09-26 Thread Igor Mammedov
"hypervisor" CPU feature is unconditionally enabled/overridden even if it's cleared in cpudef. Moving it inside CPU initializer from cpudef will help to split cpu_x86_find_by_name() into default init and user settable properties. Signed-off-by: Igor Mammedov --- target-i386/cpu.c |3 +-- 1

Re: [Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-26 Thread Eduardo Habkost
On Wed, Sep 26, 2012 at 02:31:25PM -0700, H. Peter Anvin wrote: > On 09/26/2012 01:32 PM, Igor Mammedov wrote: > > + > > +static void x86_cpuid_get_feature(Object *obj, Visitor *v, void *opaque, > > + const char *name, Error **errp) > > +{ > > +X86CPU *cp

[Qemu-devel] [PATCH 08/22] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)()

2012-09-26 Thread Igor Mammedov
It's needed for the next 3 patches to avoid build breakage when qemu is built with --disable-kvm option. Signed-off-by: Igor Mammedov Reported-by: Eduardo Habkost --- target-i386/hyperv.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/target-i386/hyperv.h b/tar

[Qemu-devel] [PATCH 14/22] target-i386: use visit_type_hz to parse tsc_freq property value

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Andreas Färber --- v2: * use visit_type_freq() which replaced visit_type_hz() --- target-i386/cpu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e663ec1..d36410a 100644 --- a/targ

Re: [Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-26 Thread H. Peter Anvin
On 09/26/2012 01:32 PM, Igor Mammedov wrote: > + > +static void x86_cpuid_get_feature(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) > +{ > +X86CPU *cpu = X86_CPU(obj); > +CPUX86State *env = &cpu->env; > +bool value = t

[Qemu-devel] [PATCH 09/22] target-i386: convert 'hv_spinlocks' feature into property

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 213368b..b215b53 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1203,6 +1203,32 @@ sta

[Qemu-devel] [PATCH 06/22] target-i386: xlevel should be more than 0x80000000, move fixup into setter

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target-i386/cpu.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 50efe5f..a713960 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -973,8 +97

[Qemu-devel] [PATCH 10/22] target-i386: convert 'hv_relaxed' feature into property

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b215b53..079a8e7 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1227,6 +1227,26 @@ static void

[Qemu-devel] [PATCH 16/22] target-i386: use define for cpuid vendor string size

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c |6 +++--- target-i386/cpu.h |2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 4f333e9..5c7c5a5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1102,13 +1102,13 @@

[Qemu-devel] [PATCH 02/22] target-i386: cpu_x86_register(): report error from property setter

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- v2: - replace "if (error_is_set(&error))" with "if (error)" --- target-i386/cpu.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e1e2346..8d3edbf 100644 --- a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/6] pseries: Implement PAPR NVRAM

2012-09-26 Thread Alexander Graf
On 26.09.2012, at 14:55, Alexander Graf wrote: > > On 26.09.2012, at 05:12, David Gibson wrote: > >> The PAPR specification requires a certain amount of NVRAM, accessed via >> RTAS, which we don't currently implement in qemu. This patch addresses >> this deficiency, implementing the NVRAM as a

[Qemu-devel] [PATCH 13/22] add visitor for parsing hz[KMG] input string

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- v2: * replaced _hz suffix for frequency visitor by _freq suffix suggested-by: Andreas Färber * fixed typo & extra space spotted-by: Andreas Färber * initialize val, due to a silly CentOS6 compiler warning, that breakes build

[Qemu-devel] [PATCH 01/22] target-i386: return Error from cpu_x86_find_by_name()

2012-09-26 Thread Igor Mammedov
it will allow to use property setters there later. Signed-off-by: Igor Mammedov Reviewed-by: Don Slutz Reviewed-by: Eduardo Habkost -- v2: - style change, add braces (reqested by Blue Swirl) - removed unused error_is_set(errp) in properties set loop --- target-i386/cpu.c | 15 +++

[Qemu-devel] [PATCH 15/22] target-i386: introduce vendor-override property

2012-09-26 Thread Igor Mammedov
currently 'cpuid_vendor_override' can be set only via cmd line cpu_model string. But setting it in 'vendor' property prevents using 'vendor' property on its own without setting cpuid_vendor_override. So fix/remove enabling cpuid_vendor_override from "vendor" property setter. It's up-to cpu_model s

Re: [Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex

2012-09-26 Thread Eric Blake
On 09/26/2012 02:25 PM, Luiz Capitulino wrote: > o v3 > > - doc & log fixups > - rename KeyCode.hex to KeyCode.number > > This actually fixes a regression introduced by the qapi conversion, > please refer to patch 2/3 for details. > > It's also important to note that this series changes the QM

[Qemu-devel] [PATCH 05/22] target-i386: move out CPU features initialization in separate func

2012-09-26 Thread Igor Mammedov
later it could be used in cpu_x86_find_by_name() to init CPU from found cpu_def Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- v2: - rebased on top of "i386: cpu: remove duplicate feature names" http://www.mail-archive.com/qemu-devel@nongnu.org/msg129458.html --- target-

[Qemu-devel] [PATCH 22/22] target-i386: cleanup cpu_x86_find_by_name(), only fill x86_def_t in it

2012-09-26 Thread Igor Mammedov
Do in cpu_x86_find_by_name() only what name implies. i.e. leave only cpudef search and copy/fill passed in x86_def_t structure. and move out of it cpu_model parsing and CPU initializing into cpu_x86_register(). Plus add hints to where blocks should go when cpu_x86_register() is disbanded. Signed-

[Qemu-devel] [PATCH 17/22] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

2012-09-26 Thread Igor Mammedov
Vendor property setter takes string as vendor value but cpudefs use uint32_t vendor[123] fields to define vendor value. It makes it difficult to unify and use property setter for values from cpudefs. Simplify code by using vendor property setter, vendor[123] fields are converted into vendor[13] ar

[Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties

2012-09-26 Thread Igor Mammedov
cpu_model string does represent features in following format: ([+-]feat)|(feat=foo)|(feat) which makes it impossible directly use property infrastructure to set features on CPU. This patch introduces parser that splits CPU name from cpu_model and converts legacy features string into canonized set

Re: [Qemu-devel] [PATCH v2 15/45] stream: add on-error argument

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > This patch adds support for error management to streaming. > > Signed-off-by: Paolo Bonzini > --- > block/stream.c | 28 +++- > block_int.h | 3 ++- > blockdev.c | 11 --- > hmp.c| 3 ++- >

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-26 Thread Alexander Graf
On 26.09.2012, at 22:03, Anthony Liguori wrote: > Alexander Graf writes: > >> On 22.09.2012, at 15:31, Blue Swirl wrote: >> >>> On Fri, Sep 21, 2012 at 3:08 AM, David Gibson >>> wrote: Below is a patch which implements the (PAPR mandated) NVRAM for the pseries machine. It raises

Re: [Qemu-devel] [PATCH v2 0/3] qmp/hmp: dump-guest-memory fixes

2012-09-26 Thread Eric Blake
On 09/26/2012 12:56 PM, Luiz Capitulino wrote: > Please, check individual patches for details. > > v2 > > - Fix TAB/spaces in qapi-schema.json > - English fixes > - Use g_strconcat() (instead of a qstring) > > Luiz Capitulino (3): > qmp: dump-guest-memory: improve schema doc (again) > qmp

Re: [Qemu-devel] [libvirt] [PATCH 0/2] Fixed QEMU 1.0.1 support

2012-09-26 Thread Anthony Liguori
Michal Privoznik writes: > On 25.09.2012 19:08, Doug Goldstein wrote: >> On Tue, Sep 25, 2012 at 12:01 PM, Daniel P. Berrange >> wrote: >>> On Tue, Sep 25, 2012 at 10:57:23AM -0600, Eric Blake wrote: On 09/25/2012 06:54 AM, Daniel P. Berrange wrote: > On Tue, Sep 25, 2012 at 02:49:00PM

[Qemu-devel] [PATCH 12/22] target-i386: convert 'check' and 'enforce' features into properties

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov -- v2: * restore original behavior, check features against host before they might be filtered out by TCG masks. spotted-by: Eduardo Habkost --- target-i386/cpu.c | 68 1 files changed, 57 insertions(+), 11 d

[Qemu-devel] [PATCH 07/22] target-i386: convert cpuid features into properties

2012-09-26 Thread Igor Mammedov
add property accessors for cpuid feature bits defined by *_feature_name arrays. Signed-off-by: Igor Mammedov --- v2: * replaced mask/ffs tricks by plain 'for (bit = 0; bit < 32; bit++)' as suggested by Eduardo Habkost v3: * check if property exists before adding it * rebased on top of

[Qemu-devel] [PATCH 04/22] target-i386: filter out not TCG features if running without kvm at realize time

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 25 ++--- 1 files changed, 14 insertions(+), 11 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 8d3edbf..f9900af 100644 --- a/target-i386

[Qemu-devel] [PATCH 03/22] target-i386: if x86_cpu_realize() failed report error and do cleanup

2012-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Acked-by: Andreas Färber --- v2: - replaced "if (error_is_set(&error))" with "if (error)" --- target-i386/helper.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index 8a5da3d..3038198

[Qemu-devel] [PATCH 3/3] input: index_from_key(): drop unused code

2012-09-26 Thread Luiz Capitulino
The hex key conversion is unused since last commit. Signed-off-by: Luiz Capitulino --- input.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/input.c b/input.c index 76ade64..25d3973 100644 --- a/input.c +++ b/input.c @@ -186,8 +186,7 @@ static const int key_d

[Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex

2012-09-26 Thread Luiz Capitulino
Before the qapi conversion, the sendkey command could be used to send key codes in hex directly to the guest. In HMP, this would be like: (qemu) sendkey 0xdc However, the qapi conversion broke this, as it only supports sending QKeyCode values to the guest. That's a regression. This commit fixes

[Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify

2012-09-26 Thread Luiz Capitulino
The current code duplicates the QKeyCodeList keys in order to store the key values for release_keys() late run. This is a bit complicated though, as we have to care about correct ordering and then release_keys() will have to index key_defs[] over again. Switch to an array of integers, which is dyn

[Qemu-devel] [PATCH v3 0/3] qmp: send-key: accept key codes in hex

2012-09-26 Thread Luiz Capitulino
o v3 - doc & log fixups - rename KeyCode.hex to KeyCode.number This actually fixes a regression introduced by the qapi conversion, please refer to patch 2/3 for details. It's also important to note that this series changes the QMP interface for the send-key command, but this shouldn't be a pro

Re: [Qemu-devel] [PATCH 01/22] target-i386: return Error from cpu_x86_find_by_name()

2012-09-26 Thread Igor Mammedov
Looks like mail server suffered failure. I'll try to repost later. --- - The following addresses had permanent fatal errors - - Transcript of session follows - 550 5.1.2 ... Host unknown (Name server: eggs.gnu.org.: host not found)

Re: [Qemu-devel] [PATCH] x86: Implement SMEP and SMAP

2012-09-26 Thread Anthony Liguori
"H. Peter Anvin" writes: > From: "H. Peter Anvin" > > This patch implements Supervisor Mode Execution Prevention (SMEP) and > Supervisor Mode Access Prevention (SMAP) for x86. The purpose of the > patch, obviously, is to help kernel developers debug the support for > those features. > > A fair

[Qemu-devel] [PATCH v2] x86: Implement SMEP and SMAP

2012-09-26 Thread H. Peter Anvin
From: "H. Peter Anvin" This patch implements Supervisor Mode Execution Prevention (SMEP) and Supervisor Mode Access Prevention (SMAP) for x86. The purpose of the patch, obviously, is to help kernel developers debug the support for those features. A fair bit of the code relates to the handling o

Re: [Qemu-devel] [PATCH] x86: Implement SMEP and SMAP

2012-09-26 Thread H. Peter Anvin
On 09/26/2012 12:50 PM, Anthony Liguori wrote: > > The patch looks good except for these two chunks. This would break live > migration from a new QEMU to an old one because CPUs are currently not > versioned. > > If you just remove these two chunks, the patch can be applied and you > can still t

Re: [Qemu-devel] [PATCH] New syscalls to the seccomp whitelist

2012-09-26 Thread Paul Moore
On Friday, September 21, 2012 09:40:33 AM Eduardo Otubo wrote: > Seccomp syscall whitelist updated after tests running qemu under > libvirt. Reference to the bug - > https://bugzilla.redhat.com/show_bug.cgi?id=855162 Unfortunately, this patch still does not work correctly for me using F17/libvirt

[Qemu-devel] [PATCH] configure: Support empty target list (--target-list=)

2012-09-26 Thread Stefan Weil
Specifying an empty target list with --target-list= is shorter than specifying --disable-user --disable-system. Both variants should give the same result: no targets at all. This modification implements that feature. It uses a trick which works with POSIX compliant shells to test whether target_

Re: [Qemu-devel] [Qemu-ppc] RFC: NVRAM for pseries machine

2012-09-26 Thread Anthony Liguori
Alexander Graf writes: > On 22.09.2012, at 15:31, Blue Swirl wrote: > >> On Fri, Sep 21, 2012 at 3:08 AM, David Gibson >> wrote: >>> Below is a patch which implements the (PAPR mandated) NVRAM for the >>> pseries machine. It raises a couple of generic questions. >>> >>> First, this adds a new

[Qemu-devel] [PATCH 01/22] target-i386: return Error from cpu_x86_find_by_name()

2012-09-26 Thread Igor Mammedov
it will allow to use property setters there later. Signed-off-by: Igor Mammedov Reviewed-by: Don Slutz Reviewed-by: Eduardo Habkost -- v2: - style change, add braces (reqested by Blue Swirl) - removed unused error_is_set(errp) in properties set loop --- target-i386/cpu.c | 15 +++

Re: [Qemu-devel] [PATCH 1/2] tcg/arm: Factor out code to emit immediate or reg-reg op

2012-09-26 Thread Peter Maydell
On 26 September 2012 20:01, Richard Henderson wrote: > On 09/26/2012 11:48 AM, Peter Maydell wrote: >> case INDEX_op_setcond_i32: >> -if (const_args[2]) { >> -int rot; >> -rot = encode_imm(args[2]); >> -tcg_out_dat_imm(s, COND_AL, ARITH_CMP, 0, >> -

Re: [Qemu-devel] [PATCH 1/4] s390: sclp base support

2012-09-26 Thread Alexander Graf
On 26.09.2012, at 21:25, Christian Borntraeger wrote: > On 26/09/12 21:01, Alexander Graf wrote: >> >> On 26.09.2012, at 18:06, Christian Borntraeger wrote: >> >>> On 26/09/12 17:00, Alexander Graf wrote: >>> > +/* Provide information about the configuration, CPUs and storage */ > +sta

Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error

2012-09-26 Thread Eric Blake
On 09/26/2012 01:10 PM, Eric Blake wrote: >> +Emitted when a block job encounters an error. >> + >> +Data: >> + >> +- "device": device name (json-string) >> +- "operation": I/O operation (json-string, "read" or "write") > > For symmetry with BLOCK_JOB_{CANCELLED,COMPLETED}, you also need: > - "ty

Re: [Qemu-devel] [PATCH 1/4] s390: sclp base support

2012-09-26 Thread Christian Borntraeger
On 26/09/12 21:01, Alexander Graf wrote: > > On 26.09.2012, at 18:06, Christian Borntraeger wrote: > >> On 26/09/12 17:00, Alexander Graf wrote: >> +/* Provide information about the configuration, CPUs and storage */ +static void read_SCP_info(SCCB *sccb) +{ +ReadInfo *rea

[Qemu-devel] [PATCH 0/2] tcg/arm: Implement movcond_i32

2012-09-26 Thread Peter Maydell
These patches implement movcond_i32 for the ARM TCG backend; we emit "mov dst, v2; cmp c1, c2; movcc dst, v1". We could have done this with a pair of conditional movs, but (a) this is not actually any shorter (b) it means we don't get the common TCG code doing the work of avoiding "mov reg to itsel

[Qemu-devel] [PATCH v2 0/3] qmp/hmp: dump-guest-memory fixes

2012-09-26 Thread Luiz Capitulino
Please, check individual patches for details. v2 - Fix TAB/spaces in qapi-schema.json - English fixes - Use g_strconcat() (instead of a qstring) Luiz Capitulino (3): qmp: dump-guest-memory: improve schema doc (again) qmp: dump-guest-memory: don't spin if non-blocking fd would block hmp:

Re: [Qemu-devel] [PATCH v4] Align PCI capabilities in pci_find_space

2012-09-26 Thread Alex Williamson
On Wed, 2012-09-26 at 13:51 -0500, Matt Renzelmann wrote: > The current implementation of pci_find_space does not correctly align > PCI capabilities in the PCI configuration space. It also does not > support PCI-Express devices. This patch fixes these issues. > > Thanks to Alex Williamson for fe

Re: [Qemu-devel] [PATCH v2 14/45] block: introduce block job error

2012-09-26 Thread Eric Blake
On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > The following behaviors are possible: > > 'report': The behavior is the same as in 1.1. An I/O error, > respectively during a read or a write, will complete the job immediately > with an error code. > > 'ignore': An I/O error, respectively during a

  1   2   3   >