Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote:
> Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe
> it would be nicer to do it in one go instead (after splitting off the
> arp_requested renaming)?
Please discuss about it with the people who asked for it. I won't
rev
Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote:
> > +switch (iph->ip_v) {
> > +case IPVERSION:
> > if (iph->ip_dst.s_addr == 0) {
> > /* 0.0.0.0 can not be a destination address, something went wrong,
> > * avoid making it worse */
>
> That indentation looks
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 11/12/2015 14:42, Eric Blake wrote:
>>> compiles and is pretty much a 1:1 translation from the qjson.c
>>> API to the visitor API (using this patch as a guide). Feel
>>> free to include it and remove qjson.c. Alternatively, you can
>>> leave o
On 11/12/15 14:38, Thomas Huth wrote:
> On 11/12/15 01:15, Samuel Thibault wrote:
>> From: Guillaume Subiron
>>
>> Basically, this patch replaces "arp" by "resolution" every time "arp"
>> means "mac resolution" and not specifically ARP.
>>
>> Some indentation problems are solved in functions that
On 12/11/2015 04:10 AM, Paolo Bonzini wrote:
>
>
> On 11/12/2015 00:53, Eric Blake wrote:
>> Instead of rolling our own limited JSON outputter, we can just
>> wrap the more full-featured JSON output Visitor.
>>
>> This slightly changes the output (different spacing), but the
>> result is still eq
Hi; I noticed while grepping through code that the version of
tcg_liveness_analysis() in tcg/tcg.c for #ifndef USE_LIVENESS_ANALYSIS
won't compile because it's still referring to the no-longer-existent
TCGContext::gen_opc_buf.
Richard, I think this was probably broken as part of your changes to
us
On 11/12/15 01:15, Samuel Thibault wrote:
> From: Guillaume Subiron
>
> Basically, this patch replaces "arp" by "resolution" every time "arp"
> means "mac resolution" and not specifically ARP.
>
> Some indentation problems are solved in functions that will be modified
> in the next patches (ip_i
On 11 December 2015 at 03:43, Valerón JC wrote:
> I want to trace a bug in tcg, which for me, at some point, generate infinite
> loop TB chains, that's unexpected. and I've found the final TB(head, since
> they're chaining) which run in an infinite loop, and I know a very weird
> trick to 'disable
The VFIO-PCI ioctl VFIO_DEVICE_FLAGS_PCI_MSIX_MMAP flag indicate that
platform support mmapping MSI-X table.
With this flag set, we skip some MSI-X table check so that QEMU can
mmap MSI-X table successfully. And we also raise the priority of mmap
memory region in case of overlap with MSI-X/PBA mem
On 11 December 2015 at 03:27, Eric Blake wrote:
> On my machine, './check -qcow2 028' was failing about 80% of the time,
> due to a race in how many times the repeated attempts to run 'info
> block-jobs' could occur before the job was done, showing up as a
> failure of fewer '(qemu) ' prompts than
The VFIO-PCI ioctl flag VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED indicates platform
support all PCI MMIO BARs to be page aligned and sub-page(size < PAGE_SIZE)
MMIO BARs can be mmapped.
But this has an issue for these mmapped sub-page MMIO BARs - KVM would not
allow to create memory slot for them via io
I have experienced a minor difficulty using QEMU with the "-serial pty" option:
If a process opens the slave pts device, writes data to it, then immediately
closes it, the data doesn't reliably get delivered to the emulated serial port.
This seems to be because a read of the master pty device re
This patch set adds support for two VFIO-PCI ioctl flags:
VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED and VFIO_DEVICE_FLAGS_PCI_MSIX_MMAP.
Note that the kernel bits of this two flags are not in upstream and
posted as .
VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED indicates that platform support
all PCI MMIO BARs to
Some functions was moved from block.c to block/io.c, so the trace-events file
should reflect that change.
Signed-off-by: Qinghua Jin
---
trace-events | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/trace-events b/trace-events
index 2fce98e..bec1aa1 100644
--- a/trace-ev
I want to trace a bug in tcg, which for me, at some point, generate infinite
loop TB chains, that's unexpected. and I've found the final TB(head, since
they're chaining) which run in an infinite loop, and I know a very weird trick
to 'disable' this bug, so I would like to track the tcg-ops for t
Syncup VFIO related linux headers from linux-next tree using
scripts/update-linux-headers.sh.
Integrate two VFIO-PCI ioctl flags:
- VFIO_DEVICE_FLAGS_PCI_PAGE_ALIGNED
- VFIO_DEVICE_FLAGS_PCI_MSIX_MMAP
Signed-off-by: Yongji Xie
---
linux-headers/linux/vfio.h |4
1 file changed, 4 insert
On 11 December 2015 at 12:52, Peter Maydell wrote:
> On 11 December 2015 at 12:25, Juan Quintela wrote:
>> Peter Maydell wrote:
>>> This sounds like we should probably put this into 2.5; I'm happy
>>> to do so if it gets review by tomorrow afternoon and Juan/Amit
>>> agree.
>>
>> Yeap, did the r
On 11 December 2015 at 12:25, Juan Quintela wrote:
> Peter Maydell wrote:
>> This sounds like we should probably put this into 2.5; I'm happy
>> to do so if it gets review by tomorrow afternoon and Juan/Amit
>> agree.
>
> Yeap, did the review by. Do you want a pull request, or just pick it
> dir
On Tue, 8 Dec 2015, Gerd Hoffmann wrote:
> Pure code motion, except for dropping instance_size for
> TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE (no need to set,
> we can inherit it from TYPE_I440FX_PCI_DEVICE).
>
> Signed-off-by: Gerd Hoffmann
Acked-by: Stefano Stabellini
> hw/pci-host/Makefile.
Peter Maydell wrote:
D> On 10 December 2015 at 16:31, Dr. David Alan Gilbert (git)
> wrote:
>> From: "Dr. David Alan Gilbert"
>>
>> My fix (84e7b80a) replaced the last_sent_block update that I'd
>> removed earlier; however it was too aggressive in the xbzrle case.
>>
>> save_xbzrle_page might re
On Wed, 9 Dec 2015, Eduardo Habkost wrote:
> On Tue, Dec 08, 2015 at 03:07:22PM +0100, Gerd Hoffmann wrote:
> > rename pc_xen_hvm_init_pci to pc_i440fx_init_pci,
> > use it for both xen and non-xen init.
> >
> > Signed-off-by: Gerd Hoffmann
> > ---
> > hw/i386/pc_piix.c | 11 +--
> > 1 f
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> My fix (84e7b80a) replaced the last_sent_block update that I'd
> removed earlier; however it was too aggressive in the xbzrle case.
>
> save_xbzrle_page might return '0' to mean that the page didn't
> need sending since it
Thomas Huth, on Fri 11 Dec 2015 12:54:14 +0100, wrote:
> > @@ -5,7 +5,7 @@
> > * terms and conditions of the copyright.
> > */
> >
> > -//#define DEBUG 1
> > +#define DEBUG 1
>
> Please don't enable the debug code by default.
Oops, sorry, that wasn't meant to be included in the patch series
Actually CC'ing xen-devel
On Fri, 11 Dec 2015, Stefano Stabellini wrote:
> On Tue, 8 Dec 2015, Gerd Hoffmann wrote:
> > Hi,
> >
> > We have some code in our tree to support pci passthrough of intel
> > graphics devices (igd) on xen, which requires some chipset tweaks
> > for (a) the host bridge
On 11/12/15 01:15, Samuel Thibault wrote:
> From: Guillaume Subiron
>
> Before this patch, if sosendto fails, udp_input is executed as if the
> packet was sent, recording the packet for icmp errors, which does not
> makes sense since the packet was not actually sent, errors would be
> related to
On Tue, 8 Dec 2015, Gerd Hoffmann wrote:
> Hi,
>
> We have some code in our tree to support pci passthrough of intel
> graphics devices (igd) on xen, which requires some chipset tweaks
> for (a) the host bridge and (b) the lpc/isa-bridge to meat the
> expectations of the guest driver. For kvm w
On Tue, 1 Dec 2015, Eduardo Habkost wrote:
> We don't need the FWCfgState return value and the PcGuestInfo
> parameter.
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Stefano Stabellini
> hw/i386/pc.c | 5 +
> hw/i386/pc_piix.c| 2 +-
> include/hw/i386/pc.h | 3 +--
> 3 file
On 11/12/2015 11:53, Daniel P. Berrange wrote:
> Ping, unless anyone wants to review this further I'll send a pull
> request for it once 2.6 opens up, so I can focus on getting the
> other dependant patch series reviewed & merged in 2.6 too.
Yes, please do.
Paolo
On 11/12/2015 00:53, Eric Blake wrote:
> Instead of rolling our own limited JSON outputter, we can just
> wrap the more full-featured JSON output Visitor.
>
> This slightly changes the output (different spacing), but the
> result is still equivalent JSON contents.
>
> Signed-off-by: Eric Blake
On 11/12/2015 00:53, Eric Blake wrote:
> We have two different JSON visitors in the tree; and having both
> named 'qjson.h' can cause include confusion. Rename the qapi
> version.
>
> Kill trailing whitespace in the renamed tests/check-qobject-json.c
> to keep checkpatch.pl happy.
>
> Signed-o
Ping, unless anyone wants to review this further I'll send a pull
request for it once 2.6 opens up, so I can focus on getting the
other dependant patch series reviewed & merged in 2.6 too.
Regards,
Daniel
On Wed, Nov 18, 2015 at 06:42:43PM +, Daniel P. Berrange wrote:
> This series of patches
On 11/12/15 01:11, David Gibson wrote:
> The functions for migrating the hash page table on pseries machine type
> (htab_save_setup() and htab_load()) can report some errors with an
> explicit fprintf() before returning an appropriate eror code. Change these
s/eror/error/
> to use error_report()
On 11/12/15 01:11, David Gibson wrote:
> Use the error handling infrastructure to pass an error out from
> try_create_xics() instead of assuming &error_abort - the caller is in a
> better position to decide on error handling policy.
>
> Signed-off-by: David Gibson
> ---
> hw/ppc/spapr.c | 6 +++-
On 11/12/15 01:11, David Gibson wrote:
> The errors detected in this function indicate problems with the rest of
> the machine type code, rather than configuration or runtime problems.
>
> Use error_setg() and &error_abort instead of explicit fprintf() and exit().
>
> Signed-off-by: David Gibson
Hello Jason,
+-- On Fri, 11 Dec 2015, Jason Wang wrote --+
| I think it's possible for attacker. Better wait for Dmitry's answer for
| this.
Okay.
| > +/* Verify if device is active */
| > +if (s->device_active) {
| > +VMW_CFPRN("Vmxnet3 device is active");
| > +retu
On 11/12/15 01:11, David Gibson wrote:
> Use error_setg() and &error_fatal instead of an explicit exit().
>
> Signed-off-by: David Gibson
> ---
> hw/ppc/spapr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index fd16db4..546d2f5
On 11/12/15 01:11, David Gibson wrote:
> Use error_setg() to return an error instead of using an explicit exit().
>
> Signed-off-by: David Gibson
> ---
> hw/ppc/spapr.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 0ff0
On 2015/12/11 3:01, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
If we detect some error in colo, we will wait for some time,
hoping users also detect it. If users don't issue failover command.
We will go into default failover procedure, which the PVM wi
On 2015/12/11 17:22, Dr. David Alan Gilbert wrote:
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote:
On 2015/12/11 2:34, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
For PVM, if there is failover request from users.
The colo thread will exit the
On 11/12/15 01:11, David Gibson wrote:
> Use error_setg() to return an error rather than an explicit exit().
> Previously it was an exit(0) instead of a non-zero exit code, which was
> simply a bug.
>
> Also improve the error message.
>
> Signed-off-by: David Gibson
> ---
> hw/ppc/spapr.c | 10
Sent from my iPhone
> On 11 Dec 2015, at 11:10, Jason Wang wrote:
>
>
>
>> On 12/09/2015 11:28 PM, P J P wrote:
>> Hello Jason, Dmitry,
>>
>> +-- On Tue, 8 Dec 2015, P J P wrote --+
>> | |1) VMXNET3_CMD_QUIESCE_DEV
>> |
>> | IIUC, it is used to pause the device when the receiver end is
On 12/04/2015 05:44 PM, Denis V. Lunev wrote:
EFI based VM with pflash storage for NVRAM could not be snapshoted as
libvirt configures storage as 'raw' and writable. OK, this is a libvirt
problem.
Another problem is that libvirt can not detect this failure at all
as it uses HMP for this operatio
On 2015/12/11 17:18, Dr. David Alan Gilbert wrote:
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote:
On 2015/12/11 4:03, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
If the net connection between COLO's two sides is broken while colo/colo
incomi
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote:
> On 2015/12/11 2:34, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> >>For PVM, if there is failover request from users.
> >>The colo thread will exit the loop while the failover BH does the
> >>cle
* Hailiang Zhang (zhang.zhanghaili...@huawei.com) wrote:
> On 2015/12/11 4:03, Dr. David Alan Gilbert wrote:
> >* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> >>If the net connection between COLO's two sides is broken while colo/colo
> >>incoming
> >>thread is blocked in 'read'/'write'
On 11/12/15 01:11, David Gibson wrote:
> Current ppc_set_compat() returns -1 for errors, and also (unconditionally)
> reports an error message. The caller in h_client_architecture_support()
> may then report it again using an outdated fprintf().
>
> Clean this up by using the modern error reporti
On 12/09/2015 11:28 PM, P J P wrote:
>Hello Jason, Dmitry,
>
> +-- On Tue, 8 Dec 2015, P J P wrote --+
> | |1) VMXNET3_CMD_QUIESCE_DEV
> |
> | IIUC, it is used to pause the device when the receiver end is unable to
> | keee-up with the incoming flow. After a brief period, the operation co
On 2015/12/11 2:16, Cornelia Huck wrote:
On Thu, 10 Dec 2015 18:23:49 +0100
Markus Armbruster wrote:
Commit 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they
keep coming back. Tracked down with the Coccinelle semantic patch
from commit 312fd5f.
Cc: Fam Zheng
Cc: Peter Crosthwaite
On 2015/12/11 4:03, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
If the net connection between COLO's two sides is broken while colo/colo
incoming
thread is blocked in 'read'/'write' socket fd. It will not detect this error
until
connect timeout. It wil
On Fri, Dec 11, 2015 at 5:41 AM, David Gibson
wrote:
> Use error_setg() and return an error, rather than using an explicit exit().
>
> Also improve messages, and be more explicit about which constraint failed.
>
> Signed-off-by: David Gibson
Reviewed-by: Bharata B Rao
> ---
> hw/ppc/spapr.c |
On Fri, Dec 11, 2015 at 5:41 AM, David Gibson
wrote:
> Currently spapr_cpu_init() is hardcoded to handle any errors as fatal.
> That works for now, since it's only called from initial setup where an
> error here means we really can't proceed.
>
> However, we'll want to handle this more flexibly fo
On Fri, Dec 11, 2015 at 5:41 AM, David Gibson
wrote:
> The spapr_alloc_htab() and spapr_reset_htab() functions currently handle
> all errors with error_setg(&error_abort, ...). That's correct for
> spapr_reset_htab() - if anything goes wrong there, there's really nothing
> we can do about it. Fo
On 2015/12/11 2:50, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
If users require SVM to takeover work, colo incoming thread should
exit from loop while failover BH helps backing to migration incoming
coroutine.
Signed-off-by: zhanghailiang
Signed-off-b
>
> static Property s390_ipl_properties[] = {
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index a061b49..9a117c9 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -456,29 +456,29 @@ static void sclp_realize(DeviceState *dev, Error **errp)
> {
> MachineState *machine = MACH
Any comments?
Ciao,
Gerhard
On 08.12.2015 10:39, Gerhard Wiesinger wrote:
Hello,
Yesterday I looked at my munin statistics on my KVM host and I swar
that performance gets worser: load is getting higher, interrupts are
getting higher and are high as well as context switches. VMs and
applicat
On 2015/12/11 2:34, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
For PVM, if there is failover request from users.
The colo thread will exit the loop while the failover BH does the
cleanup work and resumes VM.
Signed-off-by: zhanghailiang
Signed-off-by:
101 - 156 of 156 matches
Mail list logo
