Hi Vijaya,
On 27/01/2017 08:02, Vijay Kilari wrote:
> Hi Eric,
>
> On Thu, Jan 26, 2017 at 2:49 PM, Eric Auger wrote:
>> Rename KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS into KVM_DEV_ARM_VGIC_CPU_SYSREGS
>> as exposed in the kernel user API and pulled by update-linux-headers.sh.
>
> I will fix it in my
I don't like "change FOO" subject lines. What about;
qapi: Simplify qapi2texi.py a bit
This way, it's obvious that the commit isn't supposed to change
behavior. Can touch up on commit.
Marc-André Lureau writes:
> STRUCT_FMT is generic enough, rename it to TYPE_FMT, use it for unions.
>
>
Hi Vijaya,
On 27/01/2017 08:17, Vijay Kilari wrote:
> Hi Eric,
>
> On Thu, Jan 26, 2017 at 2:49 PM, Eric Auger wrote:
>> We need to handle both registers and ITS tables. While
>> register handling is standard, ITS table handling is more
>> challenging since the kernel API is devised so that the
Move makeinfo flags from MAKEINFO to MAKEINFOFLAGS. Fix the call of
quiet-command for target qemu-ga-qapi.texi. Both messed up in commit
56e8bdd.
Cc: Marc-André Lureau
Signed-off-by: Markus Armbruster
Message-Id: <1484816804-12598-1-git-send-email-arm...@redhat.com>
Reviewed-by: Marc-André Lur
From: Stefan Weil
We don't want that commas to be part of the generated documentation,
so remove them.
Signed-off-by: Stefan Weil
Message-Id: <20170122145407.27476-1...@weilnetz.de>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qapi-schema.json | 4 ++--
qapi/block
From: Lin Ma
The argument is called "typename", not "name".
[Thanks to Markus for correcting the commit message]
Signed-off-by: Lin Ma
Message-Id: <20170125052703.23571-1-...@suse.com>
Reviewed-by: Markus Armbruster
Signed-off-by: Markus Armbruster
---
qmp.c | 4 ++--
1 file changed, 2 inse
The following changes since commit c7f1cf01b8245762ca5864e835d84f6677ae8b1f:
Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging
(2017-01-25 17:54:14 +)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-01-27
for you to
Hi Eric,
On Thu, Jan 26, 2017 at 2:49 PM, Eric Auger wrote:
> We need to handle both registers and ITS tables. While
> register handling is standard, ITS table handling is more
> challenging since the kernel API is devised so that the
> tables are flushed into guest RAM and not in vmstate buffers
Hi Eric,
On Thu, Jan 26, 2017 at 2:49 PM, Eric Auger wrote:
> Rename KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS into KVM_DEV_ARM_VGIC_CPU_SYSREGS
> as exposed in the kernel user API and pulled by update-linux-headers.sh.
I will fix it in my next qemu patch series.
I have updated kernel to use KVM_DEV_ARM_
Thomas Huth writes:
> On 26.01.2017 16:09, Markus Armbruster wrote:
>> Block backends defined with -drive if=ide are meant to be picked up by
>> machine initialization code: a suitable frontend gets created and
>> wired up automatically.
>>
>> if=ide drives not picked up that way can still be us
Peter Maydell writes:
> On 26 January 2017 at 17:52, Paolo Bonzini wrote:
>> - HTML is mostly a destination format. With the listed formats it is
>> possible to produce a variety of outputs (mostly HTML itself and PDF;
>> secondarily text or ePub or others).
>
> It's an interesting question to
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> On 26/01/2017 15:32, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> >> On 26/01/2017 14:37, Pavel Dovgalyuk wrote:
> Simpler:
>
> use_icount &&
> ((int32_t)cpu->icount_decr.u32 < 0 ||
>
On 01/26/17 19:59, Michael S. Tsirkin wrote:
> On Thu, Jan 26, 2017 at 07:25:22PM +0100, Laszlo Ersek wrote:
>> On 01/26/17 19:15, Michael S. Tsirkin wrote:
>>> On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote:
On 01/26/17 16:20, Michael S. Tsirkin wrote:
> On Thu, Jan 26, 2017
Currently, update-linux-headers.sh will crash when run with a clean
checkout of a recent version of the linux kernel source (e.g. 4.10-rc1):
scripts/Makefile.headersinst:62: *** Missing generated UAPI file
./arch/arm/include/generated/uapi/asm/unistd-common.h. Stop.
This seems to be due to the s
Interactive access to a guest serial console can be enabled by hooking
the serial device to a pty backend, e.g. -device
isa-serial,chardev=cs0 -chardev pty,id=cs0. With libvirt this can be
configured via .
Output from the same serial device can also be logged to a file by
adding logfile=/somefile
On 26 January 2017 at 05:50, Thomas Huth wrote:
> I think there is no real use case yet. But this fix is 1) simpler than
> doing an error_report() + exit() here, and 2) maybe the vision of
> constructing machines on the fly with QEMU will eventually come true one
> day in the distant future, so wi
On 17 January 2017 at 15:20, Gerd Hoffmann wrote:
> On Di, 2017-01-17 at 10:44 +, Peter Maydell wrote:
>> On 17 January 2017 at 08:20, Gerd Hoffmann wrote:
>> > On Mo, 2017-01-16 at 18:35 +, Peter Maydell wrote:
>> >> On 11 January 2017 at 10:58, Gerd Hoffmann wrote:
>> >> > No need to g
On Thu, Jan 26, 2017 at 12:38 AM, Laurent Vivier wrote:
> Le 26/01/2017 à 06:50, Thomas Huth a écrit :
>> On 26.01.2017 00:26, Alistair Francis wrote:
>>> On Wed, Jan 25, 2017 at 12:52 PM, Laurent Vivier wrote:
Le 25/01/2017 à 21:45, Thomas Huth a écrit :
> When running QEMU with "-M non
On Thu, Jan 26, 2017 at 09:26:55AM -0800, Richard Henderson wrote:
> On 01/26/2017 05:12 AM, Stafford Horne wrote:
> > I just sent you a mail with a link to my kernel for download.
> >
> > One thing I noticed is you passed '-append console=ttyS0' I think that
> > does nothing on openrisc since as
Does the problem still occur with the latest version of QEMU (currently
v2.8)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1258626
Title:
Cur
Which exact version of QEMU did you use? Does this problem still occur
with the latest version of QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/b
On 26 January 2017 at 20:47, Peter Maydell wrote:
> On 26 January 2017 at 19:36, Stefano Stabellini
> wrote:
>> It should be just a matter of replacing qdev_init_nofail with something
>> that can fail. I couldn't find a regular qdev_init that can return
>> error, so maybe we would need to add it
On 26 January 2017 at 19:36, Stefano Stabellini wrote:
> It should be just a matter of replacing qdev_init_nofail with something
> that can fail. I couldn't find a regular qdev_init that can return
> error, so maybe we would need to add it.
That's just
object_property_set_bool(OBJECT(whatever
This is a port to ppc of the i386 commit:
00f4d64 kvmclock: clock should count only if vm is running
We remove timebase_/pre_save/post_load/ functions,
and use the VM state change handler to save and restore
the guest_timebase (on stop and continue).
Time base offset has originally been intro
* Brian Rak (b...@gameservers.com) wrote:
> We've been considering switching over to using qemu's built in websockets
> support (to avoid the overhead of needing websockify running). We've been
> seeing very poor performance after the switch (it takes the console 4-5
> seconds to update after pres
On 26.01.2017 16:09, Markus Armbruster wrote:
> Block backends defined with -drive if=ide are meant to be picked up by
> machine initialization code: a suitable frontend gets created and
> wired up automatically.
>
> if=ide drives not picked up that way can still be used with -device as
> if they
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote:
> Migration of a "none" machine with no RAM crashes abruptly as
> bitmap_new() fails and thus aborts. Instead, place a check for
> last_ram_offset() being '0' at the start of ram_save_setup() and
> error out with a meaningful error message.
>
>
On Thu, 26 Jan 2017, Roger Pau Monné wrote:
> On Wed, Jan 25, 2017 at 11:05:29AM +, Roger Pau Monné wrote:
> > On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> > > On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > > > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > > > H
On Thu, Jan 26, 2017 at 07:25:22PM +0100, Laszlo Ersek wrote:
> On 01/26/17 19:15, Michael S. Tsirkin wrote:
> > On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote:
> >> On 01/26/17 16:20, Michael S. Tsirkin wrote:
> >>> On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote:
> >>
>
On 01/26/2017 11:16 AM, Stefan Hajnoczi wrote:
> There are a number of unused trace events that
> scripts/cleanup-trace-events.pl finds. The "hw/vfio/pci-quirks.c"
> filename was typoed and "qapi/qapi-visit-core.c" was missing the qapi/
> directory prefix.
>
> Signed-off-by: Stefan Hajnoczi
> --
On 01/26/17 19:15, Michael S. Tsirkin wrote:
> On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote:
>> On 01/26/17 16:20, Michael S. Tsirkin wrote:
>>> On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote:
>>
But, again, I'd like to keep COMMAND_ALLOCATE_RETURN_ADDR 8-byte wid
On Thu, Jan 26, 2017 at 06:43:22PM +0100, Laszlo Ersek wrote:
> On 01/26/17 16:20, Michael S. Tsirkin wrote:
> > On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote:
>
> >> But, again, I'd like to keep COMMAND_ALLOCATE_RETURN_ADDR 8-byte wide.
> >
> >
> > What is COMMAND_ALLOCATE_RETURN
On 26.01.2017 16:09, Markus Armbruster wrote:
> These machines have no onboard SCSI HBA, and no way to plug one.
> -drive if=scsi therefore cannot work. They do have an onboard IDE
> controller (sysbus-ahci), but fail to honor if=ide.
>
> Change their default to if=ide, and add a TODO comment on
On 26.01.2017 16:09, Markus Armbruster wrote:
> Block backends defined with -drive if=scsi are meant to be picked up
> by machine initialization code: a suitable frontend gets created and
> wired up automatically.
>
> if=scsi drives not picked up that way can still be used with -device
> as if the
On Thu, 26 Jan 2017 18:30:46 +0100
Paolo Bonzini wrote:
> On 26/01/2017 18:28, G 3 wrote:
> >
> > On Jan 26, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
> >
> >>
> >> Hi all,
> >>
> >> as you may know I've been collecting some ideas about documentation for
> >> QEMU at http://wiki.q
On 26 January 2017 at 17:52, Paolo Bonzini wrote:
> - HTML is mostly a destination format. With the listed formats it is
> possible to produce a variety of outputs (mostly HTML itself and PDF;
> secondarily text or ePub or others).
It's an interesting question to ask what destination formats
we
On 26/01/2017 18:40, G 3 wrote:
>
> On Jan 26, 2017, at 12:30 PM, Paolo Bonzini wrote:
>
>>
>>
>> On 26/01/2017 18:28, G 3 wrote:
>>>
>>> On Jan 26, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
>>>
Hi all,
as you may know I've been collecting some ideas about docu
On 01/26/2017 11:16 AM, Stefan Hajnoczi wrote:
> A trace event exists for enums but it's never called. This patch fixes
> this oversight so that enums are traced just like the other QAPI types.
>
> Suggested-by: Daniel P. Berrange
> Signed-off-by: Stefan Hajnoczi
> ---
> qapi/qapi-visit-core.c
Hello Jason,
+-- On Mon, 26 Sep 2016, P J P wrote --+
| +-- On Fri, 23 Sep 2016, Jason Wang wrote --+
| | Actually the patch does not apply cleanly. Please fix and repost.
|
| The 'net: imx:...' patch is for v2.6 series. I missed to indicate that in
| Patch v2. Could you please try it with v
On 01/26/17 16:20, Michael S. Tsirkin wrote:
> On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote:
>> But, again, I'd like to keep COMMAND_ALLOCATE_RETURN_ADDR 8-byte wide.
>
>
> What is COMMAND_ALLOCATE_RETURN_ADDR? I'm only familiar with
> COMMAND_ALLOCATE.
It's a new command being
This enables reboot of a guest from U-Boot and Linux.
Signed-off-by: Cédric Le Goater
Reviewed-by: Joel Stanley
---
hw/arm/aspeed_soc.c | 13 +
include/hw/arm/aspeed_soc.h | 2 ++
2 files changed, 15 insertions(+)
diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
inde
On Jan 26, 2017, at 12:30 PM, Paolo Bonzini wrote:
On 26/01/2017 18:28, G 3 wrote:
On Jan 26, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
Hi all,
as you may know I've been collecting some ideas about
documentation for
QEMU at http://wiki.qemu-project.org/Features/Document
Hello,
The Aspeed SoC includes a set of watchdog timers using 32-bit
decrement counters. This patchset provides a model for this controller
and adds the first watchdog to the Aspeed SoC model. A second watchdog
exists and is used on real HW to boot from a second flash module
containing a golden im
The Aspeed SoC includes a set of watchdog timers using 32-bit
decrement counters, which can be based either on the APB clock or
a 1 MHz clock.
The watchdog timer is designed to prevent system deadlock and, in
general, it should be restarted before timeout. When a timeout occurs,
different types of
On 26/01/2017 18:28, G 3 wrote:
>
> On Jan 26, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
>
>>
>> Hi all,
>>
>> as you may know I've been collecting some ideas about documentation for
>> QEMU at http://wiki.qemu-project.org/Features/Documentation.
>>
>> I've now prepared a poll to
On Jan 26, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
Hi all,
as you may know I've been collecting some ideas about documentation
for
QEMU at http://wiki.qemu-project.org/Features/Documentation.
I've now prepared a poll to understand how familiars developers are
with
variou
On 01/26/2017 05:12 AM, Stafford Horne wrote:
I just sent you a mail with a link to my kernel for download.
One thing I noticed is you passed '-append console=ttyS0' I think that
does nothing on openrisc since as far as I know openrisc only gets boot
params from the device tree file. I tried wit
On Wed, Jan 25, 2017 at 03:04:43PM +0100, Paolo Bonzini wrote:
>
>
> On 25/01/2017 14:22, Stefan Hajnoczi wrote:
> > On Tue, Jan 24, 2017 at 07:04:15PM +0100, Paolo Bonzini wrote:
> >> @@ -689,18 +714,34 @@ void *virtqueue_pop(VirtQueue *vq, size_t sz)
> >> }
> >>
> >> i = head;
> >>
There are a number of unused trace events that
scripts/cleanup-trace-events.pl finds. The "hw/vfio/pci-quirks.c"
filename was typoed and "qapi/qapi-visit-core.c" was missing the qapi/
directory prefix.
Signed-off-by: Stefan Hajnoczi
---
block/trace-events | 2 --
hw/block/trace-events |
On 01/26/2017 04:14 AM, Paolo Bonzini wrote:
I haven't studied the code much, so I'm just reporting what Coverity
says. Not sure if the code has a bug or can just be simplified.
It looks like it can be simplified.
I'm sure at one point in the development, "which" was not a constant like that.
A trace event exists for enums but it's never called. This patch fixes
this oversight so that enums are traced just like the other QAPI types.
Suggested-by: Daniel P. Berrange
Signed-off-by: Stefan Hajnoczi
---
qapi/qapi-visit-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/qap
I noticed that some trace-events files are out of date. This series fixes them.
Stefan Hajnoczi (2):
qapi: add missing trace_visit_type_enum() call
trace: clean up trace-events files
qapi/qapi-visit-core.c | 1 +
block/trace-events | 2 --
hw/block/trace-events | 1 -
hw/display/tra
On Wed, Jan 25, 2017 at 02:20:22PM +, Daniel P. Berrange wrote:
> On Wed, Jan 25, 2017 at 02:14:26PM +, Stefan Hajnoczi wrote:
> > There are a number of unused trace events that
> > scripts/cleanup-trace-events.pl finds. The "hw/vfio/pci-quirks.c"
> > filename was typoed and "qapi/qapi-vis
Hi all,
as you may know I've been collecting some ideas about documentation for
QEMU at http://wiki.qemu-project.org/Features/Documentation.
I've now prepared a poll to understand how familiars developers are with
various documentation tools. I've CCed people with most commits to QEMU
documentat
From: Marcel Apfelbaum
The shpc component is optional while ACPI hotplug is used
for hot-plugging PCI devices into a PCI-PCI bridge.
Disabling the shpc by default will make slot 0 usable at boot time
and not only for hot-plug, without loosing any functionality.
Older machines will have shpc enab
From: Marc-André Lureau
Remove the chardev implicitly when cleaning up the netdev. This
prevents from reusing the chardev since it would be in an incorrect
state with the slave.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1256618
Signed-off-by: Marc-André Lureau
Reviewed-by: Michael
From: Marcel Apfelbaum
Preserve only Intel specific details.
Signed-off-by: Marcel Apfelbaum
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/pci-bridge/ioh3420.c | 121 ++--
1 file changed, 15 insertions(+), 106 deletions(-
From: Jason Wang
We don't use 1ULL which is wrong during size calculation. Fix it, and
while at it, switch to use cto64() and adds a comments to make it
simpler and easier to be understood.
Reported-by: Paolo Bonzini
Cc: Paolo Bonzini
Signed-off-by: Jason Wang
Reviewed-by: Michael S. Tsirkin
From: Cao jin
msix_init() reports errors with error_report(), which is wrong when
it's used in realize(). The same issue was fixed for msi_init() in
commit 1108b2f. In order to make the API change as small as possible,
leave the return value check to later patch.
For some devices(like e1000e, v
QEMU_BUILD_BUG_ON uses a typedef in order to be safe
to use outside functions, but sometimes it's useful
to have a version that can be used within an expression.
Following what Linux does, introduce QEMU_BUILD_BUG_ON_ZERO
that return zero after checking condition at build time.
Signed-off-by: Mich
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Stefan Hajnoczi
---
include/hw/virtio/virtio.h | 1 -
hw/virtio/virtio.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/vi
There are theoretical concerns that some compilers might not trigger
build failures on attempts to define an array of size (x ? -1 : 1) where
x is a variable and make it a variable sized array instead. Let rewrite
using a struct with a negative bit field size instead as there are no
dynamic bit fie
Good catch!
Reviewed-by: Dmitry Fleytman
> On 26 Jan 2017, at 12:10 PM, Paolo Bonzini wrote:
>
> Because is_first is declared inside a loop, it is always true. The store
> is dead, and so is the "else" branch of "if (is_first)". is_last is
> okay though.
>
> Reported by Coverity.
>
> Signe
From: Cao jin
usb_xhci_realize() corrects invalid values of property "intrs"
automatically, but the uncorrected value is passed to msi_init(),
which chokes on invalid values. Delay that until after the
correction.
Resources allocated by usb_xhci_init() are leaked when msi_init()
fails. Fix by
vhost does not support RO protections on memory at the moment - adding
ROMs would mean that e.g. a buggy guest might change them in-memory - a
condition from which guest reset does not recover. Not nice.
We also definitely don't want to try logging writes into ROMs -
in particular guests set very
The following changes since commit ae5045ae5b2bbd8ce1335d1b05f9ecacca83a6cf:
Merge remote-tracking branch 'remotes/rth/tags/pull-nios-20170124' into
staging (2017-01-25 13:30:23 +)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstre
From: Haozhong Zhang
The missing of 'nvdimm' in the machine type option '-M' means NVDIMM
is disabled. QEMU should refuse to plug any NVDIMM device in this case
and report the misconfiguration.
The behavior of NVDIMM on unsupported platform (HW/FW) is vendor
specific. For some vendors, it's unde
From: Marcel Apfelbaum
The Generic Root Port behaves almost the same as the
Intel's IOH device with id 3420, without having
Intel specific attributes.
The device has two purposes:
(1) Can be used on both X86 and ARM machines.
(2) It will allow us to tweak the behaviour
(e.g add vendor-spec
From: Cao jin
CC: Markus Armbruster
CC: Marcel Apfelbaum
CC: Michael S. Tsirkin
Reviewed-by: Markus Armbruster
Acked-by: Marcel Apfelbaum
Signed-off-by: Cao jin
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/pci/msix.c | 8 ++--
1 file changed, 6 insertions
All users include the trailing ; anyway, let's require that -
it seems cleaner.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Eric Blake
Reviewed-by: Markus Armbruster
---
include/qemu/compiler.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/qemu/compiler.h b/i
From: Marcel Apfelbaum
The 'base' PCI Express Root Port includes
the common code to be re-used for all
Root Ports implementations. Most of the code
was taken from the current implementation
of Intel's IOH 3420 Root Port.
Signed-off-by: Marcel Apfelbaum
Reviewed-by: Michael S. Tsirkin
Signed-of
We are switching BUILD_BUG_ON to verify that it's parameter is a
compile-time constant, and it turns out that some gcc versions
(specifically gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609) are
not smart enough to figure it out for expressions involving local
variables. This is harmless but mea
Looks like we didn't mark PCI ROMs as RO allowing
mischief such as guests writing there.
Further, e.g. vhost gets confused trying to allocate
enough space to log writes there. Fix it up.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Marcel Apfelbaum
Tested-by: Laurent Vivier
---
hw/pci/pci.c
It's a familiar pattern: some code uses ARRAY_SIZE, then refactoring
changes the argument from an array to a pointer to a dynamically
allocated buffer. Code keeps compiling but any ARRAY_SIZE calls now
return the size of the pointer divided by element size.
Let's add build time checks to ARRAY_SI
On 26.01.2017 16:09, Markus Armbruster wrote:
> Block backends defined with -drive if=ide are meant to be picked up by
> machine initialization code: a suitable frontend gets created and
> wired up automatically.
>
> if=ide drives not picked up that way can still be used with -device as
> if they
On Wed, Jan 25, 2017 at 11:05:29AM +, Roger Pau Monné wrote:
> On Tue, Jan 24, 2017 at 01:30:02PM -0800, Stefano Stabellini wrote:
> > On Tue, 24 Jan 2017, Stefano Stabellini wrote:
> > > On Tue, 24 Jan 2017, Roger Pau Monné wrote:
> > > > Hello,
> > > >
> > > > The following commit:
> > > >
This patch:
* moves vm_start to cpus.c .
* exports qemu_vmstop_requested, since it's needed by vm_start .
* extracts vm_prepare_start from vm_start; it does what vm_start did,
except restarting the cpus. vm_start now calls vm_prepare_start.
* moves the call to qemu_clock_enable away from resume_
When GDB issues a "vCont", QEMU was not handling it correctly when
multiple VCPUs are active.
For vCont, for each thread (VCPU), it can be specified whether to
single step, continue or stop that thread. The default is to stop a
thread.
However, when (for example) "vCont;s:2" is issued, all VCPUs co
This small patchset fixes the incorrect behaviour of the vCont command
in the gdb stub.
The first patch, as suggested be Paolo, refactors some code. The most
visible change is that it moves vm_start to cpus.c
The second one fixes the incorrect behaviour of the vCont command.
Previously, continu
This hunk should not have been merged but I forgot to remove it. Let's
remove it before it slips into a QEMU release.
¯\_(ツ)_/¯
Signed-off-by: Stefan Hajnoczi
---
aio-posix.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/aio-posix.c b/aio-posix.c
index 9453d83..9a6348b 100644
--- a
Block backends defined with "-drive if=T" with T other than "none" are
meant to be picked up by machine initialization code: a suitable
frontend gets created and wired up automatically.
Drives defined with if=scsi are also picked up by SCSI HBAs added with
-device, unlike other interface types. D
Drives defined with if=scsi get connected to buses created with
-device, unlike other interface types. Deprecate this usage.
There is no good default SCSI HBA for PC machines. Deprecate if=scsi
there entirely.
Before this series, frontends for -drive if=scsi get created by SCSI
HBAs. Frontends
The PC machines (pc-q35-* pc-i440fx-* pc-* isapc xenfv) automatically
create lsi53c895a SCSI HBAs and SCSI devices to honor -drive if=scsi.
For giggles, try -drive if=scsi,bus=25,media=cdrom --- this makes QEMU
create 25 of them.
lsi53c895a is thoroughly obsolete (PCI Ultra2 SCSI, ca. 2000), and
c
The logic to create frontends for -drive if=scsi is in SCSI HBAs. For
all other interface types, it's in machine initialization code.
A few machine types create the SCSI HBAs necessary for that. That's
also not done for other interface types.
I'm going to deprecate these SCSI eccentricities. I
Le 26/01/2017 à 16:09, Markus Armbruster a écrit :
> Block backends defined with -drive if=ide are meant to be picked up by
> machine initialization code: a suitable frontend gets created and
> wired up automatically.
>
> if=ide drives not picked up that way can still be used with -device as
> if
On Thu, Jan 26, 2017 at 01:48:37AM +0100, Laszlo Ersek wrote:
> On 01/25/17 19:35, Michael S. Tsirkin wrote:
> > On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote:
> >> Hi Laszlo,
> >>
> >>
> >> On Jan 24, 2017, at 7:55 PM, Laszlo Ersek wrote:
> >>
> >> Hi Ben,
> >>
> >> sorry
These machines have no onboard SCSI HBA, and no way to plug one.
-drive if=scsi therefore cannot work. They do have an onboard IDE
controller (sysbus-ahci), but fail to honor if=ide.
Change their default to if=ide, and add a TODO comment on what needs
to be done to actually honor -drive if=ide.
We've traditionally rejected orphans here and there, but not
systematically. For instance, the sun4m machines have an onboard SCSI
HBA (bus=0), and have always rejected bus>0. Other machines with an
onboard SCSI HBA don't.
Commit a66c9dc made all orphans trigger a warning, and the previous
commi
Block backends defined with -drive if=T, T!=none are meant to be
picked up by machine initialization code: a suitable frontend gets
created and wired up automatically.
if=T drives not picked up that way can still be used with -device as
if they had if=none, but that's unclean and best avoided. Un
Machine types cubieboard, xlnx-ep108, xlnx-zcu102 have an onboard AHCI
controller, but neglect to set their MachineClass member
units_per_default_bus = 1. This permits -drive if=ide,unit=1, which
makes no sense for AHCI. It also screws up index=N for odd N, because
it gets desugared to unit=1,bus
We warn when a -drive isn't supported by the machine type (commit
a66c9dc):
$ qemu-system-x86_64 -S -display none -drive if=mtd
Warning: Orphaned drive without device: id=mtd0,file=,if=mtd,bus=0,unit=0
Improve this to point to the offending bit of configuration:
qemu-system-x86_64: -
Block backends defined with "-drive if=T" with T other than "none" are
meant to be picked up by machine initialization code: a suitable
frontend gets created and wired up automatically.
If machine initialization code doesn't comply, the block backend
remains unused. This triggers a warning since
Block backends defined with -drive if=scsi are meant to be picked up
by machine initialization code: a suitable frontend gets created and
wired up automatically.
if=scsi drives not picked up that way can still be used with -device
as if they had if=none, but that's unclean and best avoided. Unuse
Block backends defined with -drive if=ide are meant to be picked up by
machine initialization code: a suitable frontend gets created and
wired up automatically.
if=ide drives not picked up that way can still be used with -device as
if they had if=none, but that's unclean and best avoided. Unused
Block backends defined with -drive if=ide are meant to be picked up by
machine initialization code: a suitable frontend gets created and
wired up automatically.
if=ide drives not picked up that way can still be used with -device as
if they had if=none, but that's unclean and best avoided. Unused
On 26/01/2017 15:32, Pavel Dovgalyuk wrote:
>> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
>> On 26/01/2017 14:37, Pavel Dovgalyuk wrote:
Simpler:
use_icount &&
((int32_t)cpu->icount_decr.u32 < 0 ||
cpu->icount_decr.u16.low + cpu->icount_extra == 0)
>>> Rig
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> On 26/01/2017 14:37, Pavel Dovgalyuk wrote:
> >> Simpler:
> >>
> >>use_icount &&
> >>((int32_t)cpu->icount_decr.u32 < 0 ||
> >> cpu->icount_decr.u16.low + cpu->icount_extra == 0)
> > Right.
> >
> >> But I'm not sure that you need to t
On 26/01/2017 14:37, Pavel Dovgalyuk wrote:
>> Simpler:
>>
>> use_icount &&
>> ((int32_t)cpu->icount_decr.u32 < 0 ||
>> cpu->icount_decr.u16.low + cpu->icount_extra == 0)
> Right.
>
>> But I'm not sure that you need to test u32. After all you're not
> Checking u32 is needed, bec
On Thu, Jan 26, 2017 at 12:32:58PM +0100, Igor Mammedov wrote:
> On Fri, 17 Jun 2016 16:36:36 +1000
> David Gibson wrote:
>
> > From: Bharata B Rao
> >
> > Remove the CPU core device by removing the underlying CPU thread devices.
> > Hot removal of CPU for sPAPR guests is achieved by sending th
ldl_p has a signed return type so assigning it to uint64_t implicitly
sign-extends the value. This results in devices with min_access_size = 8
seeing unexpected values passed to their write handlers.
Example: guest performs a 32-bit write of 0x8000 to an mmio region
and the handler receives 0x
1 - 100 of 233 matches
Mail list logo
