Host bridge device and PCI function #0 are inverted.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Message-Id: <20231012041237.22281-3-phi...@linaro.org>
---
hw/pci-host/sh_pci.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/pci-host
From: Marc-André Lureau
Return true/false on success/failure.
Signed-off-by: Marc-André Lureau
Reviewed-by: David Hildenbrand
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20231009075310.153617-1-marcandre.lur...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/core/cpu.h
pcspk_init() is a legacy init function, inline and remove it.
Since the device is realized using &error_fatal, use the same
error for setting the "pit" link.
Reviewed-by: Mark Cave-Ayland
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20231019073307.99608-1-phi...@linaro.org>
---
include/h
APICCommonClass::realize() is a DeviceRealize() handler which
take an Error** parameter and can fail. Do not proceed further
on failure.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Message-Id: <20231003082728.83496-2-phi...@linaro.org>
---
hw/intc/apic_common.c | 4
1 file
In order to make the next commit trivial, move sysbus_init_mmio()
calls just before the corresponding sysbus_mmio_map() calls.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Thomas Huth
Reviewed-by: LIU Zhiwei
Reviewed-by: Cédric Le Goater
Message-Id: <20231
From: Lu Gao
Block Size Register bits [14:12] is SDMA Buffer Boundary, it is missed
in register write, but it is needed in SDMA transfer. e.g. it will be
used in sdhci_sdma_transfer_multi_blocks to calculate boundary_ variables.
Missing this field will cause wrong operation for different SDMA Bu
From: Thomas Huth
hw/input/lasips2.c and the corresponding header include/hw/input/lasips2.h
are only used by the HPPA machine, so add them to the corresponding section
in the MAINTAINERS file.
Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Messag
When configuring with '--disable-cocoa --disable-coreaudio'
on Darwin, we get:
meson.build:4081:58: ERROR: Tried to access compiler for language "objc", not
specified for host machine.
meson.build:4097:47: ERROR: Tried to access unknown option 'objc_args'.
Instead of unconditionally display Ob
From: Thomas Huth
hw/openrisc/ is already listed here, so we should mention
the folder for the headers here, too.
Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20231017154242.234133-1-th...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
From: Marc-André Lureau
The argument is unused since commit bdc44640c ("cpu: Use QTAILQ for CPU list").
Signed-off-by: Marc-André Lureau
Reviewed-by: David Hildenbrand
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20231009075231.150568-1-marcandre.lur...@redhat.com>
Signed-off-by: Philippe
The following changes since commit 0d239e513e0117e66fa739fb71a43b9383a108ff:
Merge tag 'pull-lu-20231018' of https://gitlab.com/rth7680/qemu into staging
(2023-10-19 10:20:57 -0700)
are available in the Git repository at:
https://github.com/philmd/qemu.git tags/hw-misc-20231019
From: BALATON Zoltan
The VIA south bridges are now mostly used by other machines not just
fuloong2e so split off into a separate section and take maintainership.
Signed-off-by: BALATON Zoltan
Message-ID: <20231015141517.21931745...@zero.eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé
---
MA
Juan Quintela writes:
> Signed-off-by: Juan Quintela
Reviewed-by: Fabiano Rosas
On 10/19/23 22:49, Greg Kurz wrote:
Hi Juan,
On Thu, 19 Oct 2023 21:08:25 +0200
Juan Quintela wrote:
Current code does:
- register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
dependinfg on cpu number
- for newer machines, it register vmstate_icp with "icp/server" name
and
Juan Quintela writes:
> Sometimes devices have different features depending of things outside
> of qemu. For instance the kernel. Document how to handle that cases.
>
> Signed-off-by: Juan Quintela
> Acked-by: Peter Xu
> ---
Reviewed-by: Fabiano Rosas
Peter Xu writes:
> After we have errp which contains the more detailed error message, make
> ram_save_queue_pages() returns bool in its stack.
>
> Signed-off-by: Peter Xu
Reviewed-by: Fabiano Rosas
Peter Xu writes:
> Now we have a Error** passed into the return path thread stack, which is
> even clearer than an int retval. Change ram_dirty_bitmap_reload() and the
> callers to use a bool instead to replace errnos.
>
> Suggested-by: Philippe Mathieu-Daudé
> Signed-off-by: Peter Xu
Reviewe
Peter Xu writes:
> rp_state.error was a boolean used to show error happened in return path
> thread. That's not only duplicating error reporting (migrate_set_error),
> but also not good enough in that we only do error_report() and set it to
> true, we never can keep a history of the exact error
On 19/10/23 20:32, Matheus Tavares Bernardino wrote:
We duplicate "cmd" as strtok may modify its argument, but we forgot
to free it later. Furthermore, add_semihosting_arg doesn't take
responsibility for this memory either (it strdup's the argument).
Signed-off-by: Matheus Tavares Bernardino
--
On 10/19/23 15:08, Juan Quintela wrote:
Signed-off-by: Juan Quintela
---
docs/devel/migration.rst | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index c3e1400c0c..a9fde75862 100644
--- a/docs/devel/migrati
Hi Juan,
On Thu, 19 Oct 2023 21:08:25 +0200
Juan Quintela wrote:
> Current code does:
> - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
> dependinfg on cpu number
> - for newer machines, it register vmstate_icp with "icp/server" name
> and instance 0
> - now it unregiste
Create a mode migration parameter that can be used to select alternate
migration algorithms. The default mode is normal, representing the
current migration algorithm, and does not need to be explicitly set.
No functional change until a new mode is added, except that the mode is
shown by the 'info
Some devices block migration because they rely on local state that
is not migrated to the target host, such as for local filesystems.
These need not block cpr, which will restart qemu on the same host.
Narrow the scope of these blockers so they only apply to normal mode.
They will not block cpr mod
Add a mode migration parameter that can be used to select alternate
migration algorithms. The default mode is normal, representing the
current migration algorithm, and does not need to be explicitly set.
Provide the cpr-reboot migration mode for live update, which saves state to
a file. This all
Extend the blocker interface so that a blocker can be registered for
one or more migration modes. The existing interfaces register a
blocker for all modes, and the new interfaces take a varargs list
of modes.
Internally, maintain a separate blocker list per mode. The same Error
object may be add
Add the cpr-reboot migration mode. Usage:
$ qemu-system-$arch -monitor stdio ...
QEMU 8.1.50 monitor - type 'help' for more information
(qemu) migrate_set_capability x-ignore-shared on
(qemu) migrate_set_parameter mode cpr-reboot
(qemu) migrate -d file:vm.state
(qemu) info status
VM status: pause
On 10/19/23 15:08, Juan Quintela wrote:
I have no idea if we can have more than one vmware_vga device, so play
it safe.
Signed-off-by: Juan Quintela
Reviewed-by: Stefan Berger
---
hw/display/vmware_vga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/vm
The pca9552 INPUT0 and INPUT1 registers are supposed to
hold the logical values of the LED pins. A logical 0
should be seen in the INPUT0/1 registers for a pin when
its corresponding LSn bits are set to 0, which is also
the state needed for turning on an LED in a typical
usage scenario. Existing
Allow external devices to drive pca9552 input pins by adding
input GPIO's to the model. This allows a device to connect
its output GPIO's to the pca9552 input GPIO's.
In order for an external device to set the state of a pca9552
pin, the pin must first be configured for high impedance (LED
is off
This is a series of patches targeted at getting the pca9552
model ready for use by the powernv10 machine.
Glenn Miles (2):
misc/pca9552: Fix inverted input status
misc/pca9552: Let external devices set pca9552 inputs
hw/misc/pca9552.c | 51 +-
inc
On 10/19/23 15:08, Juan Quintela wrote:
We can have more than one audio card.
void audio_init_audiodevs(void)
{
AudiodevListEntry *e;
QSIMPLEQ_FOREACH(e, &audiodevs, next) {
audio_init(e->dev, &error_fatal);
}
}
Signed-off-by: Juan Quintela
Reviewed-by: Stefan Berg
On 10/19/23 15:08, Juan Quintela wrote:
We can have more than one eeprom93xx.
For instance:
e100_nic_realize() -> eeprom93xx_new()
Signed-off-by: Juan Quintela
Reviewed-by: Stefan Berger
---
hw/nvram/eeprom93xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nv
On 10/19/23 15:08, Juan Quintela wrote:
Each user network conection create a new slirp instance. We register
more than one slirp instance for number 0.
qemu-system-x86_64: -netdev user,id=hs1: savevm_state_handler_insert: Detected
duplicate SaveStateEntry: id=slirp, instance_id=0x0
Broken pi
On 10/19/23 15:08, Juan Quintela wrote:
Just with make check I can see that we can have more than one of this
devices, so use ANY.
ok 5 /s390x/device/introspect/abstract-interfaces
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEM
Akihiko Odaki writes:
> copy_call() has an unused parameter so remove it.
>
> Signed-off-by: Akihiko Odaki
Queued to plugins/next, thanks.
> ---
> accel/tcg/plugin-gen.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plug
On 10/19/23 15:08, Juan Quintela wrote:
Otherwise device-introspection-test fails.
$ ./tests/qtest/device-introspect-test
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered exit status 1 (expected 0)
Aborte
On 10/19/23 15:08, Juan Quintela wrote:
This are the easiest cases, where we were already using
VMSTATE_INSTANCE_ID_ANY.
Signed-off-by: Juan Quintela
Reviewed-by: Stefan Berger
---
backends/dbus-vmstate.c | 3 +--
backends/tpm/tpm_emulator.c | 3 +--
hw/i2c/core.c
On 10/19/23 15:08, Juan Quintela wrote:
We have lots of cases where we are using an instance_id==0 when we
should be using VMSTATE_INSTANCE_ID_ANY (-1). Basically everything
that can have more than one needs to have a proper instance_id or -1
and the system will take one for it.
vmstate_regis
Hyman Huang writes:
> Add migration dirty-limit capability test if kernel support
> dirty ring.
>
> Migration dirty-limit capability introduce dirty limit
> capability, two parameters: x-vcpu-dirty-limit-period and
> vcpu-dirty-limit are introduced to implement the live
> migration with dirty lim
Hyman Huang writes:
> The dirty limit feature has been introduced since the 8.1
> QEMU release but has not reflected in the document, add a
> section for that.
>
> Signed-off-by: Hyman Huang
> ---
> docs/devel/migration.rst | 71
> 1 file changed, 71 ins
Hyman Huang writes:
> Checking if dirty limit is in service is done by the
> dirtylimit_query_all function, drop the reduplicative
> check in the qmp_query_vcpu_dirty_limit function.
>
> Signed-off-by: Hyman Huang
Reviewed-by: Fabiano Rosas
Hyman Huang writes:
> Fix a race situation for global variable dirtylimit_state.
>
> Also, replace usleep by g_usleep to increase platform
> accessibility to the sleep function.
>
> Signed-off-by: Hyman Huang
Reviewed-by: Fabiano Rosas
On 19/10/2023 19.55, Nina Schoetterl-Glausch wrote:
On Thu, 2023-10-19 at 09:35 -0700, Stefan Hajnoczi wrote:
On Wed, 18 Oct 2023 at 06:09, Thomas Huth wrote:
From: Pierre Morel
During a subsystem reset the Topology-Change-Report is cleared
by the machine.
Let's ask KVM to clear the Modifie
From: Het Gala
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Signed-off-by: Fabiano Rosas
---
mig
Convert the file: URI to accept a FileMigrationArgs to be compatible
with the new migration QAPI.
Signed-off-by: Fabiano Rosas
---
migration/file.c | 22 +++---
migration/file.h | 9 ++---
migration/migration.c | 10 --
3 files changed, 17 insertions(+), 24
From: Het Gala
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for qmp migration.
For current series, limit the size of MigrateChannelList
to single element (single interface) as runtime check.
Suggested-by: Aravind Retn
Signed-off-by: Fabiano Rosas
---
qapi/migration.json | 8
1 file changed, 8 insertions(+)
diff --git a/qapi/migration.json b/qapi/migration.json
index 85ad5f2601..f51e6663bb 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1666,6 +1666,14 @@
#
From: Het Gala
migration_channels_and_uri_compatible() check for transport mechanism
suitable for multifd migration gets executed when the caller calls old
uri syntax. It needs it to be run when using the modern MigrateChannel
QAPI syntax too.
After URI -> 'MigrateChannel' :
migration_channels_a
From: Het Gala
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct.
Suggested-by: Aravind Retnakaran
Signed-off-b
From: Het Gala
This patch introduces well defined MigrateAddress struct
and its related child objects.
The existing argument of 'migrate' and 'migrate-incoming' QAPI
- 'uri' is of type string. The current implementation follows
double encoding scheme for fetching migration parameters like
'uri'
From: Het Gala
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Signed-off-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qte
Signed-off-by: Fabiano Rosas
---
migration/file.c | 2 +-
migration/file.h | 1 +
migration/migration.c | 6 ++
3 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/migration/file.c b/migration/file.c
index cf5b1bf365..ec069ef329 100644
--- a/migration/file.c
+++ b/migratio
From: Het Gala
RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs
accept new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for RDMA connection into well defined InetSocketAddress struct.
Suggested-by: Ara
Signed-off-by: Fabiano Rosas
---
qapi/migration.json | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index c352c7ac52..602cb706e3 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1519,10 +1519,25 @@
Het Gala writes:
> On 18/10/23 7:58 pm, Fabiano Rosas wrote:
>> Het Gala writes:
>>
>>> Fabiano, would your below commits impact this patchset 'make check'
>>> tests ? Because you have added tests for file based migration, which is
>>> still not included in this patchset.
>> AFAICS, the tests sh
From: Het Gala
Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for socket connection into well defined SocketAddress struct.
Suggested-by: Aravind R
From: Het Gala
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Signed-off-by: Fabiano Rosas
---
migration/migration-hmp-cmds.c | 27 +
From: Het Gala
MigrateChannelList allows to connect accross multiple interfaces.
Add MigrateChannelList struct as argument to migration QAPIs.
We plan to include multiple channels in future, to connnect
multiple interfaces. Hence, we choose 'MigrateChannelList'
as the new argument over 'MigrateC
Hi,
I had to make this a new version because the file: tests are already
merged and Het's patches break them unless we also convert the file
transport to the new API.
I did the conversion and added separate patches as fixups so we can
review my additions separately.
Het's series untouched aside
We can have more than one eeprom93xx.
For instance:
e100_nic_realize() -> eeprom93xx_new()
Signed-off-by: Juan Quintela
---
hw/nvram/eeprom93xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/nvram/eeprom93xx.c b/hw/nvram/eeprom93xx.c
index 1081e2cc0d..57d63638d7 100644
I have no idea if we can have more than one vmware_vga device, so play
it safe.
Signed-off-by: Juan Quintela
---
hw/display/vmware_vga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index 09591fbd39..7490d43881 100644
--- a
Each user network conection create a new slirp instance. We register
more than one slirp instance for number 0.
qemu-system-x86_64: -netdev user,id=hs1: savevm_state_handler_insert: Detected
duplicate SaveStateEntry: id=slirp, instance_id=0x0
Broken pipe
../../../../../mnt/code/qemu/full/tests/q
This are the easiest cases, where we were already using
VMSTATE_INSTANCE_ID_ANY.
Signed-off-by: Juan Quintela
---
backends/dbus-vmstate.c | 3 +--
backends/tpm/tpm_emulator.c | 3 +--
hw/i2c/core.c | 2 +-
hw/input/adb.c | 2 +-
hw/input/ads7846.c | 2 +-
We can have more than one audio card.
void audio_init_audiodevs(void)
{
AudiodevListEntry *e;
QSIMPLEQ_FOREACH(e, &audiodevs, next) {
audio_init(e->dev, &error_fatal);
}
}
Signed-off-by: Juan Quintela
---
audio/audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Just with make check I can see that we can have more than one of this
devices, so use ANY.
ok 5 /s390x/device/introspect/abstract-interfaces
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered exit status 1 (exp
Otherwise qom-test fails.
ok 4 /i386/qom/x-remote
qemu-system-i386: savevm_state_handler_insert: Detected duplicate
SaveStateEntry: id=isa-ide, instance_id=0x0
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered ex
Current code does:
- register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
dependinfg on cpu number
- for newer machines, it register vmstate_icp with "icp/server" name
and instance 0
- now it unregisters "icp/server" for the 1st instance.
This is wrong at many levels:
- we should
Signed-off-by: Juan Quintela
---
docs/devel/migration.rst | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index c3e1400c0c..a9fde75862 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -165,
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 9ca7e9cc48..d1282a78ef 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -28,6 +28,7 @
Il gio 19 ott 2023, 19:44 Richard Henderson
ha scritto:
> On 10/19/23 03:46, Paolo Bonzini wrote:
> > +/*
> > + * Write back flags after last memory access. Some newer ALU
> instructions, as
> > + * well as SSE instructions, write flags in the gen_* function, but
> that can
> > +
From: Peter Xu
Before finally register one SaveStateEntry, we detect for duplicated
entries. This could be helpful to notify us asap instead of get
silent migration failures which could be hard to diagnose.
For example, this patch will generate a message like this (if without
previous fixes on
We have lots of cases where we are using an instance_id==0 when we
should be using VMSTATE_INSTANCE_ID_ANY (-1). Basically everything
that can have more than one needs to have a proper instance_id or -1
and the system will take one for it.
vmstate_register_any(): We register with -1.
Signed-off-
Hi
This series are based in a patch from Peter than check if a we try to
register the same device with the same instance_id more than once. It
was not merged when he sent it because it broke "make check". So I
fixed all devices to be able to merge it.
- I create vmstate_register_any(), its the
Otherwise device-introspection-test fails.
$ ./tests/qtest/device-introspect-test
...
Broken pipe
../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried
to terminate QEMU process but encountered exit status 1 (expected 0)
Aborted (core dumped)
Signed-off-by: Juan Quintel
On Thu, Oct 19, 2023 at 08:41:26PM +0200, Juan Quintela wrote:
> We can changing pending_job to a bool if you preffer. I think that we
> have nailed all the off_by_one errors by now (famous last words).
Would it work to make pending_job a bool, even with SYNC? It seems to me
multifd_send_sync_ma
On Thu, Oct 19, 2023 at 08:28:05PM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > On Thu, Oct 19, 2023 at 05:00:02PM +0200, Juan Quintela wrote:
> >> Peter Xu wrote:
> >> > Fabiano,
> >> >
> >> > Sorry to look at this series late; I messed up my inbox after I reworked
> >> > my
> >> > arrange
On Thu, 19 Oct 2023 at 11:34, Michael S. Tsirkin wrote:
>
> On Thu, Oct 19, 2023 at 09:32:28AM -0700, Stefan Hajnoczi wrote:
> > On Wed, 18 Oct 2023 at 08:56, Michael S. Tsirkin wrote:
> > >
> > > From: Hawkins Jiawei
> > >
> > > This patch introduces vhost_vdpa_net_load_rss() to restore
> > > t
Fabiano Rosas wrote:
> Juan Quintela writes:
>
>> Fabiano Rosas wrote:
>>> Juan Quintela writes:
>>>
>>
>> This is a common pattern for concurrency. To not have your mutex locked
>> too long, you put a variable (that can only be tested/changed with the
>> lock) to explain that the "channel" is
From: Laszlo Ersek
The tails of the "vhost_user_set_vring_addr" and "vhost_user_set_u64"
functions are now byte-for-byte identical. Factor the common tail out to a
new function called "vhost_user_write_sync".
This is purely refactoring -- no observable change.
Cc: "Michael S. Tsirkin" (support
From: Zhao Liu
This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
type4").
In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of
threads in the socket is not more than 255, then smbios type4 table
encodes threads per socket into the thread count field.
So for t
From: Zhao Liu
This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
type4").
In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of
threads in the socket is more than 255, then smbios type4 table encodes
threads per socket into the thread count2 field.
So for the
Signed-off-by: Richard Henderson
---
target/i386/tcg/translate.c | 28 +++-
1 file changed, 3 insertions(+), 25 deletions(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 0c81e066de..d420ed8f0a 100644
--- a/target/i386/tcg/translate.c
+++ b/
Signed-off-by: Richard Henderson
---
target/xtensa/translate.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 54bee7ddba..de89940599 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
From: Bernhard Beschow
When the board assigns the ISA IRQs after the device's realize(), internal
devices such as the RTC can't be wired in ich9_lpc_realize() since the qemu_irqs
are still NULL. Fix that by assigning the ISA interrupts before realize().
This change is necessary for PIIX consolid
From: Ilya Maximets
Coverity scan reports multiple false-positive "defects" for the
following series of actions in virtio.c:
MemoryRegionCache indirect_desc_cache;
address_space_cache_init_empty(&indirect_desc_cache);
address_space_cache_destroy(&indirect_desc_cache);
For some reason it's
The two concrete type functions already existed, merely needing
a bit of hardening to invalid inputs.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 2 ++
include/tcg/tcg-op.h| 2 ++
tcg/tcg-op-ldst.c | 14 ++
3 files changed, 14 insertions(+),
From: Laszlo Ersek
At this point, only "vhost_user_write_sync" calls "enforce_reply"; embed
the latter into the former.
This is purely refactoring -- no observable change.
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez
On Thu, Oct 19, 2023 at 09:32:28AM -0700, Stefan Hajnoczi wrote:
> On Wed, 18 Oct 2023 at 08:56, Michael S. Tsirkin wrote:
> >
> > From: Hawkins Jiawei
> >
> > This patch introduces vhost_vdpa_net_load_rss() to restore
> > the hash calculation state at device's startup.
> >
> > Note that vhost_vd
From: Bernhard Beschow
TYPE_PIIX3_PCI_DEVICE was the former base class of the Xen and non-Xen variants
of the PIIX3 ISA device models. It will become the base class for the PIIX3 and
PIIX4 device models, so drop the "3" from the type names.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S
From: Ani Sinha
pc_get_device_memory_range() finds the device memory size by calculating the
difference between maxram and ram sizes. This calculation makes sense only when
maxram is greater than the ram size. Make sure we check for that before calling
pc_get_device_memory_range().
Signed-off-by
From: Bernhard Beschow
So far multi-process QEMU was only implemented for PIIX3. Move the support into
the base class to achieve feature parity between both device models.
Signed-off-by: Bernhard Beschow
Message-Id: <20231007123843.127151-29-shen...@gmail.com>
Reviewed-by: Michael S. Tsirkin
S
From: Bernhard Beschow
Unlike its PIIX4 counterpart, TYPE_PIIX3_DEVICE doesn't instantiate a PIC
itself. Instead, it relies on the board to do so. This means that the board
needs to wire the ISA IRQs to the PIIX3 device model. As long as the board
assigns the ISA IRQs after PIIX3's realize(), int
From: Bernhard Beschow
Avoid assigning the private member of struct PIIX3State from outside which goes
against best QOM practices. Instead, implement best QOM practice by adding an
"isa-irqs" array property to TYPE_PIIX3_DEVICE and assign it in board code, i.e.
from outside.
Signed-off-by: Bernh
The ext_and_shift_reg helper does this plus a shift.
The non-zero check for shift count is duplicate to
the one done within tcg_gen_shli_i64.
Signed-off-by: Richard Henderson
---
target/arm/tcg/translate-a64.c | 37 ++
1 file changed, 2 insertions(+), 35 deletions
From: Zhao Liu
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 1 - 3.
List the ACPI tables that will be added to test the type 4 core count
field.
Signed-off-by: Zhao Liu
Message-Id: <20230928125943.1816922-6-zhao1@linux.intel.com>
Reviewed-by: Michael S. Tsirkin
From: Li Feng
If the backend crashes and restarts, the device is broken.
This patch adds reconnect for vhost-user-scsi.
This patch also improves the error messages, and reports some silent errors.
Tested with spdk backend.
Signed-off-by: Li Feng
Message-Id: <20231009044735.941655-4-fen...@sma
From: Laszlo Ersek
Cc: "Michael S. Tsirkin" (supporter:vhost)
Cc: Eugenio Perez Martin
Cc: German Maglione
Cc: Liu Jiang
Cc: Sergio Lopez Pascual
Cc: Stefano Garzarella
Signed-off-by: Laszlo Ersek
Reviewed-by: Stefano Garzarella
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Albert Estev
From: Bernhard Beschow
Speeds up PIIX4 which resolves an old TODO. Also makes PIIX4 compatible with Xen
which relies on pci_bus_fire_intx_routing_notifier() to be fired.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
Message-Id: <20231007123843.127151-27-shen...@gmail.com>
Sig
From: Hawkins Jiawei
Next patches in this series will delay the polling
and checking of buffers until either the SVQ is
full or control commands shadow buffers are full,
no longer perform an immediate poll and check of
the device's used buffers for each CVQ state load command.
To achieve this, t
101 - 200 of 695 matches
Mail list logo
