[Impala-ASF-CR] IMPALA-9101: Add support for detecting self-events on partition events

2019-12-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14799 ) Change subject: IMPALA-9101: Add support for detecting self-events on partition events .. Patch Set 2: (3 comments) Thanks fo

[Impala-ASF-CR] IMPALA-9257: Last event id should be advanced if all events are skipped

2019-12-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14916 ) Change subject: IMPALA-9257: Last event id should be advanced if all events are skipped .. Patch Set 1: (1 comment) Looks goo

[Impala-ASF-CR] IMPALA-9257: Last event id should be advanced if all events are skipped

2019-12-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14916 ) Change subject: IMPALA-9257: Last event id should be advanced if all events are skipped .. Patch Set 2: Code-Review+1 -- To v

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support lo

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. Patch Set 4: (8 comm

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support lo

[Impala-ASF-CR] IMPALA-9101: Add support for detecting self-events on partition events

2020-01-08 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14799 ) Change subject: IMPALA-9101: Add support for detecting self-events on partition events .. Patch Set 5: Code-Review+1 (1 commen

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support lo

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-16 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. Patch Set 6: (1 comm

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. Patch Set 7: (5 comm

[Impala-ASF-CR] IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode.

2020-01-17 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/14731 ) Change subject: IMPALA-9158: Support loading primary key/foreign key constraints in LocalCatalog Mode. .. IMPALA-9158: Support lo

[Impala-ASF-CR] IMPALA-9311: Store SQLPrimaryKeys in canonical order.

2020-01-24 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15106 Change subject: IMPALA-9311: Store SQLPrimaryKeys in canonical order. .. IMPALA-9311: Store SQLPrimaryKeys in canonical order. H

[Impala-ASF-CR] IMPALA-9329: Don't add nested columns in TableMaskingView

2020-01-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15108 ) Change subject: IMPALA-9329: Don't add nested columns in TableMaskingView .. Patch Set 4: Code-Review+1 The patch looks good to

[Impala-ASF-CR] IMPALA-9311: Store SQLPrimaryKeys in canonical order.

2020-01-27 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15106 ) Change subject: IMPALA-9311: Store SQLPrimaryKeys in canonical order. .. Patch Set 1: Could you also please merge this, Tim?

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 1: (5 comments) Thanks for making these changes to the docs. I ha

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 2: (1 comment) Thanks for addressing my comments. Another minor c

[Impala-ASF-CR] IMPALA-9330: Resolve nested types of masked tables

2020-02-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15108 ) Change subject: IMPALA-9330: Resolve nested types of masked tables .. Patch Set 7: Code-Review+1 (1 comment) The patch makes s

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-02 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15146/3/docs/t

[Impala-ASF-CR] IMPALA-9336: [DOCS] constraints

2020-02-03 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15146 ) Change subject: IMPALA-9336: [DOCS] constraints .. Patch Set 4: Code-Review+1 Looks good to me. -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-9358: Query slowdown with inline views and hundreds of columns

2020-02-04 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 ) Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns .. Patch Set 1: (2 comments) Thanks for

[Impala-ASF-CR] IMPALA-9358: Query slowdown with inline views and hundreds of columns

2020-02-05 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 ) Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns .. Patch Set 2: Code-Review+1 LGTM! I ra

[Impala-ASF-CR] IMPALA-8852: Skipping short-circuit config check for coordinator only

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only .. Patch Set 2: (5 comments) Thanks for

[Impala-ASF-CR] IMPALA-8852: Skipping short-circuit config check for coordinator only

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skipping short-circuit config check for coordinator only .. Patch Set 2: (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-8795 : Enable event polling by default in dockerized tests.

2020-02-06 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/14272 ) Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. .. IMPALA-8795 : Enable event polling by defa

[Impala-ASF-CR] IMPALA-9358: Query slowdown with inline views and hundreds of columns

2020-02-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15157 ) Change subject: IMPALA-9358: Query slowdown with inline views and hundreds of columns .. Patch Set 3: Code-Review+1 -- To vie

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-07 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 3: Code-Review+1 (1 commen

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for coordinator-only mode

2020-02-09 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for coordinator-only mode .. Patch Set 4: Code-Review+1 LGTM. -

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-12 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15213 Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. IMPALA-9256: Refactor constraint informat

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-13 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 1: The build errors are due t

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. IMPALA-9256: Refactor constraint informati

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. Patch Set 4: (2 comments) http://gerri

[Impala-ASF-CR] IMPALA-9256: Refactor constraint information into a separate class.

2020-02-14 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15213 ) Change subject: IMPALA-9256: Refactor constraint information into a separate class. .. IMPALA-9256: Refactor constraint informati

[Impala-ASF-CR] IMPALA-9386: Remove hive-metastore dependency from hive-3 profile

2020-02-19 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15223 ) Change subject: IMPALA-9386: Remove hive-metastore dependency from hive-3 profile .. Patch Set 2: Abandon this? -- To view,

[Impala-ASF-CR] IMPALA-6689: Speed up point lookup for Kudu primary key

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15250 ) Change subject: IMPALA-6689: Speed up point lookup for Kudu primary key .. Patch Set 2: I agree that these optimizations could

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15263 Change subject: IMPALA-9369: Make createInsertEvents() async. .. IMPALA-9369: Make createInsertEvents() async. This patch makes

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-02-20 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-8852: Skip short-circuit config check for dedicated coordinator

2020-02-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15173 ) Change subject: IMPALA-8852: Skip short-circuit config check for dedicated coordinator .. Patch Set 10: Code-Review+1 LGTM!

[Impala-ASF-CR] IMPALA-9357: Fix race condition in alter database event

2020-02-21 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15260 ) Change subject: IMPALA-9357: Fix race condition in alter_database event .. Patch Set 1: Code-Review+1 LGTM. -- To view, visit

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-03-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. IMPALA-9369: Make createInsertEvents() async. This patch makes t

[Impala-ASF-CR] IMPALA-9369: Make createInsertEvents() async.

2020-03-01 Thread Anurag Mantripragada (Code Review)
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15263 ) Change subject: IMPALA-9369: Make createInsertEvents() async. .. Patch Set 2: Thanks for researching CompletableFuture :) I add

<    1   2   3   4