[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-11-17 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new change for review. http://gerrit.cloudera.org:8080/5137 Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. IMPALA-4033,IMPALA-4105: Improvements of partition DDL. This

[Impala-ASF-CR] IMPALA-2890: Support ALTER TABLE statements for Kudu tables

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5136 Change subject: IMPALA-2890: Support ALTER TABLE statements for Kudu tables .. IMPALA-2890: Support ALTER TABLE statements for

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. Patch Set 3: s/binary/dictionary in last comment. -- To view, visit

[Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner .. IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner * Extend

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 8: Code-Review+2 Minor test fix and rebase. Carry Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5026 to look at the new patch set (#8). Change subject: IMPALA-3726: Add support for Kudu-specific column options

[Impala-ASF-CR] IMPALA-4510: Selectively filter args for metric verification tests

2016-11-17 Thread David Knupp (Code Review)
David Knupp has uploaded a new change for review. http://gerrit.cloudera.org:8080/5135 Change subject: IMPALA-4510: Selectively filter args for metric verification tests .. IMPALA-4510: Selectively filter args for metric

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Don't overwrite user's .ssh/config file when bootstrapping .. Patch Set 3: > Build failed: >

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

2016-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Don't overwrite user's .ssh/config file when bootstrapping .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4967 To

[Impala-ASF-CR] Don't overwrite user's .ssh/config file when bootstrapping

2016-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Don't overwrite user's .ssh/config file when bootstrapping .. Don't overwrite user's .ssh/config file when bootstrapping >From bash's manual

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#5). Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 4: Code-Review+1 Carry Tim's +1 forward. -- To view, visit

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5105 to look at the new patch set (#4). Change subject: IMPALA-4432: Handle internal codegen disabling properly ..

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. IMPALA-3200: Implement suballocator for splitting buffers This is useful for situations like hash

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. Patch Set 4: (4 comments)

[Impala-ASF-CR] IMPALA-3200: Implement suballocator for splitting buffers

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3200: Implement suballocator for splitting buffers .. Patch Set 4: (34 comments) http://gerrit.cloudera.org:8080/#/c/4715/4//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter stats updates .. IMPALA-3838, IMPALA-4495: Codegen EvalRuntimeFilters() and fixes filter

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4833/3/be/src/exec/filter-context.cc File

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4833/3//COMMIT_MSG Commit Message: PS3, Line 7:

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4833/1/be/src/exec/hdfs-parquet-scanner-ir.cc File

[Impala-ASF-CR] IMPALA-3838: Codegen EvalRuntimeFilters().

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-3838: Codegen EvalRuntimeFilters(). .. IMPALA-3838: Codegen EvalRuntimeFilters(). This change codegens HdfsParquetScanner::EvalRuntimeFilters() by unrolling

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. IMPALA-4490: Only generate runtime filters for hash join nodes. Change-Id:

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5117 To

[Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4410: Safer tear-down of RuntimeState .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4893/2/be/src/runtime/test-env.cc File

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt File

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 15: (5 comments)

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-17 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4956 to look at the new patch set (#8). Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory ..

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4956/7/be/src/codegen/llvm-codegen.h

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-3398: Add docs to main Impala branch. .. IMPALA-3398: Add docs to main Impala branch. These are refugees from doc_prototype. They can be rendered

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-17 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3398: Add docs to main Impala branch. .. Patch Set 2: Code-Review+2 Verified+1 Got clean build of both SQL Ref and entire Impala doc bundle. -- To view,

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Add docs to main Impala branch. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5014/1/docs/impala_sqlref.ditamap File

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-3398: Add docs to main Impala branch. .. IMPALA-3398: Add docs to main Impala branch. These are refugees from doc_prototype. They can be rendered with the DITA

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-17 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3398: Add docs to main Impala branch. .. Patch Set 1: (1 comment) Appended the updated attribute key/value pair.

[Impala-ASF-CR] IMPALA-3398: Add docs to main Impala branch.

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3398: Add docs to main Impala branch. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5014/1/docs/impala_sqlref.ditamap File

[Impala-ASF-CR] IMPALA-3202: refactor scratch file management into TmpFileMgr

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3202: refactor scratch file management into TmpFileMgr .. IMPALA-3202: refactor scratch file management into TmpFileMgr This is a pure

[Impala-ASF-CR] IMPALA-3202: refactor scratch file management into TmpFileMgr

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3202: refactor scratch file management into TmpFileMgr .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4898 To

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5095

[Impala-ASF-CR] IMPALA-4476: Use unique database to stop races in test udfs.py

2016-11-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4476: Use unique_database to stop races in test_udfs.py .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5124 To

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/6//COMMIT_MSG Commit Message: PS6, Line

[Impala-ASF-CR] IMPALA-4363: Add Parquet timestamp validation

2016-11-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. Change subject: IMPALA-4363: Add Parquet timestamp validation .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4968/6//COMMIT_MSG Commit Message: PS6, Line 12:

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 7: Code-Review+1 (3 comments)

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3726: Add support for Kudu-specific column options .. Patch Set 7: Code-Review+2 (2 comments) Rebase and fixing tests, carry Alex's +2

[Impala-ASF-CR] IMPALA-3726: Add support for Kudu-specific column options

2016-11-17 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5026 to look at the new patch set (#7). Change subject: IMPALA-3726: Add support for Kudu-specific column options ..

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 1: (1 comment) It might be best to special-case the local backend. At a high level this is the most

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt File

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-4490: Only generate runtime filters for hash join nodes.

2016-11-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4490: Only generate runtime filters for hash join nodes. .. Patch Set 3: Any more comments? -- To view, visit http://gerrit.cloudera.org:8080/5117 To

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 1: Thanks for your feedback. I agree that this is not optimal, and if there was a way to send the

[Impala-ASF-CR] IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions

2016-11-17 Thread Dan Hecht (Code Review)
Dan Hecht has uploaded a new change for review. http://gerrit.cloudera.org:8080/5129 Change subject: IMPALA-4440: lineage timestamps can go backwards across daylight savings transitions .. IMPALA-4440: lineage timestamps can

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. Patch Set 1: This is better than crashing, but it also seems like we shouldn't fail queries for this reason.

[Impala-ASF-CR] IMPALA-4494: Fix crash in SimpleScheduler

2016-11-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/5127 Change subject: IMPALA-4494: Fix crash in SimpleScheduler .. IMPALA-4494: Fix crash in SimpleScheduler The scheduler maintains a local

[Impala-ASF-CR] IMPALA-4397,IMPALA-3259: reduce codegen time and memory

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4397,IMPALA-3259: reduce codegen time and memory .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4956/4/be/src/exec/hdfs-scanner.h File

[Impala-ASF-CR] IMPALA-4476: Use unique database to stop races in test udfs.py

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4476: Use unique_database to stop races in test_udfs.py .. Patch Set 2: Code-Review+2 (1 comment) Carry +2

[Impala-ASF-CR] IMPALA-4476: Use unique database to stop races in test udfs.py

2016-11-17 Thread Jim Apple (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5124 to look at the new patch set (#2). Change subject: IMPALA-4476: Use unique_database to stop races in test_udfs.py ..

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 1: (26 comments) > (22 comments) > > what's the plan for keeping this

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Add a build flag for the undefined behavior sanitizer, aka "ubsan". Ubsan checks for undefined

[Impala-ASF-CR] IMPALA-4432: Handle internal codegen disabling properly

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4432: Handle internal codegen disabling properly .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-3202: refactor scratch file management into TmpFileMgr

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: refactor scratch file management into TmpFileMgr .. Patch Set 6: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/4898 To

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next .. Patch Set 1: Code-Review+2 Verified+1 Merge from master. Confirmed that it compiled locally on

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next .. Merge remote-tracking branch 'origin/master' into hadoop-next Change-Id:

[Impala-ASF-CR](hadoop-next) Merge remote-tracking branch 'origin/master' into hadoop-next

2016-11-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5126 Change subject: Merge remote-tracking branch 'origin/master' into hadoop-next .. Merge remote-tracking branch 'origin/master' into

[Impala-ASF-CR] IMPALA-4476: Use unique database to stop races in test udfs.py

2016-11-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4476: Use unique_database to stop races in test_udfs.py .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

2016-11-17 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/5125 Change subject: IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE. .. IMPALA-3809: Show Kudu-specific column metadata in DESCRIBE.

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/4863/13/be/src/exec/hdfs-table-sink.cc

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-17 Thread Lars Volker (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#15). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-17 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. Patch Set 3: > > Thanks!Do you think I should add some code to catalog to validate >

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-17 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#3). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present .. IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present This change

[Impala-ASF-CR] IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

2016-11-17 Thread Attila Jeges (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5095 to look at the new patch set (#3). Change subject: IMPALA-4278: Don't abort Catalog startup quickly if HMS is not present

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input .. Patch Set 13: (10 comments) Thanks for the review. Please see PS14.

[Impala-ASF-CR] IMPALA-2523: Make HdfsTableSink aware of clustered input

2016-11-17 Thread Lars Volker (Code Review)
Hello Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4863 to look at the new patch set (#14). Change subject: IMPALA-2523: Make HdfsTableSink aware of clustered input

[Impala-ASF-CR] IMPALA-4476: Use unique database to stop races in test udfs.py

2016-11-17 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/5124 Change subject: IMPALA-4476: Use unique_database to stop races in test_udfs.py .. IMPALA-4476: Use unique_database to stop races in

[Impala-ASF-CR] Improve message output from run-step.sh

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Improve message output from run-step.sh .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5116 To unsubscribe, visit

[Impala-ASF-CR] Improve message output from run-step.sh

2016-11-17 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Improve message output from run-step.sh .. Improve message output from run-step.sh run-step prints a message to tell the reader what it's doing.