[GitHub] [iotdb] neuyilan commented on a diff in pull request #8673: fix the wal comment

2023-01-03 Thread GitBox
neuyilan commented on code in PR #8673: URL: https://github.com/apache/iotdb/pull/8673#discussion_r1061081221 ## server/src/main/java/org/apache/iotdb/db/wal/utils/WALFileUtils.java: ## @@ -105,15 +105,15 @@ public static void ascSortByVersionId(File[] walFiles) { /** *

[GitHub] [iotdb] HTHou opened a new pull request, #8725: [To rel/0.13][IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
HTHou opened a new pull request, #8725: URL: https://github.com/apache/iotdb/pull/8725 ## Description See IOTDB-5346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8724: [IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8724: URL: https://github.com/apache/iotdb/pull/8724#issuecomment-1370393375 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] HTHou opened a new pull request, #8724: [IOTDB-5346] Fix log error in MemtableFlushTask when recovering

2023-01-03 Thread GitBox
HTHou opened a new pull request, #8724: URL: https://github.com/apache/iotdb/pull/8724 ## Description ![52241672732815_ pic](https://user-images.githubusercontent.com/25913899/210467279-626d4987-bcc7-417d-b099-a9e8f475f9e0.jpg) -- This is an automated message from the Apache Gi

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8721: [IOTDB-5342] Separate filtering and business logic in AbstractTreeVisitor

2023-01-03 Thread GitBox
MarcosZyk commented on code in PR #8721: URL: https://github.com/apache/iotdb/pull/8721#discussion_r1061057693 ## node-commons/src/main/java/org/apache/iotdb/commons/schema/tree/AbstractTreeVisitor.java: ## @@ -189,17 +195,26 @@ protected void getNext() throws Exception {

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1060804526 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/EventWindow.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1060803930 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowParameter.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1370015059 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] ZhanGHanG9991 commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ZhanGHanG9991 commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1060770627 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/WindowManagerFactory.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8723: Change Variables to Variable

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8723: URL: https://github.com/apache/iotdb/pull/8723#issuecomment-1369947020 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8711: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8711: URL: https://github.com/apache/iotdb/pull/8711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] Alima777 merged pull request #8706: [To rel/1.0] [IOTDB-5309] Wrong calculation for retained size of tsblock calculate

2023-01-03 Thread GitBox
Alima777 merged PR #8706: URL: https://github.com/apache/iotdb/pull/8706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apach

[GitHub] [iotdb] Beyyes merged pull request #8708: [IOTDB-5326] Add cluster_name parameter

2023-01-03 Thread GitBox
Beyyes merged PR #8708: URL: https://github.com/apache/iotdb/pull/8708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] ycycse commented on a diff in pull request #7693: [IOTDB-4437] Implement event window in RawDataAggregationOperator

2023-01-03 Thread GitBox
ycycse commented on code in PR #7693: URL: https://github.com/apache/iotdb/pull/7693#discussion_r1056021652 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/window/EqualEventBooleanWindowManager.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8712: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8712: URL: https://github.com/apache/iotdb/pull/8712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8714: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8714: URL: https://github.com/apache/iotdb/pull/8714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8710: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8710: URL: https://github.com/apache/iotdb/pull/8710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8709: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-03 Thread GitBox
OneSizeFitsQuorum merged PR #8709: URL: https://github.com/apache/iotdb/pull/8709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8721: [IOTDB-5342] Separate filtering and business logic in AbstractTreeVisitor

2023-01-03 Thread GitBox
Cpaulyz opened a new pull request, #8721: URL: https://github.com/apache/iotdb/pull/8721 ## Description 1. Separate filtering and business logic in AbstractTreeVisitor. ``` /** * Internal-match means the node matches an internal node name of the given path pattern. root.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369728582 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] JackieTien97 merged pull request #8719: [To rel/1.0][IOTDB-5316] fix bug that Session.setFetchSize is not used in the following fetch requests

2023-01-03 Thread GitBox
JackieTien97 merged PR #8719: URL: https://github.com/apache/iotdb/pull/8719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] Beyyes merged pull request #8718: Fix testGetSlots IT bug

2023-01-03 Thread GitBox
Beyyes merged PR #8718: URL: https://github.com/apache/iotdb/pull/8718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] Beyyes merged pull request #8715: Rename SQL show cluster parameters to show variables

2023-01-03 Thread GitBox
Beyyes merged PR #8715: URL: https://github.com/apache/iotdb/pull/8715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369639661 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] choubenson opened a new pull request, #8720: [IOTDB-5207] Reconstruct compaction package

2023-01-03 Thread GitBox
choubenson opened a new pull request, #8720: URL: https://github.com/apache/iotdb/pull/8720 ![image](https://user-images.githubusercontent.com/45144903/210340986-7b7d8803-efcb-49f6-b5af-16c72eeaec81.png) -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1369582095 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369564220 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] MarcosZyk merged pull request #8677: [IOTDB-3063] Set up SchemaReader and apply them in show devices and show timeseries

2023-01-03 Thread GitBox
MarcosZyk merged PR #8677: URL: https://github.com/apache/iotdb/pull/8677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8718: Fix testGetSlots IT bug

2023-01-03 Thread GitBox
CRZbulabula opened a new pull request, #8718: URL: https://github.com/apache/iotdb/pull/8718 Modify a test configuration to avoid local test bug. Since our local computers always have sufficient CPUs, this IT will create DataRegionGroups for each StorageGroups that more than expected(leastD

[GitHub] [iotdb] HeimingZ opened a new pull request, #8717: [IOTDB-5285] Modifying system properties before the initial startup causes the datanode to fail to start

2023-01-03 Thread GitBox
HeimingZ opened a new pull request, #8717: URL: https://github.com/apache/iotdb/pull/8717 The system writes system.properties before pulling config from the confignode, which causes error when the first startup. So, I overwrite the system.properties when the first startup. -- This is an

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8708: [IOTDB-5326] Add cluster_name parameter

2023-01-03 Thread GitBox
CRZbulabula commented on code in PR #8708: URL: https://github.com/apache/iotdb/pull/8708#discussion_r1060371307 ## server/src/assembly/resources/conf/iotdb-datanode.properties: ## @@ -17,6 +17,14 @@ # under the License. # + +### Cluster Configuration +##

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-03 Thread GitBox
sonarcloud[bot] commented on PR #8650: URL: https://github.com/apache/iotdb/pull/8650#issuecomment-1369510780 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] liuminghui233 merged pull request #8684: Fix typo in query metric

2023-01-03 Thread GitBox
liuminghui233 merged PR #8684: URL: https://github.com/apache/iotdb/pull/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.

[GitHub] [iotdb] JackieTien97 merged pull request #8716: [To rel/1.0] [IOTDB-5245] Fix bug in last query

2023-01-02 Thread GitBox
JackieTien97 merged PR #8716: URL: https://github.com/apache/iotdb/pull/8716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] neuyilan commented on pull request #8489: [IOTDB-5176] Change ratis snapshot dir with datadir

2023-01-02 Thread GitBox
neuyilan commented on PR #8489: URL: https://github.com/apache/iotdb/pull/8489#issuecomment-1369460826 Why not cherry-pick to rel/1.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8677: [IOTDB-3063] Set up SchemaReader and apply them in show devices and show timeseries

2023-01-02 Thread GitBox
MarcosZyk commented on code in PR #8677: URL: https://github.com/apache/iotdb/pull/8677#discussion_r1060310797 ## server/src/main/java/org/apache/iotdb/db/metadata/schemaregion/ISchemaRegion.java: ## @@ -265,8 +269,7 @@ Set getMatchedDevices(PartialPath pathPattern, boolean isP

[GitHub] [iotdb] HTHou merged pull request #8626: [To rel/0.13][IOTDB-5296]fix close session npe when session is null

2023-01-02 Thread GitBox
HTHou merged PR #8626: URL: https://github.com/apache/iotdb/pull/8626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] HTHou merged pull request #8678: [IOTDB-5228]NPE if the file does not exist when create TsFileSequenceR…

2023-01-02 Thread GitBox
HTHou merged PR #8678: URL: https://github.com/apache/iotdb/pull/8678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.o

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1369430716 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8716: [To rel/1.0] [IOTDB-5245] Fix bug in last query

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8716: URL: https://github.com/apache/iotdb/pull/8716#issuecomment-1369427337 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] ericpai merged pull request #8707: [To rel/1.0][IOTDB-5333] Fix a typo of max_tsblock_line_number in iotdb-common.properties

2023-01-02 Thread GitBox
ericpai merged PR #8707: URL: https://github.com/apache/iotdb/pull/8707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] Beyyes merged pull request #8713: Fix cluster_name definition conflict

2023-01-02 Thread GitBox
Beyyes merged PR #8713: URL: https://github.com/apache/iotdb/pull/8713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.

[GitHub] [iotdb] JackieTien97 opened a new pull request, #8716: [To rel/1.0] [IOTDB-5245] Fix bug in last query

2023-01-02 Thread GitBox
JackieTien97 opened a new pull request, #8716: URL: https://github.com/apache/iotdb/pull/8716 (cherry picked from commit bc887772cdf0a0fe4a091bab221b2ff36271d73b) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [iotdb] JackieTien97 merged pull request #8683: [IOTDB-5245] Fix bug in last query

2023-01-02 Thread GitBox
JackieTien97 merged PR #8683: URL: https://github.com/apache/iotdb/pull/8683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] Cpaulyz commented on a diff in pull request #8677: [IOTDB-3063] Set up SchemaReader and apply them in show devices and show timeseries

2023-01-02 Thread GitBox
Cpaulyz commented on code in PR #8677: URL: https://github.com/apache/iotdb/pull/8677#discussion_r1060287160 ## server/src/main/java/org/apache/iotdb/db/metadata/schemaregion/ISchemaRegion.java: ## @@ -265,8 +269,7 @@ Set getMatchedDevices(PartialPath pathPattern, boolean isPre

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8715: Rename SQL show cluster parameters to show variables

2023-01-02 Thread GitBox
CRZbulabula opened a new pull request, #8715: URL: https://github.com/apache/iotdb/pull/8715 Rename and update related user docs. Test result: https://user-images.githubusercontent.com/33111881/210302099-33d04051-ab84-400b-a1a6-d4dead87a85e.png";> -- This is an automated message

[GitHub] [iotdb] BUAAserein opened a new pull request, #8714: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-02 Thread GitBox
BUAAserein opened a new pull request, #8714: URL: https://github.com/apache/iotdb/pull/8714 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] BUAAserein opened a new pull request, #8712: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-02 Thread GitBox
BUAAserein opened a new pull request, #8712: URL: https://github.com/apache/iotdb/pull/8712 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] BUAAserein opened a new pull request, #8711: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-02 Thread GitBox
BUAAserein opened a new pull request, #8711: URL: https://github.com/apache/iotdb/pull/8711 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] ericpai commented on a diff in pull request #8708: [IOTDB-5326] Add cluster_name parameter

2023-01-02 Thread GitBox
ericpai commented on code in PR #8708: URL: https://github.com/apache/iotdb/pull/8708#discussion_r1060271229 ## server/src/assembly/resources/conf/iotdb-datanode.properties: ## @@ -17,6 +17,14 @@ # under the License. # + +### Cluster Configuration +##

[GitHub] [iotdb] BUAAserein opened a new pull request, #8710: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-02 Thread GitBox
BUAAserein opened a new pull request, #8710: URL: https://github.com/apache/iotdb/pull/8710 - cherry-pick from master. - https://github.com/apache/iotdb/pull/8648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [iotdb] BUAAserein opened a new pull request, #8709: [To rel/1.0][IOTDB-5284] Fix some code smells

2023-01-02 Thread GitBox
BUAAserein opened a new pull request, #8709: URL: https://github.com/apache/iotdb/pull/8709 - fix some code smells - cherry-pick from master. https://github.com/apache/iotdb/pull/8647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8707: [To rel/1.0][IOTDB-5333] Fix a typo of max_tsblock_line_number in iotdb-common.properties

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8707: URL: https://github.com/apache/iotdb/pull/8707#issuecomment-1369379491 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] CRZbulabula opened a new pull request, #8708: [IOTDB-5326] Add cluster_name parameter

2023-01-02 Thread GitBox
CRZbulabula opened a new pull request, #8708: URL: https://github.com/apache/iotdb/pull/8708 Add cluster_name parameter for which the user can distinguish different clusters. The cluster_name is configurable as shown below: https://user-images.githubusercontent.com/33111881/210298704-

[GitHub] [iotdb] ericpai opened a new pull request, #8707: [To rel/1.0][IOTDB-5333] Fix a typo of max_tsblock_line_number in iotdb-common.properties

2023-01-02 Thread GitBox
ericpai opened a new pull request, #8707: URL: https://github.com/apache/iotdb/pull/8707 A cherry pick of #8705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8706: [To rel/1.0] [IOTDB-5309] Wrong calculation for retained size of tsblock calculate

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8706: URL: https://github.com/apache/iotdb/pull/8706#issuecomment-1369369192 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb-tsfile-viewer] qiaojialin merged pull request #10: [IOTDB-5254][IOTDB-5251] BUG FIX

2023-01-02 Thread GitBox
qiaojialin merged PR #10: URL: https://github.com/apache/iotdb-tsfile-viewer/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...

[GitHub] [iotdb] ericpai merged pull request #8705: [IOTDB-5333] Fix a typo of max_tsblock_line_number in iotdb-common.properties

2023-01-02 Thread GitBox
ericpai merged PR #8705: URL: https://github.com/apache/iotdb/pull/8705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache

[GitHub] [iotdb] SpriCoder merged pull request #8704: [To rel/1.0] [IOTDB-5330] Add the details of normal level metrics in zh

2023-01-02 Thread GitBox
SpriCoder merged PR #8704: URL: https://github.com/apache/iotdb/pull/8704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] SpriCoder merged pull request #8703: [IOTDB-5330] Add the details of normal level metrics in zh

2023-01-02 Thread GitBox
SpriCoder merged PR #8703: URL: https://github.com/apache/iotdb/pull/8703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] xingtanzjr merged pull request #8646: [IOTDB-5285] TimePartition may be error when restarting with different time partition configuration

2023-01-02 Thread GitBox
xingtanzjr merged PR #8646: URL: https://github.com/apache/iotdb/pull/8646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] THUMarkLau merged pull request #8614: [IOTDB-5160] [Metric] Fix the file count of datanode become negative number

2023-01-02 Thread GitBox
THUMarkLau merged PR #8614: URL: https://github.com/apache/iotdb/pull/8614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apa

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8705: Fix a typo of iotdb-common.properties

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8705: URL: https://github.com/apache/iotdb/pull/8705#issuecomment-1369340739 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8650: [IOTDB-5308] Limit the output tsblock's size of each operator[Part1]

2023-01-02 Thread GitBox
JackieTien97 commented on code in PR #8650: URL: https://github.com/apache/iotdb/pull/8650#discussion_r1060251167 ## server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/source/AlignedSeriesScanOperator.java: ## @@ -77,13 +84,35 @@ public OperatorContext getOperatorCo

[GitHub] [iotdb] ohaTgxK9956562414460 commented on issue #6904: SessionPool 连接3个节点集群超时

2023-01-02 Thread GitBox
ohaTgxK9956562414460 commented on issue #6904: URL: https://github.com/apache/iotdb/issues/6904#issuecomment-1369337386 > 兄弟,你这个问题解决了吗?我这也遇到了 没有解决,直接改成单节点,集群问题太多,也不稳定。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [iotdb] ericpai opened a new pull request, #8705: Fix a typo of iotdb-common.properties

2023-01-02 Thread GitBox
ericpai opened a new pull request, #8705: URL: https://github.com/apache/iotdb/pull/8705 The Java code: ![image](https://user-images.githubusercontent.com/3821212/210293085-c85defc1-c5f5-420a-b8ce-6d9acdd4c7ad.png) -- This is an automated message from the Apache Git Service. To res

[GitHub] [iotdb] JackieTien97 merged pull request #8342: Make some code more efficient

2023-01-02 Thread GitBox
JackieTien97 merged PR #8342: URL: https://github.com/apache/iotdb/pull/8342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1369334088 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8666: [IOTDB-5320] Add executeAggregationQuery interface in session API (java)

2023-01-02 Thread GitBox
JackieTien97 commented on code in PR #8666: URL: https://github.com/apache/iotdb/pull/8666#discussion_r1060233868 ## thrift/src/main/thrift/client.thrift: ## @@ -545,6 +560,8 @@ service IClientRPCService { TSExecuteStatementResp executeLastDataQuery(1:TSLastDataQueryReq req

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8683: Fix bug in last query

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8683: URL: https://github.com/apache/iotdb/pull/8683#issuecomment-1369327029 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate

[GitHub] [iotdb] HeimingZ commented on a diff in pull request #8673: fix the wal comment

2023-01-02 Thread GitBox
HeimingZ commented on code in PR #8673: URL: https://github.com/apache/iotdb/pull/8673#discussion_r1060232885 ## server/src/main/java/org/apache/iotdb/db/wal/utils/WALFileUtils.java: ## @@ -105,15 +105,15 @@ public static void ascSortByVersionId(File[] walFiles) { /** *

[GitHub] [iotdb] JackieTien97 merged pull request #8665: [IOTDB-5316] fix bug that Session.setFetchSize is not used in the following fetch requests

2023-01-02 Thread GitBox
JackieTien97 merged PR #8665: URL: https://github.com/apache/iotdb/pull/8665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] JackieTien97 merged pull request #8649: [IOTDB-5309] Wrong calculation for retained size of tsblock calculate

2023-01-02 Thread GitBox
JackieTien97 merged PR #8649: URL: https://github.com/apache/iotdb/pull/8649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.a

[GitHub] [iotdb] MarcosZyk merged pull request #8700: [IOTDB-5329] Exception handler for AbstractTreeVisitor

2023-01-02 Thread GitBox
MarcosZyk merged PR #8700: URL: https://github.com/apache/iotdb/pull/8700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] ccliushou commented on issue #8618: 关于0.13版本的TsFile 同步方式bug

2023-01-02 Thread GitBox
ccliushou commented on issue #8618: URL: https://github.com/apache/iotdb/issues/8618#issuecomment-1369282310 感谢您的回答。我按照这个步骤操作了,但,接收端还是没有那数据: 1.找到IOTDB_HOME/data/data目录下,删除所有sync开头的文件夹(发送端) 2.重启sync工具 看接收端的输出的日志,还是感觉有bug: 2023-01-03 08:04:36,565 [main] INFO o.a.i.d

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8648: [IOTDB-5284] Fix some code smells

2023-01-02 Thread GitBox
OneSizeFitsQuorum merged PR #8648: URL: https://github.com/apache/iotdb/pull/8648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368910021 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] MarcosZyk merged pull request #8702: Add deadband columns to User-Guide SQL examples

2023-01-02 Thread GitBox
MarcosZyk merged PR #8702: URL: https://github.com/apache/iotdb/pull/8702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8702: Add deadband column to User-Guide SQL examples

2023-01-02 Thread GitBox
MarcosZyk opened a new pull request, #8702: URL: https://github.com/apache/iotdb/pull/8702 ## Description Add deadband column to User-Guide SQL examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [iotdb] MarcosZyk merged pull request #8701: [To rel/1.0] Add deadband column to User-Guide SQL examples

2023-01-02 Thread GitBox
MarcosZyk merged PR #8701: URL: https://github.com/apache/iotdb/pull/8701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8701: [To rel/1.0] Add deadband column to User-Guide SQL examples

2023-01-02 Thread GitBox
MarcosZyk opened a new pull request, #8701: URL: https://github.com/apache/iotdb/pull/8701 ## Description Add deadband column to User-Guide SQL examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8700: [IOTDB-5329] Exception handler for AbstractTreeVisitor

2023-01-02 Thread GitBox
MarcosZyk commented on code in PR #8700: URL: https://github.com/apache/iotdb/pull/8700#discussion_r1059951628 ## node-commons/src/main/java/org/apache/iotdb/commons/schema/tree/AbstractTreeVisitor.java: ## @@ -135,12 +146,23 @@ public void reset() { initStack(); } +

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8700: [IOTDB-5329] Exception handler for AbstractTreeVisitor

2023-01-02 Thread GitBox
Cpaulyz opened a new pull request, #8700: URL: https://github.com/apache/iotdb/pull/8700 ## Description Exception handler for AbstractTreeVisitor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [iotdb] MarcosZyk merged pull request #8699: [To rel/0.13] Update SQL result example for deadband column

2023-01-02 Thread GitBox
MarcosZyk merged PR #8699: URL: https://github.com/apache/iotdb/pull/8699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368754640 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8663: [To rel/0.13][IOTDB-5253] Fix chunkMetadata mem metric

2023-01-02 Thread GitBox
OneSizeFitsQuorum merged PR #8663: URL: https://github.com/apache/iotdb/pull/8663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8662: [To rel/1.0][IOTDB-5253] Fix chunkMetadata mem metric

2023-01-02 Thread GitBox
OneSizeFitsQuorum merged PR #8662: URL: https://github.com/apache/iotdb/pull/8662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] OneSizeFitsQuorum merged pull request #8661: [IOTDB-5253] Fix chunkMetadata mem metric

2023-01-02 Thread GitBox
OneSizeFitsQuorum merged PR #8661: URL: https://github.com/apache/iotdb/pull/8661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@io

[GitHub] [iotdb] MarcosZyk merged pull request #8698: Add deadband doc to 0.13.x User-Guide

2023-01-02 Thread GitBox
MarcosZyk merged PR #8698: URL: https://github.com/apache/iotdb/pull/8698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8699: [To rel/0.13] Update SQL result example for deadband column

2023-01-02 Thread GitBox
MarcosZyk opened a new pull request, #8699: URL: https://github.com/apache/iotdb/pull/8699 ## Description Update SQL result example for deadband column -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [iotdb] MarcosZyk opened a new pull request, #8698: Add deadband doc to 0.13.x Userguide

2023-01-02 Thread GitBox
MarcosZyk opened a new pull request, #8698: URL: https://github.com/apache/iotdb/pull/8698 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ] concu

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [IOTDB-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368732357 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] MarcosZyk merged pull request #8695: [IOTDB-5133] Add 0.13 Export-Schema document to website config

2023-01-02 Thread GitBox
MarcosZyk merged PR #8695: URL: https://github.com/apache/iotdb/pull/8695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [lemming-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368720104 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059817762 ## schema-engine-tag/src/main/java/org/apache/iotdb/db/metadata/tagSchemaRegion/tagIndex/flush/MemChunkGroupFlush.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] [iotdb] MarcosZyk commented on a diff in pull request #8619: [IOTDB-5291] Add TiFile to Tag Model, support disk flush and query

2023-01-01 Thread GitBox
MarcosZyk commented on code in PR #8619: URL: https://github.com/apache/iotdb/pull/8619#discussion_r1059865519 ## schema-engine-tag/src/main/java/org/apache/iotdb/lsm/sstable/fileIO/FileOutput.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8671: [lemming-5303] Refine IT: Make cluster properties mutable from outside file and developer coding easily

2023-01-01 Thread GitBox
sonarcloud[bot] commented on PR #8671: URL: https://github.com/apache/iotdb/pull/8671#issuecomment-1368705903 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qualit

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8697: [To rel/0.13][IOTDB-5133] Add log for export schema tool

2023-01-01 Thread GitBox
Cpaulyz opened a new pull request, #8697: URL: https://github.com/apache/iotdb/pull/8697 ## Description Add log for export schema tool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [iotdb] MarcosZyk merged pull request #8696: [To rel/0.13][IOTDB-5133] Move export schame tool docs to Maintenance-Tools

2023-01-01 Thread GitBox
MarcosZyk merged PR #8696: URL: https://github.com/apache/iotdb/pull/8696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apac

[GitHub] [iotdb] Cpaulyz opened a new pull request, #8696: [To rel/0.13][IOTDB-5133] Move export schame tool docs to Maintenance-Tools

2023-01-01 Thread GitBox
Cpaulyz opened a new pull request, #8696: URL: https://github.com/apache/iotdb/pull/8696 ## Description Move export schame tool docs to Maintenance-Tools -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

<    2   3   4   5   6   7   8   9   10   11   >