[kudu-CR] KUDU-3543 Fix Content-Type headers

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 5: Code-Review+1 (12 comments) Overall looks good to me, a few nits a

[kudu-CR] Fix a grammar error

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21635 ) Change subject: Fix a grammar error .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21635/1//COMMIT_MSG

[kudu-CR] [cfile] minor clean-up

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21632 Change subject: [cfile] minor clean-up .. [cfile] minor clean-up I'm going to post more patches updating the code in src/kudu/cfile, so

[kudu-CR] [cfile] make WriterOptions* a constant member field

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21631 Change subject: [cfile] make WriterOptions* a constant member field .. [cfile] make WriterOptions* a constant member field Since I'm pr

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21630 ) Change subject: [tests] check for gflags::SetCommandLineOption() result .. [tests] check for gflags::SetCommandLineOption() res

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

Alexey Serbin has removed a vote on this change. Change subject: [tests] check for gflags::SetCommandLineOption() result .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21630 To unsu

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21630 ) Change subject: [tests] check for gflags::SetCommandLineOption() result .. Patch Set 1: Verified+1 unrelated test failures in BlockMa

[kudu-CR] [tests] check for gflags::SetCommandLineOption() result

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21630 Change subject: [tests] check for gflags::SetCommandLineOption() result .. [tests] check for gflags::SetCommandLineOption() result With

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. KUDU-613: Add SLRU Cache metrics This patch adds segment-specific metrics

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/213

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 14: Verified+1 unrelated test failures -- To view, visit http://gerrit

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has removed a vote on this change. Change subject: KUDU-613: Add SLRU Cache metrics .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21389 To unsubscribe, visit http://g

[kudu-CR] [common] Remove std::lock guard template parameter

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 4: > (1 comment) > > > Patch Set 3: > > > > (1 com

[kudu-CR] [fs] check block size match only for block managers

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21627 ) Change subject: [fs] check block size match only for block managers .. [fs] check block size match only for block managers Sin

[kudu-CR] [fs] check block size match only for block managers

Alexey Serbin has removed a vote on this change. Change subject: [fs] check block size match only for block managers .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21627 To unsubscr

[kudu-CR] [fs] check block size match only for block managers

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21627 ) Change subject: [fs] check block size match only for block managers .. Patch Set 1: Verified+1 unrelated test failures -- To view, v

[kudu-CR] [fs] check block size match only for block managers

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21627 Change subject: [fs] check block size match only for block managers .. [fs] check block size match only for block managers Since the bl

[kudu-CR] [cmake] work around of Gradle-related issues

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21626 ) Change subject: [cmake] work around of Gradle-related issues .. Patch Set 2: Verified+1 unrelated test failures: KUDU-3601 -- To vie

[kudu-CR] [cmake] work around of Gradle-related issues

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21626 ) Change subject: [cmake] work around of Gradle-related issues .. [cmake] work around of Gradle-related issues Once Gradle start

[kudu-CR] [cmake] work around of Gradle-related issues

Alexey Serbin has removed a vote on this change. Change subject: [cmake] work around of Gradle-related issues .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21626 To unsubscribe, vi

[kudu-CR] [tools] fix compilation warning

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21625 ) Change subject: [tools] fix compilation warning .. [tools] fix compilation warning This patch addresses compilation warnings l

[kudu-CR] [tools] fix compilation warning

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21625 ) Change subject: [tools] fix compilation warning .. Patch Set 1: Verified+1 unrelated test failures -- To view, visit http://gerrit.c

[kudu-CR] [cmake] work around of Gradle-related issues

Hello Zoltan Chovan, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21626 to look at the new patch set (#2). Change subject: [cmake] work around of Gradle-related issues ..

[kudu-CR] [cmake] work around of Gradle-related issues

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21626 Change subject: [cmake] work around of Gradle-related issues .. [cmake] work around of Gradle-related issues Once Gradle started being

[kudu-CR] [tools] fix compilation warning

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21625 Change subject: [tools] fix compilation warning .. [tools] fix compilation warning This patch addresses compilation warnings like below

[kudu-CR] [common] Remove std::lock guard template parameter

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21623 ) Change subject: [common] Remove std::lock_guard template parameter .. Patch Set 3: (1 comment) > Build Failed > > http://jenkins.ku

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. KUDU-3591 Fix the flaky test FsMan

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. Patch Set 5: Code-Review+2 (1 comment) T

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 13: Code-Review+1 (3 comments) overall looks good, just a couple of nit

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/21389/11/src/kudu/u

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 11: (6 comments) Almost there. Just one nit and a question w.r.t. maki

[kudu-CR] [client] KUDU-3595: Add a way to set Kudu client's rpc max message size

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21622 ) Change subject: [client] KUDU-3595: Add a way to set Kudu client's rpc_max_message_size .. Patch Set 2: (5 comments) http://gerrit.c

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21609 ) Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. [Tool] Fix unit test ToolTest.TableCopyLimitSpeed This pa

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21609 ) Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. Patch Set 3: Verified+1 unrelated test failure in Java test --

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

Alexey Serbin has removed a vote on this change. Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21609 To unsubscrib

[kudu-CR] [Tool] Retry failed table copying tasks

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21536 ) Change subject: [Tool] Retry failed table copying tasks .. Patch Set 9: (7 comments) http://gerrit.cloudera.org:8080/#/c/21536/9//COM

[kudu-CR] [Tool] Fix unit test ToolTest.TableCopyLimitSpeed

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21609 ) Change subject: [Tool] Fix unit test ToolTest.TableCopyLimitSpeed .. Patch Set 3: Code-Review+2 Thanks a lot for addressing the feedba

[kudu-CR] KUDU-613: Add SLRU Cache metrics

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21389 ) Change subject: KUDU-613: Add SLRU Cache metrics .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/21389/11//COMMIT_M

[kudu-CR] KUDU-613: SLRU Cache Benchmark

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 ) Change subject: KUDU-613: SLRU Cache Benchmark .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21601/1

[kudu-CR] [log] fix the Ranger client log count limit not working

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] [log] fix the Ranger client log count limit not working

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. [log] fix the Ranger client log count limit not work

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. [tests] more robust TabletServerDiskErrorITest::SetU

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21612 ) Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario .. [tests] re-enable ReplaceTabletsWhileWriting scenario

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. Patch Set 1: > There is a new IWYU error need to be fixed.

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21614 ) Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. Patch Set 1: > Only thing is that IWYU has to be satisfied.

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

Hello Marton Greber, Yingchun Lai, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21614 to look at the new patch set (#2). Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp()

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21612 ) Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario .. Patch Set 2: Verified+1 TSAN: unrelated tests failures. File

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Alexey Serbin has removed a vote on this change. Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21612 To unsubs

[kudu-CR] [tests] more robust TabletServerDiskErrorITest::SetUp()

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21614 Change subject: [tests] more robust TabletServerDiskErrorITest::SetUp() .. [tests] more robust TabletServerDiskErrorITest::SetUp() This

[kudu-CR] [tests] re-enable ReplaceTabletsWhileWriting scenario

Hello Ashwani Raina, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21612 to look at the new patch set (#2). Change subject: [tests] re-enable ReplaceTabletsWhileWriting scenario ...

[kudu-CR] KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21612 Change subject: KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario .. KUDU-2376 re-enable ReplaceTabletsWhileWriting scenario Sinc

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. Patch Set 2: Code-Review+2 thank you for fixing the issue! -- To view, visi

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. KUDU-3594 Fix scan_token-test on ASAN scan_token-test was failing on

[kudu-CR] KUDU-3594 Fix scan token-test on ASAN

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21610 ) Change subject: KUDU-3594 Fix scan_token-test on ASAN .. Patch Set 1: (1 comment) thank you for the fix! http://gerrit.cloudera.org:

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21580 ) Change subject: [client] add ScanTokenStaleRaftMembershipTest .. [client] add ScanTokenStaleRaftMembershipTest This patch adds

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21580 ) Change subject: [client] add ScanTokenStaleRaftMembershipTest .. Patch Set 3: Verified+1 All the failed tests seem to be solely relate

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Alexey Serbin has removed a vote on this change. Change subject: [client] add ScanTokenStaleRaftMembershipTest .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21580 To unsubscribe, v

[kudu-CR] KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21604 ) Change subject: KUDU-3591 Fix the flaky test FsManagerTestBase.TestAddRemoveDataDirsFuzz .. Patch Set 3: (2 comments) http://gerrit.

[kudu-CR] [util] a small clean up on the Throttler class

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21603 ) Change subject: [util] a small clean up on the Throttler class .. [util] a small clean up on the Throttler class The motivatio

[kudu-CR] [util] a small clean up on the Throttler class

Alexey Serbin has removed a vote on this change. Change subject: [util] a small clean up on the Throttler class .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21603 To unsubscribe,

[kudu-CR] [util] a small clean up on the Throttler class

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21603 ) Change subject: [util] a small clean up on the Throttler class .. Patch Set 1: Verified+1 All test failures seem to be solely related

[kudu-CR] [util] a small clean up on the Throttler class

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21603 Change subject: [util] a small clean up on the Throttler class .. [util] a small clean up on the Throttler class The motivation behind

[kudu-CR] [Tool] Limit table copying speed

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/21527/6/src/kudu/too

[kudu-CR] [Tool] Limit table copying speed

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21527 ) Change subject: [Tool] Limit table copying speed .. Patch Set 6: (9 comments) I'm not sure this works as expected in PS6. http://ger

[kudu-CR] Update CMake to 3.25.3

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.25.3 .. Patch Set 3: It seems update cmake's ctest changed its output format, so dist_test.py script

[kudu-CR] KUDU-613: SLRU Cache Benchmark

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21601 ) Change subject: KUDU-613: SLRU Cache Benchmark .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/21601/1//COMMIT_MSG C

[kudu-CR] [WIP] KUDU-1261 Java client complex type introduction

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20749 ) Change subject: [WIP] KUDU-1261 Java client complex type introduction .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. KUDU-3371 Add NO_ROCKSDB build option This patch adds a build option

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

Alexey Serbin has removed a vote on this change. Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/21560 To unsubscribe, visit htt

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Patch Set 5: Code-Review+2 Thank you very much for implementing this! -- To

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Patch Set 5: Verified+1 (1 comment) The test failures are due to expired cer

[kudu-CR] [log] fix the Ranger client log count limit not working

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21572 ) Change subject: [log] fix the Ranger client log count limit not working .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21580 ) Change subject: [client] add ScanTokenStaleRaftMembershipTest .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21580/3

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Hello Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21580 to look at the new patch set (#3). Change subject: [client] add ScanTokenStaleRaftMembershipTest .

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21580 ) Change subject: [client] add ScanTokenStaleRaftMembershipTest .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21580/

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Hello Ashwani Raina, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21580 to look at the new patch set (#2). Change subject: [client] add ScanTokenStaleRaftMembershipTest .

[kudu-CR] [client] add ScanTokenStaleRaftMembershipTest

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21580 Change subject: [client] add ScanTokenStaleRaftMembershipTest .. [client] add ScanTokenStaleRaftMembershipTest This patch adds a new te

[kudu-CR] [log block manager] Write lock for deletion

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20901 ) Change subject: [log_block_manager] Write lock for deletion .. Patch Set 16: (1 comment) > Build Failed > > http://jenkins.kudu.apa

[kudu-CR] KUDU-3371 Parameterize some options of RocksDB

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21570 ) Change subject: KUDU-3371 Parameterize some options of RocksDB .. Patch Set 1: (26 comments) http://gerrit.cloudera.org:8080/#/c/2157

[kudu-CR] [KUDU-3583] Revert the default value of the flag --tablet history max age sec

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21481 ) Change subject: [KUDU-3583] Revert the default value of the flag --tablet_history_max_age_sec .. Patch Set 2: (1 comment) http://ger

[kudu-CR] Update CMake to 3.22.6

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21569 ) Change subject: Update CMake to 3.22.6 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21569/2//COMMIT_MSG Commit Me

[kudu-CR] KUDU-3371 Add NO ROCKSDB build option

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21560 ) Change subject: KUDU-3371 Add NO_ROCKSDB build option .. Patch Set 2: Thank you for putting together this patch! Overall look good to

[kudu-CR] [cfile] allocate CFileWriter field on the stack when possible

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21543 ) Change subject: [cfile] allocate CFileWriter field on the stack when possible .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] [cfile] allocate CFileWriter field on the stack when possible

Hello Yingchun Lai, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21543 to look at the new patch set (#2). Change subject: [cfile] allocate CFileWriter field on the stack when possible ..

[kudu-CR] [cfile] allocate CFileWriter field on the stack when possible

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21543 Change subject: [cfile] allocate CFileWriter field on the stack when possible .. [cfile] allocate CFileWriter field on the stack when po

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. KUDU-3371 check for RocksDB dir presence upo

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 9: Code-Review+2 -- To view, visit http:

[kudu-CR](branch-1.17.x) KUDU-3566 fix summary metrics in Prometheus format

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21526 ) Change subject: KUDU-3566 fix summary metrics in Prometheus format .. KUDU-3566 fix summary metrics in Prometheus format This

[kudu-CR](branch-1.17.x) [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21524 ) Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. [client-test] make ClearCacheAndConc

[kudu-CR] KUDU-3371 check for RocksDB dir presence upon opening FSManager

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21295 ) Change subject: KUDU-3371 check for RocksDB dir presence upon opening FSManager .. Patch Set 8: Code-Review+1 (1 comment) Overall LGT

[kudu-CR] [tool] Add '--columns' param to 'table list'

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21496 ) Change subject: [tool] Add '--columns' param to 'table list' .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/21496/8

[kudu-CR] KUDU-3580 Fix the crash caused when binaries run on older CPU machines

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU machines .. KUDU-3580 Fix the crash caused when

[kudu-CR] KUDU-3580 Fix the crash caused when binaries run on older CPU machines

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU machines .. Patch Set 8: Code-Review+2 -- To view, vis

[kudu-CR] KUDU-3580 Fix the crash caused when binaries run on older CPU machines

Alexey Serbin has removed a vote on this change. Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU machines .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] KUDU-3580 Fix the crash caused when binaries run on older CPU machines

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 Fix the crash caused when binaries run on older CPU machines .. Patch Set 8: Verified+1 unrelated test fail

[kudu-CR](branch-1.17.x) KUDU-3566 fix summary metrics in Prometheus format

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21526 ) Change subject: KUDU-3566 fix summary metrics in Prometheus format .. Patch Set 1: Verified+1 unrelated test failures due to unclean w

[kudu-CR](branch-1.17.x) [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21524 ) Change subject: [client-test] make ClearCacheAndConcurrentWorkload more stable in TSAN .. Patch Set 1: Verified+1 unrelated test fail

[kudu-CR] [tool] Add '--columns' param to 'table list'

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21496 ) Change subject: [tool] Add '--columns' param to 'table list' .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/21496/3

[kudu-CR](branch-1.17.x) KUDU-3566 fix summary metrics in Prometheus format

Hello Abhishek Chennaka, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/21526 to review the following change. Change subject: KUDU-3566 fix summary metrics in Prometheus format .. KUDU-3566

[kudu-CR] KUDU-3580 the crash bug when run binaries on older CPU machines

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21287 ) Change subject: KUDU-3580 the crash bug when run binaries on older CPU machines .. Patch Set 7: > (1 comment) Overall looks good to m

<    1   2   3   4   5   6   7   8   9   10   >