[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#11). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5223 Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches .. Reduce the number of batches in FuzzTest::TestFuzz

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#17). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 16: (7 comments) http://gerrit.cloudera.org:8080/#/c/4995/16/src/kudu/tablet/comp

[kudu-CR] [c++ client] timestamp propagation via scan tokens

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens .. Patch Set 1: I meant making sure that we're not breaking anything with this change stand-alone. We u

[kudu-CR] [c++ client] timestamp propagation via scan tokens

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] timestamp propagation via scan tokens .. Patch Set 1: did you test that these tokens are cross-client compatible? -- To view, visit http://g

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5188/6/java/kudu-client/src/main/java/

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 6: -Code-Review (1 comment) oops, found a problem http://gerrit.cloudera.org:8080/#/c/51

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5188 To unsubscribe, v

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#16). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#15). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/4995/14/src/kudu/tablet/comp

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/4995/14/src/kudu/tablet/comp

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#14). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] Make DebugDumpCompactionInput use CompactionInputRowToString

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5215 Change subject: Make DebugDumpCompactionInput use CompactionInputRowToString .. Make DebugDumpCompactionInput use CompactionInputRo

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 13: (29 comments) http://gerrit.cloudera.org:8080/#/c/4995/12/src/kudu/common/row

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#13). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] [c++] Reuse snapshot scan timestamp across tablets

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [c++] Reuse snapshot scan timestamp across tablets .. [c++] Reuse snapshot scan timestamp across tablets KUDU-1189 On reads at a snapshot that tou

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1189 integration test for reusing snap timestamp .. KUDU-1189 integration test for reusing snap timestamp Added a test for reusing snapshot t

[kudu-CR] [java] Reuse snapshot scan timestamp across tablets

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] Reuse snapshot scan timestamp across tablets .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5188/5/java/kudu-client/src/main/java

[kudu-CR] [c++] Reuse snapshot scan timestamp across tablets

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++] Reuse snapshot scan timestamp across tablets .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5143 To unsubscribe, vi

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 integration test for reusing snap timestamp .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5163 To unsubscribe,

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 2: (4 comments) can you please address the tidy bot nits? I know most a

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 integration test for reusing snap timestamp .. Patch Set 4: Does this need to be rebased on top of the patch that unbroke the build? -- To view

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5143/5//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5143/5//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1189 integration test for reusing snap timestamp

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 integration test for reusing snap timestamp .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5163/3/src/kudu/integration-tests/co

[kudu-CR] [scan] test for reusing snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [scan] test for reusing snapshot timestamp when not set .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5163/2/src/kudu/integration-tests

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 1: I'm not sure what kind of test you're planning but in the past, for these types of

[kudu-CR] [scan] test for reusing snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [scan] test for reusing snapshot timestamp when not set .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5163/2//COMMIT_MSG Commit Message

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set .. Patch Set 5: (2 comments) any way we can add simple unit test for this? http://gerrit.cloudera.

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Check that the set raw snapshot timestamp is > 0 .. Check that the set raw snapshot timestamp is > 0 Commit 06bb52d changed the default (invalid)

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: not sure, nothing changed in the java client, but having the c++ not allow scans at 0 and

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message: Line

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message: Line

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Don't do UNDO garbage collection until after the REDO->UNDO transfor

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Make RowChangeListDecoder::RemoveColumnI

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 8: Verified+1 unrelated flake OpenReadonlyFsITest.TestWriteAndVeri

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 13: Verified+1 unrelated flake RpcBenc

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4928 to look at the new patch set (#12). Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out pa

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 10: (2 comments) http://gerrit.cloude

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 11: -Code-Review oops missed todd's co

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 11: Code-Review+2 again, keeping the +

[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5055/6//COMMIT_MSG Commit Message:

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: fuzz-itest used to create snapshots at timestamp 0, which previously were silently transf

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#9). Change subject: Don't output unobservable rows from the MemRowset .. Don't outpu

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/6//COMMIT_MSG Commit Message: PS6,

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#8). Change subject: Don't output unobservable rows from the MemRowset .. Don't outpu

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4993 to look at the new patch set (#7). Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 6: (9 comments) http://gerrit.cloudera.org:8080/#/c/4993/6/src/ku

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/4791/16/src/kudu/com

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#17). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5155 Change subject: Check that the set raw snapshot timestamp is > 0 .. Check that the set raw snapshot timestamp is > 0 Commit 06bb52

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#10). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4997 to look at the new patch set (#10). Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to ta

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/4996/8//COMMIT_MSG Commit Message: Line 23: WIPish: Thi

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 6: Verified+1 unrelated flake DebugUtilTest.TestSignalStackTrace -- To view, visit http://

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5056/3/src/kudu/ta

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#9). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-itest This adds a new operation to fuzz-itest: snapshot scans at timestamp. When generating r

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4994 to look at the new patch set (#6). Change subject: Don't output unobservable rows from the MemRowset .. Don't outpu

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 10: Code-Review+2 just a rebase keepin

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#16). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4928 to look at the new patch set (#10). Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out pa

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-19 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4993 to look at the new patch set (#6). Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4993/2/src/kud

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/4791/15/src/kudu/com

[kudu-CR] KUDU-1189 if not set, use timestamp from first server

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1189 if not set, use timestamp from first server .. Patch Set 3: (33 comments) http://gerrit.cloudera.org:8080/#/c/5143/3//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-1679 Propagate timestamps for scans .. KUDU-1679 Propagate timestamps for scans Added the 'propagated_timestamp' field into the ScanResponseP

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5099 To unsubscribe, visit http:/

[kudu-CR] [integration tests] added scan consistency test

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [integration tests] added scan consistency test .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5084 To unsubscribe, visit

[kudu-CR] [integration tests] added scan consistency test

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [integration tests] added scan consistency test .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5084/4/src/kudu/integration-tests/consiste

[kudu-CR] WIP: KUDU-1189 if not set, use timestamp from first server

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1189 if not set, use timestamp from first server .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5143/1/src/kudu/client/scanner

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Patch Set 5: Code-Review+2 lgtm, since the tidy bot is nt your fault I'm merging this. -- To view,

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. [Timestamp] use 'operator<' instead of ComesBefore Added more syntactic sugar, now for the k

[kudu-CR] [Timestamp] use 'operator<' instead of ComesBefore

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [Timestamp] use 'operator<' instead of ComesBefore .. Patch Set 3: (4 comments) lgtm, but please remove the CompactionInputRow stuff http://gerrit.cloude

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 5: Could you put this patch after the consistency itest patch in the git history and enable that tes

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/5099/5//COMMIT_MSG Commit Message: PS5, Line 10

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5099/4/src/kudu/client/scan_configuration.h File

[kudu-CR] [integration tests] added scan consistency test

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [integration tests] added scan consistency test .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/5084/2/src/kudu/client/client-test-util.c

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Fix list rendering of the last weekly update post .. Fix list rendering of the last weekly update post The sublist after "Noteworthy features/impr

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix list rendering of the last weekly update post .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5131 To unsubscribe, visit

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Fix list rendering of the last weekly update post .. Fix list rendering of the last weekly update post The sublist after "Noteworthy features/improvements" i

[kudu-CR](gh-pages) Fix list rendering of the last weekly update post

2016-11-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5131 Change subject: Fix list rendering of the last weekly update post .. Fix list rendering of the last weekly update post The sublist

[kudu-CR] [consensus] KUDU-1718: Fix few bugs around replica eviction failures

2016-11-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction failures .. Patch Set 1: (1 comment) would it be possible to split this patch into several on

[kudu-CR] KUDU-1679 Propagate timestamps for scans

2016-11-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1679 Propagate timestamps for scans .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/5099/4/python/kudu/tests/test_scanner.py File py

[kudu-CR] [hybrid clock] update on NowWithError's signature

2016-11-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [hybrid_clock] update on NowWithError's signature .. Patch Set 1: what is the goal here? we usually frown on optional args in outside of tests without a g

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5098 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I487b092739b3f921e3ab0b186f82c7f368d84f4f Reviewed-on: http://gerrit.cloudera.org:80

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
Hello Dinesh Bhat, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5098 to look at the new patch set (#4). Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I4

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add 11/15 weekly update .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5098/3/_posts/2016-11-15-weekly-update.md File _posts/2016-11-15-

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I487b092739b3f921e3ab0b186f82c7f368d84f4f --- A _posts/2016-11-15-weekly-update.md 1 file chang

[kudu-CR] [c++client] propagating timestamp for scans

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [c++client] propagating timestamp for scans .. Patch Set 1: I mention this yesterday, but it was pretty late and maybe you didn't get a chance to read it.

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I487b092739b3f921e3ab0b186f82c7f368d84f4f --- A _posts/2016-11-15-weekly-update.md 1 file chang

[kudu-CR](gh-pages) Add 11/15 weekly update

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5098 Change subject: Add 11/15 weekly update .. Add 11/15 weekly update Change-Id: I487b092739b3f921e3ab0b186f82c7f368d84f4f --- A _pos

[kudu-CR] WIP: [integration tests] scan inconsistency test

2016-11-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: [integration tests] scan inconsistency test .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5084/1/src/kudu/integration-tests/consis

[kudu-CR] KUDU-798 (part 3) - Remove automatic safe time adjustment from mvcc

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#5). Change subject: KUDU-798 (part 3) - Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 3) - Remove automatic safe time adjustment from mvcc

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#4). Change subject: KUDU-798 (part 3) - Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 3) - Remove automatic safe time adjustment from mvcc

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#3). Change subject: KUDU-798 (part 3) - Remove automatic safe time adjustment from mvcc

[kudu-CR] KUDU-798 (part 3) Remove automatic safe time adjustment from mvcc

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5057 to look at the new patch set (#2). Change subject: KUDU-798 (part 3) Remove automatic safe time adjustment from mvcc ..

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-13 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5056 to look at the new patch set (#3). Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .

<    9   10   11   12   13   14   15   16   17   18   >