[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduPartialRow::Set{Binary,String}()] copy input data KuduPartialRow::SetBinary()/SetString() be

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3868 To unsubscribe, visit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 10: (1 comment) Thank you for the review, Mike! http://gerrit.cloudera.org:8080/#/c/3868/10

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2805/ -- To view, visit http://gerri

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#11). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 10: Code-Review+1 (1 comment) Looks good, just found one more doc nit http://gerrit.cloudera.o

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#10). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [Kudu

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2804/ -- To view, visit http://gerri

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/3868/9/src/kudu/common/partial_row-test.

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/3868/9/src/kudu/common/partial_row-test.cc F

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/3868/9/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#9). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2796/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2788/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#8). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#7). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-10 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2787/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3868/5/src/kudu/common/partial_row-test.

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#6). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2778/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3868/5/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3868/5/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#5). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2771/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#4). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2770/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3868/3/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: (3 comments) Will post the updated version soon. http://gerrit.cloudera.org:8080/#/c/386

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/3868/3/src/kudu/common/partial_row-test.cc

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2768/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#3). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 2: (3 comments) > (3 comments) > > Can we add basic test coverage for SetString() and Set

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 2: (3 comments) Can we add basic test coverage for SetString() and SetBinary()? http://gerrit.

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2763/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3868 to look at the new patch set (#2). Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduP

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3868/1//COMMIT_MSG Commit Message: Line

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3868/1//COMMIT_MSG Commit Message: Line 17

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2756/ -- To view, visit http://gerrit

[kudu-CR] [KuduPartialRow::Set{Binary,String}()] copy input data

2016-08-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3868 Change subject: [KuduPartialRow::Set{Binary,String}()] copy input data .. [KuduPartialRow::Set{Binary,String}()] copy input data KuduPar