[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. KUDU-1192 Periodically flush glog buffers from a thread Added a wait timeout to AsyncLogger

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6853 To unsubscribe,

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-17 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 11: (14 comments) all are related to the missing header file. fixed.

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6853 To unsubscribe,

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-17 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#11). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-17 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#10). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#9). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 6: (2 comments) sorry my bad. included the test_util.h

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#8). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6853/7/src/kudu/util/logging-test.cc File

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#7). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6853/6/src/kudu/util/logging-test.cc File

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6853/6/src/kudu/util/logging-test.cc File

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 6: (3 comments) done the fixes. Also added the SetCommandLineOptionWithMode per suggestion,

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-16 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#6). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 5: (3 comments) Can you also add something like:

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-11 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#5). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-11 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6853/3/src/kudu/util/async_logger.cc File

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-11 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#4). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6853/3/src/kudu/util/async_logger.cc File

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-10 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#3). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-10 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 2: (2 comments) removed the changes from other files as well.

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-10 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6853 to look at the new patch set (#2). Change subject: KUDU-1192 Periodically flush glog buffers from a thread ..

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6853/1/src/kudu/util/async_logger.cc

[kudu-CR] KUDU-1192 Periodically flush glog buffers from a thread

2017-05-10 Thread William Li (Code Review)
William Li has uploaded a new change for review. http://gerrit.cloudera.org:8080/6853 Change subject: KUDU-1192 Periodically flush glog buffers from a thread .. KUDU-1192 Periodically flush glog buffers from a thread Added a