Re: Review Request 36501: MESOS-3023

On July 24, 2015, 2:01 p.m., Klaus Ma wrote: > > If you don't get to them first, I will fix the remaining little style > > suggestions when committing. OK, please help to fix it. I'll learn it from the final code :). Thanks very much. - Klaus ---

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92911 --- Ship it! src/tests/fetcher_tests.cpp (line 295)

Re: Review Request 36501: MESOS-3023

> On July 20, 2015, 9:42 a.m., haosdent huang wrote: > > > > haosdent huang wrote: > Its a bit difficult to follow the mesos style guide at first. Maybe the > committer could help you reformat it when summit @klausma1982 . :-) > > Klaus Ma wrote: > Thanks very much for your patience; y

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92889 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 24, 2015, 9:57 a.m.) Review request for mesos. Bugs: MESOS-3023

Re: Review Request 36501: MESOS-3023

> On July 20, 2015, 4:42 p.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 297 > > > > > > According > > https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definit

Re: Review Request 36501: MESOS-3023

> On July 20, 2015, 4:42 p.m., haosdent huang wrote: > > > > haosdent huang wrote: > Its a bit difficult to follow the mesos style guide at first. Maybe the > committer could help you reformat it when summit @klausma1982 . :-) Thanks very much for your patience; yes, it tooks time for me t

Re: Review Request 36501: MESOS-3023

> On July 20, 2015, 9:42 a.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 297 > > > > > > According > > https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definit

Re: Review Request 36501: MESOS-3023

> On July 20, 2015, 4:42 p.m., haosdent huang wrote: > > Its a bit difficult to follow the mesos style guide at first. Maybe the committer could help you reformat it when summit @klausma1982 . :-) - haosdent --- This is an automaticall

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92270 --- src/tests/fetcher_tests.cpp (line 297)

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92170 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 18, 2015, 9:47 a.m.) Review request for mesos. Bugs: MESOS-3023

Re: Review Request 36501: MESOS-3023

> On 七月 17, 2015, 5:39 p.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 66 > > > > > > Because use stringify, could remove it now. yes. agree. i'll update the code. - Klaus --

Re: Review Request 36501: MESOS-3023

> On July 17, 2015, 2:20 p.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 22 > > > > > > Need sort it lexicographically. > > > > ``` > > #include > > #include > > haosdent huang wr

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92108 --- src/tests/fetcher_tests.cpp (line 22)

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92104 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 17, 2015, 4:13 p.m.) Review request for mesos. Bugs: MESOS-3023

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92093 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

> On July 17, 2015, 2:20 p.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 22 > > > > > > Need sort it lexicographically. > > > > ``` > > #include > > #include ``` #include #includ

Re: Review Request 36501: MESOS-3023

> On July 17, 2015, 2:20 p.m., haosdent huang wrote: > > Ship It! 3rdparty/libprocess/src/tests/http_tests.cpp have a unit test case "TEST(URLTest, Stringification)" show how to use URL and stringify it. Maybe you could use URL according that. - haosdent ---

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92082 --- Ship it! Ship It! src/tests/fetcher_tests.cpp (line 22)

Re: Review Request 36501: MESOS-3023

> On July 17, 2015, 7:13 a.m., haosdent huang wrote: > > src/tests/utils.hpp, line 72 > > > > > > How about check path length and use `path[0]` here? Instead of > > `*(path.begin())` I think we can use startsWith to

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 17, 2015, 2:06 p.m.) Review request for mesos. Bugs: MESOS-3023

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92033 --- src/tests/utils.hpp (line 30)

Re: Review Request 36501: MESOS-3023

> On July 15, 2015, 4:16 a.m., haosdent huang wrote: > > src/tests/utils.hpp, line 54 > > > > > > I suggest move the implement to cpp file. As far as I known, C++ can not declare template in header file and implete i

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91871 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

> On July 15, 2015, 4:16 a.m., haosdent huang wrote: > > src/tests/utils.hpp, line 55 > > > > > > The code styple need change to follow > > https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.m

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 16, 2015, 5:47 a.m.) Review request for mesos. Bugs: MESOS-3023

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91863 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

> On July 15, 2015, 9:19 p.m., Joseph Wu wrote: > > src/tests/utils.hpp, line 55 > > > > > > * Tab size = 2 spaces. > > * Parameters are indented by 4 spaces. > > * Comments start with a capital letter and end

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 16, 2015, 4:41 a.m.) Review request for mesos. Bugs: MESOS-3023

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91823 --- src/tests/utils.hpp (line 55)

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91732 --- src/tests/utils.hpp (line 26)

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91707 --- Patch looks great! Reviews applied: [36501] All tests passed. - M

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review91706 --- src/tests/utils.hpp (line 26)

Re: Review Request 36501: MESOS-3023

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 15, 2015, 2:59 a.m.) Review request for mesos. Bugs: MESOS-3023