[GitHub] spark pull request: [SPARK-4237][BUILD] Fix MANIFEST.MF in maven a...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3103#issuecomment-62295132 [Test build #23116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23116/consoleFull) for PR 3103 at commit [`8332304`](https://githu

[GitHub] spark pull request: [SPARK-4237][BUILD] Fix MANIFEST.MF in maven a...

2014-11-08 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3103#issuecomment-62295066 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-4250] [SQL] Fix bug of constant null va...

2014-11-08 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/3114#issuecomment-62294967 @marmbrus The problem @chenghao-intel pointed out can be illustrated by this Scala shell snippet: ``` scala> def foo(v: Any) = v match { | case _

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62293983 [Test build #23115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23115/consoleFull) for PR 3159 at commit [`5dcd602`](https://githu

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62293906 [Test build #23114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23114/consoleFull) for PR 3159 at commit [`5dcd602`](https://githu

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62293843 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62293224 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62293221 [Test build #23113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23113/consoleFull) for PR 3173 at commit [`cc4647d`](https://gith

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62293022 [Test build #23113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23113/consoleFull) for PR 3173 at commit [`cc4647d`](https://githu

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread Ishiihara
Github user Ishiihara commented on a diff in the pull request: https://github.com/apache/spark/pull/3173#discussion_r20056877 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -84,6 +84,10 @@ private[sql] abstract class SparkStrategies ex

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3173#discussion_r20056856 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -84,6 +84,10 @@ private[sql] abstract class SparkStrategies ext

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62292538 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62292537 [Test build #23112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23112/consoleFull) for PR 3173 at commit [`5cb98c3`](https://gith

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3173#issuecomment-62292327 [Test build #23112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23112/consoleFull) for PR 3173 at commit [`5cb98c3`](https://githu

[GitHub] spark pull request: [SPARK-2213][SQL] Sort Merge Join

2014-11-08 Thread Ishiihara
GitHub user Ishiihara opened a pull request: https://github.com/apache/spark/pull/3173 [SPARK-2213][SQL] Sort Merge Join This PR adds MergeJoin operator to Spark SQL. The semantics of MergeJoin operator is similar to Hive's Sort merge bucket join. MergeJoin operator reli

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3172#issuecomment-62291934 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3172#issuecomment-62291933 [Test build #23111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23111/consoleFull) for PR 3172 at commit [`04cddc8`](https://gith

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62291931 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SQL] Minor fix for TreeNode

2014-11-08 Thread scwf
Github user scwf closed the pull request at: https://github.com/apache/spark/pull/3171 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62291927 [Test build #23109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23109/consoleFull) for PR 3159 at commit [`0b9f0f4`](https://gith

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3172#discussion_r20056740 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockManager.java --- @@ -56,16 +58,24 @@ // Single-threaded

[GitHub] spark pull request: [SQL] Minor fix for TreeNode

2014-11-08 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3171#issuecomment-62291925 Hmm, remove ```case null``` leads to code generation failed, so close this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/3172#issuecomment-62291922 LGTM, just a few minor style nits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3172#discussion_r20056737 --- Diff: network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockManager.java --- @@ -56,16 +58,24 @@ // Single-threaded

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3172#issuecomment-62291803 [Test build #23111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23111/consoleFull) for PR 3172 at commit [`04cddc8`](https://githu

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3172#discussion_r20056709 --- Diff: network/common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java --- @@ -31,27 +31,27 @@ import org.apache.sp

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread aarondav
Github user aarondav commented on a diff in the pull request: https://github.com/apache/spark/pull/3172#discussion_r20056703 --- Diff: core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockManager.scala --- @@ -22,6 +22,9 @@ import java.nio.ByteBuffer import java.util.c

[GitHub] spark pull request: [SPARK-4307] Initialize FileDescriptor lazily ...

2014-11-08 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/3172 [SPARK-4307] Initialize FileDescriptor lazily in FileRegion. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rxin/spark lazyFD Alternatively you c

[GitHub] spark pull request: [SQL] Minor fix for TreeNode

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3171#issuecomment-62291100 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SQL] Minor fix for TreeNode

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3171#issuecomment-62291098 [Test build #23110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23110/consoleFull) for PR 3171 at commit [`c2b09e3`](https://gith

[GitHub] spark pull request: [SQL] Minor fix for TreeNode

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3171#issuecomment-62290939 [Test build #23110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23110/consoleFull) for PR 3171 at commit [`c2b09e3`](https://githu

[GitHub] spark pull request: [SQL] Minor fix for TreeNode

2014-11-08 Thread scwf
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/3171 [SQL] Minor fix for TreeNode 1 remove `case` never reached 2 add transformUp for test("transform works on nodes with Option children") You can merge this pull request into a Git repository by runn

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62289795 [Test build #23109 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23109/consoleFull) for PR 3159 at commit [`0b9f0f4`](https://githu

[GitHub] spark pull request: Scala 2.11 Support in Spark

2014-11-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2986#issuecomment-62289760 @JoshRosen yes I will add docs - this was just running some tests through jenkins. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: Scala 2.11 Support in Spark

2014-11-08 Thread pwendell
Github user pwendell closed the pull request at: https://github.com/apache/spark/pull/2986 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62289725 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: Support cross building for Scala 2.11

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3159#issuecomment-62289504 [Test build #23108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23108/consoleFull) for PR 3159 at commit [`125ba46`](https://githu

[GitHub] spark pull request: SPARK-3648: Provide a script for fetching remo...

2014-11-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3165#issuecomment-62288954 I'm actually happy to just drop this though if we can update the documentation in our wiki to suggest people use hub. @JoshRosen or @rxin would one of you guys be able t

[GitHub] spark pull request: SPARK-3648: Provide a script for fetching remo...

2014-11-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3165#issuecomment-62288892 I didn't use hub - but I preferred this since I can just create a temporary ref that gets thrown away and I never have to worry about cleaning it up. --- If your projec

[GitHub] spark pull request: SPARK-2811 upgrade algebird to 0.8.1

2014-11-08 Thread adampingel
Github user adampingel commented on the pull request: https://github.com/apache/spark/pull/2947#issuecomment-62288693 Algebird 0.8.1 for Scala 2.11 is on the central repo: http://search.maven.org/#artifactdetails%7Ccom.twitter%7Calgebird_2.11%7C0.8.1%7Cjar --- If your project is set

[GitHub] spark pull request: [SPARK-4301] StreamingContext should not allow...

2014-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-4301] StreamingContext should not allow...

2014-11-08 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3160#issuecomment-62287744 merging this. thanks josh for this PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: SPARK-3179. Add task OutputMetrics.

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2968#issuecomment-62285457 [Test build #23107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23107/consoleFull) for PR 2968 at commit [`dce4784`](https://gith

[GitHub] spark pull request: SPARK-3179. Add task OutputMetrics.

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2968#issuecomment-62285463 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-3179. Add task OutputMetrics.

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2968#issuecomment-62282883 [Test build #23107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23107/consoleFull) for PR 2968 at commit [`dce4784`](https://githu

[GitHub] spark pull request: SPARK-3179. Add task OutputMetrics.

2014-11-08 Thread sryza
Github user sryza commented on a diff in the pull request: https://github.com/apache/spark/pull/2968#discussion_r20055135 --- Diff: core/src/test/scala/org/apache/spark/metrics/InputOutputMetricsSuite.scala --- @@ -73,4 +78,32 @@ class InputMetricsSuite extends FunSuite with Share

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62281021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62281019 [Test build #23106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23106/consoleFull) for PR 3158 at commit [`97d00a8`](https://gith

[GitHub] spark pull request: SPARK-3648: Provide a script for fetching remo...

2014-11-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3165#issuecomment-62279935 Just realized Josh also pointed this out earlier. I've been using hub and it's pretty good. It does require a local branch, but that's pretty easy to do. --- If your projec

[GitHub] spark pull request: SPARK-3648: Provide a script for fetching remo...

2014-11-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3165#issuecomment-62279046 Why not using hub? It is super easy and we don't need to duplicate the work. https://github.com/github/hub --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62278867 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62278862 [Test build #23105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23105/consoleFull) for PR 3158 at commit [`e1ba56e`](https://gith

[GitHub] spark pull request: [Minor] [Core] Don't NPE on closeQuietly(null)

2014-11-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [Minor] [Core] Don't NPE on closeQuietly(null)

2014-11-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/3166#issuecomment-62278736 Merged in master & branch-1.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62278701 [Test build #23106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23106/consoleFull) for PR 3158 at commit [`97d00a8`](https://githu

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62278623 [Test build #23105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23105/consoleFull) for PR 3158 at commit [`e1ba56e`](https://githu

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62276463 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62276461 [Test build #23104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23104/consoleFull) for PR 3158 at commit [`b61540e`](https://gith

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date with comp...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3158#issuecomment-62275092 [Test build #23104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23104/consoleFull) for PR 3158 at commit [`b61540e`](https://githu

[GitHub] spark pull request: [SPARK-4261][BUILD][SQL] Make right version in...

2014-11-08 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/3124#issuecomment-62269619 cc @pwendell @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...

2014-11-08 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3139#discussion_r20053092 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -341,12 +341,21 @@ abstract class HiveComparisonTest

[GitHub] spark pull request: [SPARK-4001][MLlib] adding apriori algorithm f...

2014-11-08 Thread varadharajan
Github user varadharajan commented on the pull request: https://github.com/apache/spark/pull/2847#issuecomment-62263230 As mentioned in comments of SPARK-2432. I was wondering how the PFP versions compared with YAFIM (http://pasa-bigdata.nju.edu.cn/people/ronggu/pub/YAFIM_ParLearning.

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62262792 [Test build #23103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23103/consoleFull) for PR 3131 at commit [`8a56fd6`](https://gith

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62262797 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2894#issuecomment-62262246 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2894#issuecomment-62262242 [Test build #23102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23102/consoleFull) for PR 2894 at commit [`5f9406b`](https://gith

[GitHub] spark pull request: [SPARK-4250] [SQL] Fix bug of constant null va...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3114#issuecomment-62261556 [Test build #23101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23101/consoleFull) for PR 3114 at commit [`e603bda`](https://gith

[GitHub] spark pull request: [SPARK-4250] [SQL] Fix bug of constant null va...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3114#issuecomment-62261557 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [WIP] [SPARK-4273] [SQL] Providing ExternalSet...

2014-11-08 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3137#issuecomment-62260611 Probably a better way is providing the Sort-Merge-Aggregation not just for `DistinctCount`. I am working on a POC, hope we can discuss that soon. --- If your proj

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051975 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hi

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3131#issuecomment-62260293 [Test build #23103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23103/consoleFull) for PR 3131 at commit [`8a56fd6`](https://githu

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051957 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hi

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051950 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala --- @@ -428,7 +432,7 @@ private[hive] case class MetastoreRelation

[GitHub] spark pull request: [SPARK-4250] [SQL] Fix bug of constant null va...

2014-11-08 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3114#issuecomment-62260018 Thank you @marmbrus to review this. All of primitive constant null value actually will not find a match, and will be considered as normal ObjectInspector, this

[GitHub] spark pull request: [SPARK-4012] call tryOrExit instead of logUnca...

2014-11-08 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/2864#issuecomment-62259510 Hi, @andrewor14 , Sorry about the misunderstanding and thanks for your patient explanation I will resubmit it and hopefully will get more feedbacks about this,

[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread varadharajan
Github user varadharajan commented on the pull request: https://github.com/apache/spark/pull/2894#issuecomment-62259405 Also i think it would help users if we can document in the LR section of the MLlib guide, which algorithm should be preferred in which scenarios. --- If your projec

[GitHub] spark pull request: [SPARK-4250] [SQL] Fix bug of constant null va...

2014-11-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/3114#discussion_r20051871 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala --- @@ -254,46 +255,59 @@ private[hive] trait HiveInspectors {

[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2894#issuecomment-62259296 [Test build #23102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23102/consoleFull) for PR 2894 at commit [`5f9406b`](https://githu

[GitHub] spark pull request: [SPARK-4047] - Generate runtime warnings for e...

2014-11-08 Thread varadharajan
Github user varadharajan commented on the pull request: https://github.com/apache/spark/pull/2894#issuecomment-62259256 @jkbradley Makes sense. I've updated the warnings, please let me know if wordings can be improved. Also i just noticed that pyspark classification model does not hav

[GitHub] spark pull request: [SPARK-4250] [SQL] Fix bug of constant null va...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3114#issuecomment-62259067 [Test build #23101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23101/consoleFull) for PR 3114 at commit [`e603bda`](https://githu

[GitHub] spark pull request: [SPARK-4239] [SQL] support view in HiveQl

2014-11-08 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/3131#discussion_r20051793 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -21,6 +21,7 @@ import java.sql.Date import org.apache.hadoop.hive.conf

[GitHub] spark pull request: [SPARK-4274] [SQL] Print informative message w...

2014-11-08 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/3139#discussion_r20051763 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveComparisonTest.scala --- @@ -341,12 +341,21 @@ abstract class HiveComparison

[GitHub] spark pull request: [SPARK-4205][SQL] Timestamp and Date classes w...

2014-11-08 Thread culler
Github user culler commented on the pull request: https://github.com/apache/spark/pull/3066#issuecomment-62257326 Thanks! I'm proud to be a member of the club. :^) On Fri, Nov 7, 2014 at 11:16 PM, Cheng Lian wrote: > @culler Don't worr

[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3170#issuecomment-62257227 [Test build #23100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23100/consoleFull) for PR 3170 at commit [`865fb5a`](https://gith

[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3170#issuecomment-62257228 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-4156 [MLLIB] EM algorithm for GMMs

2014-11-08 Thread tgaloppo
Github user tgaloppo commented on the pull request: https://github.com/apache/spark/pull/3022#issuecomment-62256712 This test appeared to fail due to some form of timeout during the pull; is there any action I need to take? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: SPARK-971 [DOCS] Link to Confluence wiki from ...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3169#issuecomment-62255849 [Test build #23099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23099/consoleFull) for PR 3169 at commit [`dcb84d0`](https://gith

[GitHub] spark pull request: SPARK-971 [DOCS] Link to Confluence wiki from ...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3169#issuecomment-62255850 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-1344 [DOCS] Scala API docs for top metho...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3168#issuecomment-62255695 [Test build #23098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23098/consoleFull) for PR 3168 at commit [`6963fcc`](https://gith

[GitHub] spark pull request: SPARK-1344 [DOCS] Scala API docs for top metho...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3168#issuecomment-62255698 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an 1-hi...

2014-11-08 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-62254979 I agree with what @debasish83 said. We should find a suitable solution to weight matrix distributed storage. --- If your project is set up for it, you can reply to this e

[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3170#issuecomment-62254881 [Test build #23100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23100/consoleFull) for PR 3170 at commit [`865fb5a`](https://githu

[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...

2014-11-08 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/3170 SPARK-948 [WEB UI] Move "Classpath Entries" in WebUI This is a trivial change that resolves SPARK-948. Feel free to reject it too if there's not agreement on it, and then the JIRA can be closed. Just

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62254523 [Test build #23097 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23097/consoleFull) for PR 2735 at commit [`b6d8001`](https://gith

[GitHub] spark pull request: Update RecoverableNetworkWordCount.scala

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2735#issuecomment-62254525 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-4305 [BUILD] yarn-alpha profile won't bu...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3167#issuecomment-62253946 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

[GitHub] spark pull request: SPARK-4305 [BUILD] yarn-alpha profile won't bu...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3167#issuecomment-62253944 [Test build #23094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23094/consoleFull) for PR 3167 at commit [`88938cb`](https://gith

[GitHub] spark pull request: [SPARK-4293][SQL] Make Cast be able to handle ...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3150#issuecomment-62253732 [Test build #23096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23096/consoleFull) for PR 3150 at commit [`8999868`](https://gith

[GitHub] spark pull request: SPARK-971 [DOCS] Link to Confluence wiki from ...

2014-11-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3169#issuecomment-62253730 [Test build #23099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23099/consoleFull) for PR 3169 at commit [`dcb84d0`](https://githu

[GitHub] spark pull request: [SPARK-4293][SQL] Make Cast be able to handle ...

2014-11-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3150#issuecomment-62253734 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23

  1   2   >