[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67423/consoleFull)** for PR 13891 at commit [`294164d`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67423/ Test FAILed. ---

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67423/consoleFull)** for PR 13891 at commit [`294164d`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84615167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -76,8 +76,14 @@ abstract class Covaria

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67422/ Test FAILed. ---

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67422/consoleFull)** for PR 13891 at commit [`d29fd67`](https://github.com/apache/spark/commit/

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13891 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in ALS

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13891 **[Test build #67422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67422/consoleFull)** for PR 13891 at commit [`d29fd67`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 I have another question. I found this PR also use `expressions` in the description when the function only accepts foldable expressions. This is also unclear to the users. --- If your project is

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84613013 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala --- @@ -43,11 +43,20 @@ import org.apache.s

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 To differentiate literals from expressions, the simplest way is to add `expr` or `expression` into the function name. For the arguments whose names do not contain `expr`, they are treated as lite

[GitHub] spark issue #15579: Added support for extra command in front of spark.

2016-10-23 Thread sheepduke
Github user sheepduke commented on the issue: https://github.com/apache/spark/pull/15579 @srowen Hi, at first we wanted to add support for numactl only, but later we thought that it is rather better to make it possible for adding the prefix command. It is not only for NUMA, but also f

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13252 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13252 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67421/ Test PASSed. ---

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13252 **[Test build #67421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67421/consoleFull)** for PR 13252 at commit [`031c9da`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67420/ Test PASSed. ---

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15603 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15603 **[Test build #67420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67420/consoleFull)** for PR 15603 at commit [`6fcd247`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 IMHO, I would like to leave it and prefer to differentiate literal from expression as it throws an exception, for example, when a column is given as an argument for literal, the exception messag

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15604 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #15604: [SPARK-18066] [CORE] [TESTS] Add Pool usage policies tes...

2016-10-23 Thread erenavsarogullari
Github user erenavsarogullari commented on the issue: https://github.com/apache/spark/pull/15604 cc @kayousterhout @markhamstra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark pull request #15604: Add Pool usage policies test coverage for FIFO & ...

2016-10-23 Thread erenavsarogullari
GitHub user erenavsarogullari opened a pull request: https://github.com/apache/spark/pull/15604 Add Pool usage policies test coverage for FIFO & FAIR Schedulers ## What changes were proposed in this pull request? The following FIFO & FAIR Schedulers Pool usage cases need to have

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15513 Thanks @gatorsmile. I will double-check if there is any instance more that misses default value. For the format, I asked @rxin initially to avoid change a lot repeatedly. Could I please

[GitHub] spark issue #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in the UI

2016-10-23 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/15441 @srowen Addressed the try-finally, this look good to go now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84604637 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala --- @@ -49,21 +49,29 @@ import org

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84604598 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala --- @@ -150,8 +206,16 @@ case class XPathString(xml: Exp

[GitHub] spark issue #15553: [SPARK-18008] [build] Add support for -Dmaven.test.skip=...

2016-10-23 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/15553 @srowen This is explicitly supports maven.test.skip=true - the rationale for using it can be project specific (generating clean builds for various profile combinations, internal release builds from

[GitHub] spark issue #13252: [SPARK-15473][SQL] CSV data source writes header for emp...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13252 **[Test build #67421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67421/consoleFull)** for PR 13252 at commit [`031c9da`](https://github.com/apache/spark/commit/0

[GitHub] spark pull request #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column t...

2016-10-23 Thread CodingCat
Github user CodingCat closed the pull request at: https://github.com/apache/spark/pull/15602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15602 Merging to branch-2.0. Thanks! Can you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67418/ Test PASSed. ---

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15541 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15541 **[Test build #67418 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67418/consoleFull)** for PR 15541 at commit [`6b29002`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in the UI

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15441 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in the UI

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67417/ Test PASSed. ---

[GitHub] spark issue #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in the UI

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15441 **[Test build #67417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67417/consoleFull)** for PR 15441 at commit [`0162c81`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15602 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15602 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67419/ Test PASSed. ---

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15602 **[Test build #67419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67419/consoleFull)** for PR 15602 at commit [`e0d806a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15603 **[Test build #67420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67420/consoleFull)** for PR 15603 at commit [`6fcd247`](https://github.com/apache/spark/commit/6

[GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup

2016-10-23 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/15603 [WEBUI][MINOR] Return types in methods + cleanup ## What changes were proposed in this pull request? The main purpose of the change is to discuss the purpose of `SparkUITab` class a

[GitHub] spark issue #11119: [SPARK-10780][ML] Add an initial model to kmeans

2016-10-23 Thread yinxusen
Github user yinxusen commented on the issue: https://github.com/apache/spark/pull/9 How about the following: 1. Since the new generated model is derived from an estimator, the model should have the same params as its parent estimator. That's why there is no need to consid

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15602 LGTM - pending jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] spark issue #15596: [SQL] Remove shuffle codes in CollectLimitExec

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15596 @JoshRosen could you shed some light on why we are not using the regular `EnsureRequirements` based code path for `CollectLimitExec`? --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #15595: [SPARK-18058][SQL] Comparing column types ignorin...

2016-10-23 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/15595#discussion_r84600741 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala --- @@ -377,4 +377,23 @@ class AnalysisSuite extends Anal

[GitHub] spark issue #15602: [SPARK-18058][SQL] [BRANCH-2.0]Comparing column types ig...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15602 **[Test build #67419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67419/consoleFull)** for PR 15602 at commit [`e0d806a`](https://github.com/apache/spark/commit/e

[GitHub] spark pull request #15602: [SPARK-18058][SQL] [BACKPORT-2.0]Comparing column...

2016-10-23 Thread CodingCat
GitHub user CodingCat opened a pull request: https://github.com/apache/spark/pull/15602 [SPARK-18058][SQL] [BACKPORT-2.0]Comparing column types ignoring Nullability in Union and SetOperation ## What changes were proposed in this pull request? The PR tries to fix [SPARK-18

[GitHub] spark pull request #15589: [SPARKR][branch-2.0] R merge API doc and example ...

2016-10-23 Thread felixcheung
Github user felixcheung closed the pull request at: https://github.com/apache/spark/pull/15589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] spark issue #15589: [SPARKR][branch-2.0] R merge API doc and example fix

2016-10-23 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15589 merged to branch-2.0 and then cherry-picked to master for the error message fix not in master. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] spark issue #15541: [SPARK-17637][Scheduler]Packed scheduling for Spark task...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15541 **[Test build #67418 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67418/consoleFull)** for PR 15541 at commit [`6b29002`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/15595 Just saw that this got merged. I had a tiny nit but its ok without it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request #15595: [SPARK-18058][SQL] Comparing column types ignorin...

2016-10-23 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/15595#discussion_r84600424 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala --- @@ -377,4 +377,23 @@ class AnalysisSuite extends An

[GitHub] spark issue #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in the UI

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15441 **[Test build #67417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67417/consoleFull)** for PR 15441 at commit [`0162c81`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15595 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread CodingCat
Github user CodingCat commented on the issue: https://github.com/apache/spark/pull/15595 sure, doing that now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15595 @CodingCat could you open a backport for branch-2.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #15595: [SPARK-18058][SQL] Comparing column types ignorin...

2016-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15595 LGTM - merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark issue #14136: [SPARK-16282][SQL] Implement percentile SQL function.

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14136 It is relatively straight forward to test `ImperativeAggregate`s. See: - org.apache.spark.sql.catalyst.expressions.aggregate.HyperLogLogPlusPlusSuite - org.apache.spark.sql.catalyst.

[GitHub] spark pull request #15441: [SPARK-4411] [Web UI] Add "kill" link for jobs in...

2016-10-23 Thread ajbozarth
Github user ajbozarth commented on a diff in the pull request: https://github.com/apache/spark/pull/15441#discussion_r84599733 --- Diff: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala --- @@ -651,6 +671,15 @@ class UISeleniumSuite extends SparkFunSuite with WebBrowse

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67415/ Test PASSed. ---

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15595 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15513 **[Test build #67415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67415/consoleFull)** for PR 15513 at commit [`2656c62`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15595 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67416/ Test PASSed. ---

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15595 **[Test build #67416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67416/consoleFull)** for PR 15595 at commit [`e691714`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15417: [SPARK-17851][SQL][TESTS] Make sure all test sqls in cat...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15417 Sorry, will review it soon. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 We should also add the default value in the argument description. Below is an example. ``` Arguments: col - a numeric expression. percentage - a numeric literal or

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 Another example: ``` Arguments: expr1 - a numeric expression. expr2 - a numeric expression. ``` -> ``` Arguments: expr1 - Data type: numeric. expr2 -

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/15513 I prefer to minimizing the words without showing any information. Below is an example. ``` Arguments: class - a string literal that represents a fully-qualified class name.

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84597837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala --- @@ -49,21 +49,29 @@ import org.

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84597661 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -692,9 +722,11 @@ case class DenseRank(chi

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84597610 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/xml/xpath.scala --- @@ -150,8 +206,16 @@ case class XPathString(xml: Expr

[GitHub] spark pull request #15513: [SPARK-17963][SQL][Documentation] Add examples (e...

2016-10-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15513#discussion_r84597530 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -970,9 +1270,19 @@ case class Round(child: E

[GitHub] spark issue #15595: [SPARK-18058][SQL] Comparing column types ignoring Nulla...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15595 **[Test build #67416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67416/consoleFull)** for PR 15595 at commit [`e691714`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15513 **[Test build #67415 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67415/consoleFull)** for PR 15513 at commit [`2656c62`](https://github.com/apache/spark/commit/2

[GitHub] spark pull request #15433: [SPARK-17822][SPARKR] Use weak reference in JVMOb...

2016-10-23 Thread techaddict
Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/15433 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15433: [SPARK-17822][SPARKR] Use weak reference in JVMObjectTra...

2016-10-23 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/15433 closing this since, its maybe not the right way to do this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened e...

2016-10-23 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/15601 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15601 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67413/ Test PASSed. ---

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15601 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15601 **[Test build #67413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67413/consoleFull)** for PR 15601 at commit [`9154463`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15601 LGTM. Merging to branch-2.0. Could you close this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15601 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15601 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67412/ Test PASSed. ---

[GitHub] spark issue #15601: [SPARK-17123][SQL][BRANCH-2.0] Use type-widened encoder ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15601 **[Test build #67412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67412/consoleFull)** for PR 15601 at commit [`b233d09`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15413: [SPARK-17847][ML][WIP] Copy GaussianMixture implementati...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15413 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67414/ Test PASSed. ---

[GitHub] spark issue #15413: [SPARK-17847][ML][WIP] Copy GaussianMixture implementati...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15413 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15413: [SPARK-17847][ML][WIP] Copy GaussianMixture implementati...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15413 **[Test build #67414 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67414/consoleFull)** for PR 15413 at commit [`8b94909`](https://github.com/apache/spark/commit/

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15513 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67411/ Test PASSed. ---

[GitHub] spark issue #15513: [SPARK-17963][SQL][Documentation] Add examples (extend) ...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15513 **[Test build #67411 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67411/consoleFull)** for PR 15513 at commit [`feafdc2`](https://github.com/apache/spark/commit/

[GitHub] spark pull request #15582: [SPARK-18045][SQL][TESTS] Move `HiveDataFrameAnal...

2016-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15582 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark issue #14957: [SPARK-4502][SQL]Support parquet nested struct pruning a...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14957 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #15354: [SPARK-17764][SQL] Add `to_json` supporting to convert n...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15354 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] spark issue #14957: [SPARK-4502][SQL]Support parquet nested struct pruning a...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14957 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67410/ Test PASSed. ---

[GitHub] spark issue #15354: [SPARK-17764][SQL] Add `to_json` supporting to convert n...

2016-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15354 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67409/ Test PASSed. ---

[GitHub] spark issue #15582: [SPARK-18045][SQL][TESTS] Move `HiveDataFrameAnalyticsSu...

2016-10-23 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/15582 Merging to master. Thanks! Ping me for the follow-up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #14957: [SPARK-4502][SQL]Support parquet nested struct pruning a...

2016-10-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14957 **[Test build #67410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67410/consoleFull)** for PR 14957 at commit [`ab8f5ec`](https://github.com/apache/spark/commit/

<    1   2   3   >