[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r72144974 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -625,10 +643,12 @@ private[execution] final class OffsetWindowFu

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r72083334 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -625,10 +643,12 @@ private[execution] final class OffsetWindowFunctio

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r72083182 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite extends Q

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71993975 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -625,10 +643,12 @@ private[execution] final class OffsetWindowFu

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71990056 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite exten

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71782889 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite extends Q

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71781735 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite extends Qu

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71781548 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite extends Q

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71781038 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71598723 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLWindowFunctionSuite.scala --- @@ -367,4 +367,50 @@ class SQLWindowFunctionSuite exten

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71598678 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala --- @@ -357,14 +356,59 @@ class SQLWindowFunctionSuite extends Q

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71588935 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLWindowFunctionSuite.scala --- @@ -367,4 +367,50 @@ class SQLWindowFunctionSuite exten

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71584966 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLWindowFunctionSuite.scala --- @@ -367,4 +367,50 @@ class SQLWindowFunctionSuite extend

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71489063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala --- @@ -582,25 +582,43 @@ private[execution] final class OffsetWindowFunctio

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14284#discussion_r71488537 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala --- @@ -382,7 +382,7 @@ abstract class OffsetWindowFun

[GitHub] spark pull request #14284: [SPARK-16633] [SPARK-16642] Fixes three issues re...

GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/14284 [SPARK-16633] [SPARK-16642] Fixes three issues related to window functions ## What changes were proposed in this pull request? This PR contains three changes. First, this PR changes the