Re: [ros-dev] [ros-diffs] [reactos] 06/12: [EXT2] Correctly zero memory before using it

2019-04-01 Thread Pierre Schweitzer
RtlZeroMemory(Prefix, sizeof(WCHAR) * HIDINGPAT_LEN); > +RtlZeroMemory(Suffix, sizeof(WCHAR) * HIDINGPAT_LEN); > RtlZeroMemory(MountPoint, sizeof(USHORT) * 4); > RtlZeroMemory(DrvLetter, sizeof(CHAR) * 4); > > -- Pierre Schweitzer System & Network Administ

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [FREETYPE] Fix 3 regressions in one patch

2019-03-12 Thread Pierre Schweitzer
Buffer, pCount, MaxCount, > - &Win32Process->PrivateFontListHead); > -IntUnLockProcessPrivateFonts(Win32Process); > -break; > +if (*pCount < MaxCount) > +{ > +FontFamilyFillInfo(&Info[*pCount], pF

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [CDFS] Make windows gcc release build compile, regression CORE-15659

2019-01-22 Thread Pierre Schweitzer
atusEx ( > > #else > > +#ifdef __REACTOS__ > +static // make windows gcc release build compile > INLINE > +#endif > DECLSPEC_NORETURN > VOID > CdRaiseStatusEx( > -- Pierre Schweitzer System & Network Administrator Senior Ker

Re: [ros-dev] Web services down

2018-12-26 Thread Pierre Schweitzer
We seem to be back to normal state. Please report if some service is still not working properly. Pierre Schweitzer wrote on Wed, December 26th, 2018, 4:43 PM: > Dear all, > > Due to an unexpected outage touching our hoster infrastructure, our DB server > is currently down and it

[ros-dev] Web services down

2018-12-26 Thread Pierre Schweitzer
Dear all, Due to an unexpected outage touching our hoster infrastructure, our DB server is currently down and it affects all the web services relying on it. So, don't expect Jira, boards, wiki, website, and so on to work properly for now, I'll keep you informed when I have more information. Che

Re: [ros-dev] [ros-diffs] [reactos] 01/01: [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again CORE-15412

2018-12-17 Thread Pierre Schweitzer
wszExpandedBuffer + 1, NULL, > LOAD_LIBRARY_AS_DATAFILE); > +if (!hModule || !load_string(hModule, uiStringId, pszOutBuf, > cbOutBuf / sizeof(WCHAR))) > +result = ERROR_BADKEY; > +FreeLibrary(hModule); > +} > + > +cleanup: > +HeapFree(GetP

Re: [ros-dev] [ros-diffs] 03/03: [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.

2018-11-18 Thread Pierre Schweitzer
t; -@ stdcall -stub CoDisconnectContext(long) > +@ stdcall -stub -version=0x600+ CoDisconnectContext(long) > @ stdcall CoDisconnectObject(ptr long) > @ stdcall CoDosDateTimeToFileTime(long long ptr) > kernel32.DosDateTimeToFileTime > @ stdcall -stub CoEnableCallCancellation(ptr) >

Re: [ros-dev] [ros-diffs] 01/01: [SERVICES] Fix timeout when a service is stopped

2018-10-04 Thread Pierre Schweitzer
> + hStopThread = CreateThread(NULL, > + 0, > + (LPTHREAD_START_ROUTINE)ScmStopThread, > + (LPVOID)lpService, > + 0, > +

Re: [ros-dev] [ros-diffs] 01/01: [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted password

2018-09-17 Thread Pierre Schweitzer
> +{ > +/* Wipe and release the password buffer */ > +ZeroMemory(lpClearTextPassword, > + (wcslen(lpClearTextPassword) + 1) * sizeof(WCHAR)); > + HeapFree(GetProcessHeap(), 0, lpClearTextPassword); > +} > + > if (dwError == ERROR_S

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:MM] Fix paged pool expansion

2018-08-20 Thread Pierre Schweitzer
n failed: PointerPde->u.Hard.Valid == 0 *** Source File: /srv/buildbot/Build_GCCLin_x86/build/ntoskrnl/mm/ARM3/miarm.h, line 975 See testbots for instance: https://build.reactos.org/builders/Test%20VBox/builds/8625/steps/test/logs/stdio Cheers, Pierre -- Pierre Schweitzer System & Netwo

Re: [ros-dev] [ros-diffs] 01/01: [CONFIGURE] Added support for new VS 19.15.x

2018-08-16 Thread Pierre Schweitzer
13." > NUL && set VS_VERSION=15 > cl 2>&1 | find "19.14." > NUL && set VS_VERSION=15 > + cl 2>&1 | find "19.15." > NUL && set VS_VERSION=15 > if not defined VS_VERSION ( > echo Error: Visu

Re: [ros-dev] [ros-diffs] 01/01: [WIN32SS] Fix NtUserGetClipboardData for text paste (#645)

2018-07-03 Thread Pierre Schweitzer
&& pWinStaObj->spwndClipOwner) > +{ > +/* Send WM_RENDERFORMAT message */ > +pWinStaObj->fInDelayedRendering = TRUE; > +co_IntSendMessage(pWinStaObj->spwndClipOwner->head.h, > WM_RENDERFORMAT, (WPARAM)uSourceFmt, 0); > +pWinStaObj->fI

Re: [ros-dev] Microsoft acquires GitHub

2018-06-05 Thread Pierre Schweitzer
lman/listinfo/ros-dev<https://nam05.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.reactos.org%2Fmailman%2Flistinfo%2Fros-dev&data=02%7C01%7C%7Ca6b7a92ca5c146e5bc5e08d5cac00cc9%7C84df9e7fe9f640afb435%7C1%7C0%7C6366378485505520

Re: [ros-dev] [ros-diffs] 04/05: [USETUP] Enhancements for filesystem utility functions.

2018-05-27 Thread Pierre Schweitzer
h b/base/setup/usetup/fslist.h > index 685a2cfe2e..4433d381ba 100644 > --- a/base/setup/usetup/fslist.h > +++ b/base/setup/usetup/fslist.h > @@ -31,7 +31,7 @@ > typedef struct _FILE_SYSTEM_ITEM > { > LIST_ENTRY ListEntry; > -LPCWSTR FileSystemName; /* Not owned by the item */ > +PCWSTR FileSystemName; /* Not owned by the item */ > FORMATEX FormatFunc; > CHKDSKEX ChkdskFunc; > BOOLEAN QuickFormat; > @@ -46,16 +46,16 @@ typedef struct _FILE_SYSTEM_LIST > } FILE_SYSTEM_LIST, *PFILE_SYSTEM_LIST; > > VOID > -FS_AddProvider( > +AddProvider( > IN OUT PFILE_SYSTEM_LIST List, > -IN LPCWSTR FileSystemName, > +IN PCWSTR FileSystemName, > IN FORMATEX FormatFunc, > IN CHKDSKEX ChkdskFunc); > > PFILE_SYSTEM_ITEM > GetFileSystemByName( > IN PFILE_SYSTEM_LIST List, > -IN LPWSTR FileSystemName); > +IN PWSTR FileSystemName); > > struct _PARTENTRY; // Defined in partlist.h > PFILE_SYSTEM_ITEM > @@ -68,7 +68,7 @@ CreateFileSystemList( > IN SHORT Left, > IN SHORT Top, > IN BOOLEAN ForceFormat, > -IN LPCWSTR ForceFileSystem); > +IN PCWSTR SelectFileSystem); > > VOID > DestroyFileSystemList( > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. signature.asc Description: OpenPGP digital signature ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] 01/01: improve SHGetFileInfo (#118)

2018-02-16 Thread Pierre Schweitzer
ltiByte(CP_ACP, 0, temppsfi.szDisplayName, -1, > - psfi->szDisplayName, sizeof(psfi->szDisplayName), NULL, > NULL); > -} > -if(flags & SHGFI_TYPENAME) > -{ > -WideCharToMultiByte(CP_ACP, 0, temppsf

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-08 Thread Pierre Schweitzer
__ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. signature.asc Description: OpenPGP digital signature __

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-08 Thread Pierre Schweitzer
fc22d664ea2485d04303e8ae10047f21f >> Author: Serge Gautherie >> AuthorDate: Wed Feb 7 06:29:02 2018 +0100 >> Commit: Pierre Schweitzer >> CommitDate: Wed Feb 7 22:22:28 2018 +0100 >> >> [NTOS:KE] Replace "Fatal System Error" with "Bu

Re: [ros-dev] Making bluescreens more useful

2018-01-10 Thread Pierre Schweitzer
quick PoC can be found at > https://github.com/ThFabba/reactos/commit/6a9f172b76bd11f763598c16e5d47299eec1971c > > Thoughts? > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev >

Re: [ros-dev] Regression in r75772 broke multiple disk drive support

2017-09-20 Thread Pierre Schweitzer
This regression got fixed with r75911. Can you confirm it's OK on your side? Le 18/09/2017 à 22:41, Pierre Schweitzer a écrit : > Ack. See https://jira.reactos.org/browse/CORE-13805 > > Thanks for the report. > > Le 17/09/2017 à 17:39, Dimitrij Klingbeil a écrit : >> H

Re: [ros-dev] Regression in r75772 broke multiple disk drive support

2017-09-18 Thread Pierre Schweitzer
om the wrong (not subscribed to the list) > address by mistake. I think the first one was rejected by the list SW, > but sorry if the message appears twice. > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Pierre Schweitzer

Re: [ros-dev] [ros-diffs] [cfinck] 75630: [FS_REC] - Add a detection routine for CDFS (ISO-9660) volumes that verifies the Primary Volume Descriptor. - Use this to also detect CDFS on disks and load t

2017-08-21 Thread Pierre Schweitzer
UDFS for CDs */ > > Modified: trunk/reactos/drivers/filesystems/fs_rec/udfs.c > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec/udfs.c?rev=75630&r1=75629&r2=75630&view=diff > == > --- trunk/reactos/drivers/filesystems/fs_rec/udfs.c [iso-8859-1] (original) > +++ trunk/reactos/drivers/filesystems/fs_rec/udfs.c [iso-8859-1] Sun Aug 20 > 15:30:59 2017 > @@ -125,7 +125,7 @@ > MountDevice = Stack->Parameters.MountVolume.DeviceObject; > if (FsRecGetDeviceSectorSize(MountDevice, &SectorSize)) > { > -/* Check if it's an actual FAT volume */ > +/* Check if it's an actual UDF volume */ > if (FsRecIsUdfsVolume(MountDevice, SectorSize)) > { > /* It is! */ > > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [hbelusca] 72922: [KD] - When enabling or disabling the kernel debugger and setting the KdDebuggerEnabled flag, also update the corresponding user-mode flag in SharedUserData

2016-10-06 Thread Pierre Schweitzer
;KdpDebugLogSpinLock); > > /* Display separator + ReactOS version at start of the debug log */ > - > DPRINT1("---\n"); > +DPRINT1("---------\n"); This specific change has likely broke

Re: [ros-dev] [ros-diffs] [dchapyshev] 72835: [NTOS:FSRTL] Rework FsRtlIsNameInExpressionPrivate for correct parsing some expressions * Fixes 1 test for kmtest:FsRtlExpression and 15 tests for kernel3

2016-09-28 Thread Pierre Schweitzer
> sizeof(WCHAR)] == DOS_QM) > +{ > +if (EndOfName || Name->Buffer[NamePosition] == L'.') > continue; > + > +BackTracking[BackTrackingPosition++] = > (ExpressionPosition + sizeof(WCHAR)) * 2; > +

Re: [ros-dev] [ros-diffs] [jgardou] 72435: [KDGDB] - Implement setting and removing breakpoints - Implement single-stepping - Only get past the breakpoint instruction when it comes from RtlpBreakWithS

2016-08-23 Thread Pierre Schweitzer
; > > /* GLOBALS > / > @@ -203,16 +208,15 @@ > > if (!Resuming) > { > +/* Report the idle thread */ > +#if MONOPROCESS > +ptr += sprintf(ptr, "1");

Re: [ros-dev] [ros-diffs] [jgardou] 72435: [KDGDB] - Implement setting and removing breakpoints - Implement single-stepping - Only get past the breakpoint instruction when it comes from RtlpBreakWithS

2016-08-23 Thread Pierre Schweitzer
4]; > -*ptr++ = hex_chars[EipPtr[2] & 0xF]; > -*ptr++ = hex_chars[EipPtr[3] >> 4]; > -*ptr++ = hex_chars[EipPtr[3] & 0xF]; > -*ptr++ = ';'; > -*ptr++ = '\0'; > - > -return ptr; > -} > - > + > > Modified: trunk/react

Re: [ros-dev] [ros-diffs] [tthompson] 71945: [NTFS] *AddRun() - Don't leak RunBuffer when encountering errors. Handle exception from FsRtlAddLargeMcbEntry().

2016-07-24 Thread Pierre Schweitzer
d do the cleanup in the exception handler. That avoids code duplication. This also implies you don't want to force the status code, but rather use _SEH2_GetExceptionCode(). Also note that FsRtlAddLargeMcbEntry may fail for various reasons. I don't really know which status code to use as you

Re: [ros-dev] [ros-diffs] [tthompson] 71957: [NTFS] Address some minor issues with attrib.c: Fix gcc build. Fix formatting.

2016-07-24 Thread Pierre Schweitzer
fs/attrib.c [iso-8859-1] > Sun Jul 17 14:04:01 2016 > @@ -295,14 +291,14 @@ > ULONG RunBufferOffset = 0; > LONGLONG DataRunOffset; > ULONGLONG LastLCN = 0; > - > LONGLONG Vbn, Lbn, Count; > +int i; Use MS portable type, please (ULONG looks good :-))

Re: [ros-dev] [ros-diffs] [tthompson] 71968: [NTFS] +FreeClusters(). Fix a DPRINT.

2016-07-24 Thread Pierre Schweitzer
FS_ATTR_RECORD NextAttribute = > (PNTFS_ATTR_RECORD)((ULONG_PTR)FileRecord + NextAttributeOffset); > +ULONGLONG NextVBN = AttrContext->Record.NonResident.LowestVCN; > + > +// Allocate some memory for the RunBuffer > +PUCHAR RunBuffer = ExAllocatePoolWithTa

Re: [ros-dev] [ros-diffs] [tthompson] 71807: [NTFS][FREELDR] Fix ReadAttribute() and NtfsReadAttribute() in the case when an attribute contains two data runs; Remove extra if statement that prevents s

2016-07-06 Thread Pierre Schweitzer
17:02:10 2016 > @@ -384,9 +384,6 @@ > } > else > DataRunStartLCN = -1; > - > -if (*DataRun == 0) > -return AlreadyRead; > } > > while (Length > 0) > > -- Pierre Schweitzer

Re: [ros-dev] [ros-diffs] [tthompson] 71820: [NTFS] Add ability to write to resident attributes. SetAttributeDataLength() - Check if the file is memory mapped before truncating +InternalSetResidentAtt

2016-07-06 Thread Pierre Schweitzer
Le 06/07/2016 19:59, Trevor Thompson a écrit : > Hi Pierre, thanks for the fast review! I'll respond inline. > > On Tue, Jul 5, 2016 at 4:39 PM, Pierre Schweitzer > wrote: > >> Hi, >> >> Comments inline. >> >> Le 0

Re: [ros-dev] [ros-diffs] [tthompson] 71820: [NTFS] Add ability to write to resident attributes. SetAttributeDataLength() - Check if the file is memory mapped before truncating +InternalSetResidentAtt

2016-07-05 Thread Pierre Schweitzer
,7 +157,7 @@ > DPRINT1("Total clusters in bitmap: %I64x\n", BitmapDataSize * 8); > DPRINT1("Diff in size: %I64d B\n", ((BitmapDataSize * 8) - > DeviceExt->NtfsInfo.ClusterCount) * DeviceExt->NtfsInfo.SectorsPerCluster * > DeviceExt->NtfsInfo

Re: [ros-dev] [ros-diffs] [hbelusca] 71419: [NETSHELL]: Fix french orthograph.

2016-05-26 Thread Pierre Schweitzer
S_SHOWSELALWAYS | LVS_NOCOLUMNHEADER | LVS_NOSORTHEADER | > WS_BORDER | WS_TABSTOP, 33, 22, 250, 50 > PUSHBUTTON "&Installer...", IDC_NETWORK_INSTALL, 122, 75, 50, 14, > WS_DISABLED | WS_TABSTOP For the record, "n/a" isn't French. n/a means "Not avai

Re: [ros-dev] Regarding r71352 and SubGit

2016-05-18 Thread Pierre Schweitzer
it's better to get > rid of that commit in SVN history rather than having everyone suffer > from it. > > Again, I deeply apologize! > > > With best regards, > > Colin > > ___ > Ros-dev mailing list > Ros-dev@reactos.org &g

Re: [ros-dev] [ros-diffs] [spetreolle] 71201: [CDMAKE] Don't check for extension length on Joliet images. Encountered with AHK binaries. ONLINE-567

2016-04-24 Thread Pierre Schweitzer
orting...", filename); > s++; > } > -if (strlen(s) > MAX_EXTENSION_LENGTH) > +// Check for extension length > +if (!joliet && strlen(s) > MAX_EXTENSION_LENGTH) > { > error_exit("'%s' has too long ext

Re: [ros-dev] GSOC-2016

2016-03-12 Thread Pierre Schweitzer
ng big,. > But i can learn and show you the proposal before i submit it. > > With Care > Samian > > From: Ros-dev on behalf of Pierre Schweitzer > > Sent: Sunday, March 6, 2016 2:41 AM > To: ros-dev@reactos.org > Subject: Re: [ros-dev] GSOC

Re: [ros-dev] GSOC-2016

2016-03-05 Thread Pierre Schweitzer
omeone working around to > mentor me at some stages. > > > Any advice would be appreciated > > > With Care > > Samian > > > > > _______ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos

Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-02 Thread Pierre Schweitzer
hat is interpreted by Usetup as a failure (and the error message appears, > forbidding the user to continue nevertheless to install ROS). > > Cheers, > Hermès > > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre > Schweitz

Re: [ros-dev] [ros-diffs] [hbelusca] 70857: [USETUP]: In case chkdsk detects some disk errors, just display a warning message but allow the user to continue the installation.

2016-03-01 Thread Pierre Schweitzer
g/svn/reactos/trunk/reactos/base/setup/usetup/lang/tr-TR.h?rev=70857&r1=70856&r2=70857&view=diff > == > --- trunk/reactos/base/setup/usetup/lang/tr-TR.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/usetup/lang/tr-TR.h [iso-8859-1] Wed Mar 2 > 00:51:48 2016 > @@ -1724,6 +1724,8 @@ > "Kur, ReactOS'u b”lm zerine kurar."}, > {STRING_CHECKINGPART, > "Kur, Ÿimdi se‡ili b”lm g”zden ge‡iriyor."}, > +{STRING_CONTINUE, > +"GiriŸ = Srdr"}, > {STRING_QUITCONTINUE, > "˜3 = €k GiriŸ = Srdr"}, > {STRING_REBOOTCOMPUTER, > > Modified: trunk/reactos/base/setup/usetup/lang/uk-UA.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/lang/uk-UA.h?rev=70857&r1=70856&r2=70857&view=diff > == > --- trunk/reactos/base/setup/usetup/lang/uk-UA.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/usetup/lang/uk-UA.h [iso-8859-1] Wed Mar 2 > 00:51:48 2016 > @@ -1753,6 +1753,8 @@ > "ReactOS ¢áâ ­®¢«îóâìáï ­ ஧¤i«"}, > {STRING_CHECKINGPART, > "‚áâ ­®¢«î¢ ç ¯¥à¥¢iàïó ¢¨¡à ­¨© ஧¤i«."}, > +{STRING_CONTINUE, > +"ENTER = à®¤®¢¦¨â¨"}, > {STRING_QUITCONTINUE, > "F3 = ‚¨©â¨ ENTER = à®¤®¢¦¨â¨"}, > {STRING_REBOOTCOMPUTER, > > Modified: trunk/reactos/base/setup/usetup/mui.h > URL: > http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/mui.h?rev=70857&r1=70856&r2=70857&view=diff > == > --- trunk/reactos/base/setup/usetup/mui.h [iso-8859-1] (original) > +++ trunk/reactos/base/setup/usetup/mui.h [iso-8859-1] Wed Mar 2 > 00:51:48 2016 > @@ -115,11 +115,12 @@ > #define STRING_NONFORMATTEDOTHERPART 63 > #define STRING_INSTALLONPART 10 > #define STRING_CHECKINGPART 11 > -#define STRING_QUITCONTINUE 12 > -#define STRING_REBOOTCOMPUTER13 > -#define STRING_TXTSETUPFAILED14 > -#define STRING_COPYING 15 > -#define STRING_SETUPCOPYINGFILES 16 > +#define STRING_CONTINUE 12 > +#define STRING_QUITCONTINUE 13 > +#define STRING_REBOOTCOMPUTER14 > +#define STRING_TXTSETUPFAILED15 > +#define STRING_COPYING 16 > +#define STRING_SETUPCOPYINGFILES 17 > #define STRING_REGHIVEUPDATE 20 > #define STRING_IMPORTFILE21 > #define STRING_DISPLAYETTINGSUPDATE 22 > > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: Signature cryptographique S/MIME ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [GSOC] NTFS driver improvements

2016-03-01 Thread Pierre Schweitzer
iverable and a plan for completion of project, if it is to be > selected for Google summer of Code. > > It'll be great if somebody, could mentor me for this project. > > Thanks, > Pratik Singhal > > > > ___ >

Re: [ros-dev] Something is wron again with getbuilds

2015-12-16 Thread Pierre Schweitzer
age again? > -- > С уважением, > Alexander Rechitskiy > +79286331900 > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System &a

Re: [ros-dev] [ros-diffs] [sginsberg] 69393: [NTOS] Fix the Ob wait system calls to only catch the exceptions that are expected to be raised by the Ke wait functions (and not potentially silently catc

2015-09-28 Thread Pierre Schweitzer
doubt, just put some random: Status = ZwWaitForMultipleObjects(2, (void **)0x42424242, WaitAll, FALSE, NULL); In a kernel component. In w2k3, you'll get Status = STATUS_ACCESS_VIOLATION In ReactOS, with your changes: BSOD. Please before doing random changes that you believe are right: do te

Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining French strings in msgina.dll

2015-09-14 Thread Pierre Schweitzer
me thing (eg. If you see “when pigs will fly” you won’t > translate by “quand les cochons voleront” in French, but instead you’ll say > “quand les poules auront des dents”). > > > > [...] > > > > Kind regards, > > > > Sylvain Petreolle > > > >

Re: [ros-dev] [ros-diffs] [pschweitzer] 69221: [MOUNTMGR] Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_CREATED: - Implement WriteRemoteDatabaseEntry() - Implement MountMgrVolumeMountPointCrea

2015-09-14 Thread Pierre Schweitzer
sociatedEntry->AssociatedDevicesEntry); >> + >> +/* We're done! */ >> +FreePool(SourceSymbolicName.Buffer); >> +return STATUS_SUCCESS; >> } >> >> NTSTATUS >> >> Modified: trunk/reactos/drivers/filters/mountmgr/mntmgr.h >> URL: >> http://svn.reactos

Re: [ros-dev] [ros-diffs] [spetreolle] 69186: [TRANSLATIONS] Translate remaining French strings in msgina.dll

2015-09-11 Thread Pierre Schweitzer
uot;Your password has expired and must be changed." > +IDS_LOCKMSG "Seul %s ou un administrateur peut déverrouiller cet > ordinateur." > +IDS_LOGONMSG "Vous êtes connecté en tant que %s." > + IDS_LOGONDATE "Date de connexion: %s %s" See

Re: [ros-dev] [ros-diffs] [hbelusca] 68754: [NTVDM]: Initialize the PSP' memory control block owner name with the file name (without extension, and up to 8 chars) of the started program.

2015-08-18 Thread Pierre Schweitzer
re the program can find > itself on disk? :p > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer Re

Re: [ros-dev] [ros-diffs] [aandrejevic] 68607: [FASTFAT] Irp->UserBuffer being NULL doesn't indicate any error. It could be that the caller really wants the result stored at address NULL (which can be

2015-08-07 Thread Pierre Schweitzer
FER; > goto ByeBye; > @@ -927,7 +927,7 @@ > OldFileSize = Fcb->RFCB.FileSize; > > Buffer = VfatGetUserBuffer(IrpContext->Irp, > BooleanFlagOn(IrpContext->Irp->Flags, IRP_PAGING_IO)); > -if (!Buffer) > +if (!Buffer && IrpContext->

Re: [ros-dev] [ros-diffs] [cwittich] 68305: [BROWSEUI] don't expose some interfaces expose IID_IContextMenu3 from CBandSiteMenu

2015-06-29 Thread Pierre Schweitzer
D_IPersistStreamInit, IPersistStreamInit) > COM_INTERFACE_ENTRY_IID(IID_IOleCommandTarget, IOleCommandTarget) > @@ -237,7 +236,5 @@ > COM_INTERFACE_ENTRY_IID(IID_IShellChangeNotify, IShellChangeNotify) > COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite) >

Re: [ros-dev] Name of builders/testers in buildbot

2015-06-14 Thread Pierre Schweitzer
h BuildBot and Testman. >> >> Changes have been applied. >> Experiences show that BuildBot changes break things easily, so just >> reply here if something has stopped working. >> >> Cheers, >> >> Colin > > > _____

Re: [ros-dev] Changes in authentication for Jira

2015-06-11 Thread Pierre Schweitzer
__ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature _

Re: [ros-dev] Changes in authentication for Jira

2015-06-11 Thread Pierre Schweitzer
reenabling the > agile-extensions, that I think we lost on the previous update attempt. > > Thanks, > Timo > > > Am 10.06.2015 um 16:34 schrieb Pierre Schweitzer: >> Dear all, >> >> We have proceed to a complete reimplementation of authentication server >

Re: [ros-dev] Changes in authentication for Jira

2015-06-10 Thread Pierre Schweitzer
he first > time? > > Hermès. > > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre > Schweitzer > Envoyé : mercredi 10 juin 2015 16:34 > À : ReactOS Development List > Objet : [ros-dev] Changes in authenticatio

[ros-dev] Changes in authentication for Jira

2015-06-10 Thread Pierre Schweitzer
not spot anything wrong with our new authentication mechanism, then, then the upgrade to Jira 6 should happen in the next days. With my best regards, -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Crypt

Re: [ros-dev] Vote for removing rapps DB from trunk

2015-06-01 Thread Pierre Schweitzer
pinion in completely removing > the RAPPS DB from trunk into a subtree like done for many other things, too. > > What do you think? > > > > Greetings > > > > Daniel Reimer > > > > Gesendet von Windows Mail > > > > > >

Re: [ros-dev] Status Meeting (May 2015)

2015-05-28 Thread Pierre Schweitzer
t; start with a proposed agenda. > > Regards, > Aleksey Bragin > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Pierre Schweitzer System & Network Administrat

Re: [ros-dev] Fezile motherboard has finally failed

2015-05-11 Thread Pierre Schweitzer
Forgot to say: The generation is done and went fine. Enjoy the most up to date Doxygen ;-). On 05/11/2015 08:46 AM, Ged Murphy wrote: > Great, thanks Pierre :) > > -Original Message- > From: Ros-dev [mailto:ros-dev-boun...@reactos.org] On Behalf Of Pierre > Schweitzer >

Re: [ros-dev] Fezile motherboard has finally failed

2015-05-10 Thread Pierre Schweitzer
lso there is a huge pile of replacement hardware > available. >> >> Sorry for the inconveniences! >> >> Cheers, >> >> Colin >> >> >> >> ___ >> Ros-dev mailing list >> Ros-dev@rea

Re: [ros-dev] [ros-builds] Trunk_x86_GCCLin Release: build failed

2015-05-10 Thread Pierre Schweitzer
gt; > Buildbot URL: https://build.reactos.org/ > > Buildslave for this Build: Debug > > Build Reason: The Periodic scheduler named 'Release' triggered this build > Build Source Stamp: HEAD > Blamelist: > > BUILD FAILED: failed shell > > sincerel

Re: [ros-dev] [ros-diffs] [akhaldi] 67508: [PARPORT] Introduce a skeleton that will serve as base for implementing the parallel port function driver. Brought to you by The ReactOS Printing Group. CORE

2015-05-02 Thread Pierre Schweitzer
___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > > _______ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pier

Re: [ros-dev] [ros-diffs] [akhaldi] 67508: [PARPORT] Introduce a skeleton that will serve as base for implementing the parallel port function driver. Brought to you by The ReactOS Printing Group. CORE

2015-05-02 Thread Pierre Schweitzer
a good example, nor a reason to keep doing so. -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature ___ Ros-dev mailing list Ros-dev@reactos.org

Re: [ros-dev] Status Meeting (April 2015)

2015-04-30 Thread Pierre Schweitzer
___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature

Re: [ros-dev] [ros-diffs] [aandrejevic] 67340: [NTVDM] Implement basic XMS functions.

2015-04-21 Thread Pierre Schweitzer
e ? Entry : NULL; > +} This looks highly dangerous to me and likely compiler dependent. I'd rather perform the sanity checks before ever touching HandleTable, especially because the value of Handle is coming right from caller registers and have never been sanitized before. -- Pierre Schwei

Re: [ros-dev] old.reactos.org reaching end-of-life

2015-04-03 Thread Pierre Schweitzer
Dear all, As planned, the server has been taken down today. With my best regards, On 03/02/2015 15:58, Pierre Schweitzer wrote: > Dear all, > > On the 3rd of April 2015, the old.reactos.org website will be taken > offline after several years of good services. > > If you have

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66988: [EXPLORER] - Fix showing the website when Help is selected from the start menu.

2015-03-31 Thread Pierre Schweitzer
8,7 +28,7 @@ > STRINGTABLE > BEGIN > //IDS_HELP_COMMAND "helpctr.exe>-FromStartHelp" > -IDS_HELP_COMMAND "https://www.reactos.org/"; > +IDS_HELP_COMMAND "http://www.reactos.org/"; This is to be reverted once ReactOS fully supports SSL. -- Pierre Schwei

Re: [ros-dev] [ros-diffs] [hbelusca] 66946: [CMAKE] Improve the concatenate_files macro introduced by Timo in r52179 + r52182 and hackfixed in r53914 . Notice that now it can take an arbitrary number

2015-03-29 Thread Pierre Schweitzer
output) >> -get_target_property(_file2 ${_target2} LOCATION) >> -add_custom_command( >> -OUTPUT ${_output} >> -COMMAND cat ${_file1} ${_file2} > ${_output} >> -DEPENDS ${_file1} >> -DEPENDS ${_target

Re: [ros-dev] [ros-diffs] [hbelusca] 66903: [NTVDM] - Fix some english. - Validity checks for DosGetSftEntry returned pointer added. - Use unsigned indices for for-loops indices that are always positi

2015-03-26 Thread Pierre Schweitzer
x27;t comment for yourself. Comment for the others, you're not alone here. So, make it explicit. Cheers, -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature ___

Re: [ros-dev] Jira & Fisheye downtime

2015-03-19 Thread Pierre Schweitzer
Dear all, Jira & Fisheye are getting back online. Everything went fine. Please report if you see anything wrong. With my best regards, On 03/19/2015 04:54 PM, Pierre Schweitzer wrote: > Dear all, > > Due to DB maintenance, Jira & Fisheye will be down in a few minutes. > T

[ros-dev] Jira & Fisheye downtime

2015-03-19 Thread Pierre Schweitzer
Dear all, Due to DB maintenance, Jira & Fisheye will be down in a few minutes. There's no ETA for up status. Sorry for the caused inconvenience, -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME

Re: [ros-dev] ReactOS versioning

2015-03-10 Thread Pierre Schweitzer
v@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Network Administ

Re: [ros-dev] ReactOS versioning

2015-03-07 Thread Pierre Schweitzer
ike > ros-kernel-base.dll or - when a compile switch is given - to link > together fully self contained DLLs. > > I am really not interested in answers like "This is not what WIndows > does!", "THIS CANNOT WORK!!!", "You are a * even suggesting this", > "What if a

Re: [ros-dev] [ros-diffs] [hbelusca] 66575: Start source tree (final, I hope!) restructuration. Part 1/X Win32, Shell, Services, MVDM

2015-03-06 Thread Pierre Schweitzer
ment. >> >> I understand ReactOS is a very loosely managed project (to favor ease >> of development), but totally ignoring everyone? >> I checked CORE-9111 and I don't see any single comment from Timo, >> Jerome, James, whoever else counts. >> >> Re

Re: [ros-dev] [ros-diffs] [hbelusca] 66575: Start source tree (final, I hope!) restructuration. Part 1/X Win32, Shell, Services, MVDM

2015-03-05 Thread Pierre Schweitzer
ee any single comment from Timo, Jerome, > James, whoever else counts. > > Regards, > Aleksey Bragin > P.S. I'm not talking about actual changes, I'm talking about the process and > attitude. > > On 06.03.2015 2:03, hbelu...@svn.reactos.org wrote: >> Author: hbelusca >> Date: Thu

Re: [ros-dev] GSoC :: application rejected

2015-03-03 Thread Pierre Schweitzer
(i.e. no > apparent reasons)? > > Cheers, > Hermès. > > -Message d'origine- > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Pierre > Schweitzer > Envoyé : lundi 2 mars 2015 22:23 > À : ReactOS Development List > Objet : [ros-dev] GSoC

[ros-dev] GSoC :: application rejected

2015-03-02 Thread Pierre Schweitzer
Dear all, The ReactOS Foundation application to GSoC has been rejected this year again. Statistics are not reliable after all. In any case, keep up the good work. We don't need Google to be the bests at what we do. Cheers, -- Pierre Schweitzer System & Network Administrator Seni

Re: [ros-dev] Cant log in jira

2015-03-01 Thread Pierre Schweitzer
> С уважением, >> Alexander Rechitskiy >> +79286331900 >> > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev -- Pierre Schweitzer System & Network Administrator

Re: [ros-dev] VirtualBox Testslave

2015-02-26 Thread Pierre Schweitzer
With latest sysreg2 available in SVN, it's working fine. On 02/18/2015 11:38 AM, Pierre Schweitzer wrote: > Hi Colin, > > I will have a look at sysreg2. > > Please make sure that the NUC is setup with the latest LTS. It will make > the process smoother. > > Cheers

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66383: [SHELL32] - Implement progress dialogs for SHFileOperation - Patch by Hwu Davies CORE-4476

2015-02-21 Thread Pierre Schweitzer
FILEOOP_MOVING"Moving" > +IDS_FILEOOP_DELETING "Deleting" > +IDS_FILEOOP_FROM_TO "From %1 to %2" > +IDS_FILEOOP_FROM "From %1" > + IDS_FILEOOP_PREFLIGHT "Preflight" > + > /* message box strings */ >

Re: [ros-dev] VirtualBox Testslave

2015-02-18 Thread Pierre Schweitzer
eg2 can fully handle VirtualBox once I set up the machine. > > Cheers, > > Colin > > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schwe

Re: [ros-dev] The ReactOS Project at FOSDEM 2015

2015-02-06 Thread Pierre Schweitzer
, > > FOSDEM 2015 has ended some days ago. After five years of absence, the > ReactOS Project was finally represented with a stand again, maintained > by Aleksey Bragin, Giannis Adamopoulos, Pierre Schweitzer and me. > Turns out that FOSDEM has significantly grown over the recent y

[ros-dev] old.reactos.org reaching end-of-life

2015-02-03 Thread Pierre Schweitzer
Dear all, On the 3rd of April 2015, the old.reactos.org website will be taken offline after several years of good services. If you have anything to do on it (like gathering data or whatever) please make sure you do before that date. With my best regards, -- Pierre Schweitzer System & Net

Re: [ros-dev] [ros-diffs] [pschweitzer] 66101: [CDMAKE] It's totally pointless to nullify after calloc

2015-01-28 Thread Pierre Schweitzer
free(parentcase); >> de = calloc(1, sizeof(*de)); >> -de->head = NULL; >> -de->child = NULL; >> de->parent = parent_de; >> de->normalized_name = strdup(targetnorm); >> de->case_name = strdup(chop_filename(casename)); >

Re: [ros-dev] [ros-diffs] [hbelusca] 66083: [CDMAKE] - Disable unused dir_hash_next_dir function and corresponding target_dir_traversal structure definition. - Be really sure de->head and de->child ar

2015-01-24 Thread Pierre Schweitzer
Jan 24 > 00:15:08 2015 > @@ -26,11 +26,13 @@ > struct target_dir_entry root; > }; > > +#if 0 > struct target_dir_traversal > { > struct target_dir_entry *it; > int i; > }; > +#endif See comment above. Cheers, -- Pierre S

[ros-dev] Security issue on ReactOS.org website

2015-01-21 Thread Pierre Schweitzer
Dear all, Just to make sure you read it: https://www.reactos.org/node/928 The SVN accounts are not affected. Cheers, -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signa

[ros-dev] Downtime tomorrow at noon CET

2015-01-13 Thread Pierre Schweitzer
ReactOS community website Sorry for the caused inconvenience. With my best regards, -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature ___ Ros

Re: [ros-dev] [ros-diffs] [hbelusca] 66022: [FREELDR]: Commit a temporary "hackfix" for (Pc)GetTime: on VBox when booting with PXE, for some mysterious reason, Int386(0x1A) call with AH = 0x02 (Get CM

2015-01-10 Thread Pierre Schweitzer
o.Minute = BCD_INT(HalpReadCmos(2)); > +TimeInfo.Hour = BCD_INT(HalpReadCmos(4)); > +TimeInfo.Day = BCD_INT(HalpReadCmos(7)); > +TimeInfo.Month = BCD_INT(HalpReadCmos(8)); > +TimeInfo.Year = BCD_INT(HalpReadCmos(9)); > + > + /* Compensate for the century field */

Re: [ros-dev] ReactOS Hybrid-USB Key attempt

2015-01-08 Thread Pierre Schweitzer
On 08/01/2015 03:22, Hermès BÉLUSCA - MAÏTO wrote: > - we still report strange dates when listing files from the livecd (at least > when it is mounted as ramdisk), see the video. From the video, it appears to only affect directories and not "normal" files. Likely some bug in C

Re: [ros-dev] [ros-diffs] [hbelusca] 65982: [FREELDR] - Correctly append a backslash to the BootPath (if needed). - Be able to specify relative boot paths (relative to the current boot device): as a c

2015-01-05 Thread Pierre Schweitzer
} Why? Can you please stop commenting out code without further explanations? Either you comment out (better doing so with #if 0, for the record) and you explain why you do so alongside in the code, for next developers coming into the code, or you don't comment out. So, just don't ans

[ros-dev] ReactOS at FOSDEM

2015-01-04 Thread Pierre Schweitzer
location when we have them. We're looking forward to seeing you at Brussels! Cheers, -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature __

Re: [ros-dev] [ros-diffs] [pschweitzer] 65501: [FASTFAT] Set clean shutdown bit on dismount

2014-11-27 Thread Pierre Schweitzer
>> >> >> > don't really seem to match. Or is the former a part of a OR combination > defining the latter ? > > Cheers. > Jérôme. > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailma

Re: [ros-dev] [ros-diffs] [pschweitzer] 65367: [PARTTEST] Add a dummy application that will open first disk and check first sector for MBR and then will open first partition to check for something kno

2014-11-10 Thread Pierre Schweitzer
___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Si

Re: [ros-dev] [ros-diffs] [pschweitzer] 65352: [NTOSKRNL] So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice

2014-11-10 Thread Pierre Schweitzer
Let me make a simple arrogant comment: Challenge accepted :P Best regards, Pierre Schweitzer On 10/11/2014 19:02, Alex Ionescu wrote: > Let me make a simple arrogant comment: > > Don't try to fix hacks that I spent years trying to fix (and failed). They > just can't

Re: [ros-dev] [ros-diffs] [pschweitzer] 65352: [NTOSKRNL] So... Because actual ReactOS mood is to worship hacks instead of looking for proper fixes to have decent behavior: reenable the IopParseDevice

2014-11-10 Thread Pierre Schweitzer
e() hack. Requested invalid >> attributes: %lx\n", >> +DesiredAccess & ~(SYNCHRONIZE | >> + FILE_READ_ATTRIBUTES | >> + READ_CONTROL | >> + ACCESS_SYSTEM_SECURITY | >> +

Re: [ros-dev] NTFS in ReactOS: heise online article

2014-11-08 Thread Pierre Schweitzer
o an USB drive, it wouldn't >> be writable, the CDFS driver we use is also read-only. > > >> Pierre Schweitzer > > My idea was to build and use the ROSBE on FreeBSD, NetBSD or Linux to build > the trunk, then install to a USB stick formatted FAT32. > >

Re: [ros-dev] NTFS in ReactOS: heise online article

2014-11-08 Thread Pierre Schweitzer
On 07/11/2014 19:52, Sven Barth wrote: > On 07.11.2014 13:19, Pierre Schweitzer wrote: >> On 07/11/2014 12:05, Thomas Mueller wrote: >>>> Dear Thomas, >>> >>>> This source of such article is a post from reboot.pro >>>> (http://reboo

Re: [ros-dev] NTFS in ReactOS: heise online article

2014-11-07 Thread Pierre Schweitzer
has initial, but not full (release process >> was started before everything could be developed) NTFS support. Testing >> from trunk is then the preferred method. > >> Cheers, > >> Pierre Schweitzer > > Thanks for the link! > > I can see why, in a deve

Re: [ros-dev] NTFS in ReactOS: heise online article

2014-11-05 Thread Pierre Schweitzer
progress. > > Some ReactOS developers must be familiar with this? > > Tom > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Netw

Re: [ros-dev] [ros-diffs] [tfaber] 65269: [FASTFAT] - VfatCleanupFile: do not dereference the FCB when closing the volume file object. ObDereferenceObject already causes an IRP_MJ_CLOSE request to be

2014-11-05 Thread Pierre Schweitzer
zeCacheMap(tmpFileObject, NULL, NULL); >> ObDereferenceObject(tmpFileObject); >> -vfatReleaseFCB(IrpContext->DeviceExt, pFcb); >> } >> >> CcPurgeCacheSection(FileObject->SectionObjectPointer, NULL, 0, >

Re: [ros-dev] [ros-diffs] [pschweitzer] 65166: [NTFS] Simplify buffer size management in GetNtfsFileRecord(). As tests shown, Windows doesn't care about the real size of the file record and expects th

2014-11-01 Thread Pierre Schweitzer
cord, > Stack->Parameters.FileSystemControl.OutputBufferLength) > in the memcpy size. Or am I missing something? > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > --

Re: [ros-dev] [ros-diffs] [jgardou] 65140: [FASTFAT] - Fix renaming files in case the target file already exists. - Plug a few reference count leaks on FCBs. CORE-8660 #comment fixed in r65140 #resolv

2014-10-31 Thread Pierre Schweitzer
file isn't open by anyone! */ > -if (TargetFcb->OpenHandleCount != 0) > -{ > -vfatReleaseFCB(DeviceExt, *ParentFCB); > - *ParentFCB = NULL; > -vfatReleaseFCB(DeviceExt, TargetFcb); > -retur

Re: [ros-dev] [ros-diffs] [akhaldi] 64994: [ADVAPI32] * Update ImpersonateNamedPipeClient(). CORE-8540

2014-10-25 Thread Pierre Schweitzer
> +BOOL WINAPI ImpersonateNamedPipeClient( HANDLE hNamedPipe ) >> +{ >> + IO_STATUS_BLOCK io_block; >> + >> +TRACE("(%p)\n", hNamedPipe); >> + >> +return set_ntstatus( NtFsControlFile(hNamedPipe, NULL, NULL, NULL, >> +

Re: [ros-dev] [ros-diffs] [pschweitzer] 64752: [NTFS] Implement NtfsDateTimeToFileTime() which convert epoch time (1970) to Windows time (1601)

2014-10-15 Thread Pierre Schweitzer
May 60056 (File times are 64-bit > numbers counting 100-nanosecond intervals (ten million per second) > since 1601, which is 58,000+ years)" > and your link doesn't seem to disagree. > > ___ > Ros-dev mailing list &

  1   2   3   4   >