Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Chris Hegarty
On 25/05/15 09:42, Erik Joelsson wrote: On 2015-05-22 18:53, Mandy Chung wrote: On 05/22/2015 08:09 AM, Alan Bateman wrote: On 22/05/2015 13:55, Chris Hegarty wrote: : I think it could be done either way. Valerie - have you considered not pushing the services configuration files with

Re: [8u] request for review: 8062552 Support keystore type detection for JKS and PKCS12 keystores

2015-05-25 Thread Vincent Ryan
Unfortunately we cannot modify a Java SE API in an update release so there is no opportunity to backport the keystore probe mechanism to JDK 8u. On 23 May 2015, at 22:57, Thomas Lußnig open...@suche.org wrote: On 23.05.2015 10:59, Vincent Ryan wrote: The aim of this enhancement is to

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Erik Joelsson
On 2015-05-22 18:53, Mandy Chung wrote: On 05/22/2015 08:09 AM, Alan Bateman wrote: On 22/05/2015 13:55, Chris Hegarty wrote: : I think it could be done either way. Valerie - have you considered not pushing the services configuration files with this change? With the change then the

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Alan Bateman
On 25/05/2015 09:53, Chris Hegarty wrote: If it is agreed that these files are needed, then I can look at expanding the ImageBuilder to do concatenate them. I agree with Mandy's point that java.security should be change to list the provider name rather than the class name. If that happens

Re: TLS ALPN Proposal

2015-05-25 Thread Michael McMahon
Hi Brad, A couple of initial comments/questions. 1) Certificate selection is one feature envisaged by ALPN. ie a client or a server ought to be able to choose a different certificate depending on the application name that gets negotiated. Is that possible with this API? 2) The

Re: TLS ALPN Proposal

2015-05-25 Thread Simone Bordet
Hi, On Mon, May 25, 2015 at 12:08 PM, Michael McMahon michael.x.mcma...@oracle.com wrote: Hi Brad, A couple of initial comments/questions. 1) Certificate selection is one feature envisaged by ALPN. ie a client or a server ought to be able to choose a different certificate depending on

Re: TLS ALPN Proposal

2015-05-25 Thread Michael McMahon
On 25/05/15 12:34, Simone Bordet wrote: Hi, On Mon, May 25, 2015 at 12:08 PM, Michael McMahon michael.x.mcma...@oracle.com wrote: Hi Brad, A couple of initial comments/questions. 1) Certificate selection is one feature envisaged by ALPN. ie a client or a server ought to be able to

RFR 8080911: sun/security/krb5/auto/UseCacheAndStoreKey.java timed out intermittently

2015-05-25 Thread Weijun Wang
Hi All Please review a code change at http://cr.openjdk.java.net/~weijun/8080911/webrev.00/ I've limit the synchronized block to Config creation only and therefore won't deadlock with EType's class initialization. Noreg-hard. The EType call is at class initialization and only run once in

RFR: 8048830 - Implement tests for new functionality provided in JEP 166

2015-05-25 Thread Bhanu Prakash Gopularam
Hello, Please review tests for JEP 166: Tests check for default key store format i.e., PKCS 12, import a trusted cert into PKCS 12 key store and export cert and print it. Tests validate whether exception is thrown when key entry with invalid cert chain is imported, Read and write key

[9] RFR: 8078823: javax/net/ssl/ciphersuites/DisabledAlgorithms.java fails intermittently

2015-05-25 Thread Artem Smotrakov
Hello, Please review this fix for javax/net/ssl/ciphersuites/DisabledAlgorithms.java test. It fails very rarely with SocketException. The test runs clients in main thread, but a server runs in a separate thread. In checkFailure() method, clients expect a SSLHandshakeException, and when it

Re: TLS ALPN Proposal

2015-05-25 Thread Simone Bordet
Hi, On Mon, May 25, 2015 at 3:57 PM, Michael McMahon michael.x.mcma...@oracle.com wrote: Perhaps, though it seems there are specific ALPNs for HTTP/1.1 (http/1.1) and for HTTP/2 (h2). So, I think you would use ALPN itself to do that negotiation. An incoming TLS connection without the ALPN

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

2015-05-25 Thread Mandy Chung
On May 25, 2015, at 3:00 AM, Alan Bateman alan.bate...@oracle.com wrote: On 25/05/2015 09:53, Chris Hegarty wrote: If it is agreed that these files are needed, then I can look at expanding the ImageBuilder to do concatenate them. I agree with Mandy's point that java.security should be

Run-time configurable sandboxes

2015-05-25 Thread org . openjdk
Hello! I am a security-conscious Java developer and am interested in using the JVMs built-in security features to run code in separated and run-time configured sandboxes. I'm writing to the list to explain some of the issues I've come up against and am hoping to either elicit suggestions or at

Re: TLS ALPN Proposal

2015-05-25 Thread Bradford Wetmore
On 5/22/2015 8:28 PM, Weijun Wang wrote: On 5/23/2015 9:13 AM, Bradford Wetmore wrote: Weijun wrote: But in the RFC the name is in uppercase and chars in string are all lowercases. ...deleted... - Compare with equalsIgnoreCase() Not following here, the spec is specific about the

Re: RFR 8080911: sun/security/krb5/auto/UseCacheAndStoreKey.java timed out intermittently

2015-05-25 Thread Xuelei Fan
synchronized on class looks a little bit unsafe to me. As singleton is a static variable, creating the instance during initialization looks safer. - private static Config singleton = null; + private static Config singleton = new Config(); Xuelei On 5/25/2015 10:16 PM, Weijun Wang wrote:

Re: RFR 8080911: sun/security/krb5/auto/UseCacheAndStoreKey.java timed out intermittently

2015-05-25 Thread Weijun Wang
On 5/26/2015 7:59 AM, Xuelei Fan wrote: synchronized on class looks a little bit unsafe to me. Why? Isn't it the same as making a static method synchronized? [1] As singleton is a static variable, creating the instance during initialization looks safer. - private static Config singleton =

Re: [9] RFR: 8078823: javax/net/ssl/ciphersuites/DisabledAlgorithms.java fails intermittently

2015-05-25 Thread Xuelei Fan
Looks fine to me. Thanks, Xuelei On 5/25/2015 11:58 PM, Artem Smotrakov wrote: Hello, Please review this fix for javax/net/ssl/ciphersuites/DisabledAlgorithms.java test. It fails very rarely with SocketException. The test runs clients in main thread, but a server runs in a separate

Re: RFR 8080911: sun/security/krb5/auto/UseCacheAndStoreKey.java timed out intermittently

2015-05-25 Thread Xuelei Fan
On 5/26/2015 9:06 AM, Weijun Wang wrote: On 5/26/2015 7:59 AM, Xuelei Fan wrote: synchronized on class looks a little bit unsafe to me. Why? Isn't it the same as making a static method synchronized? [1] Other code may be also able to lock on class. Code 1: lock on MyClass.class Code 2:

Re: TLS ALPN Proposal

2015-05-25 Thread Bradford Wetmore
Darn those Chicken/Eggs [1]! Yes, you are correct. The steps for the current server code: 1. The ClientHello is parsed, and the SNI matcher callback is called. It does not return which value was matched in the ServerHello, just whether a SNI name was matched or not: The extension_data

Re: RFR 8080911: sun/security/krb5/auto/UseCacheAndStoreKey.java timed out intermittently

2015-05-25 Thread Weijun Wang
On 5/26/2015 9:22 AM, Xuelei Fan wrote: On 5/26/2015 9:06 AM, Weijun Wang wrote: On 5/26/2015 7:59 AM, Xuelei Fan wrote: synchronized on class looks a little bit unsafe to me. Why? Isn't it the same as making a static method synchronized? [1] Other code may be also able to lock on class.

Re: RFR 8080911: sun/security/krb5/auto/UseCacheAndStoreKey.java timed out intermittently

2015-05-25 Thread Xuelei Fan
I do not like class level synchronization because it may not work as expected, especially if the synchronization can be used by other codes. However, your update does not change this behavior. The fix looks fine to me. Please go ahead if you don't want to use object level synchronization.

Re: RFR 8038089: TLS optional support for Kerberos cipher suites needs to be re-examine

2015-05-25 Thread Weijun Wang
This is the latest webrev of this bug http://cr.openjdk.java.net/~weijun/8038089/webrev.06/ No significant change from the previous one, mainly rebase. There are some issues which need changes inside JSSE. I'd like to file another bug for them. 1. JsseJce.java still uses core reflection