Re: [13] RFR JDK-8220349: The fix done for JDK-8214253 have caused issues in JTree behaviour

2019-03-08 Thread Philip Race
I am unable to test this since I don't have access to suitable systems, but it does look like it should be OK as it reverts the function's behaviour to what it was before 8214253 except for tooltips. -phil. On 3/8/19, 7:20 PM, Pankaj Bansal wrote: Hi All, Please review the following fix.

Re: [13] RFR JDK-8220250: fix headings in java.desktop

2019-03-08 Thread Jonathan Gibbons
Hi Prasanta, You mentioned the tool I was using to find the issues with headings... It's a bit of a hack -- it's an annotation processor that can be run by javac -- but while it is reasonably good at _detecting, it is not good at checking that you have fixed them _correctly_.  This is because

[13] RFR JDK-8220349: The fix done for JDK-8214253 have caused issues in JTree behaviour

2019-03-08 Thread Pankaj Bansal
Hi All, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8220349 webrev http://cr.openjdk.java.net/~pbansal/8220349/webrev00/ Issue: The fix done for JDK-8214253 have caused issues in JTree behaviour. If the JTree node is selected, its background

Re: [13] JDK-8216008: -Djavax.accessibility.assistive_technologies empty list leads to crash

2019-03-08 Thread Joe Darcy
Hello, I strongly recommend using     String.strip rather than     String.trim as Strim.trim uses a idosyncratic definition of whitespace whereas the new-in-11 String.strip uses a conventional definition of white space. Likewise, I recommend linking "white space" to the definition of white