Re: u-boot DT configuration node

2020-04-07 Thread Michal Simek
On 02. 04. 20 13:34, Mark Kettenis wrote: >> From: Michal Simek >> Date: Thu, 2 Apr 2020 08:05:36 +0200 >> >> On 01. 04. 20 20:09, Mark Kettenis wrote: From: Michal Simek Date: Wed, 1 Apr 2020 11:23:13 +0200 Hi Rob and others, for couple of years already u-boot is us

Re: zynq_z_turn_defconfig: broken networking

2020-04-07 Thread Michal Simek
On 07. 04. 20 22:12, Joe Hershberger wrote: > On Tue, Apr 7, 2020 at 1:34 PM Matwey V. Kornilov > wrote: >> >> вт, 7 апр. 2020 г. в 12:18, Michal Simek : >>> >>> On 07. 04. 20 11:16, Matwey V. Kornilov wrote: вт, 7 апр. 2020 г. в 12:01, Michal Simek : > > On 07. 04. 20 9:58, Matwey V.

Re: [PATCH v5 17/20] spl: nor: add lzma decompression support for legacy image

2020-04-07 Thread Stefan Roese
Hi, On 13.02.20 08:55, Simon Goldschmidt wrote: On Wed, Feb 12, 2020 at 10:46 AM Weijie Gao wrote: This patch adds support for decompressing LZMA compressed u-boot payload in legacy uImage format. Using this patch together with u-boot-lzma.img is useful for NOR flashes as they can reduce the

RE: [PATCH v6 10/17] riscv: dts: sifive: Sync hifive-unleashed-a00 dts from linux

2020-04-07 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: Jagan Teki >Sent: 07 April 2020 01:07 >To: Pragnesh Patel >Cc: U-Boot-Denx ; Atish Patra >; palmerdabb...@google.com; Bin Meng >; Paul Walmsley ; Troy >Benjegerdes ; Anup Patel >; Sagar Kadam ; Rick Chen > >Subject: Re: [PATCH v6 10/17] riscv: dts: si

Re: [PATCH V2] mmc: zynq: parse dt when probing

2020-04-07 Thread Michal Simek
On 07. 04. 20 16:15, Benedikt Grassl wrote: > Currently, the entry "bus-width = <8>" in the ZynqMP's sdhci nodes > is not evaluated. This results in the bus width staying at its default > value (4 bit in HS200 mode). > Fix this by calling mmc_of_parse. This function also checks for the > "no-1-8-v"

Re: [PATCH] mmc: zynq: parse dt when probing

2020-04-07 Thread Michal Simek
On 08. 04. 20 0:38, Jaehoon Chung wrote: > On 4/6/20 11:35 PM, Benedikt Grassl wrote: >> Currently, the entry "bus-width = <8>" in the ZynqMP's sdhci nodes >> is not evaluated. This results in the bus width staying at its default >> value (4 bit in HS200 mode). >> Fix this by parsing the device tre

Re: [PATCH v2 1/3] arm: dts: arria10: Move uboot specific properties to u-boot.dtsi

2020-04-07 Thread Simon Goldschmidt
On Tue, Apr 7, 2020 at 9:43 AM Ley Foon Tan wrote: > > Move Uboot specific properties to *u-boot.dtsi files. > Preparation to sync Arria 10 device tree from Linux. > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > --- > arch/arm/dts/socfpga_arria10-u-boot.dtsi | 123 ++

Re: [PATCH v2 2/3] arm: dts: arria10: Update dtsi/dts from Linux

2020-04-07 Thread Simon Goldschmidt
On Tue, Apr 7, 2020 at 9:43 AM Ley Foon Tan wrote: > > Update these 3 files from Linux:. > - socfpga_arria10.dtsi (Commit ID c1459a9d7e92) > - socfpga_arria10_socdk.dtsi (Commit ID d9b9f805ee2b) > - socfpga_arria10_socdk_sdmmc.dts (Commit ID 17808d445b6f) > > Change in socfpga_arria10.dtsi: > - Ad

Re: [PATCH v2 3/3] arm: socfpga: arria10: Enable cache driver in SPL

2020-04-07 Thread Simon Goldschmidt
On Tue, Apr 7, 2020 at 9:43 AM Ley Foon Tan wrote: > > Adding "u-boot,dm-pre-reloc" and enable CONFIG_SPL_CACHE > to enable cache driver in SPL. > > This fixed error below in SPL: > cache controller driver NOT found! > > Signed-off-by: Ley Foon Tan Reviewed-by: Simon Goldschmidt > > --- > v2:

Re: [PATCH v3 1/1] drivers: usb: host: Add BRCM xHCI driver

2020-04-07 Thread Rayagonda Kokatanur
On Wed, Apr 8, 2020 at 9:56 AM Marek Vasut wrote: > > On 4/8/20 5:35 AM, Rayagonda Kokatanur wrote: > [...] > > +struct brcm_xhci_platdata { > > + unsigned int arcache; > > + unsigned int awcache; > > + uintptr_t hc_base; > > This could be struct xhci_hccr * instead , and then you can

[PATCH v3 1/1] drivers: i2c: add brcm iproc I2C driver support

2020-04-07 Thread Rayagonda Kokatanur
Add I2C driver support for Broadcom iproc-based socs. Signed-off-by: Arjun Jyothi Signed-off-by: Rayagonda Kokatanur Signed-off-by: Sheetal Tigadoli Signed-off-by: Vladimir Olovyannikov Reviewed-by: Heiko Schocher --- Changes from v2: -Address all review comments from Heiko Schocher, Use C

RE: [PATCH v6 07/17] sifive: dts: fu540: Add DDR controller and phy register settings

2020-04-07 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: Jagan Teki >Sent: 07 April 2020 01:00 >To: Pragnesh Patel >Cc: U-Boot-Denx ; Atish Patra >; palmerdabb...@google.com; Bin Meng >; Paul Walmsley ; Troy >Benjegerdes ; Anup Patel >; Sagar Kadam ; Rick Chen > >Subject: Re: [PATCH v6 07/17] sifive: dts: f

RE: [PATCH v6 16/17] sifive: fix palmer's email address

2020-04-07 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: Jagan Teki >Sent: 07 April 2020 01:13 >To: Pragnesh Patel >Cc: U-Boot-Denx ; Atish Patra >; palmerdabb...@google.com; Bin Meng >; Paul Walmsley ; Troy >Benjegerdes ; Anup Patel >; Sagar Kadam ; Rick Chen >; Palmer Dabbelt >Subject: Re: [PATCH v6 16/1

RE: [PATCH v6 02/17] riscv: sifive: fu540: Use OTP DM driver for serial environment variable

2020-04-07 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: Jagan Teki >Sent: 07 April 2020 14:51 >To: Pragnesh Patel >Cc: U-Boot-Denx ; Atish Patra >; palmerdabb...@google.com; Bin Meng >; Paul Walmsley ; Troy >Benjegerdes ; Anup Patel >; Sagar Kadam ; Rick Chen >; Palmer Dabbelt >Subject: Re: [PATCH v6 02/1

RE: [PATCH v6 00/17] RISC-V SiFive FU540 support SPL

2020-04-07 Thread Pragnesh Patel
Hi Jagan, >-Original Message- >From: Jagan Teki >Sent: 07 April 2020 15:02 >To: Pragnesh Patel >Cc: U-Boot-Denx ; Atish Patra >; palmerdabb...@google.com; Bin Meng >; Paul Walmsley ; Troy >Benjegerdes ; Anup Patel >; Sagar Kadam ; Rick Chen > >Subject: Re: [PATCH v6 00/17] RISC-V SiFive

Re: [PATCH v2 1/1] drivers: i2c: add brcm iproc I2C driver support

2020-04-07 Thread Rayagonda Kokatanur
On Wed, Apr 8, 2020 at 9:30 AM Heiko Schocher wrote: > > Hello Rayagonda Kokatanur, > > Am 26.03.2020 um 11:51 schrieb Rayagonda Kokatanur: > > Add I2C driver support for Broadcom iproc-based socs. > > > > Signed-off-by: Arjun Jyothi > > Signed-off-by: Rayagonda Kokatanur > > Signed-off-by: Shee

Re: [PATCH v4 02/31] lib: Add a function to convert a string to upper case

2020-04-07 Thread Heinrich Schuchardt
Am April 8, 2020 4:18:12 AM UTC schrieb Heinrich Schuchardt : >Am April 8, 2020 3:00:38 AM UTC schrieb Simon Glass : >>Add a helper function for this operation. Update the strtoul() tests >to >>check upper case as well. >> >>Update FAT writing to use this new function. >> >>Signed-off-by: Simon Gl

Re: [PATCH v3 1/1] drivers: usb: host: Add BRCM xHCI driver

2020-04-07 Thread Marek Vasut
On 4/8/20 5:35 AM, Rayagonda Kokatanur wrote: [...] > +struct brcm_xhci_platdata { > + unsigned int arcache; > + unsigned int awcache; > + uintptr_t hc_base; This could be struct xhci_hccr * instead , and then you can remove the cast ... > +}; > + > +static int xhci_brcm_probe(struct

Re: [PATCH v4 02/31] lib: Add a function to convert a string to upper case

2020-04-07 Thread Heinrich Schuchardt
Am April 8, 2020 3:00:38 AM UTC schrieb Simon Glass : >Add a helper function for this operation. Update the strtoul() tests to >check upper case as well. > >Update FAT writing to use this new function. > >Signed-off-by: Simon Glass >--- > >Changes in v4: >- Add a new patch to convert a string to u

Re: [PATCH] cmd: eeprom: Staticize eeprom_i2c_bus

2020-04-07 Thread Heiko Schocher
Hello Marek, Am 07.04.2020 um 13:29 schrieb Marek Vasut: The eeprom_i2c_bus is not used outside of this file, make it static. Signed-off-by: Marek Vasut Cc: Heiko Schocher Cc: Tom Rini --- cmd/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Heiko Schocher G

Re: [RFC PATCH v2 04/13] i2c: add nexell driver

2020-04-07 Thread Heiko Schocher
Hello Stefan, Am 28.03.2020 um 10:43 schrieb Stefan Bosch: Changes in relation to FriendlyARM's U-Boot nanopi2-v2016.01: - i2c/nx_i2c.c: Some adaptions mainly because of changes in "struct udevice". - several Bugfixes in nx_i2c.c. - the driver has been for s5p6818 only. Code extended appropri

Re: [PATCH v4 4/8] board: presidio-asic: Add I2C support

2020-04-07 Thread Heiko Schocher
Hello Alex, Am 31.03.2020 um 01:51 schrieb Alex Nemirovsky: Add I2C board support for Cortina Access Presidio Engineering Board Signed-off-by: Alex Nemirovsky CC: Heiko Schocher --- Changes in v4: None Changes in v3: None Changes in v2: None configs/cortina_presidio-asic-emmc_defconfig |

Re: [PATCH v4 3/8] i2c: i2c-cortina: added CAxxxx I2C support

2020-04-07 Thread Heiko Schocher
Hello Alex, Am 31.03.2020 um 01:51 schrieb Alex Nemirovsky: From: Arthur Li Add I2C controller support for Cortina Access CA SoCs Signed-off-by: Arthur Li Signed-off-by: Alex Nemirovsky CC: Heiko Schocher --- Changes in v4: - Utilize standard I2C macros from - Return ETIMEDOUT in fu

Re: [PATCH v2 1/1] drivers: i2c: add brcm iproc I2C driver support

2020-04-07 Thread Heiko Schocher
Hello Rayagonda Kokatanur, Am 26.03.2020 um 11:51 schrieb Rayagonda Kokatanur: Add I2C driver support for Broadcom iproc-based socs. Signed-off-by: Arjun Jyothi Signed-off-by: Rayagonda Kokatanur Signed-off-by: Sheetal Tigadoli Signed-off-by: Vladimir Olovyannikov --- Changes from v1: -Ad

Re: [PATCH] i2c: muxes: pca954x: add PCA9546 variant

2020-04-07 Thread Heiko Schocher
Hello Chris, Am 01.04.2020 um 04:55 schrieb Chris Packham: This adds the PCA9546 4-channel i2c bus switch. Signed-off-by: Chris Packham --- U-boot already supports the PCA9646 which is a pin-compatible (and mostly register compatible) replacement. I still think it's worth making the distinctio

Re: [PATCH v2 1/1] drivers: usb: host: Add BRCM xHCI driver

2020-04-07 Thread Rayagonda Kokatanur
On Tue, Apr 7, 2020 at 2:39 PM Marek Vasut wrote: > > On 4/7/20 8:29 AM, Rayagonda Kokatanur wrote: > [...] > > +static int xhci_brcm_probe(struct udevice *dev) > > +{ > > + struct xhci_hccr *hcd; > > + struct xhci_hcor *hcor; > > + struct brcm_xhci_platdata *plat = dev_get_platdata(de

[PATCH v3 1/1] drivers: usb: host: Add BRCM xHCI driver

2020-04-07 Thread Rayagonda Kokatanur
Base driver for Broadcom xHCI controllers Signed-off-by: Bharat Kumar Reddy Gooty Signed-off-by: Rayagonda Kokatanur Signed-off-by: Vladimir Olovyannikov --- Changes from v2: -Address review comments from Marek Vasut, Cache hc_base in private data instead of always reading it from DT, Foll

Re: [RFC 1/7] mmc: fsl_esdhc_imx: add OF_PLATDATA support

2020-04-07 Thread Simon Glass
Hi Walter, On Tue, 7 Apr 2020 at 14:05, Walter Lozano wrote: > > Hi Simon, > > Thank you for taking the time to review this series. > > On 6/4/20 00:42, Simon Glass wrote: > > Hi Walter, > > > > On Sun, 29 Mar 2020 at 21:32, Walter Lozano > > wrote: > >> Signed-off-by: Walter Lozano > >> --- >

Re: [RFC] dm: uclass: add functions to get device by platdata

2020-04-07 Thread Simon Glass
Hi Walter, On Tue, 7 Apr 2020 at 14:05, Walter Lozano wrote: > > Hi Simon, > > On 6/4/20 00:43, Simon Glass wrote: > > Hi Walter, > > > > On Mon, 9 Mar 2020 at 12:27, Walter Lozano > > wrote: > >> Hi Simon > >> > >> On 6/3/20 17:32, Simon Glass wrote: > >>> Hi Walter, > >>> > >>> On Fri, 6 Mar

[PATCH v4 31/31] acpi: Add an acpi command

2020-04-07 Thread Simon Glass
It is useful to dump ACPI tables in U-Boot to see what has been generated. Add a command to handle this. To allow the command to find the tables, add a position into the global data. Support subcommands to list and dump the tables. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner ---

[PATCH v4 29/31] acpi: Put table-setup code in its own function

2020-04-07 Thread Simon Glass
We always write three basic tables to ACPI at the start. Move this into its own function, along with acpi_fill_header(), so we can write a test for this code. Signed-off-by: Simon Glass --- Changes in v4: - Put back cast on table_compute_checksum() Changes in v3: - Fix 'XDST' typo - Move acpi_a

[PATCH v4 30/31] acpi: Move the xsdt pointer to acpi_ctx

2020-04-07 Thread Simon Glass
Put this in the context along with the other important pointers. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: None Changes in v2: None include/dm/acpi.h | 2 ++ lib/acpi/acpi_table.c | 10 -- test/dm/acpi.c| 5 + 3 f

[PATCH v4 27/31] acpi: Drop code for missing XSDT from acpi_write_rsdp()

2020-04-07 Thread Simon Glass
We don't actually support tables without an XSDT so we can drop this dead code. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: None Changes in v2: None arch/x86/lib/acpi_table.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletion

[PATCH v4 28/31] acpi: Move acpi_add_table() to generic code

2020-04-07 Thread Simon Glass
Move this code to a generic location so that we can test it with sandbox. This requires adding a few new fields to acpi_ctx, so drop the local variables used in the original code. Also use mapmem to avoid pointer-to-address casts which don't work on sandbox. Signed-off-by: Simon Glass Reviewed-b

[PATCH v4 26/31] x86: Allow devices to write ACPI tables

2020-04-07 Thread Simon Glass
Call the new core function to permit devices to write their own ACPI tables. These tables will appear after all other tables. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: None Changes in v2: None arch/x86/lib/acpi_table.c | 2 ++ 1 file chang

[PATCH v4 21/31] acpi: Add a central location for table version numbers

2020-04-07 Thread Simon Glass
Each ACPI table has its own version number. Add the version numbers in a single function so we can keep them consistent and easily see what versions are supported. Start a new acpi_table file in a generic directory to house this function. We can move things over to this file from x86 as needed. S

[PATCH v4 22/31] acpi: Add support for DMAR

2020-04-07 Thread Simon Glass
The DMA Remapping Reporting (DMAR) table contains information about DMA remapping. Add a version simple version of this table with only the minimum fields filled out. i.e. no entries. Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner Signed-off-by: Simon Glass --- Changes in v4: None Change

[PATCH v4 23/31] test: Add hexdump.h to the unit test header

2020-04-07 Thread Simon Glass
Since ut_asserteq_mem() uses bin2hex() we should include this header in ut.h to avoid errors. Add it. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: - Add new patch to add hexdump.h to the unit test header Changes in v2: None include/test/ut.h

[PATCH v4 24/31] acpi: Add a method to write tables for a device

2020-04-07 Thread Simon Glass
A device may want to write out ACPI tables to describe itself to Linux. Add a method to permit this. Reviewed-by: Wolfgang Wallner Signed-off-by: Simon Glass --- Changes in v4: - Separate out the log newline Changes in v3: None Changes in v2: - Drop definition of ACPI_TABLE_CREATOR - Make _acp

[PATCH v4 25/31] acpi: Convert part of acpi_table to use acpi_ctx

2020-04-07 Thread Simon Glass
The current code uses an address but a pointer would result in fewer casts. Also it repeats the alignment code in a lot of places so this would be better done in a helper function. Update write_acpi_tables() to make use of the new acpi_ctx structure, adding a few helpers to clean things up. Signe

[PATCH v4 18/31] x86: Move acpi_s3.h to include/acpi/

2020-04-07 Thread Simon Glass
This header relates to ACPI and we are about to add some more ACPI headers. Move this one into a new directory so they are together. Signed-off-by: Simon Glass Reviewed-by: Andy Shevchenko --- Changes in v4: None Changes in v3: - Add new patch to move acpi_s3.h to include/acpi/ Changes in v2:

[PATCH v4 16/31] acpi: Add a binding for ACPI settings in the device tree

2020-04-07 Thread Simon Glass
Devices need to report various identifiers in the ACPI tables. Rather than hard-coding these in drivers it is typically better to put them in the device tree. Add a binding file to describe this. Signed-off-by: Simon Glass --- Changes in v4: - Put 'interrupts-extended' property on one line - Re

[PATCH v4 17/31] acpi: Add a simple sandbox test

2020-04-07 Thread Simon Glass
Add a sandbox test for the basic ACPI functionality we have so far. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: None Changes in v2: - Add in the acpi_table.h header file to this patch arch/sandbox/dts/test.dts

[PATCH v4 19/31] x86: Move acpi_table header to main include/ directory

2020-04-07 Thread Simon Glass
This file is potentially useful to other architectures saddled with ACPI so move most of its contents to a common location. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: - Update commit message to say that we move most of

[PATCH v4 20/31] acpi: Add an __ACPI__ preprocessor symbol

2020-04-07 Thread Simon Glass
The ASL compiler cannot handle C structures and the like so needs some sort of header guard around these. We already have an __ASSEMBLY__ #define but it seems best to create a new one for ACPI since the rules may be different. Add the check to a few files that ACPI always includes. Signed-off-by

[PATCH v4 14/31] dm: core: Add basic ACPI support

2020-04-07 Thread Simon Glass
ACPI (Advanced Configuration and Power Interface) is a standard for specifying information about a platform. It is a little like device tree but the bindings are part of the specification and it supports an interpreted bytecode language. Driver model does not use ACPI for U-Boot's configuration, b

[PATCH v4 15/31] dts: Add a binding for hid-over-i2c

2020-04-07 Thread Simon Glass
Add this binding from Linux v5.4. Signed-off-by: Simon Glass --- Changes in v4: None Changes in v3: - Split out hid-over-i2c into its own patch Changes in v2: None .../input/hid-over-i2c.txt| 44 +++ 1 file changed, 44 insertions(+) create mode 100644 doc/

[PATCH v4 13/31] x86: apl: Add Global NVS table header

2020-04-07 Thread Simon Glass
Add the C version of this header. It includes a few Chrome OS bits which are disabled for a normal build. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner --- Changes in v4: - Fix indentation of unused - Calculate the padding Changes in v3: - Fix stray #endif Changes in v2: - Drop the

[PATCH v4 12/31] pci: Adjust dm_pci_read_bar32() to return errors correctly

2020-04-07 Thread Simon Glass
At present if reading a BAR returns 0x (e.g. the device is not present) then the value is masked and a different value is returned. This makes it harder to detect the problem when debugging. Update the function to avoid masking in this case. Signed-off-by: Simon Glass Reviewed-by: Bin Me

[PATCH v4 11/31] x86: apl: Move p2sb ofdata reading to the correct method

2020-04-07 Thread Simon Glass
With P2SB the initial BAR (base-address register) is set up by TPL and this is used unchanged right through U-Boot. At present the reading of this address is split between the ofdata() and probe() methods. There are a few problems that are unique to the p2sb. One is that its children need to call

[PATCH v4 09/31] dm: pci: Allow disabling auto-config for a device

2020-04-07 Thread Simon Glass
Add a means to avoid configuring a device when needed. Add an explanation of why this is useful to the binding file. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v4: None Changes in v3: Drop acpi,name in example Changes in v2: None doc/device-tree-bindings/pci/x86-pci.txt

[PATCH v4 10/31] x86: Correct wording of coreboot source code

2020-04-07 Thread Simon Glass
Some files are taken or modified from coreboot, but the files are no-longer part of the coreboot project. Fix the wording in a few places. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: None Changes in v2: None arch/x86/c

[PATCH v4 07/31] tpm: cr50: Use the correct GPIO binding

2020-04-07 Thread Simon Glass
This device should use ready-gpios rather than ready-gpio. Fix it. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v4: None Changes in v3: None Changes in v2: None arch/x86/dts/chromebook_coral.dts | 2 +- doc/device-tree-bindings/gpio/intel,apl-g

[PATCH v4 08/31] tpm: Don't cleanup unless an error happens

2020-04-07 Thread Simon Glass
At present the cleanup() method is called on every transfer. It should only be called on failing transfers. Fix this and tidy up the error handling a little. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/tpm/tpm-uclass

[PATCH v4 05/31] tpm: cr50: Release locality on exit

2020-04-07 Thread Simon Glass
At present the cr50 driver claims the locality and does not release it for Linux. This causes problems. Fix this by tracking what is claimed, and adding a 'remove' method. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/

[PATCH v4 06/31] tpm: cr50: Add a comment for cr50_priv

2020-04-07 Thread Simon Glass
Add a comment for the private structure Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v4: None Changes in v3: None Changes in v2: - Drop the other comment change since it is already applied drivers/tpm/cr50_i2c.c | 9 + 1 file changed, 9 insertions(+) diff --git a/d

[PATCH v4 03/31] cpu: Support querying the address width

2020-04-07 Thread Simon Glass
Different CPUs may support different address widths, meaning the amount of memory they can address. Add a property for this to the cpu_info struct. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/cpu/cpu_sandbox.c | 1 +

[PATCH v4 04/31] spi: Add SPI mode enums

2020-04-07 Thread Simon Glass
With ACPI we need to describe the settings of the SPI bus. Add enums to handle this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng Reviewed-by: Wolfgang Wallner --- Changes in v4: None Changes in v3: None Changes in v2: - Don't bracket the definitions with DM_SPI - Add trailing commas to en

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-04-07 Thread Simon Glass
Hi Andy, On Sun, 29 Mar 2020 at 15:00, Andy Shevchenko wrote: > > On Sun, Mar 29, 2020 at 5:13 AM Simon Glass wrote: > > On Thu, 5 Mar 2020 at 05:17, Andy Shevchenko > > wrote: > > > On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > > > > On Tue, 3 Mar 2020 at 02:23, Andy Shevchen

[PATCH v4 01/31] test: Add the beginnings of some string tests

2020-04-07 Thread Simon Glass
There are quite a few string functions in U-Boot with no tests. Make a start by adding a test for strtoul(). Signed-off-by: Simon Glass --- Changes in v4: - Add a new patch with some string tests Changes in v3: None Changes in v2: None include/test/suites.h | 1 + test/Makefile | 1

[PATCH v4 02/31] lib: Add a function to convert a string to upper case

2020-04-07 Thread Simon Glass
Add a helper function for this operation. Update the strtoul() tests to check upper case as well. Update FAT writing to use this new function. Signed-off-by: Simon Glass --- Changes in v4: - Add a new patch to convert a string to upper case Changes in v3: None Changes in v2: None fs/fat/fat_

Re: [PATCH v2] dm: core: remove the duplicated function dm_ofnode_pre_reloc

2020-04-07 Thread Simon Glass
On Fri, 3 Apr 2020 at 03:39, Patrick Delaunay wrote: > > The content dm_ofnode_pre_reloc() is identical with ofnode_pre_reloc() > defined in drivers/core/ofnode.c and used only three times: > - drivers/core/lists.c:lists_bind_fdt() > - drivers/clk/at91/pmc.c::at91_clk_sub_device_bind > - drivers/c

Re: [PATCH v3 13/29] dts: Add a binding for hid-over-i2c

2020-04-07 Thread Simon Glass
Hi Wolfgang, On Tue, 31 Mar 2020 at 13:25, Wolfgang Wallner wrote: > > Hi Simon, > > -"Simon Glass" schrieb: - > > >An: u-boot@lists.denx.de > >Von: "Simon Glass" > >Datum: 31.03.2020 01:14 > >Kopie: "Andy Shevchenko" , > >"Wolfgang Wallner" , "Leif > >Lindholm" , "Simon Glass" > >Betr

Re: [PATCH v3 19/29] acpi: Add a central location for table version numbers

2020-04-07 Thread Simon Glass
Hi Wolfgang, On Tue, 31 Mar 2020 at 13:30, Wolfgang Wallner wrote: > > > Hi Simon, > > -"Simon Glass" schrieb: - > > >Betreff: [PATCH v3 19/29] acpi: Add a central location for table > >version numbers > > > >Each ACPI table has its own version number. Add the version numbers > >in a > >

Re: [PATCH v3 27/29] acpi: Put table-setup code in its own function

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 07:32, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:13:03PM -0600, Simon Glass wrote: > > We always write three basic tables to ACPI at the start. Move this into > > its own function, along with acpi_fill_header(), so we can write a test > > for this code.

Re: [PATCH v3 22/29] acpi: Add a method to write tables for a device

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 07:20, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:58PM -0600, Simon Glass wrote: > > A device may want to write out ACPI tables to describe itself to Linux. > > Add a method to permit this. > > > +acpi_method acpi_get_method(struct udevice *dev, enum m

Re: [PATCH v3 19/29] acpi: Add a central location for table version numbers

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 07:04, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:55PM -0600, Simon Glass wrote: > > Each ACPI table has its own version number. Add the version numbers in a > > single function so we can keep them consistent and easily see what > > versions are suppor

Re: [RFC PATCH v3] arch: x86: apl: Read FSP-M configuration from device-tree

2020-04-07 Thread Simon Glass
On Mon, 30 Mar 2020 at 07:01, Bernhard Messerklinger wrote: > > Move FSP-M configuration to the device-tree like it's already done for > other SoCs (Baytrail). > > Signed-off-by: Bernhard Messerklinger > > --- > With this patch I moved the FSP-M configuration to the device-tree based > on the Ba

Re: [PATCH v3 23/29] acpi: Convert part of acpi_table to use acpi_ctx

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 07:24, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:59PM -0600, Simon Glass wrote: > > The current code uses an address but a pointer would result in fewer > > casts. Also it repeats the alignment code in a lot of places so this would > > be better done

Re: [PATCH v3 13/29] dts: Add a binding for hid-over-i2c

2020-04-07 Thread Simon Glass
Hi Wolfgang, On Wed, 1 Apr 2020 at 01:39, Wolfgang Wallner wrote: > > Hi Simon, > > -"U-Boot" schrieb: - > > [snip] > > >> + - acpi,ddn : Contains the string to use as the _DDN (DOS (Disk > >Operating > >> +System) Device Name) > >> + - acpi,hid : Contains the string to use as the HI

Re: [PATCH v3 12/29] dm: core: Add basic ACPI support

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 05:35, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:48PM -0600, Simon Glass wrote: > > ACPI (Advanced Configuration and Power Interface) is a standard for > > specifying information about a platform. It is a little like device > > tree but the bindings a

Re: [PATCH v2 2/2] test: fdtdec: test fdtdec_set_carveout()

2020-04-07 Thread Simon Glass
On Fri, 3 Apr 2020 at 04:43, Laurentiu Tudor wrote: > > Add a new test for fdtdec_set_carveout(). > > Signed-off-by: Laurentiu Tudor > --- > test/dm/Makefile | 1 + > test/dm/fdtdec.c | 60 > 2 files changed, 61 insertions(+) > create mode 10064

Re: [PATCH v3 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 05:22, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:46PM -0600, Simon Glass wrote: > > At present if reading a BAR returns 0x (e.g. the device is not > > present) then the value is masked and a different value is returned. > > This makes it harde

Re: [PATCH v3 17/29] x86: Move acpi_table header to main include/ directory

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 06:58, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:53PM -0600, Simon Glass wrote: > > This file is potentially useful to other architectures saddled with ACPI > > so move most of its contents to a common location. > > It's not just potentially, it's def

Re: [PATCH v3 16/29] x86: Move acpi_s3.h to include/acpi/

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 06:53, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:52PM -0600, Simon Glass wrote: > > This header relates to ACPI and we are about to add some more ACPI > > headers. Move this one into a new directory so they are together. > > > > FWIW, > Reviewed-by: A

Re: [PATCH v2 1/2] fdtdec: support multiple phandles in memory carveout

2020-04-07 Thread Simon Glass
On Fri, 3 Apr 2020 at 04:43, Laurentiu Tudor wrote: > > fdtdec_set_carveout() is limited to only one phandle. Fix this > limitation by adding support for multiple phandles. > > Signed-off-by: Laurentiu Tudor > --- > lib/fdtdec.c | 36 ++-- > 1 file changed, 26 ins

Re: [PATCH v3 15/29] acpi: Add a simple sandbox test

2020-04-07 Thread Simon Glass
Hi Andy, On Fri, 3 Apr 2020 at 06:51, Andy Shevchenko wrote: > > On Mon, Mar 30, 2020 at 05:12:51PM -0600, Simon Glass wrote: > > Add a sandbox test for the basic ACPI functionality we have so far. > > > +U_BOOT_DRIVER(testacpi_drv) = { > > + .name = "testacpi_drv", > > + .of_match

RE: i.MX8QXP hangs in SPL after a "reboot" command

2020-04-07 Thread Peng Fan
> Subject: Re: i.MX8QXP hangs in SPL after a "reboot" command > > Hi Peng, > > On Tue, Apr 7, 2020 at 9:47 PM Peng Fan wrote: > > > > > Subject: Re: i.MX8QXP hangs in SPL after a "reboot" command > > > > > > On Thu, Apr 2, 2020 at 4:21 PM Fabio Estevam > > > wrote: > > > > > > > U-Boot SPL 2020

Re: i.MX8QXP hangs in SPL after a "reboot" command

2020-04-07 Thread Fabio Estevam
Hi Peng, On Tue, Apr 7, 2020 at 9:47 PM Peng Fan wrote: > > > Subject: Re: i.MX8QXP hangs in SPL after a "reboot" command > > > > On Thu, Apr 2, 2020 at 4:21 PM Fabio Estevam > > wrote: > > > > > U-Boot SPL 2020.04-rc4-00061-ge0718b3ab7 (Apr 02 2020 - 16:14:22 > > > -0300) Normal Boot > > > WDT:

RE: i.MX8QXP hangs in SPL after a "reboot" command

2020-04-07 Thread Peng Fan
> Subject: Re: i.MX8QXP hangs in SPL after a "reboot" command > > On Thu, Apr 2, 2020 at 4:21 PM Fabio Estevam > wrote: > > > U-Boot SPL 2020.04-rc4-00061-ge0718b3ab7 (Apr 02 2020 - 16:14:22 > > -0300) Normal Boot > > WDT: Not found! > > Trying to boot from MMC2_2 > > spl: mmc init failed with

Re: [PATCH] Revert "common: spl_fit: Default to IH_OS_U_BOOT if FIT_IMAGE_TINY enabled"

2020-04-07 Thread Matt Porter
On Tue, Mar 31, 2020 at 01:59:20AM -0700, Ye Li wrote: > The patch in commit cf8dcc5d02c32173b74bf1b7600dd2b990a90b13 is not correct, > it will append fdt to each loadable image. > Actually when using TINY FIT, the first loadable image is thought as u-boot > and already have fdt appended. > > Sign

Re: [PATCH] mmc: zynq: parse dt when probing

2020-04-07 Thread Jaehoon Chung
On 4/6/20 11:35 PM, Benedikt Grassl wrote: > Currently, the entry "bus-width = <8>" in the ZynqMP's sdhci nodes > is not evaluated. This results in the bus width staying at its default > value (4 bit in HS200 mode). > Fix this by parsing the device tree while probing. > > Signed-off-by: Benedikt G

Re: zynq_z_turn_defconfig: broken networking

2020-04-07 Thread Joe Hershberger
On Tue, Apr 7, 2020 at 1:34 PM Matwey V. Kornilov wrote: > > вт, 7 апр. 2020 г. в 12:18, Michal Simek : > > > > On 07. 04. 20 11:16, Matwey V. Kornilov wrote: > > > вт, 7 апр. 2020 г. в 12:01, Michal Simek : > > >> > > >> On 07. 04. 20 9:58, Matwey V. Kornilov wrote: > > >>> пн, 6 апр. 2020 г. в 1

Re: [RFC 2/7] mmc: fsl_esdhc_imx: add ofdata_to_platdata support

2020-04-07 Thread Walter Lozano
Hi Simon, On 6/4/20 00:42, Simon Glass wrote: Hi Walter On Sun, 29 Mar 2020 at 21:32, Walter Lozano wrote: All of these commits need a commit message please. Thank you for pointing it. Signed-off-by: Walter Lozano --- drivers/mmc/fsl_esdhc_imx.c | 71 ++---

Re: [RFC 7/7] mx6cuboxi: enable OF_PLATDATA

2020-04-07 Thread Walter Lozano
Hi Simon, On 6/4/20 00:43, Simon Glass wrote: On Sun, 29 Mar 2020 at 21:32, Walter Lozano wrote: Signed-off-by: Walter Lozano --- configs/mx6cuboxi_defconfig | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: SImon Glass (with commit msg) Thank you.

Re: [RFC 5/7] gpio: mxc_gpio: add OF_PLATDATA support

2020-04-07 Thread Walter Lozano
Hi Simon, On 6/4/20 00:42, Simon Glass wrote: Hi Walter, On Sun, 29 Mar 2020 at 21:32, Walter Lozano wrote: Signed-off-by: Walter Lozano --- drivers/gpio/mxc_gpio.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/mxc_gpio.c b/dri

Re: [RFC 3/7] dtoc: update dtb_platdata to support cd-gpio

2020-04-07 Thread Walter Lozano
Hi Simon, On 6/4/20 00:42, Simon Glass wrote: On Sun, 29 Mar 2020 at 21:32, Walter Lozano wrote: Signed-off-by: Walter Lozano --- tools/dtoc/dtb_platdata.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) This looks OK, but please add a test. Noted. Thank you. diff --g

Re: [RFC] dm: uclass: add functions to get device by platdata

2020-04-07 Thread Walter Lozano
Hi Simon, On 6/4/20 00:43, Simon Glass wrote: Hi Walter, On Mon, 9 Mar 2020 at 12:27, Walter Lozano wrote: Hi Simon On 6/3/20 17:32, Simon Glass wrote: Hi Walter, On Fri, 6 Mar 2020 at 09:10, Walter Lozano wrote: Hi Simon, Thanks again for taking the time to check my comments. On 6/3/2

Re: [RFC 1/7] mmc: fsl_esdhc_imx: add OF_PLATDATA support

2020-04-07 Thread Walter Lozano
Hi Simon, Thank you for taking the time to review this series. On 6/4/20 00:42, Simon Glass wrote: Hi Walter, On Sun, 29 Mar 2020 at 21:32, Walter Lozano wrote: Signed-off-by: Walter Lozano --- drivers/mmc/fsl_esdhc_imx.c | 46 + 1 file changed, 42 inse

Re: [PATCH 3/4] [RFC] ARM: dts: stm32: Rework DDR DT inclusion

2020-04-07 Thread Marek Vasut
On 4/7/20 3:00 PM, Patrick DELAUNAY wrote: > Dear Marek, Hi, >> diff --git a/arch/arm/dts/stm32mp15-ddr.dtsi >> b/arch/arm/dts/stm32mp15-ddr.dtsi >> index 38f29bb789..50ca7092c4 100644 >> --- a/arch/arm/dts/stm32mp15-ddr.dtsi >> +++ b/arch/arm/dts/stm32mp15-ddr.dtsi >> @@ -3,152 +3,233 @@ >> *

Re: [PATCH 2/4] [RFC] ram: stm32mp1: Add support for multiple configs

2020-04-07 Thread Marek Vasut
On 4/7/20 3:04 PM, Patrick DELAUNAY wrote: > Hi Marek, Hi, [...] >> +__weak int board_stm32mp1_ddr_config_name_match(struct udevice *dev, >> +const char *name) >> +{ >> +return 0; /* Always match */ >> +} >> + >> +static ofnode stm32mp1_ddr_g

Re: zynq_z_turn_defconfig: broken networking

2020-04-07 Thread Matwey V. Kornilov
вт, 7 апр. 2020 г. в 12:18, Michal Simek : > > On 07. 04. 20 11:16, Matwey V. Kornilov wrote: > > вт, 7 апр. 2020 г. в 12:01, Michal Simek : > >> > >> On 07. 04. 20 9:58, Matwey V. Kornilov wrote: > >>> пн, 6 апр. 2020 г. в 12:41, Michal Simek : > > Hi, > > On 06. 04. 20 10:14,

Re: [PATCH v5 0/6] RISC-V DT related fixes for reserved memory & UEFI

2020-04-07 Thread Atish Patra
On Mon, Apr 6, 2020 at 11:51 PM Ard Biesheuvel wrote: > > On Tue, 7 Apr 2020 at 08:46, Heinrich Schuchardt wrote: > > > > On 4/6/20 11:01 PM, Ard Biesheuvel wrote: > > > On Mon, 6 Apr 2020 at 22:45, Atish Patra wrote: > > >> > > >> This series adds few DT related fixes required for Linux EFI stu

Re: iMX8MM USB support?

2020-04-07 Thread Tim Harvey
On Mon, Apr 6, 2020 at 2:43 AM Schrempf Frieder wrote: > > Hi Tim, > > On 01.04.20 19:55, Tim Harvey wrote: > > Peng, > > > > It looks like IMX8MM USB support hasn't made it upstream yet. Is this > > something your working on? > > > > I'm interested in booting an IMX8MM via SDP. > > If I remember

Re: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-07 Thread Wolfgang Denk
Dear Patrick, In message <8607d1778bcd4035807908e4a3a90...@sfhdag6node3.st.com> you wrote: > > To simplify the test: > > env_check = " if env info -p -d -q; then env save; fi;" All such automatical "env save" actions somewhere in the code give me the creeps. I've seen too often that they did t

Re: [PATCH 03/16] arm: stm32mp: reset to default environment when serial# change

2020-04-07 Thread Wolfgang Denk
Dear Patrick, In message <60273317e5704581bef81c4beb28a...@sfhdag6node3.st.com> you wrote: > > > I strongly advice against such a method. Please drop that. > > Understood, I drops this patch Thanks. > I introduce this behavior after a internal request and to avoid issues during > tests: >

RE: [U-Boot] [PATCH v2 5/5] sifive: fu540: Enable spi-nor flash support

2020-04-07 Thread Sagar Kadam
Hello Jagan, > -Original Message- > From: Jagan Teki > Sent: Monday, April 6, 2020 9:30 PM > To: Sagar Kadam > Cc: Bin Meng ; Palmer Dabbelt > ; U-Boot Mailing List ; linux- > amarula > Subject: Re: [U-Boot] [PATCH v2 5/5] sifive: fu540: Enable spi-nor flash > support > > [External Ema

Re: [PATCH 1/2] sunxi: allow bigger images for all

2020-04-07 Thread Maxime Ripard
On Mon, Apr 06, 2020 at 08:24:26PM -, Karl Palsson wrote: > > Maxime Ripard wrote: > > Hi, > > > > On Mon, Apr 06, 2020 at 03:51:39PM +, Karl Palsson wrote: > > > No reason to limit bigger images to 64bit targets, it's quite easy > > > to go over the limit with a kernel+initramfs > > > > T

RE: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-07 Thread Patrick DELAUNAY
Dear Wolfgang, > From: Wolfgang Denk > Sent: mercredi 1 avril 2020 13:26 > > Dear Patrick Delaunay, > > In message <20200331160456.26254-1-patrick.delau...@st.com> you wrote: > > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target and test U-Boot > > version ($env_ver) when the environment was sa

RE: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-07 Thread Patrick DELAUNAY
Hi Patrice > From: Patrice CHOTARD > Sent: mercredi 1 avril 2020 09:34 > > Hi Patrick > > On 3/31/20 6:04 PM, Patrick Delaunay wrote: > > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target and test U-Boot > > version ($env_ver) when the environment was saved for the last time > > and to display

  1   2   >