Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
(3 comments)
Ayal, the current implementation would not cut the storage under a running
VM, as
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
Sergey Gotliv has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 7:
(1 comment)
File vdsm/vm.py
Sergey Gotliv has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 8:
1. Rebase.
2. Added new log printing due to Ayal's comment.
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
For this kind of upgrade we may either require a reboot, or detect which lvs
are used and
Sergey Gotliv has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 8:
I am not sure why Jenkins decided that vm.py line 514 is not properly indented.
Dan Kenigsberg has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
Nir, right, i did not think about upgrade logic. Though you can touch var/run
in the spec file
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
For this kind of upgrade we may either require a reboot, or detect which lvs
are used and
Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
you can touch var/run in the spec file to avoid this problem.
of course that everything that is
Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1: Code-Review-1
(2 comments)
using a file under /var/run to sign first boot is enough. also bare
Yaniv Bronhaim has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4:
(1 comment)
Commit Message
Line 29: from .
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 2:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4:
(1 comment)
Commit Message
Line 29: from .
Yaniv Bronhaim has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1: Code-Review-1
until convincing me why not having it under the tool I must use my -1 force..
sorry :/
Yaniv Bronhaim has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1:
use whatever you need from /usr/share/vdsm and add the path for that if
required.. although I don't
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
can't find your response to my question why not having appropriate solution
for
Assaf Muller has posted comments on this change.
Change subject: Quarantine ovirt-3.0.0 network upgrade
..
Patch Set 1: -Code-Review
Dan, if you do end up using vdsm-tool then you might want to use the upgrade
mechanism :)
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
(2 comments)
also bare in mind that user can have vdsmd installed without running it at
all, so
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
what hack? maybe I do not follow.
--
To view, visit http://gerrit.ovirt.org/20808
To
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
first: no require reboot ever
second: files under /var/run persist during upgrade, so I don't
Yaniv Bronhaim has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Create AsyncProcessOperation
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19254
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
Current plan is to have this patch only for zstream, and use lvm activation
skipping for el 6.5
Alon Bar-Lev has posted comments on this change.
Change subject: fcp: Deactivate vdsm volume groups during boot
..
Patch Set 1:
Current plan is to have this patch only for zstream
so why do you submit it into master?
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: Pause vm in case volume allocation is greater than lv size
..
Patch Set 9:
Build Successful
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 6:
(1 comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 23:
Alon, lets continue with the review until I'll understand all the material
about sanlock
Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 23:
I have no more comments except that we need to move the sanlock configuration
here to have sane
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 7:
modified commit message
--
To view, visit http://gerrit.ovirt.org/20808
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 7:
Build Successful
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 2:
(1 comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4:
(1 comment)
Commit Message
Line 29: from .
Saggi Mizrahi has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4: Code-Review-1
Although relative imports are nice we will not use them until we don't need to
import
Nir Soffer has uploaded a new change for review.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
lvm: Prevent auto-actviation of logical volumes
When using FC storage, physical volumes are connected during
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4392/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iscsi: Iscsi rescan cleanup
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4393/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4394/ :
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
Missing also spec changes - depend on lvm 2.02.100.
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: tests: Add miniaml issciadm tests
..
Patch Set 11:
I understand what you are testing I just don't understand why you want to test
that.
It can't catch any
Yaniv Bronhaim has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 24: Verified+1
Verified. although there is still libvirtd stop in libvirtd_sysv2upstart which
I
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20808
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 24:
No more comments, just the sanlock should not be abnormality.
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 24:
I still do not follow how restart of sanlock cause it to run under different
account.
The only
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1: Verified-1 Code-Review-1
(6 comments)
Commit
mooli tayer has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4:
(1 comment)
Commit Message
Line 29: from .
Eduardo has uploaded a new change for review.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
lvm: Prevent auto-activation of logical volumes.
When using FC storage, physical volumes are connected during
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4395/ :
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
Please look at:
Change-Id: Iab9b7579990d934c60999b4c603c3acf46557be1
--
To view, visit
Sergey Gotliv has posted comments on this change.
Change subject: upgrade: fix v3ResetMetaVolSize argument
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20721
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 1:
(6 comments)
Commit Message
Line 16: lvm
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4396/
Nir Soffer has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
Fix typo and lvm2 dependency.
--
To view, visit http://gerrit.ovirt.org/20832
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4397/ :
Nir Soffer has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop dead thread
..
Patch Set 3:
(1 comment)
Looks good expect unused variable.
Nir Soffer has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop dead thread
..
Patch Set 3:
(1 comment)
Minor title edit.
Commit Message
Line
Nir Soffer has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 1:
(2 comments)
File vdsm/configNetwork.py
Line 32:
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: Improve lib/vdsm imports (PEP328)
..
Patch Set 4:
Saggi, why no prepare now for the (nearing) __future__?
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling.ImagePathStatus: drop unused code
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4398/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
Patch Set 1: Code-Review-1
(2 comments)
Commit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
Patch Set 2: Code-Review+2
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: move watchdog default params to WatchdogDevice
..
vdsm: move watchdog default params to WatchdogDevice
Watchdog device creation is currently
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
Patch Set 1:
(1 comment)
Commit Message
Line 6:
Line 7:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4399/ :
Eduardo has uploaded a new change for review.
Change subject: Remove redundant supervsdm.validateAccess.
..
Remove redundant supervsdm.validateAccess.
Change-Id: Id37865225ea2d29361d6e588f9bb0acf7bf71cec
Signed-off-by: Eduardo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove redundant supervsdm.validateAccess.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4400/ : SUCCESS
Sergey Gotliv has posted comments on this change.
Change subject: lvm: Prevent auto-activation of logical volumes.
..
Patch Set 2:
You and Nir are working on the same issue:
http://gerrit.ovirt.org/#/c/20832/
--
To view,
Sergey Gotliv has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3:
Similar to http://gerrit.ovirt.org/#/c/20836/.
Eduardo mentioned that in one of his comments.
Eduardo has posted comments on this change.
Change subject: lvm: Prevent auto-actviation of logical volumes
..
Patch Set 3: Code-Review-1
(5 comments)
Commit Message
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: prevent hook validation decorator from leaving scripts
installed
..
Patch Set 6:
Build Successful
78 matches
Mail list logo
