Yaniv Bronhaim has posted comments on this change. Change subject: xmlrpc: Parsing error logging enhancement - vdsClient ......................................................................
Patch Set 2: (1 comment) .................................................... File lib/vdsm/vdscli.py.in Line 37: class TransportWrapper: Line 38: def __init__(self, transport): Line 39: self._transport = transport Line 40: Line 41: def __getattr__(self, name): imo wrapper is the right way here. you just modify the getattr which is common for attributes, and wrap the call Line 42: if hasattr(self._transport, name): Line 43: func = getattr(self._transport, name) Line 44: return lambda *args, **kwargs: self._wrap(name, func, args, kwargs) Line 45: raise AttributeError(name) -- To view, visit http://gerrit.ovirt.org/20627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife29c4f7749b9cd8a4ad892f486d91509e505ae4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
