Dan Kenigsberg has uploaded a new change for review.
Change subject: py3: remove capsTests from blacklist
..
py3: remove capsTests from blacklist
This patch makes the test module not depend on specific iteration order
of a set,
Dan Kenigsberg has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 15: Code-Review-1
Needs a rebase
--
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, vi
Dan Kenigsberg has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 34: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: utils: add is_kvm helper
..
virt: utils: add is_kvm helper
Proper container support needs some changes into oVirt Engine.
First of all, Engine sh
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sos: collect 'nodectl info' output
..
sos: collect 'nodectl info' output
CEE needs a quick and reliable way to determine release information
from a cus
Dan Kenigsberg has posted comments on this change.
Change subject: sos: collect 'nodectl info' output
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.or
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: add migrate and migrateStatus
..
jsonrpcvdscli: add migrate and migrateStatus
Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Signe
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: bond tests fails on CI with ctypes.AttributeError
..
Patch Set 1:
The commit message needs some beefing: admit that we have no idea what are
these f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
net: Consume ifcfg files that have a non vdsm standard name
VDSM assumes that the ifcfg
Dan Kenigsberg has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visi
Dan Kenigsberg has posted comments on this change.
Change subject: tests: inspect.getargspec() is deprecated in py3
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/64313/1/tests/testlib.py
File tests/testlib.py:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sos: remove jsonrpcvdscli.connect parameters
..
sos: remove jsonrpcvdscli.connect parameters
patch https://gerrit.ovirt.org/#/c/62730/ added default va
Dan Kenigsberg has posted comments on this change.
Change subject: utils: build cert paths in single place
..
Patch Set 12: Code-Review-1
(1 comment)
-1 for visibility
https://gerrit.ovirt.org/#/c/52354/12/vdsm/sos/vdsm.py.in
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: set selinux labels while creating bricks
..
gluster: set selinux labels while creating bricks
brick should have correct selinux labels on the
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 5: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: net: test ovs info with southbound nic
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63999
To unsubscribe, visit https://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: test ovs info with southbound nic
..
net: test ovs info with southbound nic
We will remove OVS bonding support in a following patch. This patch
ch
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding)
..
net: Disable IPv6 on OVS southbound iface (nic or bonding)
Only northbound iface may have
Dan Kenigsberg has posted comments on this change.
Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding)
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63826
To unsubscri
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: remove default route before adding a new one
..
net: remove default route before adding a new one
Change-Id: Ie59c07845898630404ce517e5cc52048e50e
Dan Kenigsberg has posted comments on this change.
Change subject: net: remove default route before adding a new one
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63220
To unsubscribe, visit https://
Dan Kenigsberg has posted comments on this change.
Change subject: net test: test_ip_info - wait for IP settings with address
..
Patch Set 4: Code-Review+2
rasing
--
To view, visit https://gerrit.ovirt.org/63660
To unsubscrib
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: test_ip_info - wait for IP settings with address
..
net test: test_ip_info - wait for IP settings with address
This is a second attempt to ha
Dan Kenigsberg has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 33: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: Do not modify warnings filter in a library
..
vdsm: Do not modify warnings filter in a library
vdsm.vdscli was modifying warnings filter, taking
Dan Kenigsberg has submitted this change and it was merged.
Change subject: alignmentScan: Add Red Hat copyright
..
alignmentScan: Add Red Hat copyright
This module was started by Saša Tomić in 2012. According to git log Red
Ha
Dan Kenigsberg has posted comments on this change.
Change subject: alignmentScan: Add Red Hat copyright
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64223
To unsubscribe, visit https://gerrit.ovirt.
Dan Kenigsberg has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64113/1/static/etc/vdsm/logger.conf.in
File static/etc/vdsm/lo
Dan Kenigsberg has posted comments on this change.
Change subject: config: Rename irs:scsi_settle_timeout option
..
Patch Set 1: Code-Review+2
Ok, I don't suppose people in the field use and depend on it.
--
To view, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: config: Rename irs:scsi_settle_timeout option
..
config: Rename irs:scsi_settle_timeout option
This option is not about SCSI but about udev events. We
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://g
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Link setup module - includes bond setup logic.
..
net: Link setup module - includes bond setup logic.
Introducing the bond setup module.
It includ
Dan Kenigsberg has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 25: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: early IP+link setup
..
net: early IP+link setup
Host networking must be available before libvirtd.service starts.
This cannot be handled by curren
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove python-argparse requirement
..
Remove python-argparse requirement
This package has been obsoleted in Fedora because it got in to stdlib.
Change
Dan Kenigsberg has posted comments on this change.
Change subject: Remove python-argparse requirement
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64162
To unsubscribe, visit https://gerrit.ovirt.or
Dan Kenigsberg has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: add and use new devel logger
..
logging: add and use new devel logger
After rhbz#1264149 we learned that way that the warnings
module doesn't
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: add test for Xen block device
..
v2v: add test for Xen block device
Change-Id: I1afc7d21857e59ebf69856e99e15cc3796149e4e
Signed-off-by: Shahar Hav
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: shorten py3 blacklist
..
tests: shorten py3 blacklist
A few more test modules are passing under Python 3. Let's keeep testing
them.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: api.py: preserve signature in decorator
..
Patch Set 13: Code-Review+2
never mind the minor slowdown of each API call, let's take this in.
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: api.py: preserve signature in decorator
..
lib: api.py: preserve signature in decorator
The api.method decorator needs to preserve the function
or
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move the response.py under common
..
lib: move the response.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
shou
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move define.py under common
..
lib: move define.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
should depend on
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: move exception.py under common
..
lib: move exception.py under common
The commit fc732ae broke the rule that code under lib/vdsm/common
should dep
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cmdutils: enhance systemd_run
..
cmdutils: enhance systemd_run
Change-Id: Id49be0d88d573958bf0884a254256bb2a745940a
TODO: explain
Signed-off-by: France
Dan Kenigsberg has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56474
To unsubscribe, visit https://gerrit.ovirt.org/se
Dan Kenigsberg has posted comments on this change.
Change subject: draft: migration plugin proposal - draft 102
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/64186/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_m
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mount: Wait for systemd temporary mount unit
..
mount: Wait for systemd temporary mount unit
Systemd is monitoring mountpoints created during runtime b
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Rely on system for logrotation
..
Patch Set 3:
I am not 100% that this still applies, but please discuss
https://bugzilla.redhat.com/show_bug.cgi?id=1113
Dan Kenigsberg has posted comments on this change.
Change subject: tests: shorten py3 blacklist
..
Patch Set 3: Verified+1
tests still pass, on py3 as well
--
To view, visit https://gerrit.ovirt.org/64060
To unsubscribe, visi
Dan Kenigsberg has abandoned this change.
Change subject: [WIP]fencenode: split fenceNode into its own module
..
Abandoned
On Sun, Sep 18, 2016 at 09:32:19AM +0300, Yaniv Bronheim wrote:
> Hi Dan, please abandon this patch
--
Dan Kenigsberg has abandoned this change.
Change subject: Adding dns vdsm hook
..
Abandoned
this has been integrated natively into DNS in https://gerrit.ovirt.org/61184
and friends.
--
To view, visit https://gerrit.ovirt.org
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ResourceManagerLock: Disable autoRelease
..
ResourceManagerLock: Disable autoRelease
When acquiring ResourceManagerLocks we do not store a reference to
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Unbreak make rpm
..
tests: Unbreak make rpm
commit a54045aff9af introduced vmfakecon helper module but it was missing from
the makefile, breakin
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Unbreak make rpm
..
Patch Set 1: Code-Review+2
So sorry, i was careless.
--
To view, visit https://gerrit.ovirt.org/64076
To unsubscribe, visit https:/
Dan Kenigsberg has posted comments on this change.
Change subject: tests: split vmfakecon out of vmfakelib
..
Patch Set 2: Verified+1
still passes unit tests
--
To view, visit https://gerrit.ovirt.org/63197
To unsubscribe, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: split vmfakecon out of vmfakelib
..
tests: split vmfakecon out of vmfakelib
vmfakelib contains both a fake ClientIF and a fake libvirtconnection
Dan Kenigsberg has uploaded a new change for review.
Change subject: tests: shorten py3 blacklist
..
tests: shorten py3 blacklist
A few more test modules are passing under Python 3. Let's keeep testing
them.
Change-Id: I1826df6
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: outOfProcess: remove useless warning
..
storage: outOfProcess: remove useless warning
This usage of warnings module add no value, so we drop i
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: fileUtils: drop redundant warning
..
storage: fileUtils: drop redundant warning
The usage of warnings.warn in the fileUtils
looks redundant, s
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 5:
Edy, I believe the bug is specific to ifcfg, so the solution and the test are
Dan Kenigsberg has submitted this change and it was merged.
Change subject: functional tests: fix supervdsmServer test
..
functional tests: fix supervdsmServer test
supervdsmServer dropPrivileges function is switching root user
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: Support for ova exported from AWS
..
v2v: Support for ova exported from AWS
When exporting VM from AWS as VMWare OVA file it doesn't export
tag f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: dhclient: shorten name of the thread
..
network: dhclient: shorten name of the thread
We shorten the name of the DhcpClient worker thread to
m
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: ifup: shorten name of the thread
..
network: ifup: shorten name of the thread
We shorten the name of the thread optionally used by
the _ifup()
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: switch to concurrent.thread()
..
network: switch to concurrent.thread()
This patch replaces good usages of threading.Thread() with
more modern
Dan Kenigsberg has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61459
To unsubscribe, visit https://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61459/13//COMMIT_MSG
Commit Message:
Line 9: This patch:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: ResourceManagerLock: Disable autoRelease
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63967/1//COMMIT_MSG
Commit Message:
Line 10: resource (prefe
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "build tests: Require NOSE 1.3.7 and up for running
tests"
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64035/2//COMMIT_MSG
C
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net libvirt hook: revert vmList change
..
net libvirt hook: revert vmList change
Patch 78ea853e131da3b91b812315a0656b8f99d7fef4 is reverted so the
vmLi
Dan Kenigsberg has posted comments on this change.
Change subject: net libvirt hook: revert vmList change
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63762/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpc: revert Host.getVMList command result change
..
jsonrpc: revert Host.getVMList command result change
patch https://gerrit.ovirt.org/#/c/63408/
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Run mount tests multiple times
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/56545/7/tests/mountTests.py
File tests/mountTests.py:
Line 122:
Dan Kenigsberg has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 6: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/56544/6/lib/vdsm/storage/mount.py
File lib/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: add a repo with a fresh nose
..
automation: add a repo with a fresh nose
We need nose >= 1.3.7 to test vdsm, but don't have it on el7. One
Dan Kenigsberg has posted comments on this change.
Change subject: automation: add a repo with a fresh nose
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63986
To unsubscribe, visit https://gerrit.ov
Dan Kenigsberg has uploaded a new change for review.
Change subject: automation: add a repo with a fresh nose
..
automation: add a repo with a fresh nose
We need nose >= 1.3.7 to test vdsm, but don't have it on el7. One option
d
Dan Kenigsberg has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-09-15
Dan Kenigsberg has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-09-15
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: fix help test for glusterVolumehealInfo in vdsClient
..
gluster: fix help test for glusterVolumehealInfo in vdsClient
There is a format issu
Dan Kenigsberg has posted comments on this change.
Change subject: net: reconfigure bond detached from bridges
..
Patch Set 4:
could you add a functional test for the user scenario
--
To view, visit https://gerrit.ovirt.org/6
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build tests: Require NOSE 1.3.7 and up for running tests
..
build tests: Require NOSE 1.3.7 and up for running tests
On RHEL7/Centos7 the provided NOSE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storageServer: Remove dead code
..
storageServer: Remove dead code
The connection monitor and friends were never used, remove them.
Change-Id: Id5e827
Dan Kenigsberg has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 6: Code-Review+2
Introduced long ago, by https://gerrit.ovirt.org/#/c/1694/ , but never used.
--
To view, visit h
Dan Kenigsberg has posted comments on this change.
Change subject: mount: Wait for systemd temporary mount unit
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/56544/5/lib/vdsm/storage/mount.py
File lib/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mount: Remove unneeded freeloop=True usage
..
mount: Remove unneeded freeloop=True usage
On modern systems loop devices are mounted with the autoclear
Dan Kenigsberg has posted comments on this change.
Change subject: mount: Remove unneeded freeloop=True usage
..
Patch Set 5: Code-Review+2
taking your word about the unneededness of this arg.
--
To view, visit https://gerrit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mount: Remove pointless force=True usage
..
mount: Remove pointless force=True usage
Using force=True when unmounting loop device is pointless - this o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Add mount.isMounted() timing tests
..
tests: Add mount.isMounted() timing tests
Add timing tests to understand how much time it takes to check i
Dan Kenigsberg has posted comments on this change.
Change subject: build net tests: Create a test target for networking tests.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63649
To unsubscribe, visi
Dan Kenigsberg has posted comments on this change.
Change subject: cleanup: remove persist/unpersist calls for legacy node
..
Patch Set 4: Code-Review-1
Thanks for this much needed cleanup.
At the very least, you can split net
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix testGetBondingOptions
..
tests: fix testGetBondingOptions
Bonding options are reported only if they differ from defaults.
Bond 'mode' is exc
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: introducting broken_on_ci decorator
..
tests: introducting broken_on_ci decorator
With this decorator we skip failed test only when it was execu
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build net tests: Create a test target for networking tests.
..
build net tests: Create a test target for networking tests.
It is usefull to run only th
Dan Kenigsberg has posted comments on this change.
Change subject: build tests: Disable the builtin check target.
..
Patch Set 1: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63646
To unsubscribe, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build tests: Disable the builtin check target.
..
build tests: Disable the builtin check target.
There is no need to recursively check the tests/ folde
Dan Kenigsberg has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/61459/13//COMMIT_MSG
Commit Message:
Line 9: This patch:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: Unify stoage logger name
..
storage: Unify stoage logger name
We had both "Storage" and "storage" loggers, but configuration was only
for "Sto
301 - 400 of 21419 matches
Mail list logo
