Re: [Warzone-dev] Commit policies

2008-06-17 Thread Giel van Schijndel
Per Inge Mathisen schreef: On Tue, Jun 17, 2008 at 3:18 PM, Dennis Schridde <[EMAIL PROTECTED]> wrote: Am Dienstag, 17. Juni 2008 09:02:13 schrieb Per Inge Mathisen: On Tue, Jun 17, 2008 at 12:35 AM, Dennis Schridde <[EMAIL PROTECTED]> wrote: Principle, yes. I am also against co

Re: [Warzone-dev] Commit policies

2008-06-17 Thread Dennis Schridde
Am Dienstag, 17. Juni 2008 17:18:30 schrieb Per Inge Mathisen: > On Tue, Jun 17, 2008 at 3:18 PM, Dennis Schridde <[EMAIL PROTECTED]> wrote: > > But while I read through functions, I also add spaces here and there so I > > can get a quick overview faster. > > Don't. Seriously, that is extremely ann

Re: [Warzone-dev] Commit policies

2008-06-17 Thread Per Inge Mathisen
On Tue, Jun 17, 2008 at 3:18 PM, Dennis Schridde <[EMAIL PROTECTED]> wrote: > Am Dienstag, 17. Juni 2008 09:02:13 schrieb Per Inge Mathisen: >> On Tue, Jun 17, 2008 at 12:35 AM, Dennis Schridde <[EMAIL PROTECTED]> > wrote: > Principle, yes. I am also against commits like "change style in a.c, b.c,

Re: [Warzone-dev] Commit policies

2008-06-17 Thread Dennis Schridde
Am Dienstag, 17. Juni 2008 09:02:13 schrieb Per Inge Mathisen: > On Tue, Jun 17, 2008 at 12:35 AM, Dennis Schridde <[EMAIL PROTECTED]> wrote: > >> > 4) Do not mix unrelated cleanup and feature changes or bug fixes in > >> > the same patch. > > ... > > > 4) Seems cumbersome to me, since when I try

Re: [Warzone-dev] Commit policies

2008-06-17 Thread Per Inge Mathisen
On Tue, Jun 17, 2008 at 12:35 AM, Dennis Schridde <[EMAIL PROTECTED]> wrote: >> > 4) Do not mix unrelated cleanup and feature changes or bug fixes in >> > the same patch. ... > 4) Seems cumbersome to me, since when I try to fix a bug, some cleanup will > almost always sneak in, and additionaly I f

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Dennis Schridde
Am Montag, 16. Juni 2008 21:47:16 schrieb Giel van Schijndel: > Per Inge Mathisen schreef: > > On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> > > wrote: > >> Per Inge Mathisen schreef: > >>> Here is what I would like to see: > >>> 1) Every patch goes into the patch tracke

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Giel van Schijndel
Per Inge Mathisen schreef: On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: Per Inge Mathisen schreef: Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patc

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Per Inge Mathisen
On Mon, Jun 16, 2008 at 9:21 PM, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Per Inge Mathisen schreef: >> >> Here is what I would like to see: >> 1) Every patch goes into the patch tracker. Give a quick run down of >> what it does and what it changes. >> 2) After a patch has been put into th

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Giel van Schijndel
Per Inge Mathisen schreef: Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patch has been put into the patch tracker, give this list 48 hours to comment on it. Exception for patches that *only* f

Re: [Warzone-dev] Commit policies

2008-06-16 Thread Dennis Luxen
Hello, > We need to implement some stricter commit policies and focus more on > quality control and avoiding patch conflicts. Although, I have contributed only once until now, I do see these problems as well. > Here is what I would like to see: > 1) Every patch goes into the patch tracker. Giv

[Warzone-dev] Commit policies

2008-06-16 Thread Per Inge Mathisen
Hello all, We need to implement some stricter commit policies and focus more on quality control and avoiding patch conflicts. Here is what I would like to see: 1) Every patch goes into the patch tracker. Give a quick run down of what it does and what it changes. 2) After a patch has been put in