Re: [Wikitech-l] HipHop

2011-04-04 Thread Ashar Voultoiz
On 05/04/11 04:47, Tim Starling wrote: > Speaking of "fast", I did a quick benchmark of the [[Barack Obama]] > article with templates pre-expanded. It took 22 seconds in HipHop and > 112 seconds in Zend, which is not bad, for a first attempt. I reckon > it would do better if a few of the regula

[MediaWiki-CodeReview] [MediaWiki r82778]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r82778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82778#c15725 Comment: I don't see how doing your own reads is helping with that bug. The duplicates will be missing whether you get them from InterlanguageCentralExtension::

[MediaWiki-CodeReview] [MediaWiki r85412]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r85412. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85412#c15724 Comment: Use new Article( $title, 0 ); unless you want hard to track bugs with wrong articles being acted on. ___ Med

[MediaWiki-CodeReview] [MediaWiki r84997]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r84997. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84997#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://li

[MediaWiki-CodeReview] [MediaWiki r85296]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tbleher" posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15723 Comment: We don't have to, but if we don't, why add a b/c function at all? At the very least, the function is very confusing, because both name and documentation imp

[MediaWiki-CodeReview] [MediaWiki r84791]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" changed the status of MediaWiki.r84791. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84791#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://li

[MediaWiki-CodeReview] [MediaWiki r85296]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15722 Comment: Why do we have to support old versions of extensions in new versions of core? ___ MediaWiki-CodeReview mailing li

[MediaWiki-CodeReview] [MediaWiki r82778]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r82778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82778#c15721 Comment: In EditPage::showEditForm:fields, you should do what you are doing already. Use $parser->mOutput->setProperty() in the parser hook, remove the ArticleS

[MediaWiki-CodeReview] [MediaWiki r85296]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Tbleher" changed the status of MediaWiki.r85296. Old Status: new New Status: fixme User "Tbleher" also posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15720 Comment: Surely getSkin() should return a skin object rather than a Lin

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r85403. Old Status: new New Status: fixme User "Siebrand" also posted a comment on MediaWiki.r85403. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15719 Comment: FIXME: +var_dump('foo'); _

[Wikitech-l] HipHop: need developers

2011-04-04 Thread Tim Starling
I need to get back to work on reviews and deployments and other such strategic things. I hope the work I've done on HipHop support is enough to get the project started. Initial benchmarks are showing a 5x speedup for article parsing, which is better than we had hoped for. So there are big gains

[MediaWiki-CodeReview] [MediaWiki r85387]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "MaxSem" changed the status of MediaWiki.r85387. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85387#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wi

[MediaWiki-CodeReview] [MediaWiki r85415]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r85415. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85415#c15718 Comment: A lot of this rev is reverted in r85417, which is a better fix. ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r85417]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r85417. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85417#c15717 Comment: This is a less clunky fix for bug 27424. The other rev (r85415) was overkill. ___ MediaWiki-CodeReview mailing li

Re: [Wikitech-l] HipHop

2011-04-04 Thread Brandon Harris
I am surely not the only person who gets Blondie's "Rapture" stuck in their head whenever they see the topic for this thread? No? Ugh. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mail

Re: [Wikitech-l] GSOC and networking

2011-04-04 Thread K. Peachey
On Tue, Apr 5, 2011 at 1:07 PM, Michael Costello wrote: > Perhaps entirely outside of the scope of GSOC, I think it would be a > fun project to make wikipedia.org and wikimedia.org accessible over > IPv6. > > I noticed that my login was insecure, and that there was no SSL > option.  Adding a secur

Re: [Wikitech-l] GSOC and networking

2011-04-04 Thread Benjamin Lees
On Mon, Apr 4, 2011 at 11:07 PM, Michael Costello wrote: > I noticed that my login was insecure, and that there was no SSL > option. There is a secure login option, and the login page has a link to it, but the link wasn't showing up in the right place in the Vector skin. I think I've fixed it.[0]

Re: [Wikitech-l] GSOC and networking

2011-04-04 Thread Jelle Zijlstra
There is an SSL option: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/MediaWiki . However, making https://www.mediawiki.org would be another useful project. 2011/4/4 Michael Costello > Hello, > > I was encouraged (hello, Sumana) to post a Google Summer of Code idea > and solicit comments

[Wikitech-l] GSOC and networking

2011-04-04 Thread Michael Costello
Hello, I was encouraged (hello, Sumana) to post a Google Summer of Code idea and solicit comments. So here goes. Perhaps entirely outside of the scope of GSOC, I think it would be a fun project to make wikipedia.org and wikimedia.org accessible over IPv6. Also, while creating an account to post

Re: [Wikitech-l] Actions and Special Pages

2011-04-04 Thread MZMcBride
Daniel Friesen wrote: > What "IS" so evil about actions? Besides the implementation details > which are just that... something we can make better. In fact something > we could potentially make work better than SpecialPages would in this > context. > Personally, I like tacking on ?action=edit and es

Re: [Wikitech-l] HipHop

2011-04-04 Thread Tim Starling
On 03/30/2011 09:22 AM, Magnus Manske wrote: > Plus, free C++ MediaWiki parser ;-) > > Seriously, there should be a way to turn the entire package into a > (huge) library; maybe transpile it and then replace the C++ code for > index.php with a manually written library interface? HipHop has a libra

Re: [Wikitech-l] Actions and Special Pages

2011-04-04 Thread Daniel Friesen
On 11-04-04 08:12 PM, MZMcBride wrote: > Aryeh Gregor wrote: >> On Mon, Apr 4, 2011 at 9:28 AM, Happy-melon wrote: >>> If people think it would be >>> better as a special page we'd make >>> http://foo.example.com/w/index.php?title=Bar&action=edit a hard redirect to >>> Special:Edit/Bar; that has t

Re: [Wikitech-l] Actions and Special Pages

2011-04-04 Thread MZMcBride
Aryeh Gregor wrote: > On Mon, Apr 4, 2011 at 9:28 AM, Happy-melon wrote: >> If people think it would be >> better as a special page we'd make >> http://foo.example.com/w/index.php?title=Bar&action=edit a hard redirect to >> Special:Edit/Bar; that has the significant advantage of being able to be >

Re: [Wikitech-l] Future: Love for the sister projects!

2011-04-04 Thread Casey Brown
On Mon, Apr 4, 2011 at 9:05 PM, K. Peachey wrote: > I don't see why we need to spilt it off to another list No reason > not to do it here on wikitech-l. Did you realize that that list already exists? There's also no reason not to use both of them, with the ambassadors list one being more of

Re: [Wikitech-l] Some changes to $wgOut, $wgUser, Skin, and SpecialPage code patterns

2011-04-04 Thread MZMcBride
Brion Vibber wrote: > I'd be kind of inclined to separate out the Skin and Linker worlds a bit > further; really, the HTML formatting of links and such doesn't depend on the > user (except in some edge cases like stub links which could in principle be > done differently). The surrounding *skin* dep

[MediaWiki-CodeReview] [MediaWiki r84782]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r84782. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84782#c15716 Comment: total processing time: 188 days 4520h 57m 51.00s gained time: 2 days 62h 32m 52.859375s Too many hours! _

[Wikitech-l] Linker, more on Skins, OutputPage, and context code patterns changes

2011-04-04 Thread Daniel Friesen
Continuing with my changes to $wgOut, $wgUser, Skin, and SpecialPage patterns. The Linker is now static, $sk->link will still work, however you should not be requiring a Skin anymore to use linker methods. Please use Linker::link directly. The only exception is the method to create an editsecti

Re: [Wikitech-l] Future: Love for the sister projects!

2011-04-04 Thread K. Peachey
On Tue, Apr 5, 2011 at 10:27 AM, Casey Brown wrote: >> * Gather a list of tech users[2] and invite them to the new wiki and/or >> a mailing list. > > https://lists.wikimedia.org/mailman/listinfo/wikitech-ambassadors ? I don't see why we need to spilt it off to another list No reason not to do

Re: [Wikitech-l] Some changes to $wgOut, $wgUser, Skin, and SpecialPage code patterns

2011-04-04 Thread Aaron Schulz
I second the idea of the static Linker class. It's far better than the subclass system. Skin modification of links should focus on CSS anyway, rather than trying to overload link generating code. Daniel Friesen-4 wrote: > > On 11-04-04 02:40 PM, Platonides wrote: >> I like it. Specially the Link

Re: [Wikitech-l] Some changes to $wgOut, $wgUser, Skin, and SpecialPage code patterns

2011-04-04 Thread Daniel Friesen
On 11-04-04 02:40 PM, Platonides wrote: > I like it. Specially the Linker change. It really looks the way to have it. > >> I'm considering >> making the Parser get it's linker via $po->getLinker(); (either >> ParserOutput or ParserOptions, I need another look) > The linker would be an input paramet

[MediaWiki-CodeReview] [MediaWiki r85402]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r85402. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85402#c15713 Comment: Making it private and the whitespace? Probably not ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r85302. Old Status: fixme New Status: new User "Happy-melon" also posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15714 Comment: Fixed in r85403 _

Re: [Wikitech-l] Future: Love for the sister projects!

2011-04-04 Thread Casey Brown
On Mon, Apr 4, 2011 at 6:22 PM, Platonides wrote: > Some steps to take: > * Finally create global gadgets. > * Create a central wiki for javascript sharing [1] It seems like this always comes up for a number of different things -- "global pages" for interwiki transclusion and interlanguage extens

[MediaWiki-CodeReview] [MediaWiki r85403]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r85403. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85403#c15715 Comment: You can also drop $wgUser->getSkin( $wgTitle ); // set skin title it's not needed. ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r85402]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Happy-melon" posted a comment on MediaWiki.r85402. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85402#c15712 Comment: This is half of r79542. Is it worth merging the rest of that rev? ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r79108]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r79108. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79108#c15711 Comment: I'm not sure. It's stopped happening now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.

Re: [Wikitech-l] HipHop

2011-04-04 Thread Tim Starling
On 04/05/2011 07:31 AM, Platonides wrote: > Having to create a reflection class and look for exceptions just to > check for class existance is really ugly. > However, looking at https://github.com/facebook/hiphop-php/issues/314 it > seems to be a declaration before use problem (even though class_ex

[MediaWiki-CodeReview] [MediaWiki r85385]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r85385. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.

Re: [Wikitech-l] HipHop

2011-04-04 Thread Tim Starling
On 04/05/2011 04:31 AM, Inez Korczynski wrote: > Hi Tim, > > I have no problem running foo.php and test.php that you sent in hphpi, but > also it compiles and run without any problems with hphp. What command > exactly do you use to compile and then execute? To compile: hphp --target=cpp --format=

Re: [Wikitech-l] Future: Love for the sister projects!

2011-04-04 Thread Alex Brollo
Very interesting! :-) I'm a beginner in js stuff, but I realized how much js can be useful in a number of ways (presently I am a "very simple gadgets maker" t help users engaged into proofreading into wikisource). I'm a little worried about additional server load coming from AJAX, and I suggest d

Re: [Wikitech-l] Future: Love for the sister projects!

2011-04-04 Thread Platonides
I think the source of the problems is the decentralizated process that wikimedia javascript have followed. Medium-size wikis will have 2-3 tech people. Small wikis will be lucky to have 1 js-savy sysop. Even wikis with no local expert may have just forked the Monobook.js from its mother project and

[MediaWiki-CodeReview] [MediaWiki r85385]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85385. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c15710 Comment: Oh poop, I still haven't retrained my muscle memory for our space style. ;) The empty() should be fine for arrays, but if it makes you feel better chang

[MediaWiki-CodeReview] [MediaWiki r85385]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r85385. Old Status: new New Status: fixme User "Reedy" also posted a comment on MediaWiki.r85385. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85385#c15709 Comment: empty? :P Also, should have more spaces on your if statement ;)

[MediaWiki-CodeReview] [MediaWiki r85335]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Jeroen De Dauw" posted a comment on MediaWiki.r85335. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85335#c15708 Comment: The current MW convention for fields AFAIK is $fieldName, not $m_fieldName. Just saying, doesn't matter that much in any case

Re: [Wikitech-l] writing phpunit tests for extensions

2011-04-04 Thread Michael Dale
On 04/04/2011 02:20 PM, Platonides wrote: > Michael Dale wrote: >> Eventually it would be ideal to be able to 'just test your extension' >> from the core bootstraper (ie dynamically generate our suite.xml and >> namespace the registration of extension tests) ... but for now at least >> not having t

Re: [Wikitech-l] Some changes to $wgOut, $wgUser, Skin, and SpecialPage code patterns

2011-04-04 Thread Platonides
I like it. Specially the Linker change. It really looks the way to have it. > I'm considering > making the Parser get it's linker via $po->getLinker(); (either > ParserOutput or ParserOptions, I need another look) The linker would be an input parameter, so it is a ParserOptions

Re: [Wikitech-l] HipHop

2011-04-04 Thread Platonides
Tim Starling wrote: > On 03/29/2011 10:48 AM, Platonides wrote: >> I was expecting this the week hip-hop hit. What would be required "to >> target hip-hop"? How does that differ from working from Zend? > > I've explored the issues and made some initial changes to my working > copy. I'm now waitin

[MediaWiki-CodeReview] [MediaWiki r85177]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85177. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85177#c15707 Comment: Passing a string doesn't work either -- the timezone parameter needs to be a DateTimeZone object. ___ Media

Re: [Wikitech-l] writing phpunit tests for extensions

2011-04-04 Thread Platonides
Michael Dale wrote: > Eventually it would be ideal to be able to 'just test your extension' > from the core bootstraper (ie dynamically generate our suite.xml and > namespace the registration of extension tests) ... but for now at least > not having to wait for all the core tests as you write you e

[MediaWiki-CodeReview] [MediaWiki r39635]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r39635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/39635#c15706 Comment: Better late than never? :P ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://l

[MediaWiki-CodeReview] [MediaWiki r39635]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Dantman" posted a comment on MediaWiki.r39635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/39635#c15705 Comment: @_@ I'm being told this 3 years later? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia

[MediaWiki-CodeReview] [MediaWiki r39635]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r39635. Old Status: ok New Status: fixme User "Reedy" also posted a comment on MediaWiki.r39635. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/39635#c15704 Comment: Line 251 now in trunk has an undefined $name usage ___

[MediaWiki-CodeReview] [MediaWiki r85376]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r85376. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85376#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wik

[MediaWiki-CodeReview] [MediaWiki r85373]: New comment added

2011-04-04 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r85373. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85373#c15703 Comment: Did you check it first? If so, you should bump the version in the README. ___ MediaWiki-CodeReview mailing list me

[MediaWiki-CodeReview] [MediaWiki r85317]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r85317. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85317#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://list

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Platonides" changed the status of MediaWiki.r85302. Old Status: new New Status: fixme User "Platonides" also posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15702 Comment: parserTests.php creates a new OutputPage. _

[MediaWiki-CodeReview] [MediaWiki r85361]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r85361. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85361#c15701 Comment: [[wikipedia:Byte order mark]] - and PHP doesn't like it. ___ MediaWiki-CodeReview mailing list mediawiki-coder

[MediaWiki-CodeReview] [MediaWiki r85361]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Mdale" posted a comment on MediaWiki.r85361. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85361#c15700 Comment: not intentionally... What is BOM? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org ht

[MediaWiki-CodeReview] [MediaWiki r85361]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r85361. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85361#c15699 Comment: Did you add or remove BOM in trunk/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php? ___ MediaWiki-C

[MediaWiki-CodeReview] [MediaWiki r85048]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85048. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85048#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wiki

[MediaWiki-CodeReview] [MediaWiki r85328]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85328. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85328#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@list

[MediaWiki-CodeReview] [MediaWiki r85276]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85276. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85276#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wiki

[MediaWiki-CodeReview] [MediaWiki r84637]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r84637. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84637#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@list

[MediaWiki-CodeReview] [MediaWiki r85144]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85144. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85144#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wiki

[MediaWiki-CodeReview] [MediaWiki r84627]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r84627. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84627#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@list

[MediaWiki-CodeReview] [MediaWiki r85177]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85177. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85177#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://

[MediaWiki-CodeReview] [MediaWiki r84929]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r84929. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84929#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wiki

[MediaWiki-CodeReview] [MediaWiki r85358]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85358. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85358#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wi

[MediaWiki-CodeReview] [MediaWiki r85232]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Nikola Smolenski" posted a comment on MediaWiki.r85232. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85232#c15698 Comment: Hey, it actually works :) I reverted this revision in r85356, however in order to simulate [edit] links I had to make an addition to SkinTemplate::

Re: [Wikitech-l] HipHop

2011-04-04 Thread Inez Korczynski
Hi Tim, I have no problem running foo.php and test.php that you sent in hphpi, but also it compiles and run without any problems with hphp. What command exactly do you use to compile and then execute? Inez On Sun, Apr 3, 2011 at 5:38 PM, Tim Starling wrote: > On 03/29/2011 10:48 AM, Platonides

Re: [Wikitech-l] Focus on sister projects

2011-04-04 Thread Magnus Manske
Ah, sorry, realized what you mean a second after sending... On Mon, Apr 4, 2011 at 7:07 PM, Magnus Manske wrote: > http://www.mediawiki.org/wiki/WYSIFTW ;-) > > > On Mon, Apr 4, 2011 at 6:09 PM, Ryan Kaldari wrote: >> Maybe my brain just made a leap here, but is there a plan for >> implementing

Re: [Wikitech-l] Focus on sister projects

2011-04-04 Thread Magnus Manske
http://www.mediawiki.org/wiki/WYSIFTW ;-) On Mon, Apr 4, 2011 at 6:09 PM, Ryan Kaldari wrote: > Maybe my brain just made a leap here, but is there a plan for > implementing a web-based Javascript editor for MediaWiki?? This would be > a hugely awesome feature. I've used jsFiddle (http://jsfiddle

[Wikitech-l] writing phpunit tests for extensions

2011-04-04 Thread Michael Dale
I had a bit of a documentation challenge approaching the problem of writing phpunit test for extensions, mostly because many of the extensions do this very differently and the manual did not have any recommendations. It appears many extension have custom bootstraping code ( somewhat hacky path dis

[MediaWiki-CodeReview] [MediaWiki r79108]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Platonides" posted a comment on MediaWiki.r79108. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79108#c15697 Comment: Works for me. How is Wiki::restInPeace() getting called for you? ___ MediaWiki-CodeReview mailing list mediawi

[MediaWiki-CodeReview] [MediaWiki r85151]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85151. Old Status: fixme New Status: new User "^demon" also posted a comment on MediaWiki.r85151. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85151#c15696 Comment: Yay for followups :D __

Re: [Wikitech-l] Focus on sister projects

2011-04-04 Thread Michael Dale
Also see the freebase / google acre system inline editor: http://wiki.freebase.com/wiki/Acre What is more impressive than the online editor, is the template and integrated data query system in an seamless sandboxed server / client javascript system. Its not perfect, but definitely includes some id

[MediaWiki-CodeReview] [MediaWiki r83080]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tbleher" posted a comment on MediaWiki.r83080. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83080#c15695 Comment: This change breaks the CommentBox extension, which has a special page to add comments to pages. The special page creates a FauxRequest which it submits to t

[MediaWiki-CodeReview] [MediaWiki r85080]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85080. Old Status: fixme New Status: new User "^demon" also posted a comment on MediaWiki.r85080. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85080#c15694 Comment: All the concerns here have been addressed -> new. _

[MediaWiki-CodeReview] [MediaWiki r85080]: New comment added

2011-04-04 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r85080. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85080#c15693 Comment: Grabbed the ones mentioned in this rev, see r85343 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@list

Re: [Wikitech-l] Focus on sister projects

2011-04-04 Thread Ryan Kaldari
Maybe my brain just made a leap here, but is there a plan for implementing a web-based Javascript editor for MediaWiki?? This would be a hugely awesome feature. I've used jsFiddle (http://jsfiddle.net/) which is really slick - syntax color-coding, tabbing that works, a Tidy button(!), integrate

[MediaWiki-CodeReview] [MediaWiki r85211]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85211. Old Status: fixme New Status: new User "^demon" also posted a comment on MediaWiki.r85211. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85211#c15692 Comment: Merged the first 3. The last two look merged to me, The regexes

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Happy-melon" changed the status of MediaWiki.r85302. Old Status: fixme New Status: new User "Happy-melon" also posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15691 Comment: Heaven knows :D Should be fixed in r85332 though. __

Re: [Wikitech-l] Future: Love for the sister projects!

2011-04-04 Thread Billinghurst
On 3 Apr 2011 at 10:56, Brion Vibber wrote: > (Breaking this out from 'Focus on sister projects' thread.) > > I just want to give an official shout out, as Lead Software Architect for > the Wikimedia Foundation, that Wikipedia's sister projects are important and > that they need more love. Not on

[MediaWiki-CodeReview] [MediaWiki r85327]: Revision status changed

2011-04-04 Thread MediaWiki Mail
User "Reedy" changed the status of MediaWiki.r85327. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.

[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r85302. Old Status: new New Status: fixme User "Raymond" also posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c15690 Comment: I am unsure if this revision is the right culprit for this fat

Re: [Wikitech-l] Focus on sister projects

2011-04-04 Thread Billinghurst
On 2 Apr 2011 at 16:08, Ryan Kaldari wrote: > What do you guys think would be more useful: > > 1. Helping sister projects write up proposals for the Berlin Hackathon If it is going to get selected and have outcome for my favourite wiki, then yes ;-) > 2. Creating "The Complete Idiot's Guide to

[MediaWiki-CodeReview] [MediaWiki r85327]: New comment added, and revision status changed

2011-04-04 Thread MediaWiki Mail
User "Raymond" changed the status of MediaWiki.r85327. Old Status: new New Status: fixme User "Raymond" also posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c15689 Comment: Seen on Translatewiki and on my local wiki: Warning: require_

Re: [Wikitech-l] Actions and Special Pages

2011-04-04 Thread Aryeh Gregor
On Mon, Apr 4, 2011 at 9:28 AM, Happy-melon wrote: > If people think it would be > better as a special page we'd make > http://foo.example.com/w/index.php?title=Bar&action=edit a hard redirect to > Special:Edit/Bar; that has the significant advantage of being able to be > formed as an internal lin

Re: [Wikitech-l] Actions and Special Pages

2011-04-04 Thread Tim Starling
On 04/04/2011 11:28 PM, Happy-melon wrote: > For either case in the backend I would think we'd want to create an > ActionPage base class and an EditActionPage from that, which looks > internally rather like a SpecialPage construct, might even subclass it. We had this discussion in January. That's

[Wikitech-l] Actions and Special Pages

2011-04-04 Thread Happy-melon
In the beginning, there was Article.php. And the Article class had methods like Article::view(), Article::delete(), Article::protect(), etc. And the fundamental codeflow of Mediawiki consisted of something along the lines of: $article = new Article( $title ); $action = wfGetTheActionSomehow();

[MediaWiki-CodeReview] [MediaWiki r79108]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r79108. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79108#c15688 Comment: I get Running test Interlanguage link, with prefix links... A database error has occurred. Did you forget to run maintenance/update.php after upgrad

[MediaWiki-CodeReview] [MediaWiki r85296]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Siebrand" posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15687 Comment: Isn't it good practice to support this without warnings for at least one release (1.18), have it whine the next release (1.19), and remove it in the 3rd (1

[MediaWiki-CodeReview] [MediaWiki r85296]: New comment added

2011-04-04 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c15686 Comment: You sure didn't give a lot of time to fix this... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@l