My house is being rewired, so Patchwatcher is offline
for a day.
Patchwatcher is down for the moment - I mistakenly
tried using proprietary nvidia drivers, forgetting
that my nvidia card is too old to be supported,
and don't have time this morning to recover.
I'll fix it tonight.
On Thu, 2008-11-06 at 09:29 -0800, Dan Kegel wrote:
>
> Would you settle for static alternating colors?
> I'm kind of anti hover highlight.
IIRC there was a recent study claiming that alternating
row colors are not all that useful in practice, the on-hover
has the advantage of focusing your att
On Thu, Nov 6, 2008 at 9:07 AM, Dimi Paun <[EMAIL PROTECTED]> wrote:
> One suggestion that I have is changing the background color
> of the row on hover so you can easily match the result on the
> RHS to the Subject, right now that is a bit difficult to
> do visually on a wide-screen monitor.
Woul
On Thu, 2008-11-06 at 08:32 -0800, Dan Kegel wrote:
> You should see your patch appear at
> http://kegel.com/wine/patchwatcher/results
Very nice!
One suggestion that I have is changing the background color
of the row on hover so you can easily match the result on the
RHS to the Subject, right
Patchwatcher is now working well enough to
depend on, I think, but doesn't send email yet.
You should see your patch appear at
http://kegel.com/wine/patchwatcher/results
under a minute after you post, and if
your patch is simple, test results should
show up about ten minutes later.
(Long patch ser
The new patchwatcher is sort of up; I'm focusing
on things like getting the load balancing
and blacklist right before I even think about
email output. You can look at the results at
http://kegel.com/wine/patchwatcher/results2/
but they will probably not be very reliable for
a few more days.
(And
Let me know if these updates get annoying.
I'm bringing up a three-node patchwatcher cluster
(master plus two build slaves), and updating
http://winezeug.googlecode.com/svn/trunk/patchwatcher/readme.txt
as I go.
It's coming along ok, but it'll probably be another few
days before it's up.
- Dan
I'm taking the patchwatcher machines down to upgrade them
to Intrepid Ibex this weekend.
Incidentally, a jaguar plowed through the corner of
our garage here at home. For a short while it
was a 2.1 car garage :-) I may be somewhat
distracted until that's dealt with somehow.
- Dan
On Thu, 4 Sep 2008 09:45:52 -0700
"Dan Kegel" <[EMAIL PROTECTED]> wrote:
> The new machine has a fairly modern nvidia card, so
> more of the tests are actually run.
Where can I find the spec of the new machine ?
Are you using the closed source driver ?
I want to see the full system spec hardware
Both old and new patchwatcher:
- fixed the displayed time of patches on the results web page.
New patchwatcher:
- for some reason it wasn't looking for all the errors the old one did. Fixed.
- for some reason I had forgotten to have it actually watch for new
commits in git. Fixed.
- Better at lo
Blacklisted wininet:http.c because it relies on winehq.org being up
and serving php properly :-)
Fixed enough problems with the new
patchwatcher that it seems to be running
tests properly.
You can see the new patchwatcher's results at
http://kegel.com/wine/patchwatcher/results2/
The results should
On Sun, Oct 26, 2008 at 8:56 PM, Dmitry Timoshkov
<[EMAIL PROTECTED]> wrote:
>> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716
>> more and more often. We really need to set up mock
>> servers so test cases don't need to rely on the public
>> internet.
>
> If a test fails due to mis
From: "Dan Kegel" <[EMAIL PROTECTED]> wrote:
> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716
> more and more often. We really need to set up mock
> servers so test cases don't need to rely on the public
> internet.
If a test fails due to missing internet access that's a bug
in t
Kai wrote:
> Dan Kegel <[EMAIL PROTECTED]> wrote:
>> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716
>> more and more often. We really need to set up mock
>> servers so test cases don't need to rely on the public
>> internet.
>
> Samba has a socket wrapper library that fakes network
Dan Kegel wrote:
> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716
> more and more often. We really need to set up mock
> servers so test cases don't need to rely on the public
> internet.
>
> I'm slowly bringing up a second patchwatcher using
> the newly refactored code. I even wr
On Sunday 26 October 2008 23:00:51 Dan Kegel wrote:
> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716
> more and more often. We really need to set up mock
> servers so test cases don't need to rely on the public
> internet.
Samba has a socket wrapper library that fakes network acce
I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716
more and more often. We really need to set up mock
servers so test cases don't need to rely on the public
internet.
I'm slowly bringing up a second patchwatcher using
the newly refactored code. I even wrote some documentation
on how
The blacklist has grown a bit, adding
d3d8:visual.c
winhttp:Timeout...Killing.child
wldap32:parse.c
wldap32/tests/__test__
Rob has been busy helping get the distributed patchwatcher
scripts working. He has a msvc9 build slave coming along
nicely(!).
I've ordered a second computer to use as a
The most pressing issue for patchwatcher is
to finish the refactoring into libpatchwatcher.sh and wine-slave.sh.
I made a tiny bit of progress there today by
applying some typo fixes Rob sent me, and
adding the missing timeout enforcement
that was already in the monolithic patchwatcher.
(Checked in
These tests failed randomly for a few people:
urlmon:url.c:2125: Test succeeded inside todo block: unexpected
OnProgress_CONNECTING
urlmon:url.c:2129: Test failed: expected OnProgress_SENDINGREQUEST
urlmon:url.c:2131: Test failed: expected OnResponse
urlmon:protocol.c:1597: Test failed: Read faile
On Thu, Sep 4, 2008 at 10:39 AM, Paul Vriens <[EMAIL PROTECTED]> wrote:
> Are there any changes compared to the email notification a week ago?
>
> I've received several emails about a failure with my patches but it turns
> out they were marked as "ignore" or "Patch already in git.". I'm not sure I
Dan Kegel wrote:
> Patchwatcher is almost recovered from its move
> to the new machine. I expect to turn email
> notifications back on tomorrow.
>
Hi Dan,
Are there any changes compared to the email notification a week ago?
I've received several emails about a failure with my patches but it t
On Fri, Sep 5, 2008 at 2:45 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> Patchwatcher is almost recovered from its move
> to the new machine. I expect to turn email
> notifications back on tomorrow.
>
> The old machine could only just barely keep up with
> the patch flow. The new machine is two or
Patchwatcher is almost recovered from its move
to the new machine. I expect to turn email
notifications back on tomorrow.
The old machine could only just barely keep up with
the patch flow. The new machine is two or so times
faster, so it's much, much better at catching up
when a patch flood hi
On Monday 25 August 2008 23:58:17 Scott Ritchie wrote:
> James Hawkins wrote:
> > On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
> >> Something else... I sometimes reply to patches, and right now that
> >> seems to cause patchwatcher to complain that my mail doesn't conta
Dan Kegel wrote:
> On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <[EMAIL PROTECTED]> wrote:
>
#patchwatcher approve
Such a directive would only be recognized if it's alone on a line.
>>> The usual positive reply is 'ACK'. I believe it would be simplest to
>>> grep the r
On Mon, Aug 25, 2008 at 4:58 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote:
> James Hawkins wrote:
>> On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
>>> Something else... I sometimes reply to patches, and right now that
>>> seems to cause patchwatcher to complain that my ma
James Hawkins wrote:
> On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
>> Something else... I sometimes reply to patches, and right now that
>> seems to cause patchwatcher to complain that my mail doesn't contain a
>> patch. Would it be possible to do something about that?
On Monday 25 August 2008 23:20:40 Dan Kegel wrote:
> Around where I work, LGTM (looks good to me) is the reply that
> denotes approval. And then there's the Apache convention of +1.
> Anyway, I'll recognize one or more of those if and when I get around
> to adding a wine-devel listener. Might b
On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <[EMAIL PROTECTED]> wrote:
>> > #patchwatcher approve
>> >
>> > Such a directive would only be recognized if it's alone on a line.
>>
>> The usual positive reply is 'ACK'. I believe it would be simplest to
>> grep the reply message for ACK to see if a repl
On Monday 25 August 2008 20:46:51 James Hawkins wrote:
> On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote:
> >
> > #patchwatcher approve
> >
> > Such a directive would only be recognized if it's alone on a line.
>
> The usual positive reply is 'ACK'. I believe it would be si
On Mon, Aug 25, 2008 at 2:46 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
> On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote:
>> On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote:
>>
>>> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>>>
On Mon, Aug 25, 2008 at 8:47 AM, Ale
On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote:
> On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote:
>
>> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>>
>>> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard
>>> <[EMAIL PROTECTED]> wrote:
patchwatcher should watch for
On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote:
> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>
>> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard
>> <[EMAIL PROTECTED]> wrote:
>>> patchwatcher should watch for replies on wine-devel, and
>>> link the reply to the patch
>>
>> Yes. The ot
"Dan Kegel" <[EMAIL PROTECTED]> writes:
> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
>> patchwatcher should watch for replies on wine-devel, and
>> link the reply to the patch
>
> Yes. The other similar patchwatching systems I found do this,
> and ours should,
On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote:
> patchwatcher should watch for replies on wine-devel, and
> link the reply to the patch
Yes. The other similar patchwatching systems I found do this,
and ours should, too.
> and mark the patch as needing further act
Alexandre Julliard wrote:
> Kai Blin <[EMAIL PROTECTED]> writes:
>
>> On Monday 25 August 2008 00:06:29 Henri Verbeet wrote:
>>> Something else... I sometimes reply to patches, and right now that
>>> seems to cause patchwatcher to complain that my mail doesn't contain a
>>> patch. Would it be poss
Kai Blin <[EMAIL PROTECTED]> writes:
> On Monday 25 August 2008 00:06:29 Henri Verbeet wrote:
>> Something else... I sometimes reply to patches, and right now that
>> seems to cause patchwatcher to complain that my mail doesn't contain a
>> patch. Would it be possible to do something about that?
>
On Monday 25 August 2008 00:06:29 Henri Verbeet wrote:
> Something else... I sometimes reply to patches, and right now that
> seems to cause patchwatcher to complain that my mail doesn't contain a
> patch. Would it be possible to do something about that?
I've got to agree with James on that one. R
On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
> Something else... I sometimes reply to patches, and right now that
> seems to cause patchwatcher to complain that my mail doesn't contain a
> patch. Would it be possible to do something about that? I suppose
> patchwatcher
Something else... I sometimes reply to patches, and right now that
seems to cause patchwatcher to complain that my mail doesn't contain a
patch. Would it be possible to do something about that? I suppose
patchwatcher could ignore replies without patch.
2008/8/24 Dan Kegel <[EMAIL PROTECTED]>:
> On Sun, Aug 24, 2008 at 9:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
>> The script now forwards patches that pass all tests to the mailing list
>> http://groups.google.com/group/wine-patches-filtered
>> so potentially Alexandre could start looking only at
On Sun, Aug 24, 2008 at 9:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> The script now forwards patches that pass all tests to the mailing list
> http://groups.google.com/group/wine-patches-filtered
> so potentially Alexandre could start looking only at that
> list
Hmm. At the moment, patchwatche
Patchwatcher now regenerates configure and makefiles
after each patch, so it can handle patches that change
configure.ac.
I have enabled email notification to authors of patches
that don't build.
The script now forwards patches that pass all tests to the mailing list
http://groups.google.com/grou
I think I fixed the charset munging, so patches of non-english stretches
of code should work now.
That was the last big source of false failure reports, so
I'm going to enable email notification to people whose patches fail.
I'll probably clear the results page tonight to get rid of
all the bogus
Dan Kegel wrote:
> On Tue, Aug 19, 2008 at 1:35 AM, Paul Vriens <[EMAIL PROTECTED]> wrote:
>> Looks like there is something (else?) wrong with checking the patch series.
>>
>> None of the last patch series (by Juan, James, Rob, Stefan to name a few)
>> are shown on the results page.
>
> Thanks for
On Tue, Aug 19, 2008 at 1:35 AM, Paul Vriens <[EMAIL PROTECTED]> wrote:
> Looks like there is something (else?) wrong with checking the patch series.
>
> None of the last patch series (by Juan, James, Rob, Stefan to name a few)
> are shown on the results page.
Thanks for pointing that out.
It got
Dan Kegel wrote:
> Patchwatcher falsely complained that
> [2/17] richedit: Removed assumption about the order of rtf indent
> didn't apply because the regexp I used to detect
> the end of a patch series falsely matched the
> first patch in a series of 1x patches. Here's the fix:
>
> --- patchwat
On Thursday 14 August 2008 16:38:40 Dan Kegel wrote:
> What to do, what to do... how about this: are there any python users
> on the list who would be willing to help adapt buildbot to our needs?
I've subscribed to the buildbot list as well, and I'll start looking over the
code once I figured ou
Patchwatcher falsely complained that
[2/17] richedit: Removed assumption about the order of rtf indent
didn't apply because the regexp I used to detect
the end of a patch series falsely matched the
first patch in a series of 1x patches. Here's the fix:
--- patchwatcher.sh (revision 150)
+++
On Thu, Aug 14, 2008 at 7:37 AM, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> You mentioned sporadic test failures in the d3d9:visual and ddraw:visual
> tests earlier, but I did not have time to look at it back then. Can you send
> me logs of the failures and successes?
>
> I am afraid that the d3d
On Thu, Aug 14, 2008 at 2:49 AM, Darragh Bailey
<[EMAIL PROTECTED]> wrote:
> I currently use buildbot at work for managing builds, and it looks like
> that it could handle many of your tasks if patchwatcher could be
> integrated into it.
Good idea. Even Mozilla, home of http://www.mozilla.org/tin
> Patchwatcher is online and giving reasonably good
> feedback on the patch stream. The bug that caused
> every patch to be marked 'failed tests' is fixed, and
> the blacklist is expanded enough that false regressions
> seem to be rare.
You mentioned sporadic test failures in the d3d9:visual and d
Have you considered using some of the tools out there for automated
builds and looking to integrate patchwatcher to extend them to suit your
purpose.
A number of the features you suggest below are most likely already
implemented within existing automated builds.
I currently use buildbot at work f
Patchwatcher is online and giving reasonably good
feedback on the patch stream. The bug that caused
every patch to be marked 'failed tests' is fixed, and
the blacklist is expanded enough that false regressions
seem to be rare.
There are still bugs:
1. the dashboard shows no status column for
http
56 matches
Mail list logo
