Re: [PATCH] Basic WINGs theming

2013-11-05 Thread Rodolfo García Peñas (kix)
Hi, You are doing a very good job with window maker. Testing patches, trying new things and of course, the git management. Is a hard work and you are always ready to do it. I only can say, thanks a lot. However, I cannot understand your logic about don't include some patches and the way to do

Re: [PATCH] Basic WINGs theming

2013-11-05 Thread Carlos R. Mafra
On Tue, 5 Nov 2013 at 20:41:40 +0100, Rodolfo García Peñas (kix) wrote: Hi, You are doing a very good job with window maker. Testing patches, trying new things and of course, the git management. Is a hard work and you are always ready to do it. I only can say, thanks a lot. However, I

RE: [PATCH] Basic WINGs theming

2013-11-05 Thread Torrance, Douglas
-Original Message- From: Carlos R. Mafra [mailto:crma...@gmail.com] It's been only a day or two since the patch and I'm still thinking and hoping to read more convincing arguments. It would help if the patch included an entry in the NEWS file to teach people about it (including the

Re: [PATCH] Basic WINGs theming

2013-11-05 Thread Rodolfo García Peñas (kix)
On 05/11/2013 21:57, Carlos R. Mafra wrote: On Tue, 5 Nov 2013 at 20:41:40 +0100, Rodolfo García Peñas (kix) wrote: Hi, You are doing a very good job with window maker. Testing patches, trying new things and of course, the git management. Is a hard work and you are always ready to do it. I

Re: [PATCH 0/4] Fixes for Image Format detection

2013-11-05 Thread Christophe
- Carlos R. Mafra crma...@gmail.com a écrit : On Mon, 4 Nov 2013 at 20:52:27 +0100, Christophe wrote: From: Christophe CURIS christophe.cu...@free.fr Hello, Following the reported by Amadeusz, I had a deeper look, so I am proposing new version for the 4 patches: - patch 1

Re: [PATCH] Basic WINGs theming

2013-11-05 Thread SJS
begin quoting Carlos R. Mafra as of Tue, Nov 05, 2013 at 06:57:53PM -0200: [snip] I try to be reasonable in my decisions, but I prefer to err on the conservative rather than the accept all patches side. A prudent gatekeeper is a good thing. Every patch submission deserves a response, but

Re: [PATCH] Basic WINGs theming

2013-11-05 Thread SJS
begin quoting Rodolfo García Peñas (kix) as of Tue, Nov 05, 2013 at 11:32:08PM +0100: On 05/11/2013 21:57, Carlos R. Mafra wrote: [snip] It's been only a day or two since the patch and I'm still thinking and hoping to read more convincing arguments. It would help if the patch included an

Re: [PATCH] Basic WINGs theming

2013-11-05 Thread Christophe
Hi, Although I do like the idea brought by the patch, there are a few things in this implementation that I would suggest to do differently: - Doug Torrance dtorra...@monmouthcollege.edu a écrit : [...] diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs/WINGs.h index 0104e03..ff9eaef