[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-10 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199472#comment-16199472 ] Jian He commented on YARN-7202: --- bq. After discussion with Jian, we agree to revert back to P

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-10 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199443#comment-16199443 ] Jian He commented on YARN-7202: --- bq. This is the reason that MiniHDFSCluster and MiniYARNClus

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-10 Thread Billie Rinaldi (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199438#comment-16199438 ] Billie Rinaldi commented on YARN-7202: -- Instead of the patch 08 changes to updateServi

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-10 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198976#comment-16198976 ] Eric Yang commented on YARN-7202: - [~jianhe] wrote: {code} Confused. I'm seeing the opposit

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-10 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198881#comment-16198881 ] Eric Yang commented on YARN-7202: - [~jianhe] I took another look at the code from patch 08,

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198013#comment-16198013 ] Hadoop QA commented on YARN-7202: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-09 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198012#comment-16198012 ] Eric Yang commented on YARN-7202: - [~jianhe] PUT method throws YarnException for both Servi

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197999#comment-16197999 ] Hadoop QA commented on YARN-7202: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197860#comment-16197860 ] Jian He commented on YARN-7202: --- confused, isn't this code not part of this patch ? I did cle

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-09 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197669#comment-16197669 ] Eric Yang commented on YARN-7202: - [~jianhe] Thank you for the review. The new code enable

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-09 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197421#comment-16197421 ] Jian He commented on YARN-7202: --- bq. If Service config changed, save configuration. bq. If S

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-08 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196544#comment-16196544 ] Eric Yang commented on YARN-7202: - [~jianhe] ServiceClient code is partially completed in Y

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-08 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196338#comment-16196338 ] Jian He commented on YARN-7202: --- Thanks for the patch, few comments: - STARTED and STOP

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194957#comment-16194957 ] Hadoop QA commented on YARN-7202: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192146#comment-16192146 ] Hadoop QA commented on YARN-7202: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191835#comment-16191835 ] Hadoop QA commented on YARN-7202: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190594#comment-16190594 ] Hadoop QA commented on YARN-7202: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190567#comment-16190567 ] Hadoop QA commented on YARN-7202: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-10-02 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188942#comment-16188942 ] Eric Yang commented on YARN-7202: - TestYarnNativeServices and TestApiServer combination pro

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-28 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184996#comment-16184996 ] Jian He commented on YARN-7202: --- oh, ok, didn't know we can still re-open it. > End-to-end

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-28 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184914#comment-16184914 ] Eric Yang commented on YARN-7202: - [~jianhe] I am able to re-open HADOOP-9122. I can move

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-28 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184881#comment-16184881 ] Jian He commented on YARN-7202: --- Once the issue is closed, it cannot be reopened. If the issu

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-28 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184870#comment-16184870 ] Eric Yang commented on YARN-7202: - [~jianhe] Sure, I will add to javadoc to indicate the pu

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-28 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184648#comment-16184648 ] Jian He commented on YARN-7202: --- could you also add the comments in your first comment of thi

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-28 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184640#comment-16184640 ] Jian He commented on YARN-7202: --- bq. If both mocked version of ServiceClient, and ApiServer

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-27 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182886#comment-16182886 ] Eric Yang commented on YARN-7202: - [~jianhe] In the example that you provided, it is showin

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-26 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181778#comment-16181778 ] Jian He commented on YARN-7202: --- I'm just worried some ended up testing the ServiceClientForT

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-26 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181706#comment-16181706 ] Eric Yang commented on YARN-7202: - [~jianhe] The test case are designed to be unit tests fo

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-26 Thread Jian He (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181680#comment-16181680 ] Jian He commented on YARN-7202: --- [~eyang], thanks for working on the patch. I looked at the p

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181567#comment-16181567 ] Hadoop QA commented on YARN-7202: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |

[jira] [Commented] (YARN-7202) End-to-end UT for api-server

2017-09-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181251#comment-16181251 ] Hadoop QA commented on YARN-7202: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote |