Re: Small improvements to run_spec_clang_asan.sh
Done.
On Wed, Oct 1, 2014 at 8:18 PM, Yuri Gribov tetra2...@gmail.com wrote:
Cool! Could someone apply this then?
On Wed, Oct 1, 2014 at 2:18 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
Sorry, my bad, missed the $ sign.
On Wed, Oct 1, 2014 at 2:03 PM, Yuri Gribov tetra2...@gmail.com wrote:
On Wed, Oct 1, 2014 at 1:56 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')}
What if there is more than one gcc in the compiler path?
Sorry, don't understand... I'm just replacing trailing gcc with g++ so
e.g. path/to/my/cross-gcc becomes path/to/my/cross-g++.
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Small improvements to run_spec_clang_asan.sh
CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')}
What if there is more than one gcc in the compiler path?
Otherwise LGTM.
On Wed, Oct 1, 2014 at 1:35 PM, Yuri Gribov tetra2...@gmail.com wrote:
On Fri, Sep 19, 2014 at 11:13 PM, Yuri Gribov tetra2...@gmail.com wrote:
Will test and resend on Monday.
Ok, I've fallen ill and then completely forgot about this. Here's an
updated version.
CLANG=${CLANG:-clang}
You probably need the same for CLANGXX
I'm doing this below depending on whether CLANG is really clang or gcc.
Why are you disabling leak detection? It is on by default, which means
you are benchmarking not the same thing that users run.
At least make it an option.
I've kept the detect_leaks=0 because as kcc mentioned lots of tests
have leaks. If you desperately want this cluttered stderr you can
remove the detect_leaks=0 part from final patch (or I can do it
myself).
I don't understand this LD_LIBRARY_PATH magic, what's its for?
Fixed. This now allows user to override default script's ASAN_OPTIONS.
@Evgeniy: you can just remove detect_leaks=0 if you desperately want
this stderr clutter in runner's output.
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Small improvements to run_spec_clang_asan.sh
Sorry, my bad, missed the $ sign.
On Wed, Oct 1, 2014 at 2:03 PM, Yuri Gribov tetra2...@gmail.com wrote:
On Wed, Oct 1, 2014 at 1:56 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')}
What if there is more than one gcc in the compiler path?
Sorry, don't understand... I'm just replacing trailing gcc with g++ so
e.g. path/to/my/cross-gcc becomes path/to/my/cross-g++.
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Small improvements to run_spec_clang_asan.sh
Cool! Could someone apply this then?
On Wed, Oct 1, 2014 at 2:18 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
Sorry, my bad, missed the $ sign.
On Wed, Oct 1, 2014 at 2:03 PM, Yuri Gribov tetra2...@gmail.com wrote:
On Wed, Oct 1, 2014 at 1:56 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
CLANGXX=${CLANGXX:-$(echo $CLANG | sed -e 's/gcc$/g++/')}
What if there is more than one gcc in the compiler path?
Sorry, don't understand... I'm just replacing trailing gcc with g++ so
e.g. path/to/my/cross-gcc becomes path/to/my/cross-g++.
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Small improvements to run_spec_clang_asan.sh
On Fri, Sep 19, 2014 at 5:13 AM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
CLANG=${CLANG:-clang}
You probably need the same for CLANGXX
Why are you disabling leak detection? It is on by default, which means
you are benchmarking not the same thing that users run.
At least make it an option.
i disable lsan in my local copy of this script because there are leaks
in several benchmarks :)
I don't understand this LD_LIBRARY_PATH magic, what's its for?
On Fri, Sep 19, 2014 at 3:26 PM, Alexander Potapenko gli...@google.com
wrote:
CC kcc, eugenis
On Thu, Sep 18, 2014 at 7:25 PM, Yuri Gribov tetra2...@gmail.com wrote:
Hi all,
Here is a small patch for
https://code.google.com/p/address-sanitizer/source/browse/trunk/spec/run_spec_clang_asan.sh
which
* updates docs
* adds some option verification
* adds GCC support
* disables leak detection
Does the change look sane?
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Alexander Potapenko
Software Engineer
Google Moscow
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an
email to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Small improvements to run_spec_clang_asan.sh
On Fri, Sep 19, 2014 at 4:13 PM, 'Evgeniy Stepanov' via
address-sanitizer address-sanitizer@googlegroups.com wrote:
CLANG=${CLANG:-clang}
You probably need the same for CLANGXX
I do this in the next block (autodetection is different clang and gcc
are different).
Why are you disabling leak detection? It is on by default, which means
you are benchmarking not the same thing that users run.
At least make it an option.
As Kostya mentioned there are numerous leaks in benchmarks which make
analysis harder. I can remove it if necessary.
I don't understand this LD_LIBRARY_PATH magic, what's its for?
Snap, believe it or not but that's a typo. It should be ASAN_OPTIONS
and the weird expression optionally inserts : in front of added
options (so that user can provide his own ASAN_OPTIONS).
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: Small improvements to run_spec_clang_asan.sh
On Fri, Sep 19, 2014 at 9:02 PM, Yuri Gribov tetra2...@gmail.com wrote:
I don't understand this LD_LIBRARY_PATH magic, what's its for?
Snap, believe it or not but that's a typo. It should be ASAN_OPTIONS
and the weird expression optionally inserts : in front of added
options (so that user can provide his own ASAN_OPTIONS).
I meant to say
export
ASAN_OPTIONS=alloc_dealloc_mismatch=0:detect_leaks=0${ASAN_OPTIONS:+:$ASAN_OPTIONS}
Will test and resend on Monday.
-Y
--
You received this message because you are subscribed to the Google Groups
address-sanitizer group.
To unsubscribe from this group and stop receiving emails from it, send an email
to address-sanitizer+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
