[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User mba changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Mon Feb 5 13:34:12 + 2007 --- closing ancient issues - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User aziem changed the following: What|Old value |New value CC|'joergwartenberg,sb,utomo9|'aziem,joergwartenberg,sb, |9'|utomo99' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User mmeeks changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Wed Jan 17 07:54:13 -0800 2007 --- committed to CWS filtershrink, based on as' approval in comment 7. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User mmeeks changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Wed Jan 17 08:11:42 -0800 2007 --- builds nicely has been running nicely in 2.0.4 for us forever (in my day-to-day OO.o for months) = verified. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Tue Jan 16 05:54:37 -0800 2007 --- As we are still waiting for the unit tests I don't see how we can get this CWS ready for QA until end of this week. So barring miracles I will change the target to 2.3 end of this week. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Tue Jan 16 06:04:32 -0800 2007 --- In fact unit tests have been written, and (as expected since the patch is remarkably simple) pass with no problems. [ sent by private mail to Stefan ]. The problem is that they use some ancient, ugly (but actually functional) unit testing framework [ as opposed, to the new, trendy, (undocumented), and (apparently) non-functional-out-of-the-box new unit testing framework ]. Thankfully someone kindly sent me the non-public docs on writing C++ unit tests and I need to dive into this morass and work out why there is such compound brokenness here; first to get the unit testing framework actually working for me, and then (of course) to re-write the tests to use it. But as yet I have not found the time or inclination. Why, oh why - can I not just type $ build test or better $ test and get a simple yes/no answer that works reliably, requires no extra installation / download / build / documentation foo ? The casual writing of unit testage IMHO is severely impeeded by the mess here :-) Anyhow - it's good to vent some spleen; it's a curious decision not to take the change IMHO, it's obviously correct and saves a noticable chunk of memory. Utomo: your PDF is not relevant to this and just burns a chunk of space on the IZ server. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Tue Jan 16 07:13:28 -0800 2007 --- In fact unit tests have been written, and (as expected since the patch is remarkably simple) pass with no problems. [ sent by private mail to Stefan ]. The only such mail I can remember is for issue 72766 on CWS cppuhelpshrink. Are you mixing up issues? [And regarding issue 72766 and CWS cppuhelpshrink: Sorry, I did not interpret the private mail you sent me (and which I have discarded by now) as containing working unit tests (you asked a number of questions in that mail), so I did not run them and instead waited for you to come up with something working. That's why I set CWS cppuhelpshrink back to new and added a comment that I am waiting for unit tests.] - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Tue Jan 16 12:58:24 -0800 2007 --- sb: urgk - you're quite right ;-) I should at least rant in the right issue I guess. Apologies for the noise. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Mon Jan 8 02:01:13 -0800 2007 --- Michael, as we will have code freeze for 2.2 end of this month the time has come to decide about the target of this issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User utomo99 changed the following: What|Old value |New value Attachment data| |Created an attachment (id= | |41698) Investigation repor | |ts --- Additional comments from [EMAIL PROTECTED] Sun Dec 24 21:55:12 -0800 2006 --- Created an attachment (id=41698) Investigation reports - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Thu Dec 21 01:05:33 -0800 2006 --- Michael, if you wanted to have this in 2.2 the time it would be high time! :-) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Fri Nov 24 02:08:19 -0800 2006 --- utomo99 - you are most welcome to do the CWS work here, since it seems you have time. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User utomo99 changed the following: What|Old value |New value CC|'joergwartenberg,sb' |'joergwartenberg,sb,utomo9 | |9' Keywords| |oooqa Target milestone|--- |OOo 2.2 --- Additional comments from [EMAIL PROTECTED] Thu Nov 23 21:02:50 -0800 2006 --- michael, please see as comments: remove the fprintf() statement inside registration.cxx .-) After changing that you can check it into a cws. Thanks - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User as changed the following: What|Old value |New value Assigned to|as|mmeeks --- Additional comments from [EMAIL PROTECTED] Tue Sep 5 00:10:37 -0700 2006 --- AS-mmeeks: The patch seams to be OK for me ... excepting you remove the fprintf() statement inside registration.cxx .-) After changing that you can check it into a cws. Best Regards - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 --- Additional comments from [EMAIL PROTECTED] Wed Aug 30 05:00:02 -0700 2006 --- @mmeeks: is it really not possible Would not want to carry on that discussion in this issue, but if you think rtl/instance.hxx should be simplified, please file an issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User sb changed the following: What|Old value |New value CC|'joergwartenberg' |'joergwartenberg,sb' --- Additional comments from [EMAIL PROTECTED] Mon Aug 28 00:34:11 -0700 2006 --- The proposed patch makes the code unnecessarily complex, by lumping together definition and use of the various strings as PROPNAME_ macros using PROPNAME_IMPL_DECL macro to differentiate the two cases. Why not have as interface an enum of propname values together with an (inline) accessor function rtl::OUString getPropname(enum Propname), getting rid of all the macro stuff. Also, initialization should not use broken double checked locking pattern, but instead the rtl/instance.hxx stuff (and no fprintf logging). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=68929
--- Additional comments from [EMAIL PROTECTED] Mon Aug 28 12:00:30 -0700
2006 ---
Hi Stefan; so - sure, we don't use the (empty anyway) memory barrier macro, I
guess that is broken.
The dual definition / enumeration macro is common in cases where people need to
accurately maintain large lists of string/enum/attribute information, it's also
(presuambly) easy enough to understand. [ cf. eg. gcc for a ton of examples ].
Why not have as interface an enum of propname values together with an (inline)
accessor function rtl::OUString getPropname(enum Propname), getting rid of
all the macro stuff.
I just wanted to use what was there (macros), with some trivial changes. I have
to maintain a large patch set, you don't; sounds like a nice change though as it
goes up-stream.
Wrt. the double-check-locking pattern, I read the instance.hxx and concluded it
was an abomination of template driven evil, that *looks* like it does something
8x more inefficient than what is required; and (apparently) includes a load of
parameters that should be defaults:
T * getInstance()
{
return rtl_Instance T, Init, ::osl::MutexGuard,
::osl::GetGlobalMutex ::create(
Init(), ::osl::GetGlobalMutex());
}
If templates are so clever - why do we need to pass such a bunch of crud to them
? :-) Why can't we do:
PtrArray *getInstance()
{
return rtl_Instance PtrArray ;
}
I guess passing 5 other parameters, including a function etc. etc. is highly
flexible, but appears sufficiently unpleasant to have put me off :-) is it
really not possible to bin them, and/or use sensible defaults to make this
easier to read, adapt in future etc. ?
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User joergwartenberg changed the following: What|Old value |New value CC|''|'joergwartenberg' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User mba changed the following: What|Old value |New value Assigned to|mba |as --- Additional comments from [EMAIL PROTECTED] Fri Aug 25 06:43:17 -0700 2006 --- Andreas, please have a look. The discussion about the topic was done on the dev list, please ask if you have questions about it. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 Issue #|68929 Summary|shrink filter memory footprint Component|framework Version|680m182 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|mmeeks --- Additional comments from [EMAIL PROTECTED] Thu Aug 24 07:19:49 -0700 2006 --- as discusse on [EMAIL PROTECTED] - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[framework-issues] [Issue 68929] shrink filter memory footp rint
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=68929 User mmeeks changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |38753) patch --- Additional comments from [EMAIL PROTECTED] Thu Aug 24 07:20:08 -0700 2006 --- Created an attachment (id=38753) patch - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
