[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-08-17 Thread mgalmard
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User mgalmard changed the following:

What|Old value |New value

  CC|'amy2008,camillem,carlosrp|'amy2008,camillem,carlosrp
|,chengxz,eostapets,er,gaoz|,chengxz,eostapets,er,gaoz
|m,jodygoldberg,jpryor,kami|m,jodygoldberg,jpryor,kami
|_,khirano,kohei,kpalagin,l|_,khirano,kohei,kpalagin,l
|iutao,lvyue,maoyg,mh,mmeek|iutao,lvyue,maoyg,mgalmard
|s,muthusuba,pagalmes,pj,pm|,mh,mmeeks,muthusuba,pagal
|ike,renatoyamane,tbe,tuhar|mes,pj,pmike,renatoyamane,
|sky,utomo99'  |tbe,tuharsky,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-08-06 Thread amy2008
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User amy2008 changed the following:

What|Old value |New value

  Status|VERIFIED  |CLOSED





--- Additional comments from amy2...@openoffice.org Thu Aug  6 06:15:36 
+ 2009 ---
Verified in DEV300m54
Closing

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-08-05 Thread jes
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from j...@openoffice.org Wed Aug  5 20:55:51 + 
2009 ---
Testing DEV300_m54 on Fedora Linux 11:

New options are present in Data  Filter  Standard Filter  Condition:
 Contains/Does not contain
 Begins with/Does not begin with
 Ends with/Does not end with

Tested each singly and in some simple combinations.

All worked correctly.

Looks great--Thanks!

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-07-22 Thread oc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from o...@openoffice.org Wed Jul 22 11:15:01 + 
2009 ---
Created an attachment (id=63687)
TestCaseSpecification


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-07-22 Thread oc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from o...@openoffice.org Wed Jul 22 11:15:58 + 
2009 ---
Created an attachment (id=63688)
Testdocument for Test Case Specification


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-07-22 Thread oc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User oc changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from o...@openoffice.org Wed Jul 22 11:17:10 + 
2009 ---
verified in internal build cws_calc51

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-07-07 Thread sparcmoz
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User sparcmoz changed the following:

What|Old value |New value

  CC|'amy2008,camillem,carlosrp|'amy2008,camillem,carlosrp
|,chengxz,eostapets,er,gaoz|,chengxz,eostapets,er,gaoz
|m,jodygoldberg,jpryor,kami|m,jodygoldberg,jpryor,kami
|_,khirano,kohei,kpalagin,l|_,khirano,kohei,kpalagin,l
|iutao,lvyue,maoyg,mh,mmeek|iutao,lvyue,maoyg,mh,mmeek
|s,muthusuba,pagalmes,pj,pm|s,muthusuba,pagalmes,pj,pm
|ike,renatoyamane,sparcmoz,|ike,renatoyamane,tbe,tuhar
|tbe,tuharsky,utomo99' |sky,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-07-06 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User tbe changed the following:

What|Old value |New value

 Assigned to|tbe   |oc





--- Additional comments from t...@openoffice.org Mon Jul  6 13:06:29 + 
2009 ---
TBE-OC: Please verify in CWS calc51.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-06-17 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User tbe changed the following:

What|Old value |New value

 Assigned to|nn|tbe





--- Additional comments from t...@openoffice.org Wed Jun 17 08:57:56 + 
2009 ---
reassign to tbe

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-06-17 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User tbe changed the following:

What|Old value |New value

  Status|NEW   |STARTED

Target milestone|OOo 3.x   |OOo 3.2





--- Additional comments from t...@openoffice.org Wed Jun 17 09:23:38 + 
2009 ---
set target OOo 3.2

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-06-17 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User tbe changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from t...@openoffice.org Wed Jun 17 12:51:15 + 
2009 ---
Fixed in CWS calc51. In addition to the latest patch from June 3, 2009
I increased the horizontal size of the condition listboxes in the
standard filter dialog as specified in the specification from
January 7, 2008. The following files are affected:

offapi/com/sun/star/sheet/FilterOperator2.idl  r273052
offapi/com/sun/star/sheet/TableFilterField2.idl  r273052
offapi/com/sun/star/sheet/XSheetFilterDescriptor2.idl  r273052
offapi/com/sun/star/sheet/makefile.mk  r273052

xmloff/source/core/xmltoken.cxx  r273054
xmloff/inc/xmloff/xmltoken.hxx  r273054
xmloff/inc/xmlkywd.hxx  r273054

sc/source/filter/excel/excimp8.cxx  r273055
sc/source/filter/excel/excrecds.cxx  r273055
sc/source/filter/xml/xmlfilti.cxx  r273055
sc/source/filter/xml/xmldrani.hxx  r273055
sc/source/filter/xml/XMLExportDatabaseRanges.hxx  r273055
sc/source/filter/xml/xmlfilti.hxx  r273055
sc/source/filter/xml/xmldrani.cxx  r273055
sc/source/filter/xml/XMLExportDatabaseRanges.cxx  r273055
sc/source/core/data/table3.cxx  r273055
sc/source/ui/src/filter.src  r273055
sc/source/ui/unoobj/cellsuno.cxx  r273055
sc/source/ui/unoobj/datauno.cxx  r273055
sc/source/ui/vba/vbarange.cxx  r273055
sc/inc/global.hxx  r273055
sc/inc/datauno.hxx  r273055


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-06-17 Thread dr
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User dr changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|15522,72764,77677,90135   |15522,72764,77677,90135,10
  is|  |2872





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-06-05 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from ga...@openoffice.org Fri Jun  5 08:25:25 + 
2009 ---
Created an attachment (id=62787)
Updata the SpecificationDocument of issue35579.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-06-02 Thread lvyue
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from lv...@openoffice.org Wed Jun  3 02:59:06 + 
2009 ---
Created an attachment (id=62737)
patch 2, based on DEV300m49.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-05-06 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from t...@openoffice.org Wed May  6 07:30:23 + 
2009 ---
TBE-LVYUE,MAOYG:

This patch looks really nice. I did some testing and everything works fine.
I only have some minor remarks to your code, please see below.

Before we can integrate your patch we unfortunately have to wait until the
childworkspace (CWS) calc49 is integrated, because this CWS also changes
the filter dialog. After that it's necessary that you adjust your patch,
that means that you remove the duplicate and conflicting changes to the
filter dialog from your patch.

After the CWS calc49 is integrated it's also necessary that you update
the specification for this feature with the new screenshots
(FilterFeatureSpecificationDocument.odt, see attachment from
January 7, 2008).

Finally some code has to be written for the OOXML filter,
but I propose that this will be done by Daniel.



offapi/com/sun/star/sheet/FilterOperator2.idl


 +/** specifies the type of a single condition in a filter descriptor.
 +pThis constants group extends the typeFilterOperator/type enum by
 +additional filter operators./p
 +@since OOo 3.0
 +*/

For readability please add an empty line before and after the paragraph
starting with p and ending with /p. Please update the @since tag
to OOo 3.2. And in addition please indent the end of the comment '*/'
as in all other lines. 


offapi/com/sun/star/sheet/TableFilterField2.idl


 +/** describes a single condition in a filter descriptor.
 +pThis struct has the typeFilterOperator2/type constants group as
 +member, whereas the typeTableFilterField/type struct uses the
 +typeFilterOperator/type enum./p
 +@see com::sun::star::sheet::SheetFilterDescriptor
 +@since OOo 3.0
 +*/

As in the previous comment please add some empty lines and change the
position of the '*/'. Please update the @since tag to OOo 3.2.


offapi/com/sun/star/sheet/XSheetFilterDescriptor2.idl


 +/** provides access to a collection of filter conditions (filter fields).
 +pThis interface uses the typeTableFilterField2/type struct,
 +whereas the typeXSheetFilterDescriptor/type interface uses the
 +typeTableFilterField/type struct./p
 +@see com::sun::star::sheet::SheetFilterDescriptor
 +@since OOo 3.0
 +*/

As in the previous comment please add some empty lines and change the
position of the '*/'. Please update the @since tag to OOo 3.2.


sc/inc/datauno.hxx


 @@ -340,7 +341,8 @@
 
 //to uno, all three look the same
 
 -class ScFilterDescriptorBase : public cppu::WeakImplHelper3
 +class ScFilterDescriptorBase : public cppu::WeakImplHelper4
 +   
com::sun::star::sheet::XSheetFilterDescriptor2,
   
 com::sun::star::sheet::XSheetFilterDescriptor,
   
 com::sun::star::beans::XPropertySet,
   
 com::sun::star::lang::XServiceInfo ,

I would add XSheetFilterDescriptor2 after XSheetFilterDescriptor, but
that's only a matter of taste.

 @@ -367,6 +369,11 @@
   virtual void SAL_CALL   setFilterFields( const 
 ::com::sun::star::uno::Sequence
   
 ::com::sun::star::sheet::TableFilterField  aFilterFields )
   
 throw(::com::sun::star::uno::RuntimeException);
 +virtual ::com::sun::star::uno::Sequence
::com::sun::star::sheet::TableFilterField2  SAL_CALL
 +getFilterFields2()
throw(::com::sun::star::uno::RuntimeException);
 +virtual void SAL_CALLsetFilterFields2( const
::com::sun::star::uno::Sequence
 +::com::sun::star::sheet::TableFilterField2 
aFilterFields )
 +   
throw(::com::sun::star::uno::RuntimeException);

Please add a comment '// XSheetFilterDescriptor2' here.


sc/source/filter/xml/xmldrani.cxx



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-04-07 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from t...@openoffice.org Tue Apr  7 10:56:02 + 
2009 ---
maoyg: On which milestone is your patch from March 25, 2009 based on?


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-04-07 Thread maoyg
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from ma...@openoffice.org Tue Apr  7 13:52:49 + 
2009 ---
tbe:I used OOoDev300_m42 code.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-03-25 Thread maoyg
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from ma...@openoffice.org Wed Mar 25 08:38:34 + 
2009 ---
Created an attachment (id=61169)
Update the patch.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-03-12 Thread maoyg
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User maoyg changed the following:

What|Old value |New value

  CC|'amy2008,camillem,carlosrp|'amy2008,camillem,carlosrp
|,eostapets,er,gaozm,jodygo|,chengxz,eostapets,er,gaoz
|ldberg,jpryor,kami_,khiran|m,jodygoldberg,jpryor,kami
|o,kohei,kpalagin,lvyue,mh,|_,khirano,kohei,kpalagin,l
|mmeeks,muthusuba,pagalmes,|iutao,lvyue,maoyg,mh,mmeek
|pmike,renatoyamane,sparcmo|s,muthusuba,pagalmes,pj,pm
|z,tbe,tuharsky,utomo99'   |ike,renatoyamane,sparcmoz,
|  |tbe,tuharsky,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-03-12 Thread er
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from e...@openoffice.org Thu Mar 12 17:11:31 + 
2009 ---
*** Issue 90923 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-02-25 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from t...@openoffice.org Wed Feb 25 09:52:02 + 
2009 ---
TBE-GLOBETROT:
The patch is not finished yet. Therefore I don't recommend to include
this patch in its current state in any code line. There's also no
easy way for a newbie to include this patch, you have to build several
projects and register the new UNO types.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-02-25 Thread renatoyamane
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from renatoyam...@openoffice.org Wed Feb 25 
13:06:36 + 2009 ---
@prabinrng: If need this options, install Go-oo (www.go-oo.org).
It already have all this options in more than 1 year ago.

Regards,
Renato

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-02-24 Thread prabinrng
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from prabin...@openoffice.org Tue Feb 24 09:58:26 
+ 2009 ---
Please add , contains , start with , end with in the filter option

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-02-24 Thread prabinrng
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from prabin...@openoffice.org Tue Feb 24 09:58:37 
+ 2009 ---
Please add , contains , start with , end with in the filter option

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-02-24 Thread globetrot
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from globet...@openoffice.org Tue Feb 24 10:33:21 
+ 2009 ---
I notice there's a patch file available here, but don't find it included in any
build.  Is there an easy way for a newbie to include this functionality in OOo
3.0.1?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2009-02-08 Thread mh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User mh changed the following:

What|Old value |New value

   Status whiteboard|  |RM-S4





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org
For additional commands, e-mail: issues-h...@sc.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-12-02 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Dec  3 01:23:58 + 
2008 ---
The last patch based on DEV300_m2.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-12-01 Thread renatoyamane
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Dec  1 10:12:50 + 
2008 ---
@canis,
Maybe not, because:

1) A lot of people here are *users* and not *developers*.
2) Apply a patch and compile OOo is not easy to them.
3) And maybe, all this users are using Go-oo, wich contain a similar (or the
same) patch to do this a long time ago.

Best regards,
Renato

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-12-01 Thread canis
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Dec  2 04:52:49 + 
2008 ---
As a *user* who wants to use native OOo, I asked for *developers* who can *аpply
a patch and compile OOo*.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-11-30 Thread canis
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Sun Nov 30 09:19:07 + 
2008 ---
 Additional comments from gaozm Mon Jul 14 02:15:21 + 2008 ---
 Could you review the last patch?

Nobody can???

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-11-24 Thread camillem
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User camillem changed the following:

What|Old value |New value

  CC|'amy2008,carlosrp,eostapet|'amy2008,camillem,carlosrp
|s,er,gaozm,jodygoldberg,jp|,eostapets,er,gaozm,jodygo
|ryor,kami_,khirano,kohei,k|ldberg,jpryor,kami_,khiran
|palagin,lvyue,mh,mmeeks,mu|o,kohei,kpalagin,lvyue,mh,
|thusuba,pagalmes,pmike,ren|mmeeks,muthusuba,pagalmes,
|atoyamane,sparcmoz,tbe,tuh|pmike,renatoyamane,sparcmo
|arsky,utomo99'|z,tbe,tuharsky,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-09-25 Thread amy2008
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Sep 25 07:36:40 + 
2008 ---
*** Issue 84874 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-08-05 Thread kohei
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User kohei changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|15522,72764,90135 |15522,72764,77677,90135
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-07-27 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User gaozm changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|15522,90135   |15522,72764,90135
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-07-13 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Jul 14 02:15:21 + 
2008 ---
Hi,all
Could you review the last patch? Thank you.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-07-10 Thread amy2008
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User amy2008 changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,gao|'amy2008,carlosrp,eostapet
|zm,jodygoldberg,jpryor,kam|s,er,gaozm,jodygoldberg,jp
|i_,khirano,kohei,kpalagin,|ryor,kami_,khirano,kohei,k
|lvyue,mh,mmeeks,muthusuba,|palagin,lvyue,mh,mmeeks,mu
|pagalmes,pmike,renatoyaman|thusuba,pagalmes,pmike,ren
|e,sparcmoz,tbe,tuharsky,ut|atoyamane,sparcmoz,tbe,tuh
|omo99'|arsky,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-07-10 Thread er
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jul 10 13:12:18 + 
2008 ---
@tuharsky: apparently they apply some go-oo patch; whatever patch that may be,
most certainly not the one under discussion here.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-07-09 Thread fst
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jul  9 07:39:23 + 
2008 ---
*** Issue 90605 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-07-09 Thread tuharsky
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User tuharsky changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,gao|'carlosrp,eostapets,er,gao
|zm,jodygoldberg,jpryor,kam|zm,jodygoldberg,jpryor,kam
|i_,khirano,kohei,kpalagin,|i_,khirano,kohei,kpalagin,
|lvyue,mh,mmeeks,muthusuba,|lvyue,mh,mmeeks,muthusuba,
|pagalmes,pmike,renatoyaman|pagalmes,pmike,renatoyaman
|e,sparcmoz,tbe,utomo99'   |e,sparcmoz,tbe,tuharsky,ut
|  |omo99'





--- Additional comments from [EMAIL PROTECTED] Wed Jul  9 07:49:09 + 
2008 ---
The Ubuntu distributionl OpenOffice 2.4 does contain the filters, OxygenOffice
too. How is it possible, since this issue is targeted at 3.x? Do they apply the
patch? As listed in Issue 90605 (a duplicate)...

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-06-12 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jun 12 08:19:43 + 
2008 ---
Created an attachment (id=54418)
A complete patch to issue 35579.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-30 Thread mh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User mh changed the following:

What|Old value |New value

 IssuesThisDependsOn|  |90135





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-30 Thread mh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User mh changed the following:

What|Old value |New value

 IssuesThisDependsOn|90135 |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-30 Thread mh
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User mh changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|15522 |15522,90135
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-29 Thread er
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu May 29 17:45:05 + 
2008 ---
*** Issue 89549 has been marked as a duplicate of this issue. ***

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-22 Thread fl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User fl changed the following:

What|Old value |New value

Target milestone|OOo Later |OOo 3.x





--- Additional comments from [EMAIL PROTECTED] Thu May 22 08:33:34 + 
2008 ---
This issue is important and listed on the quarterly review for Calc:
http://wiki.services.openoffice.org/wiki/2008_Q2_Review_of_Spreadsheet_Project
Therefore adjusting target to 3.x.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-15 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu May 15 08:49:03 + 
2008 ---
Hello Thomas:
Thank your for your comments. After testing, I found that the problem
happened during the export course. I will trace it, in the meanwhile, I hope you
offer me some help.

gaozm


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-14 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed May 14 14:55:32 + 
2008 ---
Hi Gao,

I tested your latest patch from May 12, 2008 and found a
problem.

I create a standard filter on a table and set the 'contains'
condition and a value of e.g. 'blue'. Then I save and close the
document. After that I open the document again. Now the problem
is, that the  Standard Filter dialog doesn't show the 'contains'
condition, but the '=' condition and a value of '- empty -'.

Can you please debug and fix this problem. And please test your
patches before attaching them for review. For me it's always
very time consuming to apply the patch and build the
corresponding projects. 

Thomas


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-11 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon May 12 03:53:02 + 
2008 ---
Created an attachment (id=53557)
A new patch about issue 35579.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-08 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu May  8 06:25:14 + 
2008 ---
Hi, Thomas
What about the last patch about the file vbarange.cxx?

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-08 Thread kohei
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User kohei changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,gao|'carlosrp,eostapets,er,gao
|zm,jodygoldberg,jpryor,kam|zm,jodygoldberg,jpryor,kam
|i_,khirano,kpalagin,lvyue,|i_,khirano,kohei,kpalagin,
|mh,mmeeks,muthusuba,pagalm|lvyue,mh,mmeeks,muthusuba,
|es,pmike,renatoyamane,spar|pagalmes,pmike,renatoyaman
|cmoz,tbe,utomo99' |e,sparcmoz,tbe,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-07 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed May  7 07:30:03 + 
2008 ---
Created an attachment (id=53436)
A new patch about the file vbarange.cxx


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-06 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue May  6 10:14:05 + 
2008 ---
Hi Gao,

I applied your patch from April 20, 2008 to a DEV300 m10 milestone.
Some hunks failed, but those needed some minor modifications only.
Also in this milestone I couldn't reproduce your crashes.
The export of the new filter conditions works fine, but the import
doesn't work. I debugged your code with the result that
the aFilterFields2 member in ScXMLDatabaseRangeContext is empty.
This sequence must be filled during the import.

Therefore I propose the following steps:

1. Extend the ScXMLFilterContext class by a
   Sequence sheet::TableFilterField2  member and a
   void AddFilterField2( const sheet::TableFilterField2 aFilterField2 )
   method. This method must be called in
   ScXMLConditionContext::EndElement() (*).

2. Add a
   void SetFilterFields2( const Sequence sheet::TableFilterField2 )
   method to the ScXMLDatabaseRangeContext class. This method must be
   called in ScXMLFilterContext::EndElement() (*).

(*) Probably you find a way to call those methods only, if the
XSheetFilterDescriptor2 interface is supported.

Thomas


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-06 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue May  6 10:59:13 + 
2008 ---
Hi Gao,

I had a look at your patch from May 6, 2008 and I was really
wondering, why you assign to the Operator member of the
TableFilterField2 struct values of type FilterOperator
instead of FilterOperator2.

Thomas


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-05-05 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue May  6 03:43:25 + 
2008 ---
Created an attachment (id=53402)
A patch about vbarange.cxx


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-04-29 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Apr 30 04:35:42 + 
2008 ---
Created an attachment (id=53273)
A patch about issue 35579


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-26 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Mar 26 17:08:05 + 
2008 ---
Hi Gao,

I tried to apply your sc(2).patch from Mar 18, 2008, but the patch
fails for sc/source/ui/vba/vbarange.cxx:

Hunk #1 FAILED at 105.
Hunk #2 FAILED at 3324.

It also seems, that the corresponding code in ScVbaRange::AutoFilter() has
changed, please check.

As this part of the patch should only affect VBA specifics, I tested
your patch. If I create a standard filter with the new filter conditions
it seems, that the new conditions are not saved to the xml file.
In addition, I get the assertion Falscher Filter-enum from
ScFilterDescriptorBase::getFilterFields() or
ScFilterDescriptorBase::getFilterFields2().
Do you observe the same problem?

Before you submit the next iteration of your patch it would be nice,
if you combine all your sc patches into one patch, because due to
the amount of patches it gets more and more difficult for me to
keep track of all the patches. In addition it would make sense
to refer to the latest DEV300 milestone.

Thomas


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-18 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Mar 18 08:36:32 + 
2008 ---
Created an attachment (id=52183)
A patch about the XML import/export。


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-14 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Mar 14 08:06:41 + 
2008 ---
Hi Gao,

your 1.patch from Mar 13, 2008 is the right approach. You can even
think about adding a method

  void ScXMLExportDatabaseRanges::WriteFilterDescriptor(
const ReferenceXSheetFilterDescriptor2 xSheetFilterDescriptor2,
const ::rtl::OUString sDatabaseRangeName)

and query for XSheetFilterDescriptor2 before calling WriteFilterDescriptor().
But that's just a matter of taste.

In addition you also produced lots of similar/duplicate code, e.g. the first
part of the WriteFilterDescriptor() implementation. Probably you have an
idea of how to consolidate the code.

Thomas


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-12 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Mar 13 05:51:51 + 
2008 ---
Created an attachment (id=52067)
What about this patch about the function 
ScXMLExportDatabaseRanges::WriteFilterDescriptor()?


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-11 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Mar 11 08:43:13 + 
2008 ---
Created an attachment (id=52021)
Another patch about the XML import/export (offapi)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-11 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Mar 11 08:41:57 + 
2008 ---
Created an attachment (id=52020)
Another patch about the XML import/export (sc)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-03-11 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Mar 11 10:13:33 + 
2008 ---
TBE-GAOZM:

offapi.patch from Feb 18, 2008:
--

This patch is fine.


xmloff.patch from Feb 25, 2008:
--

Two hunks fail for SRC680 m245. Probably it makes sense to adjust
your patches for DEV300. In addition, please use spaces instead
of tabs. Otherwise this patch is fine.


offapi(1).patch and sc(1).patch from Mar 11, 2008:
-

I think that's exactly the wrong approach and not the way we
discussed in our last IRC meeting.

You basically added the interfaces XDatabaseRange2, XSheetFilterable2
and XSheetFilterableEx2. In the sc module you replaced in some
locations the existing interfaces XDatabaseRange, XSheetFilterable
and XSheetFilterableEx by the new ones. This approach has the
disadvantage, that the extension of the UNO API is unnecessary
and more worse, that you break existing functionality.

Therefore I propose the following approach:
The ScFilterDescriptorBase object and all derived objects support
XSheetFilterDescriptor and XSheetFilterDescriptor2.
If a method, e.g. ScXMLExportDatabaseRanges::WriteFilterDescriptor()
has a parameter 
const uno::Reference sheet::XSheetFilterDescriptor xSheetFilterDescriptor,
then you can query the xSheetFilterDescriptor object for the
XSheetFilterDescriptor2 interface. If this query is successful, then you
call the methods of XSheetFilterDescriptor2, otherwise you call the
methods of XSheetFilterDescriptor. Please see some pseudo code below.

Reference XSheetFilterDescriptor2  xDesc2( xSheetFilterDescriptor, UNO_QUERY 
);
if ( xDesc2.is() )
{
Sequence TableFilterField2  aTableFilterFields2(
xDesc2-getFilterFields2() );   
}
else
{
Sequence TableFilterField  aTableFilterFields(
xSheetFilterDescriptor-getFilterFields() );
}


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-24 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Feb 25 02:59:08 + 
2008 ---
Created an attachment (id=51696)
A new patch. the patch to the XML import/export (xmloff) above is wrong


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-19 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Feb 19 08:09:09 + 
2008 ---
Created an attachment (id=51584)
A new patch. the patch to the XML import/export (xmloff) (1) above is wrong.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-18 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Feb 18 08:33:22 + 
2008 ---
Created an attachment (id=51559)
A patch about the XML import/export (sc) (1)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-18 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Feb 18 08:35:21 + 
2008 ---
Created an attachment (id=51560)
A patch about the XML import/export (xmloff) (1)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-18 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Feb 18 08:31:58 + 
2008 ---
Created an attachment (id=51558)
A patch about the XML import/export (offapi) (1)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-08 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Feb  8 16:13:05 + 
2008 ---
TBE-GAOZM:

sc.patch doesn't compile. There are several undeclared indentifiers:
XML_CONTAINS, XML_DOES_NOT_CONTAIN, etc.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-02-08 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Feb  8 16:09:45 + 
2008 ---
TBE-GAOZM:

Please see my comments on offapi.patch below.



TableFilterField2.idl


+   pThis struct has the typeFilterOperator2/type constants group as
+   member, whereas the typeTableFilterField/type struct uses the
+   typeFilterOperator/type enum./p

Please indent by one more space.

+published struct TableFilterField2
+{
+   
//-
+

Please don't use tabs, but spaces.

+   /** specifies the type of the condition as defined in
typeFilterOperator2/type.
+ */
+   long Operator;

Please restrict to 80 chars per line.



TableFilterField2.idl


+pThis interface uses the typeTableFilterField2/type struct, whereas 
the
+typeXSheetFilterDescriptor/type interface uses the
+typeTableFilterField/type struct./p

Please restrict to 80 chars per line.



makefile.mk


hunk 1 and 3 fail for SRC680 m245


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-31 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 31 08:19:55 + 
2008 ---
Created an attachment (id=51283)
A patch about the XML import/export (offapi)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-31 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 31 08:22:17 + 
2008 ---
Created an attachment (id=51284)
A patch about the XML import/export (sc)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Jan 29 08:23:36 + 
2008 ---
Created an attachment (id=51221)
A patch about the XML import/export


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Jan 29 10:00:38 + 
2008 ---
TBE-GAOZM:

Hi Gao,

each patch review includes applying the patch, compiling the
modules and testing. Therefore can you please provide a
patch which

a) includes all the IDL files
b) includes the corresponding makefile entries
c) has the full file path for each file, e.g.
   sc/source/ui/unoobj/datauno.cxx instead of sc/datauno.cxx

All this is needed anyway and would save me lots of manual
work.

Thanks,

Thomas


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jan 30 07:55:04 + 
2008 ---
Created an attachment (id=51243)
A new patch about the XML import/export (2)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jan 30 07:53:44 + 
2008 ---
Created an attachment (id=51242)
A new patch about the XML import/export (1)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread branday
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jan 30 07:30:02 + 
2008 ---
Extend filter.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jan 30 07:56:29 + 
2008 ---
Created an attachment (id=51244)
A new patch about the XML import/export (3)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-29 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jan 30 07:58:33 + 
2008 ---
Created an attachment (id=51245)
A new patch about the XML import/export (4)


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-18 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Jan 18 09:44:50 + 
2008 ---
TBE-GAOZM:

Please see my comments below. 



FilterOperator2.idl


 /** FilterOperator2 was introduced in order to add additional filter operators
 */

better:

/** specifies the type of a single condition in a filter descriptor.

pThis constants group extends the typeFilterOperator/type enum by
additional filter operators./p

@since OOo 3.0
 */



TableFilterField2.idl


 /** FilterOperator2 is a member of TableFilterField2
 */

better:

/** describes a single condition in a filter descriptor.

   pThis struct has the typeFilterOperator2/type constants group as
   member, whereas the typeTableFilterField/type struct uses the
   typeFilterOperator/type enum./p

@see com::sun::star::sheet::SheetFilterDescriptor

@since OOo 3.0
 */

 /** specifies the type of the condition. And the type FilterOperator2 is
used here.
  */

better:

/** specifies the type of the condition as defined in 
typeFilterOperator2/type.
 */



XSheetFilterDescriptor2.idl


 /**XSheetFilterDescriptor2 is derived from XSheetFilterDescriptor.
 */

That's not the case, it's derived from XInterface.

better:

/** provides access to a collection of filter conditions (filter fields).

pThis interface uses the typeTableFilterField2/type struct, whereas 
the
typeXSheetFilterDescriptor/type interface uses the
typeTableFilterField/type struct./p

@see com::sun::star::sheet::SheetFilterDescriptor

@since OOo 3.0
 */


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-17 Thread lvyue
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 17 08:01:55 + 
2008 ---
Created an attachment (id=50934)
patch2


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-17 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 17 09:32:59 + 
2008 ---
TBE-GAOZM:


FilterOperator2.idl


Please use spaces instead of tabs for indentation.

 module com {  module sun {  module star {  module sheet {

Please add a comment here. It also makes sense to explain, why FilterOperator2
was introduced (additional filter operators).


   constants FilterOperator2

I think you can already use published here.

   
 //-

  /** selects begins-with entries.
  */
const long BEGINS_WITH = 14;

Please indent as follows:

/** selects begins-with entries.
 */



TableFilterField2.idl


Please use spaces instead of tabs for indentation.

 module com {  module sun {  module star {  module sheet {

Please add a comment here. It also makes sense to explain the difference to
TableFilterField.


 struct TableFilterField2

I think you can already use published here.

   
 //-

   /** specifies the type of the condition.
*/
   long Operator;

Please note in the comment, that type FilterOperator2 is used here.

   /** selects whether the memberTableFilterField::NumericValue/member
   or the memberTableFilterField::StringValue/member is used.
*/
   boolean IsNumeric;

Please exchange TableFilterField with TableFilterField2 here.



XSheetFilterDescriptor2.idl


Please use spaces instead of tabs for indentation.

module com {  module sun {  module star {  module sheet {

Please add a comment here. It also makes sense to explain the difference to
XSheetFilterDescriptor.

   published interface XSheetFilterDescriptor2: 
 com::sun::star::uno::XInterface

You cannot use getFilterFields() and setFilterFields() as method names here,
because this leads to problems when implementing this interface at the same
C++ object which implements XSheetFilterDescriptor. Also for Basic macros this
gives some problems. Therefore please use other names.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-17 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 17 09:35:40 + 
2008 ---
TBE-LVYUE:
This patch is fine. Thanks for all this work.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-17 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Jan 18 04:46:04 + 
2008 ---
Created an attachment (id=50950)
Extend the UNO API


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-17 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Jan 18 04:47:27 + 
2008 ---
Created an attachment (id=50951)
Extend the UNO API


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-17 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Jan 18 04:48:33 + 
2008 ---
Created an attachment (id=50952)
Extend the UNO API


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-16 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 17 07:52:17 + 
2008 ---
Created an attachment (id=50931)
I have extended the UNO API


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-16 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 17 07:54:30 + 
2008 ---
Created an attachment (id=50932)
I have extended the UNO API


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-16 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 17 07:55:26 + 
2008 ---
Created an attachment (id=50933)
I have extended the UNO API


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-11 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Fri Jan 11 10:03:45 + 
2008 ---
lvyue:
Apart from the missing ODF code I have only one consolidation issue.



sc/source/core/data/table3.cxx


@@ -1045,14 +1055,51 @@ BOOL ScTable::ValidQuery(SCROW nRow, con
 {
 xub_StrLen nStart = 0;
 xub_StrLen nEnd   = aCellStr.Len();
-BOOL bMatch = (BOOL) rEntry.GetSearchTextPtr( rParam.bCaseSens 
)
--SearchFrwrd( aCellStr, nStart, nEnd );
 // from 614 on, nEnd is behind the found text
+BOOL bMatch = FALSE;
+if ( rEntry.eOp == SC_ENDS_WITH || rEntry.eOp ==
SC_DOES_NOT_END_WITH )
+{
+nEnd = 0;
+nStart = aCellStr.Len();
+bMatch = (BOOL) rEntry.GetSearchTextPtr( rParam.bCaseSens )
+-SearchBkwrd( aCellStr, nStart, nEnd );
+} 
+else
+{
+bMatch = (BOOL) rEntry.GetSearchTextPtr( rParam.bCaseSens )
+-SearchFrwrd( aCellStr, nStart, nEnd );
+}
 if ( bMatch  bMatchWholeCell
  (nStart != 0 || nEnd != aCellStr.Len()) )
 bMatch = FALSE;// RegExp must match entire cell string
 if ( bRealRegExp )
-bOk = ((rEntry.eOp == SC_NOT_EQUAL) ? !bMatch : bMatch);
+switch (rEntry.eOp)
+{
+case SC_EQUAL:
+case SC_CONTAINS:
+bOk = bMatch;
+break;
+case SC_NOT_EQUAL:
+case SC_DOES_NOT_CONTAIN:
+bOk = !bMatch;
+break;
+case SC_BEGINS_WITH:
+bOk = ( bMatch  (nStart == 0) );
+break;
+case SC_DOES_NOT_BEGIN_WITH:
+bOk = !( bMatch  (nStart == 0) );
+break;
+case SC_ENDS_WITH:
+bOk = ( bMatch  (nEnd == aCellStr.Len()) );
+break;
+case SC_DOES_NOT_END_WITH:
+bOk = !( bMatch  (nEnd == aCellStr.Len()) );
+break;
+default:
+{
+// added to avoid warnings
+}
+}

This is really nice code, that's exactly what I meant.

@@ -1083,6 +1130,46 @@ BOOL ScTable::ValidQuery(SCROW nRow, con
 if ( rEntry.eOp == SC_NOT_EQUAL )
 bOk = !bOk;
 }
+else if( rEntry.eOp == SC_CONTAINS || rEntry.eOp ==
SC_DOES_NOT_CONTAIN
+|| rEntry.eOp == SC_BEGINS_WITH || rEntry.eOp == 
SC_ENDS_WITH
+|| rEntry.eOp == SC_DOES_NOT_BEGIN_WITH || rEntry.eOp ==
SC_DOES_NOT_END_WITH )
+{
+::com::sun::star::uno::Sequence sal_Int32  xOff;
+String aCell( pTransliteration-transliterate(
+aCellStr, ScGlobal::eLnge, 0, aCellStr.Len(),
+xOff ) );
+String aQuer( pTransliteration-transliterate(
+*rEntry.pStr, ScGlobal::eLnge, 0, rEntry.pStr-Len(),
+xOff ) );
+xub_StrLen nIndex = (rEntry.eOp == SC_ENDS_WITH 
+|| rEntry.eOp == SC_DOES_NOT_END_WITH)?
(aCell.Len()-aQuer.Len()):0;
+xub_StrLen nStrPos = aCell.Search( aQuer, nIndex );
+switch (rEntry.eOp)
+{
+case SC_CONTAINS:
+bOk = ( nStrPos != STRING_NOTFOUND );
+break;
+case SC_DOES_NOT_CONTAIN:
+bOk = ( nStrPos == STRING_NOTFOUND );
+break;
+case SC_BEGINS_WITH:
+bOk = ( nStrPos == 0 );
+break;
+case SC_DOES_NOT_BEGIN_WITH:
+bOk = ( nStrPos != 0 );
+break;
+case SC_ENDS_WITH:
+bOk = ( nStrPos + aQuer.Len() == aCell.Len() );
+break;
+case SC_DOES_NOT_END_WITH:
+bOk = ( nStrPos + aQuer.Len() != aCell.Len() );
+break;
+default:
+

[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-09 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Wed Jan  9 09:52:41 + 
2008 ---
gaozm:
I would use the following strategy for finding the right
code places for the XML import/export.
Set up a standard filter with condition '=' and check
that this condition is exported and imported again
while saving/loading.
Set a breakpoint in all locations where SC_EQUAL is
checked.
Each breakpoint which is hit during saving/loading
is a location where you have to add your new filter
conditions.

In addition, as already said, you probably have to
also add the new attribute values in xmloff.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-09 Thread lvyue
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 10 04:26:31 + 
2008 ---
Created an attachment (id=50776)
I have modified the last patch according to tbe's comments. Please check it. 
And for the ODF part, we stiil need some time.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-09 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Thu Jan 10 05:18:43 + 
2008 ---
Hello tbe:
That's a good idear. Following your idear, I will do it right now. And give
you  a feedback as soon as possible. Thank you.
  

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-08 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User gaozm changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,jod|'carlosrp,eostapets,er,gao
|ygoldberg,jpryor,kami_,khi|zm,jodygoldberg,jpryor,kam
|rano,kpalagin,lvyue,mh,mme|i_,khirano,kpalagin,lvyue,
|eks,muthusuba,pagalmes,pmi|mh,mmeeks,muthusuba,pagalm
|ke,renatoyamane,sparcmoz,t|es,pmike,renatoyamane,spar
|be,utomo99'   |cmoz,tbe,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-07 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Jan  7 16:28:47 + 
2008 ---
This iteration of the patch is much better. Please see my comments below.

Thomas



The code for exporting/importing the new filter conditions to/from ODF is
missing!!!


I got the news from Eike, that the missing '!begins' and '!ends'
attribute values were proposed to the OASIS ODF TC today. Probably next week
they will decide about them.


sc/source/core/data/table3.cxx


@@ -1036,29 +1043,45 @@ BOOL ScTable::ValidQuery(SCROW nRow, con
 else
 GetInputString( static_castSCCOL(rEntry.nField), nRow,
aCellStr );
 
-BOOL bRealRegExp = (rParam.bRegExp  ((rEntry.eOp == SC_EQUAL)
-|| (rEntry.eOp == SC_NOT_EQUAL)));
+BOOL bRealRegExp = (rParam.bRegExp  ((rEntry.eOp == SC_EQUAL)   

+   || (rEntry.eOp == SC_NOT_EQUAL) || (rEntry.eOp == 
SC_CONTAINS) 

+   || (rEntry.eOp == SC_DOES_NOT_CONTAIN) || 
(rEntry.eOp == SC_BEGINS_WITH)

+   || (rEntry.eOp == SC_ENDS_WITH) || (rEntry.eOp 
== SC_DOES_NOT_BEGIN_WITH)

+|| (rEntry.eOp == SC_DOES_NOT_END_WITH)));

 BOOL bTestRegExp = (pbTestEqualCondition  rParam.bRegExp
  ((rEntry.eOp == SC_LESS_EQUAL)
 || (rEntry.eOp == SC_GREATER_EQUAL)));
 if ( bRealRegExp || bTestRegExp )
 {
-   xub_StrLen nStart = 0;
+xub_StrLen nStart = (rEntry.eOp == SC_ENDS_WITH 
+|| rEntry.eOp == SC_DOES_NOT_END_WITH)? ( aCellStr.Len() -
rEntry.pStr-Len() ):0;
xub_StrLen nEnd   = aCellStr.Len();
 BOOL bMatch = (BOOL) rEntry.GetSearchTextPtr( rParam.bCaseSens 
)
-SearchFrwrd( aCellStr, nStart, nEnd 
);

The code branch for searching with regular expressions needs some rework.
Thanks to Eike for all the hints.
For the SC_ENDS_WITH and SC_DOES_NOT_END_WITH part,
setting nStart to aCellStr.Len() - rEntry.pStr-Len() is not correct, as your
regular expression can match the whole cell string, although the length of
the regular expression is much shorter. Therefore you have to search starting
with nStart=0, that means the whole cell string. You'll get some problems, if
the cell string contains the regular expression more than one time, therefore
you have to guarantee, that you find the last occurance. Probably
TextSearch::SearchBkwrd() is your friend in this case.
Finally you can check, if nEnd equals aCellStr.Len().

-if ( bMatch  bMatchWholeCell
-(nStart != 0 || nEnd != 
aCellStr.Len()) )
-bMatch = FALSE;// RegExp must match entire cell string
+if ( bMatch )
+{
+if ( bMatchWholeCell  (nStart != 0 || nEnd !=
aCellStr.Len()) )
+bMatch = FALSE;
+else if ( ((rEntry.eOp == SC_BEGINS_WITH || rEntry.eOp ==
SC_DOES_NOT_BEGIN_WITH)
+ (nStart != 0))
+   || ((rEntry.eOp == SC_ENDS_WITH || rEntry.eOp ==
SC_DOES_NOT_END_WITH)
+ (nEnd != aCellStr.Len())) )
+bMatch = FALSE;
+}
 if ( bRealRegExp )
-bOk = ((rEntry.eOp == SC_NOT_EQUAL) ? !bMatch : bMatch);
+bOk = ((rEntry.eOp == SC_NOT_EQUAL || rEntry.eOp ==
SC_DOES_NOT_CONTAIN
+|| rEntry.eOp == SC_DOES_NOT_BEGIN_WITH 
+|| rEntry.eOp == SC_DOES_NOT_END_WITH) ? !bMatch :
bMatch);

This part of the code is hard to read and hard to understand,
especially bOK = !bMatch a few lines later. I would recommend to have a switch
statement and handle there the different cases for SC_BEGINS_WITH,
SC_DOES_NOT_BEGIN_WITH, etc.

@@ -1078,10 +1101,35 @@ BOOL ScTable::ValidQuery(SCROW nRow, con
 String aQuer( pTransliteration-transliterate(
 *rEntry.pStr, ScGlobal::eLnge, 0, 
rEntry.pStr-Len(),
 xOff ) );
-bOk = (aCell.Search( aQuer ) != STRING_NOTFOUND);
+xub_StrLen nIndex = (rEntry.eOp == SC_ENDS_WITH 
+|| rEntry.eOp == SC_DOES_NOT_END_WITH)?
(aCell.Len()-aQuer.Len()):0;
+

[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-06 Thread gaozm
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Jan  7 03:10:16 + 
2008 ---
Created an attachment (id=50685)
Add some filter-conditions and change the layout to the new  dialog style by 
shifting OK/Cancel/Help buttons


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-06 Thread lvyue
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User lvyue changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,jod|'carlosrp,eostapets,er,jod
|ygoldberg,jpryor,kami_,khi|ygoldberg,jpryor,kami_,khi
|rano,kpalagin,mh,mmeeks,mu|rano,kpalagin,lvyue,mh,mme
|thusuba,pagalmes,pmike,ren|eks,muthusuba,pagalmes,pmi
|atoyamane,sparcmoz,tbe,uto|ke,renatoyamane,sparcmoz,t
|mo99' |be,utomo99'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2008-01-06 Thread lvyue
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Mon Jan  7 05:20:16 + 
2008 ---
Created an attachment (id=50691)
A patch


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2007-12-19 Thread tbe
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User tbe changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,jod|'carlosrp,eostapets,er,jod
|ygoldberg,jpryor,kami_,khi|ygoldberg,jpryor,kami_,khi
|rano,kpalagin,mh,mmeeks,mu|rano,kpalagin,mh,mmeeks,mu
|thusuba,pagalmes,pmike,ren|thusuba,pagalmes,pmike,ren
|atoyamane,sparcmoz,utomo99|atoyamane,sparcmoz,tbe,uto
|' |mo99'





--- Additional comments from [EMAIL PROTECTED] Wed Dec 19 09:12:23 + 
2007 ---
cc tbe

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2007-08-14 Thread er
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579





--- Additional comments from [EMAIL PROTECTED] Tue Aug 14 10:52:01 + 
2007 ---
   foo
foo
foo 
 
 Before, a regex of Equals foo would only match the first row.  After my
 change, it will match all three rows.

That should be avoided. Note that ScTable::ValidQuery() is also used by
formula functions, so loading a document suddenly and silently may
produce different results.


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[sc-issues] [Issue 35579] Standard filter requires m ore options..

2007-08-13 Thread jpryor
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35579


User jpryor changed the following:

What|Old value |New value

  CC|'carlosrp,eostapets,er,jod|'carlosrp,eostapets,er,jod
|ygoldberg,kami_,khirano,kp|ygoldberg,jpryor,kami_,khi
|alagin,mh,mmeeks,muthusuba|rano,kpalagin,mh,mmeeks,mu
|,pagalmes,pmike,renatoyama|thusuba,pagalmes,pmike,ren
|ne,sparcmoz,utomo99'  |atoyamane,sparcmoz,utomo99
|  |'





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



  1   2   >