Re: GSoC proposal : Semantic Collection for Amarok

2012-02-24 Thread Phalgun Guduthur
On Fri, Feb 24, 2012 at 10:33 PM, Teo Mrnjavac  wrote:

> On Wed, Feb 22, 2012 at 13:24, Phalgun Guduthur
>  wrote:
> > Hi
> >
> > My name is Phalgun Guduthur, a 21 year old final year under grad
> majoring in
> > Computer Science in PESIT, Bangalore India.
> >
> > I am interested in working on the Amarok GSoC idea 'Semantic Collection
> for
> > Amarok'. I have been researching on this project for a few days now. I
> have
> > had a few interactions with the mentor (Teo) to gain a clear
> understanding
> > on the problem statement. I have had prior experience working with
> Nepomuk.
> > More details on it can be found in the proposal.
> >
> > I have come up with a proposal and you can find it attached it to this
> > mail.This is first rough draft of the proposal, so there are bound to be
> > mistakes. Please let me know if I have made a blunder anywhere.
> >
> > I plan to come up with a patch in a few days. It will attached to the
> > proposal when complete.
> >
> > Hope you find the time to review my proposal.
>
> Hello.
> First of all, this is a very good proposal!
> I've got a few observations/questions, you can incorporate the answers
> in your proposal document.
>
> * In our existing code it's called QueryMaker, not QueryManager.
> * Is there a way to handle what in TagLib is extended metadata, such
> as composer, disc number or albumartist? I think this is important.
> * This is not required, but it would be cool if you could research a
> bit how much of this work could also apply to an apparently
> Nepomuk-compatible data store such as Tracker as well.
> * Finally, a commit is a committment. Do you plan to keep working on
> this project even after GSoC ends?
>
> Cheers,
> --
> Teo
>

Hello Teo

Thank you for reviewing my proposal inspite of your busy schedule.

   - Yes, I noticed the error too. Will rename it to QueryMaker in the next
   draft of the proposal.

   - Do you mean how extended meta data like disc number will be handled in
   Nepomuk?
   If that is what you mean, there are already ontologies present to handle
   that metadata which are supported by Nepomuk.
   For example,
   nid3:composer applies to Composer
   nid3:trackNumber applies to Disc Number.

   More details of these ontologies can be found
here
   .

   - Yes, the last 2 points came to my mind after submitting my proposal. I
   made a note to myself just today about these 2 :)
   I was too excited about Nepomuk that I forgot about Tracker. I will
   research more about this and get back to you soon.

   And about my further commitment towards Amarok, I assure you that I will
   continue maintaining the code I develop and work more if necessary.
   I'm in my final year of Bachelors program, and my future employer (who
   was himself one of the first open source contributors from India) has
   assured me I can spend time on contributing to open source during work
   hours.

   And I have no other commitments so working for Amarok & Nepomuk will be
   easy.


Hope I could clarify myself on a few notes there.

Cheers
Phalgun
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: Review Request: Preview of live scanning feature

2012-02-24 Thread Ville Ranki
On 2012-02-24 14:25, Bart Cerneels wrote:

> src/core-impl/collections/db/ScanManager.cpp
> 
> 
> With such complex nested code readability is even more important. Please 
> change the style to comply with HACKING/intro_and_style.txt
> 
> 
> 
> src/core-impl/collections/db/ScanManager.cpp
> 
> 
> Commented out code should be removed.

As i mentioned, this is just a preview so i am not interested in code
style issues at this point. Are the actual changes to scanner logic
good and should i continue the work? If yes, next steps would be
implementing partial scan and deleting missing files from database.

Any ideas how to implement deletion are welcome. I'm not sure if it
should be done in amarok or scanner process.

-- 
Ville Ranki 
http://www.iki.fi/~cos
<>___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: GSoC 2012 : QMLify Amarok Context View

2012-02-24 Thread Saurabh Sood
Thanks for the reply Bart. I am currently going through the code for
EngineController, and have got some idea. I am targeting 'Current
Track' right now. One query I had was with respect to Data models. I
didnt fully understand the requirements there. What are the models
composed of, and what are they expected to accomplish. Could you
provide some more specific info on that, so I can get started.

Regards,.
Saurabh

On Fri, Feb 24, 2012 at 5:58 PM, Bart Cerneels  wrote:
> On Thu, Feb 23, 2012 at 17:50, Saurabh Sood  wrote:
>> Hi,
>>
>> I am a 3rd Year Bachelor's student of Computer Science Student from
>> India. I have started work on the GSoC proposal to QML'ify the Amarok
>> Context Viewn and have contacted the mentors (Teo` and Stecchino) for
>> the same. I have experience in developing Qt Applications, and in
>> developing QML Plasma Widgets. I will be coming up with a more
>> detailed plan shortly.
>>
>> I am at present concentrating on brushing up my QML knowledge with
>> Data Models, and also using Qt Declarative. I am also studying the
>> present code for the applets. My main queries at present are:
>>
>> 1.) The need to change the present Data Engines
>
> The data engines are plasma. Since our goal is not to depend om plasma
> anymore for the context applets, they are not needed anymore. You can
> probably use some of the data gathering code though.
>
>> 2.) The extent of Amarok code, I need to be concerned with
>
> src/context/* and later on EngineController (to get current playing track 
> data).
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Bug 194549 confirmation.

2012-02-24 Thread Parthasarathy Gopavarapu
I just wanted to ask whether this bug( wish ) needs to be patched, or let
it be?

https://bugs.kde.org/show_bug.cgi?id=194549

( *Bug 194549*  - appending
songs to playlist instantly plays them - should be quiet and just append )
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: GSoC proposal : Semantic Collection for Amarok

2012-02-24 Thread Teo Mrnjavac
On Wed, Feb 22, 2012 at 13:24, Phalgun Guduthur
 wrote:
> Hi
>
> My name is Phalgun Guduthur, a 21 year old final year under grad majoring in
> Computer Science in PESIT, Bangalore India.
>
> I am interested in working on the Amarok GSoC idea 'Semantic Collection for
> Amarok'. I have been researching on this project for a few days now. I have
> had a few interactions with the mentor (Teo) to gain a clear understanding
> on the problem statement. I have had prior experience working with Nepomuk.
> More details on it can be found in the proposal.
>
> I have come up with a proposal and you can find it attached it to this
> mail.This is first rough draft of the proposal, so there are bound to be
> mistakes. Please let me know if I have made a blunder anywhere.
>
> I plan to come up with a patch in a few days. It will attached to the
> proposal when complete.
>
> Hope you find the time to review my proposal.

Hello.
First of all, this is a very good proposal!
I've got a few observations/questions, you can incorporate the answers
in your proposal document.

* In our existing code it's called QueryMaker, not QueryManager.
* Is there a way to handle what in TagLib is extended metadata, such
as composer, disc number or albumartist? I think this is important.
* This is not required, but it would be cool if you could research a
bit how much of this work could also apply to an apparently
Nepomuk-compatible data store such as Tracker as well.
* Finally, a commit is a committment. Do you plan to keep working on
this project even after GSoC ends?

Cheers,
-- 
Teo
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: GSoC 2012 : QMLify Amarok Context View

2012-02-24 Thread Bart Cerneels
On Thu, Feb 23, 2012 at 17:50, Saurabh Sood  wrote:
> Hi,
>
> I am a 3rd Year Bachelor's student of Computer Science Student from
> India. I have started work on the GSoC proposal to QML'ify the Amarok
> Context Viewn and have contacted the mentors (Teo` and Stecchino) for
> the same. I have experience in developing Qt Applications, and in
> developing QML Plasma Widgets. I will be coming up with a more
> detailed plan shortly.
>
> I am at present concentrating on brushing up my QML knowledge with
> Data Models, and also using Qt Declarative. I am also studying the
> present code for the applets. My main queries at present are:
>
> 1.) The need to change the present Data Engines

The data engines are plasma. Since our goal is not to depend om plasma
anymore for the context applets, they are not needed anymore. You can
probably use some of the data gathering code though.

> 2.) The extent of Amarok code, I need to be concerned with

src/context/* and later on EngineController (to get current playing track data).
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Re: Review Request: Preview of live scanning feature

2012-02-24 Thread Bart Cerneels

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104049/#review10866
---



src/core-impl/collections/db/ScanManager.cpp


With such complex nested code readability is even more important. Please 
change the style to comply with HACKING/intro_and_style.txt



src/core-impl/collections/db/ScanManager.cpp


Commented out code should be removed.


- Bart Cerneels


On Feb. 23, 2012, 2:25 p.m., Ville Ranki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104049/
> ---
> 
> (Updated Feb. 23, 2012, 2:25 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> ---
> 
> This is a preview of work i've been doing to implement live scanning. 
> Currently it can do full scan 
> and add found tracks to database during the scan. Removing missing files is 
> not yet implemented. Also partial 
> scan may not work as expected.
> 
> 
> Diffs
> -
> 
>   src/core-impl/collections/db/ScanManager.h 5f0d153 
>   src/core-impl/collections/db/ScanManager.cpp 97d0b1c 
>   src/core-impl/collections/db/ScanResultProcessor.cpp 4f02a16 
>   src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp 6699b98 
>   src/scanner/GenericScanManager.cpp 215f78b 
>   utilities/collectionscanner/CollectionScanner.h 6bbc757 
>   utilities/collectionscanner/CollectionScanner.cpp 74b57a6 
>   utilities/collectionscanner/Directory.cpp 66b3a9b 
> 
> Diff: http://git.reviewboard.kde.org/r/104049/diff/
> 
> 
> Testing
> ---
> 
> "Works on my pc" on a small test collection.
> 
> 
> Thanks,
> 
> Ville Ranki
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


Path incompatibilities between Windows and Linux

2012-02-24 Thread Myriam Schweingruber
Hi all,

Patrick just raised my attention on several bugs that have in common
the difference in path prefixes between Windows and Linux. I don't
know if this is an easy fix, but it should really be addressed soon as
it is one of the major flaws for Amarok under Windows as well for
saved playlists between the two systems and iTunes import.

I have attached a screenshot that shows the problem. You can find it
here as well:

http://dl.dropbox.com/u/6292727/Sceenshots/Capture70.png

The bug reports that seem to be linked to this are the following:

https://bugs.kde.org/show_bug.cgi?id=160841
https://bugs.kde.org/show_bug.cgi?id=279560
https://bugs.kde.org/show_bug.cgi?id=278715

It would be really nice if someone could tackle this soon so we can
get rid of one major problem :)


Regards, Myriam

-- 
Proud member of the Amarok and KDE Community
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
<>___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel