D11862: Get rid of scripting

2018-04-05 Thread Malte Veerman 
malteveerman added a comment.


  In D11862#239984 , @markey wrote:
  
  > See, the problem with removing features like this is, there will be a huge 
outcry from users. That's guaranteed, even without knowing for sure how much 
the scripting feature is really used in the wild.
  >
  > I was discussing about this with Heiko. Maybe QtScript could be replaced 
with QJSEngine, similar to how the following patch for another project attempts 
to do it?
  >
  > https://phabricator.kde.org/D7033
  
  
  I see your point about removing features. But I've taken a look at the most 
popular scripts on opendesktop.org and they all rely on Qt bindings. Unless 
there is some way to restore bindings support this feature is broken and people 
will complain anyway.
  About replacing QtScript with QJSEngine: I think it's quite possible to do 
so, but I have my doubts if the development and maintenance work is worth it 
given our limited manpower.
  Anyway, I'll open a new revision just with the patch that implements the 
lyrics functionality in C++.

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D11862

To: malteveerman, #amarok
Cc: markey, #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, 
cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11862: Get rid of scripting

2018-04-04 Thread Mark Kretschmann 
markey added a comment.


  See, the problem with removing features like this is, there will be a huge 
outcry from users. That's guaranteed, even without knowing for sure how much 
the scripting feature is really used in the wild.
  
  I was discussing about this with Heiko. Maybe QtScript could be replaced with 
QJSEngine, similar to how the following patch for another project attempts to 
do it?
  
  https://phabricator.kde.org/D7033

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D11862

To: malteveerman, #amarok
Cc: markey, #amarok, jackyalcine, nhuisman, paul, yaohanchen, malteveerman, 
cochise, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker

D11862: Get rid of scripting

2018-04-01 Thread Malte Veerman 
malteveerman created this revision.
malteveerman added a reviewer: Amarok.
malteveerman added a project: Amarok.
malteveerman requested review of this revision.

REVISION SUMMARY
  Since Qt5Script is deprecated and virtually useless without bindings support 
I got rid of it.
  I moved the lyrics functionality to LyricsManager but the rest I deleted 
without reimplementing it in C++.

REPOSITORY
  R181 Amarok

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11862

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/bindingstest/QtScriptBindingsTest.cpp
  src/ActionClasses.cpp
  src/App.cpp
  src/App.h
  src/CMakeLists.txt
  src/MainWindow.cpp
  src/browsers/CollectionTreeView.cpp
  src/browsers/servicebrowser/ServiceBrowser.cpp
  src/browsers/servicebrowser/ServiceBrowser.h
  src/configdialog/ConfigDialog.cpp
  src/configdialog/dialogs/ScriptSelector.cpp
  src/configdialog/dialogs/ScriptSelector.h
  src/configdialog/dialogs/ScriptsConfig.cpp
  src/configdialog/dialogs/ScriptsConfig.h
  src/configdialog/dialogs/ScriptsConfig.ui
  src/context/LyricsManager.cpp
  src/context/LyricsManager.h
  src/context/applets/lyrics/plugin/LyricsEngine.cpp
  src/context/applets/lyrics/plugin/LyricsEngine.h
  src/dialogs/DiagnosticDialog.cpp
  src/dialogs/deviceconfiguredialog.cpp
  src/dynamic/BiasFactory.cpp
  src/lyrics/LyricsManager.cpp
  src/lyrics/LyricsManager.h
  src/playlistmanager/PlaylistManager.h
  src/scripting/scriptconsole/CompletionModel.cpp
  src/scripting/scriptconsole/CompletionModel.h
  src/scripting/scriptconsole/ScriptConsole.cpp
  src/scripting/scriptconsole/ScriptConsole.h
  src/scripting/scriptconsole/ScriptConsoleItem.cpp
  src/scripting/scriptconsole/ScriptConsoleItem.h
  src/scripting/scriptconsole/ScriptEditorDocument.cpp
  src/scripting/scriptconsole/ScriptEditorDocument.h
  src/scripting/scriptengine/AmarokBookmarkScript.cpp
  src/scripting/scriptengine/AmarokBookmarkScript.h
  src/scripting/scriptengine/AmarokCollectionScript.cpp
  src/scripting/scriptengine/AmarokCollectionScript.h
  src/scripting/scriptengine/AmarokCollectionViewScript.cpp
  src/scripting/scriptengine/AmarokCollectionViewScript.h
  src/scripting/scriptengine/AmarokEngineScript.cpp
  src/scripting/scriptengine/AmarokEngineScript.h
  src/scripting/scriptengine/AmarokEqualizerScript.cpp
  src/scripting/scriptengine/AmarokEqualizerScript.h
  src/scripting/scriptengine/AmarokInfoScript.cpp
  src/scripting/scriptengine/AmarokInfoScript.h
  src/scripting/scriptengine/AmarokKNotifyScript.cpp
  src/scripting/scriptengine/AmarokKNotifyScript.h
  src/scripting/scriptengine/AmarokLyricsScript.cpp
  src/scripting/scriptengine/AmarokLyricsScript.h
  src/scripting/scriptengine/AmarokNetworkScript.cpp
  src/scripting/scriptengine/AmarokNetworkScript.h
  src/scripting/scriptengine/AmarokOSDScript.cpp
  src/scripting/scriptengine/AmarokOSDScript.h
  src/scripting/scriptengine/AmarokPlaylistManagerScript.cpp
  src/scripting/scriptengine/AmarokPlaylistManagerScript.h
  src/scripting/scriptengine/AmarokPlaylistScript.cpp
  src/scripting/scriptengine/AmarokPlaylistScript.h
  src/scripting/scriptengine/AmarokScript.cpp
  src/scripting/scriptengine/AmarokScript.h
  src/scripting/scriptengine/AmarokScriptConfig.cpp
  src/scripting/scriptengine/AmarokScriptConfig.h
  src/scripting/scriptengine/AmarokScriptXml.cpp
  src/scripting/scriptengine/AmarokScriptXml.h
  src/scripting/scriptengine/AmarokScriptableServiceScript.cpp
  src/scripting/scriptengine/AmarokScriptableServiceScript.h
  src/scripting/scriptengine/AmarokServicePluginManagerScript.cpp
  src/scripting/scriptengine/AmarokServicePluginManagerScript.h
  src/scripting/scriptengine/AmarokStatusbarScript.cpp
  src/scripting/scriptengine/AmarokStatusbarScript.h
  src/scripting/scriptengine/AmarokStreamItemScript.cpp
  src/scripting/scriptengine/AmarokStreamItemScript.h
  src/scripting/scriptengine/AmarokWindowScript.cpp
  src/scripting/scriptengine/AmarokWindowScript.h
  src/scripting/scriptengine/PHAACG2.py
  src/scripting/scriptengine/ScriptImporter.cpp
  src/scripting/scriptengine/ScriptImporter.h
  src/scripting/scriptengine/ScriptingDefines.cpp
  src/scripting/scriptengine/ScriptingDefines.h
  src/scripting/scriptengine/exporters/CollectionTypeExporter.cpp
  src/scripting/scriptengine/exporters/CollectionTypeExporter.h
  src/scripting/scriptengine/exporters/MetaTypeExporter.cpp
  src/scripting/scriptengine/exporters/MetaTypeExporter.h
  src/scripting/scriptengine/exporters/PlaylistExporter.cpp
  src/scripting/scriptengine/exporters/PlaylistExporter.h
  src/scripting/scriptengine/exporters/PlaylistProviderExporter.cpp
  src/scripting/scriptengine/exporters/PlaylistProviderExporter.h
  src/scripting/scriptengine/exporters/QueryMakerExporter.cpp
  src/scripting/scriptengine/exporters/QueryMakerExporter.h
  src/scripting/scriptengine/exporters/ScriptableBiasExporter.cpp
  src/scripting/scriptengine/exporters/ScriptableBiasExporter.h
  src/scripting/scriptmanager/ScriptItem.cpp
  src/s