Re: Review Request: Some changes to make Amarok appearance more pretty

2012-08-17 Thread Ralf Engels 


> On May 26, 2012, 3:23 p.m., Ralf Engels wrote:
> > This is outstanding since quite some time.
> > I liked it somehow.
> > 
> > What is the current state? There was a question open, can that be solved?

State? Still valid?


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review14180
---


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/420/
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/423/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes 


On March 22, 2012, 10:04 p.m., Lucas Gomes wrote:
> > Could you please explain what are the benefits (direct, current - not 
> > hypothetical or philosofical) of the TreeItem -> NormalTreeItem, 
> > MergedTreeItem split? Where exactly is avoids code duplication?
> 
> Lucas Gomes wrote:
> Ok, first ignore revision five. In it I've tryed to put the extra info 
> string with the podcast title in Qt::DisplayRole(Look at PodcastModel changes 
> in revision 5), but the extra info won't appear if the PodcastBrowser width 
> isn't bigger enought to show the '\n' character. It's surely the kind of hack 
> that I'd prefer to avoid.
> 
> It's not possible to do this without making the use of delegates. I've 
> tryed again yesterday, but with no success. And the problem is that we cannot 
> set a delegate to merged view mode in the current implementation(Look by 
> yourself in PlaylistBrowserCategory). 
> 
> Also, I have split TreeItems in Normal and Merged because the latter 
> doesn't show the provider item. So the logic is a bit different and it isn't 
> possible to have only one for both view modes if we want to show some extra 
> info(This review proposal). 
> 
> Well, since we aren't showing track count in the playlist and collection 
> browser anymore, we can simplify it by using a single provider for them. 
> Though I believe that it's best to have separate(normal and merged) classes. 
> Basically, because they'd be already done in case we want to change anything 
> via their delegators.
> 
> Anyone has any suggestion about how to achieve the extra info goal in a 
> different/more appropriate manner?

Warning: Past revisions aren't ready yet :o.

Almost forgot. I've found some bugs yesterday too, so I'll wait to know if 
everyone understands the situation. Then I'll make another revision that's 
really working as expected. Or do it in another way if someone has an 
alternative solution.


- Lucas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review11771
---


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes 


On March 22, 2012, 10:04 p.m., Lucas Gomes wrote:
> > Could you please explain what are the benefits (direct, current - not 
> > hypothetical or philosofical) of the TreeItem -> NormalTreeItem, 
> > MergedTreeItem split? Where exactly is avoids code duplication?

Ok, first ignore revision five. In it I've tryed to put the extra info string 
with the podcast title in Qt::DisplayRole(Look at PodcastModel changes in 
revision 5), but the extra info won't appear if the PodcastBrowser width isn't 
bigger enought to show the '\n' character. It's surely the kind of hack that 
I'd prefer to avoid.

It's not possible to do this without making the use of delegates. I've tryed 
again yesterday, but with no success. And the problem is that we cannot set a 
delegate to merged view mode in the current implementation(Look by yourself in 
PlaylistBrowserCategory). 

Also, I have split TreeItems in Normal and Merged because the latter doesn't 
show the provider item. So the logic is a bit different and it isn't possible 
to have only one for both view modes if we want to show some extra info(This 
review proposal). 

Well, since we aren't showing track count in the playlist and collection 
browser anymore, we can simplify it by using a single provider for them. Though 
I believe that it's best to have separate(normal and merged) classes. 
Basically, because they'd be already done in case we want to change anything 
via their delegators.

Anyone has any suggestion about how to achieve the extra info goal in a 
different/more appropriate manner?


- Lucas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review11771
---


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/Podcast

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-05-26 Thread Ralf Engels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review14180
---


This is outstanding since quite some time.
I liked it somehow.

What is the current state? There was a question open, can that be solved?

- Ralf Engels


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/420/
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/423/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-03-23 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review11771
---



src/browsers/AbstractTreeViewDelegate.h


I would be more verbose here:

bigFontMetrics();
smallFontMetrics();



src/browsers/CollectionTreeItemModelBase.cpp


Sorry, I fooled you in a bad way, I wanted to say that the height should be 
left at 34 pixels (i.e. untouched).


Could you please explain what are the benefits (direct, current - not 
hypothetical or philosofical) of the TreeItem -> NormalTreeItem, MergedTreeItem 
split? Where exactly is avoids code duplication?

- Matěj Laitl


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/420/
> PodcastBr

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-30 Thread Lucas Gomes 


> On Jan. 30, 2012, 8:17 a.m., Bart Cerneels wrote:
> > The screenshots look good. Perhaps some font effects (italics, bold) can be 
> > added to highlight channels with new episodes to make it even more 
> > intuitive?
> > 
> > Have not take a better look at the code yet. My remark on an early version 
> > was that it was quite invasive (new abstract class for Collection and 
> > PodcastBrowser) and would prefer if it's mainly changes in the podcast view.

It's a good ideia to add font effects for podcast with new episodes.

I understand your concern, but I done this changes because the overall code 
design of the way PlaylistBrowser and CollectionBrowser used delegates was too 
much restrictive. For instance, I couldn't apply a delegate to any of the 
merged view modes. 

So I created a abstract class (AbstractTreeViewDelegate) and setted 
PlaylistBrowser/CollectionBrowser to accept two of them, one for the normal 
view mode and one for the merged view mode, in the initializeView() function.

I also removed some repetitive code related to font creation in these delegates.

In my point of view, these changes were necessary to keep or not extending the 
code capability, that is something desirable in every piece of code.


- Lucas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review10222
---


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREAT

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-30 Thread Bart Cerneels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review10222
---


The screenshots look good. Perhaps some font effects (italics, bold) can be 
added to highlight channels with new episodes to make it even more intuitive?

Have not take a better look at the code yet. My remark on an early version was 
that it was quite invasive (new abstract class for Collection and 
PodcastBrowser) and would prefer if it's mainly changes in the podcast view.

- Bart Cerneels


On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 29, 2012, 6:42 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   ChangeLog 70dd420 
>   src/CMakeLists.txt 4241e69 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/420/
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/423/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-29 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
---

(Updated Jan. 29, 2012, 6:42 p.m.)


Review request for Amarok and Bart Cerneels.


Changes
---

Album images in podcast browser should be left at 32 pixel size.
The episode count extra info code was moved to PodcastModel::data() DisplayRole 
role.
Removed some unnecessary code.


Description
---

This is my attempt to make QTreeView subclasses items, used in Amarok, more 
pretty by displaying some extra information. Notice that these extra 
information are usually the quantity of tracks in a album, the quantity of 
episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some 
questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser 
too?
2) Is there any extra information that you think it's relevant to be showed 
somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs (updated)
-

  src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
  ChangeLog 70dd420 
  src/CMakeLists.txt 4241e69 
  src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
  src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
  src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
  src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
  src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
  src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
  src/core/podcasts/PodcastMeta.h 679f7ac 
  src/core/podcasts/PodcastMeta.cpp b9851f7 
  src/widgets/TrackSelectWidget.cpp 5bd5059 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Screenshots (updated)
---

CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/420/
PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/423/


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-27 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
---

(Updated Jan. 27, 2012, 1:11 a.m.)


Review request for Amarok and Bart Cerneels.


Changes
---

Fixed some problems with plural localization. 
Podcast's cover are now aligned and bigger. 
The star, that appears when a podcast has a new episode, is aligned on the 
bottonm left corner of the podcast cover. 
Removed the track count info from Podcastbrowser due to other developers 
preference.


Description
---

This is my attempt to make QTreeView subclasses items, used in Amarok, more 
pretty by displaying some extra information. Notice that these extra 
information are usually the quantity of tracks in a album, the quantity of 
episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some 
questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser 
too?
2) Is there any extra information that you think it's relevant to be showed 
somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs (updated)
-

  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/CollectionTreeItem.h 3438adc 
  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Screenshots (updated)
---

CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/420/
PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/421/


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-26 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review10114
---


Hmm, either I'm completely dumb or v4 of the patch you submitted is not a 
difference between Amarok master and the desired code, but a difference between 
previous version of the patch and the desired code. Please submit a patch that 
will apply to amarok master by itself. Thanks for removing the track count from 
collection browser.

Speaking about alignment, I think you misunderstood the review, my 
interpretation is that:
 * album images in podcast browser should be left at 32 pixel size
 * alignment issue was that the space between upper border of the row and the 
"6 Minute English" should be equal to the space between the lower border of the 
row and "1 (o new) episode". E.g. to move the whole text slightly upwards.


Screenshot: PodcastBrowser

Should be moved upwards.

- Matěj Laitl


On Jan. 27, 2012, 1:11 a.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 27, 2012, 1:11 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/CollectionTreeItem.h 3438adc 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/420/
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/421/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-19 Thread Matěj Laitl 
On 18. 1. 2012 Lucas Lira Gomes wrote:
> Hi everyone,
>  
> Does anybody else but Myriam doesn't liked the extra info on the
> CollectionBrowser? If you haven't opined yet please let us know what's your
> opinion and explain why you prefer one way or another.

I agree with Myriam. Track count is useful in Podcasts, not in collection 
browser. I also agree with Nikita about the alignment issues.

> Maybe Myriam is right, but this feature could be possibly like the album
> art. You can hide it or you can show it, thereby pleasing everyone. Also,
> if the majority doesn't liked the extra info on CollectionBrowser I can
> remove it easily ^^.

Well, we try to keep ammount of micro-options low.

Matěj
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Lucas Lira Gomes 
Hi everyone,

Does anybody else but Myriam doesn't liked the extra info on the 
CollectionBrowser? If you haven't opined yet please let us know what's your 
opinion and explain why you prefer one way or another.

Maybe Myriam is right, but this feature could be possibly like the album art. 
You can hide it or you can show it, thereby pleasing everyone. Also, if the 
majority doesn't liked the extra info on CollectionBrowser I can remove it 
easily ^^.

By the way, I liked Lorenz Röhrl suggestion.

Regards, Lucas Lira Gomes.

On Wednesday 18 January 2012 11:01:43 Myriam Schweingruber wrote:
> On Wed, Jan 18, 2012 at 10:56, Lorenz Röhrl  wrote:
> > Hi,
> > 
> >> So, please help me to improve this feature even more by answering some
> >> questions:
> >> 
> >> 1) Should I show the quantity of tracks on playlists listed in
> >> PlaylistBrowser too? 2) Is there any extra information that you think
> >> it's relevant to be showed somewhere (In QTreeViews)?
> > 
> > I really like that idea.
> > 
> > To answer question #2:
> > 
> > It would be great if the track rating for the individual tracks could be
> > shown.
> > I've created a (ugly :)) mockup:
> > http://img51.imageshack.us/img51/7591/amarokrating.png
> 
> I strongly disagree, I don't think the Collection Browser should
> function like that.
> 
> If you are looking for ratings you can filter the Collection already,
> this seems an unnecessary feature overload to me.
> 
> Regards, Myriam___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Myriam Schweingruber 
On Wed, Jan 18, 2012 at 10:56, Lorenz Röhrl  wrote:
> Hi,
>
>> So, please help me to improve this feature even more by answering some 
>> questions:
>>
>> 1) Should I show the quantity of tracks on playlists listed in 
>> PlaylistBrowser too?
>> 2) Is there any extra information that you think it's relevant to be showed
>> somewhere (In QTreeViews)?
>
>
>
> I really like that idea.
>
> To answer question #2:
>
> It would be great if the track rating for the individual tracks could be
> shown.
> I've created a (ugly :)) mockup:
> http://img51.imageshack.us/img51/7591/amarokrating.png

I strongly disagree, I don't think the Collection Browser should
function like that.

If you are looking for ratings you can filter the Collection already,
this seems an unnecessary feature overload to me.

Regards, Myriam

-- 
Proud member of the Amarok and KDE Community
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Lorenz Röhrl 
Hi,

> So, please help me to improve this feature even more by answering some 
> questions:
>
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed
> somewhere (In QTreeViews)?



I really like that idea.

To answer question #2:

It would be great if the track rating for the individual tracks could be
shown.
I've created a (ugly :)) mockup:
http://img51.imageshack.us/img51/7591/amarokrating.png

What do you think?

Cu
Hurra
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-18 Thread Nikita Skovoroda 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review9902
---


I am not a kde developer, but to me it looks like the items on the screenshots 
are misaligned.
Would it be possible to lift them up a bit, so the top and bottom margins would 
be equal?

- Nikita Skovoroda


On Jan. 4, 2012, 12:52 a.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 4, 2012, 12:52 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/402/
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/401/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-15 Thread Ralf Engels 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review9846
---


Some problems with plural localization.
Apart from that the fix looks harmless.


src/browsers/CollectionTreeItemModelBase.cpp


The text scanner will not pick this text up.
Use i18np for that.



src/browsers/playlistbrowser/PodcastModel.cpp


Same here. i18np


- Ralf Engels


On Jan. 4, 2012, 12:52 a.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 4, 2012, 12:52 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/401/
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/402/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-04 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
---

(Updated Jan. 4, 2012, 12:52 a.m.)


Review request for Amarok and Bart Cerneels.


Changes
---

Just ignore revision number 2. I don't know how to remove it :/.


Description
---

This is my attempt to make QTreeView subclasses items, used in Amarok, more 
pretty by displaying some extra information. Notice that these extra 
information are usually the quantity of tracks in a album, the quantity of 
episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some 
questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser 
too?
2) Is there any extra information that you think it's relevant to be showed 
somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs (updated)
-

  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Screenshots
---

PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/402/
CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/401/


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-04 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
---

(Updated Jan. 4, 2012, 12:43 a.m.)


Review request for Amarok and Bart Cerneels.


Changes
---

Made both track count and episode count text a little bit less technical.


Description
---

This is my attempt to make QTreeView subclasses items, used in Amarok, more 
pretty by displaying some extra information. Notice that these extra 
information are usually the quantity of tracks in a album, the quantity of 
episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some 
questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser 
too?
2) Is there any extra information that you think it's relevant to be showed 
somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs (updated)
-

  src/CMakeLists.txt 7c2335d 
  src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
  src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
  src/browsers/CollectionTreeItem.h 3438adc 
  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
  src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
  src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
  src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
  src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
  src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
  src/core/podcasts/PodcastMeta.h 679f7ac 
  src/core/podcasts/PodcastMeta.cpp b9851f7 
  src/widgets/TrackSelectWidget.cpp 5bd5059 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Screenshots (updated)
---

PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/402/
CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/401/


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Myriam Schweingruber 


> On Jan. 2, 2012, 7:37 p.m., Sven Krohlas wrote:
> > Can you make the text a little bit less technical? Track Count X -> X 
> > Tracks, Episode Cunt: Y -> Y Episodes

I think this is a good idea for the podcast list, but I am not sure it really 
matters for the albums. Just my 2 ct.


- Myriam


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review9477
---


On Jan. 2, 2012, 2:38 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 2, 2012, 2:38 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7c2335d 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/CollectionTreeItem.h 3438adc 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/389/
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/390/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Sven Krohlas 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review9477
---


Can you make the text a little bit less technical? Track Count X -> X Tracks, 
Episode Cunt: Y -> Y Episodes

- Sven Krohlas


On Jan. 2, 2012, 2:38 p.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 2, 2012, 2:38 p.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7c2335d 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/CollectionTreeItem.h 3438adc 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Screenshots
> ---
> 
> PodcastBrowser
>   http://git.reviewboard.kde.org/r/103603/s/389/
> CollectionBrowser
>   http://git.reviewboard.kde.org/r/103603/s/390/
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
---

(Updated Jan. 2, 2012, 2:38 p.m.)


Review request for Amarok and Bart Cerneels.


Changes
---

Look above the album name in the screenshot of CollectionBrowser. You will see 
that now there is the track count for every album. Also, I had done similar 
changes in the PodcastBrowser. Those are the perceptible changes at the user 
interface. 

In the programming level, I had modified PlayslistBrowserCategory, 
CollectionWidget and PodcastCategory, in order to be easier to make delegates 
for their views. Also, it's easy to implement this system for more QTreeViews 
used in Amarok.


Description
---

This is my attempt to make QTreeView subclasses items, used in Amarok, more 
pretty by displaying some extra information. Notice that these extra 
information are usually the quantity of tracks in a album, the quantity of 
episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some 
questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser 
too?
2) Is there any extra information that you think it's relevant to be showed 
somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs
-

  src/CMakeLists.txt 7c2335d 
  src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
  src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
  src/browsers/CollectionTreeItem.h 3438adc 
  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
  src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
  src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
  src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
  src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
  src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
  src/core/podcasts/PodcastMeta.h 679f7ac 
  src/core/podcasts/PodcastMeta.cpp b9851f7 
  src/widgets/TrackSelectWidget.cpp 5bd5059 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Screenshots (updated)
---

PodcastBrowser
  http://git.reviewboard.kde.org/r/103603/s/389/
CollectionBrowser
  http://git.reviewboard.kde.org/r/103603/s/390/


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Matěj Laitl 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/#review9423
---


Lucas, thanks for your review request. This is a rather bigger change, could 
you describe what exactly this does and perhaps provide screen-shots that show 
all the changes?

- Matěj Laitl


On Jan. 2, 2012, 1:29 a.m., Lucas Gomes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103603/
> ---
> 
> (Updated Jan. 2, 2012, 1:29 a.m.)
> 
> 
> Review request for Amarok and Bart Cerneels.
> 
> 
> Description
> ---
> 
> This is my attempt to make QTreeView subclasses items, used in Amarok, more 
> pretty by displaying some extra information. Notice that these extra 
> information are usually the quantity of tracks in a album, the quantity of 
> episodes in a podcast and the quantity of episodes marked as new in a podcast.
> 
> So, please help me to improve this feature even more by answering some 
> questions:
> 
> 1) Should I show the quantity of tracks on playlists listed in 
> PlaylistBrowser too?
> 2) Is there any extra information that you think it's relevant to be showed 
> somewhere (In QTreeViews)?
> 
> Link for my personal repository (Look for ui-improve branch):
> http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7c2335d 
>   src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
>   src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
>   src/browsers/CollectionTreeItem.h 3438adc 
>   src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
>   src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
>   src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
>   src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
>   src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp 
> PRE-CREATION 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
>   src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
>   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
>   src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
>   src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
>   src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
>   src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
>   src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
>   src/core/podcasts/PodcastMeta.h 679f7ac 
>   src/core/podcasts/PodcastMeta.cpp b9851f7 
>   src/widgets/TrackSelectWidget.cpp 5bd5059 
> 
> Diff: http://git.reviewboard.kde.org/r/103603/diff/diff
> 
> 
> Testing
> ---
> 
> This patch should build. Everything is working as expected and there aren't 
> any known issues.
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103603/
---

(Updated Jan. 2, 2012, 1:29 a.m.)


Review request for Amarok and Bart Cerneels.


Description
---

This is my attempt to make QTreeView subclasses items, used in Amarok, more 
pretty by displaying some extra information. Notice that these extra 
information are usually the quantity of tracks in a album, the quantity of 
episodes in a podcast and the quantity of episodes marked as new in a podcast.

So, please help me to improve this feature even more by answering some 
questions:

1) Should I show the quantity of tracks on playlists listed in PlaylistBrowser 
too?
2) Is there any extra information that you think it's relevant to be showed 
somewhere (In QTreeViews)?

Link for my personal repository (Look for ui-improve branch):
http://quickgit.kde.org/index.php?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary


Diffs
-

  src/CMakeLists.txt 7c2335d 
  src/browsers/AbstractTreeViewDelegate.h PRE-CREATION 
  src/browsers/AbstractTreeViewDelegate.cpp PRE-CREATION 
  src/browsers/CollectionTreeItem.h 3438adc 
  src/browsers/CollectionTreeItemModelBase.cpp e7f8e62 
  src/browsers/collectionbrowser/CollectionBrowserTreeView.cpp 35a8222 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionMergedTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.h 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionNormalTreeItemDelegate.cpp 
PRE-CREATION 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.h 8a189e6 
  src/browsers/collectionbrowser/CollectionTreeItemDelegate.cpp 755be00 
  src/browsers/collectionbrowser/CollectionWidget.cpp ac1c26d 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.h 9198d43 
  src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp 0c2f9c1 
  src/browsers/playlistbrowser/PlaylistBrowserView.cpp 9c4236d 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.h 3a094b0 
  src/browsers/playlistbrowser/PlaylistTreeItemDelegate.cpp bc76551 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.h 941268c 
  src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 12f2676 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.h 9a01dbe 
  src/browsers/playlistbrowser/PlaylistsInFoldersProxy.cpp 4268a82 
  src/browsers/playlistbrowser/PodcastCategory.cpp 1c353dc 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastMergedTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/PodcastModel.h e88f4a1 
  src/browsers/playlistbrowser/PodcastModel.cpp 18334f6 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.h PRE-CREATION 
  src/browsers/playlistbrowser/PodcastNormalTreeItemDelegate.cpp PRE-CREATION 
  src/browsers/playlistbrowser/UserPlaylistCategory.cpp b48a55f 
  src/core-impl/podcasts/sql/SqlPodcastMeta.h 42ad039 
  src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 1c3bdf4 
  src/core/podcasts/PodcastMeta.h 679f7ac 
  src/core/podcasts/PodcastMeta.cpp b9851f7 
  src/widgets/TrackSelectWidget.cpp 5bd5059 

Diff: http://git.reviewboard.kde.org/r/103603/diff/diff


Testing
---

This patch should build. Everything is working as expected and there aren't any 
known issues.


Thanks,

Lucas Gomes

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel