Re: [arch-projects] netcfg: fixes and features
Am 28.02.2012 09:57, schrieb Jouke Witteveen: On Tue, Feb 28, 2012 at 08:59, Thomas Bächler tho...@archlinux.org wrote: Am 28.02.2012 00:31, schrieb Jouke Witteveen: Dear Thomas and the rest, A few of us have been looking at the netcfg code lately. One thing that came to light was that FS#24599 is actualy a wpa_actiond bug, so, Thomas, could you take it upon you? I looked into it shortly, the last comment is correct. That comment was mine. I wondered whether there was a reason to look at occurrences of ']'. The lack of a proper API to the wpa_supplicant management interface forces us to parse the output of the status notifications ourselves. The notification in question looks like this: 2CTRL-EVENT-CONNECTED - Connection to 00:11:22:33:44:55 completed (reauth) [id=10 id_str=profile_name] This format is about as primitive and broken as my parser. Given that this is only a single line, the patch I'll send in a minute SHOULD solve this, but I can't test this anytime soon. signature.asc Description: OpenPGP digital signature
[arch-projects] [wpa_actiond] [PATCH (untested)] Fix action call for profile names that contain ']'.
Fixes FS#24599
---
wpa_actiond.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/wpa_actiond.c b/wpa_actiond.c
index 84eef63..69eb6f2 100644
--- a/wpa_actiond.c
+++ b/wpa_actiond.c
@@ -188,7 +188,7 @@ static void parse_wpa_event(const char *msg, enum wpaevent
*ev, char *idstr)
pos = strstr(pos, id_str=);
if(pos != NULL) {
pos += strlen(id_str=);
- pos2 = index(pos, ']');
+ pos2 = rindex(pos, ']');
strncpy(idstr, pos, min(pos2-pos, IDSTRLEN-1));
idstr[min(pos2-pos, IDSTRLEN-1)] = '\0';
}
--
1.7.9.2
Re: [arch-projects] [PATCH 4/4] fhs: disallow installing in /srv
On Sun, Feb 26, 2012 at 4:20 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Feb 26, 2012 at 3:46 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 2:56 PM, Tom Gundersen t...@jklm.no wrote: /srv is admin territory, similar to /home. No package should put stuff there. Are you sure of this? Currently many http packages use /srv/http to put static files. e.g backuppc, flyspray, roundcube... http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM The consensus seems to be that we don't let packages put stuff in /srv, so I thought it would make sense to let namcap reflect this. Sure ! I just wondering what is the arch way of doing web package :) -- Sébastien Luttringer www.seblu.net
Re: [arch-projects] [PATCH 4/4] fhs: disallow installing in /srv
On Tue, Feb 28, 2012 at 3:34 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 4:20 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Feb 26, 2012 at 3:46 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 2:56 PM, Tom Gundersen t...@jklm.no wrote: /srv is admin territory, similar to /home. No package should put stuff there. Are you sure of this? Currently many http packages use /srv/http to put static files. e.g backuppc, flyspray, roundcube... http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM The consensus seems to be that we don't let packages put stuff in /srv, so I thought it would make sense to let namcap reflect this. Sure ! I just wondering what is the arch way of doing web package :) -- Sébastien Luttringer www.seblu.net Take a look out phpmyadmin -- Jelle van der Waa
Re: [arch-projects] [PATCH 4/4] fhs: disallow installing in /srv
On Tue, Feb 28, 2012 at 3:51 PM, Jelle van der Waa je...@vdwaa.nl wrote: On Tue, Feb 28, 2012 at 3:34 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 4:20 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Feb 26, 2012 at 3:46 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 2:56 PM, Tom Gundersen t...@jklm.no wrote: /srv is admin territory, similar to /home. No package should put stuff there. Are you sure of this? Currently many http packages use /srv/http to put static files. e.g backuppc, flyspray, roundcube... http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM The consensus seems to be that we don't let packages put stuff in /srv, so I thought it would make sense to let namcap reflect this. Sure ! I just wondering what is the arch way of doing web package :) what's about adding /etc/webapps and /usr/share/webapps in php.ini ? We already add /srv/http. -- Sébastien Luttringer www.seblu.net
Re: [arch-projects] [PATCH 4/4] fhs: disallow installing in /srv
On Tue, Feb 28, 2012 at 5:59 PM, Seblu se...@seblu.net wrote: On Tue, Feb 28, 2012 at 3:51 PM, Jelle van der Waa je...@vdwaa.nl wrote: On Tue, Feb 28, 2012 at 3:34 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 4:20 PM, Tom Gundersen t...@jklm.no wrote: On Sun, Feb 26, 2012 at 3:46 PM, Seblu se...@seblu.net wrote: On Sun, Feb 26, 2012 at 2:56 PM, Tom Gundersen t...@jklm.no wrote: /srv is admin territory, similar to /home. No package should put stuff there. Are you sure of this? Currently many http packages use /srv/http to put static files. e.g backuppc, flyspray, roundcube... http://www.pathname.com/fhs/pub/fhs-2.3.html#SRVDATAFORSERVICESPROVIDEDBYSYSTEM The consensus seems to be that we don't let packages put stuff in /srv, so I thought it would make sense to let namcap reflect this. Sure ! I just wondering what is the arch way of doing web package :) what's about adding /etc/webapps and /usr/share/webapps in php.ini ? We already add /srv/http. Looking inside repositories for examples, phpmyadmin look like an exception. We lack of clean rules and a cleanning of our web packages. What's about a /var/lib/webapps to have writable content outside /usr ? Wiki suggest to symlink /var/lib to /usr/share/webapps? -- Sébastien Luttringer www.seblu.net
Re: [arch-projects] [PATCH 4/4] fhs: disallow installing in /srv
On Tue, Feb 28, 2012 at 11:08 AM, Seblu se...@seblu.net wrote:
On Tue, Feb 28, 2012 at 5:59 PM, Seblu se...@seblu.net wrote:
what's about adding /etc/webapps and /usr/share/webapps in php.ini ?
We already add /srv/http.
Looking inside repositories for examples, phpmyadmin look like an
exception. We lack of clean rules and a cleanning of our web packages.
What's about a /var/lib/webapps to have writable content outside
/usr ? Wiki suggest to symlink /var/lib to /usr/share/webapps?
imo, which is the only relevant opinion [sarcasm], these things should
be in /usr/share/{pkgname} like anything else, with upload
directories/etc configured to /var/lib/{pkgname}. phpmyadmin (on
debian?) IIRC works like this -- nothing should be writing to /etc,
and preferably nothing should be writing to /usr/share either
(locale-gen is the only tool i know off-hand that does this regularly,
and is incorrect imo).
on other distros these webapps are enabled by dropping configuration
files in /etc/httpd/* ... it would be nice to have a generic way of
specifying installation details (vs. just assuming apache2, which
bytes compared to uwsgi/mongrel2/nginx/{insert-here})
--
C Anthony
