Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 03/11/2013 01:17 PM, Felix Fietkau wrote: On 2013-03-11 8:51 PM, Ben Greear wrote: On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? You are just setting the country code...and country-code 0 seems to at least open up the US regulatory domain so we use it by default. You can use any country code you wish here. I'd like to have less fugly module parameter hackery please. How about either using CONFIG_CFG80211_CERTIFICATION_ONUS the way it was intended, or adding another config option that makes it bail out of ath_regd_init_wiphy() early, thus still processing the EEPROM regdomain hint and not making it binding. I get lost in the weeds when trying to understand that code, and I'm not sure where it should bail out early to accomplish the suggestion above. If by chance you have time interest to put together a patch to handle the code changes, I'll be happy to test it. Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? Do the Atheros folks have an opinion on this? John -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? You are just setting the country code...and country-code 0 seems to at least open up the US regulatory domain so we use it by default. You can use any country code you wish here. Thanks, Ben Do the Atheros folks have an opinion on this? John -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On Mon, Mar 11, 2013 at 12:51:41PM -0700, Ben Greear wrote: On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? You are just setting the country code...and country-code 0 seems to at least open up the US regulatory domain so we use it by default. You can use any country code you wish here. Ah, sorry -- I brain-locked on it being a logic value... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 2013-03-11 8:51 PM, Ben Greear wrote: On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? You are just setting the country code...and country-code 0 seems to at least open up the US regulatory domain so we use it by default. You can use any country code you wish here. I'd like to have less fugly module parameter hackery please. How about either using CONFIG_CFG80211_CERTIFICATION_ONUS the way it was intended, or adding another config option that makes it bail out of ath_regd_init_wiphy() early, thus still processing the EEPROM regdomain hint and not making it binding. - Felix ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 03/11/2013 01:17 PM, Felix Fietkau wrote: On 2013-03-11 8:51 PM, Ben Greear wrote: On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? You are just setting the country code...and country-code 0 seems to at least open up the US regulatory domain so we use it by default. You can use any country code you wish here. I'd like to have less fugly module parameter hackery please. How about either using CONFIG_CFG80211_CERTIFICATION_ONUS the way it was intended, or adding another config option that makes it bail out of ath_regd_init_wiphy() early, thus still processing the EEPROM regdomain hint and not making it binding. I am not sure what you are suggesting. I enabled this override only when ONUS is selected because I wanted it clear that users were taking their regulatory compliance into their own hands. I always want the module option at least visible so that you don't have to muck with modprobe.conf just to get ath9k.ko to load when it's compiled differently. For the second part, you want the ability to set the regdomain be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN or something like that? Thanks, Ben - Felix -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 2013-03-11 10:01 PM, Ben Greear wrote: On 03/11/2013 01:17 PM, Felix Fietkau wrote: On 2013-03-11 8:51 PM, Ben Greear wrote: On 03/11/2013 12:05 PM, John W. Linville wrote: On Mon, Mar 11, 2013 at 09:45:06AM -0700, gree...@candelatech.com wrote: From: Ben Greear gree...@candelatech.com Otherwise, can't get the Sparklan AR9380 NICs to be 5Ghz APs, since they are in world-roaming domain by default. Add this to /etc/modprobe.d/ath9k.conf: options ath9k override_eeprom_regdomain=0 Signed-off-by: Ben Greear gree...@candelatech.com Why =0 to enable it? Just to make it more confusing? You are just setting the country code...and country-code 0 seems to at least open up the US regulatory domain so we use it by default. You can use any country code you wish here. I'd like to have less fugly module parameter hackery please. How about either using CONFIG_CFG80211_CERTIFICATION_ONUS the way it was intended, or adding another config option that makes it bail out of ath_regd_init_wiphy() early, thus still processing the EEPROM regdomain hint and not making it binding. I am not sure what you are suggesting. I enabled this override only when ONUS is selected because I wanted it clear that users were taking their regulatory compliance into their own hands. And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already enables some code in cfg80211 that allows a special type of regulatory change request from user space that bypasses intersection. I always want the module option at least visible so that you don't have to muck with modprobe.conf just to get ath9k.ko to load when it's compiled differently. For the second part, you want the ability to set the regdomain be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN or something like that? Something like that, yes. It should depend on CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that strongly discourages any distribution from enabling it in their kernel builds. - Felix ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 03/11/2013 02:36 PM, Felix Fietkau wrote: On 2013-03-11 10:01 PM, Ben Greear wrote: On 03/11/2013 01:17 PM, Felix Fietkau wrote: I am not sure what you are suggesting. I enabled this override only when ONUS is selected because I wanted it clear that users were taking their regulatory compliance into their own hands. And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already enables some code in cfg80211 that allows a special type of regulatory change request from user space that bypasses intersection. I always want the module option at least visible so that you don't have to muck with modprobe.conf just to get ath9k.ko to load when it's compiled differently. For the second part, you want the ability to set the regdomain be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN or something like that? Something like that, yes. It should depend on CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that strongly discourages any distribution from enabling it in their kernel builds. It seems to me that this doesn't gain much. The ONUS configuration is already strongly discouraged from vendor kernels. If you are already compiling with ONUS set, is there any reason you'd care to disable the override module option? When you don't set the module option, nothing happens anyway... Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 2013-03-11 10:44 PM, Ben Greear wrote: On 03/11/2013 02:36 PM, Felix Fietkau wrote: On 2013-03-11 10:01 PM, Ben Greear wrote: On 03/11/2013 01:17 PM, Felix Fietkau wrote: I am not sure what you are suggesting. I enabled this override only when ONUS is selected because I wanted it clear that users were taking their regulatory compliance into their own hands. And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already enables some code in cfg80211 that allows a special type of regulatory change request from user space that bypasses intersection. I always want the module option at least visible so that you don't have to muck with modprobe.conf just to get ath9k.ko to load when it's compiled differently. For the second part, you want the ability to set the regdomain be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN or something like that? Something like that, yes. It should depend on CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that strongly discourages any distribution from enabling it in their kernel builds. It seems to me that this doesn't gain much. The ONUS configuration is already strongly discouraged from vendor kernels. If you are already compiling with ONUS set, is there any reason you'd care to disable the override module option? When you don't set the module option, nothing happens anyway... I'd like to avoid accumulating more hackish driver specific module options for working around a generic issue. - Felix ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 03/11/2013 02:51 PM, Felix Fietkau wrote: On 2013-03-11 10:44 PM, Ben Greear wrote: On 03/11/2013 02:36 PM, Felix Fietkau wrote: On 2013-03-11 10:01 PM, Ben Greear wrote: On 03/11/2013 01:17 PM, Felix Fietkau wrote: I am not sure what you are suggesting. I enabled this override only when ONUS is selected because I wanted it clear that users were taking their regulatory compliance into their own hands. And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already enables some code in cfg80211 that allows a special type of regulatory change request from user space that bypasses intersection. I always want the module option at least visible so that you don't have to muck with modprobe.conf just to get ath9k.ko to load when it's compiled differently. For the second part, you want the ability to set the regdomain be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN or something like that? Something like that, yes. It should depend on CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that strongly discourages any distribution from enabling it in their kernel builds. It seems to me that this doesn't gain much. The ONUS configuration is already strongly discouraged from vendor kernels. If you are already compiling with ONUS set, is there any reason you'd care to disable the override module option? When you don't set the module option, nothing happens anyway... I'd like to avoid accumulating more hackish driver specific module options for working around a generic issue. I don't think I'm up for any significant re-write of the regdomain logic, and I'm not sure it's worth the effort of anyone doing this for code that will be compiled out of all vendor kernels anyway... Thanks, Ben -- Ben Greear gree...@candelatech.com Candela Technologies Inc http://www.candelatech.com ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
Re: [ath9k-devel] [PATCH] ath9k: Allow over-riding reg-domain.
On 2013-03-11 11:00 PM, Ben Greear wrote: On 03/11/2013 02:51 PM, Felix Fietkau wrote: On 2013-03-11 10:44 PM, Ben Greear wrote: On 03/11/2013 02:36 PM, Felix Fietkau wrote: On 2013-03-11 10:01 PM, Ben Greear wrote: On 03/11/2013 01:17 PM, Felix Fietkau wrote: I am not sure what you are suggesting. I enabled this override only when ONUS is selected because I wanted it clear that users were taking their regulatory compliance into their own hands. And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already enables some code in cfg80211 that allows a special type of regulatory change request from user space that bypasses intersection. I always want the module option at least visible so that you don't have to muck with modprobe.conf just to get ath9k.ko to load when it's compiled differently. For the second part, you want the ability to set the regdomain be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN or something like that? Something like that, yes. It should depend on CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that strongly discourages any distribution from enabling it in their kernel builds. It seems to me that this doesn't gain much. The ONUS configuration is already strongly discouraged from vendor kernels. If you are already compiling with ONUS set, is there any reason you'd care to disable the override module option? When you don't set the module option, nothing happens anyway... I'd like to avoid accumulating more hackish driver specific module options for working around a generic issue. I don't think I'm up for any significant re-write of the regdomain logic, and I'm not sure it's worth the effort of anyone doing this for code that will be compiled out of all vendor kernels anyway... Who said anything about rewriting the regdomain logic? The code is already there. If you make it a compile time option that gets rid of the code in ath_regd_init_wiphy, it doesn't need a module parameter - iw reg set will do the job, and the default still comes from EEPROM. - Felix ___ ath9k-devel mailing list ath9k-devel@lists.ath9k.org https://lists.ath9k.org/mailman/listinfo/ath9k-devel
