Re: export bbdb fields to ispell personal dictionary

2011-12-11 Thread Roland Winkler
On Fri Dec 9 2011 Ivan Kanis wrote:
 I am pleased to release version 1.1 of bbdb spell.

Thank you! I included the file in the repository. Also I made a few
more changes to match naming conventions and to have separate
functions only when they are needed.

The default value of bbdb-ispell-dictionary-list is now '(default)
because my aspell complained it did not have a french dictionary.
Also I removed address from the default of bbdb-ispell-field-list
because these words are probably used yet more rarely elsewhere.

(dolist (bar foo)
  ...)
 
 I thought inclusion of cl was frowned upon. I have made the changes and
 the code is much nicer to read. Thanks for the suggestion.

There is also a `dolist' in subr.el (good enough for most purposes).

  - Check the code of `ispell-word' for how to avoid the `sit-for'.
(I guess there should really be a function in ispell for that
purpose that could be used by other packages, but it does not exist.)
 
 I have changed it to (ispell-accept-output 1) it looks nicer but it's
 probably doing the same thing.

I changed the code so that it sends another word to ispell. This
gives us an explicit response to wait for.

Thanks again for contributing to BBDB.

Roland

--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: export bbdb fields to ispell personal dictionary

2011-12-09 Thread Mark Simpson

Hello:

Ivan Kanis ivan.ka...@googlemail.com writes:

 I am pleased to release version 1.1 of bbdb spell.

This code doesn't seem to work with BBDB 2.36.  I get the message: 

 let: Symbol's function definition is void: bbdb-record-list

Is bbdb-spell only for BBDB v3?

Ciao
Mark


--
Learn Windows Azure Live!  Tuesday, Dec 13, 2011
Microsoft is holding a special Learn Windows Azure training event for 
developers. It will provide a great way to learn Windows Azure and what it 
provides. You can attend the event by watching it streamed LIVE online.  
Learn more at http://p.sf.net/sfu/ms-windowsazure
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: export bbdb fields to ispell personal dictionary

2011-12-08 Thread Roland Winkler
On Thu Dec 8 2011 Ivan Kanis wrote:
 Attached is version 1.0 of bbdb-ispell.el. 

Hi Ivan,

Small thing: I believe that the bbdb mailing list is better suited
for this topic.

 I think it includes all the modifications you requested. Let me
 know if you would like further improvement.

- Another small thing: Your internal variables (args of functions)
  have names like bsef-field where `bsef' is short for
  bbdb-spell-export-field. This is not quite the usual elisp
  style. Global variables should use the prefix for the package
  (such as `bbdb'). But there is no such need for internal
  variables. Anyway, a prefix such as bsef does not help so much
  because it is not very mnemonic, nor does it become clear that the
  corresponding variable is belonging to the package `bbdb' and not
  to some other package `bsef'.

- Why not use
 
  (dolist (bar foo)
...)

  instead of

  (let ((foo-2 foo))
(while foo-2
  (... (car foo-2))
  (setq foo-2 (cdr foo-2

- Check the code of `ispell-word' for how to avoid the `sit-for'.
  (I guess there should really be a function in ispell for that
  purpose that could be used by other packages, but it does not exist.)

- Really small thing:
  I suggest (setq show-trailing-whitespace t) for your lisp editing

Thanks for your help with this,

Roland

--
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: export bbdb fields to ispell personal dictionary

2011-12-08 Thread Roland Winkler
On Thu Dec 8 2011 Roland Winkler wrote:
  I think it includes all the modifications you requested. Let me
  know if you would like further improvement.

Two more things: (sorry for being picky but you asked for further
improvements :-)

- could you please use defcustom instead of defvar

- The first line of the documentation string should consist of one
  or two complete sentences that stand on their own as a summary.

  (taken from Documentation tips in the elisp manual,
  the whole appendix Tips and Conventions is very useful!)

Roland

--
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of 
discussion for anyone considering optimizing the pricing and packaging model 
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/