Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On Sat, Jan 12, 2019 at 07:18:57PM -0600, Bruce Dubbs via blfs-dev wrote: > > How is poppler supposed to get people to stop using things they don't intend > to be external? Marking things as deprecated is often ignored. > > In this case, inkscape was using an internal poppler header to define glib > constructs. The problem is not with poppler, it is with inkscape. > > The only other problem package that I know of is libreoffice. I have not > built it yet with the new poppler, so we will see if that is a problem. Of > course we can always fix libreoffice by removing --with-system-poppler. > > Looking at the patch we have for libreoffice, it appears that we are just > changing gTrue to true and GBool to bool. Why is that a poppler issue? > TeXLive is also affected, but for that I've given up on trying to keep up with poppler's machinations - what works for one release will break in the next-but-one. Hopefully, TeXLive-2019 will not be using poppler (the main use is apparently in XeTeX or XeLaTeX, if I understood the list posts correctly). I think some of the poppler changes are just gratuitous. Unfortunately, 0.72 turned out to be a vulnerability fix, so sticking with old shipped versions (TL, LO) might be a bad idea. The real problem is that people used the xpdf functionality because it was available (apparently, dealing with the structure of PDFs if I have understood why it was used). And it's a poppler issue because they have been changing the true and bool names in each release. In an ideal world, in the same way that friends would not let friends use cmake, people would not use poppler except for very limited cases. ĸen -- In my seventh decade astride this planet, and as my own cells degrade, there are some things I cannot do now: skydiving, marathon running, calculus. I couldn't do them in my 20s either, so no big loss. -- Derek Smalls, formerly of Spinal Tap -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On Sat, 2019-01-12 at 19:18 -0600, Bruce Dubbs via blfs-dev wrote: > On 01/12/2019 06:19 PM, Douglas R. Reno via blfs-dev wrote: > > On 1/12/19 5:54 PM, Ken Moffat via blfs-dev wrote: > > > On Sat, Jan 12, 2019 at 04:25:04PM -0600, Bruce Dubbs via blfs-dev wrote: > > > > > Indeed, the file goo/gtypes.h has been removed from the source tree > > > > > at the > > > > > beginning of December... > > > > > > > > > > > Changing to #include "glib/gtypes.h" in > > > > > > src/extension/internal/pdfinput/pdf-parser.h allows the build to > > > > > > pass. I'll > > > > > > change the patch. > > > > Thanks for fixing that Pierre. > > > > > > > >-- Bruce > > > Yes, many thanks. Yet again, poppler seems to go out of its way to > > > break users of the old 'unstable' interface. > > > > > > ĸen > > > > If these codebases weren't so large, and I wasn't so busy with stuff > > here, I'd offer to help upstream port at this point. > > > > We're spending almost as much time picking up the pieces from poppler as > > we are updating packages, and it's starting to get really out of hand. I > > understand that upstream doesn't want them using it, but the problem is > > that they have been for years. People are reluctant to change, and I > > understand that - I can be the same way (I still seriously dislike > > Meson/Ninja/Rust, but I have to accept that decisions were made above my > > head). > > > > I suppose what I'm trying to say is that I understand that the poppler > > upstream doesn't want anybody using the functionality, but it's too late > > and there's nothing we can do about it. > > How is poppler supposed to get people to stop using things they don't > intend to be external? Marking things as deprecated is often ignored. > > In this case, inkscape was using an internal poppler header to define > glib constructs. The problem is not with poppler, it is with inkscape. > > The only other problem package that I know of is libreoffice. I have > not built it yet with the new poppler, so we will see if that is a > problem. Of course we can always fix libreoffice by removing > --with-system-poppler. > > Looking at the patch we have for libreoffice, it appears that we are > just changing gTrue to true and GBool to bool. Why is that a poppler issue? > >-- Bruce > I can report that libreoffice does failed, both 6.1.2.1 and 6.1.4.2. In file included from /opt/wbBuild/var/sources/libreoffice-6.1.4.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx:20: /opt/wbBuild/var/sources/libreoffice-6.1.4.2/sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.hxx:35:10: fatal error: GfxState.h: No such file or directory #include ^~~~ compilation terminated. I've reverted poppler back to 0.72.0 and will wait for another distro (probably Arch) to come out with a patch. Regards, Wayne. -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On 01/12/2019 06:19 PM, Douglas R. Reno via blfs-dev wrote: On 1/12/19 5:54 PM, Ken Moffat via blfs-dev wrote: On Sat, Jan 12, 2019 at 04:25:04PM -0600, Bruce Dubbs via blfs-dev wrote: Indeed, the file goo/gtypes.h has been removed from the source tree at the beginning of December... Changing to #include "glib/gtypes.h" in src/extension/internal/pdfinput/pdf-parser.h allows the build to pass. I'll change the patch. Thanks for fixing that Pierre. -- Bruce Yes, many thanks. Yet again, poppler seems to go out of its way to break users of the old 'unstable' interface. ĸen If these codebases weren't so large, and I wasn't so busy with stuff here, I'd offer to help upstream port at this point. We're spending almost as much time picking up the pieces from poppler as we are updating packages, and it's starting to get really out of hand. I understand that upstream doesn't want them using it, but the problem is that they have been for years. People are reluctant to change, and I understand that - I can be the same way (I still seriously dislike Meson/Ninja/Rust, but I have to accept that decisions were made above my head). I suppose what I'm trying to say is that I understand that the poppler upstream doesn't want anybody using the functionality, but it's too late and there's nothing we can do about it. How is poppler supposed to get people to stop using things they don't intend to be external? Marking things as deprecated is often ignored. In this case, inkscape was using an internal poppler header to define glib constructs. The problem is not with poppler, it is with inkscape. The only other problem package that I know of is libreoffice. I have not built it yet with the new poppler, so we will see if that is a problem. Of course we can always fix libreoffice by removing --with-system-poppler. Looking at the patch we have for libreoffice, it appears that we are just changing gTrue to true and GBool to bool. Why is that a poppler issue? -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On 1/12/19 5:54 PM, Ken Moffat via blfs-dev wrote: On Sat, Jan 12, 2019 at 04:25:04PM -0600, Bruce Dubbs via blfs-dev wrote: Indeed, the file goo/gtypes.h has been removed from the source tree at the beginning of December... Changing to #include "glib/gtypes.h" in src/extension/internal/pdfinput/pdf-parser.h allows the build to pass. I'll change the patch. Thanks for fixing that Pierre. -- Bruce Yes, many thanks. Yet again, poppler seems to go out of its way to break users of the old 'unstable' interface. ĸen If these codebases weren't so large, and I wasn't so busy with stuff here, I'd offer to help upstream port at this point. We're spending almost as much time picking up the pieces from poppler as we are updating packages, and it's starting to get really out of hand. I understand that upstream doesn't want them using it, but the problem is that they have been for years. People are reluctant to change, and I understand that - I can be the same way (I still seriously dislike Meson/Ninja/Rust, but I have to accept that decisions were made above my head). I suppose what I'm trying to say is that I understand that the poppler upstream doesn't want anybody using the functionality, but it's too late and there's nothing we can do about it. Thanks for fixing it Pierre. -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On Sat, Jan 12, 2019 at 04:25:04PM -0600, Bruce Dubbs via blfs-dev wrote: > > > > > > > Indeed, the file goo/gtypes.h has been removed from the source tree at the > > beginning of December... > > > > > Changing to #include "glib/gtypes.h" in > > > src/extension/internal/pdfinput/pdf-parser.h allows the build to pass. > > > I'll > > > change the patch. > > Thanks for fixing that Pierre. > > -- Bruce Yes, many thanks. Yet again, poppler seems to go out of its way to break users of the old 'unstable' interface. ĸen -- In my seventh decade astride this planet, and as my own cells degrade, there are some things I cannot do now: skydiving, marathon running, calculus. I couldn't do them in my 20s either, so no big loss. -- Derek Smalls, formerly of Spinal Tap -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On 01/12/2019 01:42 PM, Pierre Labastie via blfs-dev wrote: On 12/01/2019 20:36, Pierre Labastie via blfs-dev wrote: On 11/01/2019 21:46, Douglas R. Reno via blfs-dev wrote: On 1/11/19 10:44 AM, Bruce Dubbs via blfs-dev wrote: On 01/11/2019 07:52 AM, Ryan Marsaw via blfs-dev wrote: Hello all. Poppler 0.73.0 changed the XPDF headers switch (from the NEWS file:) ... build system: * Rename ENABLE_XPDF_HEADERS to ENABLE_UNSTABLE_API_ABI_HEADERS ... Indeed, when running the BLFS instructions I get the following: "CMake Warning: Manually-specified variables were not used by the project: ENABLE_XPDF_HEADERS" Right. I forgot to update that yesterday. Thanks for the reminder. That switch has been in the book for a long time. I think I need to double check to see if it is still needed. -- Bruce If you do, the list of things should include Libreoffice and Inkscape at least with poppler-0.73.0 and the switch ENABLE_UNSTABLE_API_ABI_HEADERS, I get nevertheless an error in Inkscape: - [ 41%] Building CXX object src/CMakeFiles/inkscape_base.dir/extension/internal/pdfinput/pdf-input.cpp.o In file included from /sources/inkscape/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-input.cpp:50: /sources/inkscape/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-parser.h:30:10: erreur fatale: goo/gtypes.h : Aucun fichier ou dossier de ce type #include "goo/gtypes.h" ^~ compilation terminée. - Indeed, the file goo/gtypes.h has been removed from the source tree at the beginning of December... Changing to #include "glib/gtypes.h" in src/extension/internal/pdfinput/pdf-parser.h allows the build to pass. I'll change the patch. Thanks for fixing that Pierre. -- Bruce -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On 12/01/2019 20:36, Pierre Labastie via blfs-dev wrote: > On 11/01/2019 21:46, Douglas R. Reno via blfs-dev wrote: >> >> On 1/11/19 10:44 AM, Bruce Dubbs via blfs-dev wrote: >>> On 01/11/2019 07:52 AM, Ryan Marsaw via blfs-dev wrote: Hello all. Poppler 0.73.0 changed the XPDF headers switch (from the NEWS file:) ... build system: * Rename ENABLE_XPDF_HEADERS to ENABLE_UNSTABLE_API_ABI_HEADERS ... Indeed, when running the BLFS instructions I get the following: "CMake Warning: Manually-specified variables were not used by the project: ENABLE_XPDF_HEADERS" >>> >>> Right. I forgot to update that yesterday. Thanks for the reminder. >>> >>> That switch has been in the book for a long time. I think I need to double >>> check to see if it is still needed. >>> >>> -- Bruce >>> >> If you do, the list of things should include Libreoffice and Inkscape at >> least >> > > with poppler-0.73.0 and the switch ENABLE_UNSTABLE_API_ABI_HEADERS, I get > nevertheless an error in Inkscape: > - > [ 41%] Building CXX object > src/CMakeFiles/inkscape_base.dir/extension/internal/pdfinput/pdf-input.cpp.o > In file included from > /sources/inkscape/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-input.cpp:50: > /sources/inkscape/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-parser.h:30:10: > erreur fatale: goo/gtypes.h : Aucun fichier ou dossier de ce type > #include "goo/gtypes.h" > ^~ > compilation terminée. > - > Indeed, the file goo/gtypes.h has been removed from the source tree at the beginning of December... > Changing to #include "glib/gtypes.h" in > src/extension/internal/pdfinput/pdf-parser.h allows the build to pass. I'll > change the patch. Pierre -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
Re: [blfs-dev] Poppler 0.73.0 and XPDF Headers
On 11/01/2019 21:46, Douglas R. Reno via blfs-dev wrote: > > On 1/11/19 10:44 AM, Bruce Dubbs via blfs-dev wrote: >> On 01/11/2019 07:52 AM, Ryan Marsaw via blfs-dev wrote: >>> Hello all. >>> >>> Poppler 0.73.0 changed the XPDF headers switch (from the NEWS file:) >>> >>> ... >>> build system: >>> * Rename ENABLE_XPDF_HEADERS to ENABLE_UNSTABLE_API_ABI_HEADERS >>> ... >>> >>> Indeed, when running the BLFS instructions I get the following: >>> "CMake Warning: >>> Manually-specified variables were not used by the project: >>> >>> ENABLE_XPDF_HEADERS" >> >> Right. I forgot to update that yesterday. Thanks for the reminder. >> >> That switch has been in the book for a long time. I think I need to double >> check to see if it is still needed. >> >> -- Bruce >> > If you do, the list of things should include Libreoffice and Inkscape at least > with poppler-0.73.0 and the switch ENABLE_UNSTABLE_API_ABI_HEADERS, I get nevertheless an error in Inkscape: - [ 41%] Building CXX object src/CMakeFiles/inkscape_base.dir/extension/internal/pdfinput/pdf-input.cpp.o In file included from /sources/inkscape/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-input.cpp:50: /sources/inkscape/inkscape-0.92.3/src/extension/internal/pdfinput/pdf-parser.h:30:10: erreur fatale: goo/gtypes.h : Aucun fichier ou dossier de ce type #include "goo/gtypes.h" ^~ compilation terminée. - Changing to #include "glib/gtypes.h" in src/extension/internal/pdfinput/pdf-parser.h allows the build to pass. I'll change the patch. Pierre -- http://lists.linuxfromscratch.org/listinfo/blfs-dev FAQ: http://www.linuxfromscratch.org/blfs/faq.html Unsubscribe: See the above information page
