[jira] [Created] (BOOKKEEPER-662) Major GC should kick in immediately if remaining space reaches a warning threshold
Sijie Guo created BOOKKEEPER-662: Summary: Major GC should kick in immediately if remaining space reaches a warning threshold Key: BOOKKEEPER-662 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-662 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-server Reporter: Sijie Guo Assignee: Aniruddha Fix For: 4.3.0 in a high throughput case, Major GC should kick in immediately if remaining spaces reaches a warning threshold. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (BOOKKEEPER-661) Turn readonly back to writable if spaces are reclaimed.
Sijie Guo created BOOKKEEPER-661: Summary: Turn readonly back to writable if spaces are reclaimed. Key: BOOKKEEPER-661 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-661 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-server Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.3.0 should be able to turn a bookie from readonly back to writable if the spaces are reclaimed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719300#comment-13719300 ] Sijie Guo commented on BOOKKEEPER-632: -- please add timeout option. I guessed we need to modify precommit hook to check '@Test' to ensure there is a timeout provided. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-602) we should have request timeouts rather than channel timeout in PerChannelBookieClient
[ https://issues.apache.org/jira/browse/BOOKKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-602: - Assignee: Aniruddha (was: Sijie Guo) > we should have request timeouts rather than channel timeout in > PerChannelBookieClient > - > > Key: BOOKKEEPER-602 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-602 > Project: Bookkeeper > Issue Type: Bug >Affects Versions: 4.2.0, 4.2.1 >Reporter: Sijie Guo >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-602.diff > > > currently we only have readTimeout in netty channel, it timeouts only when > there is no activities in that channel, but it can't track timeouts of > individual requests. if a channel continues having read entry activities, it > might shadow a slow add entry response, which is bad impacting add latency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-602) we should have request timeouts rather than channel timeout in PerChannelBookieClient
[ https://issues.apache.org/jira/browse/BOOKKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719292#comment-13719292 ] Sijie Guo commented on BOOKKEEPER-602: -- The reason why we put getAddEntryTimeout to 1 is to put the best parameter for most of cases. so the user doesn't need to tune it too much. based on this consideration, we'd prefer putting the tuned value as default value and having TestBKConfiguration to handle low-throughput case (this TestBKConfiguration also exists in the journal improvements we made in BOOKKEEPER-657). if you feel strongly about it, I could change. let me know. 1 second is based on performance evaluation, 1) we don't want a slow add request to cause too much pending requests accumulated in client (which cause bad gc behavior) 2) for latency consideration. the failure test is also related to the configuration setting. I forgot to bring the changes for hedwig when generating the patch. will add soon. > we should have request timeouts rather than channel timeout in > PerChannelBookieClient > - > > Key: BOOKKEEPER-602 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-602 > Project: Bookkeeper > Issue Type: Bug >Affects Versions: 4.2.0, 4.2.1 >Reporter: Sijie Guo >Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-602.diff > > > currently we only have readTimeout in netty channel, it timeouts only when > there is no activities in that channel, but it can't track timeouts of > individual requests. if a channel continues having read entry activities, it > might shadow a slow add entry response, which is bad impacting add latency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated BOOKKEEPER-632: - Attachment: BOOKKEEPER-632.patch Fixed test failures. Previously I had missed watching available bookies. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-429) Provide separate read and write threads in the bookkeeper server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719279#comment-13719279 ] Sijie Guo commented on BOOKKEEPER-429: -- >> MultipleThreadReadTest.java needs a license, it should probably be in the >> proto package as it's testing functionality there. I think it is an overall functionality not just protocol. if you feels strongly about it, I could move. just let me know. >> RequestProcessor.java should be in proto package also. It deals with RPC >> stuff. in future, it could be used to support chained request processor, to support like authentication handling. so I put the interface in a processor package to make it clean. I don't want to make proto too fat. >> I don't think we should allow 0 worker threads to be configured. It only >> exists for one test. It'd be better to fix the test. user could configure write thread to 0 which leverage netty threads to handle writes and configure read threads to a sensible number, so read would not block writes. so we don't have to spawn too much threads. the test problem could be addressed in a different ticket. I will address comment 3). > Provide separate read and write threads in the bookkeeper server > > > Key: BOOKKEEPER-429 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: BK-429.patch, BOOKKEEPER-429.diff > > > The current bookkeeper server is single threaded. The same thread handles > reads and writes. When reads are slow (possibly because of excessive seeks), > add entry operations suffer in terms of latencies. Providing separate read > and write threads helps in reducing add entry latencies and increasing > throughput even when we're facing slow reads. Having a single read thread > also results in low disk utilization because seeks can't be ordered > efficiently by the OS. Multiple read threads would help in improving the read > throughput. > Discussion on this can be found at > http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e > Reviewboard : https://reviews.apache.org/r/7560/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-659) LRU page management in ledger cache.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719275#comment-13719275
]
Hadoop QA commented on BOOKKEEPER-659:
--
Testing JIRA BOOKKEEPER-659
Patch
[BOOKKEEPER-659.diff|https://issues.apache.org/jira/secure/attachment/12594100/BOOKKEEPER-659.diff]
downloaded at Thu Jul 25 06:04:32 UTC 2013
{color:red}-1{color} Patch failed to apply to head of branch
> LRU page management in ledger cache.
>
>
> Key: BOOKKEEPER-659
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-659
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
>Reporter: Sijie Guo
>Assignee: Robin Dhamankar
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-659.diff
>
>
> better ledger page management.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-658) ledger cache refactor
[
https://issues.apache.org/jira/browse/BOOKKEEPER-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719272#comment-13719272
]
Hadoop QA commented on BOOKKEEPER-658:
--
Testing JIRA BOOKKEEPER-658
Patch
[BOOKKEEPER-658.patch|https://issues.apache.org/jira/secure/attachment/12594096/BOOKKEEPER-658.patch]
downloaded at Thu Jul 25 05:37:43 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 4 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 860
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/436/
> ledger cache refactor
> -
>
> Key: BOOKKEEPER-658
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-658
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
>Reporter: Sijie Guo
>Assignee: Robin Dhamankar
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-658.patch
>
>
> refactor ledger cache to separate in-memory page management from persistent
> management.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (BOOKKEEPER-604) Ledger storage can log an exception if GC happens concurrently.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719265#comment-13719265 ] Sijie Guo edited comment on BOOKKEEPER-604 at 7/25/13 5:58 AM: --- attach a patch as what I commented here : https://issues.apache.org/jira/browse/BOOKKEEPER-604?focusedCommentId=13696005&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13696005 - obtain fileinfo before flushing - pass fileinfo to flush - finally release fileinfo after flush was (Author: hustlmsp): attach a patch - obtain fileinfo before flushing - pass fileinfo to flush - finally release fileinfo after flush > Ledger storage can log an exception if GC happens concurrently. > --- > > Key: BOOKKEEPER-604 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-604 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.2.2, 4.3.0 > > Attachments: > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > BOOKKEEPER-604.diff, BOOKKEEPER-604.diff > > > If a ledger is flushing, and part way through,GC kicks in, it can delete the > index file before we try and flush it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-604) Ledger storage can log an exception if GC happens concurrently.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-604: - Attachment: BOOKKEEPER-604.diff attach a patch - obtain fileinfo before flushing - pass fileinfo to flush - finally release fileinfo after flush > Ledger storage can log an exception if GC happens concurrently. > --- > > Key: BOOKKEEPER-604 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-604 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.2.2, 4.3.0 > > Attachments: > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > BOOKKEEPER-604.diff, BOOKKEEPER-604.diff > > > If a ledger is flushing, and part way through,GC kicks in, it can delete the > index file before we try and flush it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-654) Bookkeeper client operations are allowed even after its closure, bk#close()
[
https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719262#comment-13719262
]
Sijie Guo commented on BOOKKEEPER-654:
--
thanks for updating.
1. in OrderedSafeExecutor, why not just catch the rejected exception rather
than adding an extra boolean flag. since this flag doesn't avoid throwing
rejected exception.
2. in LedgerOpenOp, why we need #readComplete here? an unscheduled speculative
task doesn't affect any logic.
{code}
+try {
+speculativeTask = scheduler.scheduleWithFixedDelay(
+speculativeReadRunnable, speculativeReadTimeout,
+speculativeReadTimeout, TimeUnit.MILLISECONDS);
+} catch (RuntimeException e) {
+if (lh.bk.bookieClient.isClosed()) {
+cb.readComplete(BKException.Code.BkClientClosedException,
+lh, PendingReadOp.this, PendingReadOp.this.ctx);
+return;
+}
+}
{code}
> Bookkeeper client operations are allowed even after its closure, bk#close()
> ---
>
> Key: BOOKKEEPER-654
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
>Affects Versions: 4.2.0
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 4.2.2, 4.3.0
>
> Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch,
> 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch
>
>
> User can perform below operations with the closed bookkeeper client, which
> was instantiated with external zkclient.
> - open a closed ledger
> - create a new ledger
> Also, ledgerhandle operations like fencing/add/write are infinitely hanging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-657) Journal Improvement
[
https://issues.apache.org/jira/browse/BOOKKEEPER-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719256#comment-13719256
]
Hadoop QA commented on BOOKKEEPER-657:
--
Testing JIRA BOOKKEEPER-657
Patch
[BOOKKEEPER-657.patch|https://issues.apache.org/jira/secure/attachment/12594095/BOOKKEEPER-657.patch]
downloaded at Thu Jul 25 04:30:59 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 16 testcase(s)
{color:red}-1 RAT{color}
.{color:red}-1{color} the patch seems to introduce 1 new RAT warning(s)
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 830
.Tests failed: 1
.Tests errors: 1
.The patch failed the following testcases:
.
testInconsistentSubscriptionStateAndLedgerRanges2[0](org.apache.hedwig.server.persistence.TestBookKeeperPersistenceManager)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/435/
> Journal Improvement
> ---
>
> Key: BOOKKEEPER-657
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-657
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
>Reporter: Sijie Guo
>Assignee: Robin Dhamankar
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-657.patch, BOOKKEEPER-657.patch
>
>
> separated force write thread, better group commit strategy on latency and
> throughput.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-604) Ledger storage can log an exception if GC happens concurrently.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719248#comment-13719248
]
Sijie Guo commented on BOOKKEEPER-604:
--
this change is still buggy. still leaking on following code block.
{code}
if (firstEntryList.size() == 0) {
LOG.debug("Nothing to flush for ledger {}.", l);
// nothing to do
return;
}
{code}
> Ledger storage can log an exception if GC happens concurrently.
> ---
>
> Key: BOOKKEEPER-604
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-604
> Project: Bookkeeper
> Issue Type: Bug
>Reporter: Ivan Kelly
>Assignee: Ivan Kelly
> Fix For: 4.2.2, 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch,
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch,
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch,
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch,
> BOOKKEEPER-604.diff
>
>
> If a ledger is flushing, and part way through,GC kicks in, it can delete the
> index file before we try and flush it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-643) Improve concurrency of entry logger
[ https://issues.apache.org/jira/browse/BOOKKEEPER-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719242#comment-13719242 ] Sijie Guo commented on BOOKKEEPER-643: -- since the concurrency part of ledger cache is part of BOOKKEEPER-659, changed the jira to focus on entry logger. will generate the diff later. > Improve concurrency of entry logger > --- > > Key: BOOKKEEPER-643 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-643 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > > the jira is created as part of BOOKKEEPER-429 to improve concurrency of > current bookie implementation by leverage concurrent structures. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-643) Improve concurrency of entry logger
[ https://issues.apache.org/jira/browse/BOOKKEEPER-643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-643: - Summary: Improve concurrency of entry logger (was: Improve concurrency of bookie implementation) > Improve concurrency of entry logger > --- > > Key: BOOKKEEPER-643 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-643 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Affects Versions: 4.2.0 >Reporter: Aniruddha >Assignee: Aniruddha > > the jira is created as part of BOOKKEEPER-429 to improve concurrency of > current bookie implementation by leverage concurrent structures. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-659) LRU page management in ledger cache.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-659: - Attachment: BOOKKEEPER-659.diff attach the patch generated based on BOOKKEEPER-658. this patch includes the changes twitter made for ledger cache (it is difficult to generate the change by commits). this patch includes two major changes: - improve the page eviction to use a LRU strategy. (thanks [~robindhamankar]) - changed the structures used in ledger cache into concurrent structures to improve performance (thanks [~i0exception]) > LRU page management in ledger cache. > > > Key: BOOKKEEPER-659 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-659 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Reporter: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-659.diff > > > better ledger page management. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-658) ledger cache refactor
[ https://issues.apache.org/jira/browse/BOOKKEEPER-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719225#comment-13719225 ] Sijie Guo commented on BOOKKEEPER-658: -- this patch is just simply moving code around without any changes. this change is for BOOKKEEPER-659. > ledger cache refactor > - > > Key: BOOKKEEPER-658 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-658 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Reporter: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-658.patch > > > refactor ledger cache to separate in-memory page management from persistent > management. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-658) ledger cache refactor
[ https://issues.apache.org/jira/browse/BOOKKEEPER-658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-658: - Attachment: BOOKKEEPER-658.patch attach a patch to refactor ledger cache to two managers, one is page management while the other one is persistence manager. > ledger cache refactor > - > > Key: BOOKKEEPER-658 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-658 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Reporter: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-658.patch > > > refactor ledger cache to separate in-memory page management from persistent > management. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-657) Journal Improvement
[ https://issues.apache.org/jira/browse/BOOKKEEPER-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-657: - Attachment: BOOKKEEPER-657.patch sorry. the previous patch is wrong. attached the correct one. > Journal Improvement > --- > > Key: BOOKKEEPER-657 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-657 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Reporter: Sijie Guo >Assignee: Robin Dhamankar > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-657.patch, BOOKKEEPER-657.patch > > > separated force write thread, better group commit strategy on latency and > throughput. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-657) Journal Improvement
[ https://issues.apache.org/jira/browse/BOOKKEEPER-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-657: - Attachment: BOOKKEEPER-657.patch generated a patch included twitter changes on journal. - provided a separated a force write thread to sync journal file rather than sync journal in journal thread. - provided different policy on how to sync journal based on the tradeoff between throughput and latency consideration. > Journal Improvement > --- > > Key: BOOKKEEPER-657 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-657 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server >Reporter: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-657.patch > > > separated force write thread, better group commit strategy on latency and > throughput. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-654) Bookkeeper client operations are allowed even after its closure, bk#close()
[
https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718748#comment-13718748
]
Hadoop QA commented on BOOKKEEPER-654:
--
Testing JIRA BOOKKEEPER-654
Patch
[0003-BOOKKEEPER-654.patch|https://issues.apache.org/jira/secure/attachment/12594000/0003-BOOKKEEPER-654.patch]
downloaded at Wed Jul 24 19:11:00 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 902
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/434/
> Bookkeeper client operations are allowed even after its closure, bk#close()
> ---
>
> Key: BOOKKEEPER-654
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
>Affects Versions: 4.2.0
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 4.2.2, 4.3.0
>
> Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch,
> 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch
>
>
> User can perform below operations with the closed bookkeeper client, which
> was instantiated with external zkclient.
> - open a closed ledger
> - create a new ledger
> Also, ledgerhandle operations like fencing/add/write are infinitely hanging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-648) BasicJMSTest failed
[ https://issues.apache.org/jira/browse/BOOKKEEPER-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718738#comment-13718738 ] Flavio Junqueira commented on BOOKKEEPER-648: - I've had cases in which I had to let it run in a loop for many minutes. It is not uncommon that we have had to let it run for a while to reproduce the error. One of the problems I've had here was that the logs were not very useful. Perhaps adding some more logging would help with debugging. > BasicJMSTest failed > --- > > Key: BOOKKEEPER-648 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-648 > Project: Bookkeeper > Issue Type: Bug > Components: hedwig-client >Reporter: Flavio Junqueira >Assignee: Mridul Muralidharan > > While running tests, I got once a failure for this hedwig-client-jms test: > BasicJMSTest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-654) Bookkeeper client operations are allowed even after its closure, bk#close()
[ https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718723#comment-13718723 ] Rakesh R commented on BOOKKEEPER-654: - Thanks [~hustlmsp]. Reworked and updated the latest patch based on trunk version. In this, I have covered the public apis in Bookkeeper & LedgerHandle. > Bookkeeper client operations are allowed even after its closure, bk#close() > --- > > Key: BOOKKEEPER-654 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-client >Affects Versions: 4.2.0 >Reporter: Rakesh R >Assignee: Rakesh R > Fix For: 4.2.2, 4.3.0 > > Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch, > 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch > > > User can perform below operations with the closed bookkeeper client, which > was instantiated with external zkclient. > - open a closed ledger > - create a new ledger > Also, ledgerhandle operations like fencing/add/write are infinitely hanging. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-654) Bookkeeper client operations are allowed even after its closure, bk#close()
[ https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated BOOKKEEPER-654: Attachment: 0003-BOOKKEEPER-654.patch > Bookkeeper client operations are allowed even after its closure, bk#close() > --- > > Key: BOOKKEEPER-654 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-client >Affects Versions: 4.2.0 >Reporter: Rakesh R >Assignee: Rakesh R > Fix For: 4.2.2, 4.3.0 > > Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch, > 0002-BOOKKEEPER-654.patch, 0003-BOOKKEEPER-654.patch > > > User can perform below operations with the closed bookkeeper client, which > was instantiated with external zkclient. > - open a closed ledger > - create a new ledger > Also, ledgerhandle operations like fencing/add/write are infinitely hanging. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-660) Logs too noisy on NIOServerFactory when client drops a connection
[
https://issues.apache.org/jira/browse/BOOKKEEPER-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718662#comment-13718662
]
Hadoop QA commented on BOOKKEEPER-660:
--
Testing JIRA BOOKKEEPER-660
Patch
[BOOKKEEPER-660.diff|https://issues.apache.org/jira/secure/attachment/12593991/BOOKKEEPER-660.diff]
downloaded at Wed Jul 24 18:21:00 UTC 2013
{color:red}-1{color} Patch failed to apply to head of branch
> Logs too noisy on NIOServerFactory when client drops a connection
> -
>
> Key: BOOKKEEPER-660
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-660
> Project: Bookkeeper
> Issue Type: Bug
>Affects Versions: 4.2.0
>Reporter: Ivan Kelly
>Assignee: Matteo Merli
>Priority: Minor
> Fix For: 4.2.2
>
> Attachments: BOOKKEEPER-660.diff
>
>
> When a client drops a connection, the server throws an exception. It should
> only log at info level and close the socket.
> {code}
> if (k.isReadable()) {
> int rc = sock.read(incomingBuffer);
> if (rc < 0) {
> throw new IOException("Read error");
> }
> if (incomingBuffer.remaining() == 0) {
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-660) Logs too noisy on NIOServerFactory when client drops a connection
[
https://issues.apache.org/jira/browse/BOOKKEEPER-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matteo Merli updated BOOKKEEPER-660:
Attachment: BOOKKEEPER-660.diff
> Logs too noisy on NIOServerFactory when client drops a connection
> -
>
> Key: BOOKKEEPER-660
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-660
> Project: Bookkeeper
> Issue Type: Bug
>Affects Versions: 4.2.0
>Reporter: Ivan Kelly
>Assignee: Matteo Merli
>Priority: Minor
> Fix For: 4.2.2
>
> Attachments: BOOKKEEPER-660.diff
>
>
> When a client drops a connection, the server throws an exception. It should
> only log at info level and close the socket.
> {code}
> if (k.isReadable()) {
> int rc = sock.read(incomingBuffer);
> if (rc < 0) {
> throw new IOException("Read error");
> }
> if (incomingBuffer.remaining() == 0) {
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718559#comment-13718559
]
Hadoop QA commented on BOOKKEEPER-632:
--
Testing JIRA BOOKKEEPER-632
Patch
[BOOKKEEPER-632.patch|https://issues.apache.org/jira/secure/attachment/12593968/BOOKKEEPER-632.patch]
downloaded at Wed Jul 24 16:09:50 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
.Tests run: 866
.Tests failed: 9
.Tests errors: 11
.The patch failed the following testcases:
.
testSimpleLedger[0](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testRestartBookie[0](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testToggleLedgerReplication[0](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testSimpleLedger[1](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testRestartBookie[1](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testToggleLedgerReplication[1](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testSimpleLedger[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testRestartBookie[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
.
testToggleLedgerReplication[2](org.apache.bookkeeper.replication.AuditorLedgerCheckerTest)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/432/
> AutoRecovery should consider read only bookies
> --
>
> Key: BOOKKEEPER-632
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-auto-recovery, bookkeeper-server
>Affects Versions: 4.2.1, 4.3.0
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 4.2.2, 4.3.0
>
> Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch,
> BOOKKEEPER-632.patch, BOOKKEEPER-632.patch
>
>
> Autorecovery Auditor should consider the readonly bookies as Available
> Bookies while publishing the under-replicated ledgers.
> Also AutoRecoveryDaemon should shutdown if the local bookie is readonly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718541#comment-13718541 ] Ivan Kelly commented on BOOKKEEPER-632: --- Regarding, #checkAllLedgers(), I don't know. In any case, its out of scope for this. The new patch looks good. I'll run the tests over it, and submit. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch, BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated BOOKKEEPER-632: - Attachment: BOOKKEEPER-632.patch Attached the updated patch. Used the BookKeeperAdmin apis > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch, BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718485#comment-13718485 ] Vinay commented on BOOKKEEPER-632: -- One more doubt, In Auditor#checkAllLedgers(), zookeeper, Bookkeeper clients are created and closed there itself. Is there any specific reason to create local to that method and close..? > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718484#comment-13718484 ] Vinay commented on BOOKKEEPER-632: -- Thanks Ivan, I will have a try anyway. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718455#comment-13718455
]
Hadoop QA commented on BOOKKEEPER-632:
--
Testing JIRA BOOKKEEPER-632
Patch
[BOOKKEEPER-632.patch|https://issues.apache.org/jira/secure/attachment/12593939/BOOKKEEPER-632.patch]
downloaded at Wed Jul 24 14:41:21 UTC 2013
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
120
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
.Tests run: 865
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/431/
> AutoRecovery should consider read only bookies
> --
>
> Key: BOOKKEEPER-632
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-auto-recovery, bookkeeper-server
>Affects Versions: 4.2.1, 4.3.0
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 4.2.2, 4.3.0
>
> Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch,
> BOOKKEEPER-632.patch
>
>
> Autorecovery Auditor should consider the readonly bookies as Available
> Bookies while publishing the under-replicated ledgers.
> Also AutoRecoveryDaemon should shutdown if the local bookie is readonly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718433#comment-13718433 ] Ivan Kelly commented on BOOKKEEPER-632: --- InetSocketAddress can easily be converted to String with o.a.bookkeeper.util.StringUtils#addrToString. Reading directly from ZK is bad, because it's putting duplicate code in a number of places, which need to be updated if there's a change to the /ledgers/available format. For example, when /ledgers/available/readonly was added, this broke some bits of code that expected every znode under /ledgers/available to be a bookie. In fact, the code that this is fixing was guilty of this. Moving the handling of ZK to a central place prevents this situation occurring again in the future. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[
https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718424#comment-13718424
]
Vinay commented on BOOKKEEPER-632:
--
{quote}he patch adds a new public api to read the readonly bookies, then
manually reads them in Auditor#getAvailableBookies(). It would be much better
if this method read the bookies through BookKeeperAdmin's apis, so that if we
change the format in future, we have less places to update.{quote}
I agree with your point Ivan, But the ways bookie addresses handled in Auditor
and ReplicationWorker are different. In Auditor, bookie address is treated as
just string, where as in RW its InetSocketAddress.
BookKeeperAdmin#getReadOnlyBookie() will return collection of InetSocketAdress.
So changes for this will be more and IMO that is out of scope of this Jira.
Any thoughts..?
> AutoRecovery should consider read only bookies
> --
>
> Key: BOOKKEEPER-632
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-auto-recovery, bookkeeper-server
>Affects Versions: 4.2.1, 4.3.0
>Reporter: Vinay
>Assignee: Vinay
> Fix For: 4.2.2, 4.3.0
>
> Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch,
> BOOKKEEPER-632.patch
>
>
> Autorecovery Auditor should consider the readonly bookies as Available
> Bookies while publishing the under-replicated ledgers.
> Also AutoRecoveryDaemon should shutdown if the local bookie is readonly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-642) Bookie returns incorrect exitcode, ExitCode.ZK_REG_FAIL is getting overridden
[
https://issues.apache.org/jira/browse/BOOKKEEPER-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Kelly updated BOOKKEEPER-642:
--
Fix Version/s: 4.2.2
> Bookie returns incorrect exitcode, ExitCode.ZK_REG_FAIL is getting overridden
> -
>
> Key: BOOKKEEPER-642
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-642
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
>Reporter: Rakesh R
>Assignee: Rakesh R
>Priority: Minor
> Fix For: 4.2.2, 4.3.0
>
> Attachments: 0001-BOOKKEEPER-642.patch
>
>
> When bookie registration fails due to zookeeper exception, its not exiting
> with ExitCode.ZK_REG_FAIL.
> Bookie.java
> {code}
>try {
> registerBookie(conf);
> } catch (IOException e) {
> LOG.error("Couldn't register bookie with zookeeper, shutting
> down", e);
> shutdown(ExitCode.ZK_REG_FAIL);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-642) Bookie returns incorrect exitcode, ExitCode.ZK_REG_FAIL is getting overridden
[
https://issues.apache.org/jira/browse/BOOKKEEPER-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718403#comment-13718403
]
Ivan Kelly commented on BOOKKEEPER-642:
---
Ah, as the bookie hasn't started at this point, it won't actually call
shutdown() to get the error code. I think this applies to 4.2.2 also.
> Bookie returns incorrect exitcode, ExitCode.ZK_REG_FAIL is getting overridden
> -
>
> Key: BOOKKEEPER-642
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-642
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-server
>Reporter: Rakesh R
>Assignee: Rakesh R
>Priority: Minor
> Fix For: 4.3.0
>
> Attachments: 0001-BOOKKEEPER-642.patch
>
>
> When bookie registration fails due to zookeeper exception, its not exiting
> with ExitCode.ZK_REG_FAIL.
> Bookie.java
> {code}
>try {
> registerBookie(conf);
> } catch (IOException e) {
> LOG.error("Couldn't register bookie with zookeeper, shutting
> down", e);
> shutdown(ExitCode.ZK_REG_FAIL);
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718381#comment-13718381 ] Ivan Kelly commented on BOOKKEEPER-632: --- This doesn't address the other issue though. Auditor should use the public api to read the readonly bookies, rather than reading from zk directly. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (BOOKKEEPER-660) Logs too noisy on NIOServerFactory when client drops a connection
Ivan Kelly created BOOKKEEPER-660:
-
Summary: Logs too noisy on NIOServerFactory when client drops a
connection
Key: BOOKKEEPER-660
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-660
Project: Bookkeeper
Issue Type: Bug
Affects Versions: 4.2.0
Reporter: Ivan Kelly
Assignee: Matteo Merli
Priority: Minor
Fix For: 4.2.2
When a client drops a connection, the server throws an exception. It should
only log at info level and close the socket.
{code}
if (k.isReadable()) {
int rc = sock.read(incomingBuffer);
if (rc < 0) {
throw new IOException("Read error");
}
if (incomingBuffer.remaining() == 0) {
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-632) AutoRecovery should consider read only bookies
[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated BOOKKEEPER-632: - Attachment: BOOKKEEPER-632.patch Attaching the patch for trail space removal. > AutoRecovery should consider read only bookies > -- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server >Affects Versions: 4.2.1, 4.3.0 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-648) BasicJMSTest failed
[ https://issues.apache.org/jira/browse/BOOKKEEPER-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718369#comment-13718369 ] Mridul Muralidharan commented on BOOKKEEPER-648: I tried it 3 times - a) mvn test b) mvn install Both from the jms subdir and c) mvn install for entire bookkeeper. Was there any other env difference when it failed ? Like hdd space constraint, mem constraint, etc ? The basic test is actually pretty basic - send msg, and receive the same if that fails, everything else should also fail. I did not notice any deprecation warnings, so wondering what has changed ! > BasicJMSTest failed > --- > > Key: BOOKKEEPER-648 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-648 > Project: Bookkeeper > Issue Type: Bug > Components: hedwig-client >Reporter: Flavio Junqueira >Assignee: Mridul Muralidharan > > While running tests, I got once a failure for this hedwig-client-jms test: > BasicJMSTest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-648) BasicJMSTest failed
[ https://issues.apache.org/jira/browse/BOOKKEEPER-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718365#comment-13718365 ] Mridul Muralidharan commented on BOOKKEEPER-648: I tried it 3 times - a) mvn test b) mvn install Both from the jms subdir and c) mvn install for entire bookkeeper. Was there any other env difference ? Like hdd space constraint, mem constraint, etc ? The basic test is actually pretty basic - send msg, and receive the same On Wed, Jul 24, 2013 at 6:51 PM, Flavio Junqueira (JIRA) > BasicJMSTest failed > --- > > Key: BOOKKEEPER-648 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-648 > Project: Bookkeeper > Issue Type: Bug > Components: hedwig-client >Reporter: Flavio Junqueira >Assignee: Mridul Muralidharan > > While running tests, I got once a failure for this hedwig-client-jms test: > BasicJMSTest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-648) BasicJMSTest failed
[ https://issues.apache.org/jira/browse/BOOKKEEPER-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718353#comment-13718353 ] Flavio Junqueira commented on BOOKKEEPER-648: - have you tried running in a loop? it fails intermittently. > BasicJMSTest failed > --- > > Key: BOOKKEEPER-648 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-648 > Project: Bookkeeper > Issue Type: Bug > Components: hedwig-client >Reporter: Flavio Junqueira >Assignee: Mridul Muralidharan > > While running tests, I got once a failure for this hedwig-client-jms test: > BasicJMSTest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-649) Race condition in sync ZKUtils.createFullPathOptimistic()
[ https://issues.apache.org/jira/browse/BOOKKEEPER-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-649: -- Fix Version/s: 4.2.2 > Race condition in sync ZKUtils.createFullPathOptimistic() > - > > Key: BOOKKEEPER-649 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-649 > Project: Bookkeeper > Issue Type: Bug >Reporter: Matteo Merli >Assignee: Matteo Merli >Priority: Trivial > Fix For: 4.2.2, 4.3.0 > > Attachments: > 0001-BOOKKEEPER-649-Race-condition-in-sync-ZKUtils.create.patch, > 0002-BOOKKEEPER-649.patch, 0002-BOOKKEEPER-649.patch > > > If multiple threads are calling createFullPathOptimistic() there will be race > conditions on creating the intermediate nodes. If the intermediate nodes have > been created since we last check, we can just ignore the exception and > continue creating the child nodes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-654) Bookkeeper client operations are allowed even after its closure, bk#close()
[ https://issues.apache.org/jira/browse/BOOKKEEPER-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-654: -- Fix Version/s: 4.2.2 > Bookkeeper client operations are allowed even after its closure, bk#close() > --- > > Key: BOOKKEEPER-654 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-654 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-client >Affects Versions: 4.2.0 >Reporter: Rakesh R >Assignee: Rakesh R > Fix For: 4.2.2, 4.3.0 > > Attachments: 0001-BOOKKEEPER-654-testcase-to-understand-more.patch, > 0002-BOOKKEEPER-654.patch > > > User can perform below operations with the closed bookkeeper client, which > was instantiated with external zkclient. > - open a closed ledger > - create a new ledger > Also, ledgerhandle operations like fencing/add/write are infinitely hanging. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-625) On OutOfMemoryError in NIOServerFactory thread bookie should shutdown
[ https://issues.apache.org/jira/browse/BOOKKEEPER-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718291#comment-13718291 ] Ivan Kelly commented on BOOKKEEPER-625: --- Great. Patch is good. +1. Committing. > On OutOfMemoryError in NIOServerFactory thread bookie should shutdown > - > > Key: BOOKKEEPER-625 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-625 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.1 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2 > > Attachments: BOOKKEEPER-625-branch-4.2.patch, > BOOKKEEPER-625-branch-4.2.patch, BOOKKEEPER-625-branch-4.2.patch > > > Observed OutOfMemoryError in NIOServerFactory, but it didnt bring down the > bookie and it continued to run without serving. > On OOME in any thread, bookie should shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-648) BasicJMSTest failed
[
https://issues.apache.org/jira/browse/BOOKKEEPER-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718267#comment-13718267
]
Mridul Muralidharan commented on BOOKKEEPER-648:
I was not able to reproduce this with latest svn trunk.
{noformat}
$ mvn test
[INFO] Scanning for projects...
[INFO]
[INFO]
[INFO] Building hedwig-client-jms 4.3.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- javacc-maven-plugin:2.6:jjtree-javacc (jjtree-javacc) @
hedwig-client-jms ---
[INFO] Skipping - all parsers are up to date
[INFO]
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @
hedwig-client-jms ---
[INFO] Setting property: classpath.resource.loader.class =>
'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
[INFO] Setting property: velocimacro.messages.on => 'false'.
[INFO] Setting property: resource.loader => 'classpath'.
[INFO] Setting property: resource.manager.logwhenfound => 'false'.
[INFO]
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @
hedwig-client-jms ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.0:compile (default-compile) @
hedwig-client-jms ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 76 source files to
/home/mridulm/work/bookkeeper/trunk/hedwig-client-jms/target/classes
[INFO]
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @
hedwig-client-jms ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/home/mridulm/work/bookkeeper/trunk/hedwig-client-jms/src/test/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.0:testCompile (default-testCompile) @
hedwig-client-jms ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 104 source files to
/home/mridulm/work/bookkeeper/trunk/hedwig-client-jms/target/test-classes
[INFO]
[INFO] --- maven-surefire-plugin:2.9:test (default-test) @ hedwig-client-jms ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-surefire-plugin:2.9:test (unit-tests) @ hedwig-client-jms ---
[INFO] Surefire report directory:
/home/mridulm/work/bookkeeper/trunk/hedwig-client-jms/target/surefire-reports
---
T E S T S
---
---
T E S T S
---
Running org.apache.hedwig.jms.BasicJMSTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.516 sec
Running org.apache.hedwig.jms.selector.activemq.SelectorTest
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.208 sec
Running org.apache.hedwig.jms.selector.activemq.SelectorParserTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.195 sec
Running org.apache.hedwig.jms.selector.BasicSelectorGrammarTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.238 sec
Results :
Tests run: 26, Failures: 0, Errors: 0, Skipped: 0
{noformat}
> BasicJMSTest failed
> ---
>
> Key: BOOKKEEPER-648
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-648
> Project: Bookkeeper
> Issue Type: Bug
> Components: hedwig-client
>Reporter: Flavio Junqueira
>Assignee: Mridul Muralidharan
>
> While running tests, I got once a failure for this hedwig-client-jms test:
> BasicJMSTest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-625) On OutOfMemoryError in NIOServerFactory thread bookie should shutdown
[ https://issues.apache.org/jira/browse/BOOKKEEPER-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated BOOKKEEPER-625: - Attachment: BOOKKEEPER-625-branch-4.2.patch Oops... Thanks Ivan for pointing it out. Here is the updated patch. > On OutOfMemoryError in NIOServerFactory thread bookie should shutdown > - > > Key: BOOKKEEPER-625 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-625 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.1 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2 > > Attachments: BOOKKEEPER-625-branch-4.2.patch, > BOOKKEEPER-625-branch-4.2.patch, BOOKKEEPER-625-branch-4.2.patch > > > Observed OutOfMemoryError in NIOServerFactory, but it didnt bring down the > bookie and it continued to run without serving. > On OOME in any thread, bookie should shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-625) On OutOfMemoryError in NIOServerFactory thread bookie should shutdown
[ https://issues.apache.org/jira/browse/BOOKKEEPER-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718220#comment-13718220 ] Ivan Kelly commented on BOOKKEEPER-625: --- One small nit. The logging should be a LOG.error instead of a LOG.warn. If you agree, I can make the change as I commit it changes. > On OutOfMemoryError in NIOServerFactory thread bookie should shutdown > - > > Key: BOOKKEEPER-625 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-625 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Affects Versions: 4.2.1 >Reporter: Vinay >Assignee: Vinay > Fix For: 4.2.2 > > Attachments: BOOKKEEPER-625-branch-4.2.patch, > BOOKKEEPER-625-branch-4.2.patch > > > Observed OutOfMemoryError in NIOServerFactory, but it didnt bring down the > bookie and it continued to run without serving. > On OOME in any thread, bookie should shutdown. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-604) Ledger storage can log an exception if GC happens concurrently.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-604: -- Attachment: 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch Fixed formatting and redundant import. > Ledger storage can log an exception if GC happens concurrently. > --- > > Key: BOOKKEEPER-604 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-604 > Project: Bookkeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 4.2.2, 4.3.0 > > Attachments: > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, > BOOKKEEPER-604.diff > > > If a ledger is flushing, and part way through,GC kicks in, it can delete the > index file before we try and flush it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
