RE: 8207830: [aix] disable jfr in build and tests

2018-07-23 Thread Lindenmaier, Goetz 
Thanks Erik!

Best regards,
  Goetz.

> -Original Message-
> From: Erik Joelsson 
> Sent: Donnerstag, 19. Juli 2018 19:33
> To: Vladimir Kozlov ; Lindenmaier, Goetz
> ; hotspot-dev developers  d...@openjdk.java.net>
> Cc: build-dev 
> Subject: Re: 8207830: [aix] disable jfr in build and tests
> 
> Build changes look good.
> 
> /Erik
> 
> 
> On 2018-07-19 10:22, Vladimir Kozlov wrote:
> > Tests changes are good.
> >
> > Thank you for fixing aot check in hotspot.m4
> >
> > In VMProps.java I would suggest to follow code pattern from other
> > features. Add new method vmHasJFR() which returns "true" or "false"
> > instead of:
> >
> > map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild());
> >
> > We may need such method to add other conditions in future.
> >
> > Thanks,
> > Vladimir
> >
> > On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote:
> >> Hi,
> >>
> >> We didn't manage to port JFR to aix in the jdk11 time frame.
> >> Thus I would like to disable it in the build.
> >> As well, I would like to introduce @requires vm.hasJFR which
> >> will disable the tests on aix, and also on linuxsparcv9 and zero.
> >>
> >> Two webrevs for better readability:
> >> This contains the functional changes
> >> http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/
> >> This contains adding @requires.
> >> http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/
> >
> > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/
> >
> >> The only one not straight forward is
> >> runtime/appcds/sharedStrings/FlagCombo.java
> >>
> >> Best regards,
> >>    Goetz.
> >>

Re: 8207830: [aix] disable jfr in build and tests

2018-07-20 Thread Vladimir Kozlov 

Looks good.

Thanks,
Vladimir

On 7/19/18 10:41 PM, Lindenmaier, Goetz wrote:

Hi Vladimir,

Thanks for looking at my change.


Thank you for fixing aot check in hotspot.m4

I guess this does no harm if aot is enabled, but I saw it on aix.


Add new method vmHasJFR()

Fixed.

New partial webrev:
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/02/
The other part is unchanged.

Best regards,
   Goetz.



-Original Message-
From: Vladimir Kozlov 
Sent: Thursday, July 19, 2018 7:22 PM
To: Lindenmaier, Goetz ; hotspot-dev
developers 
Cc: build-dev 
Subject: Re: 8207830: [aix] disable jfr in build and tests

Tests changes are good.

Thank you for fixing aot check in hotspot.m4

In VMProps.java I would suggest to follow code pattern from other
features. Add new method vmHasJFR() which returns "true" or "false"
instead of:

map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild());

We may need such method to add other conditions in future.

Thanks,
Vladimir

On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote:

Hi,

We didn't manage to port JFR to aix in the jdk11 time frame.
Thus I would like to disable it in the build.
As well, I would like to introduce @requires vm.hasJFR which
will disable the tests on aix, and also on linuxsparcv9 and zero.

Two webrevs for better readability:
This contains the functional changes
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/
This contains adding @requires.
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/


http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/


The only one not straight forward is

runtime/appcds/sharedStrings/FlagCombo.java


Best regards,
Goetz.

RE: 8207830: [aix] disable jfr in build and tests

2018-07-19 Thread Lindenmaier, Goetz 
Hi Vladimir, 

Thanks for looking at my change. 

> Thank you for fixing aot check in hotspot.m4
I guess this does no harm if aot is enabled, but I saw it on aix.

> Add new method vmHasJFR()
Fixed.

New partial webrev:
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/02/
The other part is unchanged.

Best regards,
  Goetz.


> -Original Message-
> From: Vladimir Kozlov 
> Sent: Thursday, July 19, 2018 7:22 PM
> To: Lindenmaier, Goetz ; hotspot-dev
> developers 
> Cc: build-dev 
> Subject: Re: 8207830: [aix] disable jfr in build and tests
> 
> Tests changes are good.
> 
> Thank you for fixing aot check in hotspot.m4
> 
> In VMProps.java I would suggest to follow code pattern from other
> features. Add new method vmHasJFR() which returns "true" or "false"
> instead of:
> 
> map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild());
> 
> We may need such method to add other conditions in future.
> 
> Thanks,
> Vladimir
> 
> On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > We didn't manage to port JFR to aix in the jdk11 time frame.
> > Thus I would like to disable it in the build.
> > As well, I would like to introduce @requires vm.hasJFR which
> > will disable the tests on aix, and also on linuxsparcv9 and zero.
> >
> > Two webrevs for better readability:
> > This contains the functional changes
> > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/
> > This contains adding @requires.
> > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/
> 
> http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/
> 
> > The only one not straight forward is
> runtime/appcds/sharedStrings/FlagCombo.java
> >
> > Best regards,
> >Goetz.
> >

Re: 8207830: [aix] disable jfr in build and tests

2018-07-19 Thread Erik Joelsson 

Build changes look good.

/Erik


On 2018-07-19 10:22, Vladimir Kozlov wrote:

Tests changes are good.

Thank you for fixing aot check in hotspot.m4

In VMProps.java I would suggest to follow code pattern from other 
features. Add new method vmHasJFR() which returns "true" or "false" 
instead of:


map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild());

We may need such method to add other conditions in future.

Thanks,
Vladimir

On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote:

Hi,

We didn't manage to port JFR to aix in the jdk11 time frame.
Thus I would like to disable it in the build.
As well, I would like to introduce @requires vm.hasJFR which
will disable the tests on aix, and also on linuxsparcv9 and zero.

Two webrevs for better readability:
This contains the functional changes
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/
This contains adding @requires.
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/


http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/

The only one not straight forward is 
runtime/appcds/sharedStrings/FlagCombo.java


Best regards,
   Goetz.

Re: 8207830: [aix] disable jfr in build and tests

2018-07-19 Thread Vladimir Kozlov 

Tests changes are good.

Thank you for fixing aot check in hotspot.m4

In VMProps.java I would suggest to follow code pattern from other 
features. Add new method vmHasJFR() which returns "true" or "false" 
instead of:


map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild());

We may need such method to add other conditions in future.

Thanks,
Vladimir

On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote:

Hi,

We didn't manage to port JFR to aix in the jdk11 time frame.
Thus I would like to disable it in the build.
As well, I would like to introduce @requires vm.hasJFR which
will disable the tests on aix, and also on linuxsparcv9 and zero.

Two webrevs for better readability:
This contains the functional changes
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/
This contains adding @requires.
http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/


http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/


The only one not straight forward is runtime/appcds/sharedStrings/FlagCombo.java

Best regards,
   Goetz.