Re: Patch to fix build breakage with GCC 4.7
Did this get pushed somewhere? David On 3/03/2012 1:11 AM, Deepak Bhole wrote: * Andrew Hughesahug...@redhat.com [2012-03-02 10:09]: - Original Message - * Andrew Hughesahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hairkelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole Oh as 'author' you mean? I have to admit I'm still confused by these new bylaws and rules. Presumably I can push it on your behalf as jdk8 reviewer. Sure, that'd be great. Thanks! Deepak What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
That would be this: Changeset: fb3a2cafc230 Author:andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholmes, phh, andrew Contributed-by: Deepak Bhole dbh...@redhat.com ! make/common/shared/Compiler-gcc.gmk ! src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt ! src/share/demo/jvmti/gctest/sample.makefile.txt ! src/share/demo/jvmti/heapTracker/sample.makefile.txt ! src/share/demo/jvmti/heapViewer/sample.makefile.txt ! src/share/demo/jvmti/hprof/sample.makefile.txt ! src/share/demo/jvmti/index.html ! src/share/demo/jvmti/java_crw_demo/sample.makefile.txt ! src/share/demo/jvmti/minst/sample.makefile.txt ! src/share/demo/jvmti/mtrace/sample.makefile.txt ! src/share/demo/jvmti/versionCheck/sample.makefile.txt ! src/share/demo/jvmti/waiters/sample.makefile.txt On 3/21/12 8:13 PM, David Holmes wrote: Did this get pushed somewhere? David On 3/03/2012 1:11 AM, Deepak Bhole wrote: * Andrew Hughesahug...@redhat.com [2012-03-02 10:09]: - Original Message - * Andrew Hughesahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hairkelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole Oh as 'author' you mean? I have to admit I'm still confused by these new bylaws and rules. Presumably I can push it on your behalf as jdk8 reviewer. Sure, that'd be great. Thanks! Deepak What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
On 22/03/2012 12:30 PM, Daniel D. Daugherty wrote: That would be this: Changeset: fb3a2cafc230 Author: andrew Date: 2012-03-08 14:04 + URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/fb3a2cafc230 Thanks Dan! I see it came in through the build repo which is why I couldn't find it. Now I can update the CR :) David - 7150392: Linux build breaks with GCC 4.7 due to unrecognized option Summary: Remove -mimpure-text option. Reviewed-by: ohair, dholmes, phh, andrew Contributed-by: Deepak Bhole dbh...@redhat.com ! make/common/shared/Compiler-gcc.gmk ! src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt ! src/share/demo/jvmti/gctest/sample.makefile.txt ! src/share/demo/jvmti/heapTracker/sample.makefile.txt ! src/share/demo/jvmti/heapViewer/sample.makefile.txt ! src/share/demo/jvmti/hprof/sample.makefile.txt ! src/share/demo/jvmti/index.html ! src/share/demo/jvmti/java_crw_demo/sample.makefile.txt ! src/share/demo/jvmti/minst/sample.makefile.txt ! src/share/demo/jvmti/mtrace/sample.makefile.txt ! src/share/demo/jvmti/versionCheck/sample.makefile.txt ! src/share/demo/jvmti/waiters/sample.makefile.txt On 3/21/12 8:13 PM, David Holmes wrote: Did this get pushed somewhere? David On 3/03/2012 1:11 AM, Deepak Bhole wrote: * Andrew Hughesahug...@redhat.com [2012-03-02 10:09]: - Original Message - * Andrew Hughesahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hairkelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole Oh as 'author' you mean? I have to admit I'm still confused by these new bylaws and rules. Presumably I can push it on your behalf as jdk8 reviewer. Sure, that'd be great. Thanks! Deepak What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
- Original Message - * Andrew Hughes ahug...@redhat.com [2012-03-02 10:09]: - Original Message - * Andrew Hughes ahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hair kelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole Oh as 'author' you mean? I have to admit I'm still confused by these new bylaws and rules. Presumably I can push it on your behalf as jdk8 reviewer. Sure, that'd be great. Thanks! Done: http://hg.openjdk.java.net/jdk8/build/jdk/rev/fb3a2cafc230 Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
- Original Message - * Andrew Hughes ahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hair kelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole Oh as 'author' you mean? I have to admit I'm still confused by these new bylaws and rules. Presumably I can push it on your behalf as jdk8 reviewer. What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
* Andrew Hughes ahug...@redhat.com [2012-03-02 10:09]: - Original Message - * Andrew Hughes ahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hair kelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole Oh as 'author' you mean? I have to admit I'm still confused by these new bylaws and rules. Presumably I can push it on your behalf as jdk8 reviewer. Sure, that'd be great. Thanks! Deepak What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
* Andrew Hughes ahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hair kelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
BugId: 7150392 Linux build breaks with GCC 4.7 due to unrecognized option David - On 2/03/2012 7:14 AM, Deepak Bhole wrote: * Andrew Hughesahug...@redhat.com [2012-03-01 15:40]: - Original Message - * Kelly O'Hairkelly.oh...@oracle.com [2012-02-29 20:39]: The sample.makefile.txt files may not even be used during the build, I'm not sure. They may have only been supplied as documentation on how to build the native code. Deleting the -mimpure-text is probably right all around. Okay, so then looks like the first iteration should be OK for that: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00/ If so, please go ahead and commit on my behalf as I can't. Why can't you? This is a jdk change. Only HotSpot changes have to go through JPRT. I don't have commit access to jdk: http://openjdk.java.net/census#dbhole What you will need, of course, is for someone to assign you a bug ID for it :-) :) Deepak Thanks! Deepak -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
Re: Patch to fix build breakage with GCC 4.7
* David Holmes david.hol...@oracle.com [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC + Linux. Is that combination even supported? The README doesn't list it: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE Linux-sparc is not one of Oracle's supported OpenJDK platforms. However AFAIK there are people in the community building OpenJDK on Linux-sparc using the Zero interpreter. I don't know if this would affect them but it still seems to me that we should be careful not to break other people's builds. With FOSDEM and subsequent security errata, this got pushed to side. Sorry for the delay. I've created a new webrev which contains a special case for the Sparc family (on Linux): http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ If it is okay for push, please go ahead and push it (I don't have commit access). I will then propose it for 7u. Thanks, Deepak David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
Hi Deepak, On 1/03/2012 6:30 AM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC + Linux. Is that combination even supported? The README doesn't list it: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE Linux-sparc is not one of Oracle's supported OpenJDK platforms. However AFAIK there are people in the community building OpenJDK on Linux-sparc using the Zero interpreter. I don't know if this would affect them but it still seems to me that we should be careful not to break other people's builds. With FOSDEM and subsequent security errata, this got pushed to side. Sorry for the delay. I've created a new webrev which contains a special case for the Sparc family (on Linux): http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ Where is ARCH_FAMILY being set? David If it is okay for push, please go ahead and push it (I don't have commit access). I will then propose it for 7u. Thanks, Deepak David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
* David Holmes david.hol...@oracle.com [2012-02-29 18:29]: Hi Deepak, On 1/03/2012 6:30 AM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC + Linux. Is that combination even supported? The README doesn't list it: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE Linux-sparc is not one of Oracle's supported OpenJDK platforms. However AFAIK there are people in the community building OpenJDK on Linux-sparc using the Zero interpreter. I don't know if this would affect them but it still seems to me that we should be careful not to break other people's builds. With FOSDEM and subsequent security errata, this got pushed to side. Sorry for the delay. I've created a new webrev which contains a special case for the Sparc family (on Linux): http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ Where is ARCH_FAMILY being set? It is set in make/common/shared/Platform.gmk Deepak David If it is okay for push, please go ahead and push it (I don't have commit access). I will then propose it for 7u. Thanks, Deepak David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
On 1/03/2012 9:43 AM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-02-29 18:29]: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ Where is ARCH_FAMILY being set? It is set in make/common/shared/Platform.gmk But that has no connection to the sample Makefiles. David Deepak David If it is okay for push, please go ahead and push it (I don't have commit access). I will then propose it for 7u. Thanks, Deepak David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
* David Holmes david.hol...@oracle.com [2012-02-29 18:48]: Sorry let me back up a step here. The issue with linux-sparc involved the actual build instructions in Compiler-gcc.gmk, not so much the sample makefiles for the various JVMTI demos - at least in my response. Unless someone from serviceability indicates otherwise I'd suggest just deleting -mimpure-text from those samples. Just to confuse things further, the gcc manual now lists this as a Solaris 2 option _not_ a sparc option: http://gcc.gnu.org/onlinedocs/gcc/Solaris-2-Options.html#index-mimpure_002dtext-2103 http://old.nabble.com/Correctly-document-Solaris-2-options-td29851048.html This seems to indicate the gcc folk are ignorant of linux-sparc! Gah :/ As we only used this option for linux builds and not Solaris builds I find this even more confusing. So at this point I will step back and let the build folk figure it out. Removing it might probably be correct then, since it is not applicable to Linux. I will wait for someone with more experience to chime in though. Cheers, Deepak David - On 1/03/2012 9:28 AM, David Holmes wrote: Hi Deepak, On 1/03/2012 6:30 AM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC + Linux. Is that combination even supported? The README doesn't list it: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE Linux-sparc is not one of Oracle's supported OpenJDK platforms. However AFAIK there are people in the community building OpenJDK on Linux-sparc using the Zero interpreter. I don't know if this would affect them but it still seems to me that we should be careful not to break other people's builds. With FOSDEM and subsequent security errata, this got pushed to side. Sorry for the delay. I've created a new webrev which contains a special case for the Sparc family (on Linux): http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.01/ Where is ARCH_FAMILY being set? David If it is okay for push, please go ahead and push it (I don't have commit access). I will then propose it for 7u. Thanks, Deepak David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
linux-sparc used to build and run fine (I did the port way back when), so it should be relatively easy to resurrect. The original port was on a T1. Paul On 1/31/12 10:23 AM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 21:50]: On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC + Linux. Is that combination even supported? The README doesn't list it: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE Linux-sparc is not one of Oracle's supported OpenJDK platforms. However AFAIK there are people in the community building OpenJDK on Linux-sparc using the Zero interpreter. I don't know if this would affect them but it still seems to me that we should be careful not to break other people's builds. Ah fair enough. If it is supported, the patch definitely needs to be fixed. I will re-post. Thanks for taking a look! Deepak David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
Hi Deepak, The primary change here is a build change so I've cc'ed build-dev. The majority of the changes are to JVMTI demo files hence I've cc'd serviceability-dev. I think JDK8-dev doesn't need to be included now so I've bcc'd it. While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
This change looks fine to me. It would be ok with me for this change to be pushed into the jdk8/build forest. Once there, I can do a JPRT run to verify it, but I really don't seen any issue here. -kto On Jan 30, 2012, at 4:57 PM, David Holmes wrote: Hi Deepak, The primary change here is a build change so I've cc'ed build-dev. The majority of the changes are to JVMTI demo files hence I've cc'd serviceability-dev. I think JDK8-dev doesn't need to be included now so I've bcc'd it. While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
Re: Patch to fix build breakage with GCC 4.7
On 31/01/2012 12:36 PM, Deepak Bhole wrote: * David Holmesdavid.hol...@oracle.com [2012-01-30 19:57]: While gcc compilation on sparc is rare I'm not sure that simply deleting the sparc-only option unconditionally is the right thing to do. I thought about that too. But I was unable to find info on OpenJDK + SPARC + Linux. Is that combination even supported? The README doesn't list it: http://hg.openjdk.java.net/jdk6/jdk6/raw-file/tip/README-builds.html#MBE Linux-sparc is not one of Oracle's supported OpenJDK platforms. However AFAIK there are people in the community building OpenJDK on Linux-sparc using the Zero interpreter. I don't know if this would affect them but it still seems to me that we should be careful not to break other people's builds. David - The option seemed more like a relic from Solaris + SPARC config rather than a requirement for Linux + SPARC. Cheers, Deepak David On 31/01/2012 1:20 AM, Deepak Bhole wrote: Hi, JDK builds currently fail with GCC 4.7 due to its stricter option checking. GCC 4.6 and prior ignored invalid options -- GCC 4.7 does not. Certain files in JDK supply the -mimpure-text option to GCC. This option is only valid on SPARC[1,2]. As a result, GCC 4.7 throws an error during build on Linux (I suppose . This patch removes the option: http://cr.openjdk.java.net/~dbhole/GCC-4.7-JDK8.00 1: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/SPARC-Options.html 2: http://gcc.gnu.org/onlinedocs/gcc-3.3.6/gcc/i386-and-x86_002d64-Options.html If OK for push, please feel free to do so (I don't have commit access). Cheers, Deepak
