Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]
On Wed, 9 Dec 2020 07:22:51 GMT, Bernhard Urban-Forster wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > Bernhard Urban-Forster has updated the pull request with a new target base > due to a merge or a rebase. The pull request now contains 12 commits: > > - remove gtest and jtreg > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - merge mistakes > - change default target to hotspot and align with updated x64 bits > - remove devkit usage on win-aarch64 > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - todo note for caching devkit > - remove release build > - move windows_aarch64_build next to other builds > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - ... and 2 more: > https://git.openjdk.java.net/jdk/compare/9ce3d806...c07f5d72 Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]
On Wed, 9 Dec 2020 07:22:51 GMT, Bernhard Urban-Forster wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > Bernhard Urban-Forster has updated the pull request with a new target base > due to a merge or a rebase. The pull request now contains 12 commits: > > - remove gtest and jtreg > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - merge mistakes > - change default target to hotspot and align with updated x64 bits > - remove devkit usage on win-aarch64 > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - todo note for caching devkit > - remove release build > - move windows_aarch64_build next to other builds > - Merge remote-tracking branch 'upstream/master' into > 8256657-win-arm64-gh-submit-workflow > - ... and 2 more: > https://git.openjdk.java.net/jdk/compare/9ce3d806...c07f5d72 Thanks, updates look fine to me. - Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - remove gtest and jtreg - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - merge mistakes - change default target to hotspot and align with updated x64 bits - remove devkit usage on win-aarch64 - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - todo note for caching devkit - remove release build - move windows_aarch64_build next to other builds - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - ... and 2 more: https://git.openjdk.java.net/jdk/compare/9ce3d806...c07f5d72 - Changes: https://git.openjdk.java.net/jdk/pull/1379/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=04 Stats: 92 lines in 1 file changed: 91 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v4]
On Tue, 8 Dec 2020 06:59:23 GMT, Aleksey Shipilev wrote: >> Minor nits. > > Also merge from master to get the clean workflow run everywhere? Thank you @shipilev for your comments, I've updated the PR. - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v4]
On Tue, 8 Dec 2020 06:58:49 GMT, Aleksey Shipilev wrote: >> Bernhard Urban-Forster has updated the pull request incrementally with one >> additional commit since the last revision: >> >> merge mistakes > > Minor nits. Also merge from master to get the clean workflow run everywhere? - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v4]
On Mon, 7 Dec 2020 19:34:26 GMT, Bernhard Urban-Forster
wrote:
>> This adds the cross-compiled build only, as no Windows+Arm64 machines are
>> available on GitHub Action that we could use to run the tests.
>>
>> Due to cross-compilation a build JDK is required. Initially I added EA
>> builds to be downloaded from https://jdk.java.net/16/ and used for that, but
>> then I saw how @shipiliv attempted it for the linux cross-compilation builds
>> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image
>> produced by the x64 variant. This however add more stress to the "critical
>> path", as now two more jobs depend on the x64 build first.
>>
>> Let's see how it works out in the long-run. A Windows+AArch64 build takes
>> 40-50min.
>
> Bernhard Urban-Forster has updated the pull request incrementally with one
> additional commit since the last revision:
>
> merge mistakes
Minor nits.
.github/workflows/submit.yml line 954:
> 952: --with-boot-jdk="$env:BOOT_JDK"
> 953: --with-jtreg="$env:JT_HOME"
> 954: --with-gtest="$env:GTEST"
Ditto for `--with-jtreg`, `--with-gtest`.
.github/workflows/submit.yml line 956:
> 954: --with-gtest="$env:GTEST"
> 955: --with-default-make-target="hotspot"
> 956: --enable-jtreg-failure-handler
Ditto for `--enable-jtreg-failure-handler`.
.github/workflows/submit.yml line 930:
> 928: name: transient_jtreg_${{
> needs.prerequisites.outputs.bundle_id }}
> 929: path: ~/jtreg/
> 930: if: steps.jtreg_restore.outcome == 'failure'
Since we are not running tests, and only build hotspot, we can skip jtreg and
gtest additions in this job. Saves a few cycles? This would be similar to what
"Linux additional" does.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v4]
On Mon, 7 Dec 2020 19:34:26 GMT, Bernhard Urban-Forster wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > Bernhard Urban-Forster has updated the pull request incrementally with one > additional commit since the last revision: > > merge mistakes This looks good now. It adds ~15 minutes of build time (and unfortunately ~10 minutes to download prereqs), which is quite acceptable. - Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v4]
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. Bernhard Urban-Forster has updated the pull request incrementally with one additional commit since the last revision: merge mistakes - Changes: - all: https://git.openjdk.java.net/jdk/pull/1379/files - new: https://git.openjdk.java.net/jdk/pull/1379/files/34d1ea24..4a1e08d5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1379=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1379=02-03 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v3]
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - change default target to hotspot and align with updated x64 bits - remove devkit usage on win-aarch64 - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - todo note for caching devkit - remove release build - move windows_aarch64_build next to other builds - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - remove fixpath.exe workaround - 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow This adds the cross-compiled build only, as no Windows+Arm64 machines are available on GitHub Action that we could use to run the tests. Due to cross-compilation a build JDK is required. Initially I added EA builds to be downloaded from https://jdk.java.net/16/ and used for that, but then I saw how @shipiliv attempted it for the linux cross-compilation builds in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image produced by the x64 variant. This however add more stress to the "critical path", as now two more jobs depend on the x64 build first. Let's see how it works out in the long-run. A Windows+AArch64 build takes 40-50min. - Changes: https://git.openjdk.java.net/jdk/pull/1379/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=02 Stats: 119 lines in 1 file changed: 117 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]
On Mon, 30 Nov 2020 15:44:09 GMT, Erik Joelsson wrote: >> Thanks for all the comments. >> >>> - 40-50 min builds seem to be excessive for just the hotspot build, do >>> youknow what exactly takes that long? Is this for release and debug each or >>> both combined? >> >> It's for each of them. Installing a specific version of MSVC and creating >> the devkit take each ~10min. Thinking about it, there is a opportunity to >> cache the devkit and do the MSVC installer invocation only if no cached >> devkit is available. >> >> Here is an example run if you want to have a closer look: >> https://github.com/lewurm/openjdk/runs/1434118318?check_suite_focus=true >> >>> - Is it worth the cycles to build both release *and* debug? How probable is >> it that a non-win-aarch-dev will break one but not the other? I presume >> developers on the windows aarch project will have tested the build locally >> before pushing. >> >> Fair, I'll remove one of them (as suggested by Aleksey in another comment, >> I'll keep the debug one). > > Generating a devkit every time we build seems like a pretty big waste of > time. The OpenJDK build is expected to work without devkits, using an > installed Visual Studio. Is this not possible with the Windows aarch64 build? > If not, then that really should be fixed. FWIW, here is a patch on top of my winenv rewrite that adds windows-aarch64 support on Github Actions: https://github.com/magicus/openjdk-sandbox/compare/winenv-rewrite...magicus:winenv-aarch64-gha?expand=1 I've used it while developing the winenv rewrite, but pulled it out of the final integration so as to not mix in the question of enabling more build platforms on GHA in the discussion of the rewrite. - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]
On Mon, 23 Nov 2020 15:19:18 GMT, Bernhard Urban-Forster wrote: >> I think you need to wait for #1350, and then reconcile this patch with that >> refactoring. > > Thanks for all the comments. > >> - 40-50 min builds seem to be excessive for just the hotspot build, do >> youknow what exactly takes that long? Is this for release and debug each or >> both combined? > > It's for each of them. Installing a specific version of MSVC and creating the > devkit take each ~10min. Thinking about it, there is a opportunity to cache > the devkit and do the MSVC installer invocation only if no cached devkit is > available. > > Here is an example run if you want to have a closer look: > https://github.com/lewurm/openjdk/runs/1434118318?check_suite_focus=true > >> - Is it worth the cycles to build both release *and* debug? How probable is > it that a non-win-aarch-dev will break one but not the other? I presume > developers on the windows aarch project will have tested the build locally > before pushing. > > Fair, I'll remove one of them (as suggested by Aleksey in another comment, > I'll keep the debug one). Generating a devkit every time we build seems like a pretty big waste of time. The OpenJDK build is expected to work without devkits, using an installed Visual Studio. Is this not possible with the Windows aarch64 build? If not, then that really should be fixed. - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v2]
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - todo note for caching devkit - remove release build - move windows_aarch64_build next to other builds - Merge remote-tracking branch 'upstream/master' into 8256657-win-arm64-gh-submit-workflow - remove fixpath.exe workaround - 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow This adds the cross-compiled build only, as no Windows+Arm64 machines are available on GitHub Action that we could use to run the tests. Due to cross-compilation a build JDK is required. Initially I added EA builds to be downloaded from https://jdk.java.net/16/ and used for that, but then I saw how @shipiliv attempted it for the linux cross-compilation builds in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image produced by the x64 variant. This however add more stress to the "critical path", as now two more jobs depend on the x64 build first. Let's see how it works out in the long-run. A Windows+AArch64 build takes 40-50min. - Changes: https://git.openjdk.java.net/jdk/pull/1379/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=01 Stats: 155 lines in 1 file changed: 153 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
On Mon, 23 Nov 2020 12:37:47 GMT, Magnus Ihse Bursie wrote: >> .github/workflows/submit.yml line 1367: >> >>> 1365: git apply p.patch >>> 1366: working-directory: jdk >>> 1367: shell: bash >> >> This should be in the mainline repo instead. Yes, the absence of this patch >> blocks this PR, but getting that patch into the mainline first is the right >> thing to do. > > I agree. We should not have a build action that requires a patch. That patch in its current form is not suitable for upstream. The initial plan was to wait until the "new WINENV" patch lands [1], which would resolve the problem we face with `fixpath.exe`. But maybe I can come up with a solution for the current situation, given that I've a better understanding of the build system by now. [1] https://mail.openjdk.java.net/pipermail/build-dev/2020-July/027872.html - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
On Mon, 23 Nov 2020 12:01:14 GMT, Aleksey Shipilev wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > I think you need to wait for #1350, and then reconcile this patch with that > refactoring. Thanks for all the comments. > - 40-50 min builds seem to be excessive for just the hotspot build, do > youknow what exactly takes that long? Is this for release and debug each or > both combined? It's for each of them. Installing a specific version of MSVC and creating the devkit take each ~10min. Thinking about it, there is a opportunity to cache the devkit and do the MSVC installer invocation only if no cached devkit is available. Here is an example run if you want to have a closer look: https://github.com/lewurm/openjdk/runs/1434118318?check_suite_focus=true > - Is it worth the cycles to build both release *and* debug? How probable is it that a non-win-aarch-dev will break one but not the other? I presume developers on the windows aarch project will have tested the build locally before pushing. Fair, I'll remove one of them (as suggested by Aleksey in another comment, I'll keep the debug one). - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
On Mon, 23 Nov 2020 11:59:53 GMT, Aleksey Shipilev wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds to be downloaded from https://jdk.java.net/16/ and used for that, but >> then I saw how @shipiliv attempted it for the linux cross-compilation builds >> in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image >> produced by the x64 variant. This however add more stress to the "critical >> path", as now two more jobs depend on the x64 build first. >> >> Let's see how it works out in the long-run. A Windows+AArch64 build takes >> 40-50min. > > .github/workflows/submit.yml line 1367: > >> 1365: git apply p.patch >> 1366: working-directory: jdk >> 1367: shell: bash > > This should be in the mainline repo instead. Yes, the absence of this patch > blocks this PR, but getting that patch into the mainline first is the right > thing to do. I agree. We should not have a build action that requires a patch. - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
On Mon, 23 Nov 2020 09:35:40 GMT, Bernhard Urban-Forster wrote: > This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. I think you need to wait for #1350, and then reconcile this patch with that refactoring. .github/workflows/submit.yml line 1250: > 1248: flavor: > 1249: - build release > 1250: - build debug Other foreign arches build only `debug`, thus optimizing the workflow time, drop `release` here? .github/workflows/submit.yml line 1367: > 1365: git apply p.patch > 1366: working-directory: jdk > 1367: shell: bash This should be in the mainline repo instead. Yes, the absence of this patch blocks this PR, but getting that patch into the mainline first is the right thing to do. .github/workflows/submit.yml line 2021: > 2019: - linux_x64_test > 2020: - linux_x86_test > 2021: - windows_aarch64_build This should move to other `_build` needs, for clarity. - Changes requested by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
On Mon, 23 Nov 2020 09:35:40 GMT, Bernhard Urban-Forster wrote: > This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. I thought windows-aarch64 was not able to build without a patch? Have you fixed that? - PR: https://git.openjdk.java.net/jdk/pull/1379
Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
Hi Bernhard, just some drive-by comments. - 40-50 min builds seem to be excessive for just the hotspot build, do you know what exactly takes that long? Is this for release and debug each or both combined? - Is it worth the cycles to build both release *and* debug? How probable is it that a non-win-aarch-dev will break one but not the other? I presume developers on the windows aarch project will have tested the build locally before pushing. - fixpath: Having the gh actions download a patch from your personal repos seems odd I feel at some point we need to have a talk about the growing number of platforms in github actions. E.g. which platforms should be mandatory green before pushing. I also am unsure about the associated cost for each developer (I know atm everyone has a free quota, but that is not limitless. If it is eaten up, strictly speaking one would not be able to push anymore since no submit tests can be ran until the quota is refilled). Cheers, Thomas On Mon, Nov 23, 2020 at 10:41 AM Bernhard Urban-Forster < bur...@openjdk.java.net> wrote: > This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA > builds to be downloaded from https://jdk.java.net/16/ and used for that, > but then I saw how @shipiliv attempted it for the linux cross-compilation > builds in https://github.com/openjdk/jdk/pull/1147. That is using the > JDK image produced by the x64 variant. This however add more stress to the > "critical path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. > > - > > Commit messages: > - 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow > > Changes: https://git.openjdk.java.net/jdk/pull/1379/files > Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8256657 > Stats: 164 lines in 1 file changed: 163 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/jdk/pull/1379.diff > Fetch: git fetch https://git.openjdk.java.net/jdk > pull/1379/head:pull/1379 > > PR: https://git.openjdk.java.net/jdk/pull/1379 >
RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
This adds the cross-compiled build only, as no Windows+Arm64 machines are available on GitHub Action that we could use to run the tests. Due to cross-compilation a build JDK is required. Initially I added EA builds to be downloaded from https://jdk.java.net/16/ and used for that, but then I saw how @shipiliv attempted it for the linux cross-compilation builds in https://github.com/openjdk/jdk/pull/1147. That is using the JDK image produced by the x64 variant. This however add more stress to the "critical path", as now two more jobs depend on the x64 build first. Let's see how it works out in the long-run. A Windows+AArch64 build takes 40-50min. - Commit messages: - 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow Changes: https://git.openjdk.java.net/jdk/pull/1379/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1379=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256657 Stats: 164 lines in 1 file changed: 163 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1379.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1379/head:pull/1379 PR: https://git.openjdk.java.net/jdk/pull/1379
