Re: [Care2002-developers] revision 6779
Hi Gjergj and Muthu, Sorry, I started the discussion about good/bad coding style. I don't know why but a lot of the care2x sources seem wired to be and just wanted to get your guys opinion. I do not want to go through each section / philosophy that i disagree which. Maybe even on LD var's it might makes sense instead of complex php coding. On recursive sections it would make sense either (the $$ thing), but I am not sure that there is any. I would not start here now to change wherever it is been used for that release now. It was just an idea for further releases to have a kind of standard where we all can live with. Robert Am Dienstag, den 21.09.2010, 21:31 +0200 schrieb Gjergj Sheldija - AcmeTECH: > > in the gettext branch i started renaming table fields from german to english > and doing some cleanups.. > the idea of using a data dictionary may be appealing at first, but > when you start noticing all the small differences between hospitals > and countries, you resolve to using a lot of config tables.. > > there is little or no recursion i c2x code, afaik. the use > of the $$ was a bad design choice for which we are paying. > > as robert said those will be done afer closing the bugs in 2.6.1 > > gj. > > > > On 2010-09-21 9:06.MD, Ap.Muthu wrote: > > $$ - Mostly used as LD_var for translating strings and possibly field names > > A data dictionary is what is needed. > > I will now try to make some (non)sense out of an entity relationship diagram > > for care2x. > > The unusual naming conventions for naming fields have got me dizzy. > > Since we are all using MySQL5, should we not go in for some views? > > $$ is very useful in handling recursively a set of field names and table > > names from the information_schema table to act uipon user tables across a > > set of similar databases. > > Many files have the version number of Care2x hard coded - sould we not use > > some config variable for it and do away with the versions table? Is the > > versions table used anywhere? > > > > Regards, > > Ap.Muthu > > > > > >> Hi Robert, > >> > >> you are so right about the $$ a lot of modules uses it, > >> prescription, lab requests, depot... > >> it's really a dark chapter.. > >> > >> gj. > >> > >> On 2010-09-21 8:49.MD, Robert Meggle wrote: > >>> Hi Muthu, > >>> > >>> We are now on the level where all had started of care2x nearly 10 years > >>> ago. Since that time that peace of code had not been touched. But you're > >>> right, the "_" will be escaped by MySQL and the interesting thing is > >>> that somehow it had been worked now since years. > >>> > >>> Another aspect, especially on that ground.level.zero: The idea to store > >>> that kind of global settings in a table like we are discussing it now is > >>> really ok, but we can discuss the naming convention of it. But the way > >>> how it is used by $$ use of var look: > >>> http://www.php.net/manual/en/language.variables.variable.php > >>> > >>> That is a dark chapter of php how to (mis)use variables. Normally you > >>> should read it, understand it, and -please- forget it and never use it! > >>> > >>> Robert > >>> > >>> > >>> Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: > Hi Robert, > > That's a good one. > > I did notice that in many parts of the code the global config variable > was > selectively filtered using "person_%". In MySQL, the "_" should be > escaped > as otherwise it means any characters wildcard. The existing filter will > choose "personell" and "person_" as well! I do not know if the > "person\_%" > will work as an argument in the function but it certainly works in MySQL > directly. At the moment it is not affecting any working by having a few > more > unfiltered variables getting in. > > Regards, > Ap.Muthu > > > Hi, > > > > just one note on 6779, there was one value missing in > > care_config_global. Can be added by: > > > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > > > Robert > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers > >> -- > >> Start uncovering the many advantages of virtual appliances > >> and start using them to simplify application deployment and > >> accelerate your shift to cloud computing. > >> http://p.sf.net/sfu/novel
Re: [Care2002-developers] revision 6779
Hi Robert, Actually the (c) notice is irrelevant. All that is needed is to prove that you are the author, and the svn commit does that. Tim On 21 September 2010 20:12, Robert Meggle wrote: > Well, if the version table is been used somewhere, I have not seen it > over the years. > > About the version numbering as comments. I would like to move that topic > when we killed all relevant bugs out and place a (c) setting in each > file. We have to do it, care2x was pirated and sold in the past many > times. > > When you have the ER diagram ready, please send it. That would be nice > to have. What app you are using for? > > Robert > > > Am Mittwoch, den 22.09.2010, 00:36 +0530 schrieb Ap.Muthu: >> $$ - Mostly used as LD_var for translating strings and possibly field names >> A data dictionary is what is needed. >> I will now try to make some (non)sense out of an entity relationship diagram >> for care2x. >> The unusual naming conventions for naming fields have got me dizzy. >> Since we are all using MySQL5, should we not go in for some views? >> $$ is very useful in handling recursively a set of field names and table >> names from the information_schema table to act uipon user tables across a >> set of similar databases. >> Many files have the version number of Care2x hard coded - sould we not use >> some config variable for it and do away with the versions table? Is the >> versions table used anywhere? >> >> Regards, >> Ap.Muthu >> >> >> > Hi Robert, >> > >> > you are so right about the $$ a lot of modules uses it, >> > prescription, lab requests, depot... >> > it's really a dark chapter.. >> > >> > gj. >> > >> > On 2010-09-21 8:49.MD, Robert Meggle wrote: >> >> Hi Muthu, >> >> >> >> We are now on the level where all had started of care2x nearly 10 years >> >> ago. Since that time that peace of code had not been touched. But you're >> >> right, the "_" will be escaped by MySQL and the interesting thing is >> >> that somehow it had been worked now since years. >> >> >> >> Another aspect, especially on that ground.level.zero: The idea to store >> >> that kind of global settings in a table like we are discussing it now is >> >> really ok, but we can discuss the naming convention of it. But the way >> >> how it is used by $$ use of var look: >> >> http://www.php.net/manual/en/language.variables.variable.php >> >> >> >> That is a dark chapter of php how to (mis)use variables. Normally you >> >> should read it, understand it, and -please- forget it and never use it! >> >> >> >> Robert >> >> >> >> >> >> Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: >> >>> Hi Robert, >> >>> >> >>> That's a good one. >> >>> >> >>> I did notice that in many parts of the code the global config variable >> >>> was >> >>> selectively filtered using "person_%". In MySQL, the "_" should be >> >>> escaped >> >>> as otherwise it means any characters wildcard. The existing filter will >> >>> choose "personell" and "person_" as well! I do not know if the >> >>> "person\_%" >> >>> will work as an argument in the function but it certainly works in MySQL >> >>> directly. At the moment it is not affecting any working by having a few >> >>> more >> >>> unfiltered variables getting in. >> >>> >> >>> Regards, >> >>> Ap.Muthu >> >>> >> Hi, >> >> just one note on 6779, there was one value missing in >> care_config_global. Can be added by: >> >> INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', >> '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); >> >> Robert >> >>> >> >>> >> >>> -- >> >>> Start uncovering the many advantages of virtual appliances >> >>> and start using them to simplify application deployment and >> >>> accelerate your shift to cloud computing. >> >>> http://p.sf.net/sfu/novell-sfdev2dev >> >>> ___ >> >>> Care2002-developers mailing list >> >>> Care2002-developers@lists.sourceforge.net >> >>> https://lists.sourceforge.net/lists/listinfo/care2002-developers >> > >> > -- >> > Start uncovering the many advantages of virtual appliances >> > and start using them to simplify application deployment and >> > accelerate your shift to cloud computing. >> > http://p.sf.net/sfu/novell-sfdev2dev >> > ___ >> > Care2002-developers mailing list >> > Care2002-developers@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/care2002-developers >> > >> >> >> >> -- >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> ___ >> Care20
Re: [Care2002-developers] revision 6779
in the gettext branch i started renaming table fields from german to english and doing some cleanups.. the idea of using a data dictionary may be appealing at first, but when you start noticing all the small differences between hospitals and countries, you resolve to using a lot of config tables.. there is little or no recursion i c2x code, afaik. the use of the $$ was a bad design choice for which we are paying. as robert said those will be done afer closing the bugs in 2.6.1 gj. On 2010-09-21 9:06.MD, Ap.Muthu wrote: > $$ - Mostly used as LD_var for translating strings and possibly field names > A data dictionary is what is needed. > I will now try to make some (non)sense out of an entity relationship diagram > for care2x. > The unusual naming conventions for naming fields have got me dizzy. > Since we are all using MySQL5, should we not go in for some views? > $$ is very useful in handling recursively a set of field names and table > names from the information_schema table to act uipon user tables across a > set of similar databases. > Many files have the version number of Care2x hard coded - sould we not use > some config variable for it and do away with the versions table? Is the > versions table used anywhere? > > Regards, > Ap.Muthu > > >> Hi Robert, >> >> you are so right about the $$ a lot of modules uses it, >> prescription, lab requests, depot... >> it's really a dark chapter.. >> >> gj. >> >> On 2010-09-21 8:49.MD, Robert Meggle wrote: >>> Hi Muthu, >>> >>> We are now on the level where all had started of care2x nearly 10 years >>> ago. Since that time that peace of code had not been touched. But you're >>> right, the "_" will be escaped by MySQL and the interesting thing is >>> that somehow it had been worked now since years. >>> >>> Another aspect, especially on that ground.level.zero: The idea to store >>> that kind of global settings in a table like we are discussing it now is >>> really ok, but we can discuss the naming convention of it. But the way >>> how it is used by $$ use of var look: >>> http://www.php.net/manual/en/language.variables.variable.php >>> >>> That is a dark chapter of php how to (mis)use variables. Normally you >>> should read it, understand it, and -please- forget it and never use it! >>> >>> Robert >>> >>> >>> Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: Hi Robert, That's a good one. I did notice that in many parts of the code the global config variable was selectively filtered using "person_%". In MySQL, the "_" should be escaped as otherwise it means any characters wildcard. The existing filter will choose "personell" and "person_" as well! I do not know if the "person\_%" will work as an argument in the function but it certainly works in MySQL directly. At the moment it is not affecting any working by having a few more unfiltered variables getting in. Regards, Ap.Muthu > Hi, > > just one note on 6779, there was one value missing in > care_config_global. Can be added by: > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > Robert -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers >> -- >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> ___ >> Care2002-developers mailing list >> Care2002-developers@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/care2002-developers >> > > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to c
Re: [Care2002-developers] revision 6779
Well, if the version table is been used somewhere, I have not seen it over the years. About the version numbering as comments. I would like to move that topic when we killed all relevant bugs out and place a (c) setting in each file. We have to do it, care2x was pirated and sold in the past many times. When you have the ER diagram ready, please send it. That would be nice to have. What app you are using for? Robert Am Mittwoch, den 22.09.2010, 00:36 +0530 schrieb Ap.Muthu: > $$ - Mostly used as LD_var for translating strings and possibly field names > A data dictionary is what is needed. > I will now try to make some (non)sense out of an entity relationship diagram > for care2x. > The unusual naming conventions for naming fields have got me dizzy. > Since we are all using MySQL5, should we not go in for some views? > $$ is very useful in handling recursively a set of field names and table > names from the information_schema table to act uipon user tables across a > set of similar databases. > Many files have the version number of Care2x hard coded - sould we not use > some config variable for it and do away with the versions table? Is the > versions table used anywhere? > > Regards, > Ap.Muthu > > > > Hi Robert, > > > > you are so right about the $$ a lot of modules uses it, > > prescription, lab requests, depot... > > it's really a dark chapter.. > > > > gj. > > > > On 2010-09-21 8:49.MD, Robert Meggle wrote: > >> Hi Muthu, > >> > >> We are now on the level where all had started of care2x nearly 10 years > >> ago. Since that time that peace of code had not been touched. But you're > >> right, the "_" will be escaped by MySQL and the interesting thing is > >> that somehow it had been worked now since years. > >> > >> Another aspect, especially on that ground.level.zero: The idea to store > >> that kind of global settings in a table like we are discussing it now is > >> really ok, but we can discuss the naming convention of it. But the way > >> how it is used by $$ use of var look: > >> http://www.php.net/manual/en/language.variables.variable.php > >> > >> That is a dark chapter of php how to (mis)use variables. Normally you > >> should read it, understand it, and -please- forget it and never use it! > >> > >> Robert > >> > >> > >> Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: > >>> Hi Robert, > >>> > >>> That's a good one. > >>> > >>> I did notice that in many parts of the code the global config variable > >>> was > >>> selectively filtered using "person_%". In MySQL, the "_" should be > >>> escaped > >>> as otherwise it means any characters wildcard. The existing filter will > >>> choose "personell" and "person_" as well! I do not know if the > >>> "person\_%" > >>> will work as an argument in the function but it certainly works in MySQL > >>> directly. At the moment it is not affecting any working by having a few > >>> more > >>> unfiltered variables getting in. > >>> > >>> Regards, > >>> Ap.Muthu > >>> > Hi, > > just one note on 6779, there was one value missing in > care_config_global. Can be added by: > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > Robert > >>> > >>> > >>> -- > >>> Start uncovering the many advantages of virtual appliances > >>> and start using them to simplify application deployment and > >>> accelerate your shift to cloud computing. > >>> http://p.sf.net/sfu/novell-sfdev2dev > >>> ___ > >>> Care2002-developers mailing list > >>> Care2002-developers@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/care2002-developers > > > > -- > > Start uncovering the many advantages of virtual appliances > > and start using them to simplify application deployment and > > accelerate your shift to cloud computing. > > http://p.sf.net/sfu/novell-sfdev2dev > > ___ > > Care2002-developers mailing list > > Care2002-developers@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/care2002-developers > > > > > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers -- -- CARE2X - free Integ Hospital Info System https://sourceforge.net/projects/care2002/ http://www.care2x.org
Re: [Care2002-developers] revision 6779
$$ - Mostly used as LD_var for translating strings and possibly field names A data dictionary is what is needed. I will now try to make some (non)sense out of an entity relationship diagram for care2x. The unusual naming conventions for naming fields have got me dizzy. Since we are all using MySQL5, should we not go in for some views? $$ is very useful in handling recursively a set of field names and table names from the information_schema table to act uipon user tables across a set of similar databases. Many files have the version number of Care2x hard coded - sould we not use some config variable for it and do away with the versions table? Is the versions table used anywhere? Regards, Ap.Muthu > Hi Robert, > > you are so right about the $$ a lot of modules uses it, > prescription, lab requests, depot... > it's really a dark chapter.. > > gj. > > On 2010-09-21 8:49.MD, Robert Meggle wrote: >> Hi Muthu, >> >> We are now on the level where all had started of care2x nearly 10 years >> ago. Since that time that peace of code had not been touched. But you're >> right, the "_" will be escaped by MySQL and the interesting thing is >> that somehow it had been worked now since years. >> >> Another aspect, especially on that ground.level.zero: The idea to store >> that kind of global settings in a table like we are discussing it now is >> really ok, but we can discuss the naming convention of it. But the way >> how it is used by $$ use of var look: >> http://www.php.net/manual/en/language.variables.variable.php >> >> That is a dark chapter of php how to (mis)use variables. Normally you >> should read it, understand it, and -please- forget it and never use it! >> >> Robert >> >> >> Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: >>> Hi Robert, >>> >>> That's a good one. >>> >>> I did notice that in many parts of the code the global config variable >>> was >>> selectively filtered using "person_%". In MySQL, the "_" should be >>> escaped >>> as otherwise it means any characters wildcard. The existing filter will >>> choose "personell" and "person_" as well! I do not know if the >>> "person\_%" >>> will work as an argument in the function but it certainly works in MySQL >>> directly. At the moment it is not affecting any working by having a few >>> more >>> unfiltered variables getting in. >>> >>> Regards, >>> Ap.Muthu >>> Hi, just one note on 6779, there was one value missing in care_config_global. Can be added by: INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); Robert >>> >>> >>> -- >>> Start uncovering the many advantages of virtual appliances >>> and start using them to simplify application deployment and >>> accelerate your shift to cloud computing. >>> http://p.sf.net/sfu/novell-sfdev2dev >>> ___ >>> Care2002-developers mailing list >>> Care2002-developers@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/care2002-developers > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers > -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Robert, you are so right about the $$ a lot of modules uses it, prescription, lab requests, depot... it's really a dark chapter.. gj. On 2010-09-21 8:49.MD, Robert Meggle wrote: > Hi Muthu, > > We are now on the level where all had started of care2x nearly 10 years > ago. Since that time that peace of code had not been touched. But you're > right, the "_" will be escaped by MySQL and the interesting thing is > that somehow it had been worked now since years. > > Another aspect, especially on that ground.level.zero: The idea to store > that kind of global settings in a table like we are discussing it now is > really ok, but we can discuss the naming convention of it. But the way > how it is used by $$ use of var look: > http://www.php.net/manual/en/language.variables.variable.php > > That is a dark chapter of php how to (mis)use variables. Normally you > should read it, understand it, and -please- forget it and never use it! > > Robert > > > Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: >> Hi Robert, >> >> That's a good one. >> >> I did notice that in many parts of the code the global config variable was >> selectively filtered using "person_%". In MySQL, the "_" should be escaped >> as otherwise it means any characters wildcard. The existing filter will >> choose "personell" and "person_" as well! I do not know if the "person\_%" >> will work as an argument in the function but it certainly works in MySQL >> directly. At the moment it is not affecting any working by having a few more >> unfiltered variables getting in. >> >> Regards, >> Ap.Muthu >> >>> Hi, >>> >>> just one note on 6779, there was one value missing in >>> care_config_global. Can be added by: >>> >>> INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', >>> '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); >>> >>> Robert >> >> >> -- >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> ___ >> Care2002-developers mailing list >> Care2002-developers@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/care2002-developers -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Tim, I think you can smell my idea :D Robert Am Dienstag, den 21.09.2010, 19:49 +0100 schrieb Tim Schofield: > Hi Robert, > > Have you looked at how the insurances work in the care2utu branch? > > Tim > > On 21 September 2010 19:41, Robert Meggle wrote: > > Hi Muthu, > > > > In fact you got the point I complain. Is there really a need for such > > insurance things? Insurances are always handled in a different, depends > > on government to government, from country to country and even from > > clinic to clinic. > > > > My intention is that registration place would be the right place for > > such kind of information but should be handled in different way. Every > > free text field allows misspelling issues and will bring that element of > > information down to an useless case. > > > > I would recommend to forget these insurances things for the moment and > > let us think later how to deal with an connected ERP software for > > financial settings. > > > > Any other suggestions? > > > > Robert > > > > > > Am Dienstag, den 21.09.2010, 23:55 +0530 schrieb Ap.Muthu: > >> Hi Robert, > >> > >> What is the purpose of the "status" field being "normal" for certain values > >> in the table: care_config_global ? > >> > >> In the code for saving to theinsurance table, the check is that if the > >> insurance number is non empty and the insurance company is non epty only > >> then will the insurance data be entered, else only the person data is > >> entered. Now that the insurance class number field has come in, should all > >> of that be re-coded to insist on a class being chosen if an insurance > >> number > >> is entered? > >> > >> Regards, > >> Ap.Muthu > >> apmu...@usa.net > >> > >> > >> > Hi, > >> > > >> > just one note on 6779, there was one value missing in > >> > care_config_global. Can be added by: > >> > > >> > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > >> > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > >> > > >> > Robert > >> > >> > >> > >> -- > >> Start uncovering the many advantages of virtual appliances > >> and start using them to simplify application deployment and > >> accelerate your shift to cloud computing. > >> http://p.sf.net/sfu/novell-sfdev2dev > >> ___ > >> Care2002-developers mailing list > >> Care2002-developers@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/care2002-developers > > > > -- > > -- > > > > CARE2X - free Integ Hospital Info System > > https://sourceforge.net/projects/care2002/ > > http://www.care2x.org > > > > > > -- > > Start uncovering the many advantages of virtual appliances > > and start using them to simplify application deployment and > > accelerate your shift to cloud computing. > > http://p.sf.net/sfu/novell-sfdev2dev > > ___ > > Care2002-developers mailing list > > Care2002-developers@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/care2002-developers > > > > > -- MEROTECH IT Engineering Robert Meggle St.-Mang-Str. 8 87616 Marktoberdorf Germany Tel: +49(0)8342 - 8956729 Fax: +49(0)8342 - 8956730 mailto:meg...@merotech.de -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Muthu, We are now on the level where all had started of care2x nearly 10 years ago. Since that time that peace of code had not been touched. But you're right, the "_" will be escaped by MySQL and the interesting thing is that somehow it had been worked now since years. Another aspect, especially on that ground.level.zero: The idea to store that kind of global settings in a table like we are discussing it now is really ok, but we can discuss the naming convention of it. But the way how it is used by $$ use of var look: http://www.php.net/manual/en/language.variables.variable.php That is a dark chapter of php how to (mis)use variables. Normally you should read it, understand it, and -please- forget it and never use it! Robert Am Dienstag, den 21.09.2010, 23:19 +0530 schrieb Ap.Muthu: > Hi Robert, > > That's a good one. > > I did notice that in many parts of the code the global config variable was > selectively filtered using "person_%". In MySQL, the "_" should be escaped > as otherwise it means any characters wildcard. The existing filter will > choose "personell" and "person_" as well! I do not know if the "person\_%" > will work as an argument in the function but it certainly works in MySQL > directly. At the moment it is not affecting any working by having a few more > unfiltered variables getting in. > > Regards, > Ap.Muthu > > > Hi, > > > > just one note on 6779, there was one value missing in > > care_config_global. Can be added by: > > > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > > > Robert > > > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers -- -- CARE2X - free Integ Hospital Info System https://sourceforge.net/projects/care2002/ http://www.care2x.org -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Robert, Have you looked at how the insurances work in the care2utu branch? Tim On 21 September 2010 19:41, Robert Meggle wrote: > Hi Muthu, > > In fact you got the point I complain. Is there really a need for such > insurance things? Insurances are always handled in a different, depends > on government to government, from country to country and even from > clinic to clinic. > > My intention is that registration place would be the right place for > such kind of information but should be handled in different way. Every > free text field allows misspelling issues and will bring that element of > information down to an useless case. > > I would recommend to forget these insurances things for the moment and > let us think later how to deal with an connected ERP software for > financial settings. > > Any other suggestions? > > Robert > > > Am Dienstag, den 21.09.2010, 23:55 +0530 schrieb Ap.Muthu: >> Hi Robert, >> >> What is the purpose of the "status" field being "normal" for certain values >> in the table: care_config_global ? >> >> In the code for saving to theinsurance table, the check is that if the >> insurance number is non empty and the insurance company is non epty only >> then will the insurance data be entered, else only the person data is >> entered. Now that the insurance class number field has come in, should all >> of that be re-coded to insist on a class being chosen if an insurance number >> is entered? >> >> Regards, >> Ap.Muthu >> apmu...@usa.net >> >> >> > Hi, >> > >> > just one note on 6779, there was one value missing in >> > care_config_global. Can be added by: >> > >> > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', >> > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); >> > >> > Robert >> >> >> >> -- >> Start uncovering the many advantages of virtual appliances >> and start using them to simplify application deployment and >> accelerate your shift to cloud computing. >> http://p.sf.net/sfu/novell-sfdev2dev >> ___ >> Care2002-developers mailing list >> Care2002-developers@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/care2002-developers > > -- > -- > > CARE2X - free Integ Hospital Info System > https://sourceforge.net/projects/care2002/ > http://www.care2x.org > > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers > -- WebERP Africa Ltd +447710427049 +256752963327 +255784602561 www.weberpafrica.com -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Muthu, In fact you got the point I complain. Is there really a need for such insurance things? Insurances are always handled in a different, depends on government to government, from country to country and even from clinic to clinic. My intention is that registration place would be the right place for such kind of information but should be handled in different way. Every free text field allows misspelling issues and will bring that element of information down to an useless case. I would recommend to forget these insurances things for the moment and let us think later how to deal with an connected ERP software for financial settings. Any other suggestions? Robert Am Dienstag, den 21.09.2010, 23:55 +0530 schrieb Ap.Muthu: > Hi Robert, > > What is the purpose of the "status" field being "normal" for certain values > in the table: care_config_global ? > > In the code for saving to theinsurance table, the check is that if the > insurance number is non empty and the insurance company is non epty only > then will the insurance data be entered, else only the person data is > entered. Now that the insurance class number field has come in, should all > of that be re-coded to insist on a class being chosen if an insurance number > is entered? > > Regards, > Ap.Muthu > apmu...@usa.net > > > > Hi, > > > > just one note on 6779, there was one value missing in > > care_config_global. Can be added by: > > > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > > > Robert > > > > -- > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > ___ > Care2002-developers mailing list > Care2002-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/care2002-developers -- -- CARE2X - free Integ Hospital Info System https://sourceforge.net/projects/care2002/ http://www.care2x.org -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Robert, What is the purpose of the "status" field being "normal" for certain values in the table: care_config_global ? In the code for saving to theinsurance table, the check is that if the insurance number is non empty and the insurance company is non epty only then will the insurance data be entered, else only the person data is entered. Now that the insurance class number field has come in, should all of that be re-coded to insist on a class being chosen if an insurance number is entered? Regards, Ap.Muthu apmu...@usa.net > Hi, > > just one note on 6779, there was one value missing in > care_config_global. Can be added by: > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > Robert -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
Re: [Care2002-developers] revision 6779
Hi Robert, That's a good one. I did notice that in many parts of the code the global config variable was selectively filtered using "person_%". In MySQL, the "_" should be escaped as otherwise it means any characters wildcard. The existing filter will choose "personell" and "person_" as well! I do not know if the "person\_%" will work as an argument in the function but it certainly works in MySQL directly. At the moment it is not affecting any working by having a few more unfiltered variables getting in. Regards, Ap.Muthu > Hi, > > just one note on 6779, there was one value missing in > care_config_global. Can be added by: > > INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', > '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); > > Robert -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers
[Care2002-developers] revision 6779
Hi, just one note on 6779, there was one value missing in care_config_global. Can be added by: INSERT INTO care_config_global VALUES ('person_insurance_1_nr_hide', '1', NULL, '', '', '', 00, '', '-00-00 00:00:00'); Robert -- -- CARE2X - free Integ Hospital Info System https://sourceforge.net/projects/care2002/ http://www.care2x.org -- Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev ___ Care2002-developers mailing list Care2002-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/care2002-developers