[chromium-dev] Re: [chromium-extensions] Extensions gallery open for uploads
Did you try to unpublish and then publish the extension again and download? ☆PhistucK On Thu, Dec 3, 2009 at 10:37, Anders Bergh ande...@gmail.com wrote: On Mon, Nov 23, 2009 at 23:48, Aaron Boodman a...@chromium.org wrote: Hello all, I'm happy to announce that the developer area of our extensions gallery is now open: https://chrome.google.com/extensions You can upload your extensions, edit their details, add screenshots and videos, test the autoupdate system, and begin publishing your download URL. We are opening these features early so that developers like yourselves will have time to get familiar with the system, flush out any bugs, and publish your extensions before our full launch. For more information, please see the blog post, here: http://blog.chromium.org/2009/11/extensions-one-step-closer-to-finish.html Looking forward to seeing what you've built! -- Aaron Boodman, on behalf of the Google Chrome Extensions team -- You received this message because you are subscribed to the Google Groups Chromium-extensions group. To post to this group, send email to chromium-extensi...@googlegroups.com. To unsubscribe from this group, send email to chromium-extensions+unsubscr...@googlegroups.comchromium-extensions%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=. Hi, I hope this is the right place for this. I uploaded a little extension I made, and later uploaded a new version. The information page shows the new version (2.0.2) but whenever I use the install link it gets me the first version (2.0.1). Chrome auto update doesn't work either. The extension in question: https://chrome.google.com/extensions/detail/aabigfkipkmnbbcliomedcncdcmcncgc -- Anders Bergh -- You received this message because you are subscribed to the Google Groups Chromium-extensions group. To post to this group, send email to chromium-extensi...@googlegroups.com. To unsubscribe from this group, send email to chromium-extensions+unsubscr...@googlegroups.comchromium-extensions%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=en. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Core Text
Hi Drew Albert, I picked your names off the WebKit sheriff calendar. I've landed a change to switch the Mac port over from ATSUI-Core Text APIs on the WebKit tree at http://trac.webkit.org/changeset/51633 . If you see stability or performance issues on the next WebKit roll then feel free to revert this CL (just drop me an email with a link to the bad run if you do so, please). Thanks, Jeremy 2009/11/24 Jeremy Moskovich jer...@chromium.org Thanks Hironori, I thought so too at the beginning but it turns out that they are available, just not declared in public headers. The WebKit bug I linked to has a patch that switches us to Core Text on 10.5 10.6. I'll do some perf tests and then we can make a decision based on that. Best regards, Jeremy 2009/11/24 Hironori Bono (坊野 博典) hb...@chromium.org Greetings Jeremy, This is just for your information. It seems WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp uses CTRunGetAdvancesPtr() and CTRunGetAdvances(), which are available only on 10.6 or later. (This might be a reason why WebKit doesn't use Core Text for Leopard?) (*1) http://developer.apple.com/mac/library/documentation/Carbon/Reference/CTRunRef/Reference/reference.html#//apple_ref/c/func/CTRunGetAdvancesPtr Best regards, Hironori Bono E-mail: hb...@chromium.org On Tue, Nov 24, 2009 at 6:17 AM, Jeremy Moskovich jer...@chromium.org wrote: Thanks Nico, I'll run some numbers. Best regards, Jeremy On Mon, Nov 23, 2009 at 11:15 PM, Nico Weber tha...@chromium.org wrote: Did you do measuring if it's actually slower on 10.5? The CoreText backend for MacVim is much faster than the ATSUI backend from what I've heard (then again, MacVim doesn't do very complex text rendering). (Source: http://groups.google.com/group/vim_mac/browse_thread/thread/b93c6dd5183bdc5e ) On Mon, Nov 23, 2009 at 12:58 PM, Jeremy Moskovich jer...@chromium.org wrote: Re http://crbug.com/27195 https://bugs.webkit.org/show_bug.cgi?id=31802 : Dan Bernstein says that Core Text on Leopard has performance issues vs ATSUI so I'm going to look into switching APIs at runtime rather than compile time. So we'd use ATSUI 10.6 Core Text = 10.6 . Best regards, Jeremy -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
Our messages crossed in the ether ... On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai o...@google.com wrote: +chromium-dev as others who look at the waterfall might also be confused. On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov dglaz...@google.com wrote: Sending out random people, because it's early :) There's a couple of things I see on the bot this morning: 1) There's a crashing test on all bots -- and the tree is still green! http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/plugins/embed-attributes-setting.html The test is consistently crashing when run with all the other tests, but passing when we retry it in isolation. Note that the test is listed as an unexpected flaky test on the waterfall. This is one of the downsides of retrying failing tests. We can't distinguish flakiness from this case. We just need to careful to not ignore unexpected flakiness on the waterfall. Note that the dashboard only shows the result from the first run. Including the retry results from the bots seems like more trouble than it's worth. Agreed. However, why aren't the webkit bots orange in the main waterfall? 2) WebKit (dbg) shows insane fixable numbers -- 6561 fixable? This is a bug from Dirk's commit yesterday. Dirk, PrepareListsAndPrintOutput creates the ResultSummary object with the full test list, then shards the test list, then runs the tests. So the value used for number of tests run is the total number of tests, not the sharded total number of tests. Yup. I'll fix this when I get in (~11:30ish). -- Dirk -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai o...@google.com wrote: +chromium-dev as others who look at the waterfall might also be confused. On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov dglaz...@google.com wrote: Sending out random people, because it's early :) There's a couple of things I see on the bot this morning: 1) There's a crashing test on all bots -- and the tree is still green! http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/plugins/embed-attributes-setting.html The test is consistently crashing when run with all the other tests, but passing when we retry it in isolation. Note that the test is listed as an unexpected flaky test on the waterfall. This is one of the downsides of retrying failing tests. We can't distinguish flakiness from this case. We just need to careful to not ignore unexpected flakiness on the waterfall. Note that the dashboard only shows the result from the first run. Including the retry results from the bots seems like more trouble than it's worth. Should unexpected flakiness turn the bot red? :DG -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
On Thu, Dec 3, 2009 at 10:09 AM, Dimitri Glazkov dglaz...@google.comwrote: On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai o...@google.com wrote: +chromium-dev as others who look at the waterfall might also be confused. On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov dglaz...@google.com wrote: Sending out random people, because it's early :) There's a couple of things I see on the bot this morning: 1) There's a crashing test on all bots -- and the tree is still green! http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests/plugins/embed-attributes-setting.html The test is consistently crashing when run with all the other tests, but passing when we retry it in isolation. Note that the test is listed as an unexpected flaky test on the waterfall. This is one of the downsides of retrying failing tests. We can't distinguish flakiness from this case. We just need to careful to not ignore unexpected flakiness on the waterfall. Note that the dashboard only shows the result from the first run. Including the retry results from the bots seems like more trouble than it's worth. Should unexpected flakiness turn the bot red? If it turns the bot red, then it defeats the purpose of that code. Might as well not retry and mark it as FAIL. (which turns the tree red). Nicolas :DG -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
On Thu, Dec 3, 2009 at 10:17 AM, Nicolas Sylvain nsylv...@chromium.org wrote: Should unexpected flakiness turn the bot red? If it turns the bot red, then it defeats the purpose of that code. Might as well not retry and mark it as FAIL. (which turns the tree red). Duh :) Makes sense. How about we turn red for unexpected crashiness? :DG -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov dglaz...@google.com wrote: How about we turn red for unexpected crashiness? Makes sense to me. We can just not retry tests that unexpectedly crash. On Thu, Dec 3, 2009 at 10:09 AM, Dirk Pranke dpra...@google.com wrote: On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai o...@google.com wrote: The test is consistently crashing when run with all the other tests, but passing when we retry it in isolation. Note that the test is listed as an unexpected flaky test on the waterfall. This is one of the downsides of retrying failing tests. We can't distinguish flakiness from this case. We just need to careful to not ignore unexpected flakiness on the waterfall. Note that the dashboard only shows the result from the first run. Including the retry results from the bots seems like more trouble than it's worth. Agreed. However, why aren't the webkit bots orange in the main waterfall? They are orange. We don't show orange in the console view or summary view at the top part of the waterfall though. I'm not really sure why. Nicolas, you know? I know in the console view we use orange to mean something else, but maybe we should not overload the meaning of orange so much. :) -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai o...@chromium.org wrote: On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov dglaz...@google.com wrote: How about we turn red for unexpected crashiness? Makes sense to me. We can just not retry tests that unexpectedly crash. On Thu, Dec 3, 2009 at 10:09 AM, Dirk Pranke dpra...@google.com wrote: On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai o...@google.com wrote: The test is consistently crashing when run with all the other tests, but passing when we retry it in isolation. Note that the test is listed as an unexpected flaky test on the waterfall. This is one of the downsides of retrying failing tests. We can't distinguish flakiness from this case. We just need to careful to not ignore unexpected flakiness on the waterfall. Note that the dashboard only shows the result from the first run. Including the retry results from the bots seems like more trouble than it's worth. Agreed. However, why aren't the webkit bots orange in the main waterfall? They are orange. We don't show orange in the console view or summary view at the top part of the waterfall though. I'm not really sure why. Nicolas, you know? No idea, did you not write this? :) I know in the console view we use orange to mean something else, but maybe we should not overload the meaning of orange so much. :) I think it's the goal of the console view to try hard not to attribute flakiness to a change that most likely did not cause it. The flakiness dashboard does a good job tracking this already. That said, if someone can find a good color for fail again, then I'd use it and use orange like on the waterfall. Nicolas -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Something smells weird on the buildbot
On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai o...@chromium.org wrote: On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov dglaz...@google.com wrote: How about we turn red for unexpected crashiness? Makes sense to me. We can just not retry tests that unexpectedly crash. I'll make this change if we have a consensus. Do we? -- Dirk -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] webcore_bindings target builds slowly
I filed a bug on this, including a proposal for how to improve build times by breaking DerivedSourcesAllInOne into four pieces (with a workaround to keep it building all-in-one for configurations that require that.) https://bugs.webkit.org/show_bug.cgi?id=32128 I'll do it, if people think it's a good idea... —Jens -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33707
Automatically closing tree for net_unittests on Modules XP (dbg) http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20009 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --= Automatically closing tree for net_unittests on Modules XP (dbg) =-- Revision: 33707 Blame list: ch...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Interested in HTML5 audio and video?
I've written a document describing our current implementation of the audio and video tags: http://sites.google.com/a/chromium.org/dev/developers/design-documents/video If you're interested in helping out, feel free to reply to me privately or take a look at our HelpWantedhttp://code.google.com/p/chromium/issues/list?q=label:video+label:HelpWantedbugs. Andrew -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Core Text
Hi Jeremy, My next roll will be to 51642 (in progress). I'll ping you when it lands so you can keep an eye on it too. -atw 2009/12/3 Jeremy Moskovich jer...@chromium.org Hi Drew Albert, I picked your names off the WebKit sheriff calendar. I've landed a change to switch the Mac port over from ATSUI-Core Text APIs on the WebKit tree at http://trac.webkit.org/changeset/51633 . If you see stability or performance issues on the next WebKit roll then feel free to revert this CL (just drop me an email with a link to the bad run if you do so, please). Thanks, Jeremy 2009/11/24 Jeremy Moskovich jer...@chromium.org Thanks Hironori, I thought so too at the beginning but it turns out that they are available, just not declared in public headers. The WebKit bug I linked to has a patch that switches us to Core Text on 10.5 10.6. I'll do some perf tests and then we can make a decision based on that. Best regards, Jeremy 2009/11/24 Hironori Bono (坊野 博典) hb...@chromium.org Greetings Jeremy, This is just for your information. It seems WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp uses CTRunGetAdvancesPtr() and CTRunGetAdvances(), which are available only on 10.6 or later. (This might be a reason why WebKit doesn't use Core Text for Leopard?) (*1) http://developer.apple.com/mac/library/documentation/Carbon/Reference/CTRunRef/Reference/reference.html#//apple_ref/c/func/CTRunGetAdvancesPtr Best regards, Hironori Bono E-mail: hb...@chromium.org On Tue, Nov 24, 2009 at 6:17 AM, Jeremy Moskovich jer...@chromium.org wrote: Thanks Nico, I'll run some numbers. Best regards, Jeremy On Mon, Nov 23, 2009 at 11:15 PM, Nico Weber tha...@chromium.org wrote: Did you do measuring if it's actually slower on 10.5? The CoreText backend for MacVim is much faster than the ATSUI backend from what I've heard (then again, MacVim doesn't do very complex text rendering). (Source: http://groups.google.com/group/vim_mac/browse_thread/thread/b93c6dd5183bdc5e ) On Mon, Nov 23, 2009 at 12:58 PM, Jeremy Moskovich jer...@chromium.org wrote: Re http://crbug.com/27195 https://bugs.webkit.org/show_bug.cgi?id=31802 : Dan Bernstein says that Core Text on Leopard has performance issues vs ATSUI so I'm going to look into switching APIs at runtime rather than compile time. So we'd use ATSUI 10.6 Core Text = 10.6 . Best regards, Jeremy -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Download Manager and double notification on download complete
I'm working on some UI related to downloads, and I need a clean indication that a download is finished. Not just finished but Finished. And I've found we're getting two notifications: one before auto-opening happens, and one after it happens. If we look at DownloadManager::ContinueDownloadFinished (line 867) we see: // Notify our observers that we are complete (the call to Finished() set the // state to complete but did not notify). download-UpdateObservers(); That's at the very end, and that's the real Finished notification (auto-open is done, etc). Looking at the comment we see that we'd called DownloadItem::Finished earlier (in fact, in DownloadManager::DownloadFinished, line 814). But if you look at the implementation of DownloadItem::Finished you'll see that the comment is a lie... Glen changed it about a year agohttp://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_manager.cc?r1=4049r2=4177to fix a bug, so I'm not keen on switching it back. But I need to know when a download's done. Any download experts have an opinion? Avi -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Need a linux-views build buddy.
I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in and break it. That's where you come in! Would someone mind trying http://codereview.chromium.org/465005/show for me with linux views and see if it's all ok? The only tricky part is that there's an svn move on 2 files in there, but the trybots seem able to figure it out. Would be much appreciated, thanks! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Need a linux-views build buddy.
Isn't gcl try cl -b linux_view what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton pinker...@chromium.orgwrote: I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in and break it. That's where you come in! Would someone mind trying http://codereview.chromium.org/465005/show for me with linux views and see if it's all ok? The only tricky part is that there's an svn move on 2 files in there, but the trybots seem able to figure it out. Would be much appreciated, thanks! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Need a linux-views build buddy.
The same is true of view_chromeos, FWIW. On Thu, Dec 3, 2009 at 5:45 PM, Mike Pinkerton pinker...@chromium.org wrote: Yes, except it's down and hasn't worked in days. On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow jor...@chromium.org wrote: Isn't gcl try cl -b linux_view what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton pinker...@chromium.org wrote: I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in and break it. That's where you come in! Would someone mind trying http://codereview.chromium.org/465005/show for me with linux views and see if it's all ok? The only tricky part is that there's an svn move on 2 files in there, but the trybots seem able to figure it out. Would be much appreciated, thanks! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Mike Pinkerton Mac Weenie pinker...@google.com -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Need a linux-views build buddy.
Yes, except it's down and hasn't worked in days. On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow jor...@chromium.org wrote: Isn't gcl try cl -b linux_view what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton pinker...@chromium.org wrote: I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in and break it. That's where you come in! Would someone mind trying http://codereview.chromium.org/465005/show for me with linux views and see if it's all ok? The only tricky part is that there's an svn move on 2 files in there, but the trybots seem able to figure it out. Would be much appreciated, thanks! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33741
Automatically closing tree for net_unittests on Modules XP (dbg) http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20030 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --= Automatically closing tree for net_unittests on Modules XP (dbg) =-- Revision: 33740, 33741 Blame list: rafa...@chromium.org,vand...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Modules XP (dbg), revision 33744
Automatically closing tree for net_unittests on Modules XP (dbg) http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP%20%28dbg%29/builds/20032 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP%20%28dbg%29 --= Automatically closing tree for net_unittests on Modules XP (dbg) =-- Revision: 33744 Blame list: c...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Need a linux-views build buddy.
I filed http://crbug.com/29364 On Thu, Dec 3, 2009 at 2:45 PM, Mike Pinkerton pinker...@chromium.org wrote: Yes, except it's down and hasn't worked in days. On Thu, Dec 3, 2009 at 5:44 PM, Jeremy Orlow jor...@chromium.org wrote: Isn't gcl try cl -b linux_view what you want? On Thu, Dec 3, 2009 at 1:46 PM, Mike Pinkerton pinker...@chromium.org wrote: I've got a cl that builds fine on win/mac/linux but I'm afraid I could impact views_linux. And, since there's no trybot, I have no way of knowing until I actually check in and break it. That's where you come in! Would someone mind trying http://codereview.chromium.org/465005/show for me with linux views and see if it's all ok? The only tricky part is that there's an svn move on 2 files in there, but the trybots seem able to figure it out. Would be much appreciated, thanks! -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] gcl commit throwing SVN server error
When I try to commit my change, I am getting following error there - any ideas what might be causing this? gcl commit my_change Presubmit checks took 1.7s to calculate. Loaded authentication cookies from C:\Users\zelidrag/.codereview_upload_cookies svn: Commit failed (details follow): svn: Server sent unexpected return value (500 Internal Server Error) in response to MKACTIVITY request for '/svn/!svn/act/aa57d512-f59f-9147-897e-0c6aef5f25fc' -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] gcl commit throwing SVN server error
Sounds like you're trying to commit to the read-only repo? On Thu, Dec 3, 2009 at 3:31 PM, Zelidrag Hornung zelid...@chromium.org wrote: When I try to commit my change, I am getting following error there - any ideas what might be causing this? gcl commit my_change Presubmit checks took 1.7s to calculate. Loaded authentication cookies from C:\Users\zelidrag/.codereview_upload_cookies svn: Commit failed (details follow): svn: Server sent unexpected return value (500 Internal Server Error) in response to MKACTIVITY request for '/svn/!svn/act/aa57d512-f59f-9147-897e-0c6aef5f25fc' -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] gcl commit throwing SVN server error
If you're a committer, you should have recieved instructions on how to set up your client (it will have an svn rather than an http url) when you got your commit password. On Thu, Dec 3, 2009 at 3:51 PM, Zelidrag Hornung zelid...@google.com wrote: How do I know if the repo is read-only? This is how my .gclient looks like solutions = [ { name : src, url : http://src.chromium.org/svn/trunk/src;, custom_deps : { # To use the trunk of a component instead of what's in DEPS: #component: https://svnserver/component/trunk/;, # To exclude a component from your working copy: #data/really_large_component: None, }, safesync_url: http://chromium-status.appspot.com/lkgr; }, ] On Thu, Dec 3, 2009 at 3:48 PM, Dan Kegel d...@kegel.com wrote: Sounds like you're trying to commit to the read-only repo? On Thu, Dec 3, 2009 at 3:31 PM, Zelidrag Hornung zelid...@chromium.org wrote: When I try to commit my change, I am getting following error there - any ideas what might be causing this? gcl commit my_change Presubmit checks took 1.7s to calculate. Loaded authentication cookies from C:\Users\zelidrag/.codereview_upload_cookies svn: Commit failed (details follow): svn: Server sent unexpected return value (500 Internal Server Error) in response to MKACTIVITY request for '/svn/!svn/act/aa57d512-f59f-9147-897e-0c6aef5f25fc' -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Webkit Linux, revision 33756
Automatically closing tree for test_shell_tests on Webkit Linux http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/14929 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Linux --= Automatically closing tree for test_shell_tests on Webkit Linux =-- Revision: 33755, 33756 Blame list: aka...@chromium.org,tha...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Mac10.5 Tests, revision 33758
Automatically closing tree for unit_tests on Mac10.5 Tests http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/9314 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests --= Automatically closing tree for unit_tests on Mac10.5 Tests =-- Revision: 33758 Blame list: viettrung...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Chromium XP, revision 33766
Automatically closing tree for check deps on Chromium XP http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/9003 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20XP --= Automatically closing tree for check deps on Chromium XP =-- Revision: 33757, 33758, 33759, 33760, 33761, 33762, 33763, 33764, 33765, 33766 Blame list: ch...@chromium.org,dpra...@google.com,mbel...@chromium.org,o...@chromium.org,rvar...@google.com,vand...@google.com,viettrung...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 33775
Automatically closing tree for compile on Linux Builder (ChromiumOS) http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/931 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28ChromiumOS%29 --= Automatically closing tree for compile on Linux Builder (ChromiumOS) =-- Revision: 33775 Blame list: est...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Linux Builder (Views dbg), revision 33776
Automatically closing tree for compile on Linux Builder (Views dbg) http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28Views%20dbg%29/builds/5398 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28Views%20dbg%29 --= Automatically closing tree for compile on Linux Builder (Views dbg) =-- Revision: 33774, 33775, 33776 Blame list: atwil...@chromium.org,est...@chromium.org,o...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: [chromium-extensions] Extensions gallery open for uploads
Hi Anders, That's a pain, sorry about that. I've filed a bug and asked our gallery team to take a look at it, I'll let you know what they find. -Nick On Thu, Dec 3, 2009 at 12:37 PM, Anders Bergh ande...@gmail.com wrote: At least more than 24h. On Thu, Dec 3, 2009 at 16:06, Erik Kay erik...@chromium.org wrote: There's usually a few minutes of lag before the new version actually becomes available. How long did you wait? Erik On Thu, Dec 3, 2009 at 12:37 AM, Anders Bergh ande...@gmail.com wrote: On Mon, Nov 23, 2009 at 23:48, Aaron Boodman a...@chromium.org wrote: Hello all, I'm happy to announce that the developer area of our extensions gallery is now open: https://chrome.google.com/extensions You can upload your extensions, edit their details, add screenshots and videos, test the autoupdate system, and begin publishing your download URL. We are opening these features early so that developers like yourselves will have time to get familiar with the system, flush out any bugs, and publish your extensions before our full launch. For more information, please see the blog post, here: http://blog.chromium.org/2009/11/extensions-one-step-closer-to-finish.html Looking forward to seeing what you've built! -- Aaron Boodman, on behalf of the Google Chrome Extensions team -- You received this message because you are subscribed to the Google Groups Chromium-extensions group. To post to this group, send email to chromium-extensi...@googlegroups.com. To unsubscribe from this group, send email to chromium-extensions+unsubscr...@googlegroups.comchromium-extensions%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=. Hi, I hope this is the right place for this. I uploaded a little extension I made, and later uploaded a new version. The information page shows the new version (2.0.2) but whenever I use the install link it gets me the first version (2.0.1). Chrome auto update doesn't work either. The extension in question: https://chrome.google.com/extensions/detail/aabigfkipkmnbbcliomedcncdcmcncgc -- Anders Bergh -- You received this message because you are subscribed to the Google Groups Chromium-extensions group. To post to this group, send email to chromium-extensi...@googlegroups.com. To unsubscribe from this group, send email to chromium-extensions+unsubscr...@googlegroups.comchromium-extensions%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=en. -- Anders Bergh -- You received this message because you are subscribed to the Google Groups Chromium-extensions group. To post to this group, send email to chromium-extensi...@googlegroups.com. To unsubscribe from this group, send email to chromium-extensions+unsubscr...@googlegroups.comchromium-extensions%2bunsubscr...@googlegroups.com . For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=en. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Core Text
It looks like this had some negative perf issues: http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf%281%29/builds/6289/steps/page_cycler_intl2/logs/stdio http://build.chromium.org/buildbot/perf/mac-release-10.5/intl2/report.html?history=150 (my DEPS roll was 33776) I'm going to revert. -atw 2009/12/3 Jeremy Moskovich jer...@chromium.org Hi Drew Albert, I picked your names off the WebKit sheriff calendar. I've landed a change to switch the Mac port over from ATSUI-Core Text APIs on the WebKit tree at http://trac.webkit.org/changeset/51633 . If you see stability or performance issues on the next WebKit roll then feel free to revert this CL (just drop me an email with a link to the bad run if you do so, please). Thanks, Jeremy 2009/11/24 Jeremy Moskovich jer...@chromium.org Thanks Hironori, I thought so too at the beginning but it turns out that they are available, just not declared in public headers. The WebKit bug I linked to has a patch that switches us to Core Text on 10.5 10.6. I'll do some perf tests and then we can make a decision based on that. Best regards, Jeremy 2009/11/24 Hironori Bono (坊野 博典) hb...@chromium.org Greetings Jeremy, This is just for your information. It seems WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp uses CTRunGetAdvancesPtr() and CTRunGetAdvances(), which are available only on 10.6 or later. (This might be a reason why WebKit doesn't use Core Text for Leopard?) (*1) http://developer.apple.com/mac/library/documentation/Carbon/Reference/CTRunRef/Reference/reference.html#//apple_ref/c/func/CTRunGetAdvancesPtr Best regards, Hironori Bono E-mail: hb...@chromium.org On Tue, Nov 24, 2009 at 6:17 AM, Jeremy Moskovich jer...@chromium.org wrote: Thanks Nico, I'll run some numbers. Best regards, Jeremy On Mon, Nov 23, 2009 at 11:15 PM, Nico Weber tha...@chromium.org wrote: Did you do measuring if it's actually slower on 10.5? The CoreText backend for MacVim is much faster than the ATSUI backend from what I've heard (then again, MacVim doesn't do very complex text rendering). (Source: http://groups.google.com/group/vim_mac/browse_thread/thread/b93c6dd5183bdc5e ) On Mon, Nov 23, 2009 at 12:58 PM, Jeremy Moskovich jer...@chromium.org wrote: Re http://crbug.com/27195 https://bugs.webkit.org/show_bug.cgi?id=31802 : Dan Bernstein says that Core Text on Leopard has performance issues vs ATSUI so I'm going to look into switching APIs at runtime rather than compile time. So we'd use ATSUI 10.6 Core Text = 10.6 . Best regards, Jeremy -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] make all doesn't work.
Hi, I just switched to use make to build chromium linux, but I found that make all didn't work at all. It only told me: make: Nothing to be done for `all'. Though it works if I specify the target name explicitly, such as make chrome. Is it a known issue of gyp? Or I missed something? - James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] make all doesn't work.
I think you don't need to specify a target to build everything i.e. just type make and it should work. --Craig On Fri, Dec 4, 2009 at 7:44 AM, James Su su...@chromium.org wrote: Hi, I just switched to use make to build chromium linux, but I found that make all didn't work at all. It only told me: make: Nothing to be done for `all'. Though it works if I specify the target name explicitly, such as make chrome. Is it a known issue of gyp? Or I missed something? - James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] make all doesn't work.
Unfortunately, it doesn't work. Actually, make == make all. - James Su 2009/12/4 Craig Schlenter craig.schlen...@gmail.com I think you don't need to specify a target to build everything i.e. just type make and it should work. --Craig On Fri, Dec 4, 2009 at 7:44 AM, James Su su...@chromium.org wrote: Hi, I just switched to use make to build chromium linux, but I found that make all didn't work at all. It only told me: make: Nothing to be done for `all'. Though it works if I specify the target name explicitly, such as make chrome. Is it a known issue of gyp? Or I missed something? - James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] make all doesn't work.
Hi One known problem with the make build is that you sometimes have to run it twice to rebuild the chrome target as the strings sometimes don't get rebuilt properly but if make chrome does something, then in theory make/make all should have built that too. What does make chrome build that make all doesn't? - that might give us some clues as to what is wrong. --Craig On Fri, Dec 4, 2009 at 7:53 AM, James Su su...@chromium.org wrote: Unfortunately, it doesn't work. Actually, make == make all. - James Su 2009/12/4 Craig Schlenter craig.schlen...@gmail.com I think you don't need to specify a target to build everything i.e. just type make and it should work. --Craig On Fri, Dec 4, 2009 at 7:44 AM, James Su su...@chromium.org wrote: Hi, I just switched to use make to build chromium linux, but I found that make all didn't work at all. It only told me: make: Nothing to be done for `all'. Though it works if I specify the target name explicitly, such as make chrome. Is it a known issue of gyp? Or I missed something? - James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] make all doesn't work.
make chrome works as expected, it builds out the chrome binary. But make or make all doesn't work at all. - James Su 2009/12/4 Craig Schlenter craig.schlen...@gmail.com Hi One known problem with the make build is that you sometimes have to run it twice to rebuild the chrome target as the strings sometimes don't get rebuilt properly but if make chrome does something, then in theory make/make all should have built that too. What does make chrome build that make all doesn't? - that might give us some clues as to what is wrong. --Craig On Fri, Dec 4, 2009 at 7:53 AM, James Su su...@chromium.org wrote: Unfortunately, it doesn't work. Actually, make == make all. - James Su 2009/12/4 Craig Schlenter craig.schlen...@gmail.com I think you don't need to specify a target to build everything i.e. just type make and it should work. --Craig On Fri, Dec 4, 2009 at 7:44 AM, James Su su...@chromium.org wrote: Hi, I just switched to use make to build chromium linux, but I found that make all didn't work at all. It only told me: make: Nothing to be done for `all'. Though it works if I specify the target name explicitly, such as make chrome. Is it a known issue of gyp? Or I missed something? - James Su -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev