[chromium-dev] Re: tryserver flakiness
On Wed, Aug 12, 2009 at 2:36 PM, Thomas Van Lenten wrote: > > On Wed, Aug 12, 2009 at 5:32 PM, Bradley Nelson wrote: > >> I would argue this does fall in the domain of something gyp should be able >> to do. Scons for instance detects when command lines have changed. If I >> recall correctly, xcode does as well. This wouldn't involve gyp touching the >> output directory at all, it would be more like how you can list a makefile >> as an input to some of its own rules. >> > Ok, so the build within Visual Studio is what's actually gonna nuke > everything, not the generator run? Yes, that's different and make more > sense. It would be nice if you could do this entirely within the GYP files > and not extra magic from the generator, but that might not be easily doable. > Please read this thread carefully. No one ever said anything about GYP nuking any output directories, and it was clearly state that this is a bug in Visual Studio and that we'll need to do some magic to point out dependencies it should have understood on its own. It sounds clear that there's no way to work around via changes in the GYP files. > -BradN >> >> On Aug 12, 2009 2:22 PM, "Thomas Van Lenten" >> wrote: >> >> >> >> On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson >> wrote: > > That one is know ... >> This doesn't sound like something for GYP to fix, the "fix" is detecting >> what visual studio doesn't and clobbering the build. I don't think we want >> any generators nuking output directories, etc? (the Mac generator doesn't >> even know about output dirs, the output dirs is completely controlled by the >> GYP files themselves.) >> >> TVL >> >> > > -BradN > > > On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow < >> jor...@google.com> wrote: >> >> Br... >> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
On Wed, Aug 12, 2009 at 5:32 PM, Bradley Nelson wrote: > I would argue this does fall in the domain of something gyp should be able > to do. Scons for instance detects when command lines have changed. If I > recall correctly, xcode does as well. This wouldn't involve gyp touching the > output directory at all, it would be more like how you can list a makefile > as an input to some of its own rules. > Ok, so the build within Visual Studio is what's actually gonna nuke everything, not the generator run? Yes, that's different and make more sense. It would be nice if you could do this entirely within the GYP files and not extra magic from the generator, but that might not be easily doable. > -BradN > > On Aug 12, 2009 2:22 PM, "Thomas Van Lenten" > wrote: > > > > On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson > wrote: > > That one is know ... > This doesn't sound like something for GYP to fix, the "fix" is detecting > what visual studio doesn't and clobbering the build. I don't think we want > any generators nuking output directories, etc? (the Mac generator doesn't > even know about output dirs, the output dirs is completely controlled by the > GYP files themselves.) > > TVL > > > > -BradN > > > On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow < > jor...@google.com> wrote: >> >> Br... > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
I would argue this does fall in the domain of something gyp should be able to do. Scons for instance detects when command lines have changed. If I recall correctly, xcode does as well. This wouldn't involve gyp touching the output directory at all, it would be more like how you can list a makefile as an input to some of its own rules. -BradN On Aug 12, 2009 2:22 PM, "Thomas Van Lenten" wrote: On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson wrote: > > That one is know ... This doesn't sound like something for GYP to fix, the "fix" is detecting what visual studio doesn't and clobbering the build. I don't think we want any generators nuking output directories, etc? (the Mac generator doesn't even know about output dirs, the output dirs is completely controlled by the GYP files themselves.) TVL > > -BradN > > > On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow < jor...@google.com> wrote: >> >> Br... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
I don't understand your response. On Wed, Aug 12, 2009 at 2:22 PM, Thomas Van Lenten wrote: > > > On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson wrote: > >> That one is know (we have a gyp issue filed from a while back).The >> problem is that visual studio doesn't detect command line changes (well >> actually it does as long as you do them in the IDE and don't leave the sln). >> We believe we can 'fix' this limitation by having gyp emit a file >> containing command line garp for each project and then having the relevant >> files treat that as an additional dependency. But its been on the back >> burner. >> > > This doesn't sound like something for GYP to fix, the "fix" is detecting > what visual studio doesn't and clobbering the build. > Why is nuking rather than adding a hack so VS understands dependencies it should have otherwise the right solution? > I don't think we want any generators nuking output directories, etc? > Isn't that what you just suggested? > (the Mac generator doesn't even know about output dirs, the output dirs is > completely controlled by the GYP files themselves.) > I don't understand what this means. I think the solution brad mentioned sounds like a fine one. > TVL > > >> -BradN >> >> >> On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow wrote: >> >>> Brad, looks like we might have another dependency bug in GYP? >>> >>> J >>> >>> >>> On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman wrote: >>> I just submitted the change that ENABLE's that flag a moment ago... we're clobbering things now On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: > Clobber needed? > I know Michael just enabled this within the last 24 hours. > > > On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. < > phajdan...@chromium.org> wrote: > >> Just got this on the Windows tryserver: >> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc >> : error C2220: warning treated as error - no 'object' file generated >> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc >> : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for >> precompiled header but not for current compile >> render_thread.cc >> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error >> C2220: warning treated as error - no 'object' file generated >> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning >> C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled >> header but not for current compile >> renderer_glue.cc >> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error >> C2220: warning treated as error - no 'object' file generated >> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning >> C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled >> header but not for current compile >> >> It's a bit annoying... Is it easily fixable? >> >> > > > >>> >> >> >> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
On Wed, Aug 12, 2009 at 5:03 PM, Bradley Nelson wrote: > That one is know (we have a gyp issue filed from a while back).The problem > is that visual studio doesn't detect command line changes (well actually it > does as long as you do them in the IDE and don't leave the sln). > We believe we can 'fix' this limitation by having gyp emit a file > containing command line garp for each project and then having the relevant > files treat that as an additional dependency. But its been on the back > burner. > This doesn't sound like something for GYP to fix, the "fix" is detecting what visual studio doesn't and clobbering the build. I don't think we want any generators nuking output directories, etc? (the Mac generator doesn't even know about output dirs, the output dirs is completely controlled by the GYP files themselves.) TVL > -BradN > > > On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow wrote: > >> Brad, looks like we might have another dependency bug in GYP? >> >> J >> >> >> On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman wrote: >> >>> I just submitted the change that ENABLE's that flag a moment ago... we're >>> clobbering things now >>> >>> >>> On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: >>> Clobber needed? I know Michael just enabled this within the last 24 hours. On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. < phajdan...@chromium.org> wrote: > Just got this on the Windows tryserver: > C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc > : error C2220: warning treated as error - no 'object' file generated > C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc > : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for > precompiled header but not for current compile > render_thread.cc > C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error > C2220: warning treated as error - no 'object' file generated > C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning > C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled > header but not for current compile > renderer_glue.cc > C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error > C2220: warning treated as error - no 'object' file generated > C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning > C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled > header but not for current compile > > It's a bit annoying... Is it easily fixable? > > >>> >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
That one is know (we have a gyp issue filed from a while back).The problem is that visual studio doesn't detect command line changes (well actually it does as long as you do them in the IDE and don't leave the sln). We believe we can 'fix' this limitation by having gyp emit a file containing command line garp for each project and then having the relevant files treat that as an additional dependency. But its been on the back burner. -BradN On Wed, Aug 12, 2009 at 1:59 PM, Jeremy Orlow wrote: > Brad, looks like we might have another dependency bug in GYP? > > J > > > On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman wrote: > >> I just submitted the change that ENABLE's that flag a moment ago... we're >> clobbering things now >> >> >> On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: >> >>> Clobber needed? >>> I know Michael just enabled this within the last 24 hours. >>> >>> >>> On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. < >>> phajdan...@chromium.org> wrote: >>> Just got this on the Windows tryserver: C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : error C2220: warning treated as error - no 'object' file generated C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but not for current compile render_thread.cc C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error C2220: warning treated as error - no 'object' file generated C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but not for current compile renderer_glue.cc C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error C2220: warning treated as error - no 'object' file generated C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but not for current compile It's a bit annoying... Is it easily fixable? >>> >>> >>> >>> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
I don't think so. It looks like VS doesn't rebuild files when the compiler invocation to build them would change. Michael added a new macro definition on the command line. If that's the case, this would be a VS problem (I'd call it a bug), and I'm not sure how easy it would be to work around in GYP. Jeremy Orlow wrote: > Brad, looks like we might have another dependency bug in GYP? > J > > On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman > wrote: >> >> I just submitted the change that ENABLE's that flag a moment ago... we're >> clobbering things now >> >> On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: >>> >>> Clobber needed? >>> I know Michael just enabled this within the last 24 hours. >>> >>> On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. >>> wrote: Just got this on the Windows tryserver: C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : error C2220: warning treated as error - no 'object' file generated C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but not for current compile render_thread.cc C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error C2220: warning treated as error - no 'object' file generated C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but not for current compile renderer_glue.cc C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error C2220: warning treated as error - no 'object' file generated C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but not for current compile It's a bit annoying... Is it easily fixable? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
Brad, looks like we might have another dependency bug in GYP? J On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman wrote: > I just submitted the change that ENABLE's that flag a moment ago... we're > clobbering things now > > > On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: > >> Clobber needed? >> I know Michael just enabled this within the last 24 hours. >> >> >> On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. < >> phajdan...@chromium.org> wrote: >> >>> Just got this on the Windows tryserver: >>> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : >>> error C2220: warning treated as error - no 'object' file generated >>> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : >>> warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for >>> precompiled header but not for current compile >>> render_thread.cc >>> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error C2220: >>> warning treated as error - no 'object' file generated >>> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning >>> C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled >>> header but not for current compile >>> renderer_glue.cc >>> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error C2220: >>> warning treated as error - no 'object' file generated >>> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning >>> C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled >>> header but not for current compile >>> >>> It's a bit annoying... Is it easily fixable? >>> >>> >> >> >> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
I just submitted the change that ENABLE's that flag a moment ago... we're clobbering things now On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow wrote: > Clobber needed? > I know Michael just enabled this within the last 24 hours. > > > On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. > wrote: > >> Just got this on the Windows tryserver: >> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : >> error C2220: warning treated as error - no 'object' file generated >> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : >> warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for >> precompiled header but not for current compile >> render_thread.cc >> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error C2220: >> warning treated as error - no 'object' file generated >> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning C4651: >> '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but >> not for current compile >> renderer_glue.cc >> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error C2220: >> warning treated as error - no 'object' file generated >> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning C4651: >> '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but >> not for current compile >> >> It's a bit annoying... Is it easily fixable? >> >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: tryserver flakiness
Clobber needed? I know Michael just enabled this within the last 24 hours. On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr. wrote: > Just got this on the Windows tryserver: > C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : > error C2220: warning treated as error - no 'object' file generated > C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc : > warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for > precompiled header but not for current compile > render_thread.cc > C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error C2220: > warning treated as error - no 'object' file generated > C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning C4651: > '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but > not for current compile > renderer_glue.cc > C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error C2220: > warning treated as error - no 'object' file generated > C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning C4651: > '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled header but > not for current compile > > It's a bit annoying... Is it easily fixable? > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
