API copyrightability
Hello Classpath hackers, What do you think the recent API copyrightability ruling http://www.cafc.uscourts.gov/images/stories/opinions-orders/13-1021.Opinion.5-7-2014.1.PDF means for non-Oracle (non-OpenJDK) Java library implementations like Classpath?
Re: [Classpath-inetlib] inetlib is moving
Andrew wrote: Any plans to also move to git like Classpath itself? We are actually moving to Subversion as I am very familiar with that and it is also preferred by my only other active developer. But I'm open to git at some point in the future if there is interest in doing so. -- Chris Burdess ___ Classpath-inetlib mailing list Classpath-inetlib@gnu.org https://lists.gnu.org/mailman/listinfo/classpath-inetlib
inetlib is moving
inetlib is moving into the classpathx project, since it is a direct dependency of classpathx modules and not a direct dependency within classpath itself. Within classpath, we have implementations of the HTTP and FTP URLStreamHandler mechanisms that have code copied from the inetlib sources, but they don't directly refer to any gnu.inet.* classes. If we find any bugs in the FTP or HTTP implementations in classpathx inetlib, I will ensure they are back ported into classpath. I will move the mailing list over to the classpathx project as well: Mark, could you please provide me with the current subscriber list? -- Chris Burdess
Re: inetlib is moving
Andrew wrote: Any plans to also move to git like Classpath itself? We are actually moving to Subversion as I am very familiar with that and it is also preferred by my only other active developer. But I'm open to git at some point in the future if there is interest in doing so. -- Chris Burdess
[commit-cp] inetlib/source/gnu/inet/imap IMAPResponseTokeni...
CVSROOT:/sources/classpath Module name:inetlib Changes by: Chris Burdess dog 13/10/28 10:22:09 Modified files: source/gnu/inet/imap: IMAPResponseTokenizer.java Log message: 2013-10-28 Chris Burdess d...@gnu.org * source/gnu/inet/imap/IMAPResponseTokenizer.java: Fix classpathx bug #22058: IMAPResponseTokenizer consumes one too many LITERAL characters CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/imap/IMAPResponseTokenizer.java?cvsroot=classpathr1=1.7r2=1.8
[commit-cp] inetlib Makefile.am Makefile.in aclocal.m4 conf...
CVSROOT:/sources/classpath Module name:inetlib Changes by: Chris Burdess dog 13/10/27 20:12:32 Modified files: . : Makefile.am Makefile.in aclocal.m4 configure source/gnu/inet/smtp: SMTPConnection.java Added files: source/gnu/inet/smtp: SMTPOutputStream.java Log message: Escape first dot on a line in SMTP client CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/Makefile.am?cvsroot=classpathr1=1.28r2=1.29 http://cvs.savannah.gnu.org/viewcvs/inetlib/Makefile.in?cvsroot=classpathr1=1.33r2=1.34 http://cvs.savannah.gnu.org/viewcvs/inetlib/aclocal.m4?cvsroot=classpathr1=1.20r2=1.21 http://cvs.savannah.gnu.org/viewcvs/inetlib/configure?cvsroot=classpathr1=1.19r2=1.20 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/smtp/SMTPConnection.java?cvsroot=classpathr1=1.24r2=1.25 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/smtp/SMTPOutputStream.java?cvsroot=classpathrev=1.1
Re: [cp-patches] GNU Classpath
Mario Torre wrote: No. Updating the ChangeLog is a requirement. Maybe it's a requirement, but to be honest, is also a very redundant piece of information that is already in the commit log, The commit log is not part of the package. People may want to download the package and see who the contributors were and when; the ChangeLog is a long established convention for them to do this.
Re: [cp-patches] GNU Classpath
Roman Kennke wrote: Am Samstag, den 20.10.2012, 10:03 +0100 schrieb Chris Burdess: Mario Torre wrote: No. Updating the ChangeLog is a requirement. Maybe it's a requirement, but to be honest, is also a very redundant piece of information that is already in the commit log, The commit log is not part of the package. People may want to download the package and see who the contributors were and when; the ChangeLog is a long established convention for them to do this. I don't get it. All of the information of the Changelog is also in the commit history, and if it isn't, it's only a matter of convention to put it there. Then, when doing a release, it should be a matter of a simple script to create a ChangeLog in whatever format is required and put it in the package (I am sure there are existing scripts that accomplish exactly this out there). *All* of it can be automated, and it makes branching, merging, etc much easier, especially in the face of distributed VCSs. I am agnostic on the issue of how the ChangeLog is maintained, only that it should be present and maintained. It is not reasonable to expect a user, having downloaded a GNU package, to have to search around the Web to find the development project resources, download and install configuration management systems with which they may not be familiar, etc etc, simply to see what changes have been made since the last version.
Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...
Andrew Haley wrote: Why are we using yet another VCS, anyway? We can pretty much guarantee that free Java devs are used to Mercural and maybe Subversion, but git? Because nobody spoke up during the review period, so the first suggestion was accepted.
[commit-cp] inetlib ChangeLog source/gnu/inet/http/ByteArra...
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 11/02/23 17:52:40 Modified files: . : ChangeLog source/gnu/inet/http: ByteArrayRequestBodyWriter.java Request.java RequestBodyWriter.java Log message: 2011-02-23 Chris Burdess d...@gnu.org * source/gnu/inet/http/ByteArrayRequestBodyWriter.java, source/gnu/inet/http/Request.java, source/gnu/inet/http/RequestBodyWriter.java: Move to long Content-Length values. Add support for AWS S3 authentication. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.85r2=1.86 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/http/ByteArrayRequestBodyWriter.java?cvsroot=classpathr1=1.4r2=1.5 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/http/Request.java?cvsroot=classpathr1=1.19r2=1.20 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/http/RequestBodyWriter.java?cvsroot=classpathr1=1.4r2=1.5
Re: scope of classpath(x)
Karl Berry wrote: Does classpath(x) aim to include only the standard java.* and javax.* libraries? Or does/can it go beyond that? We (GNU) were just offered a small library that implements the websocket API in a straightforward way, namely websocket4j (http://students.mimuw.edu.pl/~ms262969/maarons/wsgi.py/software/WebSocket4J/ http://students.mimuw.edu.pl/~ms262969/websocket4j-1.3.tar.gz comments welcome). I don't think it is part of any standard library yet. So I'm wondering if it would make sense to incorporate it into classpath(x) or if it's better off as a standalone package, at least for now. Classpath aims to provide the J2SE library API. ClasspathX aims to provide the J2EE library API. These do include some packages beyond those in the java.* and javax.* namespaces, including e.g. org.xml.sax.* and org.w3c.dom.* however it's only the standard APIs we're implementing. We do have a separate network protocols utility package called inetlib, perhaps it would be better contributed to that project? -- Chris Burdess
[commit-cp] inetlib ChangeLog Makefile.in aclocal.m4 configure
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 10/04/19 06:48:32 Modified files: . : ChangeLog Makefile.in aclocal.m4 configure Log message: 2010-04-19 Chris Burdess d...@gnu.org * Makefile.in, aclocal.m4, configure: Rebuilt configure with automake 1.11 and autoconf 2.65. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.84r2=1.85 http://cvs.savannah.gnu.org/viewcvs/inetlib/Makefile.in?cvsroot=classpathr1=1.32r2=1.33 http://cvs.savannah.gnu.org/viewcvs/inetlib/aclocal.m4?cvsroot=classpathr1=1.19r2=1.20 http://cvs.savannah.gnu.org/viewcvs/inetlib/configure?cvsroot=classpathr1=1.18r2=1.19
[commit-cp] inetlib ChangeLog Makefile.am configure.ac
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 10/03/26 07:35:57 Modified files: . : ChangeLog Makefile.am configure.ac Log message: 2010-03-15 Mark Wielaard m...@klomp.org * Makefile.am, configure.ac: Updated make distcheck for newer automake. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.83r2=1.84 http://cvs.savannah.gnu.org/viewcvs/inetlib/Makefile.am?cvsroot=classpathr1=1.27r2=1.28 http://cvs.savannah.gnu.org/viewcvs/inetlib/configure.ac?cvsroot=classpathr1=1.13r2=1.14
Re: [SAXParser] org.xml.sax.SAXParseException: not a name start character: U+26
Andrew Haley wrote:
On 02/13/2010 11:24 AM, Emmanuel Engelhart wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
not sure to be on the right ML to report this behavior, please help me
to find the right place to do it if not... and sorry for the noise.
I use gcj on a LTS Ubuntu:
gcj (Ubuntu 4.4.1-5ubuntu2) 4.4.1
My sample code may be downloaded here as Test.java:
https://bugzilla.wikimedia.org/attachment.cgi?id=7115
and looks like that:
import javax.xml.parsers.SAXParser;
import javax.xml.parsers.SAXParserFactory;
import org.xml.sax.helpers.DefaultHandler;
public class Test {
public static void main(String argv[]) {
try {
SAXParserFactory factory = SAXParserFactory.newInstance();
SAXParser saxParser = factory.newSAXParser();
DefaultHandler handler = new DefaultHandler() {};
saxParser.parse(test.xml, handler);
} catch (Exception e) {
e.printStackTrace();
}
}
}
I compile it like following:
gcj -o test --main=Test Test.java
My XML file test.xml may be downloaded here:
https://bugzilla.wikimedia.org/attachment.cgi?id=7114
By running the the binary I get the following error:
$ ./test
org.xml.sax.SAXParseException: not a name start character: U+26
at gnu.xml.stream.SAXParser.parse(libgcj.so.10)
at javax.xml.parsers.SAXParser.parse(libgcj.so.10)
at javax.xml.parsers.SAXParser.parse(libgcj.so.10)
at Test.main(test)
Caused by: javax.xml.stream.XMLStreamException: not a name start
character: U+26
at gnu.xml.stream.XMLParser.error(libgcj.so.10)
at gnu.xml.stream.XMLParser.readNmtoken(libgcj.so.10)
at gnu.xml.stream.XMLParser.readNmtoken(libgcj.so.10)
at gnu.xml.stream.XMLParser.readCharData(libgcj.so.10)
at gnu.xml.stream.XMLParser.next(libgcj.so.10)
at gnu.xml.stream.SAXParser.parse(libgcj.so.10)
...3 more
Although the XML should be valid.
Has someone an idea to explain this behavior?
This bug impacts the Mediawiki mwdumper SW. T
The related bug (with more details) is available here:
https://bugzilla.wikimedia.org/show_bug.cgi?id=22137
Mmmm, looks like it probably is a real bug. If you remind me next
week I'll have a look.
I reproduced and fixed this bug, see the attached patch. If someone could
validate and commit it for me please do so, I don't have a complete working
build environment at the moment.
--
Chris Burdess
patch
Description: Binary data
___
Classpath mailing list
Classpath@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath
Re: JamVM 1.5.4 released
Robert Lougher wrote: I'm pleased to announce the release of JamVM 1.5.4 (http://jamvm.org). Improvements include faster GC, updated JNI and the usual set of bug-fixes. The full list of changes are here: http://sourceforge.net/projects/jamvm/files/jamvm/JamVM%201.5.4/release_notes/view Happy New Year! Thank you Rob, a very happy New Year to you too. Fantastic work. -- Chris Burdess
Re: [cp-patches] StAX API change for final version
I redid the API changes myself to avoid any assignment issues; this seems to resolve all the original problems with the StAX API. Committed. 2009-07-08 Chris Burdess d...@gnu.org PR xml/40663: * javax/xml/stream/XMLEventFactory.java, * javax/xml/stream/XMLInputFactory.java, * javax/xml/stream/XMLOutputFactory.java, * javax/xml/stream/events/Namespace.java: Update API to match final version of StAX. * javax/xml/stream/util/ReaderDelegate.java: Removed. * javax/xml/stream/util/StreamReaderDelegate.java: Added (renamed from ReaderDelegate) * gnu/xml/stream/FilteredStreamReader.java, * gnu/xml/stream/NamespaceImpl.java, * gnu/xml/stream/XIncludeFilter.java, * gnu/xml/stream/XMLEventAllocatorImpl.java, * gnu/xml/stream/XMLEventFactoryImpl.java: Update implementation to match final version of StAX API. -- Chris Burdess 40663.patch Description: Binary data
[commit-cp] classpath ChangeLog gnu/xml/stream/FilteredStre...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 09/07/08 07:53:30 Modified files: . : ChangeLog gnu/xml/stream : FilteredStreamReader.java NamespaceImpl.java XIncludeFilter.java XMLEventAllocatorImpl.java XMLEventFactoryImpl.java javax/xml/stream: XMLEventFactory.java XMLInputFactory.java XMLOutputFactory.java javax/xml/stream/events: Namespace.java Added files: javax/xml/stream/util: StreamReaderDelegate.java Removed files: javax/xml/stream/util: ReaderDelegate.java Log message: 2009-07-08 Chris Burdess d...@gnu.org PR xml/40663: * javax/xml/stream/XMLEventFactory.java, * javax/xml/stream/XMLInputFactory.java, * javax/xml/stream/XMLOutputFactory.java, * javax/xml/stream/events/Namespace.java: Update API to match final version of StAX. * javax/xml/stream/util/ReaderDelegate.java: Removed. * javax/xml/stream/util/StreamReaderDelegate.java: Added (renamed from ReaderDelegate) * gnu/xml/stream/FilteredStreamReader.java, * gnu/xml/stream/NamespaceImpl.java, * gnu/xml/stream/XIncludeFilter.java, * gnu/xml/stream/XMLEventAllocatorImpl.java, * gnu/xml/stream/XMLEventFactoryImpl.java: Update implementation to match final version of StAX API. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9771r2=1.9772 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/FilteredStreamReader.java?cvsroot=classpathr1=1.1r2=1.2 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/NamespaceImpl.java?cvsroot=classpathr1=1.1r2=1.2 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XIncludeFilter.java?cvsroot=classpathr1=1.10r2=1.11 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLEventAllocatorImpl.java?cvsroot=classpathr1=1.4r2=1.5 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLEventFactoryImpl.java?cvsroot=classpathr1=1.3r2=1.4 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/stream/XMLEventFactory.java?cvsroot=classpathr1=1.6r2=1.7 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/stream/XMLInputFactory.java?cvsroot=classpathr1=1.6r2=1.7 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/stream/XMLOutputFactory.java?cvsroot=classpathr1=1.5r2=1.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/stream/events/Namespace.java?cvsroot=classpathr1=1.1r2=1.2 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/stream/util/StreamReaderDelegate.java?cvsroot=classpathrev=1.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/stream/util/ReaderDelegate.java?cvsroot=classpathr1=1.2r2=0
[cp-patches] Fix for prefix validation in XMLStreamWriter
The attached patch fixes an issue with overenthusiatic validation of prefixes in XMLStreamWriter. 2009-07-07 Ludovic Claude ludovic.cla...@laposte.net PR java/40653 * gnu/xml/stream/XMLStreamWriterImpl.java: Permit empty string as prefix. -- Chris Burdess 40653.patch Description: Binary data
[cp-patches] StAX API change for final version
Our current StAX API is based on an early version. This change brings it in line with the final API implemented in J2SE 6.0. 2009-07-07 Ludovic Claude ludovic.cla...@laposte.net PR java/40663 * javax/xml/stream/util/ReaderDelegate.java: Removed. * javax/xml/stream/util/StreamReaderDelegate.java: Renamed class. -- Chris Burdess StreamReaderDelegate.java Description: Binary data
Re: [cp-patches] StAX API change for final version
Andrew John Hughes wrote: 2009/7/7 Chris Burdess d...@bluezoo.org: Our current StAX API is based on an early version. This change brings it in line with the final API implemented in J2SE 6.0. 2009-07-07 Ludovic Claude ludovic.cla...@laposte.net PR java/40663 * javax/xml/stream/util/ReaderDelegate.java: Removed. * javax/xml/stream/util/StreamReaderDelegate.java: Renamed class. -- Chris Burdess Chris, are you committing these patches? Or waiting for approval? Or do you want someone else to commit them? I'm happy with them, I'm not at a location that I can commit right at the moment, so if someone else could do it earlier then great, if not I will do it as soon as I can (sometime this evening). -- Chris Burdess
Re: [cp-patches] StAX API change for final version
Andrew John Hughes wrote: Chris, are you committing these patches? Or waiting for approval? Or do you want someone else to commit them? I'm happy with them, I'm not at a location that I can commit right at the moment, so if someone else could do it earlier then great, if not I will do it as soon as I can (sometime this evening). Ok, it just wasn't clear from your first posts what you actually wanted to do :) I'm about to commit a bugfix and I'd be happy to commit these afterwards. Great, thank you. -- Chris Burdess
Re: [cp-patches] StAX API change for final version
Andrew John Hughes wrote: On closer inspection, there may be an issue as Ludovic does not have a copyright assignment. Both look more complicated at present than simple renaming. The first issue, #40653, involves only a trivial change (a few one- liners). I'm assuming that this file also needs the patch http://gcc.gnu.org/bugzilla/attachment.cgi?id=18143 which seems to have some changes outside just fixing the class used. I'll look into this. -- Chris Burdess
[commit-cp] inetlib AUTHORS ChangeLog source/gnu/inet/nntp/...
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 09/02/12 08:16:22 Modified files: . : AUTHORS ChangeLog source/gnu/inet/nntp: NNTPConnection.java NNTPConstants.java Log message: 2009-02-12 Jan Michalica jan.michal...@centire.com * source/gnu/inet/nntp/NNTPConnection.java: Support for NNTPS. * source/gnu/inet/nntp/NNTPConstants.java: NNTPS default port number. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/AUTHORS?cvsroot=classpathr1=1.1r2=1.2 http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.80r2=1.81 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/nntp/NNTPConnection.java?cvsroot=classpathr1=1.17r2=1.18 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/nntp/NNTPConstants.java?cvsroot=classpathr1=1.5r2=1.6
Re: gnu.xml.datatype.JAXPDatatypeFactory not there
Andrew John Hughes wrote: 2008/5/13 Robert Schuster [EMAIL PROTECTED]: Hi, javax.xml.datatype.DatatypeFactory declares: public static final String DATATYPEFACTORY_IMPLEMENTATION_CLASS = gnu.xml.datatype.JAXPDatatypeFactory; The value is a fallback value which is treated as a class which is to be instantiated. Unfortunately this class does not exist. Has this class been renamed or has it really not been written yet? The package doesn't seem to exist and I don't recall us having any datatype support. I guess the factory was just added so other factories would be able to operate using GNU Classpath. This package was added to the API fairly recently. We don't have support for it yet although there is a relatively complete datatype implementation in gnu.xml.validation.datatype which could probably be easily adapted to this new API. -- Chris Burdess
Re: [cp-patches] FYI: fix StAX API incompatibility
Robert Schuster wrote: while trying to compile woodstox 2.0.6 on classpath I stumbled across an incompatibility in out StAX API. The attached patch fixes the interface and adjust all implementations within classpath. Regards Robert 2008-03-04 Robert Schuster [EMAIL PROTECTED] * gnu/xml/stream/AttributeImpl.java: Changed type field to String. (getDTDType): Changed return type to String. * gnu/xml/stream/XMLEventAllocatorImpl.java: (allocate): Removed wrapping of string in QName object. * gnu/xml/stream/XMLEventFactoryImpl.java: (createAttribute(String, String)): Removed wrapping of string in QName object. (createAttribute(QName, String)): Dito. (createAttribute(String, String, String, String)): Dito. * javax/xml/stream/events/Attribute.java: (getDTDType): Changed return type to String. Yes - at the time our StAX implementation was developed the spec was subtlely different. It seems it's now stabilised to define the type property as a String as you say. Please commit. -- Chris Burdess pgphJk3pRtxqL.pgp Description: PGP signature
Re: [cp-patches] FYI: More use of CPStringBuilder
Andrew John Hughes wrote: This switches more StringBuilder use to CPStringBuilder. Sorry, why was this necessary again? -- Chris Burdess pgpbdXRJ04BVN.pgp Description: PGP signature
Re: IcedTea - Where is this going to head?
Andrew Haley wrote: From my POV, the first priority is a fully free OpenJDK, running on all the platforms we care about. We have only Classpath code into IcedTea where there are missing parts of OpenJDK. And what platforms /do/ we care about? -- Chris Burdess
[cp-patches] Fix for PR 32539
I committed this patch which allows us to avoid looking ahead in the
event stream while trying to determine whether there is a next event.
2007-07-28 Chris Burdess [EMAIL PROTECTED]
PR 32539
* gnu/xml/stream/XMLParser.java: don't call next() during hasNext().
--
Chris Burdess
? build
? patch
Index: gnu/xml/stream/XMLParser.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/stream/XMLParser.java,v
retrieving revision 1.33
diff -u -r1.33 XMLParser.java
--- gnu/xml/stream/XMLParser.java 4 May 2007 12:18:11 - 1.33
+++ gnu/xml/stream/XMLParser.java 27 Jul 2007 08:49:30 -
@@ -178,11 +178,6 @@
private int event;
/**
- * Whether we are looking ahead. Used by hasNext.
- */
- private boolean lookahead;
-
- /**
* The element name stack. The first element in this stack will be the
* root element.
*/
@@ -1013,24 +1008,12 @@
public boolean hasNext()
throws XMLStreamException
{
-if (event == XMLStreamConstants.END_DOCUMENT)
- return false;
-if (!lookahead)
- {
-next();
-lookahead = true;
- }
-return event != -1;
+return (event != XMLStreamConstants.END_DOCUMENT event != -1);
}
public int next()
throws XMLStreamException
{
-if (lookahead)
- {
-lookahead = false;
-return event;
- }
if (event == XMLStreamConstants.END_ELEMENT)
{
// Pop namespace context
[commit-cp] classpath ChangeLog gnu/xml/stream/XMLParser.java
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/07/28 15:38:14 Modified files: . : ChangeLog gnu/xml/stream : XMLParser.java Log message: 2007-07-28 Chris Burdess [EMAIL PROTECTED] PR 32539 * gnu/xml/stream/XMLParser.java: don't call next() during hasNext(). CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9355r2=1.9356 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLParser.java?cvsroot=classpathr1=1.33r2=1.34
[cp-patches] Fix for DOM node cloning
I committed the attached patch to fix bug #32672:
2007-07-09 Chris Burdess [EMAIL PROTECTED]
Fixes #32672
* gnu/xml/dom/DomElement.java,
* gnu/xml/dom/DomNamedNodeMap.java: don't check owner in
setNamedNode when cloning.
--
Chris Burdess
Index: gnu/xml/dom/DomElement.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/dom/DomElement.java,v
retrieving revision 1.4
diff -u -r1.4 DomElement.java
--- gnu/xml/dom/DomElement.java 12 Jan 2006 16:35:52 - 1.4
+++ gnu/xml/dom/DomElement.java 9 Jul 2007 17:53:40 -
@@ -124,7 +124,7 @@
node.attributes = new DomNamedNodeMap(node, Node.ATTRIBUTE_NODE);
for (DomNode ctx = attributes.first; ctx != null; ctx = ctx.next)
{
-node.attributes.setNamedItemNS(ctx.cloneNode(true));
+node.attributes.setNamedItem(ctx.cloneNode(true), true, true);
}
}
return node;
Index: gnu/xml/dom/DomNamedNodeMap.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/dom/DomNamedNodeMap.java,v
retrieving revision 1.5
diff -u -r1.5 DomNamedNodeMap.java
--- gnu/xml/dom/DomNamedNodeMap.java31 Dec 2005 10:32:14 - 1.5
+++ gnu/xml/dom/DomNamedNodeMap.java9 Jul 2007 17:53:40 -
@@ -148,7 +148,7 @@
*/
public Node setNamedItem(Node arg)
{
-return setNamedItem(arg, false);
+return setNamedItem(arg, false, false);
}
/**
@@ -160,10 +160,10 @@
*/
public Node setNamedItemNS(Node arg)
{
-return setNamedItem(arg, true);
+return setNamedItem(arg, true, false);
}
- Node setNamedItem(Node arg, boolean ns)
+ Node setNamedItem(Node arg, boolean ns, boolean cloning)
{
if (readonly)
{
@@ -171,7 +171,7 @@
}
DomNode node = (DomNode) arg;
-if (node.owner != owner.owner)
+if (!cloning node.owner != owner.owner)
{
throw new DomDOMException(DOMException.WRONG_DOCUMENT_ERR);
}
[commit-cp] classpath ChangeLog gnu/xml/dom/DomElement.java...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/07/09 17:56:31 Modified files: . : ChangeLog gnu/xml/dom: DomElement.java DomNamedNodeMap.java Log message: 2007-07-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/dom/DomElement.java, * gnu/xml/dom/DomNamedNodeMap.java: don't check owner in setNamedNode when cloning. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9349r2=1.9350 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomElement.java?cvsroot=classpathr1=1.4r2=1.5 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomNamedNodeMap.java?cvsroot=classpathr1=1.5r2=1.6
[cp-patches] Small transformer bug fix
This patch, committed, fixes a bug in the XSL transformer where you have a
with-param node with empty content.
2007-07-01 Chris Burdess [EMAIL PROTECTED]
* gnu/xml/transform/WithParam.java: Handle case where content is
empty.
--
Chris Burdess
Index: gnu/xml/transform/WithParam.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/transform/WithParam.java,v
retrieving revision 1.3
diff -u -r1.3 WithParam.java
--- gnu/xml/transform/WithParam.java9 Jul 2005 20:38:35 - 1.3
+++ gnu/xml/transform/WithParam.java1 Jul 2007 11:10:30 -
@@ -81,6 +81,10 @@
{
return select.evaluate(context, pos, len);
}
+else if (content == null)
+ {
+return ;
+ }
else
{
Document doc = (context instanceof Document) ? (Document) context :
Re: [cp-patches] Small transformer bug fix
Christian Thalinger wrote: This patch, committed, fixes a bug in the XSL transformer where you have a with-param node with empty content. 2007-07-01 Chris Burdess [EMAIL PROTECTED] * gnu/xml/transform/WithParam.java: Handle case where content is empty. Hi Chris! This patch is the fix for the HotSpot jvmti problem? Seems so... :-) Yes, let me know if you have any more issues. -- Chris Burdess
Re: NPE in gnu.xml.transform.WithParam.getValue
Christian Thalinger wrote: Hi Chris! I'm sending this directly to you, as you said you don't get these mails. I've tried your test program and, yes, it works. But only with jvmti.xsl, it fails with jvmtiEnter.xsl, though. You should try that one... Thanks for that. A fix is in HEAD. -- Chris Burdess
[commit-cp] classpath ChangeLog gnu/xml/transform/WithParam...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/07/01 11:13:33 Modified files: . : ChangeLog gnu/xml/transform: WithParam.java Log message: 2007-07-01 Chris Burdess [EMAIL PROTECTED] * gnu/xml/transform/WithParam.java: Handle case where content is empty. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9346r2=1.9347 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/WithParam.java?cvsroot=classpathr1=1.3r2=1.4
[cp-patches] DOM node-cloning fix
I committed the following small patch submitted by Robin Garner: 2007-06-01 Robin Garner [EMAIL PROTECTED] Fixes #32162 * gnu/xml/dom/DomNode.java: Correct concurrency problem when deep cloning nodes. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/dom/DomNode.java
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/06/01 09:43:54 Modified files: . : ChangeLog gnu/xml/dom: DomNode.java Log message: 2007-06-01 Robin Garner [EMAIL PROTECTED] Fixes #32162 * gnu/xml/dom/DomNode.java: Correct concurrency problem when deep cloning nodes. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9322r2=1.9323 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomNode.java?cvsroot=classpathr1=1.17r2=1.18
[commit-cp] inetlib ChangeLog Makefile.am Makefile.in acloc...
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 07/06/01 17:03:26 Modified files: . : ChangeLog Makefile.am Makefile.in aclocal.m4 configure source/gnu/inet/ftp: FTPConnection.java source/gnu/inet/http: Request.java source/gnu/inet/imap: IMAPConnection.java source/gnu/inet/nntp: NNTPConnection.java source/gnu/inet/pop3: POP3Connection.java source/gnu/inet/smtp: SMTPConnection.java Added files: source/gnu/inet/util: LaconicFormatter.java Log message: 2006-06-01 Chris Burdess [EMAIL PROTECTED] * source/gnu/inet/http/Request.java: Remove compiler warnings. * source/gnu/inet/ftp/FTPConnection.java, source/gnu/inet/imap/IMAPConnection.java, source/gnu/inet/nntp/NNTPConnection.java, source/gnu/inet/pop3/POP3Connection.java, source/gnu/inet/smtp/SMTPConnection.java: Rework logging. * source/gnu/inet/util/LaconicFormatter.java: New file. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.78r2=1.79 http://cvs.savannah.gnu.org/viewcvs/inetlib/Makefile.am?cvsroot=classpathr1=1.26r2=1.27 http://cvs.savannah.gnu.org/viewcvs/inetlib/Makefile.in?cvsroot=classpathr1=1.31r2=1.32 http://cvs.savannah.gnu.org/viewcvs/inetlib/aclocal.m4?cvsroot=classpathr1=1.18r2=1.19 http://cvs.savannah.gnu.org/viewcvs/inetlib/configure?cvsroot=classpathr1=1.17r2=1.18 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/ftp/FTPConnection.java?cvsroot=classpathr1=1.12r2=1.13 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/http/Request.java?cvsroot=classpathr1=1.18r2=1.19 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/imap/IMAPConnection.java?cvsroot=classpathr1=1.31r2=1.32 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/nntp/NNTPConnection.java?cvsroot=classpathr1=1.16r2=1.17 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/pop3/POP3Connection.java?cvsroot=classpathr1=1.21r2=1.22 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/smtp/SMTPConnection.java?cvsroot=classpathr1=1.23r2=1.24 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/util/LaconicFormatter.java?cvsroot=classpathrev=1.1
[commit-cp] inetlib ChangeLog source/gnu/inet/imap/IMAPConn...
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 07/06/01 17:19:54 Modified files: . : ChangeLog source/gnu/inet/imap: IMAPConnection.java Log message: 2006-06-01 Chris Burdess [EMAIL PROTECTED] * source/gnu/inet/imap/IMAPConnection.java: Quote wildcards. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.79r2=1.80 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/imap/IMAPConnection.java?cvsroot=classpathr1=1.32r2=1.33
[commit-cp] inetlib ChangeLog source/gnu/inet/http/Request....
CVSROOT:/cvsroot/classpath Module name:inetlib Changes by: Chris Burdess dog 07/05/30 07:47:51 Modified files: . : ChangeLog source/gnu/inet/http: Request.java source/gnu/inet/imap: IMAPConnection.java Log message: 2006-05-30 Chris Burdess [EMAIL PROTECTED] * source/gnu/inet/http/Request.java: Don't send Expect header for HTTP/1.0 requests. * source/gnu/inet/imap/IMAPConnection.java: Allow public access to utility method. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/inetlib/ChangeLog?cvsroot=classpathr1=1.77r2=1.78 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/http/Request.java?cvsroot=classpathr1=1.17r2=1.18 http://cvs.savannah.gnu.org/viewcvs/inetlib/source/gnu/inet/imap/IMAPConnection.java?cvsroot=classpathr1=1.30r2=1.31
Re: [cp-patches] RFC: Options to javac
Mario Torre wrote: On #classpath a user reported that he had to pass these switch to build the last classpath with javac. I think it can be a good idea to use them by default. What do you think? Will the switches just be ignored by 1.4 and earlier versions of javac, or will they cause an error? Is there configury in any case to check the version of the JDK being used?
[cp-patches] XML DOM bug fix
This patch (committed) fixes a problem whereby attributes were defaulted when they shouldn't have been. 2007-05-04 Chris Burdess [EMAIL PROTECTED] Fixes PR #31814 * gnu/xml/dom/DomDocument.java, gnu/xml/dom/ls/SAXEventSink.java: Don't default attribute when mode is #IMPLIED and value is not specified. * gnu/xml/stream/XMLParser.java: Add debugging info. patch Description: Binary data
[commit-cp] classpath ChangeLog gnu/xml/dom/DomDocument.jav...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/05/04 12:18:11 Modified files: . : ChangeLog gnu/xml/dom: DomDocument.java gnu/xml/dom/ls : SAXEventSink.java gnu/xml/stream : XMLParser.java Log message: 2007-05-04 Chris Burdess [EMAIL PROTECTED] Fixes PR #31814 * gnu/xml/dom/DomDocument.java, gnu/xml/dom/ls/SAXEventSink.java: Don't default attribute when mode is #IMPLIED and value is not specified. * gnu/xml/stream/XMLParser.java: Add debugging info. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9294r2=1.9295 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomDocument.java?cvsroot=classpathr1=1.12r2=1.13 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/ls/SAXEventSink.java?cvsroot=classpathr1=1.9r2=1.10 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLParser.java?cvsroot=classpathr1=1.32r2=1.33
Re: [cp-patches] Little XML patch
Christian Thalinger wrote: On Mon, 2007-04-09 at 21:11 +0200, Christian Thalinger wrote: On Mon, 2007-04-09 at 19:17 +0200, Christian Thalinger wrote: Ok, here we go: input.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/template- document.xml ids.systemId=jbb-document.dtd url=jbb-document.dtd This is the output before Chris' patch: input.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/template- document.xml ids.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/jbb- document.dtd url=file:/home/twisti/cacao/spec/jbb2005/xml/jbb-document.dtd Ok, finally I was able to build a testcase. I've found the problem. java.io.File.toURL() is returning an invalid URL in DomLSParser.getInputSource. I'm sure we've been over this a hundred times or more but maybe it's time to revisit this yet again. Here is an example of a URL returned in my local testcase: file:/home/dog/test/twisti-xml/xml/test.xml According to RFC 1738: A file URL takes the form file://host/path where host is the fully qualified domain name of the system on which the path is accessible, and path is a hierarchical directory path of the form directory/directory/.../name. ... As a special case, host can be the string localhost or the empty string; this is interpreted as `the machine from which the URL is being interpreted'. Therefore File.toURL should be returning a URL of the form file:///home/dog/test/twisti-xml/xml/test.xml Let the flamewar commence... PGP.sig Description: This is a digitally signed message part
[cp-patches] Workaround for XML file URL problem
Provides a workaround for the File.toURL problem and handles any such incorrectly formatted URLs in XML external entity references. 2007-04-16 Chris Burdess [EMAIL PROTECTED] * gnu/xml/stream/XMLParser.java: Work around a problem with incorrectly formatted file URLs. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/stream/XMLParser.java
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/04/16 10:33:51 Modified files: . : ChangeLog gnu/xml/stream : XMLParser.java Log message: 2007-04-16 Chris Burdess [EMAIL PROTECTED] * gnu/xml/stream/XMLParser.java: Work around a problem with incorrectly formatted file URLs. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9252r2=1.9253 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLParser.java?cvsroot=classpathr1=1.31r2=1.32
Re: [cp-patches] Patch: FYI: hard-code SAX fallback
Tom Tromey wrote: I think for proper operation we have to remove the various XML service files from META-INF; see the earlier thread. But in order for this to work we also have to fix SAX to properly fall back to the Classpath SAX parser. This patch does this. It is a divergence from upstream, but in a place clearly marked -- both by us and by the SAX maintainers. Let me know what you think. I tried various combinations against the Sun JDK and I think this combination (removing service files and adding this patch) provides best compatibility. I agree that this seems the most sensible place. PGP.sig Description: This is a digitally signed message part
Re: [cp-patches] FYI: Another javax.xml bugfix (PR 30983)
Gary Benson wrote: This commit fixes a bug where the entity resolver (if set) would be used to open the top-level document when parsing an XML file. The spec states that the parser will use the entity resolver before opening any external entity _except_ the top-level document entity. I'm not sure which spec says that. The EntityResolver class documentation says: The application can also use this interface to redirect system identifiers to local URIs or to look up replacements in a catalog (possibly by using the public identifier). Since the application is using the system ID to resolve the top-level document entity (either from LSInput.systemId or LSParser.parseURI (uri), which is equivalent), the spec would suggest that the entity resolver, if set, should be used to resolve the top-level entity. However, it seems expedient to ignore this for the purpose of code compatibility with other implementations. PGP.sig Description: This is a digitally signed message part
Re: Bug in gnu/xml/dom/DomDocumentBuilderFactory.java?
Andrew Haley wrote: The problem: gcj+Classpath fails to work with Xerces2, but Sun's Java does work. The means that, on Fedora, Ant doesn't run with the latest Classpath. gnu/xml/dom/DomDocumentBuilderFactory.java.newDocumentBuilder() does this: setParameter(config, expand-entity-references, isExpandEntityReferences() ? Boolean.TRUE : Boolean.FALSE); but according to the specification of org.w3c.dom.DOMConfiguration, expand-entity-references is not a parameter defined in the DOM. It seems to be local to gnu.xml.dom.ls.DomLSParser. [ http://java.sun.com/j2se/1.5.0/docs/api/org/w3c/dom/ DOMConfiguration.html ] This is all well and good with gnu.xml.dom.ls.DomLSParser, but if we have Xerces2 installed in our path then we will fail, because Xerces2 does not support expand-entity-references. Is it the case that gnu.xml.dom.DomDocumentBuilderFactory.newDocumentBuilder is totally incompatible with Xerces2? Please could you file this in Bugzilla and assign it to me, I can see the problem and I'll come up with a workaround. PGP.sig Description: This is a digitally signed message part
Build problem
I have a problem building Classpath HEAD: configured with: ../configure --with-ecj --prefix=/gnu --disable- plugin --disable-gtk-peer --disable-qt-peer --disable-gconf-peer -- enable-gjdoc platform: powerpc-apple-darwin8.8.0 make install results in: ... echo timestamp gjarsigner.1 (pod2man --center=GNU --release=0.94-pre --section=1 gjarsigner.pod gjarsigner.1.T$$ \ mv -f gjarsigner.1.T$$ gjarsigner.1) || \ (rm -f gjarsigner.1.T$$ exit 1) perl ../../doc/texi2pod.pl -D gjavah ../../doc/cp-tools.texinfo gjavah.pod echo timestamp gjavah.1 (pod2man --center=GNU --release=0.94-pre --section=1 gjavah.pod gjavah.1.T$$ \ mv -f gjavah.1.T$$ gjavah.1) || \ (rm -f gjavah.1.T$$ exit 1) perl ../../doc/texi2pod.pl -D gkeytool ../../doc/cp-tools.texinfo gkeytool.pod sed -i -e 's/^For more details.*/See ICommon Options for more details./' \ -e 's/1\.\([^]*\)/- \1/' \ gkeytool.pod sed: lstat: No such file or directory make[2]: *** [gkeytool.pod] Error 1 rm gjar.pod gappletviewer.pod gkeytool.pod gjavah.pod gjarsigner.pod make[1]: *** [install-recursive] Error 1 make: *** [install-recursive] Error 1 Any ideas? PGP.sig Description: This is a digitally signed message part
[cp-patches] Fix for SAX TransformerHandler behaviour
I committed this patch to fix an NPE when using the SAX TransformerHandler behaviour. 2007-02-19 Chris Burdess [EMAIL PROTECTED] Fixes #30831 * gnu/xml/dom/ls/SAXEventSink.java: Only set extended document properties when reader is available. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/dom/ls/SAXEventSink...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/02/19 09:27:44 Modified files: . : ChangeLog gnu/xml/dom/ls : SAXEventSink.java Log message: 2007-02-19 Chris Burdess [EMAIL PROTECTED] Fixes #30831 * gnu/xml/dom/ls/SAXEventSink.java: Only set extended document properties when reader is available. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9118r2=1.9119 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/ls/SAXEventSink.java?cvsroot=classpathr1=1.8r2=1.9
[commit-cp] classpath ChangeLog gnu/xml/dom/DomDocumentBuil...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/02/06 10:10:44 Modified files: . : ChangeLog gnu/xml/dom: DomDocumentBuilderFactory.java gnu/xml/stream : XIncludeFilter.java XMLParser.java Log message: 2007-02-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 27710. * gnu/xml/dom/DomDocumentBuilderFactory.java: Fall back to synchronous LSParser if implementation does not support asynchronous. * gnu/xml/stream/XMLParser.java, gnu/xml/stream/XIncludeFilter.java: Use custom code instead of java.net.URL to resolve to an an absolute URI, to avoid nonexistent protocol handler problems. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9088r2=1.9089 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomDocumentBuilderFactory.java?cvsroot=classpathr1=1.3r2=1.4 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XIncludeFilter.java?cvsroot=classpathr1=1.7r2=1.8 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLParser.java?cvsroot=classpathr1=1.30r2=1.31
[cp-patches] XML bug fixes
I committed the following patch to fix Bugzilla ticket 30597. 2007-01-26 Chris Burdess [EMAIL PROTECTED] Fixes #30597 * gnu/xml/dom/DomDocumentBuilder.java: Throw IOException where cause of LSException is an IOException. * gnu/xml/dom/ls/DomLSParser.java, gnu/xml/stream/SAXParser.java: Ensure coalescing feature is set correctly during LS parsing. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/dom/DomDocumentBuil...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 07/01/26 19:57:43 Modified files: . : ChangeLog gnu/xml/dom: DomDocumentBuilder.java gnu/xml/dom/ls : DomLSParser.java gnu/xml/stream : SAXParser.java Log message: 2007-01-26 Chris Burdess [EMAIL PROTECTED] Fixes #30597 * gnu/xml/dom/DomDocumentBuilder.java: Throw IOException where cause of LSException is an IOException. * gnu/xml/dom/ls/DomLSParser.java, gnu/xml/stream/SAXParser.java: Ensure coalescing feature is set correctly during LS parsing. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9074r2=1.9075 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomDocumentBuilder.java?cvsroot=classpathr1=1.5r2=1.6 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/ls/DomLSParser.java?cvsroot=classpathr1=1.4r2=1.5 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/SAXParser.java?cvsroot=classpathr1=1.23r2=1.24
[cp-patches] PATCH: Fix schema factory discovery
This patch (committed) implements the algorithm for schema factory implementation discovery. 2006-12-056 Chris Burdess [EMAIL PROTECTED] Fixes PR 28816. * javax/xml/validation/SchemaFactory.java: Use correct algorithm to discover schema factory implementation class. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[cp-patches] PATCH: fix for XMLStreamWriter.writeDTD
This patch corrects a misunderstanding about XMLStreamWriter.writeDTD. 2006-12-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 29264. * gnu/xml/stream/XMLStreamWriterImpl.java: Allow arbitrary text in writeDTD method. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[cp-patches] PATCH: trivial fixes in XML classes
This patch - corrects Javadoc formatting in DocumentBuilderFactory - plugs a file descriptor leak in the main method of SAXParser (only used for testing) 2006-12-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 29272. * javax/xml/parsers/DocumentBuilderFactory.java: Fix broken Javadoc. * gnu/xml/stream/SAXParser.java: Fix file descriptor leak. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[cp-patches] PATCH: DOM event propagation fix
I'm committing this minor patch from Ben Konrath which appears to resolve some NPE problems in Eclipse. Mark, this is not marked critical in Bugzilla so I don't believe it is release critical. 2006-12-06 Ben Konrath [EMAIL PROTECTED] Fixes PR 29853. * gnu/xml/dom/DomAttr.java: Don't report mutation if oldValue and newValue are the same. * gnu/xml/dom/DomNode.java: Set parent if null during mutation. patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog javax/xml/validation/Schema...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/12/06 11:14:24 Modified files: . : ChangeLog javax/xml/validation: SchemaFactory.java Log message: 2006-12-056 Chris Burdess [EMAIL PROTECTED] Fixes PR 28816. * javax/xml/validation/SchemaFactory.java: Use correct algorithm to discover schema factory implementation class. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8926r2=1.8927 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/validation/SchemaFactory.java?cvsroot=classpathr1=1.5r2=1.6
[commit-cp] classpath gnu/xml/stream/XMLStreamWriterImpl.ja...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/12/06 11:23:41 Modified files: gnu/xml/stream : XMLStreamWriterImpl.java . : ChangeLog Log message: 2006-12-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 29264. * gnu/xml/stream/XMLStreamWriterImpl.java: Allow arbitrary text in writeDTD method. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLStreamWriterImpl.java?cvsroot=classpathr1=1.5r2=1.6 http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8927r2=1.8928
[commit-cp] classpath ChangeLog gnu/xml/stream/SAXParser.ja...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/12/06 11:36:42 Modified files: . : ChangeLog gnu/xml/stream : SAXParser.java javax/xml/parsers: DocumentBuilderFactory.java Log message: 2006-12-06 Chris Burdess [EMAIL PROTECTED] Fixes PR 29272. * javax/xml/parsers/DocumentBuilderFactory.java: Fix broken Javadoc. * gnu/xml/stream/SAXParser.java: Fix file descriptor leak. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8928r2=1.8929 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/SAXParser.java?cvsroot=classpathr1=1.21r2=1.22 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/xml/parsers/DocumentBuilderFactory.java?cvsroot=classpathr1=1.5r2=1.6
[commit-cp] classpath/gnu/xml/stream SAXParser.java
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/12/06 12:02:11 Modified files: gnu/xml/stream : SAXParser.java Log message: Fixed typo in previous commit (same ChangeLog entry). CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/SAXParser.java?cvsroot=classpathr1=1.22r2=1.23
[commit-cp] classpath ChangeLog gnu/xml/dom/DomAttr.java gn...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/12/06 18:38:06 Modified files: . : ChangeLog gnu/xml/dom: DomAttr.java DomNode.java Log message: 2006-12-06 Ben Konrath [EMAIL PROTECTED] Fixes PR 29853. * gnu/xml/dom/DomAttr.java: Don't report mutation if oldValue and newValue are the same. * gnu/xml/dom/DomNode.java: Set parent if null during mutation. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8931r2=1.8932 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomAttr.java?cvsroot=classpathr1=1.3r2=1.4 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomNode.java?cvsroot=classpathr1=1.16r2=1.17
Re: [cp-patches] QName
Jeroen Frijters wrote: I'd like some feedback on a change I'd like to make to a small part of the JAXP implementation. [...] Note that this is contentious, because Sun's QName *doesn't do any validation* of its input. However, I still think it's the right thing to do, and I'm not alone: The Sun docs explicitly say that they don't validate: The Namespace URI is not validated as a URI reference. The local part is not validated as a NCName as specified in Namespaces in XML. Ah? That must be a recent amendment, I certainly don't recall it in the original JAXP spec. Probably they felt they had to make this explicit *after* receiving a lot of negative feedback about its behaviour. Well, if the API spec itself is broken, laisse tomber. Besides, I don't see how you can validate an anyURI, since it can be absolute or relative. According to the XML namespaces spec http://www.w3.org/TR/xml-names/#iri-use http://www.w3.org/2000/09/xppa you cannot use relative URIs in XML namespace references. -- Chris Burdess
[cp-patches] QName
I'd like some feedback on a change I'd like to make to a small part of the JAXP implementation. The API in question is the javax.xml.namespace.QName class, which is a common cause of developer error as its constructor uses plain Strings and you have to remember which order the arguments go in: QName(String namespaceUri, String localPart) but QName(String localPart) seems to confuse people a lot, and you often find something like new QName(foo, http://bar.com/my/namespace;) or worse, the arguments are variable names new QName(el, un) - difficult to spot and debug. The attached patch does some simple validation to ensure the consistency of its arguments at runtime. It should help to tie down exactly where a bogus QName is constructed, even if it doesn't catch every possible case. Note that it doesn't do exhaustive testing of the localPart or prefix arguments as the exact criteria depend on the version of XML the author intends. Note that this is contentious, because Sun's QName *doesn't do any validation* of its input. However, I still think it's the right thing to do, and I'm not alone: http://cafe.elharo.com/java/why-methods-should-check-their-arguments/ Anyway, see below for the patch. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
Re: [cp-patches] Re: FYI: CSS border support
Stuart Ballard wrote: Here's a can of worms: Do we actually *want* to be better than Sun's implementation, featurewise? For the same reason that we as Free runtime users and developers hate it when people write code which (inadvertently or not) relies on features that are only in Sun's implementation (eg the undocumented sun.* bits that Free runtimes have no intention to duplicate), IMO it's not such a good idea to end up in a situation where people might inadvertently rely on features that only Classpath provides, making their code not portable to other implementations. It's one thing if we put extra stuff into Classpath-specific packages so that people will need to make a conscious choice to use it. But adding CSS support that will silently fail to work on Sun's implementation seems dangerous. What do others think? Implement the CSS spec, not Sun's implementation. -- Chris Burdess
[cp-patches] Small fix for an issue in transformer source resolution from a SAX source
This small patch (committed) fixes a problem that could cause an avoidable exception when trying to resolve a SAX source. 2006-09-18 David Pirkle [EMAIL PROTECTED] Fixes PR 28589 * gnu/xml/transform/XSLURIResolver.java: Test SAXSource for specific input stream during resolution. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/transform/XSLURIRes...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/09/18 17:50:07 Modified files: . : ChangeLog gnu/xml/transform: XSLURIResolver.java Log message: 2006-09-18 David Pirkle [EMAIL PROTECTED] Fixes PR 28589 * gnu/xml/transform/XSLURIResolver.java: Test SAXSource for specific input stream during resolution. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8560r2=1.8561 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/XSLURIResolver.java?cvsroot=classpathr1=1.4r2=1.5
[cp-patches] Implement SAXTransformerFactory
This patch (committed) implements javax.xml.transform.sax.SAXTransformerFactory. This JAXP API is flawed by design, since XSL is defined by specification to operate on XML infosets (in-memory trees), *not* event streams or partial documents. Therefore until now the GNU TransformerFactory implementation has not implemented this interface nor advertised such conformance. However, there is existing code out there that casts the TransformerFactory blindly to a SAXTransformerFactory without checking whether it advertises conformance (getFeature (SAXTransformerFactory.FEATURE)). While such code is not guaranteed to work on a conformant Java implementation it does work on Sun's and until now would fail on Classpath. This patch implements SAXTransformerFactory by providing an implementation that will buffer all SAX events into an in-memory tree and then use this tree as the basis of existing transformer operations, and will make such aforementioned code work on Classpath providing that they do not attempt transformer operations during the actual parsing. 2006-09-17 Chris Burdess [EMAIL PROTECTED] Fixes PR 27610 27687. * gnu/xml/dom/ls/SAXEventSink.java: Permit limited subclassing. * gnu/xml/transform/SAXTemplatesHandler.java, * gnu/xml/transform/SAXTransformerHandler.java: New files. * gnu/xml/transform/TransformerFactoryImpl.java: Implement SAXTransformerFactory. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/dom/ls/SAXEventSink...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/09/17 09:54:34 Modified files: . : ChangeLog gnu/xml/dom/ls : SAXEventSink.java gnu/xml/transform: TransformerFactoryImpl.java Added files: gnu/xml/transform: SAXTemplatesHandler.java SAXTransformerHandler.java Log message: 2006-09-17 Chris Burdess [EMAIL PROTECTED] Fixes PR 27610 27687. * gnu/xml/dom/ls/SAXEventSink.java: Permit limited subclassing. * gnu/xml/transform/SAXTemplatesHandler.java, * gnu/xml/transform/SAXTransformerHandler.java: New files. * gnu/xml/transform/TransformerFactoryImpl.java: Implement SAXTransformerFactory. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8551r2=1.8552 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/ls/SAXEventSink.java?cvsroot=classpathr1=1.6r2=1.7 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/TransformerFactoryImpl.java?cvsroot=classpathr1=1.3r2=1.4 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/SAXTemplatesHandler.java?cvsroot=classpathrev=1.1 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/SAXTransformerHandler.java?cvsroot=classpathrev=1.1
[cp-patches] Fix for bug in stream serialisation
This path (committed) fixes a bug whereby XML entities were being escaped while in text output mode. 2006-09-16 Chris Burdess [EMAIL PROTECTED] Fixes PR 28572. * gnu/xml/transform/StreamSerializer.java: Don't escape XML entities when in text output mode. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[cp-patches] Fix for DOM node length
This patch (committed) fixes a bug which messed up NodeLists after a child node insertion. 2006-09-16 Chris Burdess [EMAIL PROTECTED] Fixes PR 27293. * gnu/xml/dom/DomNode.java: Increment length of node during insert. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
Debian dependencies for Classpath package
I'm building Classpath on a virgin Debian system and I was quite surprised at some of the package dependencies for the classpath package. Beyond the dependencies listed in the documentation, plus libx11-dev, libgtk2.0-dev, jikes, and their dependencies, we have: antlr build-essential cdbs comerr-dev debhelper dpatch dssi-dev gettext gjdoc html2text intltool-debian ladspa-sdk libart-2.0-dev libasound2-dev libaudio-dev libgl1-mesa-dev libgl1-mesa-dri libglu1-mesa-dev libglu1-xorg-dev libjack0.100.0-dev libjpeg62-dev libkadm55 libkrb5-dev liblcms1-dev libmng-dev libmysqlclient15off libpq-dev libqt4-dev libqt4-qt3support libqt4-sql libsqlite0 libssl-dev libxmu-dev libxmu-headers libxt-dev libxtst-dev mesa-common-dev mysql-common po-debconf x11proto-record-dev xlibmesa-gl-dev zip libgconf2-dev libidl-dev liborbit2-dev libpopt-dev orbit2 I'm especially surprised about the mysql dependency. Is all this really necessary? -- Chris Burdess
[cp-patches] XPath fix
As there appears to be no opposition to this patch I have committed it. 2006-09-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/xpath/Expr.java: Ensure that node-set evaluation returns an instance of org.w3c.dom.NodeList. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/xpath/Expr.java
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Chris Burdess dog 06/09/09 12:12:48 Modified files: . : ChangeLog gnu/xml/xpath : Expr.java Log message: 2006-09-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/xpath/Expr.java: Ensure that node-set evaluation returns an instance of org.w3c.dom.NodeList. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8519r2=1.8520 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/xpath/Expr.java?cvsroot=classpathr1=1.5r2=1.6
Re: A question @Mark Wilaard (and other developer)
theUser BL wrote: And in which part is the GNU Classpath implementation better then Suns implementation? (from the technical point of view, not from the license side) ? You might like to look at http://builder.classpath.org/xml/SAXTest/ which shows the XML SAX API conformance status of the GNU implementation versus Xerces (the parser redistributed by Sun). Until today GNU Classpath makes sence, because it is an OpenSource Java-implementation and Suns Java isn't OpenSource. And it is not only a Java-implementation it is in parts a rewrite of Suns Java. As i know, there is nowhere defined in any book how the ocean-theme looks like. Only the old metal theme is defined at http://java.sun.com/products/jlf/ So in parts GNU Classpath is not only a implementation of what the JCP defines, its a rewrite of that, what Suns have done. Yes. This vexes me greatly, when there is pressure from the community to reproduce a bug-for-bug compatible class library, i.e. that we should try to code to match Sun's implementation instead of coding a good, bug-free implementation of the specification. But, as you point out, in many cases the specification is vague or nonexistent, and people just want it to work and don't care about specs. But until Sun makes its Java implementation OpenSource, then the situation is different. No, I don't think so. So I think, that - if Sun makes its Java OpenSource - it would be a bad thing, if then GNU Classpath and Apache Harmony still exists. So, given that NetBSD exists, is it a bad thing that Linux and OpenSolaris and the Hurd exist? After all it was around long before these upstarts. Surely we should all be working on the One True Operating System™? -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
[cp-patches] Re: XPath test still not commited?
On 25 Aug 2006, at 13:23, Mario Torre wrote: Il giorno ven, 25/08/2006 alle 13.01 +0100, Chris Burdess ha scritto: Mark Wielaard wrote: The XPath test i submitted on August 16 has still not been committed. As this was my first submission to this list, It's quite possible I did something wrong. Can anyone let me know what the status is? Sorry, I was hoping Chris could take a look. But I forgot he was on vacation. Chris, if you are back, could you take a look at: http://sourceware.org/ml/mauve-patches/2006/msg00614.html I don't know much about Mauve, but the JAXP part looks correct. Hi! The mauve part is ok (but the test still fails). Please evaluate the following patch. Sorry for the delay. 2006-09-04 Chris Burdess [EMAIL PROTECTED] * gnu/xml/xpath/Expr.java: Ensure that node-set evaluation returns an instance of org.w3c.dom.NodeList. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
Re: inetlib
Per Bothner wrote: http://www.gnu.org/software/classpath/inetlib.html talks about inetlib. However, I don't see any links to download the code, nor any detailed (api or tutorial) documentation. The left sidebar has a Download link, but that only has links for downloading Classpath proper. It can be downloaded from http://ftp.gnu.org/pub/gnu/classpath/ I agree that there should be a link to the source and to generated API documentation. Mark, do you have any feelings about how we should realise this? -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
Re: JavaView runs with GNU Classpath
theUser BL wrote: If Show Backside is enabled, the backside isn't shown, and if it is disabled with GNU Classpath the backside is shown. FYI http://www.m-w.com/dictionary/backside -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
[cp-patches] XML streams debugging and partial workaround for #27664
I committed this patch which adds support for debugging XML streams via a system property (other suggestions welcomed) and also provides a workaround for a mark/reset problem somewhere in BufferedReader or CRLFReader by not reading more characters than are necessary in XMLParser.tryRead. 2006-06-07 Chris Burdess [EMAIL PROTECTED] * gnu/classpath/debug/TeeInputStream.java, gnu/classpath/debug/TeeOutputStream.java, gnu/classpath/debug/TeeReader.java, gnu/classpath/debug/TeeWriter.java: New classes for debugging streams. * gnu/xml/stream/XMLParser.java: Use tee streams for debugging. Don't read more characters than absolutely necessary in tryRead method. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
Re: [cp-patches] RFC: fix for PR27864
Robert Schuster wrote: unfortunately the fix you proposed yesterday on IRC did not work. I have further investigate the problem to find out about your consideration about an NPE happening because of my patch: I found out that if root is null, the code will not reach that code location because then 'here' would be null too and this is handled in line 243. OK. I'm not actually all that familiar with DomIterator. If you're happy that your patch is generally applicable I have no problem with it. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
Fwd: [cp-patches] More useful command-line options for XML parsers
I thought this might be of general interest to Classpath users: Begin forwarded message: I committed this patch to add options to the command-line versions of the SAX and StAX XML parsers that allow you to set several configuration parameters, as well as syntax help on these options. It is primarily for debugging. There is also a minor tweak in reporting errors in the transformer. 2006-06-07 Chris Burdess [EMAIL PROTECTED] * gnu/xml/stream/SAXParser.java, gnu/xml/stream/XMLParser.java: Add command line options for setting parsing parameters (for simpler debugging). * gnu/xml/transform/TransformerImpl.java: Try to ensure that I/ O error closing output stream is propagated to application. I know that a few people have been having problems debugging XML usage in their applications, so if you didn't know already you can invoke both the SAX and the StAX parser from the command line with e.g. jamvm gnu.xml.stream.SAXParser -v -n -c org.me.MyContentHandler .../file-to-test.xml This allows you to test Classpath's parsing of individual XML files, optionally using your own SAX callback handlers. I discussed some issues of trying to debug XML parsing embedded in 3rd party applications (where you typically don't have access to the XML input the application tries to parse) with twisti on IRC. I suggested that using a tee input stream or reader in those circumstances would be a good idea, to tee the XML input being received into a file (or perhaps directory of files?). If other people think this would be useful, we could perhaps include a TeeInputStream and TeeReader (and possible output streams and writers) in Classpath that could be installed via a system property or some other such mechanism. I'd appreciate any thoughts on this. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/stream/SAXParser.ja...
CVSROOT:/cvsroot/classpath
Module name:classpath
Changes by: Chris Burdess dog 06/06/07 08:04:49
Modified files:
. : ChangeLog
gnu/xml/stream : SAXParser.java XMLParser.java
gnu/xml/transform: TransformerImpl.java
Log message:
2006-06-07 Chris Burdess [EMAIL PROTECTED]
* gnu/xml/stream/SAXParser.java,
gnu/xml/stream/XMLParser.java: Add command line options for
setting
parsing parameters (for simpler debugging).
* gnu/xml/transform/TransformerImpl.java: Try to ensure that
I/O error
closing output stream is propagated to application.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.7690r2=1.7691
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/SAXParser.java?cvsroot=classpathr1=1.20r2=1.21
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLParser.java?cvsroot=classpathr1=1.28r2=1.29
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/TransformerImpl.java?cvsroot=classpathr1=1.14r2=1.15
Patches:
Index: ChangeLog
===
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.7690
retrieving revision 1.7691
diff -u -b -r1.7690 -r1.7691
--- ChangeLog 6 Jun 2006 22:39:49 - 1.7690
+++ ChangeLog 7 Jun 2006 08:04:48 - 1.7691
@@ -1,3 +1,11 @@
+2006-06-07 Chris Burdess [EMAIL PROTECTED]
+
+ * gnu/xml/stream/SAXParser.java,
+ gnu/xml/stream/XMLParser.java: Add command line options for setting
+ parsing parameters (for simpler debugging).
+ * gnu/xml/transform/TransformerImpl.java: Try to ensure that I/O error
+ closing output stream is propagated to application.
+
2006-06-06 Mark Wielaard [EMAIL PROTECTED]
* include/jni.h (JDK1_1InitArgs): Mark pointer-to-function types
Index: gnu/xml/stream/SAXParser.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/stream/SAXParser.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -b -r1.20 -r1.21
--- gnu/xml/stream/SAXParser.java 4 Mar 2006 20:45:32 - 1.20
+++ gnu/xml/stream/SAXParser.java 7 Jun 2006 08:04:49 - 1.21
@@ -976,10 +976,56 @@
public static void main(String[] args)
throws Exception
{
-SAXParser parser = new SAXParser();
-InputSource input = new InputSource(args[0]);
-parser.parse(input, new org.xml.sax.helpers.DefaultHandler());
-
+boolean validating = false;
+boolean namespaceAware = false;
+boolean xIncludeAware = false;
+boolean expectCallbackClass = false;
+String callbackClass = null;
+int pos = 0;
+while (pos args.length (args[pos].startsWith(-) ||
expectCallbackClass))
+ {
+if (-x.equals(args[pos]))
+ xIncludeAware = true;
+else if (-v.equals(args[pos]))
+ validating = true;
+else if (-n.equals(args[pos]))
+ namespaceAware = true;
+else if (-c.equals(args[pos]))
+ expectCallbackClass = true;
+else if (expectCallbackClass)
+ {
+callbackClass = args[pos];
+expectCallbackClass = false;
+ }
+pos++;
+ }
+if (pos = args.length || expectCallbackClass)
+ {
+System.out.println(Syntax: SAXParser [-n] [-v] [-x] [-c class]
file [file2 [...]]);
+System.out.println(\t-n: use namespace aware mode);
+System.out.println(\t-v: use validating parser);
+System.out.println(\t-x: use XInclude aware mode);
+System.out.println(\t-c class: use specified class as callback
handler (must have a no-arg public constructor));
+System.exit(2);
+ }
+while (pos args.length)
+ {
+ContentHandler handler = null;
+if (callbackClass != null)
+ {
+Class t = Class.forName(callbackClass);
+handler = (ContentHandler) t.newInstance();
+ }
+else
+ handler = new org.xml.sax.helpers.DefaultHandler();
+SAXParser parser = new SAXParser(validating, namespaceAware,
+ xIncludeAware);
+InputSource input = new InputSource(args[pos]);
+XMLReader reader = parser.getXMLReader();
+reader.setContentHandler(handler);
+reader.parse(input);
+pos++;
+ }
}
}
Index: gnu/xml/stream/XMLParser.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/stream/XMLParser.java,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -b -r1.28 -r1.29
--- gnu/xml/stream/XMLParser.java 20 Mar 2006 19:54:35 - 1.28
+++ gnu/xml/stream/XMLParser.java 7 Jun 2006 08:04:49 - 1.29
@@ -4250,13 +4250,34
[commit-cp] classpath ChangeLog gnu/xml/stream/XMLParser.ja...
CVSROOT:/cvsroot/classpath
Module name:classpath
Changes by: Chris Burdess dog 06/06/07 13:06:11
Modified files:
. : ChangeLog
gnu/xml/stream : XMLParser.java
Added files:
gnu/classpath/debug: TeeInputStream.java TeeOutputStream.java
TeeReader.java TeeWriter.java
Log message:
2006-06-07 Chris Burdess [EMAIL PROTECTED]
* gnu/classpath/debug/TeeInputStream.java,
gnu/classpath/debug/TeeOutputStream.java,
gnu/classpath/debug/TeeReader.java,
gnu/classpath/debug/TeeWriter.java: New classes for debugging
streams.
* gnu/xml/stream/XMLParser.java: Use tee streams for debugging.
Don't
read more characters than absolutely necessary in tryRead
method.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.7693r2=1.7694
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/classpath/debug/TeeInputStream.java?cvsroot=classpathrev=1.1
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/classpath/debug/TeeOutputStream.java?cvsroot=classpathrev=1.1
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/classpath/debug/TeeReader.java?cvsroot=classpathrev=1.1
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/classpath/debug/TeeWriter.java?cvsroot=classpathrev=1.1
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/stream/XMLParser.java?cvsroot=classpathr1=1.29r2=1.30
Patches:
Index: ChangeLog
===
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.7693
retrieving revision 1.7694
diff -u -b -r1.7693 -r1.7694
--- ChangeLog 7 Jun 2006 10:25:26 - 1.7693
+++ ChangeLog 7 Jun 2006 13:06:10 - 1.7694
@@ -1,3 +1,12 @@
+2006-06-07 Chris Burdess [EMAIL PROTECTED]
+
+ * gnu/classpath/debug/TeeInputStream.java,
+ gnu/classpath/debug/TeeOutputStream.java,
+ gnu/classpath/debug/TeeReader.java,
+ gnu/classpath/debug/TeeWriter.java: New classes for debugging streams.
+ * gnu/xml/stream/XMLParser.java: Use tee streams for debugging. Don't
+ read more characters than absolutely necessary in tryRead method.
+
2006-06-07 Robert Schuster [EMAIL PROTECTED]
* examples/gnu/classpath/examples/swing/Demo.java:
Index: gnu/xml/stream/XMLParser.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/stream/XMLParser.java,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -b -r1.29 -r1.30
--- gnu/xml/stream/XMLParser.java 7 Jun 2006 08:04:49 - 1.29
+++ gnu/xml/stream/XMLParser.java 7 Jun 2006 13:06:11 - 1.30
@@ -56,6 +56,8 @@
import java.io.BufferedInputStream;
import java.io.EOFException;
import java.io.File;
+import java.io.FileOutputStream;
+import java.io.FileWriter;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.IOException;
@@ -86,6 +88,8 @@
import javax.xml.stream.XMLStreamReader;
import gnu.java.net.CRLFInputStream;
+import gnu.classpath.debug.TeeInputStream;
+import gnu.classpath.debug.TeeReader;
/**
* An XML parser.
@@ -420,6 +424,21 @@
ids = new HashSet();
idrefs = new HashSet();
}
+String debug = System.getProperty(gnu.xml.debug.input);
+if (debug != null)
+ {
+try
+ {
+File file = File.createTempFile(debug, .xml);
+in = new TeeInputStream(in, new FileOutputStream(file));
+ }
+catch (IOException e)
+ {
+RuntimeException e2 = new RuntimeException();
+e2.initCause(e);
+throw e2;
+ }
+ }
pushInput(new Input(in, null, null, systemId, null, null, false, true));
}
@@ -479,6 +498,21 @@
ids = new HashSet();
idrefs = new HashSet();
}
+String debug = System.getProperty(gnu.xml.debug.input);
+if (debug != null)
+ {
+try
+ {
+File file = File.createTempFile(debug, .xml);
+reader = new TeeReader(reader, new FileWriter(file));
+ }
+catch (IOException e)
+ {
+RuntimeException e2 = new RuntimeException();
+e2.initCause(e);
+throw e2;
+ }
+ }
pushInput(new Input(null, reader, null, systemId, null, null, false,
true));
}
@@ -1332,6 +1366,15 @@
return false;
}
count += l2;
+// check the characters we received first before doing additional reads
+for (int i = 0; i count; i++)
+ {
+if (chars[i] != tmpBuf[i])
+ {
+reset();
+return false;
+ }
+ }
while (count len)
{
// force read
@@ -1341,15 +1384,14 @@
reset();
return false
[cp-patches] Fix for bug in XSL transformer
This patch fixes a bug in the XSL transformer when performing an identity transform to an existing DOMResult. 2006-06-06 Chris Burdess [EMAIL PROTECTED] * gnu/xml/transform/TransformerImpl.java: Check type of created document. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[cp-patches] Follow-on from last patch
This patch follows on from the last to correct the same condition in different parts of the code. 2006-06-06 Chris Burdess [EMAIL PROTECTED] * gnu/xml/transform/TransformerImpl.java: Check type of created document (more cases). -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ChangeLog gnu/xml/transform/Transform...
CVSROOT:/cvsroot/classpath
Module name:classpath
Changes by: Chris Burdess dog 06/06/06 12:13:33
Modified files:
. : ChangeLog
gnu/xml/transform: TransformerImpl.java
Log message:
2006-06-06 Chris Burdess [EMAIL PROTECTED]
* gnu/xml/transform/TransformerImpl.java: Check type of created
document.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.7671r2=1.7672
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/TransformerImpl.java?cvsroot=classpathr1=1.12r2=1.13
Patches:
Index: ChangeLog
===
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.7671
retrieving revision 1.7672
diff -u -b -r1.7671 -r1.7672
--- ChangeLog 6 Jun 2006 10:57:37 - 1.7671
+++ ChangeLog 6 Jun 2006 12:13:32 - 1.7672
@@ -1,3 +1,8 @@
+2006-06-06 Chris Burdess [EMAIL PROTECTED]
+
+ * gnu/xml/transform/TransformerImpl.java: Check type of created
+ document.
+
2006-06-06 Robert Schuster [EMAIL PROTECTED]
* gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java:
Index: gnu/xml/transform/TransformerImpl.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/transform/TransformerImpl.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -b -r1.12 -r1.13
--- gnu/xml/transform/TransformerImpl.java 10 Mar 2006 09:12:27 -
1.12
+++ gnu/xml/transform/TransformerImpl.java 6 Jun 2006 12:13:33 -
1.13
@@ -238,7 +238,7 @@
outputProperties.getProperty(OutputKeys.CDATA_SECTION_ELEMENTS);
boolean indent =
yes.equals(outputProperties.getProperty(OutputKeys.INDENT));
-if (created)
+if (created parent instanceof DomDocument)
{
// Discover document element
DomDocument resultDoc = (DomDocument) parent;
[commit-cp] classpath ChangeLog gnu/xml/transform/Transform...
CVSROOT:/cvsroot/classpath
Module name:classpath
Changes by: Chris Burdess dog 06/06/06 13:21:21
Modified files:
. : ChangeLog
gnu/xml/transform: TransformerImpl.java
Log message:
2006-06-06 Chris Burdess [EMAIL PROTECTED]
* gnu/xml/transform/TransformerImpl.java: Check type of created
document (more cases).
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.7675r2=1.7676
http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/transform/TransformerImpl.java?cvsroot=classpathr1=1.13r2=1.14
Patches:
Index: ChangeLog
===
RCS file: /cvsroot/classpath/classpath/ChangeLog,v
retrieving revision 1.7675
retrieving revision 1.7676
diff -u -b -r1.7675 -r1.7676
--- ChangeLog 6 Jun 2006 12:57:27 - 1.7675
+++ ChangeLog 6 Jun 2006 13:21:20 - 1.7676
@@ -1,3 +1,8 @@
+2006-06-06 Chris Burdess [EMAIL PROTECTED]
+
+ * gnu/xml/transform/TransformerImpl.java: Check type of created
+ document (more cases).
+
2006-06-06 Audrius Meskauskas [EMAIL PROTECTED]
* gnu/javax/swing/text/html/htmlAttributeSet.java
Index: gnu/xml/transform/TransformerImpl.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/transform/TransformerImpl.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -b -r1.13 -r1.14
--- gnu/xml/transform/TransformerImpl.java 6 Jun 2006 12:13:33 -
1.13
+++ gnu/xml/transform/TransformerImpl.java 6 Jun 2006 13:21:21 -
1.14
@@ -320,7 +320,7 @@
}
if (indent)
{
-if (created)
+if (created parent instanceof DomDocument)
{
DomDocument domDoc = (DomDocument) parent;
domDoc.setBuilding(true);
@@ -332,7 +332,7 @@
(Document) parent :
parent.getOwnerDocument();
reindent(resultDoc, parent, 0);
-if (created)
+if (created parent instanceof DomDocument)
{
DomDocument domDoc = (DomDocument) parent;
domDoc.setBuilding(false);
Re: [cp-patches] Initial implementation of java.net.URLConnection.guessContentTypeFromStream()
Petter Reinholdtsen wrote:
Here is a patch to implement some magic numbers in
java.net.URLConnection.guessContentTypeFromStream(). I picked a few
mime types which seemed relevant from /etc/mime-magic and implemented
tests for them. Is this approach good enough?
Index: java/net/URLConnection.java
===
RCS file: /sources/classpath/classpath/java/net/URLConnection.java,v
retrieving revision 1.42
diff -u -3 -p -u -r1.42 URLConnection.java
--- java/net/URLConnection.java 12 May 2006 20:59:30 - 1.42
+++ java/net/URLConnection.java 16 May 2006 22:08:55 -
@@ -971,10 +971,30 @@ public abstract class URLConnection
* @exception IOException If an error occurs
*/
public static String guessContentTypeFromStream(InputStream is)
-throws IOException, NotImplementedException
+throws IOException
{
// See /etc/gnome-vfs-mime-magic or /etc/mime-magic for a
reasonable
// idea of how to handle this.
+
+is.mark(5);
+int c0 = is.read();
+int c1 = is.read();
+int c2 = is.read();
+int c3 = is.read();
+is.reset();
+
+if (c0 == 0xFF c1 == 0xD8)
+ return image/jpeg;
+
+if (c0 == 'G' c1 == 'I' c2 == 'F' c3 == '8')
+ return image/gif;
+
+if (c1 == 'P' c2 == 'N' c3 == 'G')
+ return image/png;
+
+if (c0 == 'P' c1 == 'K' c2 == 3 c3 == 4)
+ return application/zip;
+
return application/octet-stream;
}
Not if is.isMarkSupported() returns false...
--
犬 Chris Burdess
They that can give up essential liberty to obtain a little safety
deserve neither liberty nor safety. - Benjamin Franklin
PGP.sig
Description: This is a digitally signed message part
Re: Build failure: mozilla-plugin
Thomas Fitzsimmons wrote: Norman Hendrich wrote: Hello all, trying to build classpath cvs fails for me right now, because I don't have package mozilla-plugin installed on my Linux system. (I do have mozilla, but I don't have any plugins except Suns JRE and flash-blocked flash.) Anyway, I think that classpath should be buildable without any mozilla dependencies. Try --disable-plugin. fx:drums fingers -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
[cp-patches] Fix for DomNode.cloneNode
I committed the following patch to work around a problem cloning DOM doctype nodes containing comments and/or PIs reported by Ian Rogers on IRC. 2006-05-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/dom/DomNode.java: Permit comments and PIs in doctype nodes to be preserved during cloneNode. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ./ChangeLog gnu/xml/dom/DomNode.java
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Chris Burdess [EMAIL PROTECTED] 06/05/09 14:27:36 Modified files: . : ChangeLog gnu/xml/dom: DomNode.java Log message: 2006-05-09 Chris Burdess [EMAIL PROTECTED] * gnu/xml/dom/DomNode.java: Permit comments and PIs in doctype nodes to be preserved during cloneNode. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7333tr2=1.7334r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/gnu/xml/dom/DomNode.java.diff?tr1=1.14tr2=1.15r1=textr2=text
Re: [cp-patches] Patch: RFC: argument parsing and 'jar' utility
Tom Tromey wrote: This weekend I wrote an argument parsing utility. It looked easy and I figured it would be better to simply have our own -- one in the correct namespace, that we can easily hack, and that doesn't have any legal baggage at all. It is reasonably straightforward to use and fully documented. ... Please comment. I propose that we convert all the tools to use the new argument parser. +1 -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
Re: [cp-patches] TransformerFactoryImpl
Jeroen Frijters wrote: I know nothing about the XML APIs, so I hope this isn't a dumb question but I just debugged some code from a user of IKVM and it did the following: SAXTransformerFactory factory = (SAXTransformerFactory)TransformerFactory.newInstance(); On the JDK this works. Now obviously the documentation doesn't specify that this is legal, but since there is code out there that assumes this work (dcm4che2, no idea what it does) I was wondering if we could/ should support it too. What do you think? Certainly, if you can find someone to develop such a transformer implementation. Note that the specification of XSL transformations defines that they operate over a tree rather than an event stream, so this is a totally pointless API that makes many assumptions that are clearly false. But it should theoretically be possible to implement it. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
Re: [cp-patches] RFC: DatatypeFactory implementation resolution mechanism
Tom Tromey wrote: Chris Please review the following patch for conformance to the API Chris specification of DatatypeFactory.newInstance Looking pretty good. Chris +// 2. jaxp.properties property Chris +File javaHome = new File(System.getProperty (java.home)); Chris +File javaHomeLib = new File(javaHome, lib); We usually use gnu.classpath.home.url here. The specification actually says to use $JAVA_HOME. Chris +// 3. services Chris +InputStream in = DatatypeFactory.class.getClassLoader() Chris + .getResourceAsStream(/META-INF/services/ + Chris + DATATYPEFACTORY_PROPERTY); We usually use gnu.classpath.ServiceFactory for this kind of thing. I incorporated this suggestion and committed. 2006-04-26 Chris Burdess [EMAIL PROTECTED] Fixes PR 27290 * javax/xml/datatype/DatatypeFactory.java: Use complete implementation resolution mechanism. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[commit-cp] classpath ./ChangeLog javax/xml/datatype/Dataty...
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Chris Burdess [EMAIL PROTECTED] 06/04/26 18:36:13 Modified files: . : ChangeLog javax/xml/datatype: DatatypeFactory.java Log message: 2006-04-26 Chris Burdess [EMAIL PROTECTED] Fixes PR 27290 * javax/xml/datatype/DatatypeFactory.java: Use complete implementation resolution mechanism. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.7215tr2=1.7216r1=textr2=text http://cvs.savannah.gnu.org/viewcvs/classpath/classpath/javax/xml/datatype/DatatypeFactory.java.diff?tr1=1.5tr2=1.6r1=textr2=text
[cp-patches] Fix for getElementById
I committed the following patch to fix a bug in our DOM implementation: 2006-04-24 Chris Burdess [EMAIL PROTECTED] Fixes PR 27262 * gnu/xml/dom/DomDocument.java: getElementById returns user- defined ID attributes when no doctype exists. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
[cp-patches] RFC: DatatypeFactory implementation resolution mechanism
Please review the following patch for conformance to the API specification of DatatypeFactory.newInstance 2006-04-24 Chris Burdess [EMAIL PROTECTED] Fixes PR 27290 * javax/xml/datatype/DatatypeFactory.java: Use complete implementation resolution mechanism. -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin patch Description: Binary data PGP.sig Description: This is a digitally signed message part
Re: [cp-patches] FYI: gnu.xml.dom.html2.* fixes and additions
Lillian Angel wrote: That's wrong. The colon is not permitted to appear as the last character in the string. You removed a valid check. Sun does permit a ':' to be the last character in a string. I was rather quick to assume that I was correct. I retested the applets that posed to be a problem, and they now work with this part of the patch reverted. 2006-04-18 Lillian Angel [EMAIL PROTECTED] * gnu/xml/dom/DomDocument.java (checkNCName): Reverted last patch. Added check for colon at last position back in. Thanks for pointing this out, I have changed it back. FYI http://www.w3.org/TR/REC-xml-names/#ns-qualnames http://www.w3.org/TR/xml-names11/#ns-qualnames -- 犬 Chris Burdess They that can give up essential liberty to obtain a little safety deserve neither liberty nor safety. - Benjamin Franklin PGP.sig Description: This is a digitally signed message part
