Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
On 09/08/2014 05:35 AM, Pascal Bach wrote: Even better would be to make the search case insensitive. How do we know which flags are sensitive to case? It has nothing to do with Visual Studio as it doesn't care about the casing. The problem is in the CMake generator. The tables in (eg. Source/cmVS10LinkFlagTable.h) map from linker flags to XML elements in the resulting .vcxproj file. One such example is the entry: {SubSystem, SUBSYSTEM:WINDOWSCE, WindowsCE, WindowsCE, 0}, This maps a flag /SUBSYSTEM:WINDOWSCE to Subsystem WindowsCE /Subsystem As you can see the entries in the table are in upper case. And the mapping does only work if the flags are uppercase to. Maybe a better solution would be to do this matching in a case in sensitive way, this way it would work in any case even with user passed flags in lower case. - set(CMAKE_CREATE_WIN32_EXE /entry:WinMainCRTStartup) - set(CMAKE_CREATE_CONSOLE_EXE /entry:mainACRTStartup) - set(_PLATFORM_LINK_FLAGS /subsystem:windowsce) + set(CMAKE_CREATE_WIN32_EXE /SUBSYSTEM:WINDOWSCE /ENTRY:WinMainCRTStartup) + set(CMAKE_CREATE_CONSOLE_EXE /SUBSYSTEM:WINDOWSCE /ENTRY:mainACRTStartup) + set(_PLATFORM_LINK_FLAGS ) That appears to un-do this recent fix: MSVC: Fix linking of DLLs on WinCE (#15013) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e1283e4 http://www.cmake.org/Bug/view.php?id=15013 that introduced _PLATFORM_LINK_FLAGS in the first place. Rith I think I had a too simplistic view here. But even the old fix doesn't seem to work with VS. I think the /ENTRY point also needs to be set for the DLLs, I will try if I can find out how to set this. Pascal PS: Forgot to add the mailinglist. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
On 09/09/2014 05:31 AM, Bach, Pascal wrote: Maybe a better solution would be to do this matching in a case insensitive way, this way it would work in any case even with user passed flags in lower case. I'm saying that some flags are case sensitive and others are not. We cannot blindly match all cl flags insensitive to case, for example. Anyway, I think just matching the case is good enough for now. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
Maybe a better solution would be to do this matching in a case insensitive way, this way it would work in any case even with user passed flags in lower case. I'm saying that some flags are case sensitive and others are not. We cannot blindly match all cl flags insensitive to case, for example. Anyway, I think just matching the case is good enough for now. Ok I didn't know that cl does care about casing for some flags. - set(CMAKE_CREATE_WIN32_EXE /entry:WinMainCRTStartup) - set(CMAKE_CREATE_CONSOLE_EXE /entry:mainACRTStartup) - set(_PLATFORM_LINK_FLAGS /subsystem:windowsce) + set(CMAKE_CREATE_WIN32_EXE /SUBSYSTEM:WINDOWSCE /ENTRY:WinMainCRTStartup) + set(CMAKE_CREATE_CONSOLE_EXE /SUBSYSTEM:WINDOWSCE /ENTRY:mainACRTStartup) + set(_PLATFORM_LINK_FLAGS ) That appears to un-do this recent fix: MSVC: Fix linking of DLLs on WinCE (#15013) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e1283e4 http://www.cmake.org/Bug/view.php?id=15013 that introduced _PLATFORM_LINK_FLAGS in the first place. The values added to _PLATFORM_LINK_FLAGS do never end up in the .vcxproj file. The go into CMAKE_${lang}_CREATE_SHARED_LIBRARY [1] and CMAKE_${lang}_LINK_EXECUTABLE [2] However I can't see how this variables should end up in the VS generator. Any ideas? [1] https://github.com/Kitware/CMake/blob/6ae98ee18f6c35b93556a66dc0ce909d84aec18b/Modules/Platform/Windows-MSVC.cmake#L242 [2] https://github.com/Kitware/CMake/blob/6ae98ee18f6c35b93556a66dc0ce909d84aec18b/Modules/Platform/Windows-MSVC.cmake#L256 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
On 09/09/2014 09:48 AM, Bach, Pascal wrote: The values added to _PLATFORM_LINK_FLAGS do never end up in the .vcxproj file. The go into CMAKE_${lang}_CREATE_SHARED_LIBRARY [1] and CMAKE_${lang}_LINK_EXECUTABLE [2] However I can't see how this variables should end up in the VS generator. Any ideas? Those are all for the Makefile and Ninja generators, as are CMAKE_CREATE_WIN32_EXE and CMAKE_CREATE_CONSOLE_EXE. For VS generators the knowledge has always been hard-coded, with a special case for Windows CE: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalVisualStudio7Generator.cxx;hb=v3.0.1#l1122 The cmVisualStudio10TargetGenerator could be taught this similarly. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
Those are all for the Makefile and Ninja generators, as are CMAKE_CREATE_WIN32_EXE and CMAKE_CREATE_CONSOLE_EXE. For VS generators the knowledge has always been hard-coded, with a special case for Windows CE: http://www.cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmLocalVisual Studio7Generator.cxx;hb=v3.0.1#l1122 The cmVisualStudio10TargetGenerator could be taught this similarly. Wouldn't it make sense to use the same variables in the VS10+ Generator too? It seems redundant to have the same information again. What's the reason it is hardcoded? Pascal -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
On 09/09/2014 10:19 AM, Bach, Pascal wrote: Wouldn't it make sense to use the same variables in the VS10+ Generator too? It seems redundant to have the same information again. What's the reason it is hardcoded? That's just the way it was written. The rule variables like CMAKE_${lang}_CREATE_SHARED_LIBRARY contain command lines in which the Makefile and Ninja generators substitute for some placeholders. The VS generators do not have a command line because they just put the declarative information into the project file and let VS build the command line. If you want to refactor things to create more independent flag-holding variables that are used to construct CMAKE_${lang}_CREATE_SHARED_LIBRARY and also read by the VS generators and sent through the flag map, that's fine with me. Please also update the VS 7-9 generators to use the same information variables if possible. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
On 09/09/2014 10:19 AM, Bach, Pascal wrote: Wouldn't it make sense to use the same variables in the VS10+ Generator too? It seems redundant to have the same information again. What's the reason it is hardcoded? That's just the way it was written. The rule variables like CMAKE_${lang}_CREATE_SHARED_LIBRARY contain command lines in which the Makefile and Ninja generators substitute for some placeholders. The VS generators do not have a command line because they just put the declarative information into the project file and let VS build the command line. I don't understand the purpose of the flag tables [1]. Aren't they there to map from command line to XML files? At first I tought the way things work was: Windows-MSVC.cmake and Co construct a commandline with the required flags. == The VS generator parses this command line and uses the cmVS7FlagTable to translate the known flags to XML elements. (Unknown arguments get passed as additional arguments). But it might be that this doesn't work because multi configuration or something else. [1] https://github.com/Kitware/CMake/blob/6ae98ee18f6c35b93556a66dc0ce909d84aec18b/Source/cmVS10LinkFlagTable.h If you want to refactor things to create more independent flag-holding variables that are used to construct CMAKE_${lang}_CREATE_SHARED_LIBRARY and also read by the VS generators and sent through the flag map, that's fine with me. Please also update the VS 7-9 generators to use the same information variables if possible. If I refactor I would change it to the way described above. Pascal -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
On 09/09/2014 11:02 AM, Bach, Pascal wrote: I don't understand the purpose of the flag tables [1]. Aren't they there to map from command line to XML files? Yes, but they were created originally to support flags specified by users in CMAKE_C_FLAGS and a few other places. At first I tought the way things work was: Windows-MSVC.cmake and Co construct a commandline with the required flags. The VS generator parses this command line and uses the cmVS7FlagTable to translate the known flags to XML elements. (Unknown arguments get passed as additional arguments). This is done for a subset of the sources of flags, specifically those settable by users and project code. We can't use a complete command line like that in CMAKE_${lang}_CREATE_SHARED_LIBRARY because that will contain a lot of pieces besides the flags. Also multi-configuration is an issue as you point out. You would need to create new variables in Windows-MSVC to hold the flags to be scanned by the VS generators. Then re-use the flags in constructing the other rule variables with command-lines used by the Makefile and Ninja generators. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [PATCH] FindIce: Remove unneeded search path modification
Hi, I have attached a minor fix to the FindIce module added a couple of weeks back. This can override the user's intended search path and was made unnecessary by the changes you requested prior to merging (the paths being added are already added as fallbacks via the list(APPEND ice_roots /opt/Ice-${ice_version}) line earlier in the script), so the removal simply makes the behaviour consistent. Regards, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 From e73f31183fb392769091877ee8aedffbe7de2f88 Mon Sep 17 00:00:00 2001 From: Roger Leigh r.le...@dundee.ac.uk Date: Tue, 9 Sep 2014 16:28:11 +0100 Subject: [PATCH] FindIce: Remove unneeded search path modification --- Modules/FindIce.cmake | 7 --- 1 file changed, 7 deletions(-) diff --git a/Modules/FindIce.cmake b/Modules/FindIce.cmake index c437a40..50bc60e 100644 --- a/Modules/FindIce.cmake +++ b/Modules/FindIce.cmake @@ -242,13 +242,6 @@ function(_Ice_FIND) message(STATUS Ice version: ${Ice_VERSION_SLICE2CPP_FULL}) - # The following searches prefer the version found; note reverse - # order due to prepending. - if(NOT MSVC) -list(INSERT ice_roots 0 /opt/Ice-${Ice_VERSION_SLICE2CPP_SHORT}) -list(INSERT ice_roots 0 /opt/Ice-${Ice_VERSION_SLICE2CPP_FULL}) - endif() - # Find include directory find_path(Ice_INCLUDE_DIR NAMES Ice/Ice.h -- 1.9.1 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH 3/3] VS: Pass MSVC compiler flags in upper case
At first I tought the way things work was: Windows-MSVC.cmake and Co construct a commandline with the required flags. The VS generator parses this command line and uses the cmVS7FlagTable to translate the known flags to XML elements. (Unknown arguments get passed as additional arguments). This is done for a subset of the sources of flags, specifically those settable by users and project code. We can't use a complete command line like that in CMAKE_${lang}_CREATE_SHARED_LIBRARY because that will contain a lot of pieces besides the flags. Also multi-configuration is an issue as you point out. You would need to create new variables in Windows-MSVC to hold the flags to be scanned by the VS generators. Then re-use the flags in constructing the other rule variables with command-lines used by the Makefile and Ninja generators. Looks like a bigger refactoring would be needed. Maybe for the moment it is better to implement it analogous to WindowsPhone and then later refactor the whole thing. Pascal -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] [CMake 0015144]: CMake is unable to locate FreeType within the XQuartz installation
The following issue has been SUBMITTED. == http://public.kitware.com/Bug/view.php?id=15144 == Reported By:Sergey Kosarevsky Assigned To: == Project:CMake Issue ID: 15144 Category: CMake Reproducibility:always Severity: minor Priority: normal Status: new == Date Submitted: 2014-09-09 12:58 EDT Last Modified: 2014-09-09 12:58 EDT == Summary:CMake is unable to locate FreeType within the XQuartz installation Description: XQuartz-2.7.7.dmg is installed. The FreeType library is located in /opt/X11/include/freetype2 The CMake output is on the attached screenshot. Steps to Reproduce: CMakeLists.txt: IF(WITH_FREETYPE) FIND_PACKAGE(Freetype REQUIRED) ADD_DEFINITIONS(-DUSEFREETYPE) INCLUDE_DIRECTORIES(${FREETYPE_INCLUDE_DIRS}) SET(wcm_LIBS ${wcm_LIBS} ${FREETYPE_LIBRARIES}) ENDIF(WITH_FREETYPE) == Issue History Date ModifiedUsername FieldChange == 2014-09-09 12:58 Sergey KosarevskyNew Issue 2014-09-09 12:58 Sergey KosarevskyFile Added: 29efc2ec-37b0-11e4-9a95-e78996c79ba3.jpg == -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] include(...) or find_package(...) within another Findpackage module
I'm working on trying to modernize the FindFLTK module but also stuck with making sure I don't break the established behavior. The problems with the module are extensive so I'm breaking them up into individual emails where possible. The part I'm questioning in this email is: Should this be include(FindX11) as it shows or find_package(X11)? if(UNIX) include(FindX11) find_library(FLTK_MATH_LIBRARY m) set(FLTK_PLATFORM_DEPENDENT_LIBS ${X11_LIBRARIES} ${FLTK_MATH_LIBRARY}) endif() Thanks, Richard -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] FindIce: Remove unneeded search path modification
On Tue, Sep 09, 2014 at 11:48:53AM -0400, Brad King wrote: On 09/09/2014 11:35 AM, Roger Leigh wrote: I have attached a minor fix to the FindIce module added a couple of weeks back. Applied, thanks: FindIce: Remove unneeded search path modification http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d5047ca1 While reviewing I noticed that there are some message(STATUS) calls not protected by if(Ice_DEBUG) or checks of Ice_FIND_QUIETLY. The latter is needed to honor the QUIET option of find_package. Please revise in a follow-up patch. I have attached a patch to do this. Thanks, Roger -- .''`. Roger Leigh : :' : Debian GNU/Linuxhttp://people.debian.org/~rleigh/ `. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools `-GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800 From 50b40ca739ea9f7646ed2e9cef9a7023df000586 Mon Sep 17 00:00:00 2001 From: Roger Leigh rle...@codelibre.net Date: Tue, 9 Sep 2014 18:48:28 + Subject: [PATCH 2/2] FindIce: Respect Ice_FIND_QUIETLY when printing messages --- Modules/FindIce.cmake | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/Modules/FindIce.cmake b/Modules/FindIce.cmake index 50bc60e..60a4107 100644 --- a/Modules/FindIce.cmake +++ b/Modules/FindIce.cmake @@ -240,7 +240,9 @@ function(_Ice_FIND) set(Ice_VERSION ${Ice_VERSION_SLICE2CPP_FULL} PARENT_SCOPE) endif() - message(STATUS Ice version: ${Ice_VERSION_SLICE2CPP_FULL}) + if(NOT Ice_FIND_QUIETLY) +message(STATUS Ice version: ${Ice_VERSION_SLICE2CPP_FULL}) + endif() # Find include directory find_path(Ice_INCLUDE_DIR @@ -305,17 +307,19 @@ function(_Ice_FIND) set(_Ice_REQUIRED_LIBS_FOUND ${Ice_REQUIRED_LIBS_FOUND} PARENT_SCOPE) set(Ice_LIBRARY ${Ice_LIBRARY} PARENT_SCOPE) - if(Ice_LIBS_FOUND) -message(STATUS Found the following Ice libraries:) -foreach(found ${Ice_LIBS_FOUND}) - message(STATUS ${found}) -endforeach() - endif() - if(Ice_LIBS_NOTFOUND) -message(STATUS The following Ice libraries were not found:) -foreach(notfound ${Ice_LIBS_NOTFOUND}) - message(STATUS ${notfound}) -endforeach() + if(NOT Ice_FIND_QUIETLY) +if(Ice_LIBS_FOUND) + message(STATUS Found the following Ice libraries:) + foreach(found ${Ice_LIBS_FOUND}) +message(STATUS ${found}) + endforeach() +endif() +if(Ice_LIBS_NOTFOUND) + message(STATUS The following Ice libraries were not found:) + foreach(notfound ${Ice_LIBS_NOTFOUND}) +message(STATUS ${notfound}) + endforeach() +endif() endif() if(Ice_DEBUG) -- 1.9.4.msysgit.0 -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] [PATCH] FindIce: Remove unneeded search path modification
On 09/09/2014 02:56 PM, Roger Leigh wrote: I have attached a patch to do this. Thanks, applied: FindIce: Respect Ice_FIND_QUIETLY when printing messages http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2131aedd -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] include(...) or find_package(...) within another Findpackage module
On 09/09/2014 02:21 PM, Richard Shaw wrote: Should this be include(FindX11) as it shows or find_package(X11)? if(UNIX) include(FindX11) find_library(FLTK_MATH_LIBRARY m) set(FLTK_PLATFORM_DEPENDENT_LIBS ${X11_LIBRARIES} ${FLTK_MATH_LIBRARY}) endif() It should be find_package(X11). Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Gold standard find module?
Everyone has been really helpful but I don't want to be a pest. Is there a specific find package module that one could point to that would be consider the gold standard of getting it right? One with sufficient complexity (not like the wiki example). Thanks, Richard -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[cmake-developers] Modern cross-platform buildsystem design requirements
Hi, I saw the addition of the VS_WINRT_COMPONENT property. This seems to be an attribute to mark an executable specially so that it is built with appropriate flags for the WinRT platform. This reminds me of this thread: http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/9728 Building executables as libraries (2014-03-21) and I wonder again if a generic solution would be possible to design. I wonder what a cmake-based buildsystem would look like for a collection of executables/targets which should be built for multiple of these 'modern, extra attribute-requiring' platforms. Until a few years ago, add_library(foo foo.cpp) add_executable(myexe main.cpp) target_link_libraries(myexe foo) was all that was needed for what we then called 'cross-platform' - it is a sufficient description to generate buildsystems to generate a working library and executable on first-class targets Windows/Linux/Mac and also cross-compiling, given an appropriate toolchain file. Today, I think 'cross-platform' includes a few mobile platforms as first- class targets, and cross-compiling is part of what cross-platform means. So, I wonder what a cross-platform buildsystem necessarily looks like today, and whether it can be done better/abstracted with more first class features. I guess in addition to the above, there would need to be something like a wrapper macro around add_executable to set the appropriate target properties, and possibly use a platform-specific condition for whether to actually create an executable or a PIC shared library (as described in the above thread). Is there any known real-world project aiming to build for those varieties of platforms so we can see what abstraction is needed? According to http://www.cmake.org/Wiki/CMake_Cross_Compiling#FAQ.2FPotential_Problems If you build software for PS3, you build software for two architectures, for the PowerPC and for the cells. That information seems to come from: http://www.cmake.org/pipermail/cmake/2008-January/018937.html I was reminded of the above by http://thread.gmane.org/gmane.comp.programming.tools.cmake.user/50389 I don't know how common it is to use cmake in those industries/environments, but if multiple toolchains are needed, I'm reminded of the previous proposal for multiple toolchain use. http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/7272 Partly that discussion was aborted because we already had the large topic of designing and implementing usage-requirements to deal with. As that is now complete as designed, it might be worthwhile to re-consider and discuss/design how multiple toolchains could be used at once, whether that would require or benefit from a new language for cmake (another orthogoal known possible future-direction for cmake) etc. [ The manual at Help/manual/cmake-toolchains.7.rst contains several sample toolchain files for Unix. It would be good to have some sample toolchain files using the new WinRT stuff, setting the toolset and CMAKE_GENERATOR_PLATFORM to see how that all fits together now with VisualStudio. ] Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
[CMake] Corrupted CmakeLists.txt File how to heal it ?
Dear All, I find ti very difficult to configure the project which has the following CMakeLists.txt at the attachement.The CMakeLists is automatically created with FireBreath Python script (fbgen.py) and is supposed to run on Win32/64 compiled with MSVS10~13 and MinGW compilers. After compilation it is supposed to create a osgWeb plugin of OpenSceneGraph library which will be used in Web applications for rendering. I Use Cmake-GUI 2.8.12.2 to configure the CMakeLists.txt file but no matter which compiler I set ( I prefer Code::Blocks MinGW Makefile) Cmake-GUI produces the Error in configurition process, project files may be invalid dialog, with following report, CMake Error at CMakeLists.txt:11 (Project): project PROJECT called with incorrect number of arguments CMake Error at CMakeLists.txt:39 (include_platform): Unknown CMake command include_platform. Configuring incomplete, errors occurred! What is wrong here I 'll appreciate your guidance, #/**\ # # Auto-generated CMakeLists.txt for the osgWeb project # #\**/ # Written to work with cmake 2.6 cmake_minimum_required (VERSION 2.6) set (CMAKE_BACKWARDS_COMPATIBILITY 2.6) Project(${PLUGIN_NAME}) file (GLOB GENERAL RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} [^.]*.cpp [^.]*.h [^.]*.cmake ) include_directories(${PLUGIN_INCLUDE_DIRS}) # Generated files are stored in ${GENERATED} by the project configuration SET_SOURCE_FILES_PROPERTIES( ${GENERATED} PROPERTIES GENERATED 1 ) SOURCE_GROUP(Generated FILES ${GENERATED} ) SET( SOURCES ${GENERAL} ${GENERATED} ) # This will include Win/projectDef.cmake, X11/projectDef.cmake, Mac/projectDef # depending on the platform include_platform() find_path( OPENSCENEGRAPH_ROOT include/osg/Node PATHS $ENV{OSG_ROOT} ) include_directories( ${OPENSCENEGRAPH_ROOT}/include ) link_directories( ${Boost_LIBRARY_DIRS} ${OPENSCENEGRAPH_ROOT}/lib ) include_platform() target_link_libraries(${PROJECT_NAME} OpenThreads osg osgDB osgGA osgViewer) -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[CMake] INCLUDE() guards
Hi all, I have a project with multiple interdependent subpackages here, each of which has its own export config file. The dependency hierarchy is reflected in the `INCLUDE()` statements in the export files. I would like to avoid that an export config file is included more than once, so I'm guarding the files with ``` IF(NOT name of the subpackage_CONFIG_INCLUDED) SET(name of the subpackage_CONFIG_INCLUDED 1) [...] setting of export variable etc [...] ENDIF() ``` This looks very much like the old C/C++ `#ifdef` `#include` header guards, so I was wondering if this is an appropriate pattern for CMake too. Or maybe there is another CMake command that already does exactly what I want? Cheers, Nico -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] Corrupted CmakeLists.txt File how to heal it ?
On 09/09/2014 01:34 PM, Sonya Blade wrote: I Use Cmake-GUI 2.8.12.2 to configure the CMakeLists.txt file but no matter which compiler I set ( I prefer Code::Blocks MinGW Makefile) Cmake-GUI produces the Error in configurition process, project files may be invalid dialog, with following report, /CMake Error at CMakeLists.txt:11 (Project): project PROJECT called with incorrect number of arguments / /CMake Error at CMakeLists.txt:39 (include_platform): Unknown CMake command include_platform. / /Configuring incomplete, errors occurred!/ / / What is wrong here I 'll appreciate your guidance, Is it possible that this isn't the top-level CMakeLists.txt? It looks like the PLUGIN_NAME variable isn't set which is probably why project() complains. Also I see nothing that would define the include_platform() function/macro which is missing. Maybe both the variable and the function/macro are set up in a parent CMakeLists.txt? Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] Corrupted CmakeLists.txt File how to heal it ?
Hi Nils,You guess is correct it is not top level CMakeLists.txt, but actually originator instruct to do soand even instruct to add the additional lines to sub-level CMakeLists.txt. Probably I misinterpreted it,and probably this is what he meant:Add the additional lines to the sub level CmakeLists but run the top-level Cmakelists file. In in case modifying the auto generated code sounds weird to me, as a more experienced user than me do you spot any abnormalities by runing a quick eye at the code below ? Originator Quote (OSG Cookbook){When we have the CMakeLists.txt file in the project folder (in projects/osgWeb), open it with any text editor and modify the last few lines: find_path( OPENSCENEGRAPH_ROOT include/osg/Node PATHS$ENV{OSG_ROOT} )include_directories( ${OPENSCENEGRAPH_ROOT}/include )link_directories( ${Boost_LIBRARY_DIRS}${OPENSCENEGRAPH_ROOT}/lib )include_platform()target_link_libraries(${PROJECT_NAME} OpenThreadsosg osgDB osgGA osgViewer)}Regards, Date: Tue, 9 Sep 2014 13:56:15 +0200 From: nilsglad...@gmail.com To: sonyablade2...@hotmail.com; cmake@cmake.org Subject: Re: [CMake] Corrupted CmakeLists.txt File how to heal it ? On 09/09/2014 01:34 PM, Sonya Blade wrote: I Use Cmake-GUI 2.8.12.2 to configure the CMakeLists.txt file but no matter which compiler I set ( I prefer Code::Blocks MinGW Makefile) Cmake-GUI produces the Error in configurition process, project files may be invalid dialog, with following report, /CMake Error at CMakeLists.txt:11 (Project): project PROJECT called with incorrect number of arguments / /CMake Error at CMakeLists.txt:39 (include_platform): Unknown CMake command include_platform. / /Configuring incomplete, errors occurred!/ / / What is wrong here I 'll appreciate your guidance, Is it possible that this isn't the top-level CMakeLists.txt? It looks like the PLUGIN_NAME variable isn't set which is probably why project() complains. Also I see nothing that would define the include_platform() function/macro which is missing. Maybe both the variable and the function/macro are set up in a parent CMakeLists.txt? Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] Request for added script intelligence
Let's see if anybody else chimes in with an opinion. I've already given mine, and I don't think there's a good argument for making installing the debug runtime libraries any easier than it already is. You can certainly write a wrapper script around the existing CMake InstallRequiredSystemLibraries that has additional logic surrounding it. Whatever the case, if any change to CMake is proposed, it should take Visual Studio generator usage into account: i.e. -- do not rely on CMAKE_BUILD_TYPE, as it is typically empty/not set in a multi-configuration VS build. Thanks, David C. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] Corrupted CmakeLists.txt File how to heal it ?
On 09/09/2014 02:05 PM, Sonya Blade wrote: Hi Nils, You guess is correct it is not top level CMakeLists.txt, but actually originator instruct to do so and even instruct to add the additional lines to sub-level CMakeLists.txt. Probably I misinterpreted it, and probably this is what he meant: Add the additional lines to the sub level CmakeLists but run the top-level Cmakelists file. In in case modifying the auto generated code sounds weird to me, as a more experienced user than me do you spot any abnormalities by runing a quick eye at the code below ? Originator Quote (OSG Cookbook) { /When we have the CMakeLists.txt file in the project folder (in projects// /osgWeb), open it with any text editor and modify the last few lines:/ / / /find_path( OPENSCENEGRAPH_ROOT include/osg/Node PATHS/ /$ENV{OSG_ROOT} )/ /include_directories( ${OPENSCENEGRAPH_ROOT}/include )/ /link_directories( ${Boost_LIBRARY_DIRS}/ /${OPENSCENEGRAPH_ROOT}/lib )/ /include_platform()/ /target_link_libraries(${PROJECT_NAME} OpenThreads/ /osg osgDB osgGA osgViewer)/ } If the issue is with the generator you might want to bring this up with the project maintainers. Generated CMake projects are a bit of an oddity given that most CMake projects are handwritten and CMake itself does not provide the facilities used for the generation. Nils -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[CMake] ITK compiling problem with CMake
Hi, I'm learning ITK for some image registration project. But just at the first step, I met a problem compiling it with CMake. The CMakeError log as following: *Compiling the C compiler identification source file CMakeCCompilerId.c failed.* *Compiler: * *Build flags: * *Id flags: * *The output was:* *The System cannot find the file specified.* *Compiling the CXX compiler identification source file CMakeCXXCompilerId.cpp failed.* *Compiler: * *Build flags: * *Id flags: * *The output was:* *The System cannot find the file specified.* The OS on my computer is Windows 8.1 with Visual Studio 2012 Pro. It seems a CMake problem, but I don't know how to solve. I'll appreciate your help. Yours, Vincent -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[CMake] Dinamically generated dependencies
Hi, I am trying to generate file that depends on a set of files that can change throughout different make invocations. To understand it better, let's show you the code: --- cmake_minimum_required(VERSION 2.8) project(demo-one C) add_custom_command( OUTPUT ${CMAKE_BINARY_DIR}/generated.c COMMAND generate -o ${CMAKE_BINARY_DIR}/generated.c DEPENDS $(shell generate-dependencies-list) COMMENT Generating generated.c ) add_executable(main main.c ${CMAKE_BINARY_DIR}/generated.c) --- So, I want to generate the file generated.c with the generate command and this files needs to be regenerated when the files specified by generated-dependencies-list command changes. As you may notice, generated-dependencies-list can generate different set of files throughout different make invocations, so is not feasible to get the result of generated-dependencies-list at configure time to then pass the result to add_custom_command. Actually the above code somewhat works, but it looks like a hack that will only work for Makefile backend, also the make rule doesn't look as what I'm expecting, after all, it's a hack: generated.c: ../$(shell\ generate-dependencies-list) Has CMake any feature to achieve this? Basically, I want this rule or something to get the same result: generated.c: $(shell generate-dependencies-list) -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[CMake] Building library with a collection of source + pre-existing object files (which are not compiled via the cmake build system)
Hi, I have not been able to find this in the cmake documentation. I have a collection of source that needs to be compiled via the cmake build system, plus a collection of object files that were compiled outside the cmake build system. I want to combine the two of these to make a shared library, but apparently add_library only takes a list of source files. Is there a way of getting cmake to build a shared library with the collection of source and object files I have? I know I could make an archive of the object files and use that library in target_link_libraries, but I would like to avoid this if I can. Thanks, Tom -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] Building library with a collection of source + pre-existing object files (which are not compiled via the cmake build system)
On 09.09.2014 17:02, Tom Kacvinsky wrote: Hi, I have not been able to find this in the cmake documentation. I have a collection of source that needs to be compiled via the cmake build system, plus a collection of object files that were compiled outside the cmake build system. I want to combine the two of these to make a shared library, but apparently add_library only takes a list of source files. Is there a way of getting cmake to build a shared library with the collection of source and object files I have? I know I could make an archive of the object files and use that library in target_link_libraries, but I would like to avoid this if I can. You should be able to list your object files like regular source files. If they have known object file extensions they should be detected as such (.obj, .o, .lo). Otherwise you can try setting the EXTERNAL_OBJECT[1] source file property for them. Nils [1] www.cmake.org/cmake/help/v3.0/prop_sf/EXTERNAL_OBJECT.html -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
Re: [CMake] Building library with a collection of source + pre-existing object files (which are not compiled via the cmake build system)
Thank you, Nils. Tom On Tue, Sep 9, 2014 at 11:25 AM, Nils Gladitz nilsglad...@gmail.com wrote: On 09.09.2014 17:02, Tom Kacvinsky wrote: Hi, I have not been able to find this in the cmake documentation. I have a collection of source that needs to be compiled via the cmake build system, plus a collection of object files that were compiled outside the cmake build system. I want to combine the two of these to make a shared library, but apparently add_library only takes a list of source files. Is there a way of getting cmake to build a shared library with the collection of source and object files I have? I know I could make an archive of the object files and use that library in target_link_libraries, but I would like to avoid this if I can. You should be able to list your object files like regular source files. If they have known object file extensions they should be detected as such (.obj, .o, .lo). Otherwise you can try setting the EXTERNAL_OBJECT[1] source file property for them. Nils [1] www.cmake.org/cmake/help/v3.0/prop_sf/EXTERNAL_OBJECT.html -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake
[Cmake-commits] CMake branch, master, updated. v3.0.1-1836-g7b2e3cc
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via 7b2e3cc63b6dc38a458524a4edcdd43fe967098b (commit) via 3e84e78c3fcd2575a4159c3a1619833a7a80ef17 (commit) from a5c6ae69f3f773ade65f94b26a79adfbe64dff66 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7b2e3cc63b6dc38a458524a4edcdd43fe967098b commit 7b2e3cc63b6dc38a458524a4edcdd43fe967098b Merge: a5c6ae6 3e84e78 Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 11:23:34 2014 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Tue Sep 9 11:23:34 2014 -0400 Merge topic 'use-consistent-regex-for-info-strings' 3e84e78c Use a more reliable regex for extracting binary INFO strings --- Summary of changes: Modules/CMakeDetermineCompilerABI.cmake |2 +- Modules/CMakeDetermineCompilerId.cmake |2 +- Modules/FortranCInterface/Detect.cmake |2 +- Tests/PerConfig/perconfig.cmake |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.0.1-5251-g86bf8af
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 86bf8afb4c085aef5e67bf8f37be89632aa2f5c2 (commit) via 7b2e3cc63b6dc38a458524a4edcdd43fe967098b (commit) via a5c6ae69f3f773ade65f94b26a79adfbe64dff66 (commit) via 371f06d005692aa6e0c48a84fe08c5dfddb22c59 (commit) via a06e49cf108488a30c0bdb168ada7653a3a737e0 (commit) from 16602e1cd2480e8406acc4233825469339f458f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=86bf8afb4c085aef5e67bf8f37be89632aa2f5c2 commit 86bf8afb4c085aef5e67bf8f37be89632aa2f5c2 Merge: 16602e1 7b2e3cc Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 11:23:51 2014 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Tue Sep 9 11:23:51 2014 -0400 Merge branch 'master' into next --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.0.1-5257-gdf87e21
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via df87e21c08e3845db5783d17b1a27a3e170738cd (commit) via d9bfa446f3ea90cb9b4f4dc656403a287d9a11ca (commit) via 4811915367cc23e68e2171b83509b8a382ff1941 (commit) from 2ead3dfac090d11db6b66f8764d600c459c8aab7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=df87e21c08e3845db5783d17b1a27a3e170738cd commit df87e21c08e3845db5783d17b1a27a3e170738cd Merge: 2ead3df d9bfa44 Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 11:26:04 2014 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Tue Sep 9 11:26:04 2014 -0400 Merge topic 'test-release' into next d9bfa446 Merge branch 'release' into test-release 48119153 CMake 3.0.2 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d9bfa446f3ea90cb9b4f4dc656403a287d9a11ca commit d9bfa446f3ea90cb9b4f4dc656403a287d9a11ca Merge: 21ece15 4811915 Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 11:25:32 2014 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Tue Sep 9 11:25:32 2014 -0400 Merge branch 'release' into test-release http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4811915367cc23e68e2171b83509b8a382ff1941 commit 4811915367cc23e68e2171b83509b8a382ff1941 Author: Brad King brad.k...@kitware.com AuthorDate: Mon Sep 8 16:39:08 2014 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Mon Sep 8 16:39:08 2014 -0400 CMake 3.0.2 diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index 4caa608..0a3c7c1 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -1,5 +1,5 @@ # CMake version number components. set(CMake_VERSION_MAJOR 3) set(CMake_VERSION_MINOR 0) -set(CMake_VERSION_PATCH 1) +set(CMake_VERSION_PATCH 2) #set(CMake_VERSION_RC 0) --- Summary of changes: hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.0.1-5259-gb44bf88
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via b44bf8890f8128b26184cfdf5de58aae13c8157b (commit) via d5047ca1b298a52c605be5f05a6458c8147872ae (commit) from df87e21c08e3845db5783d17b1a27a3e170738cd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b44bf8890f8128b26184cfdf5de58aae13c8157b commit b44bf8890f8128b26184cfdf5de58aae13c8157b Merge: df87e21 d5047ca Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 11:48:37 2014 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Tue Sep 9 11:48:37 2014 -0400 Merge topic 'FindIce-drop-unnecessary-code' into next d5047ca1 FindIce: Remove unneeded search path modification http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d5047ca1b298a52c605be5f05a6458c8147872ae commit d5047ca1b298a52c605be5f05a6458c8147872ae Author: Roger Leigh r.le...@dundee.ac.uk AuthorDate: Tue Sep 9 16:28:11 2014 +0100 Commit: Brad King brad.k...@kitware.com CommitDate: Tue Sep 9 11:45:51 2014 -0400 FindIce: Remove unneeded search path modification Drop code adding redundant /opt/Ice-${ice_version} paths. diff --git a/Modules/FindIce.cmake b/Modules/FindIce.cmake index c437a40..50bc60e 100644 --- a/Modules/FindIce.cmake +++ b/Modules/FindIce.cmake @@ -242,13 +242,6 @@ function(_Ice_FIND) message(STATUS Ice version: ${Ice_VERSION_SLICE2CPP_FULL}) - # The following searches prefer the version found; note reverse - # order due to prepending. - if(NOT MSVC) -list(INSERT ice_roots 0 /opt/Ice-${Ice_VERSION_SLICE2CPP_SHORT}) -list(INSERT ice_roots 0 /opt/Ice-${Ice_VERSION_SLICE2CPP_FULL}) - endif() - # Find include directory find_path(Ice_INCLUDE_DIR NAMES Ice/Ice.h --- Summary of changes: Modules/FindIce.cmake |7 --- 1 file changed, 7 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.0.1-5261-g621bd88
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 621bd8816e011ac621d8db317b391be0e25d3045 (commit) via db5a30b58946e4aa114ba778c74ffdeb2175106d (commit) from b44bf8890f8128b26184cfdf5de58aae13c8157b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=621bd8816e011ac621d8db317b391be0e25d3045 commit 621bd8816e011ac621d8db317b391be0e25d3045 Merge: b44bf88 db5a30b Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 15:06:49 2014 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Tue Sep 9 15:06:49 2014 -0400 Merge topic 'vs-generator-platform' into next db5a30b5 enable_language: Initialize system-specific generator info only once http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=db5a30b58946e4aa114ba778c74ffdeb2175106d commit db5a30b58946e4aa114ba778c74ffdeb2175106d Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 15:01:51 2014 -0400 Commit: Brad King brad.k...@kitware.com CommitDate: Tue Sep 9 15:04:07 2014 -0400 enable_language: Initialize system-specific generator info only once Call SetSystemName, SetGeneratorPlatform, and SetGeneratorToolset exactly once after reading CMakeSystem.cmake, and not again on another call to enable_language() or project(). diff --git a/Source/cmGlobalGenerator.cxx b/Source/cmGlobalGenerator.cxx index 90fd3f3..4375114 100644 --- a/Source/cmGlobalGenerator.cxx +++ b/Source/cmGlobalGenerator.cxx @@ -438,7 +438,8 @@ cmGlobalGenerator::EnableLanguage(std::vectorstd::stringconst languages, // try and load the CMakeSystem.cmake if it is there std::string fpath = rootBin; - if(!mf-GetDefinition(CMAKE_SYSTEM_LOADED)) + bool const readCMakeSystem = !mf-GetDefinition(CMAKE_SYSTEM_LOADED); + if(readCMakeSystem) { fpath += /CMakeSystem.cmake; if(cmSystemTools::FileExists(fpath.c_str())) @@ -472,28 +473,31 @@ cmGlobalGenerator::EnableLanguage(std::vectorstd::stringconst languages, mf-ReadListFile(0,fpath.c_str()); } - // Tell the generator about the target system. - std::string system = mf-GetSafeDefinition(CMAKE_SYSTEM_NAME); - if(!this-SetSystemName(system, mf)) + if(readCMakeSystem) { -cmSystemTools::SetFatalErrorOccured(); -return; -} +// Tell the generator about the target system. +std::string system = mf-GetSafeDefinition(CMAKE_SYSTEM_NAME); +if(!this-SetSystemName(system, mf)) + { + cmSystemTools::SetFatalErrorOccured(); + return; + } - // Tell the generator about the platform, if any. - std::string platform = mf-GetSafeDefinition(CMAKE_GENERATOR_PLATFORM); - if(!this-SetGeneratorPlatform(platform, mf)) -{ -cmSystemTools::SetFatalErrorOccured(); -return; -} +// Tell the generator about the platform, if any. +std::string platform = mf-GetSafeDefinition(CMAKE_GENERATOR_PLATFORM); +if(!this-SetGeneratorPlatform(platform, mf)) + { + cmSystemTools::SetFatalErrorOccured(); + return; + } - // Tell the generator about the toolset, if any. - std::string toolset = mf-GetSafeDefinition(CMAKE_GENERATOR_TOOLSET); - if(!this-SetGeneratorToolset(toolset, mf)) -{ -cmSystemTools::SetFatalErrorOccured(); -return; +// Tell the generator about the toolset, if any. +std::string toolset = mf-GetSafeDefinition(CMAKE_GENERATOR_TOOLSET); +if(!this-SetGeneratorToolset(toolset, mf)) + { + cmSystemTools::SetFatalErrorOccured(); + return; + } } // Load the system specific initialization if not yet loaded --- Summary of changes: Source/cmGlobalGenerator.cxx | 44 +++--- 1 file changed, 24 insertions(+), 20 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, next, updated. v3.0.1-5263-g5c6635d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, next has been updated via 5c6635d90de331677ae75f436d82239e1496998b (commit) via 2131aeddaa6e9db8f9671bdee0358039fb570b4a (commit) from 621bd8816e011ac621d8db317b391be0e25d3045 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5c6635d90de331677ae75f436d82239e1496998b commit 5c6635d90de331677ae75f436d82239e1496998b Merge: 621bd88 2131aed Author: Brad King brad.k...@kitware.com AuthorDate: Tue Sep 9 15:20:00 2014 -0400 Commit: CMake Topic Stage kwro...@kitware.com CommitDate: Tue Sep 9 15:20:00 2014 -0400 Merge topic 'FindIce-updates' into next 2131aedd FindIce: Respect Ice_FIND_QUIETLY when printing messages http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2131aeddaa6e9db8f9671bdee0358039fb570b4a commit 2131aeddaa6e9db8f9671bdee0358039fb570b4a Author: Roger Leigh rle...@codelibre.net AuthorDate: Tue Sep 9 18:48:28 2014 + Commit: Brad King brad.k...@kitware.com CommitDate: Tue Sep 9 15:19:00 2014 -0400 FindIce: Respect Ice_FIND_QUIETLY when printing messages diff --git a/Modules/FindIce.cmake b/Modules/FindIce.cmake index 50bc60e..60a4107 100644 --- a/Modules/FindIce.cmake +++ b/Modules/FindIce.cmake @@ -240,7 +240,9 @@ function(_Ice_FIND) set(Ice_VERSION ${Ice_VERSION_SLICE2CPP_FULL} PARENT_SCOPE) endif() - message(STATUS Ice version: ${Ice_VERSION_SLICE2CPP_FULL}) + if(NOT Ice_FIND_QUIETLY) +message(STATUS Ice version: ${Ice_VERSION_SLICE2CPP_FULL}) + endif() # Find include directory find_path(Ice_INCLUDE_DIR @@ -305,17 +307,19 @@ function(_Ice_FIND) set(_Ice_REQUIRED_LIBS_FOUND ${Ice_REQUIRED_LIBS_FOUND} PARENT_SCOPE) set(Ice_LIBRARY ${Ice_LIBRARY} PARENT_SCOPE) - if(Ice_LIBS_FOUND) -message(STATUS Found the following Ice libraries:) -foreach(found ${Ice_LIBS_FOUND}) - message(STATUS ${found}) -endforeach() - endif() - if(Ice_LIBS_NOTFOUND) -message(STATUS The following Ice libraries were not found:) -foreach(notfound ${Ice_LIBS_NOTFOUND}) - message(STATUS ${notfound}) -endforeach() + if(NOT Ice_FIND_QUIETLY) +if(Ice_LIBS_FOUND) + message(STATUS Found the following Ice libraries:) + foreach(found ${Ice_LIBS_FOUND}) +message(STATUS ${found}) + endforeach() +endif() +if(Ice_LIBS_NOTFOUND) + message(STATUS The following Ice libraries were not found:) + foreach(notfound ${Ice_LIBS_NOTFOUND}) +message(STATUS ${notfound}) + endforeach() +endif() endif() if(Ice_DEBUG) --- Summary of changes: Modules/FindIce.cmake | 28 1 file changed, 16 insertions(+), 12 deletions(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits
[Cmake-commits] CMake branch, master, updated. v3.0.1-1839-ge03b474
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project CMake. The branch, master has been updated via e03b474fa83a1d17f0c74fc0b046a2eeedf13b60 (commit) from 21ece15342afca12d473c58fd9b118768ef5f81c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e03b474fa83a1d17f0c74fc0b046a2eeedf13b60 commit e03b474fa83a1d17f0c74fc0b046a2eeedf13b60 Author: Kitware Robot kwro...@kitware.com AuthorDate: Wed Sep 10 00:01:10 2014 -0400 Commit: Kitware Robot kwro...@kitware.com CommitDate: Wed Sep 10 00:01:10 2014 -0400 CMake Nightly Date Stamp diff --git a/Source/CMakeVersion.cmake b/Source/CMakeVersion.cmake index 7a3d4ab..bf9c804 100644 --- a/Source/CMakeVersion.cmake +++ b/Source/CMakeVersion.cmake @@ -1,5 +1,5 @@ # CMake version number components. set(CMake_VERSION_MAJOR 3) set(CMake_VERSION_MINOR 0) -set(CMake_VERSION_PATCH 20140909) +set(CMake_VERSION_PATCH 20140910) #set(CMake_VERSION_RC 1) --- Summary of changes: Source/CMakeVersion.cmake |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- CMake ___ Cmake-commits mailing list Cmake-commits@cmake.org http://public.kitware.com/mailman/listinfo/cmake-commits