Re: [cmake-developers] C++11 all features available?

[Daniel Pfeifer]

On Mon, Aug 21, 2017 at 4:32 PM, Sebastian Holtermann 
wrote:

> Am Montag, 21. August 2017, 10:04:28 CEST schrieben Sie:
> > On 08/21/2017 09:53 AM, Sebastian Holtermann wrote:
> > > it looks like C++11 is now a requirement for CMake itself.
> >
> > Yes.  We just merged this:
> >
> >   https://gitlab.kitware.com/cmake/cmake/merge_requests/1132
> >
> > but you beat us to the announcement.
>
> I saw the MR last week and was delighted. The iterator type naming in `for`
> loops drove me mad.


Feel free to use `auto`, but you will need to hold off range based for
loops.


> > > But does this mean *all* the nice features from the std library can be
> > > used?
> > Not all.  We're still limited by some of the older C++11 compilers.
> > We'll have to see how things go on nightly builds.  As limitations
> > are found they can be documented in `Help/dev/source.rst`.
>

Please have a look at the nightly testers on
https://open.cdash.org/index.php?project=CMake and compare the feature
availability here: Please see
http://en.cppreference.com/w/cpp/compiler_support

Currently CMake is still built with Visual Studio 2010, ie. MSVC 16.0.

That means we should be able to use auto, nullptr, lambdas, std::array,
std::function, type traits, trailing return types, r-values, ...

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Future of ccmake and cmake-gui

[Daniel Pfeifer]

Hi,

With !977 merged, it is possible to base ccmake and cmake-gui on top of the
cmake server.
For demonstration, I copied the contents of the Source/CursesDialog
directory and added a proxy implementation of the classes `cmake` and
`cmState`. The result is 100% compatible with `ccmake`. The same would be
possible with cmake-gui.

Shall we proceed in this direction?

To make the server available everywhere, we should backport the code from
C++14 to C++11. I think this is limited to replacing `std::make_shared`.

For cmake-gui, the proxies could use Qt functionality (QProcess,
QJsonDocument, etc.). As a result, cmake-gui would not have any build
dependencies apart from Qt.

It might be worth considering to move ccmake and cmake-gui to their own
repositories.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] CMake PCH Prototype

[Daniel Pfeifer]

Hi Julian,

I have rebased my old precompiled-headers branch on master and created a
work-in-progress merge-request here:
https://gitlab.kitware.com/cmake/cmake/merge_requests/984

Cheers, Daniel


2017-06-15 13:38 GMT+02:00 Julian Landesberger :

> Hallo Daniel,
>
> wir hatten uns nach deinem Meetup-Vortrag letzte Woche kurz über die
> Verwaltung von precompiled headers in CMake unterhalten. Du meintest
> damals, du hättest bereits eine Art Prototyp dafür geschrieben, der aber
> noch nicht an "großen" Projekten getestet wurde, und, dass du ihn dafür zur
> Verfügung stellen könntest.
> Ich würde den Prototypen gerne am Simulationscode des Lehrstuhls für
> Computation in Engineering der TU München ausprobieren. Der hat immerhin
> über 6000 source- und header-Dateien, ist also kein kompaktes
> Beispielprojekt mehr.
>
> Würde mich freuen wenn wir da was machen könnten und beste Grüße!
>
> Julian Landesberger
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Splitting CMakeLib

[Daniel Pfeifer]

On Wed, May 10, 2017 at 4:56 PM, Egor Pugin  wrote:

> Hi!
>
> I'd like to re-use some CMake internal components, but CMakeLib looks too
> fat.
> Is it possible to split it into several libraries? Are such changes
> welcome to contribute?
>

Strongly in favor. Such a modularization will be a benefit for CMake. It
will require to cleanup CMake's internal inter-dependencies and it will
help to keep them clean afterwards.
It will make CMake's codebase easier to approach by new contributors. It
will allow experiments like replacing individual parts (eg. new frontend).
Let's learn from LLVM/Clang.


> Some rough plan:
> 1) Support library (if any stuff)
> 2) Core library (targets etc.)
> 3) Generators library
> 4) CMake syntax library (lexer, parser)
> 5) Commands implementation library (could be merged with 4)
>

Don't merge the commands with the command interpreter/vm.

5) Scripting commands
6) Project commands
7) CTest commands
8) Package generators
9) Server
...

True cmake power is in its generators. It's always possible to rip off
> all other stuff, but in order to be tied with mainstream and
> contribute back, I'm asking this.
>

Personally, I regard the generators as obsolete and see the future in the
server.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Can we please require TR1 to build CMake?

[Daniel Pfeifer]

On Mon, Jan 9, 2017 at 8:30 PM, Brad King <brad.k...@kitware.com> wrote:

> On 01/09/2017 05:46 AM, Daniel Pfeifer wrote:
> > start using TR1/C++11 library features, namely std::function, std::bind,
> > std::placeholders, std::shared_ptr, std::make_shared.
>
> I'd love to be able to start using those too, but last time I checked
> they are not supported everywhere CMake builds, at least in the standard
> libraries (see below).
>
> > AIX-7.1_IBM-12.1 reports that __IBMCPP_TR1__ must be defined to use TR1.
>
> Hopefully, but that would take some investigation.
>
> > Xcode 2.1 and 3.2 fail. These builds are not marked as "expected".
>
> I'd be okay with dropping these.
>
> > This leaves HP-UX.11iv2.ia64-aCC and Solaris-10-8.11_Oracle-12.3.
>
> IIUC the Oracle compiler supports C++11 when told to use the proper
> stdlib.  However, I don't think there is a solution on HP-UX with its
> standard library.
>
> > * Explicitly require SP1 for Visual Studio 2008.
>
> Okay.  For hosting CMake's own build we could even consider requiring
> VS 2010.  One blocker for that on Kitware's side is updating our
> dashboard machines as needed to be able to host CMake builds even if
> testing generators for older versions.  I'm not sure when I'll have
> time to do that.
>
> > * Disallow compiling in C++98 mode if compiler is capable of C++11.
>
> Okay.
>
> > * Require TR1 by all means. This may require setting up Boost.TR1
> >   on a very small number of exotic platforms.
>
> IIRC there is a tool to extract a subset of boost.  Please see how
> small it can get.  We can even remove the config headers for the
> platforms we don't need to use it, perhaps manually.
>

I have pushed an updated branch to
https://gitlab.kitware.com/cmake/cmake/merge_requests/760/diffs

The necessary subset of boost can be generated with:

```
mkdir -p cm_boost
bcp --boost= \
  boost/bind.hpp \
  boost/function.hpp \
  boost/mem_fn.hpp \
  boost/ref.hpp \
  boost/unordered_map.hpp \
  boost/unordered_set.hpp \
  boost/shared_ptr.hpp \
  boost/weak_ptr.hpp \
  boost/enable_shared_from_this.hpp \
  cm_boost
```

The resulting directory is 6.5 MB, 2.6 MB of which are preprocessed headers
for Boost.MPL.
When we remove them, we get the size down to 3.9 MB.
Removing individual config headers is tedious and does not save much.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Where execute_process INPUT_CONTENT or INPUT_VARIABLE?

[Daniel Pfeifer]

On Mon, Apr 24, 2017 at 3:03 PM, Brad King  wrote:

> On 04/23/2017 01:30 AM, Konstantin Podsvirov wrote:
> > Where execute_process INPUT_CONTENT or INPUT_VARIABLE?
> >
> > This would be very convenient for a small input.
> >
> > Why should I always write a file for input?
>
> I agree that the options should be there but they can't be easily
> implemented without choosing our own temporary file which will have
> its own problems.
>
> The reason is that our internal process execution implementation
> does not support communication from the parent on stdin.  Fixing
> that is not something I'm prepared to do or even accept as a
> contribution because I'd rather migrate to libuv than extend our
> own process management implementation further.


Brad, can you share what the current status is on this? If I remember
correctly, then libuv cannot be built yet on all necessary compilers. Is
that still the case? This sounds like the biggest impediment. Once we can
rely on libuv, we can also use it for filesystem operations. This would
help solve issues like #13162.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Support for version suffixes

[Daniel Pfeifer]

On Mon, Mar 27, 2017 at 11:03 PM, Roger Leigh  wrote:

> Hi folks,
>
> I'd like to bring this issue to your attention to canvas some feedback
> regarding the use of version suffixes:
>
>   https://gitlab.kitware.com/cmake/cmake/issues/16716
>
> This is basically a proposal to allow an optional version suffix like
> "-rc3", "-beta1" etc. in addition to the existing major.minor.patch.tweak
> pattern, for better interoperability with systems and software releases
> already using such suffixes, and also to permit the use of such suffixes by
> CMake projects for their own purposes.  A version suffix would be usable
> anywhere currently using 4 digit versions, with all the necessary
> functionality in CMake being updated to handle this.
>
> The proposal linked above contains a much more detailed rationale and
> suggested implementation strategy.  I'd be very happy to hear any thoughts
> anyone has regarding this either on the above issue, or here.
>

Hi Roger,

Thanks for starting this discussion!

I started a prototype for a PKGCONF mode for find_package in addition to
CONFIG and PACKAGE. In this mode, CMake parses .pc files and creates one
imported target per file where values from the .pc file are set as target
properties. It works pretty well and does not rely on pkg-config. To be
compatible with pkg-config, I needed to extend
`cmSystemTools::VersionCompare`, because pkg-config uses RPM version
comparison. This however breaks current tests because 1.2 != 1.2.0 in the
RPM version comparison.

It might be necessary to provide several version comparison algorithms like
Debian, RPM, Semver.
Also splitting the version string into components may depend on the
versioning scheme. Given OpenSSL version 1.0.2g, is that patch 2 suffix g,
or rather patch 2g?

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Build multiple CMake projects

[Daniel Pfeifer]

On Fri, Mar 24, 2017 at 7:35 PM,  wrote:

> Hi,
>
> I have some CMake projects which depend on each other. They provide Config
> scripts (all generated with the help of CMakePackageConfigHelpers) and the
> CMake projects find there dependencies with find_package(). Even the
> transitive dependencies are correctly modelled (exported to the Config
> scripts with find_dependency).
>
> The setup in general is fine. The only drawback is that I have to build
> and install them manually in the correct order. For example A depends on B
> depends on C, I have to build+install first C, than B, then A ...
>
> The number of projects are getting more and more and it's getting harder
> to build them.
>
> So my question:
> a) Is there a CMake way to generate a dependency graph and build them in
> the correct order, i.e., the same as CMake does within a project with the
> targets but this time on project level?
> b) What possiblities are provided by CMake to support this?
> c) Are there tools you can recommend?
>

Make sure that your projects can be used both as a sub-project and as a
installed package. That means: if the installed package provides a target
called C::C, create an alias target with that name, so that projects A and
B can use that name in target_link_libraries in both cases.
The next thing is to make sure that `find_package(C REQUIRED)` finds the
installed package when it supposed to be used, but does nothing when C is
used as a sub-project. This can be achieved by overriding the
`find_package` command. The original command can be called by prefixing it
with _. Your top-level project might look like this:

set(subprojects A B C)

macro(find_package name)
  if("${name}" IN_LIST subprojects)
set("${name}_FOUND" TRUE)
  else()
_find_package("${name}" ${ARGN})
  endif()
endmacro()

add_subdirectory(A)
add_subdirectory(B)
add_subdirectory(C)
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.8.0-rc1-716-g6a1c761

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  6a1c76184210f5dc289293bb27d5d322c0a5f67d (commit)
   via  e1418249313f35511a3162242d626785e4f51144 (commit)
  from  a1cca83f3823109ad2728c3664b8895b5b528244 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6a1c76184210f5dc289293bb27d5d322c0a5f67d
commit 6a1c76184210f5dc289293bb27d5d322c0a5f67d
Merge: a1cca83 e141824
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Mar 1 17:25:41 2017 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Mar 1 17:25:41 2017 -0500

Merge topic 'modernize-deprecated-headers' into next

e1418249 Modernize deprecated headers


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e1418249313f35511a3162242d626785e4f51144
commit e1418249313f35511a3162242d626785e4f51144
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Mar 1 23:23:09 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Mar 1 23:23:09 2017 +0100

Modernize deprecated headers

Replace C standard library headers in C++ code with their C++
alternatives.

diff --git a/Source/CPack/IFW/cmCPackIFWInstaller.cxx 
b/Source/CPack/IFW/cmCPackIFWInstaller.cxx
index d8bafee..71814bb 100644
--- a/Source/CPack/IFW/cmCPackIFWInstaller.cxx
+++ b/Source/CPack/IFW/cmCPackIFWInstaller.cxx
@@ -3,8 +3,8 @@
 #include "cmCPackIFWInstaller.h"
 
 #include 
+#include 
 #include 
-#include 
 #include 
 
 #include "CPack/cmCPackGenerator.h"
diff --git a/Source/CPack/IFW/cmCPackIFWPackage.cxx 
b/Source/CPack/IFW/cmCPackIFWPackage.cxx
index e23b1b9..7bf34ce 100644
--- a/Source/CPack/IFW/cmCPackIFWPackage.cxx
+++ b/Source/CPack/IFW/cmCPackIFWPackage.cxx
@@ -13,9 +13,9 @@
 #include "cmXMLWriter.h"
 
 #include 
+#include 
 #include 
 #include 
-#include 
 
 //- Logger ---
 #ifdef cmCPackLogger
diff --git a/Source/CPack/IFW/cmCPackIFWRepository.cxx 
b/Source/CPack/IFW/cmCPackIFWRepository.cxx
index cc204e8..ed4cb4e 100644
--- a/Source/CPack/IFW/cmCPackIFWRepository.cxx
+++ b/Source/CPack/IFW/cmCPackIFWRepository.cxx
@@ -10,7 +10,7 @@
 #include "cmXMLWriter.h"
 
 #include 
-#include 
+#include 
 
 #ifdef cmCPackLogger
 #undef cmCPackLogger
diff --git a/Source/CPack/OSXScriptLauncher.cxx 
b/Source/CPack/OSXScriptLauncher.cxx
index b159e64..689633a 100644
--- a/Source/CPack/OSXScriptLauncher.cxx
+++ b/Source/CPack/OSXScriptLauncher.cxx
@@ -3,8 +3,8 @@
 #include 
 #include 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/Source/CPack/cmCPackDebGenerator.cxx 
b/Source/CPack/cmCPackDebGenerator.cxx
index 5c50da8..28b5a78 100644
--- a/Source/CPack/cmCPackDebGenerator.cxx
+++ b/Source/CPack/cmCPackDebGenerator.cxx
@@ -9,13 +9,13 @@
 #include "cmGeneratedFileStream.h"
 #include "cmSystemTools.h"
 
+#include 
 #include 
-#include 
+#include 
+#include 
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
 
diff --git a/Source/CPack/cmCPackDragNDropGenerator.cxx 
b/Source/CPack/cmCPackDragNDropGenerator.cxx
index ec5fc88..df6ee22 100644
--- a/Source/CPack/cmCPackDragNDropGenerator.cxx
+++ b/Source/CPack/cmCPackDragNDropGenerator.cxx
@@ -9,9 +9,9 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
-#include 
 
 #include 
 
diff --git a/Source/CPack/cmCPackDragNDropGenerator.h 
b/Source/CPack/cmCPackDragNDropGenerator.h
index 876eab7..0e7b9f4 100644
--- a/Source/CPack/cmCPackDragNDropGenerator.h
+++ b/Source/CPack/cmCPackDragNDropGenerator.h
@@ -4,8 +4,8 @@
 #define cmCPackDragNDropGenerator_h
 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/Source/CPack/cmCPackLog.h b/Source/CPack/cmCPackLog.h
index a988ccc..d699f05 100644
--- a/Source/CPack/cmCPackLog.h
+++ b/Source/CPack/cmCPackLog.h
@@ -5,8 +5,8 @@
 
 #include  // IWYU pragma: keep
 
+#include 
 #include 
-#include 
 #include 
 
 #define cmCPack_Log(ctSelf, logType, msg) \
diff --git a/Source/CPack/cmCPackNSISGenerator.cxx 
b/Source/CPack/cmCPackNSISGenerator.cxx
index 1940953..690f6f3 100644
--- a/Source/CPack/cmCPackNSISGenerator.cxx
+++ b/Source/CPack/cmCPackNSISGenerator.cxx
@@ -11,10 +11,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
-#include 
-#include 
 #include 
 
 /* NSIS uses different command line syntax on Windows and others */
diff --git a/Source/CPack/cmCPackPackageMakerGenerator.cxx 
b/

[Cmake-commits] CMake branch, next, updated. v3.8.0-rc1-254-ge939f8b

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  e939f8b18003e9b3fd2e2f398d3a2a0f8e5a46ad (commit)
   via  89541d043d1d53b1a6c1082a9e9574b16165562d (commit)
   via  a3ff237a5c221be52bbd2cf7b526fd19b5202a35 (commit)
  from  b7af957834c120064057a0180487a56fc12ec7e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e939f8b18003e9b3fd2e2f398d3a2a0f8e5a46ad
commit e939f8b18003e9b3fd2e2f398d3a2a0f8e5a46ad
Merge: b7af957 89541d0
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Feb 17 16:51:06 2017 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Feb 17 16:51:06 2017 -0500

Merge topic 'iwyu' into next

89541d04 fixup! cmFortranParser: include what you use
a3ff237a ParserHelper: Move macros to bottom of files


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=89541d043d1d53b1a6c1082a9e9574b16165562d
commit 89541d043d1d53b1a6c1082a9e9574b16165562d
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Feb 17 22:49:24 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Feb 17 22:49:24 2017 +0100

fixup! cmFortranParser: include what you use

diff --git a/Source/cmFortranParser.cxx b/Source/cmFortranParser.cxx
index 45d9639..c67227f 100644
--- a/Source/cmFortranParser.cxx
+++ b/Source/cmFortranParser.cxx
@@ -97,7 +97,7 @@ Modify cmFortranParser.cxx:
   - "#if 0" out yyerrorlab block in range ["goto yyerrlab1", "yyerrlab1:"]
 */
 
-#include 
+#include  // IWYU pragma: keep
 
 #include 
 #include 
diff --git a/Source/cmFortranParser.y b/Source/cmFortranParser.y
index be4959c..3d68134 100644
--- a/Source/cmFortranParser.y
+++ b/Source/cmFortranParser.y
@@ -26,7 +26,7 @@ Modify cmFortranParser.cxx:
   - "#if 0" out yyerrorlab block in range ["goto yyerrlab1", "yyerrlab1:"]
 */
 
-#include 
+#include  // IWYU pragma: keep
 
 #include 
 #include 
diff --git a/Source/cmFortranParserTokens.h b/Source/cmFortranParserTokens.h
index 18b9e0a..8d6a5fe 100644
--- a/Source/cmFortranParserTokens.h
+++ b/Source/cmFortranParserTokens.h
@@ -130,7 +130,7 @@ extern int cmFortran_yydebug;
 
 union YYSTYPE
 {
-#line 75 "cmFortranParser.y" /* yacc.c:1909  */
+#line 70 "cmFortranParser.y" /* yacc.c:1909  */
 
   char* string;
 

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a3ff237a5c221be52bbd2cf7b526fd19b5202a35
commit a3ff237a5c221be52bbd2cf7b526fd19b5202a35
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Feb 17 22:43:43 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Feb 17 22:43:43 2017 +0100

ParserHelper: Move macros to bottom of files

Since the class name is used in the macros, the iwyu tool gets confused
wheter it needs a forward declaration or not.

While editing the files, make sure structs have no typedef.  Also,
remove confusing comments about Java.

diff --git a/Source/cmCommandArgumentParserHelper.h 
b/Source/cmCommandArgumentParserHelper.h
index 95bf0ad..5bfb236 100644
--- a/Source/cmCommandArgumentParserHelper.h
+++ b/Source/cmCommandArgumentParserHelper.h
@@ -8,27 +8,15 @@
 #include 
 #include 
 
-#define YYSTYPE cmCommandArgumentParserHelper::ParserType
-#define YYSTYPE_IS_DECLARED
-#define YY_EXTRA_TYPE cmCommandArgumentParserHelper*
-#define YY_DECL   \
-  int cmCommandArgument_yylex(YYSTYPE* yylvalp, yyscan_t yyscanner)
-
-/** \class cmCommandArgumentParserHelper
- * \brief Helper class for parsing java source files
- *
- * Finds dependencies for java file and list of outputs
- */
-
 class cmMakefile;
 
 class cmCommandArgumentParserHelper
 {
 public:
-  typedef struct
+  struct ParserType
   {
 char* str;
-  } ParserType;
+  };
 
   cmCommandArgumentParserHelper();
   ~cmCommandArgumentParserHelper();
@@ -100,4 +88,10 @@ private:
   bool RemoveEmpty;
 };
 
+#define YYSTYPE cmCommandArgumentParserHelper::ParserType
+#define YYSTYPE_IS_DECLARED
+#define YY_EXTRA_TYPE cmCommandArgumentParserHelper*
+#define YY_DECL   \
+  int cmCommandArgument_yylex(YYSTYPE* yylvalp, yyscan_t yyscanner)
+
 #endif
diff --git a/Source/cmDependsJavaParserHelper.h 
b/Source/cmDependsJavaParserHelper.h
index 71b939c..5f28f70 100644
--- a/Source/cmDependsJavaParserHelper.h
+++ b/Source/cmDependsJavaParserHelper.h
@@ -8,26 +8,18 @@
 #include 
 #include 
 
-class cmDependsJavaParserHelper;
-
-#defi

[Cmake-commits] CMake branch, next, updated. v3.8.0-rc1-117-gd358f8b

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  d358f8bba5418d0a8e95bd5efe0a913b8acb2a13 (commit)
   via  e0f3931226d6f947572bce7a4b98c55812bba105 (commit)
   via  72dcbbe5c017a4c071187259f9594ccf02f7b466 (commit)
   via  7fb14775a3cce73dc0cb0d759b96059a95f7104b (commit)
   via  615e2a17e499b2bd53cce8da1a0cfae36d67b24a (commit)
   via  45b49099d9dd034fd1e7344b3bae88b0e3d3427a (commit)
   via  5396bc92d0162fa9a9462e15ccaae8764da8ff98 (commit)
  from  d8aec3f2d5478ffb7235b638d33d08e944093916 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d358f8bba5418d0a8e95bd5efe0a913b8acb2a13
commit d358f8bba5418d0a8e95bd5efe0a913b8acb2a13
Merge: d8aec3f e0f3931
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Feb 13 17:29:12 2017 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Feb 13 17:29:12 2017 -0500

Merge topic 'command-cleanup' into next

e0f39312 cmCommands: add commands directly to cmState
72dcbbe5 split Default commands into Scripting and Project
7fb14775 cmDisallowedCommand: extract policy checking from cmCommand
615e2a17 cmCommand: Don't prefix error message with command name
45b49099 cmCommand: make noncopyable
5396bc92 cmCommand: remove member Helper


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e0f3931226d6f947572bce7a4b98c55812bba105
commit e0f3931226d6f947572bce7a4b98c55812bba105
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Jan 20 22:40:16 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Feb 13 22:39:20 2017 +0100

cmCommands: add commands directly to cmState

diff --git a/Source/cmCommands.cxx b/Source/cmCommands.cxx
index 64cd12e..b58dc62 100644
--- a/Source/cmCommands.cxx
+++ b/Source/cmCommands.cxx
@@ -1,6 +1,7 @@
 /* Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmCommands.h"
+#include "cmState.h"
 
 #include "cmAddCustomCommandCommand.h"
 #include "cmAddCustomTargetCommand.h"
@@ -105,170 +106,162 @@
 #include "cmWriteFileCommand.h"
 #endif
 
-std::vector<cmCommand*> GetScriptingCommands()
+void GetScriptingCommands(cmState* state)
 {
-  std::vector<cmCommand*> commands;
+  state->AddCommand(new cmBreakCommand);
+  state->AddCommand(new cmCMakeMinimumRequired);
+  state->AddCommand(new cmCMakePolicyCommand);
+  state->AddCommand(new cmConfigureFileCommand);
+  state->AddCommand(new cmContinueCommand);
+  state->AddCommand(new cmExecProgramCommand);
+  state->AddCommand(new cmExecuteProcessCommand);
+  state->AddCommand(new cmFileCommand);
+  state->AddCommand(new cmFindFileCommand);
+  state->AddCommand(new cmFindLibraryCommand);
+  state->AddCommand(new cmFindPackageCommand);
+  state->AddCommand(new cmFindPathCommand);
+  state->AddCommand(new cmFindProgramCommand);
+  state->AddCommand(new cmForEachCommand);
+  state->AddCommand(new cmFunctionCommand);
+  state->AddCommand(new cmGetCMakePropertyCommand);
+  state->AddCommand(new cmGetDirectoryPropertyCommand);
+  state->AddCommand(new cmGetFilenameComponentCommand);
+  state->AddCommand(new cmGetPropertyCommand);
+  state->AddCommand(new cmIfCommand);
+  state->AddCommand(new cmIncludeCommand);
+  state->AddCommand(new cmListCommand);
+  state->AddCommand(new cmMacroCommand);
+  state->AddCommand(new cmMakeDirectoryCommand);
+  state->AddCommand(new cmMarkAsAdvancedCommand);
+  state->AddCommand(new cmMathCommand);
+  state->AddCommand(new cmMessageCommand);
+  state->AddCommand(new cmOptionCommand);
+  state->AddCommand(new cmParseArgumentsCommand);
+  state->AddCommand(new cmReturnCommand);
+  state->AddCommand(new cmSeparateArgumentsCommand);
+  state->AddCommand(new cmSetCommand);
+  state->AddCommand(new cmSetDirectoryPropertiesCommand);
+  state->AddCommand(new cmSetPropertyCommand);
+  state->AddCommand(new cmSiteNameCommand);
+  state->AddCommand(new cmStringCommand);
+  state->AddCommand(new cmUnsetCommand);
+  state->AddCommand(new cmWhileCommand);
 
-  commands.push_back(new cmBreakCommand);
-  commands.push_back(new cmCMakeMinimumRequired);
-  commands.push_back(new cmCMakePolicyCommand);
-  commands.push_back(new cmConfigureFileCommand);
-  commands.push_back(new cmContinueCommand);
-  commands.push_back(new cmExecProgramCommand);
-  c

[Cmake-commits] CMake branch, next, updated. v3.8.0-rc1-92-g9862605

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  9862605636abde65ca8e651d42b3d706beeaaecc (commit)
   via  a45a5847e096e7f077acb0a4fde44bda9225fbc4 (commit)
  from  4c53c29d86e7dc4c580fb5b7c8f06551934ae03c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9862605636abde65ca8e651d42b3d706beeaaecc
commit 9862605636abde65ca8e651d42b3d706beeaaecc
Merge: 4c53c29 a45a584
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Feb 11 16:10:16 2017 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Feb 11 16:10:16 2017 -0500

Merge topic 'command-cleanup' into next

a45a5847 fixup! split Default commands into Scripting and Project


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a45a5847e096e7f077acb0a4fde44bda9225fbc4
commit a45a5847e096e7f077acb0a4fde44bda9225fbc4
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Feb 11 22:09:37 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Feb 11 22:09:37 2017 +0100

fixup! split Default commands into Scripting and Project

diff --git a/Help/manual/cmake-commands.7.rst b/Help/manual/cmake-commands.7.rst
index 8f019d2..611c989 100644
--- a/Help/manual/cmake-commands.7.rst
+++ b/Help/manual/cmake-commands.7.rst
@@ -113,6 +113,8 @@ These commands are available only in CMake projects.
/command/try_compile
/command/try_run
 
+.. _`CTest Commands`:
+
 CTest Commands
 ==
 

---

Summary of changes:
 Help/manual/cmake-commands.7.rst |2 ++
 1 file changed, 2 insertions(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.8.0-rc1-90-g4c53c29

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  4c53c29d86e7dc4c580fb5b7c8f06551934ae03c (commit)
   via  4ff5dce9f8be34d556f1fb98272a8654b1f6c5bb (commit)
   via  934ac7916e4e4df6ef55441d58fd1c310e4ad9f1 (commit)
   via  717491dd7d4a886d484025fd9002df44458117b5 (commit)
   via  b75e7691425d4cb658f3b0981fdbfbc25dedfb43 (commit)
   via  17926f29cecc7574c9173ff06f5e3d0e4e250b02 (commit)
   via  c1bfff2e72bd673e7b7bebddf58c7ea508bf4196 (commit)
  from  fe4c8e497ce4eb67bd14187f8729710a72cfe37a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4c53c29d86e7dc4c580fb5b7c8f06551934ae03c
commit 4c53c29d86e7dc4c580fb5b7c8f06551934ae03c
Merge: fe4c8e4 4ff5dce
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Feb 10 18:21:19 2017 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Feb 10 18:21:19 2017 -0500

Merge topic 'command-cleanup' into next

4ff5dce9 cmCommands: add commands directly to cmState
934ac791 split Default commands into Scripting and Project
717491dd cmDeprecatedCommand: extract policy checking from cmCommand
b75e7691 cmCommand: Don't prefix error message with command name
17926f29 cmCommand: make noncopyable
c1bfff2e cmCommand: remove member Helper


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4ff5dce9f8be34d556f1fb98272a8654b1f6c5bb
commit 4ff5dce9f8be34d556f1fb98272a8654b1f6c5bb
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Jan 20 22:40:16 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Feb 11 00:20:22 2017 +0100

cmCommands: add commands directly to cmState

diff --git a/Source/cmCommands.cxx b/Source/cmCommands.cxx
index bc24234..9ff395a 100644
--- a/Source/cmCommands.cxx
+++ b/Source/cmCommands.cxx
@@ -1,6 +1,7 @@
 /* Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmCommands.h"
+#include "cmState.h"
 
 #include "cmAddCustomCommandCommand.h"
 #include "cmAddCustomTargetCommand.h"
@@ -105,170 +106,162 @@
 #include "cmWriteFileCommand.h"
 #endif
 
-std::vector<cmCommand*> GetScriptingCommands()
+void GetScriptingCommands(cmState* state)
 {
-  std::vector<cmCommand*> commands;
+  state->AddCommand(new cmBreakCommand);
+  state->AddCommand(new cmCMakeMinimumRequired);
+  state->AddCommand(new cmCMakePolicyCommand);
+  state->AddCommand(new cmConfigureFileCommand);
+  state->AddCommand(new cmContinueCommand);
+  state->AddCommand(new cmExecProgramCommand);
+  state->AddCommand(new cmExecuteProcessCommand);
+  state->AddCommand(new cmFileCommand);
+  state->AddCommand(new cmFindFileCommand);
+  state->AddCommand(new cmFindLibraryCommand);
+  state->AddCommand(new cmFindPackageCommand);
+  state->AddCommand(new cmFindPathCommand);
+  state->AddCommand(new cmFindProgramCommand);
+  state->AddCommand(new cmForEachCommand);
+  state->AddCommand(new cmFunctionCommand);
+  state->AddCommand(new cmGetCMakePropertyCommand);
+  state->AddCommand(new cmGetDirectoryPropertyCommand);
+  state->AddCommand(new cmGetFilenameComponentCommand);
+  state->AddCommand(new cmGetPropertyCommand);
+  state->AddCommand(new cmIfCommand);
+  state->AddCommand(new cmIncludeCommand);
+  state->AddCommand(new cmListCommand);
+  state->AddCommand(new cmMacroCommand);
+  state->AddCommand(new cmMakeDirectoryCommand);
+  state->AddCommand(new cmMarkAsAdvancedCommand);
+  state->AddCommand(new cmMathCommand);
+  state->AddCommand(new cmMessageCommand);
+  state->AddCommand(new cmOptionCommand);
+  state->AddCommand(new cmParseArgumentsCommand);
+  state->AddCommand(new cmReturnCommand);
+  state->AddCommand(new cmSeparateArgumentsCommand);
+  state->AddCommand(new cmSetCommand);
+  state->AddCommand(new cmSetDirectoryPropertiesCommand);
+  state->AddCommand(new cmSetPropertyCommand);
+  state->AddCommand(new cmSiteNameCommand);
+  state->AddCommand(new cmStringCommand);
+  state->AddCommand(new cmUnsetCommand);
+  state->AddCommand(new cmWhileCommand);
 
-  commands.push_back(new cmBreakCommand);
-  commands.push_back(new cmCMakeMinimumRequired);
-  commands.push_back(new cmCMakePolicyCommand);
-  commands.push_back(new cmConfigureFileCommand);
-  commands.push_back(new cmContinueCommand);
-  commands.push_back(new cmExecProgramCommand);
-  c

Re: [cmake-developers] Debugger for CMake

[Daniel Pfeifer]

On Thu, Feb 2, 2017 at 12:02 PM, Milian Wolff  wrote:

> On Dienstag, 31. Januar 2017 20:55:45 CET Justin Berger wrote:
> > > I liked the snapshots that were in Stephen Kelly's daemon-mode patch
> much
> >
> > better than an interactive debugger.
> >
> > I'm not sure these tools have that much use-case overlap. As far as I can
> > tell, snapshots has roughly the same overhead / functionality as
> reversible
> > interactive debuggers; which is non trivial. Which tool is best for a
> given
> > problem seems situational; and having both seems useful.
> >
> > I looked through the code for cmServer, since it maintains an instance of
> > cmake in process, it could register as a debug listener and get events /
> > set breakpoints and all in response to different requests coming in. The
> > issue here though is that it seems like (and maybe this is wrong?) the
> > actual call out to configure blocks on the libuv loop thread so it can't
> > get or process any requests while configure is running; so maybe keeping
> > them as seperate services running on separate loops is better.
> >
> > The only way I could see it making sense to use a completely different
> > protocol would be if there were a semi-standard debugger protocol used in
> > different IDE's for debugging interpreted code, and then I think it makes
> > sense to pursue those. However, I did some research into that and didn't
> > find anything especially relevant -- IDE maintainers would obviously
> have a
> > better sense of that though. Also, even if there is such a thing, there
> is
> > no reason not to support multiple debug protocols; it is just a matter of
> > prioritization.
>
> GDB's MI is a standard protocol used by both clang and LLDB but I think it
> will be overkill for something like CMake. From my POV, CMake is very
> different from a normal application that you may debug. I mean do you
> really
> expect people to go line-by-line through a cmake script to see how it gets
> evaluated?


It depends.

I don't. Rather, I want to see the effect a call has on the CMake
> state, i.e. the approach that Stephen took is far better in my eyes.


I personally could not agree more. But that answer greatly depends on the
way you use CMake. If you use it as a build system generator and write your
CMakeLists.txt files in a clean, modern way, then Steve's approach is
perfect.
However, if you (ab)use CMake as a general purpose scripting language, then
a debugger might be welcome. Have a look at ExternalProject.cmake. You find
even more complex examples in the wild if you google for "cmake package
management".

I am against a debugger in CMake. We should invest in making the clean,
modern approach more clean, more modern, and more pleasant. Using CMake as
a general purpose scripting language should be possible but painful. Like a
continuous question whether you are using the right tool for the job. But
that is just my opinion.

PS: Adding an interactive debugger to the CMake scripting language might
complicate adding new language front-ends. If we allow an alternative
language front-end, you might be able to use existing tools to debug
complicated scripts.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] What should the behaviour of NUMBER_OF_LOGICAL_CORES be?

[Daniel Pfeifer]

Hi,

I agree that it should be total number of cores. In addition,
cmake_host_system_information() might be extended to provide the number of
cores per physical core.
This aligns with the information in the XML procuded by CTest: The Site
element has the attributes NumberOfLogicalCPU, NumberOfPhysicalCPU, and
LogicalProcessorsPerPhysical.

Cheers, Daniel

On Thu, Jan 26, 2017 at 9:56 PM, Nicolás Bértolo 
wrote:

> Hi,
>
> This question comes from https://gitlab.kitware.com/
> cmake/cmake/issues/16594
> Currently cmake_host_system_information(RESULT logical QUERY
> NUMBER_OF_LOGICAL_CORES) is buggy, some parts of the code that implement it
> assume it refers to the number of cores in the system and some assume it is
> the number of cores per physical core. The documentation implies it is the
> total number of cores, but in my system (AMD FX-8320) it is equal to 1 when
> it should be 8.
>
> I have offered myself to fix this bug, but first I would like to know what
> is the correct return value of this call should be.
> Should it return the number of cores per physical core or the total number
> of cores in the system?
>
> I think it should be the latter, but I would like to hear your opinions.
>
> Regards,
> Nicolás.
>
>
>
> --
> [image: Avast logo]
> 
>
> El software de antivirus Avast ha analizado este correo electrónico en
> busca de virus.
> www.avast.com
> 
>
>
> --
>
> Powered by www.kitware.com
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Kitware offers various services to support the CMake community. For more
> information on each offering, please visit:
>
> CMake Support: http://cmake.org/cmake/help/support.html
> CMake Consulting: http://cmake.org/cmake/help/consulting.html
> CMake Training Courses: http://cmake.org/cmake/help/training.html
>
> Visit other Kitware open-source projects at http://www.kitware.com/
> opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/cmake-developers
>
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.7.2-2317-g8708542

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  8708542da2b794a08b11c3ccae91dc927504ae50 (commit)
   via  eb86b4cec14df4a51cca9f178e8e758b97be11b7 (commit)
   via  178c897374718c2b7cfa76f5c016f23658d5d2b2 (commit)
   via  3bb4a798268669ca1364040abb3cfdf4a44c2f92 (commit)
   via  60b68304f25088db12112c47a4599e4fef405429 (commit)
   via  1731b90cd0b8c1c0da2f485a9b43006bb2174150 (commit)
  from  368845459f43438e239663171cb38125915d5080 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8708542da2b794a08b11c3ccae91dc927504ae50
commit 8708542da2b794a08b11c3ccae91dc927504ae50
Merge: 3688454 eb86b4c
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Jan 24 16:36:47 2017 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Jan 24 16:36:47 2017 -0500

Merge topic 'testdriver-cleanup' into next

eb86b4ce TestDriver: fix/silence clang-tidy warnings
178c8973 TestDriver: calc NumTests at compile time
3bb4a798 TestDriver: use for loop
60b68304 TestDriver: abstract CM_CAST macro
1731b90c TestDriver: Revise C++ coding style using clang-format


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=eb86b4cec14df4a51cca9f178e8e758b97be11b7
commit eb86b4cec14df4a51cca9f178e8e758b97be11b7
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Jan 24 22:24:06 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Tue Jan 24 22:24:06 2017 +0100

TestDriver: fix/silence clang-tidy warnings

diff --git a/Templates/TestDriver.cxx.in b/Templates/TestDriver.cxx.in
index 7340842..ecf6fa1 100644
--- a/Templates/TestDriver.cxx.in
+++ b/Templates/TestDriver.cxx.in
@@ -1,7 +1,7 @@
-#include 
-#include 
-#include 
-#include 
+#include   /* NOLINT */
+#include   /* NOLINT */
+#include  /* NOLINT */
+#include  /* NOLINT */
 
 #if defined(_MSC_VER)
 #pragma warning(disable : 4996) /* deprecation */
@@ -29,7 +29,7 @@ typedef struct
 
 static functionMapEntry cmakeGeneratedFunctionMapEntries[] = {
   @CMAKE_FUNCTION_TABLE_ENTIRES@
-  { 0, 0 }
+  { NULL, NULL } /* NOLINT */
 };
 
 static const int NumTests =
@@ -37,7 +37,6 @@ static const int NumTests =
 
 /* Allocate and create a lowercased copy of string
(note that it has to be free'd manually) */
-
 static char* lowercase(const char* string)
 {
   char *new_string, *p;
@@ -46,8 +45,8 @@ static char* lowercase(const char* string)
   stringSize = CM_CAST(size_t, strlen(string) + 1);
   new_string = CM_CAST(char*, malloc(sizeof(char) * stringSize));
 
-  if (!new_string) {
-return 0;
+  if (new_string == NULL) { /* NOLINT */
+return NULL;/* NOLINT */
   }
   strncpy(new_string, string, stringSize);
   for (p = new_string; *p != 0; ++p) {
@@ -87,12 +86,12 @@ int main(int ac, char* av[])
 av++;
   }
   partial_match = 0;
-  arg = 0;
+  arg = NULL; /* NOLINT */
   /* If partial match is requested.  */
   if (testToRun == -1 && ac > 1) {
 partial_match = (strcmp(av[1], "-R") == 0) ? 1 : 0;
   }
-  if (partial_match && ac < 3) {
+  if (partial_match != 0 && ac < 3) {
 printf("-R needs an additional parameter.\n");
 return -1;
   }
@@ -101,20 +100,18 @@ int main(int ac, char* av[])
   }
   for (i = 0; i < NumTests && testToRun == -1; ++i) {
 test_name = lowercase(cmakeGeneratedFunctionMapEntries[i].name);
-if (partial_match && strstr(test_name, arg) != NULL) {
+if (partial_match != 0 && strstr(test_name, arg) != NULL) { /* NOLINT */
   testToRun = i;
   ac -= 2;
   av += 2;
-} else if (!partial_match && strcmp(test_name, arg) == 0) {
+} else if (partial_match == 0 && strcmp(test_name, arg) == 0) {
   testToRun = i;
   ac--;
   av++;
 }
 free(test_name);
   }
-  if (arg) {
-free(arg);
-  }
+  free(arg);
   if (testToRun != -1) {
 int result;
 @CMAKE_TESTDRIVER_BEFORE_TESTMAIN@

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=178c897374718c2b7cfa76f5c016f23658d5d2b2
commit 178c897374718c2b7cfa76f5c016f23658d5d2b2
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Jan 24 22:24:06 2017 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Tue Jan 24 22:24:06 2017 +0100

TestDriver: calc NumTests at compile time

diff --git a/Templates/TestDriver.cxx.in b/Templates/TestDriver.cxx.in
index 8e54680..7340842 100644
--- a/Templates/TestDriver.cxx.in
+++ b/Templates/TestDriver.cxx.in
@@ -32,6 +32,9 @@ static func

Re: [cmake-developers] [Discussion] Add python support for CMakeLists

[Daniel Pfeifer]

On Wed, Jan 11, 2017 at 10:23 PM, Shmuel H,  wrote:

> Hello,
>
> First of all, I have been using CMake for a few years now, it is awesome
> tool, thank you.
>
> The only problem I currently have with CMake is its language, which has
> not really intended to be one. After reading a few endless discussions
> about this topic, I decided to give it a try and do something practical.
>
> My current design is using Python as an extension for the regular
> CMakeLists.txt files: if there is a CMakeLists.py file, it would be loaded.
>
> It should not be too hard to maintain, the current API design uses only
> 1-3 function that should be implemented in cmake.
>
> For more information, see the [closed] merge request #389
> .
>
> I would be happy to hear your opinion about this idea.
>

Hello Shmuel,

what do you find fault with the CMake language?  I have my own complaints
about it, which may be completely orthogonal or even contradictory to yours.

I am currently refactoring cmCommand and the way commands are interpreted
in the CMake language. This refactoring will simplify porting the CMake
language frontend to a different scripting engine. I have spent some
thoughts on this and I have a very strong opinion about the direction.

To avoid another "language X is better than Y" discussion, I will not go
into more details. You should elaborate your motivation first.

cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Can we please require TR1 to build CMake?

[Daniel Pfeifer]

Hi and happy 2017,

I am currently doing some refactoring (more on that later) and I would like
to start using TR1/C++11 library features, namely std::function, std::bind,
std::placeholders, std::shared_ptr, std::make_shared.

Some background information:

The Dinkumware standard library introduced TR1 in version 5.05. Visual
Studio 2008 (without Service Pack) ships with version 5.03. Visual Studio
2008 SP1 has version 5.05. Visual Studio 2010 has version 5.20. This
version puts the symbols into namespace std. The version number is stored
in _CPPLIB_VER.

The GNU libstdc++ introduced TR1 in version 4.0. The TR1 headers have been
put into a subdirectory. Starting with version 4.3, the headers can be
included as in C++11 and the symbols are in namespace std, but only if the
language mode is set to C++0x or higher. The library version number is
stored in __GLIBCXX__.

The LLVM libc++ was designed for C++11 from the beginning.

I could not find information about TR1 availability in other standard
library implementations. So I made a test run on the nightly dashboard
builds. The results are here:
https://open.cdash.org/index.php?project=CMake=2016-12-29
I was very surprised by the small number of failed builds.

Five expected nightly builds failed on dash2win64.kitware. Apparently
Visual Studio 2008 SP1 is not installed. The Intel compiler uses the
standard library of Visual Studio.

AIX-7.1_IBM-12.1 reports that __IBMCPP_TR1__ must be defined to use TR1.
That should be easy to fix.

Xcode 2.1 and 3.2 fail. These builds are not marked as "expected".

This leaves HP-UX.11iv2.ia64-aCC and Solaris-10-8.11_Oracle-12.3.

Here is my concrete proposal:

* Explicitly require SP1 for Visual Studio 2008.
* Drop support for Xcode 2.1 and 3.2 or mark builds as expected.
* Disallow compiling in C++98 mode if compiler is capable of C++11.
* Require TR1 by all means. This may require setting up Boost.TR1 on a very
small number of exotic platforms.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.7.1-1872-gf090b78

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  f090b7818791116d3bd273403a91531e9a14d3fc (commit)
   via  4d7002fe4045e32dc3e5eefaff9ab2f20c878297 (commit)
  from  2969f55026a2bb77f063c6c119a9c9e3afc35854 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f090b7818791116d3bd273403a91531e9a14d3fc
commit f090b7818791116d3bd273403a91531e9a14d3fc
Merge: 2969f55 4d7002f
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Dec 29 15:19:29 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Dec 29 15:19:29 2016 -0500

Merge topic 'require-tr1' into next

4d7002fe Revert "Require TR1"


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4d7002fe4045e32dc3e5eefaff9ab2f20c878297
commit 4d7002fe4045e32dc3e5eefaff9ab2f20c878297
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Dec 29 21:18:44 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Dec 29 21:18:44 2016 +0100

Revert "Require TR1"

This reverts commit b0c31f93c84207b3c3a8ba31241ff2ee22886acf.

diff --git a/Source/Checks/cm_cxx_features.cmake 
b/Source/Checks/cm_cxx_features.cmake
index 23805be..80c9f3b 100644
--- a/Source/Checks/cm_cxx_features.cmake
+++ b/Source/Checks/cm_cxx_features.cmake
@@ -40,4 +40,6 @@ if(CMAKE_CXX_STANDARD)
   cm_check_cxx_feature(nullptr)
   cm_check_cxx_feature(override)
   cm_check_cxx_feature(unique_ptr)
+  cm_check_cxx_feature(unordered_map)
+  cm_check_cxx_feature(unordered_set)
 endif()
diff --git a/Source/Checks/cm_cxx_unordered_map.cxx 
b/Source/Checks/cm_cxx_unordered_map.cxx
new file mode 100644
index 000..be3de25
--- /dev/null
+++ b/Source/Checks/cm_cxx_unordered_map.cxx
@@ -0,0 +1,7 @@
+#include 
+int main()
+{
+  std::unordered_map<int, int> map;
+  map[0] = 0;
+  return 0;
+}
diff --git a/Source/Checks/cm_cxx_unordered_set.cxx 
b/Source/Checks/cm_cxx_unordered_set.cxx
new file mode 100644
index 000..de4bb77
--- /dev/null
+++ b/Source/Checks/cm_cxx_unordered_set.cxx
@@ -0,0 +1,7 @@
+#include 
+int main()
+{
+  std::unordered_set set;
+  set.insert(0);
+  return 0;
+}
diff --git a/Source/cmConfigure.cmake.h.in b/Source/cmConfigure.cmake.h.in
index 07eba12..26f1df2 100644
--- a/Source/cmConfigure.cmake.h.in
+++ b/Source/cmConfigure.cmake.h.in
@@ -25,6 +25,8 @@
 #cmakedefine CMake_HAVE_CXX_NULLPTR
 #cmakedefine CMake_HAVE_CXX_OVERRIDE
 #cmakedefine CMake_HAVE_CXX_UNIQUE_PTR
+#cmakedefine CMake_HAVE_CXX_UNORDERED_MAP
+#cmakedefine CMake_HAVE_CXX_UNORDERED_SET
 #define CMAKE_BIN_DIR "/@CMAKE_BIN_DIR@"
 #define CMAKE_DATA_DIR "/@CMAKE_DATA_DIR@"
 
diff --git a/Source/cm_unordered_map.hxx b/Source/cm_unordered_map.hxx
index 3a0d88a..dc8ca35 100644
--- a/Source/cm_unordered_map.hxx
+++ b/Source/cm_unordered_map.hxx
@@ -4,29 +4,22 @@
 #define CM_UNORDERED_MAP_HXX
 
 #include 
-#include 
 
-#if defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L)
-#include 
-#else
-#include 
-#endif
+#if defined(CMake_HAVE_CXX_UNORDERED_MAP)
 
-namespace cm {
+#include 
+#define CM_UNORDERED_MAP std::unordered_map
 
-#if (defined(_CPPLIB_VER) && _CPPLIB_VER < 520) ||\
-  (defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L))
+#elif defined(CMAKE_BUILD_WITH_CMAKE)
 
-using namespace std::tr1;
+#include 
+#define CM_UNORDERED_MAP cmsys::hash_map
 
 #else
 
-using namespace std;
+#include 
+#define CM_UNORDERED_MAP std::map
 
 #endif
 
-} // end namespace cm
-
-#define CM_UNORDERED_MAP cm::unordered_map
-
 #endif
diff --git a/Source/cm_unordered_set.hxx b/Source/cm_unordered_set.hxx
index 1f66e00..ce58dbf 100644
--- a/Source/cm_unordered_set.hxx
+++ b/Source/cm_unordered_set.hxx
@@ -4,29 +4,22 @@
 #define CM_UNORDERED_SET_HXX
 
 #include 
-#include 
 
-#if defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L)
-#include 
-#else
-#include 
-#endif
+#if defined(CMake_HAVE_CXX_UNORDERED_SET)
 
-namespace cm {
+#include 
+#define CM_UNORDERED_SET std::unordered_set
 
-#if (defined(_CPPLIB_VER) && _CPPLIB_VER < 520) ||\
-  (defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L))
+#elif defined(CMAKE_BUILD_WITH_CMAKE)
 
-using namespace std::tr1;
+#include 
+#define CM_UNORDERED_SET cmsys::hash_set
 
 #else
 
-using namespace std;
+#include 
+#define CM_UNORDERED_SET std::set
 
 #endif
 
-} // end namespace cm
-
-#define CM_UNORDERED_SET 

[Cmake-commits] CMake branch, next, updated. v3.7.1-1868-g3c5549e

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  3c5549e5d6d8b3651f7696e5f9daade18ffab621 (commit)
   via  b0c31f93c84207b3c3a8ba31241ff2ee22886acf (commit)
  from  54fd0836989e2a4bb8711265499e09e6ffd5c3d8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3c5549e5d6d8b3651f7696e5f9daade18ffab621
commit 3c5549e5d6d8b3651f7696e5f9daade18ffab621
Merge: 54fd083 b0c31f9
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Dec 28 16:31:37 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Dec 28 16:31:37 2016 -0500

Merge topic 'require-tr1' into next

b0c31f93 Require TR1


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b0c31f93c84207b3c3a8ba31241ff2ee22886acf
commit b0c31f93c84207b3c3a8ba31241ff2ee22886acf
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Dec 28 20:41:17 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Dec 28 20:41:17 2016 +0100

Require TR1

diff --git a/Source/Checks/cm_cxx_features.cmake 
b/Source/Checks/cm_cxx_features.cmake
index 80c9f3b..23805be 100644
--- a/Source/Checks/cm_cxx_features.cmake
+++ b/Source/Checks/cm_cxx_features.cmake
@@ -40,6 +40,4 @@ if(CMAKE_CXX_STANDARD)
   cm_check_cxx_feature(nullptr)
   cm_check_cxx_feature(override)
   cm_check_cxx_feature(unique_ptr)
-  cm_check_cxx_feature(unordered_map)
-  cm_check_cxx_feature(unordered_set)
 endif()
diff --git a/Source/Checks/cm_cxx_unordered_map.cxx 
b/Source/Checks/cm_cxx_unordered_map.cxx
deleted file mode 100644
index be3de25..000
--- a/Source/Checks/cm_cxx_unordered_map.cxx
+++ /dev/null
@@ -1,7 +0,0 @@
-#include 
-int main()
-{
-  std::unordered_map<int, int> map;
-  map[0] = 0;
-  return 0;
-}
diff --git a/Source/Checks/cm_cxx_unordered_set.cxx 
b/Source/Checks/cm_cxx_unordered_set.cxx
deleted file mode 100644
index de4bb77..000
--- a/Source/Checks/cm_cxx_unordered_set.cxx
+++ /dev/null
@@ -1,7 +0,0 @@
-#include 
-int main()
-{
-  std::unordered_set set;
-  set.insert(0);
-  return 0;
-}
diff --git a/Source/cmConfigure.cmake.h.in b/Source/cmConfigure.cmake.h.in
index 26f1df2..07eba12 100644
--- a/Source/cmConfigure.cmake.h.in
+++ b/Source/cmConfigure.cmake.h.in
@@ -25,8 +25,6 @@
 #cmakedefine CMake_HAVE_CXX_NULLPTR
 #cmakedefine CMake_HAVE_CXX_OVERRIDE
 #cmakedefine CMake_HAVE_CXX_UNIQUE_PTR
-#cmakedefine CMake_HAVE_CXX_UNORDERED_MAP
-#cmakedefine CMake_HAVE_CXX_UNORDERED_SET
 #define CMAKE_BIN_DIR "/@CMAKE_BIN_DIR@"
 #define CMAKE_DATA_DIR "/@CMAKE_DATA_DIR@"
 
diff --git a/Source/cm_unordered_map.hxx b/Source/cm_unordered_map.hxx
index dc8ca35..3a0d88a 100644
--- a/Source/cm_unordered_map.hxx
+++ b/Source/cm_unordered_map.hxx
@@ -4,22 +4,29 @@
 #define CM_UNORDERED_MAP_HXX
 
 #include 
+#include 
 
-#if defined(CMake_HAVE_CXX_UNORDERED_MAP)
-
+#if defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L)
+#include 
+#else
 #include 
-#define CM_UNORDERED_MAP std::unordered_map
+#endif
 
-#elif defined(CMAKE_BUILD_WITH_CMAKE)
+namespace cm {
 
-#include 
-#define CM_UNORDERED_MAP cmsys::hash_map
+#if (defined(_CPPLIB_VER) && _CPPLIB_VER < 520) ||\
+  (defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L))
+
+using namespace std::tr1;
 
 #else
 
-#include 
-#define CM_UNORDERED_MAP std::map
+using namespace std;
 
 #endif
 
+} // end namespace cm
+
+#define CM_UNORDERED_MAP cm::unordered_map
+
 #endif
diff --git a/Source/cm_unordered_set.hxx b/Source/cm_unordered_set.hxx
index ce58dbf..1f66e00 100644
--- a/Source/cm_unordered_set.hxx
+++ b/Source/cm_unordered_set.hxx
@@ -4,22 +4,29 @@
 #define CM_UNORDERED_SET_HXX
 
 #include 
+#include 
 
-#if defined(CMake_HAVE_CXX_UNORDERED_SET)
-
+#if defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L)
+#include 
+#else
 #include 
-#define CM_UNORDERED_SET std::unordered_set
+#endif
 
-#elif defined(CMAKE_BUILD_WITH_CMAKE)
+namespace cm {
 
-#include 
-#define CM_UNORDERED_SET cmsys::hash_set
+#if (defined(_CPPLIB_VER) && _CPPLIB_VER < 520) ||\
+  (defined(__GLIBCXX__) && (__GLIBCXX__ < 20080306 || __cplusplus < 201103L))
+
+using namespace std::tr1;
 
 #else
 
-#include 
-#define CM_UNORDERED_SET std::set
+using namespace std;
 
 #endif
 
+} // end namespace cm
+
+#define CM_UNORDERED_SET cm::unordered_set
+
 #endif

---

S

[Cmake-commits] CMake branch, next, updated. v3.7.1-1727-g6a262ae

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  6a262ae56f4b5522836cde5a5f00baacf05aec56 (commit)
   via  d3046264ae8f48af0e0f8ae8a21722a64d354fd2 (commit)
  from  45dc7662d8d9ebf0538be9b17459466eb5d744ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6a262ae56f4b5522836cde5a5f00baacf05aec56
commit 6a262ae56f4b5522836cde5a5f00baacf05aec56
Merge: 45dc766 d304626
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Dec 13 02:15:04 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Dec 13 02:15:04 2016 -0500

Merge topic 'rebuild-lexers' into next

d3046264 fixup! Regenerate lexer source code


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d3046264ae8f48af0e0f8ae8a21722a64d354fd2
commit d3046264ae8f48af0e0f8ae8a21722a64d354fd2
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Dec 13 08:14:42 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Tue Dec 13 08:14:42 2016 +0100

fixup! Regenerate lexer source code

diff --git a/Source/cmListFileLexer.c b/Source/cmListFileLexer.c
index ba1e2a3..31faca1 100644
--- a/Source/cmListFileLexer.c
+++ b/Source/cmListFileLexer.c
@@ -551,6 +551,7 @@ Modify cmListFileLexer.c:
   - remove blank lines at end of file
   - #include "cmStandardLexer.h" at the top
   - add cast in cmListFileLexer_yy_scan_bytes for loop condition of 
_yybytes_len to size_t
+  - change type of variable yyl under yy_find_action from yy_size_t to int
 
 */
 
@@ -570,7 +571,7 @@ Modify cmListFileLexer.c:
 struct cmListFileLexer_s
 {
   cmListFileLexer_Token token;
-  yy_size_t bracket;
+  int bracket;
   int comment;
   int line;
   int column;
@@ -602,7 +603,7 @@ static void cmListFileLexerDestroy(cmListFileLexer* lexer);
 
 
 
-#line 605 "cmListFileLexer.c"
+#line 606 "cmListFileLexer.c"
 
 #define INITIAL 0
 #define STRING 1
@@ -859,10 +860,10 @@ YY_DECL
}
 
{
-#line 79 "cmListFileLexer.in.l"
+#line 80 "cmListFileLexer.in.l"
 
 
-#line 865 "cmListFileLexer.c"
+#line 866 "cmListFileLexer.c"
 
while ( /*CONSTCOND*/1 )/* loops until end-of-file is 
reached */
{
@@ -910,7 +911,7 @@ yy_find_action:
 
if ( yy_act != YY_END_OF_BUFFER && 
yy_rule_can_match_eol[yy_act] )
{
-   yy_size_t yyl;
+   int yyl;
for ( yyl = 0; yyl < yyleng; ++yyl )
if ( yytext[yyl] == '\n' )
 
@@ -934,7 +935,7 @@ do_action:  /* This label is used only to access EOF 
actions. */
 case 1:
 /* rule 1 can match eol */
 YY_RULE_SETUP
-#line 81 "cmListFileLexer.in.l"
+#line 82 "cmListFileLexer.in.l"
 {
   lexer->token.type = cmListFileLexer_Token_Newline;
   cmListFileLexerSetToken(lexer, yytext, yyleng);
@@ -947,7 +948,7 @@ YY_RULE_SETUP
 case 2:
 /* rule 2 can match eol */
 YY_RULE_SETUP
-#line 90 "cmListFileLexer.in.l"
+#line 91 "cmListFileLexer.in.l"
 {
   const char* bracket = yytext;
   lexer->comment = yytext[0] == '#';
@@ -970,7 +971,7 @@ YY_RULE_SETUP
YY_BREAK
 case 3:
 YY_RULE_SETUP
-#line 110 "cmListFileLexer.in.l"
+#line 111 "cmListFileLexer.in.l"
 {
   lexer->column += yyleng;
   BEGIN(COMMENT);
@@ -978,14 +979,14 @@ YY_RULE_SETUP
YY_BREAK
 case 4:
 YY_RULE_SETUP
-#line 115 "cmListFileLexer.in.l"
+#line 116 "cmListFileLexer.in.l"
 {
   lexer->column += yyleng;
 }
YY_BREAK
 case 5:
 YY_RULE_SETUP
-#line 119 "cmListFileLexer.in.l"
+#line 120 "cmListFileLexer.in.l"
 {
   lexer->token.type = cmListFileLexer_Token_ParenLeft;
   cmListFileLexerSetToken(lexer, yytext, yyleng);
@@ -995,7 +996,7 @@ YY_RULE_SETUP
YY_BREAK
 case 6:
 YY_RULE_SETUP
-#line 126 "cmListFileLexer.in.l"
+#line 127 "cmListFileLexer.in.l"
 {
   lexer->token.type = cmListFileLexer_Token_ParenRight;
   cmListFileLexerSetToken(lexer, yytext, yyleng);
@@ -1005,7 +1006,7 @@ YY_RULE_SETUP
YY_BREAK
 case 7:
 YY_RULE_SETUP
-#line 133 "cmListFileLexer.in.l"
+#line 134 "cmListFileLexer.in.l"
 {
   lexer->token.type = cmListFileLexer_Token_Identifier;
   cmListFileLexerSetToken(lexer, yytext, yyleng);
@@ -1015,7 +1016,7 @@ YY_RULE_SETUP
YY_BREAK
 case 8:
 YY_RULE_SETUP
-#line 140 "cmListFileLexer.in.l"
+#line 141 "cmListFileLex

[Cmake-commits] CMake branch, next, updated. v3.7.1-1702-g7554a08

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  7554a08895ec9d2754bf159450126be6f5d5ac15 (commit)
   via  6881448971ff63c32dd7d380872369afdec9b7b4 (commit)
  from  aaa775916df2d1dbe5e09c91d0238f8271978c7c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7554a08895ec9d2754bf159450126be6f5d5ac15
commit 7554a08895ec9d2754bf159450126be6f5d5ac15
Merge: aaa7759 6881448
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Dec 12 03:05:48 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Dec 12 03:05:48 2016 -0500

Merge topic 'rebuild-lexers' into next

68814489 fixup! Regenerate lexer source code


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6881448971ff63c32dd7d380872369afdec9b7b4
commit 6881448971ff63c32dd7d380872369afdec9b7b4
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Dec 12 09:05:28 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Dec 12 09:05:28 2016 +0100

fixup! Regenerate lexer source code

diff --git a/Source/cmStandardLexer.h b/Source/cmStandardLexer.h
index 1790aae..b9adee5 100644
--- a/Source/cmStandardLexer.h
+++ b/Source/cmStandardLexer.h
@@ -19,10 +19,12 @@
 #pragma warning(disable : 4786)
 #endif
 
-#if defined(__GNUC__) && ((__GNUC__ * 100) + __GNUC_MINOR__) >= 402
-#if !defined(__INTEL_COMPILER)
+#if defined(__GNUC__) && !defined(__INTEL_COMPILER)
+#if ((__GNUC__ * 100) + __GNUC_MINOR__) >= 402
 #pragma GCC diagnostic ignored "-Wconversion"
 #pragma GCC diagnostic ignored "-Wsign-compare"
+#endif
+#if ((__GNUC__ * 100) + __GNUC_MINOR__) >= 403
 #pragma GCC diagnostic ignored "-Wsign-conversion"
 #endif
 #endif

---

Summary of changes:
 Source/cmStandardLexer.h |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.1-1700-gaaa7759

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  aaa775916df2d1dbe5e09c91d0238f8271978c7c (commit)
   via  b046f1f16171e79d4877e96dedd2176a682529f2 (commit)
  from  19cdfe464bf366f900aea1d6b60b506b96bd850f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=aaa775916df2d1dbe5e09c91d0238f8271978c7c
commit aaa775916df2d1dbe5e09c91d0238f8271978c7c
Merge: 19cdfe4 b046f1f
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Dec 11 15:42:53 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Dec 11 15:42:53 2016 -0500

Merge topic 'rebuild-lexers' into next

b046f1f1 fixup! Regenerate lexer source code


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b046f1f16171e79d4877e96dedd2176a682529f2
commit b046f1f16171e79d4877e96dedd2176a682529f2
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Dec 11 21:42:24 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Dec 11 21:42:24 2016 +0100

fixup! Regenerate lexer source code

diff --git a/Source/cmStandardLexer.h b/Source/cmStandardLexer.h
index f906e47..1790aae 100644
--- a/Source/cmStandardLexer.h
+++ b/Source/cmStandardLexer.h
@@ -23,6 +23,7 @@
 #if !defined(__INTEL_COMPILER)
 #pragma GCC diagnostic ignored "-Wconversion"
 #pragma GCC diagnostic ignored "-Wsign-compare"
+#pragma GCC diagnostic ignored "-Wsign-conversion"
 #endif
 #endif
 

---

Summary of changes:
 Source/cmStandardLexer.h |1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.1-1696-g15fd34c

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  15fd34c75455508eb1d7cc95c2ed475b6cc503a1 (commit)
   via  1d8f0dd7836889944fd491c639e4010e97bc5e84 (commit)
  from  0cfcc2e3e5b7eb312b82ceddeabf1e696feea2d4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=15fd34c75455508eb1d7cc95c2ed475b6cc503a1
commit 15fd34c75455508eb1d7cc95c2ed475b6cc503a1
Merge: 0cfcc2e 1d8f0dd
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Dec 11 15:24:58 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Dec 11 15:24:58 2016 -0500

Merge topic 'clang-tidy' into next

1d8f0dd7 fixup! clang-tidy: apply modernize-use-bool-literals fixes


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1d8f0dd7836889944fd491c639e4010e97bc5e84
commit 1d8f0dd7836889944fd491c639e4010e97bc5e84
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Dec 11 21:22:58 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Dec 11 21:22:58 2016 +0100

fixup! clang-tidy: apply modernize-use-bool-literals fixes

diff --git a/Source/cmGeneratorExpression.cxx b/Source/cmGeneratorExpression.cxx
index 43b18dd..e70bbfe 100644
--- a/Source/cmGeneratorExpression.cxx
+++ b/Source/cmGeneratorExpression.cxx
@@ -351,7 +351,8 @@ std::string cmGeneratorExpression::Preprocess(const 
std::string& input,
 return stripExportInterface(input, context, resolveRelative);
   }
 
-  assert(!"cmGeneratorExpression::Preprocess called with invalid args");
+  assert(false &&
+ "cmGeneratorExpression::Preprocess called with invalid args");
   return std::string();
 }
 
diff --git a/Source/cmGeneratorExpressionNode.cxx 
b/Source/cmGeneratorExpressionNode.cxx
index 9623e27..398f95b 100644
--- a/Source/cmGeneratorExpressionNode.cxx
+++ b/Source/cmGeneratorExpressionNode.cxx
@@ -1377,7 +1377,7 @@ cmPolicies::PolicyStatus 
statusForTarget(cmGeneratorTarget const* tgt,
 
 #undef RETURN_POLICY
 
-  assert(!"Unreachable code. Not a valid policy");
+  assert(false && "Unreachable code. Not a valid policy");
   return cmPolicies::WARN;
 }
 
@@ -1392,7 +1392,7 @@ cmPolicies::PolicyID policyForString(const char* 
policy_id)
 
 #undef RETURN_POLICY_ID
 
-  assert(!"Unreachable code. Not a valid policy");
+  assert(false && "Unreachable code. Not a valid policy");
   return cmPolicies::CMP0002;
 }
 
diff --git a/Source/cmGeneratorExpressionParser.cxx 
b/Source/cmGeneratorExpressionParser.cxx
index 25a0176..c33349a 100644
--- a/Source/cmGeneratorExpressionParser.cxx
+++ b/Source/cmGeneratorExpressionParser.cxx
@@ -242,11 +242,11 @@ void cmGeneratorExpressionParser::ParseContent(
   if (this->NestingLevel == 0) {
 extendText(result, this->it);
   } else {
-assert(!"Got unexpected syntax token.");
+assert(false && "Got unexpected syntax token.");
   }
   assert(this->it != this->Tokens.end());
   ++this->it;
   return;
   }
-  assert(!"Unhandled token in generator expression.");
+  assert(false && "Unhandled token in generator expression.");
 }
diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index ccd3bfa..b6db0d6 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -3389,7 +3389,8 @@ const char* 
getLinkInterfaceDependentProperty(cmGeneratorTarget const* tgt,
 {
   switch (t) {
 case BoolType:
-  assert(!"String compatibility check function called for boolean");
+  assert(false &&
+ "String compatibility check function called for boolean");
   return CM_NULLPTR;
 case StringType:
   return tgt->GetLinkInterfaceDependentStringProperty(prop, config);
@@ -3398,7 +3399,7 @@ const char* 
getLinkInterfaceDependentProperty(cmGeneratorTarget const* tgt,
 case NumberMaxType:
   return tgt->GetLinkInterfaceDependentNumberMaxProperty(prop, config);
   }
-  assert(!"Unreachable!");
+  assert(false && "Unreachable!");
   return CM_NULLPTR;
 }
 
@@ -3589,7 +3590,7 @@ std::string compatibilityType(CompatibleType t)
 case NumberMinType:
   return "Numeric minimum compatibility";
   }
-  assert(!"Unreachable!");
+  assert(false && "Unreachable!");
   return "";
 }
 
@@ -3603,7 +3604,7 @@ std::string compatibilityAgree(CompatibleType t, bool 
dominant)
 c

[Cmake-commits] CMake branch, next, updated. v3.7.1-1694-g0cfcc2e

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  0cfcc2e3e5b7eb312b82ceddeabf1e696feea2d4 (commit)
   via  a6e932533da73b906508e42840c665b89955fb00 (commit)
  from  22492e41fbc94575cf126d9f3bde083da9b8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0cfcc2e3e5b7eb312b82ceddeabf1e696feea2d4
commit 0cfcc2e3e5b7eb312b82ceddeabf1e696feea2d4
Merge: 22492e4 a6e9325
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Dec 11 03:14:44 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Dec 11 03:14:44 2016 -0500

Merge topic 'clang-tidy' into next

a6e93253 fixup! clang-tidy: apply performance-unnecessary-value-param fixes


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a6e932533da73b906508e42840c665b89955fb00
commit a6e932533da73b906508e42840c665b89955fb00
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Dec 11 09:14:23 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Dec 11 09:14:23 2016 +0100

fixup! clang-tidy: apply performance-unnecessary-value-param fixes

diff --git a/Source/cmProcessOutput.cxx b/Source/cmProcessOutput.cxx
index e2ba58d..617e1ca 100644
--- a/Source/cmProcessOutput.cxx
+++ b/Source/cmProcessOutput.cxx
@@ -52,12 +52,16 @@ cmProcessOutput::~cmProcessOutput()
 {
 }
 
-bool cmProcessOutput::DecodeText(std::string const& raw, std::string& decoded,
+bool cmProcessOutput::DecodeText(std::string raw, std::string& decoded,
  size_t id)
 {
+#if !defined(_WIN32)
+  static_cast(id);
+  decoded.swap(raw);
+  return true;
+#else
   bool success = true;
   decoded = raw;
-#if defined(_WIN32)
   if (id > 0) {
 if (rawparts.size() < id) {
   rawparts.reserve(id);
@@ -114,10 +118,8 @@ bool cmProcessOutput::DecodeText(std::string const& raw, 
std::string& decoded,
   success = DoDecodeText(raw, decoded, NULL);
 }
   }
-#else
-  static_cast(id);
-#endif
   return success;
+#endif
 }
 
 bool cmProcessOutput::DecodeText(const char* data, size_t length,
diff --git a/Source/cmProcessOutput.h b/Source/cmProcessOutput.h
index 0ea8aa1..d2e631f 100644
--- a/Source/cmProcessOutput.h
+++ b/Source/cmProcessOutput.h
@@ -57,7 +57,7 @@ public:
* keep incomplete characters in separate buffers for each stream.
* \return true if successfully decoded \a raw to \a decoded or false if not.
*/
-  bool DecodeText(std::string const& raw, std::string& decoded, size_t id = 0);
+  bool DecodeText(std::string raw, std::string& decoded, size_t id = 0);
   /**
* Decode \a data with \a length from external encoding to internal
* encoding in \a decoded.

---

Summary of changes:
 Source/cmProcessOutput.cxx |   12 +++-
 Source/cmProcessOutput.h   |2 +-
 2 files changed, 8 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.1-1692-g22492e4

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  22492e41fbc94575cf126d9f3bde083da9b8 (commit)
   via  172e77380b8b4b012069eadb43b6156c4201e6a0 (commit)
  from  2e29d71c33f54eb84b1fae5bbb3c362b4f994f29 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=22492e41fbc94575cf126d9f3bde083da9b8
commit 22492e41fbc94575cf126d9f3bde083da9b8
Merge: 2e29d71 172e773
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 12:49:45 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Dec 10 12:49:45 2016 -0500

Merge topic 'clang-tidy' into next

172e7738 fixup! clang-tidy: apply misc-suspicious-string-compare fixes


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=172e77380b8b4b012069eadb43b6156c4201e6a0
commit 172e77380b8b4b012069eadb43b6156c4201e6a0
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 18:49:29 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Dec 10 18:49:29 2016 +0100

fixup! clang-tidy: apply misc-suspicious-string-compare fixes

diff --git a/Source/cmCoreTryCompile.cxx b/Source/cmCoreTryCompile.cxx
index a208509..f12c9e8 100644
--- a/Source/cmCoreTryCompile.cxx
+++ b/Source/cmCoreTryCompile.cxx
@@ -810,9 +810,7 @@ void cmCoreTryCompile::CleanupFiles(const char* binDir)
   for (unsigned long i = 0; i < dir.GetNumberOfFiles(); ++i) {
 const char* fileName = dir.GetFile(i);
 if (strcmp(fileName, ".") != 0 && strcmp(fileName, "..") != 0) {
-  std::pair<std::set::iterator, bool> const inserted =
-deletedFiles.insert(fileName);
-  if (inserted.second) {
+  if (deletedFiles.insert(fileName).second) {
 std::string const fullPath =
   std::string(binDir).append("/").append(fileName);
 if (cmSystemTools::FileIsDirectory(fullPath)) {

---

Summary of changes:
 Source/cmCoreTryCompile.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.1-1685-g977cfef

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  977cfef6f69e51639b9d7206667adff4b1154095 (commit)
   via  fa07c5135990639b2cb4f382c085d0cb89592e70 (commit)
   via  a1a00f9f5553d9fca6b99de6679a961f9538a45d (commit)
   via  3557e49685fb5b58f05c25d13ffcca5f4a2eff47 (commit)
   via  38041d5268571762738be3e99da5c1fd13e27cde (commit)
   via  65f5d303534c4705accc0a3f38cf845ee6b7823f (commit)
   via  3e6039ec93e6ba5d8d311b5480dd075bf110908b (commit)
   via  50cd2d8567409ac6bf371c245eae6bd0b904ed12 (commit)
   via  308f37c6da621016d9cb5da49c50fa6c1ff9005c (commit)
   via  b88843d651dc2c500af13c1fe882b389c4949b04 (commit)
  from  09752e9d1a58132bf439eb5e82df125ad8d60c0e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=977cfef6f69e51639b9d7206667adff4b1154095
commit 977cfef6f69e51639b9d7206667adff4b1154095
Merge: 09752e9 fa07c51
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 11:08:23 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Dec 10 11:08:23 2016 -0500

Merge topic 'clang-tidy' into next

fa07c513 clang-tidy: apply misc-redundant-expression fixes
a1a00f9f clang-tidy: apply misc-suspicious-string-compare fixes
3557e496 clang-tidy: apply 
readability-static-definition-in-anonymous-namespace fixes
38041d52 clang-tidy: apply readability-redundant-control-flow fixes
65f5d303 clang-tidy: apply modernize-use-bool-literals fixes
3e6039ec clang-tidy: apply readability-redundant-string-init fixes
50cd2d85 clang-tidy: apply performance-faster-string-find fixes
308f37c6 clang-tidy: apply performance-unnecessary-value-param fixes
b88843d6 CMake Nightly Date Stamp


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=fa07c5135990639b2cb4f382c085d0cb89592e70
commit fa07c5135990639b2cb4f382c085d0cb89592e70
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 16:55:49 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Dec 10 16:55:49 2016 +0100

clang-tidy: apply misc-redundant-expression fixes

diff --git a/Source/CTest/cmCTestRunTest.cxx b/Source/CTest/cmCTestRunTest.cxx
index fbc94cc..5c45fe5 100644
--- a/Source/CTest/cmCTestRunTest.cxx
+++ b/Source/CTest/cmCTestRunTest.cxx
@@ -119,10 +119,9 @@ void cmCTestRunTest::CompressOutput()
   strm.next_out = out;
   ret = deflate(, Z_FINISH);
 
-  if (ret == Z_STREAM_ERROR || ret != Z_STREAM_END) {
+  if (ret != Z_STREAM_END) {
 cmCTestLog(this->CTest, ERROR_MESSAGE,
-   "Error during output "
-   "compression. Sending uncompressed output."
+   "Error during output compression. Sending uncompressed output."
  << std::endl);
 delete[] out;
 return;
diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index dfec0fb..559275e 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -2787,7 +2787,7 @@ bool cmCTest::CompressString(std::string& str)
   strm.next_out = [0];
   ret = deflate(, Z_FINISH);
 
-  if (ret == Z_STREAM_ERROR || ret != Z_STREAM_END) {
+  if (ret != Z_STREAM_END) {
 cmCTestLog(this, ERROR_MESSAGE, "Error during gzip compression."
  << std::endl);
 return false;
diff --git a/Source/cmDocumentationFormatter.cxx 
b/Source/cmDocumentationFormatter.cxx
index 21a5209..0018263 100644
--- a/Source/cmDocumentationFormatter.cxx
+++ b/Source/cmDocumentationFormatter.cxx
@@ -156,7 +156,7 @@ void cmDocumentationFormatter::PrintColumn(std::ostream& 
os, const char* text)
 
 // Move to beginning of next word.  Skip over whitespace.
 l = r;
-while (*l && (*l == ' ')) {
+while (*l == ' ') {
   ++l;
 }
   }

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a1a00f9f5553d9fca6b99de6679a961f9538a45d
commit a1a00f9f5553d9fca6b99de6679a961f9538a45d
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 16:49:34 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Dec 10 16:49:34 2016 +0100

clang-tidy: apply misc-suspicious-string-compare fixes

diff --git a/Source/CPack/cmCPackNSISGenerator.cxx 
b/Source/CPack/cmCPackNSISGenerator.cxx
index 2c9ca63..1940953 100644
--- a/Source/CPack/cmCPackNSISGenerator.cxx
+++ b/Source/CPack/cmCPackNSISGenerator.cxx
@@ -597,13 +597,11 @@ bool cmCPackNSISGenerator::GetListOfSubdirectories(
 {
   cmsys::Directory dir;
   dir.Load(topdir);
-  size_t fileNum;
-  for (fileNum = 0; file

[Cmake-commits] CMake branch, next, updated. v3.7.1-1675-g09752e9

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  09752e9d1a58132bf439eb5e82df125ad8d60c0e (commit)
   via  471e3ff8ee3854dc6f2b507cb09f9dc7f088284e (commit)
  from  6573bc3cfb0a24e091c9fc544a43d51064bb78b1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=09752e9d1a58132bf439eb5e82df125ad8d60c0e
commit 09752e9d1a58132bf439eb5e82df125ad8d60c0e
Merge: 6573bc3 471e3ff
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 05:43:12 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Dec 10 05:43:12 2016 -0500

Merge topic 'rebuild-lexers' into next

471e3ff8 fixup! Regenerate lexer source code


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=471e3ff8ee3854dc6f2b507cb09f9dc7f088284e
commit 471e3ff8ee3854dc6f2b507cb09f9dc7f088284e
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 10 10:54:26 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Dec 10 11:39:26 2016 +0100

fixup! Regenerate lexer source code

diff --git a/Source/cmCommandArgumentLexer.cxx 
b/Source/cmCommandArgumentLexer.cxx
index 22ddb90..12dce37 100644
--- a/Source/cmCommandArgumentLexer.cxx
+++ b/Source/cmCommandArgumentLexer.cxx
@@ -462,9 +462,12 @@ Modify cmCommandArgumentLexer.cxx:
   - remove trailing whitespace: sed -i 's/\s*$//' cmCommandArgumentLexer.h 
cmCommandArgumentLexer.cxx
   - remove blank lines at end of file
   - #include "cmStandardLexer.h" at the top
+  - add cast in cmCommandArgument_yy_scan_bytes for loop condition of 
_yybytes_len to size_t
 
 */
 
+/* IWYU pragma: no_forward_declare yyguts_t */
+
 #include "cmCommandArgumentParserHelper.h"
 
 /* Replace the lexer input function.  */
@@ -478,7 +481,7 @@ Modify cmCommandArgumentLexer.cxx:
 /*--*/
 
 
-#line 481 "cmCommandArgumentLexer.cxx"
+#line 484 "cmCommandArgumentLexer.cxx"
 
 #define INITIAL 0
 #define ESCAPES 1
@@ -731,10 +734,10 @@ YY_DECL
}
 
{
-#line 39 "cmCommandArgumentLexer.in.l"
+#line 42 "cmCommandArgumentLexer.in.l"
 
 
-#line 737 "cmCommandArgumentLexer.cxx"
+#line 740 "cmCommandArgumentLexer.cxx"
 
while ( /*CONSTCOND*/1 )/* loops until end-of-file is 
reached */
{
@@ -793,7 +796,7 @@ do_action:  /* This label is used only to access EOF 
actions. */
 
 case 1:
 YY_RULE_SETUP
-#line 41 "cmCommandArgumentLexer.in.l"
+#line 44 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   yyextra->AllocateParserType(yylvalp, yytext+1, strlen(yytext)-2);
@@ -802,7 +805,7 @@ YY_RULE_SETUP
YY_BREAK
 case 2:
 YY_RULE_SETUP
-#line 47 "cmCommandArgumentLexer.in.l"
+#line 50 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   yyextra->AllocateParserType(yylvalp, yytext+1, strlen(yytext)-2);
@@ -811,7 +814,7 @@ YY_RULE_SETUP
YY_BREAK
 case 3:
 YY_RULE_SETUP
-#line 53 "cmCommandArgumentLexer.in.l"
+#line 56 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   yyextra->AllocateParserType(yylvalp, yytext+1, strlen(yytext)-2);
@@ -820,7 +823,7 @@ YY_RULE_SETUP
YY_BREAK
 case 4:
 YY_RULE_SETUP
-#line 59 "cmCommandArgumentLexer.in.l"
+#line 62 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   //yyextra->AllocateParserType(yylvalp, yytext, strlen(yytext));
@@ -830,7 +833,7 @@ YY_RULE_SETUP
YY_BREAK
 case 5:
 YY_RULE_SETUP
-#line 66 "cmCommandArgumentLexer.in.l"
+#line 69 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   //yyextra->AllocateParserType(yylvalp, yytext, strlen(yytext));
@@ -840,7 +843,7 @@ YY_RULE_SETUP
YY_BREAK
 case 6:
 YY_RULE_SETUP
-#line 73 "cmCommandArgumentLexer.in.l"
+#line 76 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << 

[Cmake-commits] CMake branch, next, updated. v3.7.1-1673-g6573bc3

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  6573bc3cfb0a24e091c9fc544a43d51064bb78b1 (commit)
   via  3d840e4da4fcd1b57036d0906b014643d4cbcbf7 (commit)
  from  8ea54462c97909a798b406b0eebb6cd1a703004f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6573bc3cfb0a24e091c9fc544a43d51064bb78b1
commit 6573bc3cfb0a24e091c9fc544a43d51064bb78b1
Merge: 8ea5446 3d840e4
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Dec 9 16:09:00 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Dec 9 16:09:00 2016 -0500

Merge topic 'rebuild-lexers' into next

3d840e4d fixup! Regenerate lexer source code


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3d840e4da4fcd1b57036d0906b014643d4cbcbf7
commit 3d840e4da4fcd1b57036d0906b014643d4cbcbf7
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Dec 9 21:57:43 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Dec 9 22:07:30 2016 +0100

fixup! Regenerate lexer source code

diff --git a/CTestCustom.cmake.in b/CTestCustom.cmake.in
index 07a9fdb..fa2fbe3 100644
--- a/CTestCustom.cmake.in
+++ b/CTestCustom.cmake.in
@@ -83,6 +83,10 @@ list(APPEND CTEST_CUSTOM_WARNING_EXCEPTION
   "warning: Value stored to 'yytoken' is never read"
   "index_encoder.c.241.2. warning: Value stored to .out_start. is never read"
   "index.c.*warning: Access to field.*results in a dereference of a null 
pointer.*loaded from variable.*"
+  "cmCommandArgumentLexer.cxx:[0-9]+:[0-9]+: warning: Call to 'realloc' has an 
allocation size of 0 bytes"
+  "cmDependsJavaLexer.cxx:[0-9]+:[0-9]+: warning: Call to 'realloc' has an 
allocation size of 0 bytes"
+  "cmExprLexer.cxx:[0-9]+:[0-9]+: warning: Call to 'realloc' has an allocation 
size of 0 bytes"
+  "cmListFileLexer.c:[0-9]+:[0-9]+: warning: Call to 'realloc' has an 
allocation size of 0 bytes"
   "cmFortranLexer.cxx:[0-9]+:[0-9]+: warning: Call to 'realloc' has an 
allocation size of 0 bytes"
   "testProcess.*warning: Dereference of null pointer .loaded from variable 
.invalidAddress.."
   "liblzma/simple/x86.c:[0-9]+:[0-9]+: warning: The result of the '<<' 
expression is undefined"
diff --git a/Source/cmCommandArgumentLexer.cxx 
b/Source/cmCommandArgumentLexer.cxx
index bf8f350..22ddb90 100644
--- a/Source/cmCommandArgumentLexer.cxx
+++ b/Source/cmCommandArgumentLexer.cxx
@@ -462,7 +462,6 @@ Modify cmCommandArgumentLexer.cxx:
   - remove trailing whitespace: sed -i 's/\s*$//' cmCommandArgumentLexer.h 
cmCommandArgumentLexer.cxx
   - remove blank lines at end of file
   - #include "cmStandardLexer.h" at the top
-  - change type of variable i in cmCommandArgument_yy_scan_bytes from 
yy_size_t to int
 
 */
 
@@ -479,7 +478,7 @@ Modify cmCommandArgumentLexer.cxx:
 /*--*/
 
 
-#line 482 "cmCommandArgumentLexer.cxx"
+#line 481 "cmCommandArgumentLexer.cxx"
 
 #define INITIAL 0
 #define ESCAPES 1
@@ -732,10 +731,10 @@ YY_DECL
}
 
{
-#line 40 "cmCommandArgumentLexer.in.l"
+#line 39 "cmCommandArgumentLexer.in.l"
 
 
-#line 738 "cmCommandArgumentLexer.cxx"
+#line 737 "cmCommandArgumentLexer.cxx"
 
while ( /*CONSTCOND*/1 )/* loops until end-of-file is 
reached */
{
@@ -794,7 +793,7 @@ do_action:  /* This label is used only to access EOF 
actions. */
 
 case 1:
 YY_RULE_SETUP
-#line 42 "cmCommandArgumentLexer.in.l"
+#line 41 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   yyextra->AllocateParserType(yylvalp, yytext+1, strlen(yytext)-2);
@@ -803,7 +802,7 @@ YY_RULE_SETUP
YY_BREAK
 case 2:
 YY_RULE_SETUP
-#line 48 "cmCommandArgumentLexer.in.l"
+#line 47 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << std::endl;
   yyextra->AllocateParserType(yylvalp, yytext+1, strlen(yytext)-2);
@@ -812,7 +811,7 @@ YY_RULE_SETUP
YY_BREAK
 case 3:
 YY_RULE_SETUP
-#line 54 "cmCommandArgumentLexer.in.l"
+#line 53 "cmCommandArgumentLexer.in.l"
 {
   //std::cerr << __LINE__ << " here: [" << yytext << "]" << s

[Cmake-commits] CMake branch, next, updated. v3.7.1-1656-gf4a9406

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  f4a9406513d4c0f1bdc825325e3691ab83fc6b7b (commit)
   via  5f457173b1c2fce6a6a8cb2c41ee34c750b07216 (commit)
  from  2170072ec502d612f62746e9ed1c960dec5fd714 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f4a9406513d4c0f1bdc825325e3691ab83fc6b7b
commit f4a9406513d4c0f1bdc825325e3691ab83fc6b7b
Merge: 2170072 5f45717
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Dec 8 19:51:53 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Dec 8 19:51:53 2016 -0500

Merge topic 'rebuild-lexers' into next

5f457173 fixup! Regenerate lexer source code


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5f457173b1c2fce6a6a8cb2c41ee34c750b07216
commit 5f457173b1c2fce6a6a8cb2c41ee34c750b07216
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Dec 9 01:50:40 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Dec 9 01:50:40 2016 +0100

fixup! Regenerate lexer source code

diff --git a/Source/cmExprLexer.cxx b/Source/cmExprLexer.cxx
index 9261302..33a9662 100644
--- a/Source/cmExprLexer.cxx
+++ b/Source/cmExprLexer.cxx
@@ -1,3 +1,4 @@
+#include "cmStandardLexer.h"
 #line 2 "cmExprLexer.cxx"
 
 #line 4 "cmExprLexer.cxx"

---

Summary of changes:
 Source/cmExprLexer.cxx |1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.1-1491-g3bd5d24

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  3bd5d24975e984b7df2c55855aacaaa291ca35d1 (commit)
   via  1af67b199a048ed8f02f3b7090ad7d9fdae3e558 (commit)
   via  c45b767a8c2120ba61b9fafa31d8db37a919d62a (commit)
  from  f4d8b9d6db329e27d4bdcf07859649bb43fe7214 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3bd5d24975e984b7df2c55855aacaaa291ca35d1
commit 3bd5d24975e984b7df2c55855aacaaa291ca35d1
Merge: f4d8b9d 1af67b1
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Dec 3 09:03:01 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Dec 3 09:03:01 2016 -0500

Merge topic 'test-handler-multimap' into next

1af67b19 cmCTestTestHandler: use multimap
c45b767a CMake Nightly Date Stamp


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1af67b199a048ed8f02f3b7090ad7d9fdae3e558
commit 1af67b199a048ed8f02f3b7090ad7d9fdae3e558
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Nov 29 23:36:54 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Dec 3 14:54:52 2016 +0100

cmCTestTestHandler: use multimap

diff --git a/Source/CTest/cmCTestTestHandler.cxx 
b/Source/CTest/cmCTestTestHandler.cxx
index ab43dbc..68f9a54 100644
--- a/Source/CTest/cmCTestTestHandler.cxx
+++ b/Source/CTest/cmCTestTestHandler.cxx
@@ -797,8 +797,9 @@ void cmCTestTestHandler::UpdateForFixtures(ListOfTests& 
tests) const
 
   // Prepare some maps to help us find setup and cleanup tests for
   // any given fixture
-  typedef std::set TestIteratorSet;
-  typedef std::map<std::string, TestIteratorSet> FixtureDependencies;
+  typedef ListOfTests::const_iterator TestIterator;
+  typedef std::multimap<std::string, TestIterator> FixtureDependencies;
+  typedef FixtureDependencies::const_iterator FixtureDepsIterator;
   FixtureDependencies fixtureSetups;
   FixtureDependencies fixtureDeps;
 
@@ -809,14 +810,14 @@ void cmCTestTestHandler::UpdateForFixtures(ListOfTests& 
tests) const
 const std::set& setups = p.FixturesSetup;
 for (std::set::const_iterator depsIt = setups.begin();
  depsIt != setups.end(); ++depsIt) {
-  fixtureSetups[*depsIt].insert(it);
-  fixtureDeps[*depsIt].insert(it);
+  fixtureSetups.insert(std::make_pair(*depsIt, it));
+  fixtureDeps.insert(std::make_pair(*depsIt, it));
 }
 
 const std::set& cleanups = p.FixturesCleanup;
 for (std::set::const_iterator depsIt = cleanups.begin();
  depsIt != cleanups.end(); ++depsIt) {
-  fixtureDeps[*depsIt].insert(it);
+  fixtureDeps.insert(std::make_pair(*depsIt, it));
 }
   }
 
@@ -859,17 +860,15 @@ void cmCTestTestHandler::UpdateForFixtures(ListOfTests& 
tests) const
   // associated with the required fixture. If any of those setup
   // tests fail, this test should not run. We make the fixture's
   // cleanup tests depend on this test case later.
-  FixtureDependencies::const_iterator setupIt =
-fixtureSetups.find(requiredFixtureName);
-  if (setupIt != fixtureSetups.end()) {
-for (TestIteratorSet::const_iterator sIt = setupIt->second.begin();
- sIt != setupIt->second.end(); ++sIt) {
-  const std::string& setupTestName = (**sIt).Name;
-  tests[i].RequireSuccessDepends.insert(setupTestName);
-  if (std::find(tests[i].Depends.begin(), tests[i].Depends.end(),
-setupTestName) == tests[i].Depends.end()) {
-tests[i].Depends.push_back(setupTestName);
-  }
+  std::pair<FixtureDepsIterator, FixtureDepsIterator> setupRange =
+fixtureSetups.equal_range(requiredFixtureName);
+  for (FixtureDepsIterator sIt = setupRange.first;
+   sIt != setupRange.second; ++sIt) {
+const std::string& setupTestName = sIt->second->Name;
+tests[i].RequireSuccessDepends.insert(setupTestName);
+if (std::find(tests[i].Depends.begin(), tests[i].Depends.end(),
+  setupTestName) == tests[i].Depends.end()) {
+  tests[i].Depends.push_back(setupTestName);
 }
   }
 
@@ -882,17 +881,11 @@ void cmCTestTestHandler::UpdateForFixtures(ListOfTests& 
tests) const
 // Already added this fixture
 continue;
   }
-  FixtureDependencies::const_iterator fixtureIt =
-fixtureDeps.find(requiredFixtureName);
-  if (fixtureIt == fixtureDeps.end()) {
-// No setup or cleanup tests for this fixture
-continue;
-  

Re: [cmake-developers] Fwd: cmVisualStudio10TargetGenerator should not generate a rule for an ImportLibrary for executables

[Daniel Pfeifer]

On Mon, Nov 28, 2016 at 2:41 PM, Lode Leroy  wrote:

> Please consider the following patch for inclusion in cmake.
>
> The problem is that when a project contains a FOO.DLL and a FOO.EXE,
> the cmake generator tries to build FOO.LIB for both.
> The FOO.EXE does not need a FOO.LIB.
>
> $ diff -urp CMake-3.7.0-orig/ CMake-3.7.0
> Only in CMake-3.7.0: build
> diff -urp CMake-3.7.0-orig/Source/cmVisualStudio10TargetGenerator.cxx
> CMake-3.7.0/Source/cmVisualStudio10TargetGenerator.cxx
> --- CMake-3.7.0-orig/Source/cmVisualStudio10TargetGenerator.cxx
> 2016-11-11 15:24:18.0 +0100
> +++ CMake-3.7.0/Source/cmVisualStudio10TargetGenerator.cxx
> 2016-11-28 14:28:26.344898900 +0100
> @@ -2310,7 +2310,9 @@ bool cmVisualStudio10TargetGenerator::Co
>  imLib += "/";
>  imLib += targetNameImport;
>
> -linkOptions.AddFlag("ImportLibrary", imLib.c_str());
> +if (this->GeneratorTarget->GetType() != cmState::EXECUTABLE) {
> +linkOptions.AddFlag("ImportLibrary", imLib.c_str());
> +}
>  linkOptions.AddFlag("ProgramDataBaseFile", pdb.c_str());
>
>  // A Windows Runtime component uses internal .NET metadata,
> --
>
>
I am no windows expert, but I think the import library is required when you
want to link against the executable.
Please see https://cmake.org/cmake/help/v3.7/prop_tgt/ENABLE_EXPORTS.html
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Questions about C++ version and third party libraries

[Daniel Pfeifer]

On Sat, Nov 26, 2016 at 11:17 AM, mateusz janek 
wrote:

> Hello CMake community,
>
> First of all, I want to say "Hello" to everyone, I am new to the CMake
> developers community.
>

Hello and welcome!


> I have some questions about developing rules, before I'll start to write
> the code:
> -In which version of C++ is CMake written?
>

CMake can still be built with Visual Studio 2008. It is mostly written in
C++98 but built with C++14 where possible. We use some abstractions like
CM_NULLPTR or CM_OVERRIDE. The parts for the language server are written in
C++14.

-Am I right that it is forbidden to use third party libraries?
>

CMake uses several third party libraries. Have a look at the Utilities
directory.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.7.0-1329-g250c3b9

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  250c3b994e4057baaa713288697cb29eda59de25 (commit)
   via  52834ffc22f87b634c194f75966b52793696e825 (commit)
  from  39707fbe51f914b538aabfa6f02852009f24d370 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=250c3b994e4057baaa713288697cb29eda59de25
commit 250c3b994e4057baaa713288697cb29eda59de25
Merge: 39707fb 52834ff
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Nov 25 18:22:25 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Nov 25 18:22:25 2016 -0500

Merge topic 'include-what-you-use' into next

52834ffc Fixup! iwyu: Fix more findings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=52834ffc22f87b634c194f75966b52793696e825
commit 52834ffc22f87b634c194f75966b52793696e825
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 26 00:22:11 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Nov 26 00:22:11 2016 +0100

Fixup! iwyu: Fix more findings

diff --git a/Source/cmFileCommand.cxx b/Source/cmFileCommand.cxx
index 9c5c862..2f6238b 100644
--- a/Source/cmFileCommand.cxx
+++ b/Source/cmFileCommand.cxx
@@ -4,7 +4,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 

---

Summary of changes:
 Source/cmFileCommand.cxx |1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-1327-g39707fb

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  39707fbe51f914b538aabfa6f02852009f24d370 (commit)
   via  153be68ff49b80eef0558c3cde89e3cd7e4d9856 (commit)
   via  807a2e02ca64ddd34788d9724867e38df5d8e701 (commit)
   via  9527fc332a8a74d5dd27d16af122b89cc3a394ef (commit)
   via  aeff60e44c203dd67b316a6c6eab1454a408e1f7 (commit)
  from  86d0d04211c1102be5449a18825aec645c7b6942 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=39707fbe51f914b538aabfa6f02852009f24d370
commit 39707fbe51f914b538aabfa6f02852009f24d370
Merge: 86d0d04 153be68
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Nov 25 18:07:06 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Nov 25 18:07:06 2016 -0500

Merge topic 'include-what-you-use' into next

153be68f avoid including cmStandardIncludes.h
807a2e02 iwyu: Fix VisualStudio specific issues
9527fc33 iwyu: Fix more findings
aeff60e4 iwyu: Fix OSX specific issues


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=153be68ff49b80eef0558c3cde89e3cd7e4d9856
commit 153be68ff49b80eef0558c3cde89e3cd7e4d9856
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Nov 25 23:21:20 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Nov 25 23:31:51 2016 +0100

avoid including cmStandardIncludes.h

diff --git a/Source/CPack/WiX/cmCPackWIXGenerator.cxx 
b/Source/CPack/WiX/cmCPackWIXGenerator.cxx
index 0c4f573..2bccf2e 100644
--- a/Source/CPack/WiX/cmCPackWIXGenerator.cxx
+++ b/Source/CPack/WiX/cmCPackWIXGenerator.cxx
@@ -4,6 +4,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/Source/CPack/WiX/cmWIXRichTextFormatWriter.h 
b/Source/CPack/WiX/cmWIXRichTextFormatWriter.h
index b535979..a3c8394 100644
--- a/Source/CPack/WiX/cmWIXRichTextFormatWriter.h
+++ b/Source/CPack/WiX/cmWIXRichTextFormatWriter.h
@@ -5,9 +5,8 @@
 
 #include 
 
-#include "cmStandardIncludes.h"
-
 #include 
+#include 
 
 /** \class cmWIXRichtTextFormatWriter
  * \brief Helper class to generate Rich Text Format (RTF) documents
diff --git a/Source/cmGhsMultiGpj.h b/Source/cmGhsMultiGpj.h
index 793d471..2c2b123 100644
--- a/Source/cmGhsMultiGpj.h
+++ b/Source/cmGhsMultiGpj.h
@@ -5,8 +5,6 @@
 
 #include 
 
-#include "cmStandardIncludes.h"
-
 class cmGeneratedFileStream;
 
 class GhsMultiGpj
diff --git a/Source/cmGlobalGhsMultiGenerator.cxx 
b/Source/cmGlobalGhsMultiGenerator.cxx
index 6bbfed5..286f375 100644
--- a/Source/cmGlobalGhsMultiGenerator.cxx
+++ b/Source/cmGlobalGhsMultiGenerator.cxx
@@ -2,14 +2,16 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmGlobalGhsMultiGenerator.h"
 
+#include 
+
+#include "cmAlgorithms.h"
+#include "cmDocumentationEntry.h"
 #include "cmGeneratedFileStream.h"
 #include "cmGeneratorTarget.h"
 #include "cmGhsMultiTargetGenerator.h"
 #include "cmLocalGhsMultiGenerator.h"
 #include "cmMakefile.h"
 #include "cmVersion.h"
-#include 
-#include 
 
 const char* cmGlobalGhsMultiGenerator::FILE_EXTENSION = ".gpj";
 const char* cmGlobalGhsMultiGenerator::DEFAULT_MAKE_PROGRAM = "gbuild";

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=807a2e02ca64ddd34788d9724867e38df5d8e701
commit 807a2e02ca64ddd34788d9724867e38df5d8e701
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Nov 25 22:54:58 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Nov 25 23:31:51 2016 +0100

iwyu: Fix VisualStudio specific issues

diff --git a/Source/bindexplib.cxx b/Source/bindexplib.cxx
index db97c47..eded883 100644
--- a/Source/bindexplib.cxx
+++ b/Source/bindexplib.cxx
@@ -62,11 +62,10 @@
 *--
 */
 #include "bindexplib.h"
+
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 
 typedef struct cmANON_OBJECT_HEADER_BIGOBJ {
diff --git a/Source/bindexplib.h b/Source/bindexplib.h
index 1a0c3a3..d6900ba 100644
--- a/Source/bindexplib.h
+++ b/Source/bindexplib.h
@@ -5,8 +5,9 @@
 
 #include 
 
-#include "cmStandardIncludes.h"
-
+#include 
+#include 
+#include 
 
 class bindexplib
 {
diff --git a/Source/cmCallVisualStudioMacro.cxx 
b/Source/cmCallVisualStudioMacro.cxx
index a21a7d2..99fe587 100644
--- a/Source/cmCallVisualStudioMacro.cxx
+++ b/Source/cmCallVisualStudioMacro.cxx
@@ -2,6 +2,8 @@

Re: [cmake-developers] improved CodeBlocks group support

[Daniel Pfeifer]

On Mon, Nov 21, 2016 at 4:21 PM, Tobias Hunger 
wrote:

> Hi Tim,
>
> Am 21.11.2016 01:19 schrieb "tim cotter" :
> >
> > i've patched my local cmake to automatically add a virtual folder group
> option for every file in a code blocks project.
> >
> > it's not proper support for cmake source groups.
> > but it does what i want it to do.
> >
> > the patch is small.
> >
> > would the community be interested in such a thing?
>
> Have you tested this with the IDEs that user this extra generator?
> CodeBlocks and QtCreator are the ones I know to be using this.
>
> > if so, how would i go about submitting it?
>
> If you can create a merge request at gitlab.kitware.com, then that would
> be the best option. Not sure you can get an account there (that is able to
> create merge requests).
>
https://gitlab.kitware.com/cmake/cmake/blob/master/CONTRIBUTING.rst
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-948-g2a71480

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  2a71480fa93b4c8bdb6485c1a78a9cd01f050791 (commit)
   via  7719d01d2925429be2ee4f742cbce81c5c5e1044 (commit)
  from  f2f7d5af951cdca95bd245838d5f24fea85a92cf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2a71480fa93b4c8bdb6485c1a78a9cd01f050791
commit 2a71480fa93b4c8bdb6485c1a78a9cd01f050791
Merge: f2f7d5a 7719d01
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Nov 7 14:07:05 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Nov 7 14:07:05 2016 -0500

Merge topic 'include-what-you-use' into next

7719d01d Fixup! Fix several include-what-you-use findings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7719d01d2925429be2ee4f742cbce81c5c5e1044
commit 7719d01d2925429be2ee4f742cbce81c5c5e1044
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Nov 7 20:06:10 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Nov 7 20:06:10 2016 +0100

Fixup! Fix several include-what-you-use findings

diff --git a/Source/cmFileCommand.cxx b/Source/cmFileCommand.cxx
index 1bade57..afff0f3 100644
--- a/Source/cmFileCommand.cxx
+++ b/Source/cmFileCommand.cxx
@@ -20,6 +20,7 @@
 
 #undef GetCurrentDirectory
 #include 
+#include 
 
 #include 
 // include sys/stat.h after sys/types.h

---

Summary of changes:
 Source/cmFileCommand.cxx |1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-946-gf2f7d5a

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  f2f7d5af951cdca95bd245838d5f24fea85a92cf (commit)
   via  6086ab4f5cdfc87fa2bdac95ecf83c6d3677e5f2 (commit)
  from  0c32230ce5fd27d4a2515c7194df00b3c36b532d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f2f7d5af951cdca95bd245838d5f24fea85a92cf
commit f2f7d5af951cdca95bd245838d5f24fea85a92cf
Merge: 0c32230 6086ab4
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Nov 7 03:02:47 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Nov 7 03:02:47 2016 -0500

Merge topic 'include-what-you-use' into next

6086ab4f Fixup! Fix several include-what-you-use findings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6086ab4f5cdfc87fa2bdac95ecf83c6d3677e5f2
commit 6086ab4f5cdfc87fa2bdac95ecf83c6d3677e5f2
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Nov 7 09:00:32 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Nov 7 09:00:32 2016 +0100

Fixup! Fix several include-what-you-use findings

diff --git a/Source/cmStateSnapshot.cxx b/Source/cmStateSnapshot.cxx
index cf6cb1b..c6288a5 100644
--- a/Source/cmStateSnapshot.cxx
+++ b/Source/cmStateSnapshot.cxx
@@ -18,6 +18,10 @@
 #include "cmVersion.h"
 #include "cmake.h"
 
+#if defined(__CYGWIN__)
+#include "cmSystemTools.h"
+#endif
+
 cmStateSnapshot::cmStateSnapshot(cmState* state)
   : State(state)
   , Position()

---

Summary of changes:
 Source/cmStateSnapshot.cxx |4 
 1 file changed, 4 insertions(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-944-g0c32230

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  0c32230ce5fd27d4a2515c7194df00b3c36b532d (commit)
   via  0721d07ec934eb7a6049c2fd9d3b7f5e25707772 (commit)
  from  998cbca769bb7cedf28bd1d77c51b0de63f1913c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0c32230ce5fd27d4a2515c7194df00b3c36b532d
commit 0c32230ce5fd27d4a2515c7194df00b3c36b532d
Merge: 998cbca 0721d07
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Nov 6 02:45:27 2016 -0500
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Nov 6 02:45:27 2016 -0500

Merge topic 'include-what-you-use' into next

0721d07e Fixup! Fix several include-what-you-use findings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0721d07ec934eb7a6049c2fd9d3b7f5e25707772
commit 0721d07ec934eb7a6049c2fd9d3b7f5e25707772
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Nov 6 08:45:03 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Nov 6 08:45:03 2016 +0100

Fixup! Fix several include-what-you-use findings

diff --git a/Source/cmGeneratorExpressionEvaluationFile.h 
b/Source/cmGeneratorExpressionEvaluationFile.h
index d597270..26135df 100644
--- a/Source/cmGeneratorExpressionEvaluationFile.h
+++ b/Source/cmGeneratorExpressionEvaluationFile.h
@@ -5,14 +5,19 @@
 
 #include  // IWYU pragma: keep
 
-#include "cmGeneratorExpression.h"
-
-#include 
 #include 
 #include 
-#include 
 #include 
 
+#include "cmGeneratorExpression.h"
+#include "cm_auto_ptr.hxx"
+
+#if defined(_MSC_VER)
+typedef unsigned short mode_t;
+#else
+#include 
+#endif
+
 class cmLocalGenerator;
 
 class cmGeneratorExpressionEvaluationFile
diff --git a/Source/cmSystemTools.h b/Source/cmSystemTools.h
index 9817a3c..0801f26 100644
--- a/Source/cmSystemTools.h
+++ b/Source/cmSystemTools.h
@@ -11,6 +11,12 @@
 #include 
 #include 
 
+#if defined(_MSC_VER)
+typedef unsigned short mode_t;
+#else
+#include 
+#endif
+
 class cmSystemToolsFileTime;
 
 /** \class cmSystemTools

---

Summary of changes:
 Source/cmGeneratorExpressionEvaluationFile.h |   13 +
 Source/cmSystemTools.h   |6 ++
 2 files changed, 15 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-942-g998cbca

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  998cbca769bb7cedf28bd1d77c51b0de63f1913c (commit)
   via  0cd654c8e23b19311bae876ada4ad5b432c1ad1b (commit)
  from  2c62af2d4bc7c5f1d66869b49da138f76586c155 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=998cbca769bb7cedf28bd1d77c51b0de63f1913c
commit 998cbca769bb7cedf28bd1d77c51b0de63f1913c
Merge: 2c62af2 0cd654c
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 19:12:03 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Nov 5 19:12:03 2016 -0400

Merge topic 'clang-tidy' into next

0cd654c8 cmGeneratorTarget: Correctly set FortranModuleDirectoryCreated


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0cd654c8e23b19311bae876ada4ad5b432c1ad1b
commit 0cd654c8e23b19311bae876ada4ad5b432c1ad1b
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Nov 6 00:11:03 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Nov 6 00:11:03 2016 +0100

cmGeneratorTarget: Correctly set FortranModuleDirectoryCreated

diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index ca3e373..f5db7f6 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -3947,6 +3947,7 @@ std::string cmGeneratorTarget::GetFortranModuleDirectory(
   if (!this->FortranModuleDirectoryCreated) {
 this->FortranModuleDirectory =
   this->CreateFortranModuleDirectory(working_dir);
+this->FortranModuleDirectoryCreated = true;
   }
 
   return this->FortranModuleDirectory;

---

Summary of changes:
 Source/cmGeneratorTarget.cxx |1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-940-g2c62af2

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  2c62af2d4bc7c5f1d66869b49da138f76586c155 (commit)
   via  bac93dcf192d8680cd72570682d6593da9818088 (commit)
   via  1e994985d83b09d71b4928a61a75d1cf3861aaec (commit)
   via  5ae3966d75593b05a9658af8d2fdd47c2bf48a4d (commit)
   via  443180fb9915eefe0b232875505632ffb9fabb95 (commit)
  from  6dacf55a79b849ccefb468166d012686b1ed3a18 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2c62af2d4bc7c5f1d66869b49da138f76586c155
commit 2c62af2d4bc7c5f1d66869b49da138f76586c155
Merge: 6dacf55 bac93dc
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 18:56:12 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Nov 5 18:56:12 2016 -0400

Merge topic 'clang-tidy' into next

bac93dcf cmGeneratorTarget: Don't assing a bool to a string
1e994985 cmGlobalNinjaGenerator: Suppress clang-tidy warning
5ae3966d cmCTestSubmitHandler: Remove redundant c_str()
443180fb cmCPluginAPI: Fix clang-tidy findings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bac93dcf192d8680cd72570682d6593da9818088
commit bac93dcf192d8680cd72570682d6593da9818088
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 23:54:57 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Nov 5 23:54:57 2016 +0100

cmGeneratorTarget: Don't assing a bool to a string

diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index ca056c0..ca3e373 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -3945,7 +3945,6 @@ std::string cmGeneratorTarget::GetFortranModuleDirectory(
   std::string const& working_dir) const
 {
   if (!this->FortranModuleDirectoryCreated) {
-this->FortranModuleDirectory = true;
 this->FortranModuleDirectory =
   this->CreateFortranModuleDirectory(working_dir);
   }

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1e994985d83b09d71b4928a61a75d1cf3861aaec
commit 1e994985d83b09d71b4928a61a75d1cf3861aaec
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 23:51:30 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Nov 5 23:51:30 2016 +0100

cmGlobalNinjaGenerator: Suppress clang-tidy warning

diff --git a/Source/cmGlobalNinjaGenerator.cxx 
b/Source/cmGlobalNinjaGenerator.cxx
index 830ab7f..22de7c4 100644
--- a/Source/cmGlobalNinjaGenerator.cxx
+++ b/Source/cmGlobalNinjaGenerator.cxx
@@ -130,7 +130,7 @@ std::string cmGlobalNinjaGenerator::EncodeLiteral(const 
std::string& lit)
 
 std::string cmGlobalNinjaGenerator::EncodePath(const std::string& path)
 {
-  std::string result = path;
+  std::string result = path; // NOLINT(clang-tidy)
 #ifdef _WIN32
   if (this->IsGCCOnWindows())
 std::replace(result.begin(), result.end(), '\\', '/');
@@ -283,7 +283,7 @@ void cmGlobalNinjaGenerator::WriteCustomCommandBuild(
   bool restat, const cmNinjaDeps& outputs, const cmNinjaDeps& deps,
   const cmNinjaDeps& orderOnly)
 {
-  std::string cmd = command;
+  std::string cmd = command; // NOLINT(clang-tidy)
 #ifdef _WIN32
   if (cmd.empty())
 // TODO Shouldn't an empty command be handled by ninja?

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ae3966d75593b05a9658af8d2fdd47c2bf48a4d
commit 5ae3966d75593b05a9658af8d2fdd47c2bf48a4d
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 23:46:24 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Nov 5 23:46:24 2016 +0100

cmCTestSubmitHandler: Remove redundant c_str()

diff --git a/Source/CTest/cmCTestSubmitHandler.cxx 
b/Source/CTest/cmCTestSubmitHandler.cxx
index d21471d..d10f7ad 100644
--- a/Source/CTest/cmCTestSubmitHandler.cxx
+++ b/Source/CTest/cmCTestSubmitHandler.cxx
@@ -926,7 +926,7 @@ bool cmCTestSubmitHandler::SubmitUsingXMLRPC(
   return false;
 }
 size_t fileSize = static_cast(st.st_size);
-FILE* fp = cmsys::SystemTools::Fopen(local_file.c_str(), "rb");
+FILE* fp = cmsys::SystemTools::Fopen(local_file, "rb");
 if (!fp) {
   cmCTestLog(this->CTest, ERROR_MESSAGE,
  "  Cannot open file: " << local_file << std::endl);

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=443180fb9915eefe0b232875505632ffb9fabb95
commit 443180fb9915eefe0b232875505632ffb9fabb95
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 23:44:29 2016 +0100

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-935-g6dacf55

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  6dacf55a79b849ccefb468166d012686b1ed3a18 (commit)
   via  0ee7b4132a7ef9c2eca46a7268a718132fa31cb2 (commit)
  from  166cd2c80d14149698a3b9f39d2973defaa8af8f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6dacf55a79b849ccefb468166d012686b1ed3a18
commit 6dacf55a79b849ccefb468166d012686b1ed3a18
Merge: 166cd2c 0ee7b41
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 18:32:37 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Nov 5 18:32:37 2016 -0400

Merge topic 'include-what-you-use' into next

0ee7b413 Fixup! Fix several include-what-you-use findings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0ee7b4132a7ef9c2eca46a7268a718132fa31cb2
commit 0ee7b4132a7ef9c2eca46a7268a718132fa31cb2
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 23:32:21 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Nov 5 23:32:21 2016 +0100

Fixup! Fix several include-what-you-use findings

diff --git a/Source/QtDialog/CMakeSetup.cxx b/Source/QtDialog/CMakeSetup.cxx
index 9038469..5e03c39 100644
--- a/Source/QtDialog/CMakeSetup.cxx
+++ b/Source/QtDialog/CMakeSetup.cxx
@@ -5,6 +5,7 @@
 #include "CMakeSetupDialog.h"
 #include "cmAlgorithms.h"
 #include "cmDocumentation.h"
+#include "cmDocumentationEntry.h"
 #include "cmVersion.h"
 #include "cmake.h"
 #include 
@@ -17,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "cmSystemTools.h" // IWYU pragma: keep
 

---

Summary of changes:
 Source/QtDialog/CMakeSetup.cxx |2 ++
 1 file changed, 2 insertions(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc3-933-g166cd2c

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  166cd2c80d14149698a3b9f39d2973defaa8af8f (commit)
   via  7e58067e3820cb79780adb0847bc90fb081e8206 (commit)
  from  838fd5c3ecc961323affd2a890ff3421edc82f08 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=166cd2c80d14149698a3b9f39d2973defaa8af8f
commit 166cd2c80d14149698a3b9f39d2973defaa8af8f
Merge: 838fd5c 7e58067
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 18:15:41 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Nov 5 18:15:41 2016 -0400

Merge topic 'include-what-you-use' into next

7e58067e Fix several include-what-you-use findings

diff --cc Source/cmGlobalGenerator.cxx
index 42e9df1,2d0767f..fa447ff
--- a/Source/cmGlobalGenerator.cxx
+++ b/Source/cmGlobalGenerator.cxx
@@@ -33,20 -44,10 +44,10 @@@
  #include "cmVersion.h"
  #include "cmake.h"
  
- #include 
- #include 
- #include 
- #include 
- #include 
- #include 
- #include 
- #include 
- #include 
- 
  #if defined(CMAKE_BUILD_WITH_CMAKE)
 +#include "cmCryptoHash.h"
  #include 
  #include 
 -#include 
  #endif
  
  class cmInstalledFile;

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e58067e3820cb79780adb0847bc90fb081e8206
commit 7e58067e3820cb79780adb0847bc90fb081e8206
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Nov 5 21:40:14 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Nov 5 23:04:23 2016 +0100

Fix several include-what-you-use findings

diff --git a/Source/CTest/cmCTestScriptHandler.cxx 
b/Source/CTest/cmCTestScriptHandler.cxx
index 7ee0f75..08ea4ee 100644
--- a/Source/CTest/cmCTestScriptHandler.cxx
+++ b/Source/CTest/cmCTestScriptHandler.cxx
@@ -22,6 +22,7 @@
 #include "cmGlobalGenerator.h"
 #include "cmMakefile.h"
 #include "cmState.h"
+#include "cmStateDirectory.h"
 #include "cmStateTypes.h"
 #include "cmSystemTools.h"
 #include "cmake.h"
diff --git a/Source/cmAlgorithms.h b/Source/cmAlgorithms.h
index aa55379..22f69fa 100644
--- a/Source/cmAlgorithms.h
+++ b/Source/cmAlgorithms.h
@@ -3,9 +3,17 @@
 #ifndef cmAlgorithms_h
 #define cmAlgorithms_h
 
-#include 
-
-#include "cmStandardIncludes.h"
+#include  // IWYU pragma: keep
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 inline bool cmHasLiteralPrefixImpl(const std::string& str1, const char* str2,
size_t N)
diff --git a/Source/cmCMakeMinimumRequired.cxx 
b/Source/cmCMakeMinimumRequired.cxx
index 655c42a..942688c 100644
--- a/Source/cmCMakeMinimumRequired.cxx
+++ b/Source/cmCMakeMinimumRequired.cxx
@@ -2,9 +2,15 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmCMakeMinimumRequired.h"
 
+#include 
+#include 
+
 #include "cmMakefile.h"
 #include "cmSystemTools.h"
 #include "cmVersion.h"
+#include "cmake.h"
+
+class cmExecutionStatus;
 
 // cmCMakeMinimumRequired
 bool cmCMakeMinimumRequired::InitialPass(std::vector const& args,
diff --git a/Source/cmCMakeMinimumRequired.h b/Source/cmCMakeMinimumRequired.h
index 3acedd2..08a5c38 100644
--- a/Source/cmCMakeMinimumRequired.h
+++ b/Source/cmCMakeMinimumRequired.h
@@ -3,8 +3,14 @@
 #ifndef cmCMakeMinimumRequired_h
 #define cmCMakeMinimumRequired_h
 
+#include 
+#include 
+#include 
+
 #include "cmCommand.h"
 
+class cmExecutionStatus;
+
 /** \class cmCMakeMinimumRequired
  * \brief cmake_minimum_required command
  *
diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index 024260c..010fc4e 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -2,6 +2,27 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmCTest.h"
 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
 #include "cmAlgorithms.h"
 #include "cmCTestBuildAndTestHandler.h"
 #include "cmCTestBuildHandler.h"
@@ -21,35 +42,15 @@
 #include "cmGlobalGenerator.h"
 #include "cmMakefile.h"
 #include "cmState.h"
+#include "cmStateSnapshot.h"
 #include "cmStateTypes.h"
 #include "cmSystemTools.h"
 #include "cmVersion.h"
 #include "cmVersionConf

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-824-g4b4bebc

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  4b4bebc7e19687ff9d1d28374555e647e5b1a634 (commit)
   via  5214bb354b508cafc859b4a05b4e5f8ed44767e0 (commit)
   via  602b78aa79f6d99e775fa0a84fb441156d192833 (commit)
   via  c58c739da7287a1cb33558f4e121ecdb23cfadd9 (commit)
   via  6b90e2850c1bd5df0aab0f1a93ea12f21bb9213f (commit)
   via  cc9987f1ae6319e6641fcfa4cf5997dc7c907948 (commit)
  from  b45687a47df2c5bd075f0316eb753c1a786c08b3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4b4bebc7e19687ff9d1d28374555e647e5b1a634
commit 4b4bebc7e19687ff9d1d28374555e647e5b1a634
Merge: b45687a 5214bb3
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 30 14:51:04 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Oct 30 14:51:04 2016 -0400

Merge topic 'clang-tidy' into next

5214bb35 Avoid some copies
602b78aa Remove redundant c_str() calls
c58c739d Use the empty method to check for emptiness
6b90e285 CMake Nightly Date Stamp
cc9987f1 CMake Nightly Date Stamp


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5214bb354b508cafc859b4a05b4e5f8ed44767e0
commit 5214bb354b508cafc859b4a05b4e5f8ed44767e0
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 30 19:50:19 2016 +0100
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Oct 30 19:50:19 2016 +0100

Avoid some copies

diff --git a/Source/cmFileMonitor.cxx b/Source/cmFileMonitor.cxx
index b55341b..9844306 100644
--- a/Source/cmFileMonitor.cxx
+++ b/Source/cmFileMonitor.cxx
@@ -247,7 +247,10 @@ public:
 
   void StopWatching() final {}
 
-  void AppendCallback(cmFileMonitor::Callback cb) { CbList.push_back(cb); }
+  void AppendCallback(cmFileMonitor::Callback const& cb)
+  {
+this->CbList.push_back(cb);
+  }
 
   std::string Path() const final
   {
@@ -310,7 +313,7 @@ cmFileMonitor::~cmFileMonitor()
 }
 
 void cmFileMonitor::MonitorPaths(const std::vector& paths,
- Callback cb)
+ Callback const& cb)
 {
   for (const auto& p : paths) {
 std::vector pathSegments;
diff --git a/Source/cmFileMonitor.h b/Source/cmFileMonitor.h
index e05f48d..48169b8 100644
--- a/Source/cmFileMonitor.h
+++ b/Source/cmFileMonitor.h
@@ -17,7 +17,7 @@ public:
   ~cmFileMonitor();
 
   using Callback = std::function<void(const std::string&, int, int)>;
-  void MonitorPaths(const std::vector& paths, Callback cb);
+  void MonitorPaths(const std::vector& paths, Callback const& cb);
   void StopMonitoring();
 
   std::vector WatchedFiles() const;
diff --git a/Source/cmGlobalUnixMakefileGenerator3.cxx 
b/Source/cmGlobalUnixMakefileGenerator3.cxx
index 17d49e8..90caaf9 100644
--- a/Source/cmGlobalUnixMakefileGenerator3.cxx
+++ b/Source/cmGlobalUnixMakefileGenerator3.cxx
@@ -963,7 +963,7 @@ void cmGlobalUnixMakefileGenerator3::WriteHelpRule(
 (type == cmStateEnums::OBJECT_LIBRARY) ||
 (type == cmStateEnums::GLOBAL_TARGET) ||
 (type == cmStateEnums::UTILITY)) {
-  std::string name = target->GetName();
+  std::string const& name = target->GetName();
   if (emittedTargets.insert(name).second) {
 path = "... ";
 path += name;
diff --git a/Source/cmOutputRequiredFilesCommand.cxx 
b/Source/cmOutputRequiredFilesCommand.cxx
index f3aa79c..7a17f2c 100644
--- a/Source/cmOutputRequiredFilesCommand.cxx
+++ b/Source/cmOutputRequiredFilesCommand.cxx
@@ -180,26 +180,23 @@ protected:
 while (cmSystemTools::GetLineFromStream(fin, line)) {
   if (cmHasLiteralPrefix(line.c_str(), "#include")) {
 // if it is an include line then create a string class
-std::string currentline = line;
-size_t qstart = currentline.find('\"', 8);
+size_t qstart = line.find('\"', 8);
 size_t qend;
 // if a quote is not found look for a <
 if (qstart == std::string::npos) {
-  qstart = currentline.find('<', 8);
+  qstart = line.find('<', 8);
   // if a < is not found then move on
   if (qstart == std::string::npos) {
-cmSystemTools::Error("unknown include directive ",
- currentline.c_str());
+cmSystemTools::Error("unknown include directive ", line.c_str());
 continue;
   } else {
-qend = currentline.find('>', qstart + 1)

Re: [cmake-developers] iwyu and clang-tidy not working under mac os

[Daniel Pfeifer]

On Wed, Oct 26, 2016 at 11:27 AM, Roman Wüger  wrote:

> Hello,
>
> I set CMAKE_CXX_INCLUDE_WHAT_YOU_USE and CMAKE_CXX_CLANG_TIDY. Both work
> as expected with CMake 3.6.2 under linux. Under Mac OS with the same
> sources and the same CMake version doesn't produce any output.
>
> On Linux clang 3.8 is used, on Mac OS it is AppleClang 7.3.0 with
> clang-tidy installed from homebrew.
>
> Any hints?
>

When you run "make VERBOSE=1" and look at what is executed, do you see any
"cmake --iwyu" invocations?
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-762-g1563b93

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  1563b936fd11bb6512d7365a070a6185ffc9fbaf (commit)
   via  85f893c0535538991218b8caaafe3ff871017b29 (commit)
   via  bf111520211ec74ab847b7fa11637b702af2e8ca (commit)
  from  5521217d66f57464ac4ecf715527682f5148f356 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1563b936fd11bb6512d7365a070a6185ffc9fbaf
commit 1563b936fd11bb6512d7365a070a6185ffc9fbaf
Merge: 5521217 85f893c
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Oct 26 03:03:24 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Oct 26 03:03:24 2016 -0400

Merge topic 'include-what-you-use' into next

85f893c0 fixup! Include necessary headers in commands
bf111520 fixup! Include necessary headers in commands


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=85f893c0535538991218b8caaafe3ff871017b29
commit 85f893c0535538991218b8caaafe3ff871017b29
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Oct 26 09:01:56 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Oct 26 09:01:56 2016 +0200

fixup! Include necessary headers in commands

diff --git a/Source/cmEndWhileCommand.cxx b/Source/cmEndWhileCommand.cxx
index f24c280..5623f33 100644
--- a/Source/cmEndWhileCommand.cxx
+++ b/Source/cmEndWhileCommand.cxx
@@ -2,7 +2,7 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmEndWhileCommand.h"
 
-#include "cmListFileArgument.h"
+#include "cmListFileCache.h"
 
 class cmExecutionStatus;
 

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bf111520211ec74ab847b7fa11637b702af2e8ca
commit bf111520211ec74ab847b7fa11637b702af2e8ca
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Oct 26 08:58:37 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Oct 26 08:58:37 2016 +0200

fixup! Include necessary headers in commands

diff --git a/Source/cmEndWhileCommand.cxx b/Source/cmEndWhileCommand.cxx
index 48f09f1..f24c280 100644
--- a/Source/cmEndWhileCommand.cxx
+++ b/Source/cmEndWhileCommand.cxx
@@ -2,8 +2,9 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmEndWhileCommand.h"
 
+#include "cmListFileArgument.h"
+
 class cmExecutionStatus;
-struct cmListFileArgument;
 
 bool cmEndWhileCommand::InvokeInitialPass(
   std::vector const& args, cmExecutionStatus&)

---

Summary of changes:
 Source/cmEndWhileCommand.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-759-g5521217

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  5521217d66f57464ac4ecf715527682f5148f356 (commit)
   via  c98c12731a987cf83d7aabc3b8127c51ceb8d741 (commit)
  from  331a9929897ad4ba864320e12bee96db86ffd8fe (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5521217d66f57464ac4ecf715527682f5148f356
commit 5521217d66f57464ac4ecf715527682f5148f356
Merge: 331a992 c98c127
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Oct 25 15:39:03 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Oct 25 15:39:03 2016 -0400

Merge topic 'include-what-you-use' into next

c98c1273 Include necessary headers in commands


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c98c12731a987cf83d7aabc3b8127c51ceb8d741
commit c98c12731a987cf83d7aabc3b8127c51ceb8d741
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Oct 25 20:35:04 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Tue Oct 25 21:22:36 2016 +0200

Include necessary headers in commands

diff --git a/Source/cmAddCustomCommandCommand.cxx 
b/Source/cmAddCustomCommandCommand.cxx
index 1ab4ef6..620de31 100644
--- a/Source/cmAddCustomCommandCommand.cxx
+++ b/Source/cmAddCustomCommandCommand.cxx
@@ -2,11 +2,19 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmAddCustomCommandCommand.h"
 
-#include "cmTarget.h"
+#include 
 
+#include "cmCustomCommand.h"
+#include "cmCustomCommandLines.h"
+#include "cmGlobalGenerator.h"
+#include "cmMakefile.h"
+#include "cmPolicies.h"
 #include "cmSourceFile.h"
+#include "cmSystemTools.h"
+#include "cmTarget.h"
+#include "cmake.h"
 
-#include "cmGlobalGenerator.h"
+class cmExecutionStatus;
 
 // cmAddCustomCommandCommand
 bool cmAddCustomCommandCommand::InitialPass(
diff --git a/Source/cmAddCustomCommandCommand.h 
b/Source/cmAddCustomCommandCommand.h
index 643163c..ea92163 100644
--- a/Source/cmAddCustomCommandCommand.h
+++ b/Source/cmAddCustomCommandCommand.h
@@ -3,8 +3,14 @@
 #ifndef cmAddCustomCommandCommand_h
 #define cmAddCustomCommandCommand_h
 
+#include 
+#include 
+#include 
+
 #include "cmCommand.h"
 
+class cmExecutionStatus;
+
 /** \class cmAddCustomCommandCommand
  * \brief cmAddCustomCommandCommand defines a new command (rule) that can
  *  be executed within the build process
diff --git a/Source/cmAddCustomTargetCommand.cxx 
b/Source/cmAddCustomTargetCommand.cxx
index 9c41dac..4e656aa 100644
--- a/Source/cmAddCustomTargetCommand.cxx
+++ b/Source/cmAddCustomTargetCommand.cxx
@@ -2,8 +2,18 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmAddCustomTargetCommand.h"
 
+#include 
+
+#include "cmCustomCommandLines.h"
 #include "cmGeneratorExpression.h"
 #include "cmGlobalGenerator.h"
+#include "cmMakefile.h"
+#include "cmPolicies.h"
+#include "cmSystemTools.h"
+#include "cmTarget.h"
+#include "cmake.h"
+
+class cmExecutionStatus;
 
 // cmAddCustomTargetCommand
 bool cmAddCustomTargetCommand::InitialPass(
diff --git a/Source/cmAddCustomTargetCommand.h 
b/Source/cmAddCustomTargetCommand.h
index 2ad244c..b679247 100644
--- a/Source/cmAddCustomTargetCommand.h
+++ b/Source/cmAddCustomTargetCommand.h
@@ -3,8 +3,14 @@
 #ifndef cmAddCustomTargetCommand_h
 #define cmAddCustomTargetCommand_h
 
+#include 
+#include 
+#include 
+
 #include "cmCommand.h"
 
+class cmExecutionStatus;
+
 /** \class cmAddCustomTargetCommand
  * \brief Command that adds a target to the build system.
  *
diff --git a/Source/cmAddDefinitionsCommand.cxx 
b/Source/cmAddDefinitionsCommand.cxx
index 8d82e71..9e0607c 100644
--- a/Source/cmAddDefinitionsCommand.cxx
+++ b/Source/cmAddDefinitionsCommand.cxx
@@ -2,6 +2,10 @@
file Copyright.txt or https://cmake.org/licensing for details.  */
 #include "cmAddDefinitionsCommand.h"
 
+#include "cmMakefile.h"
+
+class cmExecutionStatus;
+
 // cmAddDefinitionsCommand
 bool cmAddDefinitionsCommand::InitialPass(std::vector const& args,
   cmExecutionStatus&)
diff --git a/Source/cmAddDefinitionsCommand.h b/Source/cmAddDefinitionsCommand.h
index c6b5699..735f8cc 100644
--- a/Source/cmAddDefinitionsCommand.h
+++ b/Source/cmAddDefinitionsCommand.h
@@ -3,8 +3,14 @@
 #ifndef cmAddDefinitionsCommand_h
 #define cmAddDefinitionsComma

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-727-g1529102

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  1529102dab129c3d2e1010f1e37544fd4a698f5d (commit)
   via  c15dc1972839e175afaa9011f74376dadf08277f (commit)
  from  2b3a600e8570df998247ed89da75522cb97e8563 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1529102dab129c3d2e1010f1e37544fd4a698f5d
commit 1529102dab129c3d2e1010f1e37544fd4a698f5d
Merge: 2b3a600 c15dc19
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Oct 24 16:36:31 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Oct 24 16:36:31 2016 -0400

Merge topic 'cm_unordered_set' into next

c15dc197 Introduce CM_UNORDERED_SET


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=c15dc1972839e175afaa9011f74376dadf08277f
commit c15dc1972839e175afaa9011f74376dadf08277f
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Oct 24 22:33:18 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Oct 24 22:34:52 2016 +0200

Introduce CM_UNORDERED_SET

Avoid duplicating switch among std::unordered_set, cmsys::hash_set, and
std::set.

diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index 8ac302a..ca056c0 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -21,6 +21,7 @@
 #include "cmTargetLinkLibraryType.h"
 #include "cmTargetPropertyComputer.h"
 #include "cm_auto_ptr.hxx"
+#include "cm_unordered_set.hxx"
 #include "cmake.h"
 
 #include 
@@ -34,16 +35,6 @@
 #include 
 #include 
 
-#if defined(CMake_HAVE_CXX_UNORDERED_SET)
-#include 
-#define UNORDERED_SET std::unordered_set
-#elif defined(CMAKE_BUILD_WITH_CMAKE)
-#include 
-#define UNORDERED_SET cmsys::hash_set
-#else
-#define UNORDERED_SET std::set
-#endif
-
 template <>
 const char* cmTargetPropertyComputer::GetSources(
   cmGeneratorTarget const* tgt, cmMessenger* /* messenger */,
@@ -926,7 +917,7 @@ static void AddInterfaceEntries(
 static bool processSources(
   cmGeneratorTarget const* tgt,
   const std::vector<cmGeneratorTarget::TargetPropertyEntry*>& entries,
-  std::vector& srcs, UNORDERED_SET& uniqueSrcs,
+  std::vector& srcs, CM_UNORDERED_SET& uniqueSrcs,
   cmGeneratorExpressionDAGChecker* dagChecker, std::string const& config,
   bool debugSources)
 {
@@ -1053,7 +1044,7 @@ void 
cmGeneratorTarget::GetSourceFiles(std::vector& files,
   cmGeneratorExpressionDAGChecker dagChecker(this->GetName(), "SOURCES",
  CM_NULLPTR, CM_NULLPTR);
 
-  UNORDERED_SET uniqueSrcs;
+  CM_UNORDERED_SET uniqueSrcs;
   bool contextDependentDirectSources =
 processSources(this, this->SourceEntries, files, uniqueSrcs, ,
config, debugSources);
@@ -1592,7 +1583,7 @@ class cmTargetCollectLinkLanguages
 public:
   cmTargetCollectLinkLanguages(cmGeneratorTarget const* target,
const std::string& config,
-   UNORDERED_SET& languages,
+   CM_UNORDERED_SET& languages,
cmGeneratorTarget const* head)
 : Config(config)
 , Languages(languages)
@@ -1659,7 +1650,7 @@ public:
 
 private:
   std::string Config;
-  UNORDERED_SET& Languages;
+  CM_UNORDERED_SET& Languages;
   cmGeneratorTarget const* HeadTarget;
   const cmGeneratorTarget* Target;
   std::set Visited;
@@ -1731,7 +1722,7 @@ void cmGeneratorTarget::ComputeLinkClosure(const 
std::string& config,
LinkClosure& lc) const
 {
   // Get languages built in this target.
-  UNORDERED_SET languages;
+  CM_UNORDERED_SET languages;
   cmLinkImplementation const* impl = this->GetLinkImplementation(config);
   assert(impl);
   for (std::vector::const_iterator li = impl->Languages.begin();
@@ -1748,7 +1739,7 @@ void cmGeneratorTarget::ComputeLinkClosure(const 
std::string& config,
   }
 
   // Store the transitive closure of languages.
-  for (UNORDERED_SET::const_iterator li = languages.begin();
+  for (CM_UNORDERED_SET::const_iterator li = languages.begin();
li != languages.end(); ++li) {
 lc.Languages.push_back(*li);
   }
@@ -1769,7 +1760,7 @@ void cmGeneratorTarget::ComputeLinkClosure(const 
std::string& config,
 }
 
 // Now consider languages that propagate from linked targets.
-for (UNORDERED_SET::const_iterator sit = languages.begin();
+for (CM_UNORDERED_SET::const_itera

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-725-g2b3a600

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  2b3a600e8570df998247ed89da75522cb97e8563 (commit)
   via  15aa814b85a90fb8e8798eb99617d27957c28f36 (commit)
  from  08714bc5fcc28cc8e66faa6bd6f06c9a1c1b7cc2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=2b3a600e8570df998247ed89da75522cb97e8563
commit 2b3a600e8570df998247ed89da75522cb97e8563
Merge: 08714bc 15aa814
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Oct 24 15:50:58 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Oct 24 15:50:58 2016 -0400

Merge topic 'remove-cmobject' into next

15aa814b Remove cmObject.h and cmTypeMacro.h


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=15aa814b85a90fb8e8798eb99617d27957c28f36
commit 15aa814b85a90fb8e8798eb99617d27957c28f36
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 01:19:00 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Oct 24 21:49:28 2016 +0200

Remove cmObject.h and cmTypeMacro.h

diff --git a/Source/CPack/IFW/cmCPackIFWGenerator.h 
b/Source/CPack/IFW/cmCPackIFWGenerator.h
index 88a3741..d656063 100644
--- a/Source/CPack/IFW/cmCPackIFWGenerator.h
+++ b/Source/CPack/IFW/cmCPackIFWGenerator.h
@@ -10,7 +10,6 @@
 #include "cmCPackIFWInstaller.h"
 #include "cmCPackIFWPackage.h"
 #include "cmCPackIFWRepository.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPack7zGenerator.h 
b/Source/CPack/cmCPack7zGenerator.h
index 063b032..a617d9b 100644
--- a/Source/CPack/cmCPack7zGenerator.h
+++ b/Source/CPack/cmCPack7zGenerator.h
@@ -7,7 +7,6 @@
 
 #include "cmCPackArchiveGenerator.h"
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 /** \class cmCPack7zGenerator
  * \brief A generator for 7z files
diff --git a/Source/CPack/cmCPackArchiveGenerator.h 
b/Source/CPack/cmCPackArchiveGenerator.h
index 7010664..df02ae8 100644
--- a/Source/CPack/cmCPackArchiveGenerator.h
+++ b/Source/CPack/cmCPackArchiveGenerator.h
@@ -7,7 +7,6 @@
 
 #include "cmArchiveWrite.h"
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackDebGenerator.h 
b/Source/CPack/cmCPackDebGenerator.h
index f46ae5a..7db933e 100644
--- a/Source/CPack/cmCPackDebGenerator.h
+++ b/Source/CPack/cmCPackDebGenerator.h
@@ -6,7 +6,6 @@
 #include 
 
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackGenerator.h b/Source/CPack/cmCPackGenerator.h
index a7652b1..f32dd70 100644
--- a/Source/CPack/cmCPackGenerator.h
+++ b/Source/CPack/cmCPackGenerator.h
@@ -6,9 +6,7 @@
 #include 
 
 #include "cmCPackComponentGroup.h"
-#include "cmObject.h"
 #include "cmSystemTools.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackGeneratorFactory.h 
b/Source/CPack/cmCPackGeneratorFactory.h
index 5381eb2..0a98f91 100644
--- a/Source/CPack/cmCPackGeneratorFactory.h
+++ b/Source/CPack/cmCPackGeneratorFactory.h
@@ -5,9 +5,6 @@
 
 #include 
 
-#include "cmObject.h"
-#include "cmTypeMacro.h"
-
 #include 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackLog.h b/Source/CPack/cmCPackLog.h
index 2ac805d..9ffe5c4 100644
--- a/Source/CPack/cmCPackLog.h
+++ b/Source/CPack/cmCPackLog.h
@@ -5,9 +5,6 @@
 
 #include 
 
-#include "cmObject.h"
-#include "cmTypeMacro.h"
-
 #include 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackNSISGenerator.h 
b/Source/CPack/cmCPackNSISGenerator.h
index d61341c..b4bf2d4 100644
--- a/Source/CPack/cmCPackNSISGenerator.h
+++ b/Source/CPack/cmCPackNSISGenerator.h
@@ -6,7 +6,6 @@
 #include 
 
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackPKGGenerator.h 
b/Source/CPack/cmCPackPKGGenerator.h
index 5569185..bb3c1a7 100644
--- a/Source/CPack/cmCPackPKGGenerator.h
+++ b/Source/CPack/cmCPackPKGGenerator.h
@@ -3,6 +3,9 @@
 #ifndef cmCPackPKGGenerator_h
 #define cmCPackPKGGenerator_h
 
+#include 
+#include 
+
 #include "cmCPackGenerator.h"
 
 class cmCPackComponent;
diff --git a/Source/CPack/cmCPackRPMGenerator.h 
b/Source/CPack/cmCPackRPMGenerator.h
index f8bcbfe..4d48bd8 100644
--- a/Source/CPack/cmCPackRPMGenerator.h
+++ b/Source/CPack/cmCPackRPMGenerator.h
@@ -6,7 +6,6 @@
 #include 
 
 #include "cmCPac

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-679-ge640244

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  e6402444f1f837efb452c50c106a738a66b59d48 (commit)
   via  645186c0b7e46cf99882616ef2a00f07a472825c (commit)
  from  bbc1ed0b6f8669912dbf7151d3c46fa806e04a67 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e6402444f1f837efb452c50c106a738a66b59d48
commit e6402444f1f837efb452c50c106a738a66b59d48
Merge: bbc1ed0 645186c
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 04:25:57 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Oct 23 04:25:57 2016 -0400

Merge topic 'remove-cmobject' into next

645186c0 Revert "Remove cmObject.h and cmTypeMacro.h"


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=645186c0b7e46cf99882616ef2a00f07a472825c
commit 645186c0b7e46cf99882616ef2a00f07a472825c
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 10:25:23 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Oct 23 10:25:23 2016 +0200

Revert "Remove cmObject.h and cmTypeMacro.h"

This reverts commit dcb8b0fb35e74749d07b8aec837b41564691f0c7.

diff --git a/Source/CPack/IFW/cmCPackIFWGenerator.h 
b/Source/CPack/IFW/cmCPackIFWGenerator.h
index d656063..88a3741 100644
--- a/Source/CPack/IFW/cmCPackIFWGenerator.h
+++ b/Source/CPack/IFW/cmCPackIFWGenerator.h
@@ -10,6 +10,7 @@
 #include "cmCPackIFWInstaller.h"
 #include "cmCPackIFWPackage.h"
 #include "cmCPackIFWRepository.h"
+#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPack7zGenerator.h 
b/Source/CPack/cmCPack7zGenerator.h
index a617d9b..063b032 100644
--- a/Source/CPack/cmCPack7zGenerator.h
+++ b/Source/CPack/cmCPack7zGenerator.h
@@ -7,6 +7,7 @@
 
 #include "cmCPackArchiveGenerator.h"
 #include "cmCPackGenerator.h"
+#include "cmTypeMacro.h"
 
 /** \class cmCPack7zGenerator
  * \brief A generator for 7z files
diff --git a/Source/CPack/cmCPackArchiveGenerator.h 
b/Source/CPack/cmCPackArchiveGenerator.h
index df02ae8..7010664 100644
--- a/Source/CPack/cmCPackArchiveGenerator.h
+++ b/Source/CPack/cmCPackArchiveGenerator.h
@@ -7,6 +7,7 @@
 
 #include "cmArchiveWrite.h"
 #include "cmCPackGenerator.h"
+#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackDebGenerator.h 
b/Source/CPack/cmCPackDebGenerator.h
index 7db933e..f46ae5a 100644
--- a/Source/CPack/cmCPackDebGenerator.h
+++ b/Source/CPack/cmCPackDebGenerator.h
@@ -6,6 +6,7 @@
 #include 
 
 #include "cmCPackGenerator.h"
+#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackGenerator.h b/Source/CPack/cmCPackGenerator.h
index f32dd70..a7652b1 100644
--- a/Source/CPack/cmCPackGenerator.h
+++ b/Source/CPack/cmCPackGenerator.h
@@ -6,7 +6,9 @@
 #include 
 
 #include "cmCPackComponentGroup.h"
+#include "cmObject.h"
 #include "cmSystemTools.h"
+#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackGeneratorFactory.h 
b/Source/CPack/cmCPackGeneratorFactory.h
index 0a98f91..5381eb2 100644
--- a/Source/CPack/cmCPackGeneratorFactory.h
+++ b/Source/CPack/cmCPackGeneratorFactory.h
@@ -5,6 +5,9 @@
 
 #include 
 
+#include "cmObject.h"
+#include "cmTypeMacro.h"
+
 #include 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackLog.h b/Source/CPack/cmCPackLog.h
index 9ffe5c4..2ac805d 100644
--- a/Source/CPack/cmCPackLog.h
+++ b/Source/CPack/cmCPackLog.h
@@ -5,6 +5,9 @@
 
 #include 
 
+#include "cmObject.h"
+#include "cmTypeMacro.h"
+
 #include 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackNSISGenerator.h 
b/Source/CPack/cmCPackNSISGenerator.h
index b4bf2d4..d61341c 100644
--- a/Source/CPack/cmCPackNSISGenerator.h
+++ b/Source/CPack/cmCPackNSISGenerator.h
@@ -6,6 +6,7 @@
 #include 
 
 #include "cmCPackGenerator.h"
+#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackPKGGenerator.h 
b/Source/CPack/cmCPackPKGGenerator.h
index bb3c1a7..5569185 100644
--- a/Source/CPack/cmCPackPKGGenerator.h
+++ b/Source/CPack/cmCPackPKGGenerator.h
@@ -3,9 +3,6 @@
 #ifndef cmCPackPKGGenerator_h
 #define cmCPackPKGGenerator_h
 
-#include 
-#include 
-
 #include "cmCPackGenerator.h"
 
 class cmCPackComponent;
diff --git a/Source/CPack/cmCPackRPMGenerator.h 
b/Source/CPack/cmCPackRPMGenerator.h
index 4d48bd8..f8bcbfe 100644
--- a/Source/CPa

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-677-gbbc1ed0

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  bbc1ed0b6f8669912dbf7151d3c46fa806e04a67 (commit)
   via  3aa68a0197e510372c26152d4bbf9a1066b082d3 (commit)
   via  f01ee88d0040b4905844af32d10a689d8ccfc672 (commit)
  from  797b4d3a176c01c91b040ac4fc1e787796e62deb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bbc1ed0b6f8669912dbf7151d3c46fa806e04a67
commit bbc1ed0b6f8669912dbf7151d3c46fa806e04a67
Merge: 797b4d3 3aa68a0
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 04:06:32 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Oct 23 04:06:32 2016 -0400

Merge topic 'cmcommand-no-disable' into next

3aa68a01 Merge topic 'separate-compilation' into cmcommand-no-disable
f01ee88d Remove cmCommand::Enabled and all related accessors

diff --cc Source/cmCommand.h
index 6a1979a,5adca64..dcfe8da
--- a/Source/cmCommand.h
+++ b/Source/cmCommand.h
@@@ -17,11 -19,13 +17,11 @@@
   * to support such features as enable/disable, inheritance,
   * documentation, and construction.
   */
 -class cmCommand : public cmObject
 +class cmCommand
  {
  public:
 -  cmTypeMacro(cmCommand, cmObject);
 -
/**
-* Construct the command. By default it is enabled with no makefile.
+* Construct the command. By default it has no makefile.
 */
cmCommand()
  : Makefile(CM_NULLPTR)

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3aa68a0197e510372c26152d4bbf9a1066b082d3
commit 3aa68a0197e510372c26152d4bbf9a1066b082d3
Merge: f01ee88 32040cd
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 10:06:00 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Oct 23 10:06:00 2016 +0200

Merge topic 'separate-compilation' into cmcommand-no-disable

diff --cc Source/cmCommand.h
index cc34756,9299c71..5adca64
--- a/Source/cmCommand.h
+++ b/Source/cmCommand.h
@@@ -104,16 -96,29 +95,9 @@@ public
virtual std::string GetName() const = 0;
  
/**
 -   * Enable the command.
 -   */
 -  void EnabledOn() { this->Enabled = true; }
 -
 -  /**
 -   * Disable the command.
 -   */
 -  void EnabledOff() { this->Enabled = false; }
 -
 -  /**
 -   * Query whether the command is enabled.
 -   */
 -  bool GetEnabled() const { return this->Enabled; }
 -
 -  /**
 -   * Disable or enable the command.
 -   */
 -  void SetEnabled(bool enabled) { this->Enabled = enabled; }
 -
 -  /**
 * Return the last error string.
 */
-   const char* GetError()
-   {
- if (this->Error.empty()) {
-   this->Error = this->GetName();
-   this->Error += " unknown error.";
- }
- return this->Error.c_str();
-   }
+   const char* GetError();
  
/**
 * Set the error message

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f01ee88d0040b4905844af32d10a689d8ccfc672
commit f01ee88d0040b4905844af32d10a689d8ccfc672
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 08:55:19 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Oct 23 08:55:19 2016 +0200

Remove cmCommand::Enabled and all related accessors

Enabled is never set to false.  Remove the member variable and all
related getters and setters.

diff --git a/Source/cmCommand.h b/Source/cmCommand.h
index d8e337d..cc34756 100644
--- a/Source/cmCommand.h
+++ b/Source/cmCommand.h
@@ -25,12 +25,11 @@ public:
   cmTypeMacro(cmCommand, cmObject);
 
   /**
-   * Construct the command. By default it is enabled with no makefile.
+   * Construct the command. By default it has no makefile.
*/
   cmCommand()
+: Makefile(CM_NULLPTR)
   {
-this->Makefile = CM_NULLPTR;
-this->Enabled = true;
   }
 
   /**
@@ -105,26 +104,6 @@ public:
   virtual std::string GetName() const = 0;
 
   /**
-   * Enable the command.
-   */
-  void EnabledOn() { this->Enabled = true; }
-
-  /**
-   * Disable the command.
-   */
-  void EnabledOff() { this->Enabled = false; }
-
-  /**
-   * Query whether the command is enabled.
-   */
-  bool GetEnabled() const { return this->Enabled; }
-
-  /**
-   * Disable or enable the command.
-   */
-  void SetEnabled(bool enabled) { this->Enabled = enabled; }
-
-  /**
* Return the last error string.
*/
   const char* GetError()
@@ -169,7 +148,6 @@ protected:
   cmCommandArgumentsHelper Helper;
 
 private:
-  bool Enabled;
   std::string Error;
 };
 
diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx
index 00c0e82..741ffb8 100644
--- a/Source

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-674-g797b4d3

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  797b4d3a176c01c91b040ac4fc1e787796e62deb (commit)
   via  dcb8b0fb35e74749d07b8aec837b41564691f0c7 (commit)
   via  2214011f7b3b13fe7ae0f68f0f9d49af11e12edd (commit)
   via  7f9a8d53aa8a3595f4f1f2f81607f8df3627642d (commit)
   via  fb0b087c4dc65f18aef431e41de3aa9b91e35371 (commit)
   via  2169b0faa40a20cd9aae25f9170cca074579a023 (commit)
   via  9855ebf11a1556bd0b73a1eaec39232842871528 (commit)
  from  a8102f933066923c47ed35e0125a5c2e0940a4e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=797b4d3a176c01c91b040ac4fc1e787796e62deb
commit 797b4d3a176c01c91b040ac4fc1e787796e62deb
Merge: a8102f9 dcb8b0f
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 04:02:55 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Oct 23 04:02:55 2016 -0400

Merge topic 'remove-cmobject' into next

dcb8b0fb Remove cmObject.h and cmTypeMacro.h
2214011f Make cmCPackGenerator not inherit from cmObject
7f9a8d53 Make cmCPackGeneratorFactory not inherit from cmObject
fb0b087c Make cmCTestGenericHandler not inherit from cmObject
2169b0fa Make cmCPackLog not inherit from cmObject
9855ebf1 Make cmCommand not inherit from cmObject


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dcb8b0fb35e74749d07b8aec837b41564691f0c7
commit dcb8b0fb35e74749d07b8aec837b41564691f0c7
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 23 01:19:00 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Oct 23 08:02:33 2016 +0200

Remove cmObject.h and cmTypeMacro.h

diff --git a/Source/CPack/IFW/cmCPackIFWGenerator.h 
b/Source/CPack/IFW/cmCPackIFWGenerator.h
index 88a3741..d656063 100644
--- a/Source/CPack/IFW/cmCPackIFWGenerator.h
+++ b/Source/CPack/IFW/cmCPackIFWGenerator.h
@@ -10,7 +10,6 @@
 #include "cmCPackIFWInstaller.h"
 #include "cmCPackIFWPackage.h"
 #include "cmCPackIFWRepository.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPack7zGenerator.h 
b/Source/CPack/cmCPack7zGenerator.h
index 063b032..a617d9b 100644
--- a/Source/CPack/cmCPack7zGenerator.h
+++ b/Source/CPack/cmCPack7zGenerator.h
@@ -7,7 +7,6 @@
 
 #include "cmCPackArchiveGenerator.h"
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 /** \class cmCPack7zGenerator
  * \brief A generator for 7z files
diff --git a/Source/CPack/cmCPackArchiveGenerator.h 
b/Source/CPack/cmCPackArchiveGenerator.h
index 7010664..df02ae8 100644
--- a/Source/CPack/cmCPackArchiveGenerator.h
+++ b/Source/CPack/cmCPackArchiveGenerator.h
@@ -7,7 +7,6 @@
 
 #include "cmArchiveWrite.h"
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackDebGenerator.h 
b/Source/CPack/cmCPackDebGenerator.h
index f46ae5a..7db933e 100644
--- a/Source/CPack/cmCPackDebGenerator.h
+++ b/Source/CPack/cmCPackDebGenerator.h
@@ -6,7 +6,6 @@
 #include 
 
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackGenerator.h b/Source/CPack/cmCPackGenerator.h
index a7652b1..f32dd70 100644
--- a/Source/CPack/cmCPackGenerator.h
+++ b/Source/CPack/cmCPackGenerator.h
@@ -6,9 +6,7 @@
 #include 
 
 #include "cmCPackComponentGroup.h"
-#include "cmObject.h"
 #include "cmSystemTools.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackGeneratorFactory.h 
b/Source/CPack/cmCPackGeneratorFactory.h
index 5381eb2..0a98f91 100644
--- a/Source/CPack/cmCPackGeneratorFactory.h
+++ b/Source/CPack/cmCPackGeneratorFactory.h
@@ -5,9 +5,6 @@
 
 #include 
 
-#include "cmObject.h"
-#include "cmTypeMacro.h"
-
 #include 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackLog.h b/Source/CPack/cmCPackLog.h
index 2ac805d..9ffe5c4 100644
--- a/Source/CPack/cmCPackLog.h
+++ b/Source/CPack/cmCPackLog.h
@@ -5,9 +5,6 @@
 
 #include 
 
-#include "cmObject.h"
-#include "cmTypeMacro.h"
-
 #include 
 #include 
 #include 
diff --git a/Source/CPack/cmCPackNSISGenerator.h 
b/Source/CPack/cmCPackNSISGenerator.h
index d61341c..b4bf2d4 100644
--- a/Source/CPack/cmCPackNSISGenerator.h
+++ b/Source/CPack/cmCPackNSISGenerator.h
@@ -6,7 +6,6 @@
 #include 
 
 #include "cmCPackGenerator.h"
-#include "cmTypeMacro.h"
 
 #include 
 #include 

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-667-ga8102f9

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  a8102f933066923c47ed35e0125a5c2e0940a4e8 (commit)
   via  719a9e8f89a9b6f9bfd78638b62907062a84d535 (commit)
  from  1a8f42e50f1435c05479ad3039e27d6c842a69fd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a8102f933066923c47ed35e0125a5c2e0940a4e8
commit a8102f933066923c47ed35e0125a5c2e0940a4e8
Merge: 1a8f42e 719a9e8
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 17:53:16 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Oct 21 17:53:16 2016 -0400

Merge topic 'cm_unordered_map' into next

719a9e8f Introduce CM_UNORDERED_MAP


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=719a9e8f89a9b6f9bfd78638b62907062a84d535
commit 719a9e8f89a9b6f9bfd78638b62907062a84d535
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 23:52:51 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Oct 21 23:52:51 2016 +0200

Introduce CM_UNORDERED_MAP

diff --git a/Source/cmDefinitions.h b/Source/cmDefinitions.h
index 569b3a2..8dfb9ea 100644
--- a/Source/cmDefinitions.h
+++ b/Source/cmDefinitions.h
@@ -6,20 +6,11 @@
 #include 
 
 #include "cmLinkedTree.h"
+#include "cm_unordered_map.hxx"
 
 #include 
 #include 
 
-#if defined(CMAKE_BUILD_WITH_CMAKE)
-#ifdef CMake_HAVE_CXX_UNORDERED_MAP
-#include 
-#else
-#include "cmsys/hash_map.hxx"
-#endif
-#else
-#include 
-#endif
-
 /** \class cmDefinitions
  * \brief Store a scope of variable definitions for CMake language.
  *
@@ -85,15 +76,7 @@ private:
   };
   static Def NoDef;
 
-#if defined(CMAKE_BUILD_WITH_CMAKE)
-#ifdef CMake_HAVE_CXX_UNORDERED_MAP
-  typedef std::unordered_map<std::string, Def> MapType;
-#else
-  typedef cmsys::hash_map<std::string, Def> MapType;
-#endif
-#else
-  typedef std::map<std::string, Def> MapType;
-#endif
+  typedef CM_UNORDERED_MAP<std::string, Def> MapType;
   MapType Map;
 
   static Def const& GetInternal(const std::string& key, StackIter begin,
diff --git a/Source/cmFileTimeComparison.cxx b/Source/cmFileTimeComparison.cxx
index a6c9cd0..55d8c2a 100644
--- a/Source/cmFileTimeComparison.cxx
+++ b/Source/cmFileTimeComparison.cxx
@@ -7,14 +7,7 @@
 #include 
 #include 
 
-// Use a hash table to avoid duplicate file time checks from disk.
-#if defined(CMAKE_BUILD_WITH_CMAKE)
-#ifdef CMake_HAVE_CXX_UNORDERED_MAP
-#include 
-#else
-#include 
-#endif
-#endif
+#include "cm_unordered_map.hxx"
 
 // Use a platform-specific API to get file times efficiently.
 #if !defined(_WIN32) || defined(__CYGWIN__)
@@ -35,27 +28,9 @@ public:
   bool FileTimesDiffer(const char* f1, const char* f2);
 
 private:
-#if defined(CMAKE_BUILD_WITH_CMAKE)
-  // Use a hash table to efficiently map from file name to modification time.
-  class HashString
-  {
-  public:
-size_t operator()(const std::string& s) const { return h(s.c_str()); }
-#ifdef CMake_HAVE_CXX_UNORDERED_MAP
-std::hash h;
-#else
-cmsys::hash h;
-#endif
-  };
-#ifdef CMake_HAVE_CXX_UNORDERED_MAP
-  typedef std::unordered_map<std::string,
-#else
-  typedef cmsys::hash_map<std::string,
-#endif
- cmFileTimeComparison_Type, HashString>
+  typedef CM_UNORDERED_MAP<std::string, cmFileTimeComparison_Type>
 FileStatsMap;
   FileStatsMap Files;
-#endif
 
   // Internal methods to lookup and compare modification times.
   inline bool Stat(const char* fname, cmFileTimeComparison_Type* st);
@@ -68,7 +43,6 @@ private:
 bool cmFileTimeComparisonInternal::Stat(const char* fname,
 cmFileTimeComparison_Type* st)
 {
-#if defined(CMAKE_BUILD_WITH_CMAKE)
   // Use the stored time if available.
   cmFileTimeComparisonInternal::FileStatsMap::iterator fit =
 this->Files.find(fname);
@@ -76,7 +50,6 @@ bool cmFileTimeComparisonInternal::Stat(const char* fname,
 *st = fit->second;
 return true;
   }
-#endif
 
 #if !defined(_WIN32) || defined(__CYGWIN__)
   // POSIX version.  Use the stat function.
@@ -97,11 +70,8 @@ bool cmFileTimeComparisonInternal::Stat(const char* fname,
   *st = fdata.ftLastWriteTime;
 #endif
 
-#if defined(CMAKE_BUILD_WITH_CMAKE)
   // Store the time for future use.
   this->Files[fname] = *st;
-#endif
-
   return true;
 }
 
diff --git a/Source/cmGlobalGenerator.h b/Source/cmGlobalGenerator.h
index d8d47a1..4bf4bd1 100644
--- a/Source/cmGlobalGenerator.h
+++ b/Source/cmGlobalGenerator.h
@@ -12,6 +12,7 @@
 #include "c

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-665-g1a8f42e

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  1a8f42e50f1435c05479ad3039e27d6c842a69fd (commit)
   via  32040cd3aefa07524d64f65340bdc2b7e1cca513 (commit)
  from  35e25ada0edbcd6a36204ea13a4da8309dab3cfc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1a8f42e50f1435c05479ad3039e27d6c842a69fd
commit 1a8f42e50f1435c05479ad3039e27d6c842a69fd
Merge: 35e25ad 32040cd
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 15:41:30 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Oct 21 15:41:30 2016 -0400

Merge topic 'separate-compilation' into next

32040cd3 Fix newly discovered clang-tidy issues


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=32040cd3aefa07524d64f65340bdc2b7e1cca513
commit 32040cd3aefa07524d64f65340bdc2b7e1cca513
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 21:32:43 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Oct 21 21:32:43 2016 +0200

Fix newly discovered clang-tidy issues

Clang-tidy reports some issues only from the currently compiled source
file and its associated header file.  Separating the compilation of
commands exposed some clang-tidy issues that were not reported previously.
Fix them.

diff --git a/Source/cmAddLibraryCommand.cxx b/Source/cmAddLibraryCommand.cxx
index 18118a3..56cf91a 100644
--- a/Source/cmAddLibraryCommand.cxx
+++ b/Source/cmAddLibraryCommand.cxx
@@ -270,8 +270,8 @@ bool 
cmAddLibraryCommand::InitialPass(std::vector const& args,
 yet its linker language. */
   if ((type == cmStateEnums::SHARED_LIBRARY ||
type == cmStateEnums::MODULE_LIBRARY) &&
-  (this->Makefile->GetState()->GetGlobalPropertyAsBool(
- "TARGET_SUPPORTS_SHARED_LIBS") == false)) {
+  !this->Makefile->GetState()->GetGlobalPropertyAsBool(
+"TARGET_SUPPORTS_SHARED_LIBS")) {
 std::ostringstream w;
 w << "ADD_LIBRARY called with "
   << (type == cmStateEnums::SHARED_LIBRARY ? "SHARED" : "MODULE")
diff --git a/Source/cmConditionEvaluator.cxx b/Source/cmConditionEvaluator.cxx
index 4c0b649..7d98e73 100644
--- a/Source/cmConditionEvaluator.cxx
+++ b/Source/cmConditionEvaluator.cxx
@@ -222,7 +222,7 @@ bool cmConditionEvaluator::GetBooleanValue(
 double d = strtod(arg.c_str(), );
 if (*end == '\0') {
   // The whole string is a number.  Use C conversion to bool.
-  return d ? true : false;
+  return static_cast(d);
 }
   }
 
@@ -444,7 +444,7 @@ bool cmConditionEvaluator::HandleLevel1(cmArgumentList& 
newArgs, std::string&,
   if (this->IsKeyword(keyCOMMAND, *arg) && argP1 != newArgs.end()) {
 cmCommand* command =
   this->Makefile.GetState()->GetCommand(argP1->c_str());
-this->HandlePredicate(command ? true : false, reducible, arg, newArgs,
+this->HandlePredicate(command != CM_NULLPTR, reducible, arg, newArgs,
   argP1, argP2);
   }
   // does a policy exist
@@ -456,7 +456,7 @@ bool cmConditionEvaluator::HandleLevel1(cmArgumentList& 
newArgs, std::string&,
   // does a target exist
   if (this->IsKeyword(keyTARGET, *arg) && argP1 != newArgs.end()) {
 this->HandlePredicate(
-  this->Makefile.FindTargetToUse(argP1->GetValue()) ? true : false,
+  this->Makefile.FindTargetToUse(argP1->GetValue()) != CM_NULLPTR,
   reducible, arg, newArgs, argP1, argP2);
   }
   // does a test exist
@@ -464,7 +464,7 @@ bool cmConditionEvaluator::HandleLevel1(cmArgumentList& 
newArgs, std::string&,
   this->Policy64Status != cmPolicies::WARN) {
 if (this->IsKeyword(keyTEST, *arg) && argP1 != newArgs.end()) {
   const cmTest* haveTest = this->Makefile.GetTest(argP1->c_str());
-  this->HandlePredicate(haveTest ? true : false, reducible, arg,
+  this->HandlePredicate(haveTest != CM_NULLPTR, reducible, arg,
 newArgs, argP1, argP2);
 }
   } else if (this->Policy64Status == cmPolicies::WARN &&
@@ -638,8 +638,8 @@ bool cmConditionEvaluator::HandleLevel2(cmArgumentList& 
newArgs,
 bool success = cmSystemTools::FileTimeCompare(
   arg->GetValue(), (argP2)->GetValue(), );
 this->HandleBinaryOp(
-  (success == false || fileI

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-663-g35e25ad

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  35e25ada0edbcd6a36204ea13a4da8309dab3cfc (commit)
   via  14f1a9d044504d831fe34e711f4e54da4d3f2d08 (commit)
   via  2b7eb72ebdd57a7c61075cad0fa6c7f3947f6e54 (commit)
   via  4bb235357a363646685f6595b6ea501becb74813 (commit)
   via  b500bd327a4565bb85c0ef3585ad7c36aac5d8c5 (commit)
   via  3e330d8805c29f00ff550b37f50add3d009c93d7 (commit)
   via  75fbf9008092484c869d6e075d9c8a056ad8c331 (commit)
  from  5b23ea48ac45f2b08ec1941c291608737ec16555 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=35e25ada0edbcd6a36204ea13a4da8309dab3cfc
commit 35e25ada0edbcd6a36204ea13a4da8309dab3cfc
Merge: 5b23ea4 14f1a9d
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 14:27:25 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Oct 21 14:27:25 2016 -0400

Merge topic 'separate-compilation' into next

14f1a9d0 cmCommand: implement functions in cxx file
2b7eb72e bootstrap: Sort source files lexicographically
4bb23535 Create all commands from a single function
b500bd32 Separate compilation for commands included in cmBootstrapCommands2
3e330d88 Separate compilation for commands included in cmBootstrapCommands1
75fbf900 Separate compilation for commands included in cmCommands


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=14f1a9d044504d831fe34e711f4e54da4d3f2d08
commit 14f1a9d044504d831fe34e711f4e54da4d3f2d08
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Oct 20 00:29:18 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Oct 21 18:14:51 2016 +0200

cmCommand: implement functions in cxx file

diff --git a/Source/CMakeLists.txt b/Source/CMakeLists.txt
index b2617ae..09c0acf 100644
--- a/Source/CMakeLists.txt
+++ b/Source/CMakeLists.txt
@@ -386,6 +386,8 @@ set(SRCS
   cmake.cxx
   cmake.h
 
+  cmCommand.cxx
+  cmCommand.h
   cmCommands.cxx
   cmCommands.h
   cmAddCompileOptionsCommand.cxx
diff --git a/Source/cmCommand.cxx b/Source/cmCommand.cxx
new file mode 100644
index 000..3c839de
--- /dev/null
+++ b/Source/cmCommand.cxx
@@ -0,0 +1,48 @@
+/* Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
+   file Copyright.txt or https://cmake.org/licensing for details.  */
+#include "cmCommand.h"
+
+bool cmCommand::InvokeInitialPass(const std::vector& args,
+  cmExecutionStatus& status)
+{
+  std::vector expandedArguments;
+  if (!this->Makefile->ExpandArguments(args, expandedArguments)) {
+// There was an error expanding arguments.  It was already
+// reported, so we can skip this command without error.
+return true;
+  }
+  return this->InitialPass(expandedArguments, status);
+}
+
+const char* cmCommand::GetError()
+{
+  if (this->Error.empty()) {
+this->Error = this->GetName();
+this->Error += " unknown error.";
+  }
+  return this->Error.c_str();
+}
+
+void cmCommand::SetError(const std::string& e)
+{
+  this->Error = this->GetName();
+  this->Error += " ";
+  this->Error += e;
+}
+
+bool cmCommand::Disallowed(cmPolicies::PolicyID pol, const char* e)
+{
+  switch (this->Makefile->GetPolicyStatus(pol)) {
+case cmPolicies::WARN:
+  this->Makefile->IssueMessage(cmake::AUTHOR_WARNING,
+   cmPolicies::GetPolicyWarning(pol));
+case cmPolicies::OLD:
+  return false;
+case cmPolicies::REQUIRED_IF_USED:
+case cmPolicies::REQUIRED_ALWAYS:
+case cmPolicies::NEW:
+  this->Makefile->IssueMessage(cmake::FATAL_ERROR, e);
+  break;
+  }
+  return true;
+}
diff --git a/Source/cmCommand.h b/Source/cmCommand.h
index d8e337d..9299c71 100644
--- a/Source/cmCommand.h
+++ b/Source/cmCommand.h
@@ -28,9 +28,9 @@ public:
* Construct the command. By default it is enabled with no makefile.
*/
   cmCommand()
+: Makefile(CM_NULLPTR)
+, Enabled(true)
   {
-this->Makefile = CM_NULLPTR;
-this->Enabled = true;
   }
 
   /**
@@ -50,16 +50,7 @@ public:
* arguments and then invokes the InitialPass.
*/
   virtual bool InvokeInitialPass(const std::vector& args,
- cmExecutionStatus& status)
-  {
-std::vector expandedArguments;
-if (!this->Makefile->ExpandArguments(args, expandedArguments)) {
-  // There was an error expanding arguments.  It was alr

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc2-656-g5b23ea4

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  5b23ea48ac45f2b08ec1941c291608737ec16555 (commit)
   via  e3770c56a8ef6b20f473556a1ca29ea6e0f51f7f (commit)
  from  174057f9e157e570a83cf7cd55a7e121d0f4c63c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5b23ea48ac45f2b08ec1941c291608737ec16555
commit 5b23ea48ac45f2b08ec1941c291608737ec16555
Merge: 174057f e3770c5
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 14:06:54 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Oct 21 14:06:54 2016 -0400

Merge topic 'parallel-boostrap-test' into next

e3770c56 BootstrapTest: Use --parallel=... argument.


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e3770c56a8ef6b20f473556a1ca29ea6e0f51f7f
commit e3770c56a8ef6b20f473556a1ca29ea6e0f51f7f
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Oct 21 18:18:18 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Oct 21 18:22:44 2016 +0200

BootstrapTest: Use --parallel=... argument.

Determine the number of processors and provide it to the bootstrap
script.  Also make sure this test does not run parallel with other
tests.

diff --git a/Tests/BootstrapTest.cmake b/Tests/BootstrapTest.cmake
index 9c9fe09..07a65bf 100644
--- a/Tests/BootstrapTest.cmake
+++ b/Tests/BootstrapTest.cmake
@@ -1,7 +1,12 @@
 file(MAKE_DIRECTORY "${bin_dir}")
-message(STATUS "running bootstrap: ${bootstrap}")
+include(ProcessorCount)
+ProcessorCount(nproc)
+if(NOT nproc EQUAL 0)
+  set(parallel_arg --parallel=${nproc})
+endif()
+message(STATUS "running bootstrap: ${bootstrap} ${parallel_arg}")
 execute_process(
-  COMMAND ${bootstrap}
+  COMMAND ${bootstrap} ${parallel_arg}
   WORKING_DIRECTORY "${bin_dir}"
   RESULT_VARIABLE result
   )
diff --git a/Tests/CMakeLists.txt b/Tests/CMakeLists.txt
index 7df9403..5d72e5c 100644
--- a/Tests/CMakeLists.txt
+++ b/Tests/CMakeLists.txt
@@ -3081,8 +3081,8 @@ ${CMake_BINARY_DIR}/bin/cmake -DDIR=dev -P 
${CMake_SOURCE_DIR}/Utilities/Release
 -P ${CMAKE_CURRENT_SOURCE_DIR}/BootstrapTest.cmake
   )
 list(APPEND TEST_BUILD_DIRS "${CMake_BINARY_DIR}/Tests/BootstrapTest")
-# Make this test run early during parallel execution
-set_tests_properties(BootstrapTest PROPERTIES COST 5000)
+# This test will use all processors.
+set_tests_properties(BootstrapTest PROPERTIES RUN_SERIAL 1)
 
 # provide more time for the bootstrap test
 get_test_property(BootstrapTest TIMEOUT PREVIOUS_TIMEOUT)

---

Summary of changes:
 Tests/BootstrapTest.cmake |9 +++--
 Tests/CMakeLists.txt  |4 ++--
 2 files changed, 9 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc1-674-gec25bfb

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  ec25bfbe1a2623245fb3b7bc047b5243d3916dfd (commit)
   via  d2080ff950d88d91f80affce596171862c0fcd59 (commit)
  from  307cb3c1f24857f4ff93747c14fb268d6b20fdb4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ec25bfbe1a2623245fb3b7bc047b5243d3916dfd
commit ec25bfbe1a2623245fb3b7bc047b5243d3916dfd
Merge: 307cb3c d2080ff
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Oct 19 15:06:55 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Oct 19 15:06:55 2016 -0400

Merge topic 'clang-tidy' into next

d2080ff9 fixup! fix more issues reported by clang-tidy


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d2080ff950d88d91f80affce596171862c0fcd59
commit d2080ff950d88d91f80affce596171862c0fcd59
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Oct 19 21:06:13 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Oct 19 21:06:13 2016 +0200

fixup! fix more issues reported by clang-tidy

diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx
index 073d0d6..de48193 100644
--- a/Source/cmTarget.cxx
+++ b/Source/cmTarget.cxx
@@ -934,13 +934,15 @@ void cmTarget::AppendProperty(const std::string& prop, 
const char* value,
 e << "NAME property is read-only\n";
 this->Makefile->IssueMessage(cmake::FATAL_ERROR, e.str());
 return;
-  } else if (prop == "EXPORT_NAME" && this->IsImported()) {
+  }
+  if (prop == "EXPORT_NAME" && this->IsImported()) {
 std::ostringstream e;
 e << "EXPORT_NAME property can't be set on imported targets (\""
   << this->Name << "\")\n";
 this->Makefile->IssueMessage(cmake::FATAL_ERROR, e.str());
 return;
-  } else if (prop == "SOURCES" && this->IsImported()) {
+  }
+  if (prop == "SOURCES" && this->IsImported()) {
 std::ostringstream e;
 e << "SOURCES property can't be set on imported targets (\"" << this->Name
   << "\")\n";
diff --git a/Source/cmcmd.cxx b/Source/cmcmd.cxx
index 290261a..b878534 100644
--- a/Source/cmcmd.cxx
+++ b/Source/cmcmd.cxx
@@ -803,9 +803,13 @@ int cmcmd::ExecuteCMakeCommand(std::vector& 
args)
   }
   std::cerr << std::endl;
   return 1;
-} else if (args[1] == "vs_link_exe") {
+}
+
+if (args[1] == "vs_link_exe") {
   return cmcmd::VisualStudioLink(args, 1);
-} else if (args[1] == "vs_link_dll") {
+}
+
+if (args[1] == "vs_link_dll") {
   return cmcmd::VisualStudioLink(args, 2);
 }
 
@@ -928,7 +932,9 @@ int cmcmd::ExecuteCMakeCommand(std::vector& 
args)
 #endif
   }
   return 0;
-} else if (args[1] == "server") {
+}
+
+if (args[1] == "server") {
   const std::string pipePrefix = "--pipe=";
   bool supportExperimental = false;
   bool isDebug = false;

---

Summary of changes:
 Source/cmTarget.cxx |6 --
 Source/cmcmd.cxx|   12 +---
 2 files changed, 13 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.7.0-rc1-309-ga27be19

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  a27be19f9c4990e97310c1fbf0005aaaf9bbf40e (commit)
   via  326d5fa74781d807b9ecc2feed1b433657c3a92b (commit)
   via  7d45db99563c83a1a85722b1ee0f1fe10f8967d3 (commit)
   via  a28b8f95bca8ac99c811fe24cd1e291330a1cd28 (commit)
   via  66c6144cdafcae83fe4c36a4355a67aa69198809 (commit)
  from  c2382855e6a9706c9f71beb1f57bfafc75587f65 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a27be19f9c4990e97310c1fbf0005aaaf9bbf40e
commit a27be19f9c4990e97310c1fbf0005aaaf9bbf40e
Merge: c238285 326d5fa
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Oct 9 18:23:45 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Oct 9 18:23:45 2016 -0400

Merge topic 'cmake-cleanup' into next

326d5fa7 Allow custom built libarchive to use custom built expat.
7d45db99 Don't require liblzma when using system libarchive
a28b8f95 Don't require libbz2 when using system libarchive
66c6144c CMakeCPack: remove obsolete conditions


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=326d5fa74781d807b9ecc2feed1b433657c3a92b
commit 326d5fa74781d807b9ecc2feed1b433657c3a92b
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Oct 10 00:21:00 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Oct 10 00:21:00 2016 +0200

Allow custom built libarchive to use custom built expat.

Expat is built anyway.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 827a19c..b8a635f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -368,6 +368,23 @@ macro (CMAKE_BUILD_UTILITIES)
   CMAKE_SET_TARGET_FOLDER(cmcompress "Utilities/3rdParty")
 
   #-
+  # Build expat library for CMake, CTest, and libarchive.
+  if(CMAKE_USE_SYSTEM_EXPAT)
+find_package(EXPAT)
+if(NOT EXPAT_FOUND)
+  message(FATAL_ERROR
+"CMAKE_USE_SYSTEM_EXPAT is ON but a expat is not found!")
+endif()
+set(CMAKE_EXPAT_INCLUDES ${EXPAT_INCLUDE_DIRS})
+set(CMAKE_EXPAT_LIBRARIES ${EXPAT_LIBRARIES})
+  else()
+set(CMAKE_EXPAT_INCLUDES)
+set(CMAKE_EXPAT_LIBRARIES cmexpat)
+add_subdirectory(Utilities/cmexpat)
+CMAKE_SET_TARGET_FOLDER(cmexpat "Utilities/3rdParty")
+  endif()
+
+  #-
   # Build or use system libbz2 for libarchive.
   if(NOT CMAKE_USE_SYSTEM_LIBARCHIVE)
 if(CMAKE_USE_SYSTEM_BZIP2)
@@ -410,6 +427,8 @@ macro (CMAKE_BUILD_UTILITIES)
 set(CMAKE_TAR_INCLUDES ${LibArchive_INCLUDE_DIRS})
 set(CMAKE_TAR_LIBRARIES ${LibArchive_LIBRARIES})
   else()
+set(EXPAT_INCLUDE_DIR ${CMAKE_EXPAT_INCLUDES})
+set(EXPAT_LIBRARY ${CMAKE_EXPAT_LIBRARIES})
 set(ZLIB_INCLUDE_DIR ${CMAKE_ZLIB_INCLUDES})
 set(ZLIB_LIBRARY ${CMAKE_ZLIB_LIBRARIES})
 add_definitions(-DLIBARCHIVE_STATIC)
@@ -419,7 +438,7 @@ macro (CMAKE_BUILD_UTILITIES)
 set(ENABLE_ZLIB ON CACHE INTERNAL "Enable the use of the system found ZLIB 
library if found")
 set(ENABLE_BZip2 ON CACHE INTERNAL "Enable the use of the system found 
BZip2 library if found")
 set(ENABLE_LIBXML2 OFF CACHE INTERNAL "Enable the use of the system found 
libxml2 library if found")
-set(ENABLE_EXPAT OFF CACHE INTERNAL "Enable the use of the system found 
EXPAT library if found")
+set(ENABLE_EXPAT ON CACHE INTERNAL "Enable the use of the system found 
EXPAT library if found")
 set(ENABLE_PCREPOSIX OFF CACHE INTERNAL "Enable the use of the system 
found PCREPOSIX library if found")
 set(ENABLE_LibGCC OFF CACHE INTERNAL "Enable the use of the system found 
LibGCC library if found")
 set(ENABLE_XATTR OFF CACHE INTERNAL "Enable extended attribute support")
@@ -432,23 +451,6 @@ macro (CMAKE_BUILD_UTILITIES)
   endif()
 
   #-
-  # Build expat library for CMake and CTest.
-  if(CMAKE_USE_SYSTEM_EXPAT)
-find_package(EXPAT)
-if(NOT EXPAT_FOUND)
-  message(FATAL_ERROR
-"CMAKE_USE_SYSTEM_EXPAT is ON but a expat is not found!")
-endif()
-set(CMAKE_EXPAT_INCLUDES ${EXPAT_INCLUDE_DIRS})
-set(CMAKE_EXPAT_LIBRARIES ${EXPAT_LIBRARIES})
-  else()
-set(CMAKE_EXPAT_INCLUDES)
-set(CMAKE_EXPAT_LIBRARIES cmexpat)
-add_subdirectory(Utilities/cmexpat)
-CMAKE_SET_TARGET_FOLDER(cmexpat "Utiliti

Re: [cmake-developers] Is there a way in CMake to get a list of all CTest tests added with add_test?

[Daniel Pfeifer]

On Wed, Oct 5, 2016 at 12:54 PM, Nils Gladitz  wrote:
> On 04.10.2016 11:20, Tobias Hunger wrote:
>>
>> On Mo, 2016-10-03 at 14:25 -0400, Brad King wrote:

 The list we need would thus be built up to contain all COMMAND
 arguments to add_test that are also build targets in CMake.
>>>
>>> The list would also need to include targets mentioned in generator
>>> expressions such as `$`.  This will almost certainly
>>> be better done as a CMake feature implemented in C++.  This was actually
>>> an early design philosophy: do the hard stuff in C++ so that complex
>>> logic is not needed in CMake-language code.
>>
>> Access to the list of defined tests would be nice to have in the
>> server-mode,
>> too:-)
>>
>> If some work is done in that direction, please keep server-mode in mind
>> when
>> designing the APIs. I would love to reuse them to expose that information
>> to
>> clients.
>
>
> This might be rare but the tests that cmake knows about might differ from
> the tests that ctest knows about given that tests can be dynamically defined
> through TEST_INCLUDE_FILE[1].
>
> I've never used it that way but I was considering e.g. querying test
> binaries (produced at build time) for the tests they define and making those
> available dynamically when ctest processes CTestTestfile.cmake. This is in
> contrast to e.g. FindGTests.cmake's GTEST_ADD_TESTS() which tries to
> accomplish the same thing at configuration time by parsing test sources
> instead.

+1. I wrote about that approach here:
http://purplekarrot.net/blog/cmake-and-test-suites.html
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] semantics of ctest_build(APPEND)

[Daniel Pfeifer]

Hi,

the documentation of the ctest_build command states "Append semantics
are defined by the dashboard server in use." I think this is not
precise enough.

The client side effect of APPEND is that CTest creates an
Append="true" attribute in the XML. It does not append anything to the
already existing file. The existing file is overwritten.

For append to work as expected, it is necessary to call
ctest_submit(PARTS Build) between the ctest_build commands. This is
not documented.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.6.2-2458-g7ee381d

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  7ee381d0f5f46674cab4e9554236d6249010655d (commit)
   via  05e6d18bebfa01059ebb43505c0eba6f6c56af73 (commit)
  from  ac947c5134adb8bf9a100843082b45c4a7ed7097 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7ee381d0f5f46674cab4e9554236d6249010655d
commit 7ee381d0f5f46674cab4e9554236d6249010655d
Merge: ac947c5 05e6d18
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Sep 25 01:52:46 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Sep 25 01:52:46 2016 -0400

Merge topic 'auto-ptr' into next

05e6d18b fixup! Add a feature check to test availability of auto_ptr


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=05e6d18bebfa01059ebb43505c0eba6f6c56af73
commit 05e6d18bebfa01059ebb43505c0eba6f6c56af73
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Sep 25 07:52:23 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Sep 25 07:52:23 2016 +0200

fixup! Add a feature check to test availability of auto_ptr

diff --git a/Source/Checks/cm_cxx_features.cmake 
b/Source/Checks/cm_cxx_features.cmake
index 83bcff5..80c9f3b 100644
--- a/Source/Checks/cm_cxx_features.cmake
+++ b/Source/Checks/cm_cxx_features.cmake
@@ -32,11 +32,11 @@ function(cm_check_cxx_feature name)
 endfunction()
 
 if(CMAKE_CXX_STANDARD)
+  cm_check_cxx_feature(auto_ptr)
   cm_check_cxx_feature(make_unique)
   if(CMake_HAVE_CXX_MAKE_UNIQUE)
 set(CMake_HAVE_CXX_UNIQUE_PTR 1)
   endif()
-  cm_check_cxx_feature(auto_ptr)
   cm_check_cxx_feature(nullptr)
   cm_check_cxx_feature(override)
   cm_check_cxx_feature(unique_ptr)

---

Summary of changes:
 Source/Checks/cm_cxx_features.cmake |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.2-2442-g9041fb2

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  9041fb2470a9df8ce922bb0c8e591e99b98fd5fd (commit)
   via  92207752dfaeeffe674946a7139475777ad90eac (commit)
  from  ffa78c37c8efccc0d73ceae0fd0c31eabca1633d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9041fb2470a9df8ce922bb0c8e591e99b98fd5fd
commit 9041fb2470a9df8ce922bb0c8e591e99b98fd5fd
Merge: ffa78c3 9220775
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 16:44:08 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 23 16:44:08 2016 -0400

Merge topic 'tidy-server' into next

92207752 cmServer: add braces around conditional statements


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=92207752dfaeeffe674946a7139475777ad90eac
commit 92207752dfaeeffe674946a7139475777ad90eac
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 22:43:36 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 23 22:43:36 2016 +0200

cmServer: add braces around conditional statements

diff --git a/Source/cmServer.cxx b/Source/cmServer.cxx
index d5dac4e..46c1946 100644
--- a/Source/cmServer.cxx
+++ b/Source/cmServer.cxx
@@ -123,8 +123,9 @@ void cmServer::RegisterProtocol(cmServerProtocol* protocol)
  [version](cmServerProtocol* p) {
return p->ProtocolVersion() == version;
  });
-  if (it == this->SupportedProtocols.end())
+  if (it == this->SupportedProtocols.end()) {
 this->SupportedProtocols.push_back(protocol);
+  }
 }
 
 void cmServer::PrintHello() const
@@ -181,37 +182,44 @@ void cmServer::reportMessage(const char* msg, const char* 
title,
 
 cmServerResponse cmServer::SetProtocolVersion(const cmServerRequest& request)
 {
-  if (request.Type != kHANDSHAKE_TYPE)
+  if (request.Type != kHANDSHAKE_TYPE) {
 return request.ReportError("Waiting for type \"" + kHANDSHAKE_TYPE +
"\".");
+  }
 
   Json::Value requestedProtocolVersion = request.Data[kPROTOCOL_VERSION_KEY];
-  if (requestedProtocolVersion.isNull())
+  if (requestedProtocolVersion.isNull()) {
 return request.ReportError("\"" + kPROTOCOL_VERSION_KEY +
"\" is required for \"" + kHANDSHAKE_TYPE +
"\".");
+  }
 
-  if (!requestedProtocolVersion.isObject())
+  if (!requestedProtocolVersion.isObject()) {
 return request.ReportError("\"" + kPROTOCOL_VERSION_KEY +
"\" must be a JSON object.");
+  }
 
   Json::Value majorValue = requestedProtocolVersion[kMAJOR_KEY];
-  if (!majorValue.isInt())
+  if (!majorValue.isInt()) {
 return request.ReportError("\"" + kMAJOR_KEY +
"\" must be set and an integer.");
+  }
 
   Json::Value minorValue = requestedProtocolVersion[kMINOR_KEY];
-  if (!minorValue.isNull() && !minorValue.isInt())
+  if (!minorValue.isNull() && !minorValue.isInt()) {
 return request.ReportError("\"" + kMINOR_KEY +
"\" must be unset or an integer.");
+  }
 
   const int major = majorValue.asInt();
   const int minor = minorValue.isNull() ? -1 : minorValue.asInt();
-  if (major < 0)
+  if (major < 0) {
 return request.ReportError("\"" + kMAJOR_KEY + "\" must be >= 0.");
-  if (!minorValue.isNull() && minor < 0)
+  }
+  if (!minorValue.isNull() && minor < 0) {
 return request.ReportError("\"" + kMINOR_KEY +
"\" must be >= 0 when set.");
+  }
 
   this->Protocol =
 this->FindMatchingProtocol(this->SupportedProtocols, major, minor);
@@ -284,12 +292,15 @@ cmServerProtocol* cmServer::FindMatchingProtocol(
   cmServerProtocol* bestMatch = nullptr;
   for (auto protocol : protocols) {
 auto version = protocol->ProtocolVersion();
-if (major != version.first)
+if (major != version.first) {
   continue;
-if (minor == version.second)
+}
+if (minor == version.second) {
   return protocol;
-if (!bestMatch || bestMatch->ProtocolVersion().second < version.second)
+}
+if (!bestMatch || bestMatch->ProtocolVersion().second < version.second) {
   bestMatch = protocol;

[Cmake-commits] CMake branch, next, updated. v3.6.2-2440-gffa78c3

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  ffa78c37c8efccc0d73ceae0fd0c31eabca1633d (commit)
   via  b941f3bfe7ba3bffd535372c2a4d9d668bc83356 (commit)
   via  a5a7771a428a1d4a9bb671e56ea6d497361bc753 (commit)
   via  6ed564577dd0fffdd7dabfaa0ba14e2518c26048 (commit)
  from  3c6d4f69016e6ce48430b3d49c63857aaeb14b76 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ffa78c37c8efccc0d73ceae0fd0c31eabca1633d
commit ffa78c37c8efccc0d73ceae0fd0c31eabca1633d
Merge: 3c6d4f6 b941f3b
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 16:07:41 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 23 16:07:41 2016 -0400

Merge topic 'ctest-no-manual-delete' into next

b941f3bf CTest::CompressString: Avoid manual delete
a5a7771a CTest::CompressString: Reorder code to avoid unnecessary allocation
6ed56457 CTest::Base64EncodeFile: Avoid manual delete


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b941f3bfe7ba3bffd535372c2a4d9d668bc83356
commit b941f3bfe7ba3bffd535372c2a4d9d668bc83356
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 22:06:17 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 23 22:06:17 2016 +0200

CTest::CompressString: Avoid manual delete

diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index 0624b52..9b5248e 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -2803,34 +2803,29 @@ bool cmCTest::CompressString(std::string& str)
   // zlib makes the guarantee that this is the maximum output size
   int outSize =
 static_cast(static_cast(str.size()) * 1.001 + 13.0);
-  unsigned char* out = new unsigned char[outSize];
+  std::vector out(outSize);
 
   strm.avail_in = static_cast(str.size());
   strm.next_in = in;
   strm.avail_out = outSize;
-  strm.next_out = out;
+  strm.next_out = [0];
   ret = deflate(, Z_FINISH);
 
   if (ret == Z_STREAM_ERROR || ret != Z_STREAM_END) {
 cmCTestLog(this, ERROR_MESSAGE, "Error during gzip compression."
  << std::endl);
-delete[] out;
 return false;
   }
 
   (void)deflateEnd();
 
   // Now base64 encode the resulting binary string
-  unsigned char* base64EncodedBuffer = new unsigned char[(outSize * 3) / 2];
+  std::vector base64EncodedBuffer((outSize * 3) / 2);
 
   size_t rlen =
-cmsysBase64_Encode(out, strm.total_out, base64EncodedBuffer, 1);
+cmsysBase64_Encode([0], strm.total_out, [0], 1);
 
-  str = "";
-  str.append(reinterpret_cast<char*>(base64EncodedBuffer), rlen);
-
-  delete[] base64EncodedBuffer;
-  delete[] out;
+  str.assign(reinterpret_cast<char*>([0]), rlen);
 
   return true;
 }

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a5a7771a428a1d4a9bb671e56ea6d497361bc753
commit a5a7771a428a1d4a9bb671e56ea6d497361bc753
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 22:04:47 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 23 22:04:47 2016 +0200

CTest::CompressString: Reorder code to avoid unnecessary allocation

diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index d058ca7..0624b52 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -2790,22 +2790,21 @@ bool cmCTest::CompressString(std::string& str)
   int ret;
   z_stream strm;
 
-  unsigned char* in =
-reinterpret_cast(const_cast<char*>(str.c_str()));
-  // zlib makes the guarantee that this is the maximum output size
-  int outSize =
-static_cast(static_cast(str.size()) * 1.001 + 13.0);
-  unsigned char* out = new unsigned char[outSize];
-
   strm.zalloc = Z_NULL;
   strm.zfree = Z_NULL;
   strm.opaque = Z_NULL;
   ret = deflateInit(, -1); // default compression level
   if (ret != Z_OK) {
-delete[] out;
 return false;
   }
 
+  unsigned char* in =
+reinterpret_cast(const_cast<char*>(str.c_str()));
+  // zlib makes the guarantee that this is the maximum output size
+  int outSize =
+static_cast(static_cast(str.size()) * 1.001 + 13.0);
+  unsigned char* out = new unsigned char[outSize];
+
   strm.avail_in = static_cast(str.size());
   strm.next_in = in;
   strm.avail_out = outSize;

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6ed564577dd0fffdd7dabfaa0ba14e2518c26048
commit 6ed564577dd0fffdd7dabfaa0ba14e2518c26048
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 22:03:49 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate:

[Cmake-commits] CMake branch, next, updated. v3.6.2-2436-g3c6d4f6

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  3c6d4f69016e6ce48430b3d49c63857aaeb14b76 (commit)
   via  061e0e1b30ad8db23e9c416c983627c618cb2737 (commit)
   via  a2bf3ec9f86a3395ba79764167bd44690a379766 (commit)
  from  b09e96ba1960ce16f09b73767b9d3a2a171b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3c6d4f69016e6ce48430b3d49c63857aaeb14b76
commit 3c6d4f69016e6ce48430b3d49c63857aaeb14b76
Merge: b09e900 061e0e1
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 15:57:08 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 23 15:57:08 2016 -0400

Merge topic 'auto-ptr' into next

061e0e1b Use std::auto_ptr on compilers that do not warn about it
a2bf3ec9 Add a feature check to test availability of auto_ptr


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=061e0e1b30ad8db23e9c416c983627c618cb2737
commit 061e0e1b30ad8db23e9c416c983627c618cb2737
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 21:56:34 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 23 21:56:34 2016 +0200

Use std::auto_ptr on compilers that do not warn about it

diff --git a/Source/cm_auto_ptr.hxx b/Source/cm_auto_ptr.hxx
index f6c4362..f38eda5 100644
--- a/Source/cm_auto_ptr.hxx
+++ b/Source/cm_auto_ptr.hxx
@@ -14,7 +14,13 @@
 
 #include 
 
-// FIXME: Use std::auto_ptr on compilers that do not warn about it.
+#ifdef CMake_HAVE_CXX_AUTO_PTR
+
+#include 
+#define CM_AUTO_PTR std::auto_ptr
+
+#else
+
 #define CM_AUTO_PTR cm::auto_ptr
 
 // The HP compiler cannot handle the conversions necessary to use
@@ -219,3 +225,5 @@ public:
 #endif
 
 #endif
+
+#endif

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a2bf3ec9f86a3395ba79764167bd44690a379766
commit a2bf3ec9f86a3395ba79764167bd44690a379766
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 23 21:49:12 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 23 21:49:12 2016 +0200

Add a feature check to test availability of auto_ptr

diff --git a/Source/Checks/cm_cxx_auto_ptr.cxx 
b/Source/Checks/cm_cxx_auto_ptr.cxx
new file mode 100644
index 000..fc49346
--- /dev/null
+++ b/Source/Checks/cm_cxx_auto_ptr.cxx
@@ -0,0 +1,16 @@
+#include 
+
+std::auto_ptr get_auto_ptr()
+{
+  return std::auto_ptr(new int(0));
+}
+
+int use_auto_ptr(std::auto_ptr ptr)
+{
+  return *ptr;
+}
+
+int main()
+{
+  return use_auto_ptr(get_auto_ptr());
+}
diff --git a/Source/Checks/cm_cxx_features.cmake 
b/Source/Checks/cm_cxx_features.cmake
index c6a532f..83bcff5 100644
--- a/Source/Checks/cm_cxx_features.cmake
+++ b/Source/Checks/cm_cxx_features.cmake
@@ -36,6 +36,7 @@ if(CMAKE_CXX_STANDARD)
   if(CMake_HAVE_CXX_MAKE_UNIQUE)
 set(CMake_HAVE_CXX_UNIQUE_PTR 1)
   endif()
+  cm_check_cxx_feature(auto_ptr)
   cm_check_cxx_feature(nullptr)
   cm_check_cxx_feature(override)
   cm_check_cxx_feature(unique_ptr)
diff --git a/Source/cmConfigure.cmake.h.in b/Source/cmConfigure.cmake.h.in
index 8365367..8a1e81f 100644
--- a/Source/cmConfigure.cmake.h.in
+++ b/Source/cmConfigure.cmake.h.in
@@ -30,6 +30,7 @@
 #cmakedefine CMAKE_USE_MACH_PARSER
 #cmakedefine CMAKE_USE_LIBUV
 #cmakedefine CMAKE_ENCODING_UTF8
+#cmakedefine CMake_HAVE_CXX_AUTO_PTR
 #cmakedefine CMake_HAVE_CXX_MAKE_UNIQUE
 #cmakedefine CMake_HAVE_CXX_NULLPTR
 #cmakedefine CMake_HAVE_CXX_OVERRIDE

---

Summary of changes:
 Source/Checks/cm_cxx_auto_ptr.cxx   |   16 
 Source/Checks/cm_cxx_features.cmake |1 +
 Source/cmConfigure.cmake.h.in   |1 +
 Source/cm_auto_ptr.hxx  |   10 +-
 4 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 Source/Checks/cm_cxx_auto_ptr.cxx


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.2-2139-ga1d30dc

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  a1d30dcccfa79e3f79ab13c88749a8d0f04f14aa (commit)
   via  3fab1fef23476b27274cddf4bb8f6cbe8d36c712 (commit)
  from  df4c1374fb8c4e1a966fc3610c4af0fc13d05fd5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a1d30dcccfa79e3f79ab13c88749a8d0f04f14aa
commit a1d30dcccfa79e3f79ab13c88749a8d0f04f14aa
Merge: df4c137 3fab1fe
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 17:31:48 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 16 17:31:48 2016 -0400

Merge topic 'clang-tidy-fixes' into next

3fab1fef cmNinjaNormalTargetGenerator: make sure comments match parameter 
names


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3fab1fef23476b27274cddf4bb8f6cbe8d36c712
commit 3fab1fef23476b27274cddf4bb8f6cbe8d36c712
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 23:31:37 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 16 23:31:37 2016 +0200

cmNinjaNormalTargetGenerator: make sure comments match parameter names

diff --git a/Source/cmNinjaNormalTargetGenerator.cxx 
b/Source/cmNinjaNormalTargetGenerator.cxx
index 335b552..b2384b0 100644
--- a/Source/cmNinjaNormalTargetGenerator.cxx
+++ b/Source/cmNinjaNormalTargetGenerator.cxx
@@ -336,7 +336,7 @@ std::vector 
cmNinjaNormalTargetGenerator::ComputeLinkCmd()
 std::string targetOutputReal =
   this->ConvertToNinjaPath(gt.GetFullPath(cfgName,
   /*implib=*/false,
-  /*realpath=*/true));
+  /*realname=*/true));
 cmakeCommand += targetOutputReal;
 cmakeCommand += " || true";
 linkCmds.push_back(cmakeCommand);
@@ -414,7 +414,7 @@ void cmNinjaNormalTargetGenerator::WriteLinkStatement()
   std::string targetOutputReal =
 ConvertToNinjaPath(gt.GetFullPath(cfgName,
   /*implib=*/false,
-  /*realpath=*/true));
+  /*realname=*/true));
   std::string targetOutputImplib =
 ConvertToNinjaPath(gt.GetFullPath(cfgName,
   /*implib=*/true));

---

Summary of changes:
 Source/cmNinjaNormalTargetGenerator.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.2-2137-gdf4c137

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  df4c1374fb8c4e1a966fc3610c4af0fc13d05fd5 (commit)
   via  7b94a7adb32d1a8966628d2b194cfc5de04d7ecc (commit)
  from  7a2e9e8cb77e7ceeb7a160c8e83ed974c3db10b2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=df4c1374fb8c4e1a966fc3610c4af0fc13d05fd5
commit df4c1374fb8c4e1a966fc3610c4af0fc13d05fd5
Merge: 7a2e9e8 7b94a7a
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 17:17:39 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 16 17:17:39 2016 -0400

Merge topic 'clang-tidy-fixes' into next

7b94a7ad cmCommandArgumentsHelper: simplify boolean expression


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7b94a7adb32d1a8966628d2b194cfc5de04d7ecc
commit 7b94a7adb32d1a8966628d2b194cfc5de04d7ecc
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 23:16:54 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 16 23:16:54 2016 +0200

cmCommandArgumentsHelper: simplify boolean expression

diff --git a/Source/cmCommandArgumentsHelper.cxx 
b/Source/cmCommandArgumentsHelper.cxx
index 1345bd5..b8fe365 100644
--- a/Source/cmCommandArgumentsHelper.cxx
+++ b/Source/cmCommandArgumentsHelper.cxx
@@ -57,14 +57,7 @@ bool cmCommandArgument::MayFollow(const cmCommandArgument* 
current) const
   if (this->ArgumentsBeforeEmpty) {
 return true;
   }
-
-  std::set::const_iterator argIt =
-this->ArgumentsBefore.find(current);
-  if (argIt != this->ArgumentsBefore.end()) {
-return true;
-  }
-
-  return false;
+  return this->ArgumentsBefore.find(current) != this->ArgumentsBefore.end();
 }
 
 bool cmCommandArgument::KeyMatches(const std::string& key) const

---

Summary of changes:
 Source/cmCommandArgumentsHelper.cxx |9 +
 1 file changed, 1 insertion(+), 8 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.2-2135-g7a2e9e8

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  7a2e9e8cb77e7ceeb7a160c8e83ed974c3db10b2 (commit)
   via  782fcbb92e096a28f899c89eed6fe23f29cd997c (commit)
   via  809ca6c81fa23cec111a9e97529d71538c55f9eb (commit)
   via  516f8edb2e061749c56b6f9a58332fbf59e45a1a (commit)
   via  d9f5d3c50fe376423382d6445f7fb2906a43469e (commit)
   via  3fda10945132fdd2dc11ea074a96789a4afa86bc (commit)
  from  f9224eb7b28c6c6456524906103e7f26b5afe17e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7a2e9e8cb77e7ceeb7a160c8e83ed974c3db10b2
commit 7a2e9e8cb77e7ceeb7a160c8e83ed974c3db10b2
Merge: f9224eb 782fcbb
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 17:04:57 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 16 17:04:57 2016 -0400

Merge topic 'clang-tidy-fixes' into next

782fcbb9 Use CM_NULLPTR
809ca6c8 Use braces around statements
516f8edb Avoid else after return
d9f5d3c5 Remove redundant get() call on smart pointer
3fda1094 Mark overridden functions with CM_OVERRIDE


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=782fcbb92e096a28f899c89eed6fe23f29cd997c
commit 782fcbb92e096a28f899c89eed6fe23f29cd997c
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 23:01:40 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 16 23:01:40 2016 +0200

Use CM_NULLPTR

diff --git a/Source/cmGetPropertyCommand.cxx b/Source/cmGetPropertyCommand.cxx
index 3aef9cf..8063328 100644
--- a/Source/cmGetPropertyCommand.cxx
+++ b/Source/cmGetPropertyCommand.cxx
@@ -253,7 +253,7 @@ bool cmGetPropertyCommand::HandleTargetMode()
   if (this->Makefile->IsAlias(this->Name)) {
 return this->StoreResult(target->GetName().c_str());
   }
-  return this->StoreResult(NULL);
+  return this->StoreResult(CM_NULLPTR);
 }
 return this->StoreResult(
   target->GetProperty(this->PropertyName, this->Makefile));
diff --git a/Source/cmInstallCommand.cxx b/Source/cmInstallCommand.cxx
index f55fefb..8450360 100644
--- a/Source/cmInstallCommand.cxx
+++ b/Source/cmInstallCommand.cxx
@@ -1118,7 +1118,7 @@ bool cmInstallCommand::HandleExportAndroidMKMode(
   cmCAEnabler exportOld(, "EXPORT_LINK_INTERFACE_LIBRARIES",
 );
   cmCAString filename(, "FILE", );
-  exp.Follows(0);
+  exp.Follows(CM_NULLPTR);
 
   ica.ArgumentGroup.Follows();
   std::vector unknownArgs;
diff --git a/Source/cm_auto_ptr.hxx b/Source/cm_auto_ptr.hxx
index 2cd35c3..f6c4362 100644
--- a/Source/cm_auto_ptr.hxx
+++ b/Source/cm_auto_ptr.hxx
@@ -12,7 +12,7 @@
 #ifndef CM_AUTO_PTR_HXX
 #define CM_AUTO_PTR_HXX
 
-#include 
+#include 
 
 // FIXME: Use std::auto_ptr on compilers that do not warn about it.
 #define CM_AUTO_PTR cm::auto_ptr
@@ -115,7 +115,7 @@ public:
*
*   auto_ptr ptr(new X());
*/
-  explicit auto_ptr(X* p = 0) throw()
+  explicit auto_ptr(X* p = CM_NULLPTR) throw()
 : x_(p)
   {
   }
@@ -157,7 +157,7 @@ public:
   X* release() throw()
   {
 X* x = this->x_;
-this->x_ = 0;
+this->x_ = CM_NULLPTR;
 return x;
   }
 

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=809ca6c81fa23cec111a9e97529d71538c55f9eb
commit 809ca6c81fa23cec111a9e97529d71538c55f9eb
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 16 22:52:02 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 16 22:52:02 2016 +0200

Use braces around statements

diff --git a/Source/cmCMakeHostSystemInformationCommand.cxx 
b/Source/cmCMakeHostSystemInformationCommand.cxx
index fdbd5e7..6ff7575 100644
--- a/Source/cmCMakeHostSystemInformationCommand.cxx
+++ b/Source/cmCMakeHostSystemInformationCommand.cxx
@@ -42,9 +42,9 @@ bool cmCMakeHostSystemInformationCommand::InitialPass(
   result_list += ";";
 }
 std::string value;
-if (!this->GetValue(info, key, value))
+if (!this->GetValue(info, key, value)) {
   return false;
-
+}
 result_list += value;
   }
 
diff --git a/Source/cmFileCommand.cxx b/Source/cmFileCommand.cxx
index 8356fc7..a13309d 100644
--- a/Source/cmFileCommand.cxx
+++ b/Source/cmFileCommand.cxx
@@ -600,8 +600,9 @@ bool 
cmFileCommand::HandleStringsCommand(std::vector const& args)
   // how many octets are there?
   unsigned int num_utf8_bytes = 0;
   for (unsigned int j = 0; num_utf8_bytes == 0 && j < 3; j++

[Cmake-commits] CMake branch, next, updated. v3.6.2-2096-gcafd74b

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  cafd74b307f291f13ac950a3cb671c758676f0ad (commit)
   via  73f648f167e9b11739c4dbbdbd5c024baf1e39ad (commit)
  from  0c73aea46ad9b453e69e0b9de331e1d28742a888 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cafd74b307f291f13ac950a3cb671c758676f0ad
commit cafd74b307f291f13ac950a3cb671c758676f0ad
Merge: 0c73aea 73f648f
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 15 17:59:57 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Sep 15 17:59:57 2016 -0400

Merge topic 'size-empty' into next

73f648f1 use empty method to check for emptyness


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=73f648f167e9b11739c4dbbdbd5c024baf1e39ad
commit 73f648f167e9b11739c4dbbdbd5c024baf1e39ad
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 15 23:59:29 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Sep 15 23:59:29 2016 +0200

use empty method to check for emptyness

diff --git a/Source/cmAddCompileOptionsCommand.cxx 
b/Source/cmAddCompileOptionsCommand.cxx
index 2223cf4..cbba831 100644
--- a/Source/cmAddCompileOptionsCommand.cxx
+++ b/Source/cmAddCompileOptionsCommand.cxx
@@ -14,7 +14,7 @@
 bool cmAddCompileOptionsCommand::InitialPass(
   std::vector const& args, cmExecutionStatus&)
 {
-  if (args.size() < 1) {
+  if (args.empty()) {
 return true;
   }
 
diff --git a/Source/cmAddCustomTargetCommand.cxx 
b/Source/cmAddCustomTargetCommand.cxx
index 9dc7c59..8e14966 100644
--- a/Source/cmAddCustomTargetCommand.cxx
+++ b/Source/cmAddCustomTargetCommand.cxx
@@ -18,7 +18,7 @@
 bool cmAddCustomTargetCommand::InitialPass(
   std::vector const& args, cmExecutionStatus&)
 {
-  if (args.size() < 1) {
+  if (args.empty()) {
 this->SetError("called with incorrect number of arguments");
 return false;
   }
diff --git a/Source/cmAddDefinitionsCommand.cxx 
b/Source/cmAddDefinitionsCommand.cxx
index 2d0d026..5f2b32f 100644
--- a/Source/cmAddDefinitionsCommand.cxx
+++ b/Source/cmAddDefinitionsCommand.cxx
@@ -16,7 +16,7 @@ bool 
cmAddDefinitionsCommand::InitialPass(std::vector const& args,
   cmExecutionStatus&)
 {
   // it is OK to have no arguments
-  if (args.size() < 1) {
+  if (args.empty()) {
 return true;
   }
 
diff --git a/Source/cmAddLibraryCommand.cxx b/Source/cmAddLibraryCommand.cxx
index 4516ed2..5a40050 100644
--- a/Source/cmAddLibraryCommand.cxx
+++ b/Source/cmAddLibraryCommand.cxx
@@ -18,7 +18,7 @@
 bool cmAddLibraryCommand::InitialPass(std::vector const& args,
   cmExecutionStatus&)
 {
-  if (args.size() < 1) {
+  if (args.empty()) {
 this->SetError("called with incorrect number of arguments");
 return false;
   }
diff --git a/Source/cmAddSubDirectoryCommand.cxx 
b/Source/cmAddSubDirectoryCommand.cxx
index 63a9051..1a781cc 100644
--- a/Source/cmAddSubDirectoryCommand.cxx
+++ b/Source/cmAddSubDirectoryCommand.cxx
@@ -15,7 +15,7 @@
 bool cmAddSubDirectoryCommand::InitialPass(
   std::vector const& args, cmExecutionStatus&)
 {
-  if (args.size() < 1) {
+  if (args.empty()) {
 this->SetError("called with incorrect number of arguments");
 return false;
   }
diff --git a/Source/cmBuildCommand.cxx b/Source/cmBuildCommand.cxx
index 9830867..6146053 100644
--- a/Source/cmBuildCommand.cxx
+++ b/Source/cmBuildCommand.cxx
@@ -27,7 +27,7 @@ bool cmBuildCommand::InitialPass(std::vector 
const& args,
 
 bool cmBuildCommand::MainSignature(std::vector const& args)
 {
-  if (args.size() < 1) {
+  if (args.empty()) {
 this->SetError("requires at least one argument naming a CMake variable");
 return false;
   }
diff --git a/Source/cmBuildNameCommand.cxx b/Source/cmBuildNameCommand.cxx
index 27234d7..3d02034 100644
--- a/Source/cmBuildNameCommand.cxx
+++ b/Source/cmBuildNameCommand.cxx
@@ -22,7 +22,7 @@ bool cmBuildNameCommand::InitialPass(std::vector 
const& args,
 "The build_name command should not be called; see CMP0036.")) {
 return true;
   }
-  if (args.size() < 1) {
+  if (args.empty()) {
 this->SetError("called with incorrect number of arguments");
 return false;
   }
diff --git a/Source/cmCMakePolicyCommand.cxx b/Source/cmCMakePolicyCommand.cxx
index 07e0885..03c4a37 100644
--- a/Source/cmCMakePolicyCommand.cxx
+++ b/Source/cmCMakePoli

[Cmake-commits] CMake branch, next, updated. v3.6.2-1926-g997dd7f

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  997dd7fe2e6cb1369d6c8435bf34fd25f51728d9 (commit)
   via  8154a4b097286c61d0a98703bd5662dd79bd9b97 (commit)
  from  a7316d4696dc3e6b4d5fae8b09132f0821c2e810 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=997dd7fe2e6cb1369d6c8435bf34fd25f51728d9
commit 997dd7fe2e6cb1369d6c8435bf34fd25f51728d9
Merge: a7316d4 8154a4b
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Sep 11 14:32:15 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sun Sep 11 14:32:15 2016 -0400

Merge topic 'clang-tidy' into next

8154a4b0 fixup! cmSystemTools: simplify boolean expressions


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8154a4b097286c61d0a98703bd5662dd79bd9b97
commit 8154a4b097286c61d0a98703bd5662dd79bd9b97
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sun Sep 11 20:31:43 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sun Sep 11 20:31:43 2016 +0200

fixup! cmSystemTools: simplify boolean expressions

diff --git a/Source/cmSystemTools.cxx b/Source/cmSystemTools.cxx
index ae0323b..7352217 100644
--- a/Source/cmSystemTools.cxx
+++ b/Source/cmSystemTools.cxx
@@ -1766,7 +1766,7 @@ bool cmSystemTools::CopyFileTime(const char* fromFile, 
const char* toFile)
   if (!GetFileTime(hFrom, , , )) {
 return false;
   }
-  return SetFileTime(hTo, , , );
+  return SetFileTime(hTo, , , ) != 0;
 #else
   struct stat fromStat;
   if (stat(fromFile, ) < 0) {
@@ -1824,7 +1824,7 @@ bool cmSystemTools::FileTimeSet(const char* fname, 
cmSystemToolsFileTime* t)
 return false;
   }
   return SetFileTime(h, >timeCreation, >timeLastAccess,
- >timeLastWrite);
+ >timeLastWrite) != 0;
 #else
   return utime(fname, >timeBuf) >= 0;
 #endif

---

Summary of changes:
 Source/cmSystemTools.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.2-1881-g59edc3f

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  59edc3fb74ca1eb857601c63bb01c682c1a8466b (commit)
   via  cc6b948e5ea86996fe65014ce8f97bf92b46e4c0 (commit)
   via  52052ef88b6f46a12c8430395ae8b419971fcb35 (commit)
   via  3b3622305bb950f16f238f030c8f32786ad3511a (commit)
  from  905f5f00754d5e3e632b829e4f4f2e4db6f64f52 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=59edc3fb74ca1eb857601c63bb01c682c1a8466b
commit 59edc3fb74ca1eb857601c63bb01c682c1a8466b
Merge: 905f5f0 cc6b948
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 8 17:55:06 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Sep 8 17:55:06 2016 -0400

Merge topic 'cmGeneratorTarget-cleanup' into next

cc6b948e cmGeneratorTarget: factor out common part of AddSources commands
52052ef8 cmGeneratorTarget: use erase-unique instead of reinitialization
3b362230 cmGeneratorTarget: don't clear container in destructor


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cc6b948e5ea86996fe65014ce8f97bf92b46e4c0
commit cc6b948e5ea86996fe65014ce8f97bf92b46e4c0
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Sep 7 21:14:29 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Sep 8 23:47:16 2016 +0200

cmGeneratorTarget: factor out common part of AddSources commands

diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index 4baec03..7dd8e7f 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -468,9 +468,8 @@ std::string cmGeneratorTarget::GetOutputName(const 
std::string& config,
   return i->second;
 }
 
-void cmGeneratorTarget::AddSource(const std::string& src)
+void cmGeneratorTarget::AddSourceCommon(const std::string& src)
 {
-  this->Target->AddSource(src);
   cmListFileBacktrace lfbt = this->Makefile->GetBacktrace();
   cmGeneratorExpression ge(lfbt);
   CM_AUTO_PTR cge = ge.Parse(src);
@@ -480,19 +479,17 @@ void cmGeneratorTarget::AddSource(const std::string& src)
   this->LinkImplementationLanguageIsContextDependent = true;
 }
 
+void cmGeneratorTarget::AddSource(const std::string& src)
+{
+  this->Target->AddSource(src);
+  this->AddSourceCommon(src);
+}
+
 void cmGeneratorTarget::AddTracedSources(std::vector const& srcs)
 {
   this->Target->AddTracedSources(srcs);
   if (!srcs.empty()) {
-std::string srcFiles = cmJoin(srcs, ";");
-this->SourceFilesMap.clear();
-this->LinkImplementationLanguageIsContextDependent = true;
-cmListFileBacktrace lfbt = this->Makefile->GetBacktrace();
-cmGeneratorExpression ge(lfbt);
-CM_AUTO_PTR cge = ge.Parse(srcFiles);
-cge->SetEvaluateForBuildsystem(true);
-this->SourceEntries.push_back(
-  new cmGeneratorTarget::TargetPropertyEntry(cge));
+this->AddSourceCommon(cmJoin(srcs, ";"));
   }
 }
 
diff --git a/Source/cmGeneratorTarget.h b/Source/cmGeneratorTarget.h
index 173f15d..715220e 100644
--- a/Source/cmGeneratorTarget.h
+++ b/Source/cmGeneratorTarget.h
@@ -540,6 +540,8 @@ public:
   std::string GetFortranModuleDirectory() const;
 
 private:
+  void AddSourceCommon(const std::string& src);
+
   std::string CreateFortranModuleDirectory() const;
   mutable bool FortranModuleDirectoryCreated;
   mutable std::string FortranModuleDirectory;

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=52052ef88b6f46a12c8430395ae8b419971fcb35
commit 52052ef88b6f46a12c8430395ae8b419971fcb35
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Sep 7 21:03:18 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Sep 8 23:46:45 2016 +0200

cmGeneratorTarget: use erase-unique instead of reinitialization

Just to make it easier to find places where containers are cleared in
order to be recomputed.

diff --git a/Source/cmGeneratorTarget.cxx b/Source/cmGeneratorTarget.cxx
index 25917f8..4baec03 100644
--- a/Source/cmGeneratorTarget.cxx
+++ b/Source/cmGeneratorTarget.cxx
@@ -839,14 +839,10 @@ bool cmGeneratorTarget::IsSystemIncludeDirectory(
   , result, excludeImported);
 }
 
-std::set unique;
-for (std::vector::iterator li = result.begin();
- li != result.end(); ++li) {
-  cmSystemTools::ConvertToUnixSlashes(*li);
-  unique.insert(*li);
-}
-result.clear();
-result.insert(result.end(), unique.begin(), unique.end());
+std::for_each(result.begin()

[Cmake-commits] CMake branch, next, updated. v3.6.2-1877-g905f5f0

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  905f5f00754d5e3e632b829e4f4f2e4db6f64f52 (commit)
   via  befb6a645026bd7f64b6dc1dc1d370114f501375 (commit)
   via  3dde29bc72ad3b3f4cba6fc300df077fd4dc2a5c (commit)
   via  5d3b5bef11bc29bb00a14103433fea81e4dcc340 (commit)
   via  ad42eb33b61ad262315bfa087dc7f4f0ddbca5fe (commit)
  from  d803aae6f865545c4cc0702a52f73871aaf1de0e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=905f5f00754d5e3e632b829e4f4f2e4db6f64f52
commit 905f5f00754d5e3e632b829e4f4f2e4db6f64f52
Merge: d803aae befb6a6
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 8 17:43:58 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Sep 8 17:43:58 2016 -0400

Merge topic 'clang-tidy' into next

befb6a64 cmDependsFortran: simplify boolean expression
3dde29bc cmSystemTools: simplify boolean expressions
5d3b5bef QCMakeCacheView: simplify boolean expression
ad42eb33 QCMakeCacheView: no else after return


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=befb6a645026bd7f64b6dc1dc1d370114f501375
commit befb6a645026bd7f64b6dc1dc1d370114f501375
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 8 23:43:06 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Sep 8 23:43:06 2016 +0200

cmDependsFortran: simplify boolean expression

diff --git a/Source/cmDependsFortran.cxx b/Source/cmDependsFortran.cxx
index b7e006d..eb4c1ec 100644
--- a/Source/cmDependsFortran.cxx
+++ b/Source/cmDependsFortran.cxx
@@ -712,10 +712,5 @@ bool cmDependsFortran::ModulesDiffer(const char* modFile,
   // Compare the remaining content.  If no compiler id matched above,
   // including the case none was given, this will compare the whole
   // content.
-  if (!cmFortranStreamsDiffer(finModFile, finStampFile)) {
-return false;
-  }
-
-  // The modules are different.
-  return true;
+  return cmFortranStreamsDiffer(finModFile, finStampFile);
 }

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3dde29bc72ad3b3f4cba6fc300df077fd4dc2a5c
commit 3dde29bc72ad3b3f4cba6fc300df077fd4dc2a5c
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 8 23:41:31 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Sep 8 23:41:31 2016 +0200

cmSystemTools: simplify boolean expressions

diff --git a/Source/cmSystemTools.cxx b/Source/cmSystemTools.cxx
index 7da9975..ae0323b 100644
--- a/Source/cmSystemTools.cxx
+++ b/Source/cmSystemTools.cxx
@@ -1766,9 +1766,7 @@ bool cmSystemTools::CopyFileTime(const char* fromFile, 
const char* toFile)
   if (!GetFileTime(hFrom, , , )) {
 return false;
   }
-  if (!SetFileTime(hTo, , , )) {
-return false;
-  }
+  return SetFileTime(hTo, , , );
 #else
   struct stat fromStat;
   if (stat(fromFile, ) < 0) {
@@ -1778,11 +1776,8 @@ bool cmSystemTools::CopyFileTime(const char* fromFile, 
const char* toFile)
   struct utimbuf buf;
   buf.actime = fromStat.st_atime;
   buf.modtime = fromStat.st_mtime;
-  if (utime(toFile, ) < 0) {
-return false;
-  }
+  return utime(toFile, ) >= 0;
 #endif
-  return true;
 }
 
 cmSystemToolsFileTime* cmSystemTools::FileTimeNew()
@@ -1828,16 +1823,11 @@ bool cmSystemTools::FileTimeSet(const char* fname, 
cmSystemToolsFileTime* t)
   if (!h) {
 return false;
   }
-  if (!SetFileTime(h, >timeCreation, >timeLastAccess,
-   >timeLastWrite)) {
-return false;
-  }
+  return SetFileTime(h, >timeCreation, >timeLastAccess,
+ >timeLastWrite);
 #else
-  if (utime(fname, >timeBuf) < 0) {
-return false;
-  }
+  return utime(fname, >timeBuf) >= 0;
 #endif
-  return true;
 }
 
 #ifdef _WIN32

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5d3b5bef11bc29bb00a14103433fea81e4dcc340
commit 5d3b5bef11bc29bb00a14103433fea81e4dcc340
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 8 23:35:59 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Sep 8 23:35:59 2016 +0200

QCMakeCacheView: simplify boolean expression

diff --git a/Source/QtDialog/QCMakeCacheView.cxx 
b/Source/QtDialog/QCMakeCacheView.cxx
index ec7918b..ed11f7b 100644
--- a/Source/QtDialog/QCMakeCacheView.cxx
+++ b/Source/QtDialog/QCMakeCacheView.cxx
@@ -95,10 +95,7 @@ protected:
 // if there are no children
 if (!m->hasChildren(idx)) {
   bool adv = m->data(idx, QCMakeCacheModel::AdvancedRole).toBool();
-  if (!adv |

Re: [cmake-developers] [CMake] Setup/tear down steps for CTest

[Daniel Pfeifer]

On Thu, Sep 8, 2016 at 5:52 PM, Brad King  wrote:
> On 09/08/2016 10:15 AM, Craig Scott wrote:
>> the current behaviour of DEPENDS. At the moment, if test B depends
>> on test A, test B still executes if test A fails.
>> It is unexpected because I'd initially have thought of DEPENDS as
>> meaning I can't run test B if test A fails, after all, B depends
>> on A which I'd interpret to mean if A fails, then something B requires
>> isn't working. Conversely, this is also useful because until now,
>> DEPENDS was the only way to get cleanup functionality to run after
>> other tests, and if those other tests fail, we still want the
>> cleanup to occur.
>
> At one time we only had serial testing so the order of tests was
> fully controllable and based on the order of addition.  There were
> never any conditions for whether a test would run based on results
> of other tests.  Then when parallel testing was added we need a
> way to restore *order* dependencies, so DEPENDS was added just
> for that.  Maybe a better name would have been RUN_AFTER.
>
>> adding a DEPENDS_ON_SUCCESS test property or something similar
>> which would implement the perhaps more intuitive behaviour of not
>> running dependent tests when a dependee fails. If that was done,
>> then implementing the "don't run fixture tests if any fixture
>> setup fails" logic would be trivial.
>
> The semantics of this will have to be carefully though out, in
> particular with respect to enabling test dependencies.  Right now
> ctest arguments like -E can exclude tests.  What if those are
> dependencies of included tests?
>
> I think if we introduce the notion of tests requiring other tests
> then a new model of test selection and enablement needs to be
> designed.  Some kind of test DAG could be defined with various
> roots and subgraphs being selectable an causing all reachable
> tests to be included.

This could be expanded even further. If "tests requiring other tests"
is generalized to "tests requiring X", wouldn't this allow incremental
testing?  Say you change one file in your project. You rebuild only
the parts of the project that are affected by this change. Then you
rerun only the tests that are affected by the change. This really has
to be carefully thought out.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Developer tasks - Refactoring

[Daniel Pfeifer]

On Wed, Feb 10, 2016 at 12:12 AM, Stephen Kelly  wrote:
> 3) Compute cmGeneratorTarget state non-lazily in its constructor.
> * Historically target state for generators was computed lazily because it
>   might need to be cleared and re-computed.  That is no-longer true.

SourceFilesMap is cleared in a call to AddSource. It is then
recomputed the next time GetSourceFiles is called.

> * For example, the LinkInformation is populated lazily in
>   cmGeneratorTarget::GetLinkInformation.
> * Instead the LinkInformation could be populated in the cmGeneratorTarget
>   constructor for all known configurations.  That is what generators will
>   request during generate-time anyway.
> * Doing this will make it possible to split a cmComputedTarget out of
>   cmGeneratorTarget.

I started splitting out a cmComputedTarget. It is initialized in its
constructor for one single configuration.
The entries of the ComputedTargets map are computed and recomputed
lazily because of the reason mentioned above.

Please review: https://github.com/purpleKarrot/CMake/commits/computed-target
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.6.1-1790-g8752d76

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  8752d765ae63edd5153a0547727989a4efe4d809 (commit)
   via  0039ffa2163665856be1e772146442f2c7418c6c (commit)
  from  425a1248b7c91f3bd1d2a4facbfca2b7889878a6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8752d765ae63edd5153a0547727989a4efe4d809
commit 8752d765ae63edd5153a0547727989a4efe4d809
Merge: 425a124 0039ffa
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 17:18:34 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Sep 5 17:18:34 2016 -0400

Merge topic 'cm_nullptr' into next

0039ffa2 use CM_NULLPTR


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0039ffa2163665856be1e772146442f2c7418c6c
commit 0039ffa2163665856be1e772146442f2c7418c6c
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 23:18:05 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Sep 5 23:18:05 2016 +0200

use CM_NULLPTR

diff --git a/Source/cmFilePathUuid.h b/Source/cmFilePathUuid.h
index 87cfcf8..b54dc47 100644
--- a/Source/cmFilePathUuid.h
+++ b/Source/cmFilePathUuid.h
@@ -52,8 +52,9 @@ public:
* @arg outputPrefix optional string to prepend to the result
* @arg outputSuffix optional string to append to the result
*/
-  std::string get(const std::string& filePath, const char* outputPrefix = NULL,
-  const char* outputSuffix = NULL);
+  std::string get(const std::string& filePath,
+  const char* outputPrefix = CM_NULLPTR,
+  const char* outputSuffix = CM_NULLPTR);
 
 private:
   void initParentDirs(const std::string& currentSrcDir,
diff --git a/Source/cmXMLParser.cxx b/Source/cmXMLParser.cxx
index 7c53a3d..9878912 100644
--- a/Source/cmXMLParser.cxx
+++ b/Source/cmXMLParser.cxx
@@ -20,10 +20,10 @@
 
 cmXMLParser::cmXMLParser()
 {
-  this->Parser = 0;
+  this->Parser = CM_NULLPTR;
   this->ParseError = 0;
-  this->ReportCallback = 0;
-  this->ReportCallbackData = 0;
+  this->ReportCallback = CM_NULLPTR;
+  this->ReportCallbackData = CM_NULLPTR;
 }
 
 cmXMLParser::~cmXMLParser()
@@ -64,7 +64,7 @@ int cmXMLParser::InitializeParser()
   }
 
   // Create the expat XML parser.
-  this->Parser = XML_ParserCreate(0);
+  this->Parser = XML_ParserCreate(CM_NULLPTR);
   XML_SetElementHandler(static_cast(this->Parser),
 , );
   XML_SetCharacterDataHandler(static_cast(this->Parser),
@@ -108,7 +108,7 @@ int cmXMLParser::CleanupParser()
 
   // Clean up the parser.
   XML_ParserFree(static_cast(this->Parser));
-  this->Parser = 0;
+  this->Parser = CM_NULLPTR;
 
   return result;
 }
@@ -165,7 +165,7 @@ const char* cmXMLParser::FindAttribute(const char** atts,
   }
 }
   }
-  return 0;
+  return CM_NULLPTR;
 }
 
 void cmXMLParserStartElement(void* parser, const char* name, const char** atts)
diff --git a/Tests/CMakeLib/run_compile_commands.cxx 
b/Tests/CMakeLib/run_compile_commands.cxx
index 529c830..0bf0a7c 100644
--- a/Tests/CMakeLib/run_compile_commands.cxx
+++ b/Tests/CMakeLib/run_compile_commands.cxx
@@ -148,7 +148,8 @@ int main()
it != end; ++it) {
 std::vector command;
 cmSystemTools::ParseUnixCommandLine(it->at("command").c_str(), command);
-if (!cmSystemTools::RunSingleCommand(command, 0, 0, 0,
+if (!cmSystemTools::RunSingleCommand(command, CM_NULLPTR, CM_NULLPTR,
+ CM_NULLPTR,
  it->at("directory").c_str())) {
   std::cout << "ERROR: Failed to run command \"" << command[0] << "\""
 << std::endl;
diff --git a/Tests/CMakeLib/testXMLSafe.cxx b/Tests/CMakeLib/testXMLSafe.cxx
index 356880c..c4aaf17 100644
--- a/Tests/CMakeLib/testXMLSafe.cxx
+++ b/Tests/CMakeLib/testXMLSafe.cxx
@@ -27,7 +27,7 @@ static test_pair const pairs[] = {
   { "angles <>", "angles " },
   { "ampersand &", "ampersand " },
   { "bad-byte \x80", "bad-byte [NON-UTF-8-BYTE-0x80]" },
-  { 0, 0 }
+  { CM_NULLPTR, CM_NULLPTR }
 };
 
 int testXMLSafe(int /*unused*/, char* /*unused*/ [])

---

Summary of changes:
 Source/cmFilePathUuid.h |5 +++--
 Source/cmXMLParser.cxx  |   12 ++--
 Tests/CMakeLib/run_compile_commands.cxx |3 ++-

[Cmake-commits] CMake branch, next, updated. v3.6.1-1788-g425a124

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  425a1248b7c91f3bd1d2a4facbfca2b7889878a6 (commit)
   via  8d52b94262c0201b37aab554d306a037a48e0ca3 (commit)
  from  cb33be0a1655e5b9bd8abd609ac3c463182ac586 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=425a1248b7c91f3bd1d2a4facbfca2b7889878a6
commit 425a1248b7c91f3bd1d2a4facbfca2b7889878a6
Merge: cb33be0 8d52b94
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 16:35:49 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Sep 5 16:35:49 2016 -0400

Merge topic 'qtdialog-tidy' into next

8d52b942 fixup! QtDialog: fix clang-tidy warnings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8d52b94262c0201b37aab554d306a037a48e0ca3
commit 8d52b94262c0201b37aab554d306a037a48e0ca3
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 22:35:31 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Sep 5 22:35:31 2016 +0200

fixup! QtDialog: fix clang-tidy warnings

diff --git a/Source/QtDialog/Compilers.h b/Source/QtDialog/Compilers.h
index bdb1962..276e2a5 100644
--- a/Source/QtDialog/Compilers.h
+++ b/Source/QtDialog/Compilers.h
@@ -3,6 +3,8 @@
 #ifndef COMPILERS_HPP
 #define COMPILERS_HPP
 
+#include 
+
 #include 
 
 #include 
@@ -11,7 +13,7 @@ class Compilers : public QWidget, public Ui::Compilers
 {
   Q_OBJECT
 public:
-  Compilers(QWidget* p = NULL)
+  Compilers(QWidget* p = CM_NULLPTR)
 : QWidget(p)
   {
 this->setupUi(this);
diff --git a/Source/QtDialog/QCMake.h b/Source/QtDialog/QCMake.h
index a818c6b..7eadb09 100644
--- a/Source/QtDialog/QCMake.h
+++ b/Source/QtDialog/QCMake.h
@@ -13,6 +13,8 @@
 #ifndef QCMake_h
 #define QCMake_h
 
+#include 
+
 #include "cmake.h"
 
 #ifdef _MSC_VER
@@ -71,7 +73,7 @@ class QCMake : public QObject
 {
   Q_OBJECT
 public:
-  QCMake(QObject* p = 0);
+  QCMake(QObject* p = CM_NULLPTR);
   ~QCMake();
 public slots:
   /// load the cache file in a directory
diff --git a/Source/QtDialog/QCMakeWidgets.h b/Source/QtDialog/QCMakeWidgets.h
index f1e87ce..0d95e63 100644
--- a/Source/QtDialog/QCMakeWidgets.h
+++ b/Source/QtDialog/QCMakeWidgets.h
@@ -13,6 +13,8 @@
 #ifndef QCMakeWidgets_h
 #define QCMakeWidgets_h
 
+#include 
+
 #include 
 #include 
 #include 
@@ -43,7 +45,7 @@ class QCMakePathEditor : public QCMakeFileEditor
 {
   Q_OBJECT
 public:
-  QCMakePathEditor(QWidget* p = NULL, const QString& var = QString());
+  QCMakePathEditor(QWidget* p = CM_NULLPTR, const QString& var = QString());
   void chooseFile();
 };
 
@@ -52,7 +54,8 @@ class QCMakeFilePathEditor : public QCMakeFileEditor
 {
   Q_OBJECT
 public:
-  QCMakeFilePathEditor(QWidget* p = NULL, const QString& var = QString());
+  QCMakeFilePathEditor(QWidget* p = CM_NULLPTR,
+   const QString& var = QString());
   void chooseFile();
 };
 

---

Summary of changes:
 Source/QtDialog/Compilers.h |4 +++-
 Source/QtDialog/QCMake.h|4 +++-
 Source/QtDialog/QCMakeWidgets.h |7 +--
 3 files changed, 11 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1786-gcb33be0

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  cb33be0a1655e5b9bd8abd609ac3c463182ac586 (commit)
   via  00b16a866aa3994263d7536a862225150c8dce1e (commit)
  from  83d0c9351f516f3793551e8b6ef8fcea054dc9f5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cb33be0a1655e5b9bd8abd609ac3c463182ac586
commit cb33be0a1655e5b9bd8abd609ac3c463182ac586
Merge: 83d0c93 00b16a8
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 16:12:57 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Sep 5 16:12:57 2016 -0400

Merge topic 'qtdialog-tidy' into next

00b16a86 QtDialog: fix clang-tidy warnings


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=00b16a866aa3994263d7536a862225150c8dce1e
commit 00b16a866aa3994263d7536a862225150c8dce1e
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 22:12:36 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Sep 5 22:12:36 2016 +0200

QtDialog: fix clang-tidy warnings

diff --git a/Source/QtDialog/AddCacheEntry.cxx 
b/Source/QtDialog/AddCacheEntry.cxx
index dc7a4b0..a94c54b 100644
--- a/Source/QtDialog/AddCacheEntry.cxx
+++ b/Source/QtDialog/AddCacheEntry.cxx
@@ -64,7 +64,8 @@ QVariant AddCacheEntry::value() const
   QWidget* w = this->StackedWidget->currentWidget();
   if (qobject_cast<QLineEdit*>(w)) {
 return static_cast<QLineEdit*>(w)->text();
-  } else if (qobject_cast<QCheckBox*>(w)) {
+  }
+  if (qobject_cast<QCheckBox*>(w)) {
 return static_cast<QCheckBox*>(w)->isChecked();
   }
   return QVariant();
diff --git a/Source/QtDialog/CMakeSetup.cxx b/Source/QtDialog/CMakeSetup.cxx
index 5a8a5be..4de4bef 100644
--- a/Source/QtDialog/CMakeSetup.cxx
+++ b/Source/QtDialog/CMakeSetup.cxx
@@ -29,18 +29,19 @@
 
 #include "cmSystemTools.h" // IWYU pragma: keep
 
-static const char* cmDocumentationName[][2] = { { 0,
+static const char* cmDocumentationName[][2] = { { CM_NULLPTR,
   "  cmake-gui - CMake GUI." },
-{ 0, 0 } };
+{ CM_NULLPTR, CM_NULLPTR } };
 
 static const char* cmDocumentationUsage[][2] = {
-  { 0, "  cmake-gui [options]\n"
-   "  cmake-gui [options] \n"
-   "  cmake-gui [options] " },
-  { 0, 0 }
+  { CM_NULLPTR, "  cmake-gui [options]\n"
+"  cmake-gui [options] \n"
+"  cmake-gui [options] " },
+  { CM_NULLPTR, CM_NULLPTR }
 };
 
-static const char* cmDocumentationOptions[][2] = { { 0, 0 } };
+static const char* cmDocumentationOptions[]
+ [2] = { { CM_NULLPTR, CM_NULLPTR } };
 
 #if defined(Q_OS_MAC)
 static int cmOSXInstall(std::string dir);
diff --git a/Source/QtDialog/CMakeSetupDialog.cxx 
b/Source/QtDialog/CMakeSetupDialog.cxx
index fda3e58..5b84597 100644
--- a/Source/QtDialog/CMakeSetupDialog.cxx
+++ b/Source/QtDialog/CMakeSetupDialog.cxx
@@ -41,7 +41,7 @@
 
 QCMakeThread::QCMakeThread(QObject* p)
   : QThread(p)
-  , CMakeInstance(NULL)
+  , CMakeInstance(CM_NULLPTR)
 {
 }
 
@@ -57,7 +57,7 @@ void QCMakeThread::run()
   emit this->cmakeInitialized();
   this->exec();
   delete this->CMakeInstance;
-  this->CMakeInstance = NULL;
+  this->CMakeInstance = CM_NULLPTR;
 }
 
 CMakeSetupDialog::CMakeSetupDialog()
diff --git a/Source/QtDialog/FirstConfigure.cxx 
b/Source/QtDialog/FirstConfigure.cxx
index ca5e3b5..c34751a 100644
--- a/Source/QtDialog/FirstConfigure.cxx
+++ b/Source/QtDialog/FirstConfigure.cxx
@@ -129,8 +129,9 @@ bool StartCompilerSetup::crossCompilerSetup() const
 
 void StartCompilerSetup::onSelectionChanged(bool on)
 {
-  if (on)
+  if (on) {
 selectionChanged();
+  }
 }
 
 void StartCompilerSetup::onGeneratorChanged(QString const& name)
@@ -144,12 +145,15 @@ void StartCompilerSetup::onGeneratorChanged(QString 
const& name)
 
 int StartCompilerSetup::nextId() const
 {
-  if (compilerSetup())
+  if (compilerSetup()) {
 return NativeSetup;
-  if (crossCompilerSetup())
+  }
+  if (crossCompilerSetup()) {
 return CrossSetup;
-  if (crossCompilerToolChainFile())
+  }
+  if (crossCompilerToolChainFile()) {
 return ToolchainSetup;
+  }
   return -1;
 }
 
@@ -515,7 +519,8 @@ QString FirstConfigure::getCCompiler() const
 {
   if (this->compilerSetup()) {
 return this->mNativeCompilerSetupPage->getCCompiler();

[Cmake-commits] CMake branch, next, updated. v3.6.1-1784-g83d0c93

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  83d0c9351f516f3793551e8b6ef8fcea054dc9f5 (commit)
   via  1a9de8035c35cdb3e0501ce2cf2f816e4220bea0 (commit)
  from  9e42dba027b1e2860a21dcf3617f13c8adac7204 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=83d0c9351f516f3793551e8b6ef8fcea054dc9f5
commit 83d0c9351f516f3793551e8b6ef8fcea054dc9f5
Merge: 9e42dba 1a9de80
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 16:10:29 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Sep 5 16:10:29 2016 -0400

Merge topic 'macro-parenthesis' into next

1a9de803 surround macro arguments with parentheses


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1a9de8035c35cdb3e0501ce2cf2f816e4220bea0
commit 1a9de8035c35cdb3e0501ce2cf2f816e4220bea0
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Sep 5 22:09:49 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Sep 5 22:09:49 2016 +0200

surround macro arguments with parentheses

diff --git a/Source/CPack/cmCPackArchiveGenerator.cxx 
b/Source/CPack/cmCPackArchiveGenerator.cxx
index 0d3725d..377fee1 100644
--- a/Source/CPack/cmCPackArchiveGenerator.cxx
+++ b/Source/CPack/cmCPackArchiveGenerator.cxx
@@ -87,17 +87,17 @@ int cmCPackArchiveGenerator::addOneComponentToArchive(
  */
 #define DECLARE_AND_OPEN_ARCHIVE(filename, archive)   \
   cmGeneratedFileStream gf;   \
-  gf.Open(filename.c_str(), false, true); \
+  gf.Open((filename).c_str(), false, true);   \
   if (!GenerateHeader()) { \
 cmCPackLogger(cmCPackLog::LOG_ERROR,  \
   "Problem to generate Header for archive < " \
-<< filename << ">." << std::endl);\
+<< (filename) << ">." << std::endl);  \
 return 0; \
   }   \
   cmArchiveWrite archive(gf, this->Compress, this->ArchiveFormat);\
-  if (!archive) { \
+  if (!(archive)) {   \
 cmCPackLogger(cmCPackLog::LOG_ERROR, "Problem to create archive < "   \
-<< filename << ">. ERROR =" << archive.GetError() \
+<< (filename) << ">. ERROR =" << (archive).GetError() \
 << std::endl);\
 return 0; \
   }
diff --git a/Source/CTest/cmCTestBuildHandler.cxx 
b/Source/CTest/cmCTestBuildHandler.cxx
index cdf292c..754bb5f 100644
--- a/Source/CTest/cmCTestBuildHandler.cxx
+++ b/Source/CTest/cmCTestBuildHandler.cxx
@@ -366,11 +366,11 @@ int cmCTestBuildHandler::ProcessHandler()
   regexes.clear();\
   cmCTestOptionalLog(this->CTest, DEBUG,  \
  this << "Add " #regexes << std::endl, this->Quiet);  \
-  for (it = strings.begin(); it != strings.end(); ++it) { \
+  for (it = (strings).begin(); it != (strings).end(); ++it) { \
 cmCTestOptionalLog(this->CTest, DEBUG,\
"Add " #strings ": " << *it << std::endl,  \
this->Quiet);  \
-regexes.push_back(it->c_str());   \
+(regexes).push_back(it->c_str()); \
   }
   cmCTestBuildHandlerPopulateRegexVector(this->CustomErrorMatches,
  this->ErrorMatchRegex);
diff --git a/Source/cmCurl.cxx b/Source/cmCurl.cxx
index eec773f..91da239 100644
--- a/Source/cmCurl.cxx
+++ b/Source/cmCurl.cxx
@@ -25,9 +25,9 @@
 #endif
 

[Cmake-commits] CMake branch, next, updated. v3.6.1-1757-gdfa796f

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  dfa796fc2815c89ed7a1fcc119b12bcf6afc8294 (commit)
   via  32f756c8226e2026d51307c4722aa6b98939c9e6 (commit)
  from  5871837d2774cf2f6bf50d284fb705c6210640b2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=dfa796fc2815c89ed7a1fcc119b12bcf6afc8294
commit dfa796fc2815c89ed7a1fcc119b12bcf6afc8294
Merge: 5871837 32f756c
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Sat Sep 3 18:23:11 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Sat Sep 3 18:23:11 2016 -0400

Merge topic 'include-what-you-use' into next

32f756c8 CursesDialog: include what you use


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=32f756c8226e2026d51307c4722aa6b98939c9e6
commit 32f756c8226e2026d51307c4722aa6b98939c9e6
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 1 21:55:09 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Sat Sep 3 23:37:09 2016 +0200

CursesDialog: include what you use

diff --git a/Source/CursesDialog/ccmake.cxx b/Source/CursesDialog/ccmake.cxx
index 80bb55d..2e062bc 100644
--- a/Source/CursesDialog/ccmake.cxx
+++ b/Source/CursesDialog/ccmake.cxx
@@ -9,19 +9,22 @@
   implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
   See the License for more information.
 */
-#include "cmCursesStandardIncludes.h"
-
-#include "../cmDocumentation.h"
-#include "../cmSystemTools.h"
-#include "../cmake.h"
-
-#include 
-#include 
+#include 
 
+#include "cmCursesForm.h"
 #include "cmCursesMainForm.h"
-#include 
+#include "cmCursesStandardIncludes.h"
+#include "cmDocumentation.h"
+#include "cmDocumentationEntry.h"
+#include "cmSystemTools.h"
+#include "cmake.h"
 
-#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 static const char* cmDocumentationName[][2] = {
   { CM_NULLPTR, "  ccmake - Curses Interface for CMake." },
diff --git a/Source/CursesDialog/cmCursesBoolWidget.cxx 
b/Source/CursesDialog/cmCursesBoolWidget.cxx
index 99f7dcc..de95bae 100644
--- a/Source/CursesDialog/cmCursesBoolWidget.cxx
+++ b/Source/CursesDialog/cmCursesBoolWidget.cxx
@@ -11,7 +11,10 @@
 */
 #include "cmCursesBoolWidget.h"
 
-#include "cmCursesMainForm.h"
+#include "cmCursesWidget.h"
+#include "cmState.h"
+
+#include 
 
 cmCursesBoolWidget::cmCursesBoolWidget(int width, int height, int left,
int top)
diff --git a/Source/CursesDialog/cmCursesBoolWidget.h 
b/Source/CursesDialog/cmCursesBoolWidget.h
index d2899ee..b9f1b16 100644
--- a/Source/CursesDialog/cmCursesBoolWidget.h
+++ b/Source/CursesDialog/cmCursesBoolWidget.h
@@ -12,6 +12,9 @@
 #ifndef cmCursesBoolWidget_h
 #define cmCursesBoolWidget_h
 
+#include 
+
+#include "cmCursesStandardIncludes.h"
 #include "cmCursesWidget.h"
 
 class cmCursesMainForm;
diff --git a/Source/CursesDialog/cmCursesCacheEntryComposite.cxx 
b/Source/CursesDialog/cmCursesCacheEntryComposite.cxx
index 462cb6e..d115c77 100644
--- a/Source/CursesDialog/cmCursesCacheEntryComposite.cxx
+++ b/Source/CursesDialog/cmCursesCacheEntryComposite.cxx
@@ -11,18 +11,20 @@
 */
 #include "cmCursesCacheEntryComposite.h"
 
-#include "../cmState.h"
-#include "../cmSystemTools.h"
-#include "../cmake.h"
 #include "cmCursesBoolWidget.h"
-#include "cmCursesDummyWidget.h"
 #include "cmCursesFilePathWidget.h"
 #include "cmCursesLabelWidget.h"
 #include "cmCursesOptionsWidget.h"
 #include "cmCursesPathWidget.h"
 #include "cmCursesStringWidget.h"
+#include "cmCursesWidget.h"
+#include "cmState.h"
+#include "cmSystemTools.h"
+#include "cmake.h"
 
 #include 
+#include 
+#include 
 
 cmCursesCacheEntryComposite::cmCursesCacheEntryComposite(
   const std::string& key, int labelwidth, int entrywidth)
diff --git a/Source/CursesDialog/cmCursesCacheEntryComposite.h 
b/Source/CursesDialog/cmCursesCacheEntryComposite.h
index c9c8238..c717e1a 100644
--- a/Source/CursesDialog/cmCursesCacheEntryComposite.h
+++ b/Source/CursesDialog/cmC

[Cmake-commits] CMake branch, next, updated. v3.6.1-1708-g5ae80fe

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  5ae80febe60a0f15532ec439a742f30b5101f552 (commit)
   via  b61a64b3018b4be126f459348773f58d21f72a23 (commit)
  from  dea9826731fa7bc9c9b9cf58f64c9de2a64a22b3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5ae80febe60a0f15532ec439a742f30b5101f552
commit 5ae80febe60a0f15532ec439a742f30b5101f552
Merge: dea9826 b61a64b
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 2 01:21:51 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Fri Sep 2 01:21:51 2016 -0400

Merge topic 'include-what-you-use' into next

b61a64b3 fixup! fix a load of include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b61a64b3018b4be126f459348773f58d21f72a23
commit b61a64b3018b4be126f459348773f58d21f72a23
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 2 07:21:29 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 2 07:21:29 2016 +0200

fixup! fix a load of include-what-you-use violations

diff --git a/Source/cmELF.cxx b/Source/cmELF.cxx
index a43e6c1..6fff984 100644
--- a/Source/cmELF.cxx
+++ b/Source/cmELF.cxx
@@ -17,7 +17,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 
diff --git a/Source/cmFilePathUuid.cxx b/Source/cmFilePathUuid.cxx
index 6202d6d..b2def51 100644
--- a/Source/cmFilePathUuid.cxx
+++ b/Source/cmFilePathUuid.cxx
@@ -17,7 +17,6 @@
 #include "cmMakefile.h"
 #include "cmSystemTools.h"
 
-#include 
 #include 
 
 cmFilePathUuid::cmFilePathUuid(cmMakefile* makefile)

---

Summary of changes:
 Source/cmELF.cxx  |1 -
 Source/cmFilePathUuid.cxx |1 -
 2 files changed, 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1704-gbaaf490

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  baaf49013308cac99f67e6430a0553213c31b922 (commit)
   via  4aec72dd1907952bb874e0e7485a7b89a1ff6426 (commit)
  from  68be8cd53896acb0652261fef080155dc1a5248c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=baaf49013308cac99f67e6430a0553213c31b922
commit baaf49013308cac99f67e6430a0553213c31b922
Merge: 68be8cd 4aec72d
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Sep 1 18:17:47 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Sep 1 18:17:47 2016 -0400

Merge topic 'include-what-you-use' into next

4aec72dd fixup! fix a load of include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4aec72dd1907952bb874e0e7485a7b89a1ff6426
commit 4aec72dd1907952bb874e0e7485a7b89a1ff6426
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Fri Sep 2 00:16:58 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Fri Sep 2 00:16:58 2016 +0200

fixup! fix a load of include-what-you-use violations

diff --git a/Source/cmcmd.cxx b/Source/cmcmd.cxx
index 277901d..c2e1d53 100644
--- a/Source/cmcmd.cxx
+++ b/Source/cmcmd.cxx
@@ -45,7 +45,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 void CMakeCommandUsage(const char* program)

---

Summary of changes:
 Source/cmcmd.cxx |1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1419-g9619967

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  96199676e0d3a8d14480b781b5e0534b2d342006 (commit)
   via  f1e447467da748ba794f001c72cb0df5aea175d7 (commit)
  from  d64488359696c8ad9519daff699ac9f1d93b2b4f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=96199676e0d3a8d14480b781b5e0534b2d342006
commit 96199676e0d3a8d14480b781b5e0534b2d342006
Merge: d644883 f1e4474
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 24 16:25:11 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Aug 24 16:25:11 2016 -0400

Merge topic 'include-what-you-use' into next

f1e44746 fixup! CTest: fix include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=f1e447467da748ba794f001c72cb0df5aea175d7
commit f1e447467da748ba794f001c72cb0df5aea175d7
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 24 22:24:57 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Aug 24 22:24:57 2016 +0200

fixup! CTest: fix include-what-you-use violations

diff --git a/Source/CTest/cmCTestSubmitHandler.cxx 
b/Source/CTest/cmCTestSubmitHandler.cxx
index 7c42fd0..67f7c89 100644
--- a/Source/CTest/cmCTestSubmitHandler.cxx
+++ b/Source/CTest/cmCTestSubmitHandler.cxx
@@ -29,6 +29,12 @@
 #include 
 #include 
 
+#if defined(CTEST_USE_XMLRPC)
+#include "cmVersion.h"
+#include 
+#include 
+#endif
+
 #define SUBMIT_TIMEOUT_IN_SECONDS_DEFAULT 120
 
 typedef std::vector cmCTestSubmitHandlerVectorOfChar;

---

Summary of changes:
 Source/CTest/cmCTestSubmitHandler.cxx |6 ++
 1 file changed, 6 insertions(+)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1415-ga035078

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  a03507820e8b11bc65bd678433c173b92b3549f6 (commit)
   via  182a9161f714d4f122cc4c2d31abc0d795f2f9e4 (commit)
  from  0ad6db5d64d0a4554c57603f3e5be4c4d9ce2f7e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a03507820e8b11bc65bd678433c173b92b3549f6
commit a03507820e8b11bc65bd678433c173b92b3549f6
Merge: 0ad6db5 182a916
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 24 16:02:45 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Aug 24 16:02:45 2016 -0400

Merge topic 'include-what-you-use' into next

182a9161 CTest: fix include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=182a9161f714d4f122cc4c2d31abc0d795f2f9e4
commit 182a9161f714d4f122cc4c2d31abc0d795f2f9e4
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 24 22:01:40 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Aug 24 22:02:22 2016 +0200

CTest: fix include-what-you-use violations

diff --git a/Source/CTest/cmCTestBZR.cxx b/Source/CTest/cmCTestBZR.cxx
index 7baf7a3..413cada 100644
--- a/Source/CTest/cmCTestBZR.cxx
+++ b/Source/CTest/cmCTestBZR.cxx
@@ -12,12 +12,18 @@
 #include "cmCTestBZR.h"
 
 #include "cmCTest.h"
+#include "cmCTestVC.h"
+#include "cmProcessTools.h"
 #include "cmSystemTools.h"
 #include "cmXMLParser.h"
 
-#include 
-
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 extern "C" int cmBZRXMLParserUnknownEncodingHandler(void* /*unused*/,
 const XML_Char* name,
diff --git a/Source/CTest/cmCTestBZR.h b/Source/CTest/cmCTestBZR.h
index 0f05d38..e2ee8b7 100644
--- a/Source/CTest/cmCTestBZR.h
+++ b/Source/CTest/cmCTestBZR.h
@@ -12,8 +12,15 @@
 #ifndef cmCTestBZR_h
 #define cmCTestBZR_h
 
+#include 
+
 #include "cmCTestGlobalVC.h"
 
+#include 
+#include 
+
+class cmCTest;
+
 /** \class cmCTestBZR
  * \brief Interaction with bzr command-line tool
  *
@@ -41,13 +48,14 @@ private:
 
   // Parsing helper classes.
   class InfoParser;
-  class RevnoParser;
   class LogParser;
-  class UpdateParser;
+  class RevnoParser;
   class StatusParser;
+  class UpdateParser;
+
   friend class InfoParser;
-  friend class RevnoParser;
   friend class LogParser;
+  friend class RevnoParser;
   friend class UpdateParser;
   friend class StatusParser;
 };
diff --git a/Source/CTest/cmCTestBatchTestHandler.cxx 
b/Source/CTest/cmCTestBatchTestHandler.cxx
index 70f84cb..bf4ead4 100644
--- a/Source/CTest/cmCTestBatchTestHandler.cxx
+++ b/Source/CTest/cmCTestBatchTestHandler.cxx
@@ -13,10 +13,14 @@
 #include "cmCTestBatchTestHandler.h"
 
 #include "cmCTest.h"
+#include "cmCTestMultiProcessHandler.h"
+#include "cmCTestTestHandler.h"
 #include "cmProcess.h"
-#include "cmStandardIncludes.h"
 #include "cmSystemTools.h"
-#include 
+
+#include 
+#include 
+#include 
 
 cmCTestBatchTestHandler::~cmCTestBatchTestHandler()
 {
diff --git a/Source/CTest/cmCTestBatchTestHandler.h 
b/Source/CTest/cmCTestBatchTestHandler.h
index 17cc234..da10824 100644
--- a/Source/CTest/cmCTestBatchTestHandler.h
+++ b/Source/CTest/cmCTestBatchTestHandler.h
@@ -13,12 +13,11 @@
 #ifndef cmCTestBatchTestHandler_h
 #define cmCTestBatchTestHandler_h
 
-#include 
+#include 
 
 #include 
-#include 
-#include 
 #include 
+#include 
 
 /** \class cmCTestBatchTestHandler
  * \brief run parallel ctest
diff --git a/Source/CTest/cmCTestBuildAndTestHandler.cxx 
b/Source/CTest/cmCTestBuildAndTestHandler.cxx
index 9dab98a..9da2848 100644
--- a/Source/CTest/cmCTestBuildAndTestHandler.cxx
+++ b/Source/CTest/cmCTestBuildAndTestHandler.cxx
@@ -17,7 +17,9 @@
 #include "cmGlobalGenerator.h"
 #include "cmSystemTools.h"
 #include "cmake.h"
+
 #include 
+#include 
 
 cmCTestBuildAndTestHandler::cmCTestBuildAndTestHandler()
 {
diff --git a/Source/CTest/cmCTestBuildAndTestHandler.h 
b/Source/CTest/cmCTestBuildAndTestHandler.h
index 2aa90a4..f917fb0 100644
--- a/Source/CTest/cmCTestBuildAndTestHandler.h
+++ b/Source/CTest/cmCTestBuildAndTestHandler.h
@@ -13,8 +13,15 @@
 #ifndef cmCTestBuildAndTestHandler_h
 #define cmCTestBuildAndTestHandler_h
 
+#include 
+
 #include "cmCTestGenericHandler.h"
-#include "cmListFileCache.h"
+#include "cmTypeMacro.h"
+
+#include 
+#include 
+#include 
+#include 
 
 class

[Cmake-commits] CMake branch, next, updated. v3.6.1-1376-g43edf72

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  43edf727670912226bfbb7d9b4579e28013b42be (commit)
   via  5cbb54880742c23658991edec91a514f3582ed2b (commit)
  from  91e3176521915a83fa1bbe3efbd03042a906bcc2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=43edf727670912226bfbb7d9b4579e28013b42be
commit 43edf727670912226bfbb7d9b4579e28013b42be
Merge: 91e3176 5cbb548
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Aug 23 18:29:58 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Aug 23 18:29:58 2016 -0400

Merge topic 'include-what-you-use' into next

5cbb5488 fix a batch of include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5cbb54880742c23658991edec91a514f3582ed2b
commit 5cbb54880742c23658991edec91a514f3582ed2b
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 24 00:29:15 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Aug 24 00:29:15 2016 +0200

fix a batch of include-what-you-use violations

diff --git a/Source/CTest/cmCTestCVS.h b/Source/CTest/cmCTestCVS.h
index 4d5e6a9..67d162d 100644
--- a/Source/CTest/cmCTestCVS.h
+++ b/Source/CTest/cmCTestCVS.h
@@ -14,6 +14,9 @@
 
 #include "cmCTestVC.h"
 
+#include 
+#include 
+
 /** \class cmCTestCVS
  * \brief Interaction with cvs command-line tool
  *
diff --git a/Source/CTest/cmCTestGlobalVC.h b/Source/CTest/cmCTestGlobalVC.h
index 7ea3440..d42d2f2 100644
--- a/Source/CTest/cmCTestGlobalVC.h
+++ b/Source/CTest/cmCTestGlobalVC.h
@@ -15,6 +15,8 @@
 #include "cmCTestVC.h"
 
 #include 
+#include 
+#include 
 
 /** \class cmCTestGlobalVC
  * \brief Base class for handling globally-versioned trees
diff --git a/Source/cmBreakCommand.cxx b/Source/cmBreakCommand.cxx
index fd57705..b33494e 100644
--- a/Source/cmBreakCommand.cxx
+++ b/Source/cmBreakCommand.cxx
@@ -11,6 +11,8 @@
 */
 #include "cmBreakCommand.h"
 
+#include "cmExecutionStatus.h"
+
 // cmBreakCommand
 bool cmBreakCommand::InitialPass(std::vector const& args,
  cmExecutionStatus& status)
diff --git a/Source/cmMakefile.cxx b/Source/cmMakefile.cxx
index 28a3ab5..b9d71ec 100644
--- a/Source/cmMakefile.cxx
+++ b/Source/cmMakefile.cxx
@@ -11,38 +11,44 @@
 */
 #include "cmMakefile.h"
 
+#include "cmAlgorithms.h"
 #include "cmCommand.h"
 #include "cmCommandArgumentParserHelper.h"
-#include "cmCommands.h"
+#include "cmCustomCommand.h"
+#include "cmCustomCommandLines.h"
+#include "cmExecutionStatus.h"
+#include "cmExpandedCommandArgument.h"
+#include "cmFileLockPool.h"
 #include "cmFunctionBlocker.h"
 #include "cmGeneratorExpression.h"
 #include "cmGeneratorExpressionEvaluationFile.h"
 #include "cmGlobalGenerator.h"
+#include "cmInstallGenerator.h"
 #include "cmListFileCache.h"
-#include "cmOutputConverter.h"
 #include "cmSourceFile.h"
 #include "cmSourceFileLocation.h"
 #include "cmState.h"
 #include "cmSystemTools.h"
 #include "cmTest.h"
+#include "cmTestGenerator.h"
 #include "cmVersion.h"
+#include "cmake.h"
+
 #ifdef CMAKE_BUILD_WITH_CMAKE
 #include "cmVariableWatch.h"
 #endif
-#include "cmAlgorithms.h"
-#include "cmInstallGenerator.h"
-#include "cmTestGenerator.h"
-#include "cmake.h"
-#include  // required for atoi
 
 #include 
 #include 
 #include 
-#include 
 
+#include 
 #include 
-#include  // for isspace
-#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 // default is not to be building executables
 cmMakefile::cmMakefile(cmGlobalGenerator* globalGenerator,
diff --git a/Source/cmMakefile.h b/Source/cmMakefile.h
index d07b4e1..d082964 100644
--- a/Source/cmMakefile.h
+++ b/Source/cmMakefile.h
@@ -12,16 +12,15 @@
 #ifndef cmMakefile_h
 #define cmMakefile_h
 
-#include "cmStandardIncludes.h"
+#include 
 
 #include "cmAlgorithms.h"
-#include "cmExecutionStatus.h"
-#include "cmExpandedCommandArgument.h"
 #include "cmListFileCache.h"
 #include "cmNewLineStyle.h"
+#include "cmPolicies.h"
 #incl

Re: [cmake-developers] Security in CMake

[Daniel Pfeifer]

Hi Egor,

On Sat, Aug 20, 2016 at 1:48 PM, Egor Pugin  wrote:
> Hi,
>
> I'm working on a package manager based on cmake.

Please rethink that approach. Your package manager should support
CMake. It should not be based on it. Your design will be safer and
more flexible.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.6.1-1310-gcdf7e58

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  cdf7e5800504307b820f742fc3944391d6e37292 (commit)
   via  7b6349da4dc968691f1a374211fcc153c8b4f1c6 (commit)
   via  50ad1e0a144ae1f2267a4966789e5a16372f458e (commit)
   via  7f97a6c94b59be7e7eba7362ce3eecdcff79ab70 (commit)
   via  4988b914e1fb7ca215436738ab08ed199a6f63d2 (commit)
   via  11e0ceaeab905075d93e279b87470b99c6401929 (commit)
  from  3932f9cf5e3ffad641988e6f36abd69c02667fe7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=cdf7e5800504307b820f742fc3944391d6e37292
commit cdf7e5800504307b820f742fc3944391d6e37292
Merge: 3932f9c 7b6349d
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Aug 18 14:37:12 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Thu Aug 18 14:37:12 2016 -0400

Merge topic 'else-after-return' into next

7b6349da CMake: don't use else after return
50ad1e0a CTest: don't use else after return
7f97a6c9 CPack: don't use else after return
4988b914 CursesDialog: don't use else after return
11e0ceae CMake Nightly Date Stamp


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7b6349da4dc968691f1a374211fcc153c8b4f1c6
commit 7b6349da4dc968691f1a374211fcc153c8b4f1c6
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Aug 18 20:36:29 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Aug 18 20:36:29 2016 +0200

CMake: don't use else after return

diff --git a/Source/cmArchiveWrite.cxx b/Source/cmArchiveWrite.cxx
index 3da4f28..df07ccc 100644
--- a/Source/cmArchiveWrite.cxx
+++ b/Source/cmArchiveWrite.cxx
@@ -71,9 +71,8 @@ struct cmArchiveWrite::Callback
 if (self->Stream.write(static_cast(b),
static_cast(n))) {
   return static_cast<__LA_SSIZE_T>(n);
-} else {
-  return static_cast<__LA_SSIZE_T>(-1);
 }
+return static_cast<__LA_SSIZE_T>(-1);
   }
 };
 
diff --git a/Source/cmCTest.cxx b/Source/cmCTest.cxx
index 8a856a8..b4ddc3e 100644
--- a/Source/cmCTest.cxx
+++ b/Source/cmCTest.cxx
@@ -781,13 +781,12 @@ bool cmCTest::SetTest(const char* ttype, bool report)
   if (p != PartCount) {
 this->Parts[p].Enable();
 return true;
-  } else {
-if (report) {
-  cmCTestLog(this, ERROR_MESSAGE, "Don't know about test \""
-   << ttype << "\" yet..." << std::endl);
-}
-return false;
   }
+  if (report) {
+cmCTestLog(this, ERROR_MESSAGE, "Don't know about test \""
+ << ttype << "\" yet..." << std::endl);
+  }
+  return false;
 }
 
 void cmCTest::Finalize()
diff --git a/Source/cmCacheManager.cxx b/Source/cmCacheManager.cxx
index bdd7303..2571698 100644
--- a/Source/cmCacheManager.cxx
+++ b/Source/cmCacheManager.cxx
@@ -574,7 +574,8 @@ const char* cmCacheManager::CacheEntry::GetProperty(
 {
   if (prop == "TYPE") {
 return cmState::CacheEntryTypeToString(this->Type);
-  } else if (prop == "VALUE") {
+  }
+  if (prop == "VALUE") {
 return this->Value.c_str();
   }
   return this->Properties.GetPropertyValue(prop);
diff --git a/Source/cmCommandArgumentParserHelper.cxx 
b/Source/cmCommandArgumentParserHelper.cxx
index 42fb105..68111a0 100644
--- a/Source/cmCommandArgumentParserHelper.cxx
+++ b/Source/cmCommandArgumentParserHelper.cxx
@@ -75,9 +75,8 @@ char* 
cmCommandArgumentParserHelper::ExpandSpecialVariable(const char* key,
 if (cmSystemTools::GetEnv(var, str)) {
   if (this->EscapeQuotes) {
 return this->AddString(cmSystemTools::EscapeQuotes(str.c_str()));
-  } else {
-return this->AddString(str);
   }
+  return this->AddString(str);
 }
 return this->EmptyVariable;
   }
@@ -86,9 +85,8 @@ char* 
cmCommandArgumentParserHelper::ExpandSpecialVariable(const char* key,
   this->Makefile->GetState()->GetInitializedCacheValue(var)) {
   if (this->EscapeQuotes) {
 return this->AddString(cmSystemTools::EscapeQuotes(c));
-  } else {
-return this->AddString(c);
   }
+  return this->AddString(c);
 }
 return this->EmptyVariable;
   }
@@ -162,7 +160,8 @@ char* cmCommandArgumentParserHelper::CombineUnions(char* 
in1, char* in2)
 {
   if (!in1) {
 return in2;
-  } else if (!in2) {
+  }
+  if (!in2) {
 return in1;
   }
   size_t len = strlen(in1) + strlen(in2) + 1;
@@ -28

[cmake-developers] variables for top level project version

[Daniel Pfeifer]

Hi!

The project() command currently sets some variables in both
PROJECT_ and _ form. So far good.

It also sets CMAKE_PROJECT_NAME to the top level project name.  This
is not documented.

It does not set any other variables of the form CMAKE_PROJECT_.
This would be useful for the version variables.

CPack.cmake initializes CPACK_PACKAGE_NAME with ${CMAKE_PROJECT_NAME},
but it initializes CPACK_PACKAGE_VERSION with "0.1.1".  It should
initialize all version variables with the values from the top level
project() command.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.6.1-1302-g1cca31b

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  1cca31b2f5b2ac7ba21711fbe612b37d1ecc6b6c (commit)
   via  ccb9a992dc78d04112075f4667792c89239b74d1 (commit)
  from  951bc07441bdf29dde92ff7e0a58ec5b21a847f5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1cca31b2f5b2ac7ba21711fbe612b37d1ecc6b6c
commit 1cca31b2f5b2ac7ba21711fbe612b37d1ecc6b6c
Merge: 951bc07 ccb9a99
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 17 18:32:07 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Aug 17 18:32:07 2016 -0400

Merge topic 'include-what-you-use' into next

ccb9a992 fixup! fix a batch of include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ccb9a992dc78d04112075f4667792c89239b74d1
commit ccb9a992dc78d04112075f4667792c89239b74d1
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Aug 18 00:31:49 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Aug 18 00:31:49 2016 +0200

fixup! fix a batch of include-what-you-use violations

diff --git a/Source/cmArchiveWrite.cxx b/Source/cmArchiveWrite.cxx
index fa5a08e..0504f70 100644
--- a/Source/cmArchiveWrite.cxx
+++ b/Source/cmArchiveWrite.cxx
@@ -18,9 +18,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
-#include 
 
 #ifndef __LA_SSIZE_T
 #define __LA_SSIZE_T la_ssize_t
diff --git a/Source/cmArchiveWrite.h b/Source/cmArchiveWrite.h
index c859453..120453b 100644
--- a/Source/cmArchiveWrite.h
+++ b/Source/cmArchiveWrite.h
@@ -14,8 +14,8 @@
 
 #include  // IWYU pragma: keep
 
-#include 
 #include 
+#include 
 #include 
 
 #if !defined(CMAKE_BUILD_WITH_CMAKE)
diff --git a/Source/cmCacheManager.cxx b/Source/cmCacheManager.cxx
index 386c39a..5b76162 100644
--- a/Source/cmCacheManager.cxx
+++ b/Source/cmCacheManager.cxx
@@ -16,12 +16,12 @@
 #include "cmVersion.h"
 #include "cmake.h"
 
+#include 
 #include 
 #include 
+#include 
 #include 
 #include 
-#include 
-#include 
 
 cmCacheManager::cmCacheManager()
 {
diff --git a/Source/cmCommonTargetGenerator.cxx 
b/Source/cmCommonTargetGenerator.cxx
index f65e2fb..6167e2c 100644
--- a/Source/cmCommonTargetGenerator.cxx
+++ b/Source/cmCommonTargetGenerator.cxx
@@ -11,8 +11,8 @@
 */
 #include "cmCommonTargetGenerator.h"
 
-#include 
 #include 
+#include 
 #include 
 #include 
 #include 
diff --git a/Source/cmComputeLinkDepends.cxx b/Source/cmComputeLinkDepends.cxx
index 644f4a9..98405cf 100644
--- a/Source/cmComputeLinkDepends.cxx
+++ b/Source/cmComputeLinkDepends.cxx
@@ -22,12 +22,12 @@
 #include "cmTarget.h"
 #include "cmake.h"
 
-#include 
-#include 
-#include 
 #include 
+#include 
 #include 
 #include 
+#include 
+#include 
 #include 
 
 /*
diff --git a/Source/cmComputeLinkInformation.cxx 
b/Source/cmComputeLinkInformation.cxx
index 96c36f1..82877f3 100644
--- a/Source/cmComputeLinkInformation.cxx
+++ b/Source/cmComputeLinkInformation.cxx
@@ -25,10 +25,10 @@
 #include "cmTarget.h"
 #include "cmake.h"
 
-#include 
-#include 
 #include 
+#include 
 #include 
+#include 
 #include 
 
 //#define CM_COMPUTE_LINK_INFO_DEBUG
diff --git a/Source/cmComputeTargetDepends.cxx 
b/Source/cmComputeTargetDepends.cxx
index 8b89e33..dd07300 100644
--- a/Source/cmComputeTargetDepends.cxx
+++ b/Source/cmComputeTargetDepends.cxx
@@ -26,8 +26,8 @@
 #include "cmake.h"
 
 #include 
-#include 
 #include 
+#include 
 #include 
 
 class cmListFileBacktrace;

---

Summary of changes:
 Source/cmArchiveWrite.cxx   |2 +-
 Source/cmArchiveWrite.h |2 +-
 Source/cmCacheManager.cxx   |4 ++--
 Source/cmCommonTargetGenerator.cxx  |2 +-
 Source/cmComputeLinkDepends.cxx |6 +++---
 Source/cmComputeLinkInformation.cxx |4 ++--
 Source/cmComputeTargetDepends.cxx   |2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.1-1300-g951bc07

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  951bc07441bdf29dde92ff7e0a58ec5b21a847f5 (commit)
   via  250091ffa36ef6df3f4fb9429aefaef95bf70661 (commit)
   via  373b2e483d983136415190dcc838e636077e5991 (commit)
  from  2e928b19d912dcb7db0c6b10a89a35c5b5e2462d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=951bc07441bdf29dde92ff7e0a58ec5b21a847f5
commit 951bc07441bdf29dde92ff7e0a58ec5b21a847f5
Merge: 2e928b1 250091f
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 17 18:24:49 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Aug 17 18:24:49 2016 -0400

Merge topic 'include-what-you-use' into next

250091ff fix a batch of include-what-you-use violations
373b2e48 cmArchiveWrite: replace mode_t with int


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=250091ffa36ef6df3f4fb9429aefaef95bf70661
commit 250091ffa36ef6df3f4fb9429aefaef95bf70661
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Aug 18 00:24:24 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Aug 18 00:24:24 2016 +0200

fix a batch of include-what-you-use violations

diff --git a/Source/cmArchiveWrite.cxx b/Source/cmArchiveWrite.cxx
index 56da2ac..fa5a08e 100644
--- a/Source/cmArchiveWrite.cxx
+++ b/Source/cmArchiveWrite.cxx
@@ -16,7 +16,11 @@
 #include "cm_get_date.h"
 #include 
 #include 
+#include 
 #include 
+#include 
+#include 
+#include 
 
 #ifndef __LA_SSIZE_T
 #define __LA_SSIZE_T la_ssize_t
diff --git a/Source/cmArchiveWrite.h b/Source/cmArchiveWrite.h
index b15c15a..c859453 100644
--- a/Source/cmArchiveWrite.h
+++ b/Source/cmArchiveWrite.h
@@ -12,7 +12,11 @@
 #ifndef cmArchiveWrite_h
 #define cmArchiveWrite_h
 
-#include "cmStandardIncludes.h"
+#include  // IWYU pragma: keep
+
+#include 
+#include 
+#include 
 
 #if !defined(CMAKE_BUILD_WITH_CMAKE)
 #error "cmArchiveWrite not allowed during bootstrap build!"
diff --git a/Source/cmCLocaleEnvironmentScope.cxx 
b/Source/cmCLocaleEnvironmentScope.cxx
index e4c74ec..e38f531 100644
--- a/Source/cmCLocaleEnvironmentScope.cxx
+++ b/Source/cmCLocaleEnvironmentScope.cxx
@@ -15,6 +15,7 @@
 #include "cmSystemTools.h"
 
 #include 
+#include 
 
 cmCLocaleEnvironmentScope::cmCLocaleEnvironmentScope()
 {
diff --git a/Source/cmCLocaleEnvironmentScope.h 
b/Source/cmCLocaleEnvironmentScope.h
index b011741..572beaf 100644
--- a/Source/cmCLocaleEnvironmentScope.h
+++ b/Source/cmCLocaleEnvironmentScope.h
@@ -13,7 +13,10 @@
 #ifndef cmCLocaleEnvironmentScope_h
 #define cmCLocaleEnvironmentScope_h
 
-#include "cmStandardIncludes.h"
+#include  // IWYU pragma: keep
+
+#include 
+#include 
 
 class cmCLocaleEnvironmentScope
 {
diff --git a/Source/cmCPackPropertiesGenerator.cxx 
b/Source/cmCPackPropertiesGenerator.cxx
index af01c7d..ae6b0a1 100644
--- a/Source/cmCPackPropertiesGenerator.cxx
+++ b/Source/cmCPackPropertiesGenerator.cxx
@@ -1,8 +1,13 @@
 #include "cmCPackPropertiesGenerator.h"
 
-#include "cmLocalGenerator.h"
+#include "cmGeneratorExpression.h"
+#include "cmInstalledFile.h"
 #include "cmOutputConverter.h"
 
+#include 
+#include 
+#include 
+
 cmCPackPropertiesGenerator::cmCPackPropertiesGenerator(
   cmLocalGenerator* lg, cmInstalledFile const& installedFile,
   std::vector const& configurations)
diff --git a/Source/cmCPackPropertiesGenerator.h 
b/Source/cmCPackPropertiesGenerator.h
index 4d092f6..77018b0 100644
--- a/Source/cmCPackPropertiesGenerator.h
+++ b/Source/cmCPackPropertiesGenerator.h
@@ -12,9 +12,15 @@
 #ifndef cmCPackPropertiesGenerator_h
 #define cmCPackPropertiesGenerator_h
 
-#include "cmInstalledFile.h"
+#include  // IWYU pragma: keep
+
 #include "cmScriptGenerator.h"
 
+#include 
+#include 
+#include 
+
+class cmInstalledFile;
 class cmLocalGenerator;
 
 /** \class cmCPackPropertiesGenerator
diff --git a/Source/cmCacheManager.cxx b/Source/cmCacheManager.cxx
index bdd7303..386c39a 100644
--- a/Source/cmCacheManager.cxx
+++ b/Source/cmCacheManager.cxx
@@ -16,10 +16,12 @@
 #include "cmVersion.h"
 #include "cmake.h"
 
-#include 
 #include 
 #include 
-#include 
+#include 
+#include 
+#include 
+#include 
 
 cmCacheManager::cmCacheManager()
 {
diff --git a/Source/cmCacheManager.h b/Source/cmCacheManager.h
index 14e0f0a..3e32cf0 100644
--- a/Source/cmCacheManager.h
+++ b/Source/cmCacheManager.h
@@ -12,13 +12,19 @@
 #ifndef cmCacheManager_h
 #define cmCacheManager_h
 
-

[Cmake-commits] CMake branch, next, updated. v3.6.1-1278-g662661b

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  662661b2b462946f8ba6c82af22f014a18619756 (commit)
   via  e7b842e18955d13f6d9c021bab4a8935bf282744 (commit)
  from  11d0fcfcfecdcef2e21a1acb550979d208e43aa0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=662661b2b462946f8ba6c82af22f014a18619756
commit 662661b2b462946f8ba6c82af22f014a18619756
Merge: 11d0fcf e7b842e
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Aug 16 19:50:25 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Aug 16 19:50:25 2016 -0400

Merge topic 'readability-named-parameter' into next

e7b842e1 Make sure unnused parameters are /*named*/


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e7b842e18955d13f6d9c021bab4a8935bf282744
commit e7b842e18955d13f6d9c021bab4a8935bf282744
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 17 01:49:57 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Aug 17 01:49:57 2016 +0200

Make sure unnused parameters are /*named*/

diff --git a/Source/CPack/cmCPackArchiveGenerator.cxx 
b/Source/CPack/cmCPackArchiveGenerator.cxx
index b1f6864..9120a2f 100644
--- a/Source/CPack/cmCPackArchiveGenerator.cxx
+++ b/Source/CPack/cmCPackArchiveGenerator.cxx
@@ -259,7 +259,7 @@ int cmCPackArchiveGenerator::PackageFiles()
   return 1;
 }
 
-int cmCPackArchiveGenerator::GenerateHeader(std::ostream*)
+int cmCPackArchiveGenerator::GenerateHeader(std::ostream* /*unused*/)
 {
   return 1;
 }
diff --git a/Source/CPack/cpack.cxx b/Source/CPack/cpack.cxx
index 771519c..de572c0 100644
--- a/Source/CPack/cpack.cxx
+++ b/Source/CPack/cpack.cxx
@@ -50,7 +50,7 @@ static const char* cmDocumentationOptions[][2] = {
   { CM_NULLPTR, CM_NULLPTR }
 };
 
-int cpackUnknownArgument(const char*, void*)
+int cpackUnknownArgument(const char* /*unused*/, void* /*unused*/)
 {
   return 1;
 }
diff --git a/Source/CTest/cmCTestBZR.cxx b/Source/CTest/cmCTestBZR.cxx
index 0e08e1c..7baf7a3 100644
--- a/Source/CTest/cmCTestBZR.cxx
+++ b/Source/CTest/cmCTestBZR.cxx
@@ -19,7 +19,7 @@
 
 #include 
 
-extern "C" int cmBZRXMLParserUnknownEncodingHandler(void*,
+extern "C" int cmBZRXMLParserUnknownEncodingHandler(void* /*unused*/,
 const XML_Char* name,
 XML_Encoding* info)
 {
@@ -215,7 +215,7 @@ private:
 return true;
   }
 
-  void StartElement(const std::string& name, const char**) CM_OVERRIDE
+  void StartElement(const std::string& name, const char** /*atts*/) CM_OVERRIDE
   {
 this->CData.clear();
 if (name == "log") {
@@ -275,7 +275,7 @@ private:
 this->CData.clear();
   }
 
-  void ReportError(int, int, const char* msg) CM_OVERRIDE
+  void ReportError(int /*line*/, int /*column*/, const char* msg) CM_OVERRIDE
   {
 this->BZR->Log << "Error parsing bzr log xml: " << msg << "\n";
   }
diff --git a/Source/CTest/cmCTestBuildAndTestHandler.cxx 
b/Source/CTest/cmCTestBuildAndTestHandler.cxx
index eddbddc..9dab98a 100644
--- a/Source/CTest/cmCTestBuildAndTestHandler.cxx
+++ b/Source/CTest/cmCTestBuildAndTestHandler.cxx
@@ -123,14 +123,15 @@ int cmCTestBuildAndTestHandler::RunCMake(std::string* 
outstring,
   return 0;
 }
 
-void CMakeMessageCallback(const char* m, const char*, bool&, void* s)
+void CMakeMessageCallback(const char* m, const char* /*unused*/,
+  bool& /*unused*/, void* s)
 {
   std::string* out = (std::string*)s;
   *out += m;
   *out += "\n";
 }
 
-void CMakeProgressCallback(const char* msg, float, void* s)
+void CMakeProgressCallback(const char* msg, float /*unused*/, void* s)
 {
   std::string* out = (std::string*)s;
   *out += msg;
diff --git a/Source/CTest/cmCTestCurl.cxx b/Source/CTest/cmCTestCurl.cxx
index b335e32..6910f6f 100644
--- a/Source/CTest/cmCTestCurl.cxx
+++ b/Source/CTest/cmCTestCurl.cxx
@@ -54,8 +54,8 @@ static size_t curlWriteMemoryCallback(void* ptr, size_t size, 
size_t nmemb,
   return realsize;
 }
 
-static size_t curlDebugCallback(CURL*, curl_infotype, char* chPtr, size_t size,
-void* data)
+static size_t curlDebugCallback(CURL* /*unused*/, curl_infotype /*unused*/,
+char* chPtr, size_t size, void* data)
 {
   std::vector* vec = static_cast<std::vector*>(data);
   vec->insert(vec->end(), chPtr, chPtr + size);
diff --git a/Sou

[Cmake-commits] CMake branch, next, updated. v3.6.1-1276-g11d0fcf

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  11d0fcfcfecdcef2e21a1acb550979d208e43aa0 (commit)
   via  a2af850ba6dbee7797484ec5f6696525123023fc (commit)
  from  bbafe31c4f905a77622f6da7307c05dba838ac80 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=11d0fcfcfecdcef2e21a1acb550979d208e43aa0
commit 11d0fcfcfecdcef2e21a1acb550979d208e43aa0
Merge: bbafe31 a2af850
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Tue Aug 16 19:09:24 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Tue Aug 16 19:09:24 2016 -0400

Merge topic 'include-what-you-use' into next

a2af850b fix a batch of include-what-you-use violations


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a2af850ba6dbee7797484ec5f6696525123023fc
commit a2af850ba6dbee7797484ec5f6696525123023fc
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Aug 17 01:08:13 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Aug 17 01:08:13 2016 +0200

fix a batch of include-what-you-use violations

diff --git a/Source/CursesDialog/cmCursesCacheEntryComposite.h 
b/Source/CursesDialog/cmCursesCacheEntryComposite.h
index 8ed3902..c9c8238 100644
--- a/Source/CursesDialog/cmCursesCacheEntryComposite.h
+++ b/Source/CursesDialog/cmCursesCacheEntryComposite.h
@@ -14,6 +14,8 @@
 
 #include "cmCursesLabelWidget.h"
 
+class cmake;
+
 class cmCursesCacheEntryComposite
 {
 public:
diff --git a/Source/cmCacheManager.h b/Source/cmCacheManager.h
index 2331867..14e0f0a 100644
--- a/Source/cmCacheManager.h
+++ b/Source/cmCacheManager.h
@@ -17,6 +17,7 @@
 #include "cmPropertyMap.h"
 #include "cmState.h"
 
+class cmake;
 class cmMarkAsAdvancedCommand;
 
 /** \class cmCacheManager
diff --git a/Source/cmGhsMultiTargetGenerator.h 
b/Source/cmGhsMultiTargetGenerator.h
index 92a1109..118cae6 100644
--- a/Source/cmGhsMultiTargetGenerator.h
+++ b/Source/cmGhsMultiTargetGenerator.h
@@ -16,13 +16,13 @@
 
 #include "cmTarget.h"
 
+class cmCustomCommand;
 class cmGeneratedFileStream;
+class cmGeneratorTarget;
 class cmGlobalGhsMultiGenerator;
 class cmLocalGhsMultiGenerator;
 class cmMakefile;
 class cmSourceFile;
-class cmGeneratedFileStream;
-class cmCustomCommand;
 
 class cmGhsMultiTargetGenerator
 {
diff --git a/Source/cmState.cxx b/Source/cmState.cxx
index 0470508..d4eb90a 100644
--- a/Source/cmState.cxx
+++ b/Source/cmState.cxx
@@ -15,10 +15,19 @@
 #include "cmCacheManager.h"
 #include "cmCommand.h"
 #include "cmDefinitions.h"
+#include "cmListFileCache.h"
+#include "cmSystemTools.h"
+#include "cmTypeMacro.h"
 #include "cmVersion.h"
 #include "cmake.h"
 
+#include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 struct cmState::SnapshotDataType
 {
diff --git a/Source/cmState.h b/Source/cmState.h
index e5f9917..9ab4213 100644
--- a/Source/cmState.h
+++ b/Source/cmState.h
@@ -12,19 +12,25 @@
 #ifndef cmState_h
 #define cmState_h
 
-#include "cmStandardIncludes.h"
+#include  // IWYU pragma: keep
 
 #include "cmAlgorithms.h"
+#include "cmDefinitions.h"
 #include "cmLinkedTree.h"
 #include "cmPolicies.h"
+#include "cmProperty.h"
 #include "cmPropertyDefinitionMap.h"
 #include "cmPropertyMap.h"
 
-class cmake;
+#include 
+#include 
+#include 
+#include 
+
+class cmCacheManager;
 class cmCommand;
-class cmDefinitions;
 class cmListFileBacktrace;
-class cmCacheManager;
+class cmPropertyDefinition;
 
 class cmState
 {
diff --git a/Source/cmSystemTools.h b/Source/cmSystemTools.h
index d0a28e1..3c1a9f4 100644
--- a/Source/cmSystemTools.h
+++ b/Source/cmSystemTools.h
@@ -12,10 +12,13 @@
 #ifndef cmSystemTools_h
 #define cmSystemTools_h
 
-#include "cmStandardIncludes.h"
+#include  // IWYU pragma: keep
 
 #include 
 #include 
+#include 
+#include 
+#include 
 
 class cmSystemToolsFileTime;
 
diff --git a/Source/cmTarget.cxx b/Source/cmTarget.cxx
index 8476538..5681885 100644
--- a/Source/cmTarget.cxx
+++ b/Source/cmTarget.cxx
@@ -12,21 +12,25 @@
 #include "cmTarget.h"
 
 #include "cmAlgorithms.h"
-#include "cmComputeLinkInformation.h"
 #include "cmGeneratorExpression.h"
-#include "cmGeneratorExpressionDAGChecker.h"
+#include "cmGeneratorTarget.h"
 #include "cmGlobalGenerator.h"
 #include "cmListFileCache.h"
 #include "cmMakefile.h"
 #include

[Cmake-commits] CMake branch, next, updated. v3.6.1-1172-gd20a973

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  d20a9735cddbdceda3ee3122711feaab7cb74818 (commit)
   via  551b4c90626357ee9b6048e89c7406f3b4063fbb (commit)
   via  3a7be4f3943e160b1c0c144d914d3dd2ba42819e (commit)
  from  c758d6a57f6f8ee85be063b12123560fa4d174c3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=d20a9735cddbdceda3ee3122711feaab7cb74818
commit d20a9735cddbdceda3ee3122711feaab7cb74818
Merge: c758d6a 551b4c9
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Aug 8 15:51:26 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Mon Aug 8 15:51:26 2016 -0400

Merge topic 'fix-string-append' into next

551b4c90 Revert the use of string(APPEND) in .cmake.in files
3a7be4f3 prefer list(APPEND) over string(APPEND) where appropriate


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=551b4c90626357ee9b6048e89c7406f3b4063fbb
commit 551b4c90626357ee9b6048e89c7406f3b4063fbb
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Aug 8 21:45:41 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Aug 8 21:45:41 2016 +0200

Revert the use of string(APPEND) in .cmake.in files

The generated files may be consumed by older cmake versions which do not
support string(APPEND).

diff --git a/Modules/BasicConfigVersion-AnyNewerVersion.cmake.in 
b/Modules/BasicConfigVersion-AnyNewerVersion.cmake.in
index 3e8c511..bc78016 100644
--- a/Modules/BasicConfigVersion-AnyNewerVersion.cmake.in
+++ b/Modules/BasicConfigVersion-AnyNewerVersion.cmake.in
@@ -26,6 +26,6 @@ endif()
 # check that the installed version has the same 32/64bit-ness as the one which 
is currently searching:
 if(NOT CMAKE_SIZEOF_VOID_P STREQUAL "@CMAKE_SIZEOF_VOID_P@")
math(EXPR installedBits "@CMAKE_SIZEOF_VOID_P@ * 8")
-   string(APPEND PACKAGE_VERSION " (${installedBits}bit)")
+   set(PACKAGE_VERSION "${PACKAGE_VERSION} (${installedBits}bit)")
set(PACKAGE_VERSION_UNSUITABLE TRUE)
 endif()
diff --git a/Modules/BasicConfigVersion-ExactVersion.cmake.in 
b/Modules/BasicConfigVersion-ExactVersion.cmake.in
index 5741007..de4a23a 100644
--- a/Modules/BasicConfigVersion-ExactVersion.cmake.in
+++ b/Modules/BasicConfigVersion-ExactVersion.cmake.in
@@ -42,6 +42,6 @@ endif()
 # check that the installed version has the same 32/64bit-ness as the one which 
is currently searching:
 if(NOT CMAKE_SIZEOF_VOID_P STREQUAL "@CMAKE_SIZEOF_VOID_P@")
   math(EXPR installedBits "@CMAKE_SIZEOF_VOID_P@ * 8")
-  string(APPEND PACKAGE_VERSION " (${installedBits}bit)")
+  set(PACKAGE_VERSION "${PACKAGE_VERSION} (${installedBits}bit)")
   set(PACKAGE_VERSION_UNSUITABLE TRUE)
 endif()
diff --git a/Modules/BasicConfigVersion-SameMajorVersion.cmake.in 
b/Modules/BasicConfigVersion-SameMajorVersion.cmake.in
index 0fad8a3..a32245d 100644
--- a/Modules/BasicConfigVersion-SameMajorVersion.cmake.in
+++ b/Modules/BasicConfigVersion-SameMajorVersion.cmake.in
@@ -41,6 +41,6 @@ endif()
 # check that the installed version has the same 32/64bit-ness as the one which 
is currently searching:
 if(NOT CMAKE_SIZEOF_VOID_P STREQUAL "@CMAKE_SIZEOF_VOID_P@")
   math(EXPR installedBits "@CMAKE_SIZEOF_VOID_P@ * 8")
-  string(APPEND PACKAGE_VERSION " (${installedBits}bit)")
+  set(PACKAGE_VERSION "${PACKAGE_VERSION} (${installedBits}bit)")
   set(PACKAGE_VERSION_UNSUITABLE TRUE)
 endif()

https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3a7be4f3943e160b1c0c144d914d3dd2ba42819e
commit 3a7be4f3943e160b1c0c144d914d3dd2ba42819e
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Mon Aug 8 21:25:41 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Mon Aug 8 21:28:52 2016 +0200

prefer list(APPEND) over string(APPEND) where appropriate

diff --git a/Modules/ExternalProject.cmake b/Modules/ExternalProject.cmake
index 44bf957..fc01976 100644
--- a/Modules/ExternalProject.cmake
+++ b/Modules/ExternalProject.cmake
@@ -1133,7 +1133,7 @@ function(_ep_command_line_to_initial_cache var args force)
   endif()
 else()
   # Assume this is a list to append to the last var
-  string(APPEND accumulator ";${line}")
+  list(APPEND accumulator "${line}")
 endif()
   endforeach()
   # Catch the final line of the args
diff --git a/Modules/FindQt4.cmake b/Modules/FindQt4.cmake
index bf41ea1..7c41b99 100644
--- a/Modules/FindQt4.cmake
+++ b/Modules/Fin

[Cmake-commits] CMake branch, next, updated. v3.6.1-989-g10aeccb

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  10aeccbfbd4d34050a470f59757a81cd553f0eb2 (commit)
   via  7a649111cdea2b10f2ec57084416be619867fbfb (commit)
   via  5d0d980d9949daf596e10715d686adc95c1c232b (commit)
   via  73c618be7036c693cbff764b3765de1bf4626cfb (commit)
   via  8f884f2146132a3815b0295b1bfbfde1 (commit)
  from  e752540b9f56d82cc5527c681c3883df66730c48 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=10aeccbfbd4d34050a470f59757a81cd553f0eb2
commit 10aeccbfbd4d34050a470f59757a81cd553f0eb2
Merge: e752540 7a64911
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Jul 27 18:45:30 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Jul 27 18:45:30 2016 -0400

Merge topic 'use-string-append' into next

7a649111 Use string(APPEND) in Tests
5d0d980d Use string(APPEND) in Modules
73c618be CMake Nightly Date Stamp
8f884f21 CMake Nightly Date Stamp


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7a649111cdea2b10f2ec57084416be619867fbfb
commit 7a649111cdea2b10f2ec57084416be619867fbfb
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Thu Jul 28 00:43:04 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Thu Jul 28 00:43:04 2016 +0200

Use string(APPEND) in Tests

Automate with:

find Tests -type f -print0 | xargs -0 perl -i -0pe \
's/set\(([a-zA-Z0-9_]+)(\s+)"\$\{\1\}([^"])/string(APPEND \1\2"\3/g'

diff --git a/Tests/AliasTarget/CMakeLists.txt b/Tests/AliasTarget/CMakeLists.txt
index 47ccbdc..f9ae03a 100644
--- a/Tests/AliasTarget/CMakeLists.txt
+++ b/Tests/AliasTarget/CMakeLists.txt
@@ -8,7 +8,7 @@ set(CMAKE_CXX_STANDARD 98)
 # template support also need a flag to use the newer C++ library.
 if (CMAKE_CXX_COMPILER_ID STREQUAL HP AND
 CMAKE_CXX98_STANDARD_COMPILE_OPTION STREQUAL "+hpxstd98")
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -AA")
+  string(APPEND CMAKE_CXX_FLAGS " -AA")
 endif ()
 
 # Clang/C2 in C++98 mode cannot properly handle some of MSVC headers
diff --git a/Tests/CMakeOnly/CheckCXXSymbolExists/CMakeLists.txt 
b/Tests/CMakeOnly/CheckCXXSymbolExists/CMakeLists.txt
index 9528aa3..f058c19 100644
--- a/Tests/CMakeOnly/CheckCXXSymbolExists/CMakeLists.txt
+++ b/Tests/CMakeOnly/CheckCXXSymbolExists/CMakeLists.txt
@@ -50,7 +50,7 @@ else ()
 endif ()
 
 if (CMAKE_COMPILER_IS_GNUCXX)
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3")
+  string(APPEND CMAKE_CXX_FLAGS " -O3")
   unset(CSE_RESULT_O3 CACHE)
   message(STATUS "Testing with optimization -O3")
 
diff --git a/Tests/CMakeOnly/CheckStructHasMember/CMakeLists.txt 
b/Tests/CMakeOnly/CheckStructHasMember/CMakeLists.txt
index f06d5c3..a584505 100644
--- a/Tests/CMakeOnly/CheckStructHasMember/CMakeLists.txt
+++ b/Tests/CMakeOnly/CheckStructHasMember/CMakeLists.txt
@@ -77,7 +77,7 @@ endforeach()
 set(CMAKE_TRY_COMPILE_CONFIGURATION ${CMAKE_BUILD_TYPE})
 
 if (CMAKE_COMPILER_IS_GNUCC)
-set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3")
+string(APPEND CMAKE_C_FLAGS " -O3")
 unset(CSHM_RESULT_O3 CACHE)
 unset(CSHM_RESULT_O3_C CACHE)
 unset(CSHM_RESULT_O3_CXX CACHE)
diff --git a/Tests/CMakeOnly/CheckSymbolExists/CMakeLists.txt 
b/Tests/CMakeOnly/CheckSymbolExists/CMakeLists.txt
index 7656577..7f01463 100644
--- a/Tests/CMakeOnly/CheckSymbolExists/CMakeLists.txt
+++ b/Tests/CMakeOnly/CheckSymbolExists/CMakeLists.txt
@@ -39,7 +39,7 @@ else ()
 endif ()
 
 if (CMAKE_COMPILER_IS_GNUCC)
-  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O3")
+  string(APPEND CMAKE_C_FLAGS " -O3")
   unset(CSE_RESULT_O3 CACHE)
   message(STATUS "Testing with optimization -O3")
 
diff --git a/Tests/CMakeTests/ModuleNoticesTest.cmake.in 
b/Tests/CMakeTests/ModuleNoticesTest.cmake.in
index 8ecebd3..7bea0af 100644
--- a/Tests/CMakeTests/ModuleNoticesTest.cmake.in
+++ b/Tests/CMakeTests/ModuleNoticesTest.cmake.in
@@ -35,7 +35,7 @@ foreach(module ${all_modules})
   message(STATUS "module: ${module}")
   file(READ "${dir}/${module}" module_content)
   if(NOT "${module_content}" MATCHES "${notice_regex}")
-set(notice_missing "${notice_missing}  ${module}\n")
+string(APPEND notice_missing "  ${module}\n")
   endif()
 endforeach()
 
diff --git a/Tests/CMakeTests/WhileTest.cmake.in 
b/Tests/CMakeTests/WhileTest.cmake.in
index cc22978..9066544 100644
--- a/Tests/CMakeTests/WhileTest.cmake.in

[cmake-developers] QtAutoGenerators output in Ninja

[Daniel Pfeifer]

Hi,

CMake currently puts messages like "Generating moc source" into the
buildlog. This conflicts with the convention "no output == all good".
The messages blend nicely in the colorful output of Unix Makefiles,
but when using the Ninja generator, they create quite some noise.

How can this be improved?
* remove the messages (no output == all good)
* add an option to silence them
* add an option to show them and hide them per default
* ...

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Improve encoding handling on Windows

[Daniel Pfeifer]

On Fri, Jul 1, 2016 at 4:12 PM, Ben Boeckel  wrote:
> On Fri, Jul 01, 2016 at 16:44:32 +0300, Dāvis Mosāns wrote:
>> 2. change GetEnv to return std::unique_ptr which will be
>>   automatically deleted once out of scope and we still can check if there
>>   wasn't such env if it's empty.
>
> Hrm. I'd rather use std::optional than relying on implicit nullptr
> semantics.

+1.

This class here should be renamed to cmOptional and moved to its own
file, so it may be reused:
http://public.kitware.com/gitweb?p=stage/cmake.git;a=blob;f=Source/cmArchiveWrite.h;h=f847d09b74922e800293e70c3171accb500c083c;hb=refs/heads/master#l22
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] [PATCH] Improve encoding handling on Windows

[Daniel Pfeifer]

Hi Dāvis,

On Fri, Jul 1, 2016 at 4:18 AM, Dāvis Mosāns  wrote:
> On Windows getenv uses ANSI codepage so it needs to be encoded to
> internally used encoding (eg. UTF-8). Here we use _wgetenv instead
> and encode that.

Your change to the SystemTools::GetEnv function introduces memory
leaks, since you return a pointer to a new[]-ed array.
It seems impossible to refactor SystemTools::GetEnv to use _wgetenv
and provide interface compatability.
You should probably introduce a function that returns std::string and
uses GetEnvironmentVariableW internally.

> Also typically Windows applications (eg. MSVC compiler) use current
> console's codepage for output to pipes so we need to encode that
> to internally used encoding (KWSYS_ENCODING_DEFAULT_CODEPAGE).
>
> Next, when we're outputing to console need to use wide functions.
>
> This change allows that compilers such as MSVC on Windows can be
> installed in non-ASCII path and will work correctly for all
> console's codepages which supports that path's characters.

Sounds useful. I cannot really comment on this.

Cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Please apply patch from https://github.com/hunger/CMake/commits/for-upstream to master

[Daniel Pfeifer]

On Wed, Jun 29, 2016 at 10:17 AM, Tobias Hunger  wrote:
> On Mi, 2016-06-29 at 09:54 +0200, Rolf Eike Beer wrote:
>> Am 2016-06-29 09:35, schrieb Tobias Hunger:
>> > Hello Brad,
>> >
>> > I currently get more than 2000 warnings when building cmake master, all
>> > about
>> > missing overrides.
>> >
>> > Could you please take the fix warning patch from
>> > https://github.com/hunger/CMake/commits/for-upstream and apply it to
>> > master?
>> > That fixes all those pesky override warnings.
>>
>> This should be CM_OVERRIDE.
>
> Changed.

Thanks. I merged it to next.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc3-595-g724554c

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  724554c78f73c871c3b67a9498c1db15fd1c43f7 (commit)
   via  4e8480db5425e0acbbd6394593417aab2a1fc3e5 (commit)
  from  0462af8138566f7d9d47cdfa087f65c89cb70a26 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=724554c78f73c871c3b67a9498c1db15fd1c43f7
commit 724554c78f73c871c3b67a9498c1db15fd1c43f7
Merge: 0462af8 4e8480d
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Jun 29 05:54:05 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Jun 29 05:54:05 2016 -0400

Merge topic 'CM_OVERRIDE-cmTypeMacro' into next

4e8480db cmTypeMacro: mark overridden functions with CM_OVERRIDE


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=4e8480db5425e0acbbd6394593417aab2a1fc3e5
commit 4e8480db5425e0acbbd6394593417aab2a1fc3e5
Author: Tobias Hunger <tobias.hun...@qt.io>
AuthorDate: Wed Jun 29 09:31:51 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Jun 29 11:48:50 2016 +0200

cmTypeMacro: mark overridden functions with CM_OVERRIDE

diff --git a/Source/cmTypeMacro.h b/Source/cmTypeMacro.h
index 5c534c3..147eba8 100644
--- a/Source/cmTypeMacro.h
+++ b/Source/cmTypeMacro.h
@@ -15,7 +15,7 @@
 // All subclasses of cmCommand or cmCTestGenericHandler should
 // invoke this macro.
 #define cmTypeMacro(thisClass, superclass)\
-  virtual const char* GetNameOfClass() { return #thisClass; } \
+  const char* GetNameOfClass() CM_OVERRIDE { return #thisClass; } \
   typedef superclass Superclass;  \
   static bool IsTypeOf(const char* type)  \
   {   \
@@ -24,7 +24,10 @@
 } \
 return Superclass::IsTypeOf(type);\
   }   \
-  virtual bool IsA(const char* type) { return thisClass::IsTypeOf(type); }\
+  bool IsA(const char* type) CM_OVERRIDE  \
+  {   \
+return thisClass::IsTypeOf(type); \
+  }   \
   static thisClass* SafeDownCast(cmObject* c) \
   {   \
 if (c && c->IsA(#thisClass)) {\

---

Summary of changes:
 Source/cmTypeMacro.h |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

[Cmake-commits] CMake branch, next, updated. v3.6.0-rc3-593-g0462af8

[Daniel Pfeifer]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "CMake".

The branch, next has been updated
   via  0462af8138566f7d9d47cdfa087f65c89cb70a26 (commit)
   via  3f77655d060ae48fabd9dc5c445cad813a70db42 (commit)
   via  b9b3ec4d98b03c180b2e6b9ad8edba7f75576353 (commit)
  from  c664b95b08f793808d881ed08919bfa1a7fce409 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=0462af8138566f7d9d47cdfa087f65c89cb70a26
commit 0462af8138566f7d9d47cdfa087f65c89cb70a26
Merge: c664b95 3f77655
Author:     Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Jun 29 05:36:48 2016 -0400
Commit: CMake Topic Stage <kwro...@kitware.com>
CommitDate: Wed Jun 29 05:36:48 2016 -0400

Merge topic 'CM_OVERRIDE-clang' into next

3f77655d CM_OVERRIDE: fix feature test for clang
b9b3ec4d CMake Nightly Date Stamp


https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3f77655d060ae48fabd9dc5c445cad813a70db42
commit 3f77655d060ae48fabd9dc5c445cad813a70db42
Author: Daniel Pfeifer <dan...@pfeifer-mail.de>
AuthorDate: Wed Jun 29 11:33:31 2016 +0200
Commit: Daniel Pfeifer <dan...@pfeifer-mail.de>
CommitDate: Wed Jun 29 11:33:38 2016 +0200

CM_OVERRIDE: fix feature test for clang

Clang refuses to default initialize an instance of a class that does not
have a default constructor.  Fix the check by adding default
constructors.  Don't use brace initialization like it is proposed in the
error message.  We want to test the override support independent from
the support for brace initialization.

diff --git a/Source/Checks/cm_cxx_override.cxx 
b/Source/Checks/cm_cxx_override.cxx
index e196968..5a33fbb 100644
--- a/Source/Checks/cm_cxx_override.cxx
+++ b/Source/Checks/cm_cxx_override.cxx
@@ -1,11 +1,13 @@
 struct Foo
 {
+  Foo() {}
   virtual ~Foo() {}
   virtual int test() const = 0;
 };
 
 struct Bar : Foo
 {
+  Bar() {}
   ~Bar() override {}
   int test() const override { return 0; }
 };

---

Summary of changes:
 Source/CMakeVersion.cmake |2 +-
 Source/Checks/cm_cxx_override.cxx |2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
CMake
___
Cmake-commits mailing list
Cmake-commits@cmake.org
http://public.kitware.com/mailman/listinfo/cmake-commits

Re: [cmake-developers] Patch for CM_OVERRIDE

[Daniel Pfeifer]

On Wed, Jun 29, 2016 at 7:15 AM, Roman Wüger  wrote:
> Hello,
>
> I've attached a patch for the CM_OVERRIDE commit

Hi Roman, I added "override" to the destructor on purpose. The intent
is to make the check fail in Visual Studio 10.

See the commit message here:
https://cmake.org/gitweb?p=stage/cmake.git;a=commit;h=9e2d6f0c4d19e1ae1652071ea783ad577ea93e28

cheers, Daniel
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Script to update liblzma from upstream.

[Daniel Pfeifer]

Hi Brad,

I have attached a patch that adds a script to update liblzma from
upstream (closely modeled after the other update scripts).  I am not
sure how these kinds of scripts need to be run.

We currently have a copy of liblzma version 5.0.5. The latest version
on the 5.0 branch is 5.0.8. Once the script is introduced, we may
consider switching to the 5.2 branch.

Cheers, Daniel
From c0401e6f56fe5c9c77e9a80a2c2ab063930f70ed Mon Sep 17 00:00:00 2001
From: Daniel Pfeifer <dan...@pfeifer-mail.de>
Date: Tue, 28 Jun 2016 23:10:11 +0200
Subject: [PATCH] Add script to update liblzma from upstream

---
 Utilities/Scripts/update-liblzma.bash | 29 +
 1 file changed, 29 insertions(+)
 create mode 100755 Utilities/Scripts/update-liblzma.bash

diff --git a/Utilities/Scripts/update-liblzma.bash b/Utilities/Scripts/update-liblzma.bash
new file mode 100755
index 000..4933017
--- /dev/null
+++ b/Utilities/Scripts/update-liblzma.bash
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+
+set -e
+set -x
+shopt -s dotglob
+
+readonly name="liblzma"
+readonly ownership="liblzma upstream <xz-de...@tukaani.org>"
+readonly subtree="Utilities/cmliblzma"
+readonly repo="http://git.tukaani.org/xz.git;
+readonly tag="v5.0"
+readonly shortlog=false
+readonly paths="
+  src/common/sysdefs.h
+  src/common/tuklib_integer.h
+  src/liblzma
+  COPYING
+"
+
+extract_source () {
+git_archive
+pushd "${extractdir}/${name}-reduced"
+mv src/common .
+mv src/liblzma .
+rmdir src
+popd
+}
+
+. "${BASH_SOURCE%/*}/update-third-party.bash"
-- 
2.9.0

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers