Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Rolf Eike Beer]

> I notice in
>  there is
> an unstage comment from you.  Just out of curiosity, does that mean
> that commit was effectively immediately removed from
> stage/master/head?

Yes.

Eike

signature.asc
Description: This is a digitally signed message part.
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Alan W. Irwin]

On 2017-10-25 07:03-0400 Brad King wrote:


On 10/24/2017 05:47 PM, Alan W. Irwin wrote:

Since I essentially never get CMake build errors when building
CMake by hand using the bootstrap method, I assume these build
errors are due to some issue with how I set up my_dashboard.cmake.


The difference is that the script is testing the nightly stage of
in-flight topics that have not yet landed in `master`.  You just
happened to run this for the first time on one of the occasional
nights that compiler errors were introduced.


Hi Brad:

Yes, I sure picked the exact moment of the day where my dashboard was
the first to show the build error for g++ versions of 4.9 or less,
but, of course, a number of other old compiler sites followed at the
times when they completed their nightly tests.

I notice in
 there is
an unstage comment from you.  Just out of curiosity, does that mean
that commit was effectively immediately removed from
stage/master/head?

In any case, my dashboard submission is working now using

ctest -S ~/cmake/Dashboards/Scripts/CMakeScripts/my_dashboard.cmake -VV

See the raven-without-fixed-IP Experimental results at
 and 
.  These results are

perfect other than one CMake configure warning due to a minor system
issue (misspelled COPYONLY as COPY_ONLY) with Debian Jessie Qt5 which
I encounter for all my builds of cmake by hand and which has long
since been fixed for more modern versions of Qt5.

So what is the next step toward the goal of adding a test consisting
of a build of PLplot?

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Brad King]

On 10/24/2017 05:47 PM, Alan W. Irwin wrote:
> Since I essentially never get CMake build errors when building
> CMake by hand using the bootstrap method, I assume these build
> errors are due to some issue with how I set up my_dashboard.cmake.

The difference is that the script is testing the nightly stage of
in-flight topics that have not yet landed in `master`.  You just
happened to run this for the first time on one of the occasional
nights that compiler errors were introduced.

> set(CTEST_SITE "raven home computer")

Please use a name with no spaces.

> Also, as you can see above I did not specify
> CTEST_BUILD_CONFIGURATION, but unlike normal builds it appears for
> this script that the Debug configuration is the default.  How do I
> turn that off?

What configuration do you want to build?  Just

  set(CTEST_BUILD_CONFIGURATION Release)

will build the Release config.

-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Brad King]

On 10/24/2017 05:10 PM, Alan W. Irwin wrote:
> It appears cmake_common.cmake only provides the capability of changing
> the --parallel option for the bootstrap script.  Must I change that
> script in order to specify additional bootstrap options I normally use
> such as --qt-gui --system-curl or is there a less brute-force
> way to specify bootstrap options?

Use the `dashboard_cache` option to initialize the cache with the
desired options rather than having the bootstrap script do it.

-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Brad King]

On 10/25/2017 04:46 AM, Rolf Eike Beer wrote:
> This very much looks like a change I had in a few weeks ago but removed 
> from there because of exactly those compile failures.

This is all under discussion here:

  https://gitlab.kitware.com/cmake/cmake/merge_requests/1402

The errors this time are slightly different but due to similar
limitations on older compilers.

> Just make this file static variables

Good idea, thanks.

-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Rolf Eike Beer]

Am 2017-10-25 02:24, schrieb Alan W. Irwin:

@Matthias:

I am directly addressing you in this post because git bisect says your
recent commit is the first one that shows this issue.  More details 
below.



commit 49287eed2bf9860919a155af848e7cf49d45f504
Author: Matthias Maennich 
Date:   Mon Oct 9 16:25:52 2017 +0200

CommandArgumentParser: avoid strcpy usage

as the first commit that had the bootstrap issue.


This very much looks like a change I had in a few weeks ago but removed 
from there because of exactly those compile failures. This works fine 
with newer gcc and apparently Clang versions, but older compilers do not 
like it.


Looking on that code again: I don't think it is needed to have anything 
of that in the class. Just make this file static variables:


static const char EmptyVariable[] = "";
static char DCURLYVariable[3] = "${";

and then drop those members from the class entirely. Maybe make them 
static variables in the class and initialize them in the cxx file if it 
is needed to have them in the class. But I don't see no reason to have 
them as writable, instance specific class members as those values will 
never change.


Eike
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Alan W. Irwin]

On 2017-10-24 17:24-0700 Alan W. Irwin wrote:


Note the rest of the results at
 appear to have no
build errors like the ones demonstrated on my (Debian Jessie) system
which is why I mentioned my g++ version above.


Oops.  I forgot to include that information so for the record that is g++ 
(Debian
4.9.2-10).

Alan

__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Alan W. Irwin]

@Matthias:

I am directly addressing you in this post because git bisect says your
recent commit is the first one that shows this issue.  More details below.


On 2017-10-24 14:47-0700 Alan W. Irwin wrote:


Hi Brad:

While waiting for your reply to my question concerning how to specify
bootstrap script options, I decided to not specify those additional
options for my initial try.  I submitted that (Experimental) test by hand 
using


ctest -S  -V >& ctest.out1.

The result (which was a build error) is given at
.

Since I essentially never get CMake build errors when building
CMake by hand using the bootstrap method, I assume these build
errors are due to some issue with how I set up my_dashboard.cmake.

Here is the full text of that file:


# Client maintainer: air...@users.sourceforge.net
set(CTEST_SITE "raven home computer")
set(CTEST_BUILD_NAME "Linux-gcc")
#set(CTEST_BUILD_CONFIGURATION Debug)
set(CTEST_CMAKE_GENERATOR "Unix Makefiles")

# Additional variables to set before include:
set(dashboard_model Experimental)
set(CTEST_BUILD_FLAGS -j4)

include(${CTEST_SCRIPT_DIRECTORY}/cmake_common.cmake)


The above -V results from ctest had very little detail about the
build error.  If you don't see anything obvious I should change in
my_dashboard.cmake, would you like me to run ctest -S again with
-VV?

For what it is worth, another difference with how I normally build
cmake is I specified (by accident) the environment variables

CXXFLAGS=-O3 -fvisibility=hidden -Wuninitialized
CFLAGS=-O3 -fvisibility=hidden -Wuninitialized

for this build while for my normal builds I just use -O3 for both flags.

Also, as you can see above I did not specify
CTEST_BUILD_CONFIGURATION, but unlike normal builds it appears for
this script that the Debug configuration is the default.  How do I
turn that off?


Here is some critical information concerning this build issue that I
have gained since the above post:

The version of cmake source that generated the build error for me was
commit 8c5050835 from the (current) HEAD of stage/master/head

Running the bootstrap script for that version by hand
lead to exactly the same "array used as initializer" errors as
in my dashboard submission.  Doing the same thing for v3.10.0-rc3 did not show 
that build error.
git bisecting between those two commits found

commit 49287eed2bf9860919a155af848e7cf49d45f504
Author: Matthias Maennich 
Date:   Mon Oct 9 16:25:52 2017 +0200

CommandArgumentParser: avoid strcpy usage

as the first commit that had the bootstrap issue.

Note the rest of the results at
 appear to have no
build errors like the ones demonstrated on my (Debian Jessie) system
which is why I mentioned my g++ version above.

@Brad and Matthias:

If there is any further test you would like me to run concerning this
build issue, please let me know.

Returning to the original topic, I assume once this CMake build issue
is addressed, that my dashboard submission will start working but I
am still interested in the answers to my questions concerning how
to specify boostrap options, and how to turn off Debug builds
via my_dashboard.cmake.

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Alan W. Irwin]

Hi Brad:

While waiting for your reply to my question concerning how to specify
bootstrap script options, I decided to not specify those additional
options for my initial try.  I submitted that (Experimental) test by hand using

ctest -S  -V >& ctest.out1.

The result (which was a build error) is given at
.

Since I essentially never get CMake build errors when building
CMake by hand using the bootstrap method, I assume these build
errors are due to some issue with how I set up my_dashboard.cmake.

Here is the full text of that file:


# Client maintainer: air...@users.sourceforge.net
set(CTEST_SITE "raven home computer")
set(CTEST_BUILD_NAME "Linux-gcc")
#set(CTEST_BUILD_CONFIGURATION Debug)
set(CTEST_CMAKE_GENERATOR "Unix Makefiles")

# Additional variables to set before include:
set(dashboard_model Experimental)
set(CTEST_BUILD_FLAGS -j4)

include(${CTEST_SCRIPT_DIRECTORY}/cmake_common.cmake)


The above -V results from ctest had very little detail about the
build error.  If you don't see anything obvious I should change in
my_dashboard.cmake, would you like me to run ctest -S again with
-VV?

For what it is worth, another difference with how I normally build
cmake is I specified (by accident) the environment variables

CXXFLAGS=-O3 -fvisibility=hidden -Wuninitialized
CFLAGS=-O3 -fvisibility=hidden -Wuninitialized

for this build while for my normal builds I just use -O3 for both flags.

Also, as you can see above I did not specify
CTEST_BUILD_CONFIGURATION, but unlike normal builds it appears for
this script that the Debug configuration is the default.  How do I
turn that off?

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Alan W. Irwin]

On 2017-10-13 14:58-0400 Brad King wrote:


On 10/13/2017 12:08 AM, Alan W. Irwin wrote:

Accordingly Bill Hoffman suggested to me off-list
some time ago that I configure a CMake dashboard submission that
builds the master HEAD CMake version and tests it with a build and
test of PLplot similarly to what is done for Trilinos.

Could someone here please confirm that code is a good model for
what I should set up in the PLplot case?


Yes, that makes sense.  It will help catch regressions in PLplot early.
The first step is to get a normal CMake nightly build working.
See instructions here:

 https://gitlab.kitware.com/cmake/cmake/blob/master/Help/dev/testing.rst



Hi Brad:

Thanks for your reply to my question.

I have just now started looking at the above instructions.

It appears cmake_common.cmake only provides the capability of changing
the --parallel option for the bootstrap script.  Must I change that
script in order to specify additional bootstrap options I normally use
such as --qt-gui --system-curl or is there a less brute-force
way to specify bootstrap options?

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Re: [cmake-developers] Need more information concerning the Trilinos test of CMake

[Brad King]

On 10/13/2017 12:08 AM, Alan W. Irwin wrote:
> Accordingly Bill Hoffman suggested to me off-list
> some time ago that I configure a CMake dashboard submission that
> builds the master HEAD CMake version and tests it with a build and
> test of PLplot similarly to what is done for Trilinos.
> 
> Could someone here please confirm that code is a good model for
> what I should set up in the PLplot case?

Yes, that makes sense.  It will help catch regressions in PLplot early.
The first step is to get a normal CMake nightly build working.
See instructions here:

  https://gitlab.kitware.com/cmake/cmake/blob/master/Help/dev/testing.rst

Once that is working we can look at adding a PLplot build as a
contract test.  It will work as a "normal" CMake test that is
enabled by local configuration of the build.  The test itself
will drive a PLplot build internally.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

[cmake-developers] Need more information concerning the Trilinos test of CMake

[Alan W. Irwin]

A PLplot configure, build, and test is an excellent indirect test 
of modern CMake because PLplot currently uses


cmake_minimum_required(VERSION 3.6.2 FATAL_ERROR)

and has a relatively small and fast build but with a rather complex
build system for its size that has been developed over the course of
the last decade. Accordingly Bill Hoffman suggested to me off-list
some time ago that I configure a CMake dashboard submission that
builds the master HEAD CMake version and tests it with a build and
test of PLplot similarly to what is done for Trilinos.  But I am only
getting around to this now, and all I can find in the CMake source
code with regard to Trilinos is Tests/Contracts/Trilinos.

Could someone here please confirm that code is a good model for
what I should set up in the PLplot case?

Assuming that is the case, and I modify my local CMake git repository
to add the required files in Tests/Contracts/PLplot and build that
modified CMake, how would I
submit an Experimental CMake dashboard to test my work?

Or more directly, how would I submit an Experimental CMake dashboard to test
the existing Trilinos case?

Alan
__
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__

Linux-powered Science
__
--

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers