[GitHub] [airflow] potiuk commented on issue #6909: [AIRFLOW-6359] spark_submit_hook.py status polling interval config
potiuk commented on issue #6909: [AIRFLOW-6359] spark_submit_hook.py status polling interval config URL: https://github.com/apache/airflow/pull/6909#issuecomment-569215566 Same here @tooptoop4 -> pre-commit checks are helpful to catch those static-check problems before they are committed/pushed to the repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6908: [AIRFLOW-6358] - log details of failed task
potiuk commented on issue #6908: [AIRFLOW-6358] - log details of failed task URL: https://github.com/apache/airflow/pull/6908#issuecomment-569215215 It's nice - but the static checks are failing @tooptoop4. I recommend using pre-commit hooks we configured for everyone to use: https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-6272) Manage front-end JS deps with yarnpkg instead of npm
[ https://issues.apache.org/jira/browse/AIRFLOW-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-6272: -- Fix Version/s: (was: 2.0.0) 1.10.8 > Manage front-end JS deps with yarnpkg instead of npm > > > Key: AIRFLOW-6272 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6272 > Project: Apache Airflow > Issue Type: Improvement > Components: ui >Affects Versions: 2.0.0 >Reporter: Ash Berlin-Taylor >Assignee: Ash Berlin-Taylor >Priority: Minor > Fix For: 1.10.8 > > > NPM seems to be really slow at installing things, and is error-prone/tricky > to get the "locked" version installed. > Yarn (or yarnpkg to not be confused with hadoop's yarn) is a "new" (few years > old now) BSD-licesned JS package manager https://yarnpkg.com out of Facebook -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AIRFLOW-6362) Fix typehint for CommandType
[ https://issues.apache.org/jira/browse/AIRFLOW-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk resolved AIRFLOW-6362. --- Fix Version/s: 2.0.0 Resolution: Fixed > Fix typehint for CommandType > > > Key: AIRFLOW-6362 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6362 > Project: Apache Airflow > Issue Type: Bug > Components: executors >Affects Versions: 1.10.6 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > > The current type is too general. It allows situations that types that are not > used and are not tested. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6362) Fix typehint for CommandType
[ https://issues.apache.org/jira/browse/AIRFLOW-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003955#comment-17003955 ] ASF subversion and git services commented on AIRFLOW-6362: -- Commit 933e5c23c7d4ab657e1a911e4d39818b14069e5d in airflow's branch refs/heads/master from Kamil Breguła [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=933e5c2 ] [AIRFLOW-6362] Fix typehint for CommandType (#6906) > Fix typehint for CommandType > > > Key: AIRFLOW-6362 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6362 > Project: Apache Airflow > Issue Type: Bug > Components: executors >Affects Versions: 1.10.6 >Reporter: Kamil Bregula >Priority: Major > Fix For: 2.0.0 > > > The current type is too general. It allows situations that types that are not > used and are not tested. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6362) Fix typehint for CommandType
[ https://issues.apache.org/jira/browse/AIRFLOW-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003954#comment-17003954 ] ASF GitHub Bot commented on AIRFLOW-6362: - potiuk commented on pull request #6906: [AIRFLOW-6362] Fix typehint for CommandType URL: https://github.com/apache/airflow/pull/6906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix typehint for CommandType > > > Key: AIRFLOW-6362 > URL: https://issues.apache.org/jira/browse/AIRFLOW-6362 > Project: Apache Airflow > Issue Type: Bug > Components: executors >Affects Versions: 1.10.6 >Reporter: Kamil Bregula >Priority: Major > > The current type is too general. It allows situations that types that are not > used and are not tested. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] potiuk merged pull request #6906: [AIRFLOW-6362] Fix typehint for CommandType
potiuk merged pull request #6906: [AIRFLOW-6362] Fix typehint for CommandType URL: https://github.com/apache/airflow/pull/6906 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-6366) Fix migrations for MS SQL Server
[
https://issues.apache.org/jira/browse/AIRFLOW-6366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bjorn Olsen updated AIRFLOW-6366:
-
Description:
Although MS SQL Server is not officially supported as a backend database, I am
using it via PyODBC and found a minor issue with migration from 1.10.6 to
1.10.7.
Below is a log excerpt showing the issue:
INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 -> d38e04c12aa2,
add serialized_dag table
sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'JSON_VALID' is not a
recognized built-in function name. (195) (SQLExecDirectW)")
was:
Although MS SQL Server is not officially supported, I am using it via PyODBC
and found a minor issue with migration from 1.10.6 to 1.10.7.
Below is a log excerpt showing the issue:
INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 -> d38e04c12aa2,
add serialized_dag table
sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'JSON_VALID' is not a
recognized built-in function name. (195) (SQLExecDirectW)")
> Fix migrations for MS SQL Server
>
>
> Key: AIRFLOW-6366
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6366
> Project: Apache Airflow
> Issue Type: Bug
> Components: database
>Affects Versions: 1.10.7
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
>
> Although MS SQL Server is not officially supported as a backend database, I
> am using it via PyODBC and found a minor issue with migration from 1.10.6 to
> 1.10.7.
>
> Below is a log excerpt showing the issue:
> INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 ->
> d38e04c12aa2, add serialized_dag table
> sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
> [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'JSON_VALID' is not a
> recognized built-in function name. (195) (SQLExecDirectW)")
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [6fffa5b...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [6fffa5b...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [6fffa5b...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [6fffa5b...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/70b4a4532d8b91936104ab67e0cb1e4cdea4205a?src=pr=desc) will **decrease** coverage by `0.17%`. > The diff coverage is `61.38%`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.61% 84.43% -0.18% == Files 680 679 -1 Lines 3850138505 +4 == - Hits3257832513 -65 - Misses 5923 5992 +69 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/qubole\_hook.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3F1Ym9sZV9ob29rLnB5) | `52.67% <ø> (ø)` | :arrow_up: | | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.59% <ø> (ø)` | :arrow_up: | | [airflow/executors/debug\_executor.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGVidWdfZXhlY3V0b3IucHk=) | `92.06% <ø> (ø)` | :arrow_up: | | [airflow/executors/base\_executor.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvYmFzZV9leGVjdXRvci5weQ==) | `96.05% <ø> (ø)` | :arrow_up: | | [airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=) | `42.46% <0%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.28% <0%> (ø)` | :arrow_up: | | [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `0% <0%> (ø)` | :arrow_up: | | [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.08% <100%> (ø)` | :arrow_up: | | [airflow/plugins\_manager.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9wbHVnaW5zX21hbmFnZXIucHk=) | `87.17% <100%> (ø)` | :arrow_up: | | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `71.73% <100%> (ø)` | :arrow_up: | | ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [70b4a45...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io edited a comment on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [6fffa5b...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
codecov-io commented on issue #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server URL: https://github.com/apache/airflow/pull/6920#issuecomment-569206750 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=h1) Report > Merging [#6920](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6920 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6920/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=footer). Last update [6fffa5b...aa17f65](https://codecov.io/gh/apache/airflow/pull/6920?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6633: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker
codecov-io edited a comment on issue #6633: [AIRFLOW-2279] Clear tasks across DAGs if marked by ExternalTaskMarker URL: https://github.com/apache/airflow/pull/6633#issuecomment-560395451 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=h1) Report > Merging [#6633](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.17%`. > The diff coverage is `86.2%`. [](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6633 +/- ## == - Coverage 84.72% 84.54% -0.18% == Files 679 680 +1 Lines 3850538562 +57 == - Hits3262332604 -19 - Misses 5882 5958 +76 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=tree) | Coverage Δ | | |---|---|---| | [...rflow/example\_dags/example\_external\_task\_marker.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9leHRlcm5hbF90YXNrX21hcmtlci5weQ==) | `100% <100%> (ø)` | | | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `75.95% <50%> (-0.13%)` | :arrow_down: | | [airflow/sensors/external\_task\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy9zZW5zb3JzL2V4dGVybmFsX3Rhc2tfc2Vuc29yLnB5) | `85.52% <84.21%> (-0.44%)` | :arrow_down: | | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.94% <90.47%> (-0.02%)` | :arrow_down: | | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `56% <0%> (-32%)` | :arrow_down: | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `80.95% <0%> (-7.05%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `89.83% <0%> (-6.78%)` | :arrow_down: | | [airflow/utils/helpers.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9oZWxwZXJzLnB5) | `76.43% <0%> (-6.33%)` | :arrow_down: | | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/6633/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `88.08% <0%> (-1.18%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=footer). Last update [6fffa5b...577b454](https://codecov.io/gh/apache/airflow/pull/6633?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] baolsen opened a new pull request #6920: [AIRFLOW-6366] Fix migrations for MS SQL Server
baolsen opened a new pull request #6920: [AIRFLOW-6366] Fix migrations for MS
SQL Server
URL: https://github.com/apache/airflow/pull/6920
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Although MS SQL Server is not officially supported, I am using it via PyODBC
and found a minor issue with migration from 1.10.6 to 1.10.7.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
None
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-6366) Fix migrations for MS SQL Server
[
https://issues.apache.org/jira/browse/AIRFLOW-6366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003915#comment-17003915
]
ASF GitHub Bot commented on AIRFLOW-6366:
-
baolsen commented on pull request #6920: [AIRFLOW-6366] Fix migrations for MS
SQL Server
URL: https://github.com/apache/airflow/pull/6920
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
Although MS SQL Server is not officially supported, I am using it via PyODBC
and found a minor issue with migration from 1.10.6 to 1.10.7.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
None
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix migrations for MS SQL Server
>
>
> Key: AIRFLOW-6366
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6366
> Project: Apache Airflow
> Issue Type: Bug
> Components: database
>Affects Versions: 1.10.7
>Reporter: Bjorn Olsen
>Assignee: Bjorn Olsen
>Priority: Minor
>
> Although MS SQL Server is not officially supported, I am using it via PyODBC
> and found a minor issue with migration from 1.10.6 to 1.10.7.
>
> Below is a log excerpt showing the issue:
> INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 ->
> d38e04c12aa2, add serialized_dag table
> sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
> [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'JSON_VALID' is not a
> recognized built-in function name. (195) (SQLExecDirectW)")
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (AIRFLOW-6366) Fix migrations for MS SQL Server
Bjorn Olsen created AIRFLOW-6366:
Summary: Fix migrations for MS SQL Server
Key: AIRFLOW-6366
URL: https://issues.apache.org/jira/browse/AIRFLOW-6366
Project: Apache Airflow
Issue Type: Bug
Components: database
Affects Versions: 1.10.7
Reporter: Bjorn Olsen
Assignee: Bjorn Olsen
Although MS SQL Server is not officially supported, I am using it via PyODBC
and found a minor issue with migration from 1.10.6 to 1.10.7.
Below is a log excerpt showing the issue:
INFO [alembic.runtime.migration] Running upgrade 6e96a59344a4 -> d38e04c12aa2,
add serialized_dag table
sqlalchemy.exc.ProgrammingError: (pyodbc.ProgrammingError) ('42000', "[42000]
[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]'JSON_VALID' is not a
recognized built-in function name. (195) (SQLExecDirectW)")
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] codecov-io edited a comment on issue #6898: [AIRFLOW-6432] fix EmrAddStepsOperator broken ref & faulty test & add test case for missing cluster
codecov-io edited a comment on issue #6898: [AIRFLOW-6432] fix EmrAddStepsOperator broken ref & faulty test & add test case for missing cluster URL: https://github.com/apache/airflow/pull/6898#issuecomment-568865752 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=h1) Report > Merging [#6898](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/581a39575108e4cfe936f10644c62b1911087948?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `87.5%`. [](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6898 +/- ## == - Coverage 84.62% 84.33% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3258432477 -107 - Misses 5921 6032 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=tree) | Coverage Δ | | |---|---|---| | [...irflow/contrib/operators/emr\_add\_steps\_operator.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9lbXJfYWRkX3N0ZXBzX29wZXJhdG9yLnB5) | `91.89% <100%> (+0.71%)` | :arrow_up: | | [airflow/contrib/hooks/emr\_hook.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Vtcl9ob29rLnB5) | `93.75% <66.66%> (+0.2%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | | [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6898/diff?src=pr=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=footer). Last update [581a395...d5d7fc0](https://codecov.io/gh/apache/airflow/pull/6898?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] xinbinhuang commented on issue #6902: [AIRFLOW-XXXX] Fix development packages installtion instructions
xinbinhuang commented on issue #6902: [AIRFLOW-] Fix development packages installtion instructions URL: https://github.com/apache/airflow/pull/6902#issuecomment-569172501 @potiuk Small doc update on this. PTAL when you have time. Merry X'Mas! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [6fffa5b...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [6fffa5b...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [6fffa5b...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [947fb64...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [6fffa5b...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io commented on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [947fb64...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [947fb64...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
codecov-io edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569170043 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=h1) Report > Merging [#6913](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6913 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6913/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=footer). Last update [6fffa5b...c6d13c1](https://codecov.io/gh/apache/airflow/pull/6913?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io commented on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [6fffa5b...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh…
codecov-io edited a comment on issue #6917: [AIRFLOW-6350] security - spark submit operator logging+exceptions sh… URL: https://github.com/apache/airflow/pull/6917#issuecomment-569166214 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=h1) Report > Merging [#6917](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6917 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538508 +3 == - Hits3262332516 -107 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.71% <100%> (+0.21%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6917/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=footer). Last update [947fb64...cf51b23](https://codecov.io/gh/apache/airflow/pull/6917?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io commented on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
codecov-io edited a comment on issue #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#issuecomment-569157715 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=h1) Report > Merging [#6918](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6918 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538509 +4 == - Hits3262332516 -107 - Misses 5882 5993 +111 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/spark\_submit\_hook.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3NwYXJrX3N1Ym1pdF9ob29rLnB5) | `82.37% <75%> (-0.13%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6918/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=footer). Last update [6fffa5b...a4b4161](https://codecov.io/gh/apache/airflow/pull/6918?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-5406) Allow spark_submit_hook to run without pip install kubernetes/airflow[kubernetes]
[ https://issues.apache.org/jira/browse/AIRFLOW-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] t oo updated AIRFLOW-5406: -- Priority: Critical (was: Minor) > Allow spark_submit_hook to run without pip install > kubernetes/airflow[kubernetes] > - > > Key: AIRFLOW-5406 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5406 > Project: Apache Airflow > Issue Type: Improvement > Components: dependencies, executor-kubernetes, executors >Affects Versions: 1.10.5 >Reporter: t oo >Assignee: Daniel Imberman >Priority: Critical > > Allow spark_submit_hook to run without pip install > kubernetes/airflow[kubernetes] > k8s dependencies causing issues for non-k8s users based on 1.10.6: > *settings.py:* > from airflow.contrib.kubernetes.pod import Pod > def pod_mutation_hook(pod): > *models/__init__.py* > from airflow.models.kubernetes import KubeWorkerIdentifier, > KubeResourceVersion > *executors/__init__.py* > KubernetesExecutor = "KubernetesExecutor" > elif executor_name == Executors.KubernetesExecutor: > from airflow.contrib.executors.kubernetes_executor import > KubernetesExecutor > return KubernetesExecutor() > *spark_submit_hook.py* > from airflow.contrib.kubernetes import kube_client -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AIRFLOW-5406) Allow spark_submit_hook to run without pip install kubernetes/airflow[kubernetes]
[ https://issues.apache.org/jira/browse/AIRFLOW-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] t oo updated AIRFLOW-5406: -- Priority: Blocker (was: Critical) > Allow spark_submit_hook to run without pip install > kubernetes/airflow[kubernetes] > - > > Key: AIRFLOW-5406 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5406 > Project: Apache Airflow > Issue Type: Improvement > Components: dependencies, executor-kubernetes, executors >Affects Versions: 1.10.5 >Reporter: t oo >Assignee: Daniel Imberman >Priority: Blocker > > Allow spark_submit_hook to run without pip install > kubernetes/airflow[kubernetes] > k8s dependencies causing issues for non-k8s users based on 1.10.6: > *settings.py:* > from airflow.contrib.kubernetes.pod import Pod > def pod_mutation_hook(pod): > *models/__init__.py* > from airflow.models.kubernetes import KubeWorkerIdentifier, > KubeResourceVersion > *executors/__init__.py* > KubernetesExecutor = "KubernetesExecutor" > elif executor_name == Executors.KubernetesExecutor: > from airflow.contrib.executors.kubernetes_executor import > KubernetesExecutor > return KubernetesExecutor() > *spark_submit_hook.py* > from airflow.contrib.kubernetes import kube_client -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] tooptoop4 edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
tooptoop4 edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569151360 @nuclearpinguin k, maybe docs need update as brew install xmllint does not work on Mac but brew install libxml2 works. Full steps I needed to get the checks: (assuming brew and pip already installed) pip install pre-commit brew install gnu-getopt coreutils echo 'export PATH="/usr/local/opt/gnu-getopt/bin:$PATH"' >> ~/.bash_profile;. ~/.bash_profile brew cask install docker run docker from Applications This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551255 ## File path: airflow/providers/mssql/hooks/mssql_odbc.py ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains MS Sql Odbc hook. +""" + +from urllib.parse import quote_plus + +import pyodbc + +from airflow.hooks.dbapi_hook import DbApiHook + + +class MsSqlOdbcHook(DbApiHook): +""" +Interact with Microsoft SQL Server using odbc. +""" + +conn_name_attr = 'mssql_conn_id' +default_conn_name = 'mssql_default' +supports_autocommit = True + +def __init__( +self, +mssql_conn_id='mssql_default', +database=None, +schema=None, +driver=None, +dsn=None, +trx_isolation=pyodbc.SQL_TXN_READ_UNCOMMITTED, +autocommit=True, +*args, +**kwargs, +): +super(MsSqlOdbcHook, self).__init__(*args, **kwargs) +self.mssql_conn_id = mssql_conn_id +self._database = database +self._driver = driver +self._dsn = dsn +self._conn_str = None +self.schema = schema +self.autocommit = autocommit +self._conn_extra = None +self._conn_extra_lower = None +self._conn = None Review comment: i'm not sure i understand your concern? the point of the \ `_conn` attr is to store the `Connection` object under the property `conn`. that way, repeated references to it will not require going back to metastore database to retrieve the conn again. this is a fairly common pattern with hooks and operators. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551255 ## File path: airflow/providers/mssql/hooks/mssql_odbc.py ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains MS Sql Odbc hook. +""" + +from urllib.parse import quote_plus + +import pyodbc + +from airflow.hooks.dbapi_hook import DbApiHook + + +class MsSqlOdbcHook(DbApiHook): +""" +Interact with Microsoft SQL Server using odbc. +""" + +conn_name_attr = 'mssql_conn_id' +default_conn_name = 'mssql_default' +supports_autocommit = True + +def __init__( +self, +mssql_conn_id='mssql_default', +database=None, +schema=None, +driver=None, +dsn=None, +trx_isolation=pyodbc.SQL_TXN_READ_UNCOMMITTED, +autocommit=True, +*args, +**kwargs, +): +super(MsSqlOdbcHook, self).__init__(*args, **kwargs) +self.mssql_conn_id = mssql_conn_id +self._database = database +self._driver = driver +self._dsn = dsn +self._conn_str = None +self.schema = schema +self.autocommit = autocommit +self._conn_extra = None +self._conn_extra_lower = None +self._conn = None Review comment: i'm not sure i understand your concern? the point of `_conn` attr is to store the `Connection` object under the property `conn`. that way, repeated references to it will not require going back to metastore database to retrieve the conn again. this is a fairly common pattern with hooks and operators. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551255 ## File path: airflow/providers/mssql/hooks/mssql_odbc.py ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains MS Sql Odbc hook. +""" + +from urllib.parse import quote_plus + +import pyodbc + +from airflow.hooks.dbapi_hook import DbApiHook + + +class MsSqlOdbcHook(DbApiHook): +""" +Interact with Microsoft SQL Server using odbc. +""" + +conn_name_attr = 'mssql_conn_id' +default_conn_name = 'mssql_default' +supports_autocommit = True + +def __init__( +self, +mssql_conn_id='mssql_default', +database=None, +schema=None, +driver=None, +dsn=None, +trx_isolation=pyodbc.SQL_TXN_READ_UNCOMMITTED, +autocommit=True, +*args, +**kwargs, +): +super(MsSqlOdbcHook, self).__init__(*args, **kwargs) +self.mssql_conn_id = mssql_conn_id +self._database = database +self._driver = driver +self._dsn = dsn +self._conn_str = None +self.schema = schema +self.autocommit = autocommit +self._conn_extra = None +self._conn_extra_lower = None +self._conn = None Review comment: i'm not sure i understand your concern? the point of the `_conn` attr is to store the `Connection` object under the property `conn`. that way, repeated references to it will not require going back to metastore database to retrieve the conn again. this is a fairly common pattern with hooks and operators. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551255 ## File path: airflow/providers/mssql/hooks/mssql_odbc.py ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains MS Sql Odbc hook. +""" + +from urllib.parse import quote_plus + +import pyodbc + +from airflow.hooks.dbapi_hook import DbApiHook + + +class MsSqlOdbcHook(DbApiHook): +""" +Interact with Microsoft SQL Server using odbc. +""" + +conn_name_attr = 'mssql_conn_id' +default_conn_name = 'mssql_default' +supports_autocommit = True + +def __init__( +self, +mssql_conn_id='mssql_default', +database=None, +schema=None, +driver=None, +dsn=None, +trx_isolation=pyodbc.SQL_TXN_READ_UNCOMMITTED, +autocommit=True, +*args, +**kwargs, +): +super(MsSqlOdbcHook, self).__init__(*args, **kwargs) +self.mssql_conn_id = mssql_conn_id +self._database = database +self._driver = driver +self._dsn = dsn +self._conn_str = None +self.schema = schema +self.autocommit = autocommit +self._conn_extra = None +self._conn_extra_lower = None +self._conn = None Review comment: i'm not sure i understand your concern? the point of this attribute is to store the `Connection` object under the property `conn`. that way, repeated references to it will not require going back to metastore database to retrieve the conn again. this is a fairly common pattern with hooks and operators. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6919: [AIRFLOW-6365] Remove tests/compat
codecov-io edited a comment on issue #6919: [AIRFLOW-6365] Remove tests/compat URL: https://github.com/apache/airflow/pull/6919#issuecomment-569152620 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=h1) Report > Merging [#6919](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6919 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=footer). Last update [6fffa5b...97b0262](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6919: [AIRFLOW-6365] Remove tests/compat
codecov-io edited a comment on issue #6919: [AIRFLOW-6365] Remove tests/compat URL: https://github.com/apache/airflow/pull/6919#issuecomment-569152620 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=h1) Report > Merging [#6919](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6919 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=footer). Last update [6fffa5b...97b0262](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6919: [AIRFLOW-6365] Remove tests/compat
codecov-io commented on issue #6919: [AIRFLOW-6365] Remove tests/compat URL: https://github.com/apache/airflow/pull/6919#issuecomment-569152620 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=h1) Report > Merging [#6919](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#6919 +/- ## === Coverage 84.72% 84.72% === Files 679 679 Lines 3850538505 === Hits3262332623 Misses 5882 5882 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=footer). Last update [6fffa5b...97b0262](https://codecov.io/gh/apache/airflow/pull/6919?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551629 ## File path: setup.py ## @@ -275,6 +275,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])): ] mssql = [ 'pymssql~=2.1.1', +'pyodbc', Review comment: i think it's appropriate to specify the library in this case. there are a number of different ways to connect to mssql in python, besides pymssql (cTDS, pyodbc, turbodbc, BCP) i think that operators may use one or another hook depending on the use case. e.g. if you are going to store to parquet you might want to use turbodbc. or if you are bulk output to csv you might consider BCP. executing sql maybe just pyodbc. these hooks don't exist now, but if we think ahead, perhaps it makes sense to plan for their eventual possible inclusion. that's my take, anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551629 ## File path: setup.py ## @@ -275,6 +275,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])): ] mssql = [ 'pymssql~=2.1.1', +'pyodbc', Review comment: i think it's better to be clear. there are a number of different ways to connect to mssql in python, besides pymssql (cTDS, pyodbc, turbodbc, BCP) i think it makes sense to be clear in the hook name. i think that operators may use one or another hook depending on the use case. e.g. if you are going to store to parquet you might want to use turbodbc. or if you are bulk output to csv you might consider BCP. executing sql maybe just pyodbc. these hooks don't exist now, but if we think ahead, perhaps it makes sense to plan for their eventual possible inclusion. that's my take, anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551629 ## File path: setup.py ## @@ -275,6 +275,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])): ] mssql = [ 'pymssql~=2.1.1', +'pyodbc', Review comment: i think it's appropriate to specify the library in this case. there are a number of different ways to connect to mssql in python, besides pymssql (cTDS, pyodbc, turbodbc, BCP) i think it makes sense to be clear in the hook name. i think that operators may use one or another hook depending on the use case. e.g. if you are going to store to parquet you might want to use turbodbc. or if you are bulk output to csv you might consider BCP. executing sql maybe just pyodbc. these hooks don't exist now, but if we think ahead, perhaps it makes sense to plan for their eventual possible inclusion. that's my take, anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551629 ## File path: setup.py ## @@ -275,6 +275,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])): ] mssql = [ 'pymssql~=2.1.1', +'pyodbc', Review comment: i think it's better to be clear and specify the library in this case. there are a number of different ways to connect to mssql in python, besides pymssql (cTDS, pyodbc, turbodbc, BCP) i think it makes sense to be clear in the hook name. i think that operators may use one or another hook depending on the use case. e.g. if you are going to store to parquet you might want to use turbodbc. or if you are bulk output to csv you might consider BCP. executing sql maybe just pyodbc. these hooks don't exist now, but if we think ahead, perhaps it makes sense to plan for their eventual possible inclusion. that's my take, anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551255 ## File path: airflow/providers/mssql/hooks/mssql_odbc.py ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains MS Sql Odbc hook. +""" + +from urllib.parse import quote_plus + +import pyodbc + +from airflow.hooks.dbapi_hook import DbApiHook + + +class MsSqlOdbcHook(DbApiHook): +""" +Interact with Microsoft SQL Server using odbc. +""" + +conn_name_attr = 'mssql_conn_id' +default_conn_name = 'mssql_default' +supports_autocommit = True + +def __init__( +self, +mssql_conn_id='mssql_default', +database=None, +schema=None, +driver=None, +dsn=None, +trx_isolation=pyodbc.SQL_TXN_READ_UNCOMMITTED, +autocommit=True, +*args, +**kwargs, +): +super(MsSqlOdbcHook, self).__init__(*args, **kwargs) +self.mssql_conn_id = mssql_conn_id +self._database = database +self._driver = driver +self._dsn = dsn +self._conn_str = None +self.schema = schema +self.autocommit = autocommit +self._conn_extra = None +self._conn_extra_lower = None +self._conn = None Review comment: i'm not sure what you mean? the point of this is to store the `Connection` object under the property `conn`, and that way repeated references to it will not require going back to metastore database to retrieve the conn again. this is a fairly common pattern with hooks and operators. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook
dstandish commented on a change in pull request #6850: [AIRFLOW-6296] add mssql odbc hook URL: https://github.com/apache/airflow/pull/6850#discussion_r361551255 ## File path: airflow/providers/mssql/hooks/mssql_odbc.py ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +This module contains MS Sql Odbc hook. +""" + +from urllib.parse import quote_plus + +import pyodbc + +from airflow.hooks.dbapi_hook import DbApiHook + + +class MsSqlOdbcHook(DbApiHook): +""" +Interact with Microsoft SQL Server using odbc. +""" + +conn_name_attr = 'mssql_conn_id' +default_conn_name = 'mssql_default' +supports_autocommit = True + +def __init__( +self, +mssql_conn_id='mssql_default', +database=None, +schema=None, +driver=None, +dsn=None, +trx_isolation=pyodbc.SQL_TXN_READ_UNCOMMITTED, +autocommit=True, +*args, +**kwargs, +): +super(MsSqlOdbcHook, self).__init__(*args, **kwargs) +self.mssql_conn_id = mssql_conn_id +self._database = database +self._driver = driver +self._dsn = dsn +self._conn_str = None +self.schema = schema +self.autocommit = autocommit +self._conn_extra = None +self._conn_extra_lower = None +self._conn = None Review comment: i'm not sure what you mean? the point of this is to store the `Connection` object under the property `conn`, and that way repeated references to it will not require going back to metastore database to retrieve the conn again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
nuclearpinguin commented on a change in pull request #6918: [AIRFLOW-6229]
SparkSubmitOperator polls forever if status json can't…
URL: https://github.com/apache/airflow/pull/6918#discussion_r361550963
##
File path: airflow/contrib/hooks/spark_submit_hook.py
##
@@ -449,8 +450,12 @@ def _process_spark_status_log(self, itr):
if "driverState" in line:
self._driver_status = line.split(' : ')[1] \
.replace(',', '').replace('\"', '').strip()
+driver_found = 1
Review comment:
```suggestion
driver_found = True
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
nuclearpinguin commented on a change in pull request #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't… URL: https://github.com/apache/airflow/pull/6918#discussion_r361550920 ## File path: airflow/contrib/hooks/spark_submit_hook.py ## @@ -441,6 +441,7 @@ def _process_spark_status_log(self, itr): :param itr: An iterator which iterates over the input of the subprocess """ +driver_found = 0 Review comment: ```suggestion driver_found = False ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
nuclearpinguin commented on a change in pull request #6918: [AIRFLOW-6229]
SparkSubmitOperator polls forever if status json can't…
URL: https://github.com/apache/airflow/pull/6918#discussion_r361550944
##
File path: airflow/contrib/hooks/spark_submit_hook.py
##
@@ -449,8 +450,12 @@ def _process_spark_status_log(self, itr):
if "driverState" in line:
self._driver_status = line.split(' : ')[1] \
.replace(',', '').replace('\"', '').strip()
+driver_found = 1
self.log.debug("spark driver status log: {}".format(line))
+
+if driver_found == 0:
Review comment:
```suggestion
if not driver_found:
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6905: [AIRFLOW-6361] Run LocalTaskJob directly in Celery task
codecov-io edited a comment on issue #6905: [AIRFLOW-6361] Run LocalTaskJob directly in Celery task URL: https://github.com/apache/airflow/pull/6905#issuecomment-569145791 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=h1) Report > Merging [#6905](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6905 +/- ## == - Coverage 84.72% 84.44% -0.29% == Files 679 679 Lines 3850538504 -1 == - Hits3262332514 -109 - Misses 5882 5990 +108 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (-0.08%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | | [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `96.05% <0%> (+2.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=footer). Last update [6fffa5b...9492ed9](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] tooptoop4 commented on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
tooptoop4 commented on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569151360 @nuclearpinguin k, maybe docs need update as brew install xmllint does not work on Mac but brew install libxml2 works This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [947fb64...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io commented on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [947fb64...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not…
codecov-io edited a comment on issue #6916: [AIRFLOW-6335] dag_processor_manager timeout logs should be ERROR not… URL: https://github.com/apache/airflow/pull/6916#issuecomment-569150788 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=h1) Report > Merging [#6916](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6916 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88% <100%> (ø)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6916/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=footer). Last update [6fffa5b...cf4ef94](https://codecov.io/gh/apache/airflow/pull/6916?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6914: [AIRFLOW-6364] Move conn tests from test_core to test_connection
codecov-io edited a comment on issue #6914: [AIRFLOW-6364] Move conn tests from test_core to test_connection URL: https://github.com/apache/airflow/pull/6914#issuecomment-569149783 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=h1) Report > Merging [#6914](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.51%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6914 +/- ## == - Coverage 84.72% 84.21% -0.52% == Files 679 679 Lines 3850538505 == - Hits3262332426 -197 - Misses 5882 6079 +197 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `89.83% <0%> (-6.78%)` | :arrow_down: | | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `76.08% <0%> (-1.53%)` | :arrow_down: | | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `67.8% <0%> (-0.98%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=footer). Last update [6fffa5b...59b48db](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6914: [AIRFLOW-6364] Move conn tests from test_core to test_connection
codecov-io commented on issue #6914: [AIRFLOW-6364] Move conn tests from test_core to test_connection URL: https://github.com/apache/airflow/pull/6914#issuecomment-569149783 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=h1) Report > Merging [#6914](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.51%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6914 +/- ## == - Coverage 84.72% 84.21% -0.52% == Files 679 679 Lines 3850538505 == - Hits3262332426 -197 - Misses 5882 6079 +197 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | | [airflow/utils/sqlalchemy.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy91dGlscy9zcWxhbGNoZW15LnB5) | `89.83% <0%> (-6.78%)` | :arrow_down: | | [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `76.08% <0%> (-1.53%)` | :arrow_down: | | [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `67.8% <0%> (-0.98%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=footer). Last update [6fffa5b...59b48db](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6914: [AIRFLOW-6364] Move conn tests from test_core to test_connection
codecov-io edited a comment on issue #6914: [AIRFLOW-6364] Move conn tests from test_core to test_connection URL: https://github.com/apache/airflow/pull/6914#issuecomment-569149783 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=h1) Report > Merging [#6914](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6914 +/- ## == - Coverage 84.72% 84.43% -0.29% == Files 679 679 Lines 3850538505 == - Hits3262332513 -110 - Misses 5882 5992 +110 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6914/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=footer). Last update [6fffa5b...59b48db](https://codecov.io/gh/apache/airflow/pull/6914?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-3964) Consolidate and de-duplicate sensor tasks in newly created Operator
[
https://issues.apache.org/jira/browse/AIRFLOW-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yingbo Wang updated AIRFLOW-3964:
-
Summary: Consolidate and de-duplicate sensor tasks in newly created
Operator (was: Reduce duplicated tasks and optimize with scheduler embedded
sensor )
> Consolidate and de-duplicate sensor tasks in newly created Operator
> ---
>
> Key: AIRFLOW-3964
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3964
> Project: Apache Airflow
> Issue Type: Improvement
> Components: dependencies, operators, scheduler
>Affects Versions: 1.10.0
>Reporter: Yingbo Wang
>Assignee: Yingbo Wang
>Priority: Critical
>
> h2. Problem
> h3. Airflow Sensor:
> Sensors are a certain type of operator that will keep running until a certain
> criterion is met. Examples include a specific file landing in HDFS or S3, a
> partition appearing in Hive, or a specific time of the day. Sensors are
> derived from BaseSensorOperator and run a poke method at a specified
> poke_interval until it returns True.
> Airflow Sensor duplication is a normal problem for large scale airflow
> project. There are duplicated partitions needing to be detected from
> same/different DAG. In Airbnb there are 88 boxes running four different types
> of sensors everyday. The number of running sensor tasks ranges from 8k to
> 16k, which takes great amount of resources. Although Airflow team had
> redirected all sensors to a specific queue to allocate relatively minor
> resource, there is still large room to reduce the number of workers and
> relief DB pressure by optimizing the sensor mechanism.
> Existing sensor implementation creates an identical task for any sensor task
> with specific dag_id, task_id and execution_date. This task is responsible of
> keeping querying DB until the specified partitions exists. Even if two tasks
> are waiting for same partition in DB, they are creating two connections with
> the DB and checking the status in two separate processes. In one hand, DB
> need to run duplicate jobs in multiple processes which will take both cpu and
> memory resources. At the same time, Airflow need to maintain a process for
> each sensor to query and wait for the partition/table to be created.
> h1. ***Design*
> There are several issues need to be resolved for our smart sensor.
> h2. Persist sensor infor in DB and avoid file parsing before running
> Current Airflow implementation need to parse the DAG python file before
> running a task. Parsing multiple python file in a smart sensor make the case
> low efficiency and overload. Since sensor tasks need relatively more “light
> weight” executing information -- less number of properties with simple
> structure (most are built in type instead of function or object). We propose
> to skip the parsing for smart sensor. The easiest way is to persist all task
> instance information in airflow metaDB.
> h3. Solution:
> It will be hard to dump the whole task instance object dictionary. And we do
> not really need that much information.
> We add two sets to the base sensor class as “persist_fields” and
> “execute_fields”.
> h4. “persist_fields” dump to airflow.task_instance column “attr_dict”
> saves the attribute names that should be used to accomplish a sensor poking
> job. For example:
> # the “NamedHivePartitionSensor” define its persist_fields as
> ('partition_names', 'metastore_conn_id', 'hook') since these properties are
> enough for its poking function.
> # While the HivePartitionSensor can be slightly different use persist_fields
> as ('schema', 'table', 'partition', 'metastore_conn_id')
> If we have two tasks that have same property value for all field in
> persist_fields. That means these two tasks are poking the same item and they
> are holding duplicate poking jobs in senser.
> *The persist_fields can help us in deduplicate sensor tasks*. In a more
> broader way. If we can list persist_fields for all operators, it can help to
> dedup all airflow tasks.
> h4. “Execute_fields” dump to airflow.task_instance column “exec_dict”
> Saves the execution configuration such as “poke_interval”, “timeout”,
> “execution_timeout”
> Fields in this set do not contain information affecting the poking job
> detail. They are related to how frequent should we poke, when should the task
> timeout, how many times timeout should be a fail etc. We only put those logic
> that we can easily handle in a smart sensor for now. This is a smart sensor
> “doable whitelist” and can be extended with more logic being “unlocked” by
> smart sensor implementation.
> When we initialize a task instance object. We dump the attribute value of
> these two sets and persist them in the Airflow metaDB. Smart sensor can visit
> DB
[GitHub] [airflow] codecov-io edited a comment on issue #6905: [AIRFLOW-6361] Run LocalTaskJob directly in Celery task
codecov-io edited a comment on issue #6905: [AIRFLOW-6361] Run LocalTaskJob directly in Celery task URL: https://github.com/apache/airflow/pull/6905#issuecomment-569145791 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=h1) Report > Merging [#6905](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d0fbb523d617316a35461e6ee53781a7a716092c?src=pr=desc) will **decrease** coverage by `0.18%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6905 +/- ## == - Coverage 84.62% 84.44% -0.19% == Files 679 679 Lines 3849738504 +7 == - Hits3257832514 -64 - Misses 5919 5990 +71 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.51% <100%> (-0.08%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: | | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `71.73% <0%> (ø)` | :arrow_up: | | [airflow/models/taskreschedule.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza3Jlc2NoZWR1bGUucHk=) | `100% <0%> (ø)` | :arrow_up: | | [airflow/configuration.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9jb25maWd1cmF0aW9uLnB5) | `92.65% <0%> (+0.05%)` | :arrow_up: | | [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `57.48% <0%> (+0.09%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6905/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=footer). Last update [d0fbb52...9492ed9](https://codecov.io/gh/apache/airflow/pull/6905?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-6365) Remove tests/compat
[
https://issues.apache.org/jira/browse/AIRFLOW-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003809#comment-17003809
]
ASF GitHub Bot commented on AIRFLOW-6365:
-
nuclearpinguin commented on pull request #6919: [AIRFLOW-6365] Remove
tests/compat
URL: https://github.com/apache/airflow/pull/6919
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6365
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
It seems we no longer need `compat` module to preserve compatibility with
`mock`.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove tests/compat
> ---
>
> Key: AIRFLOW-6365
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6365
> Project: Apache Airflow
> Issue Type: Improvement
> Components: tests
>Affects Versions: 2.0.0
>Reporter: Tomasz Urbaszek
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] nuclearpinguin opened a new pull request #6919: [AIRFLOW-6365] Remove tests/compat
nuclearpinguin opened a new pull request #6919: [AIRFLOW-6365] Remove
tests/compat
URL: https://github.com/apache/airflow/pull/6919
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6365
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
It seems we no longer need `compat` module to preserve compatibility with
`mock`.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Work started] (AIRFLOW-6229) SparkSubmitOperator polls forever if status json can't find driverState tag
[
https://issues.apache.org/jira/browse/AIRFLOW-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-6229 started by t oo.
-
> SparkSubmitOperator polls forever if status json can't find driverState tag
> ---
>
> Key: AIRFLOW-6229
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6229
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler
>Affects Versions: 1.10.6
>Reporter: t oo
>Assignee: t oo
>Priority: Major
>
> You click ‘release’ on a new spark cluster while the prior spark cluster is
> processing some spark submits from airflow. Then airflow is never able to
> finish the sparksubmit task as it polls from status on the new spark cluster
> build which it can’t find status for as the submit happened on earlier spark
> cluster build….the status loop goes on forever
>
> [https://github.com/apache/airflow/blob/1.10.6/airflow/contrib/hooks/spark_submit_hook.py#L446]
> [https://github.com/apache/airflow/blob/1.10.6/airflow/contrib/hooks/spark_submit_hook.py#L489]
> It loops forever if it can’t find driverState tag in the json response, since
> the new build (pointed to by the released DNS name) doesn’t know about the
> driver submitted (in previously released build) then the 2nd response below
> does not contain the driverState tag.
>
> #response before clicking release on new build
> [ec2-user@reda ~]$
> curl +[http://dns:6066/v1/submissions/status/driver-20191202142207-]+
> { "action" : "SubmissionStatusResponse", "driverState" : "RUNNING",
> "serverSparkVersion" : "2.3.4", "submissionId" :
> "driver-20191202142207-", "success" : true, "workerHostPort" :
> "reda:31489", "workerId" : "worker-20191202133526-reda-31489"}
>
> #response after clicking release on new build
> [ec2-user@reda ~]$
> curl [http://dns:6066/v1/submissions/status/driver-20191202142207-]
> { "action" : "SubmissionStatusResponse", "serverSparkVersion" : "2.3.4",
> "submissionId" : "driver-20191202142207-", "success" : false
> }
>
>
> Definitely a defect in current code. Can fix this by modifying
> _process_spark_status_log function to set driver status to UNKNOWN if
> driverState is not in response after iterating all lines.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-6229) SparkSubmitOperator polls forever if status json can't find driverState tag
[
https://issues.apache.org/jira/browse/AIRFLOW-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003807#comment-17003807
]
ASF GitHub Bot commented on AIRFLOW-6229:
-
tooptoop4 commented on pull request #6918: [AIRFLOW-6229] SparkSubmitOperator
polls forever if status json can't…
URL: https://github.com/apache/airflow/pull/6918
… find driverState tag
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SparkSubmitOperator polls forever if status json can't find driverState tag
> ---
>
> Key: AIRFLOW-6229
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6229
> Project: Apache Airflow
> Issue Type: New Feature
> Components: scheduler
>Affects Versions: 1.10.6
>Reporter: t oo
>Priority: Major
>
> You click ‘release’ on a new spark cluster while the prior spark cluster is
> processing some spark submits from airflow. Then airflow is never able to
> finish the sparksubmit task as it polls from status on the new spark cluster
> build which it can’t find status for as the submit happened on earlier spark
> cluster build….the status loop goes on forever
>
> [https://github.com/apache/airflow/blob/1.10.6/airflow/contrib/hooks/spark_submit_hook.py#L446]
> [https://github.com/apache/airflow/blob/1.10.6/airflow/contrib/hooks/spark_submit_hook.py#L489]
> It loops forever if it can’t find driverState tag in the json response, since
> the new build (pointed to by the released DNS name) doesn’t know about the
> driver submitted (in previously released build) then the 2nd response below
> does not contain the driverState tag.
>
> #response before clicking release on new build
> [ec2-user@reda ~]$
> curl +[http://dns:6066/v1/submissions/status/driver-20191202142207-]+
> { "action" : "SubmissionStatusResponse", "driverState" : "RUNNING",
> "serverSparkVersion" : "2.3.4", "submissionId" :
> "driver-20191202142207-", "success" : true, "workerHostPort" :
> "reda:31489", "workerId" : "worker-20191202133526-reda-31489"}
>
> #response after clicking release on new build
> [ec2-user@reda ~]$
> curl [http://dns:6066/v1/submissions/status/driver-20191202142207-]
> { "action" : "SubmissionStatusResponse", "serverSparkVersion" : "2.3.4",
> "submissionId" : "driver-20191202142207-", "success" : false
> }
>
>
> Definitely a
[GitHub] [airflow] tooptoop4 opened a new pull request #6918: [AIRFLOW-6229] SparkSubmitOperator polls forever if status json can't…
tooptoop4 opened a new pull request #6918: [AIRFLOW-6229] SparkSubmitOperator
polls forever if status json can't…
URL: https://github.com/apache/airflow/pull/6918
… find driverState tag
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence
codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence URL: https://github.com/apache/airflow/pull/6911#issuecomment-569147830 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=h1) Report > Merging [#6911](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6911 +/- ## == + Coverage 84.72% 84.72% +<.01% == Files 679 679 Lines 3850538508 +3 == + Hits3262332626 +3 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6911/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.54% <100%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=footer). Last update [6fffa5b...95415a4](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence
codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence URL: https://github.com/apache/airflow/pull/6911#issuecomment-569147830 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=h1) Report > Merging [#6911](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6911 +/- ## == + Coverage 84.72% 84.72% +<.01% == Files 679 679 Lines 3850538508 +3 == + Hits3262332626 +3 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6911/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.54% <100%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=footer). Last update [6fffa5b...95415a4](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence
codecov-io commented on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence URL: https://github.com/apache/airflow/pull/6911#issuecomment-569147830 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=h1) Report > Merging [#6911](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/947fb64f7f16dc65a24f8d337ed1adc0fb28e464?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6911 +/- ## == + Coverage 84.72% 84.72% +<.01% == Files 679 679 Lines 3850538508 +3 == + Hits3262332626 +3 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6911/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.54% <100%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=footer). Last update [947fb64...95415a4](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence
codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence URL: https://github.com/apache/airflow/pull/6911#issuecomment-569147830 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=h1) Report > Merging [#6911](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6911 +/- ## == + Coverage 84.72% 84.72% +<.01% == Files 679 679 Lines 3850538508 +3 == + Hits3262332626 +3 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6911/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.54% <100%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=footer). Last update [6fffa5b...95415a4](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence
codecov-io edited a comment on issue #6911: [AIRFLOW-6353] security - ui - add click jacking defence URL: https://github.com/apache/airflow/pull/6911#issuecomment-569147830 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=h1) Report > Merging [#6911](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=desc) into [master](https://codecov.io/gh/apache/airflow/commit/6fffa5b0d7840727a96dc1765a0166656bc7ea52?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) ```diff @@Coverage Diff @@ ## master#6911 +/- ## == + Coverage 84.72% 84.72% +<.01% == Files 679 679 Lines 3850538508 +3 == + Hits3262332626 +3 Misses 5882 5882 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=tree) | Coverage Δ | | |---|---|---| | [airflow/www/app.py](https://codecov.io/gh/apache/airflow/pull/6911/diff?src=pr=tree#diff-YWlyZmxvdy93d3cvYXBwLnB5) | `97.54% <100%> (+0.06%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=footer). Last update [6fffa5b...95415a4](https://codecov.io/gh/apache/airflow/pull/6911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-4749) airflow connections cli - --conn_password does not allow passwords starting with dash
[ https://issues.apache.org/jira/browse/AIRFLOW-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003805#comment-17003805 ] t oo commented on AIRFLOW-4749: --- the password is dynamically generated, caller should not have to inspect+modify the password, airflow should handle it > airflow connections cli - --conn_password does not allow passwords starting > with dash > - > > Key: AIRFLOW-4749 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4749 > Project: Apache Airflow > Issue Type: Improvement > Components: cli >Affects Versions: 1.10.3 > Environment: python 2.7.15 >Reporter: t oo >Priority: Major > > h3. [connections|https://airflow.apache.org/cli.html#id30] > List/Add/Delete connections > > > If i try to add a connection in airflow cli and my password starts with dash. > ie -abc > it gives an error about only one argument allowed for --conn_password > > some background: > [https://stackoverflow.com/questions/16174992/cant-get-argparse-to-read-quoted-string-with-dashes-in-it] > > note my password reeally does start with - -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] nuclearpinguin commented on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
nuclearpinguin commented on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569147575 @tooptoop4 in Airflow we use amazing pre-commit framework that allow us to run all static analysis before committing. By using it you will eliminate need for refactoring your code and more importantly resources of our CI will be used more efficiently. https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#id4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] nuclearpinguin edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence
nuclearpinguin edited a comment on issue #6913: [AIRFLOW-6351] security - ui - Add Cross Site Scripting defence URL: https://github.com/apache/airflow/pull/6913#issuecomment-569147575 @tooptoop4 in Airflow we use amazing pre-commit framework that allow us to run all static analysis before committing. By using it you will eliminate need for refactoring your code and more importantly resources of our CI will be used more efficiently. https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#enabling-pre-commit-hooks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
