[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278067096
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278065820
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278062945
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
Review comment:
We have already discussed this in the past. Double imports in rendered file
mean that this views needs libraries several times in several views. This will
be more readable when the code will be in separate files and we could use a
["import"
statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import).
Currently, we must use such syntax.
https://github.com/apache/airflow/pull/4787#discussion_r267573261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278062663
##
File path: airflow/www/templates/airflow/task_instance.html
##
@@ -60,13 +61,15 @@
{% endblock %}
{% block tail %}
{{ super() }}
+
Review comment:
We have already discussed this in the past. Double imports in rendered file
mean that this views needs libraries several times in several views. This will
be more readable when the code will be in separate files and we could use a
["import"
statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import).
Currently, we must use such syntax.
https://github.com/apache/airflow/pull/4787#discussion_r267573261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278062598
##
File path: airflow/www/templates/airflow/gantt.html
##
@@ -46,16 +48,15 @@
{% block tail %}
{{ super() }}
+
Review comment:
We have already discussed this in the past. Double imports in rendered file
mean that this views needs libraries several times in several views. This will
be more readable when the code will be in separate files and we could use a
["import"
statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import).
Currently, we must use such syntax.
https://github.com/apache/airflow/pull/4787#discussion_r267573261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278062561
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
Review comment:
We have already discussed this in the past. Double imports in rendered file
mean that this views needs libraries several times in several views. This will
be more readable when the code will be in separate files and we could use a
["import"
statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import).
Currently, we must use such syntax.
https://github.com/apache/airflow/pull/4787#discussion_r267573261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278060268
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -357,7 +367,7 @@ DAGs
})
.on('click', function(d, i) {
if (d.count > 0)
-window.location = "{{ url_for('DagRunModelView.list')
}}?_flt_3_dag_id=" + d.dag_id + "&_flt_3_state=" + d.state;
+window.location = BASE_URL_DAG_RUN_LIST +
"?_flt_3_dag_id=" + d.dag_id + "&_flt_3_state=" + d.state;
Review comment:
I updated a PR. Thanks for suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript URL: https://github.com/apache/airflow/pull/4787#discussion_r278059913 ## File path: airflow/www/templates/airflow/tree.html ## @@ -23,6 +23,10 @@ + Review comment: I updated a PR. Now this PR use `| tojson | forceescape` to make the code more explict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript URL: https://github.com/apache/airflow/pull/4787#discussion_r278059913 ## File path: airflow/www/templates/airflow/tree.html ## @@ -23,6 +23,10 @@ + Review comment: I updated a PR. Now this PR use "| tojson | forceescape" to make the code more explict. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278058571
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
Review comment:
We have already discussed this in the past.
https://github.com/apache/airflow/pull/4787#discussion_r267573261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r278056069
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -436,7 +446,7 @@ DAGs
})
.on('click', function(d, i) {
if (d.count > 0)
-window.location = "{{
url_for('TaskInstanceModelView.list') }}?_flt_3_dag_id=" + d.dag_id +
"&_flt_3_state=" + d.state;
+window.location = BASE_URL_TASK_INSTANCES_LIST +
"?_flt_3_dag_id=" + d.dag_id + "&_flt_3_state=" + d.state;
Review comment:
I updated a PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r277660827
##
File path: airflow/www/templates/airflow/gantt.html
##
@@ -23,6 +23,8 @@
href="{{url_for('appbuilder.static',filename='datepicker/bootstrap-datepicker.css')}}"
>
+
+
Review comment:
Now the quotation mark can not appear in the name of the dag.
If I tried to do it, I got an error message.
>> airflow.exceptions.AirflowException: The key
(example_bash_operator">Awesome) has to be made of alphanumeric characters,
dashes, dots and underscores exclusively
I have changed the value of the dag_id field in a function from `views.py`
file to show this problem.
https://user-images.githubusercontent.com/12058428/56578903-05b69c00-65cf-11e9-9724-625c5599540c.png;>
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r277597088
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r277593072
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -207,14 +214,21 @@ DAGs
{% block tail %}
{{ super() }}
+
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r277592023
##
File path: airflow/www/templates/airflow/dag.html
##
@@ -322,6 +327,7 @@
{% endblock %}
{% block tail %}
{{ super() }}
+
Review comment:
We have already discussed this in the past.
https://github.com/apache/airflow/pull/4787#discussion_r267573261
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r277591515
##
File path: airflow/www/templates/airflow/gantt.html
##
@@ -23,6 +23,8 @@
href="{{url_for('appbuilder.static',filename='datepicker/bootstrap-datepicker.css')}}"
>
+
Review comment:
http://jinja.pocoo.org/docs/2.10/templates/#html-escaping
Currently, the JSON code contains quotes, so adding the next one does not
cause problems.
We have discussed this problem in the past:
https://github.com/apache/airflow/pull/4787#discussion_r265930474
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r267585002
##
File path: airflow/www/templates/airflow/dag.html
##
@@ -290,6 +294,7 @@
{% endblock %}
{% block tail %}
{{ super() }}
+
Review comment:
I guess you would like me to apply a solution similar to that presented in
the PR #4950 but this is not in my opinion the right solution. This creates one
big file that contains the major part of JS code. I would like to divide the
code into smaller parts and mark the requirements for each JS snippet to make
future refactorations easier.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r267573261
##
File path: airflow/www/templates/airflow/dag.html
##
@@ -290,6 +294,7 @@
{% endblock %}
{% block tail %}
{{ super() }}
+
Review comment:
I would prefer to deal with this problem in a separate PR. When the JS code
will be in separate files and it will be possible to introduce mechanisms that
will be much more efficient in loading the JS code. Currently, it is not
possible to implement a solution that will solve the problem completely and I
will be 100% sure. I can make another change depending on this in seperate PR,
but it creates another chain of PR. Already in the case of CSS code, we are
blocked from making changes, because the introduction of new changes involves
the necessity to fix the old problems first.
I could introduce your solution now, but it will complicate the code, which
is not in good condition.
It is worth noting that if a reference to the same JS file appears in the
HTML code, the file is only loaded once. This is a simple and easy module
loader. This is not a bad thing if you see the dependency twice in the HTML
code. This means that a given fragment is needed in two places. The browser
will provide an automatic and 100% sure way that the code will not be executed
twice. This is not a bad practice, but a simple way to ensure that the module
is loaded.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r267568275
##
File path: airflow/www/templates/airflow/dag.html
##
@@ -290,6 +294,7 @@
{% endblock %}
{% block tail %}
{{ super() }}
+
Review comment:
Currently, `tail` and` tail_js` blocks are not used correctly in our
application. So the introduction of your suggestion can be problematic, because
it is difficult to predict the order in which items are loaded.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r266221268
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -256,11 +270,7 @@ DAGs
});
var $input = $(".typeahead");
- unique_options_search = new Set([
- {% for token in auto_complete_data %}
-"{{token}}",
- {% endfor %}
-]);
+ unique_options_search = new Set(getMetaValue('tokens').split(','));
Review comment:
I created a PR: https://github.com/apache/airflow/pull/4929/files
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r265951197
##
File path: airflow/www/static/css/main.css
##
@@ -269,3 +269,10 @@ div.square {
.sd { color: #BA2121; font-style: italic } /* Literal.String.Doc */
.s2 { color: #BA2121 } /* Literal.String.Double */
.s1 { color: #BA2121 } /* Literal.String.Single */
+
+.highlight--demo-mode .s,
Review comment:
I will mention that I am working on a patch that deletes this CSS code
copied from library pygments.
https://github.com/mik-laj/incubator-airflow/pull/8/commits/90a4be93536e6cbe236856b10d0fc9c5788d371d
However, this is still in the task queue
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r265942801
##
File path: airflow/www/templates/airflow/gantt.html
##
@@ -23,6 +23,9 @@
href="{{url_for('appbuilder.static',filename='datepicker/bootstrap-datepicker.css')}}"
>
+
+
Review comment:
There is no consequence in any file. I plan to improve it in the next
change. Now there is no consistency, so you can not afford it.
Everything is displayed correctly. Jinja is intelligent enough to read our
intentions.
http://flask.pocoo.org/docs/1.0/security/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r265942801
##
File path: airflow/www/templates/airflow/gantt.html
##
@@ -23,6 +23,9 @@
href="{{url_for('appbuilder.static',filename='datepicker/bootstrap-datepicker.css')}}"
>
+
+
Review comment:
There is no consequence in any file. I plan to improve it in the next
change. Now there is no consistency, so you can not afford it.
Everything is displayed correctly. Jinja is intelligent enough to read our
intentions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r265940809
##
File path: airflow/www/static/css/main.css
##
@@ -269,3 +269,10 @@ div.square {
.sd { color: #BA2121; font-style: italic } /* Literal.String.Doc */
.s2 { color: #BA2121 } /* Literal.String.Double */
.s1 { color: #BA2121 } /* Literal.String.Single */
+
+.highlight--demo-mode .s,
Review comment:
The previous implementation did not blur any string. Probably it was
adapted to the old version of Pygments. Look at the style code for pygments a
few lines above. I note that styles s1 and s2 are at bottom, so they were
probably added later. The current version blurs the text in each case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263337590
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -256,11 +270,7 @@ DAGs
});
var $input = $(".typeahead");
- unique_options_search = new Set([
- {% for token in auto_complete_data %}
-"{{token}}",
- {% endfor %}
-]);
+ unique_options_search = new Set(getMetaValue('tokens').split(','));
Review comment:
I would like to rewrite it on Ajax to speed up page load in seperate PR. Not
everyone uses the search engine, but everyone has all the data loaded even when
there are a lot of them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263338149
##
File path: airflow/www/templates/airflow/dag_code.html
##
@@ -18,18 +18,25 @@
{% extends "airflow/dag.html" %}
{% block title %}Airflow - DAGs{% endblock %}
+{% block head_css %}
+ {{ super() }}
+
+{% endblock %}
+
{% block content %}
{{ super() }}
{{ title }}
{{ html_code|safe }}
{% endblock %}
{% block tail %}
+
{{ super() }}
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263338149
##
File path: airflow/www/templates/airflow/dag_code.html
##
@@ -18,18 +18,25 @@
{% extends "airflow/dag.html" %}
{% block title %}Airflow - DAGs{% endblock %}
+{% block head_css %}
+ {{ super() }}
+
+{% endblock %}
+
{% block content %}
{{ super() }}
{{ title }}
{{ html_code|safe }}
{% endblock %}
{% block tail %}
+
{{ super() }}
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263337590
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -256,11 +270,7 @@ DAGs
});
var $input = $(".typeahead");
- unique_options_search = new Set([
- {% for token in auto_complete_data %}
-"{{token}}",
- {% endfor %}
-]);
+ unique_options_search = new Set(getMetaValue('tokens').split(','));
Review comment:
I would like to rewrite it on Ajax to speed up page load. Not everyone uses
the search engine, but everyone has all the data loaded even when there are a
lot of them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263336587
##
File path: airflow/www/templates/airflow/dag_code.html
##
@@ -18,18 +18,25 @@
{% extends "airflow/dag.html" %}
{% block title %}Airflow - DAGs{% endblock %}
+{% block head_css %}
+ {{ super() }}
+
+{% endblock %}
+
{% block content %}
{{ super() }}
{{ title }}
{{ html_code|safe }}
{% endblock %}
{% block tail %}
+
{{ super() }}
[GitHub] [airflow] mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract Jinja directive from Javascript
mik-laj commented on a change in pull request #4787: [AIRFLOW-3967] Extract
Jinja directive from Javascript
URL: https://github.com/apache/airflow/pull/4787#discussion_r263335682
##
File path: airflow/www/templates/airflow/dag.html
##
@@ -22,6 +22,9 @@
{% block head_css %}
{{ super() }}
+
Review comment:
It would be a bit harder to add an additional attribute to html. So I will
leave the current version not to add additional complexity.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
